[jira] [Commented] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110045#comment-17110045 ] Priya Sharma commented on OFBIZ-11383: -- Thanks, Jacques. > Convert createArticleContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11383 > URL: https://issues.apache.org/jira/browse/OFBIZ-11383 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11383.patch, OFBIZ-11383.patch > > > Convert createArticleContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109400#comment-17109400 ] Jacques Le Roux commented on OFBIZ-11383: - Thanks Priay and Benjamin, I reviewed and tested based on OFBIZ-10688. I confirm what Benjamin said in Benjamin OFBIZ-10688. To be definitely closed, OFBIZ-10688 needs now OFBIZ-6705 to be done. Else, even if it works underneath, a nasty message seems that it's not OK. > Convert createArticleContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11383 > URL: https://issues.apache.org/jira/browse/OFBIZ-11383 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11383.patch, OFBIZ-11383.patch > > > Convert createArticleContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109397#comment-17109397 ] ASF subversion and git services commented on OFBIZ-11383: - Commit 6495dc7a917612a879fac8e5bb977eae71018c3a in ofbiz-framework's branch refs/heads/trunk from Priya Sharma [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=6495dc7 ] Improved: Convert createArticleContent service from mini-lang to groovy (#140) Deleted the old mini-lang service file Updated the service definitions with the new groovy methods Added the groovy implementation (with minor enhancement) (OFBIZ-11383) Co-authored-by: Priya Sharma > Convert createArticleContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11383 > URL: https://issues.apache.org/jira/browse/OFBIZ-11383 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11383.patch, OFBIZ-11383.patch > > > Convert createArticleContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17108418#comment-17108418 ] Jacques Le Roux commented on OFBIZ-11383: - Thanks Priya, I'll review soon... > Convert createArticleContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11383 > URL: https://issues.apache.org/jira/browse/OFBIZ-11383 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11383.patch, OFBIZ-11383.patch > > > Convert createArticleContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107932#comment-17107932 ] Priya Sharma commented on OFBIZ-11383: -- Sure, Jacques. I will create a PR. > Convert createArticleContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11383 > URL: https://issues.apache.org/jira/browse/OFBIZ-11383 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11383.patch, OFBIZ-11383.patch > > > Convert createArticleContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107449#comment-17107449 ] Jacques Le Roux commented on OFBIZ-11383: - Hi Priya, Benjamin, The patch fails to be applied because of changes in ContentServices.groovy. Could this be related to changes from OFBIZ-10688 ? Else could it be possible to create a PR? > Convert createArticleContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11383 > URL: https://issues.apache.org/jira/browse/OFBIZ-11383 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11383.patch, OFBIZ-11383.patch > > > Convert createArticleContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17104089#comment-17104089 ] Priya Sharma commented on OFBIZ-11383: -- Hi Jacques, I think Benjamin has already provided the updated patch with the changes he suggested. So I don't think I will do any more changes to it. > Convert createArticleContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11383 > URL: https://issues.apache.org/jira/browse/OFBIZ-11383 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11383.patch, OFBIZ-11383.patch > > > Convert createArticleContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103686#comment-17103686 ] Jacques Le Roux commented on OFBIZ-11383: - Hi Priya, Will you improve the patch? > Convert createArticleContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11383 > URL: https://issues.apache.org/jira/browse/OFBIZ-11383 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11383.patch, OFBIZ-11383.patch > > > Convert createArticleContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047635#comment-17047635 ] Jacques Le Roux commented on OFBIZ-11383: - Right, it's the [shortened version of the ternary operator|https://groovy-lang.org/operators.html#_elvis_operator]. > Convert createArticleContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11383 > URL: https://issues.apache.org/jira/browse/OFBIZ-11383 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11383.patch, OFBIZ-11383.patch > > > Convert createArticleContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047449#comment-17047449 ] Benjamin Jugl commented on OFBIZ-11383: --- I thought it was only called Evvis in a context like a=b?:c, specific to groovy, not when you use it like a = b?c:d... The correct technical term is ternary, btw. My fault. > Convert createArticleContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11383 > URL: https://issues.apache.org/jira/browse/OFBIZ-11383 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11383.patch, OFBIZ-11383.patch > > > Convert createArticleContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046965#comment-17046965 ] Jacques Le Roux commented on OFBIZ-11383: - BWT, A goo way to remember bq. Inserted trinary Operator (? : ) where possible It's Elvis ;) > Convert createArticleContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11383 > URL: https://issues.apache.org/jira/browse/OFBIZ-11383 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11383.patch, OFBIZ-11383.patch > > > Convert createArticleContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046848#comment-17046848 ] Priya Sharma commented on OFBIZ-11383: -- Wow [~bjugl], That's great learning for me. I will definitely keep these things in mind the next time I work on something. Thank you so much for the review. > Convert createArticleContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11383 > URL: https://issues.apache.org/jira/browse/OFBIZ-11383 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11383.patch, OFBIZ-11383.patch > > > Convert createArticleContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL
[
https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046659#comment-17046659
]
Benjamin Jugl commented on OFBIZ-11383:
---
Hey Priya,
I did review your patch and intorduced some changes. Here is a nearly complete
list of the changes I did:
* Variable "module" should be defined in the class, so it scope includes all
other methods that will be added in the future.
* Variables should be declared with strong typing. This makes it more readable
and better to maintain (if you do not use any types, the variables are written
into the context object of the groovies "this". That is quite cumbersome to
debug.
* "createMain.dataResourceId" was declared twice, "createMain.assocTypeId" was
not declared. "createMain.partyId" was not declared.
* "createImage.contentNam" Typo, misses an "e"
* "createImage._uploadedFile_contentType" missing entirely.
* GroovyBaseScript.groovy provides a "run service" implementation. Not sure
how the overall preferences are, but its sheer existence implies that it should
be used...
* Inserted some {} for inline if-clauses. They can be omitted but reduce
readability
* Inserted trinary Operator (? : ) where possible
* Renamed variable "map" into "result"
> Convert createArticleContent service from mini-lang to groovy DSL
> -
>
> Key: OFBIZ-11383
> URL: https://issues.apache.org/jira/browse/OFBIZ-11383
> Project: OFBiz
> Issue Type: Sub-task
> Components: content
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Priya Sharma
>Priority: Minor
> Attachments: OFBIZ-11383.patch, OFBIZ-11383.patch
>
>
> Convert createArticleContent service code from mini-lang to groovy DSL.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046149#comment-17046149 ] Priya Sharma commented on OFBIZ-11383: -- Hey Bejamin, Thanks for the review, but I guess the conversion would not fix your issue, as I was not aware of it and so did not keep that in mind. I tried to convert the exact mini-lang version to groovy keeping almost all other things as is. > Convert createArticleContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11383 > URL: https://issues.apache.org/jira/browse/OFBIZ-11383 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11383.patch > > > Convert createArticleContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045674#comment-17045674 ] Benjamin Jugl commented on OFBIZ-11383: --- Hi there. This service was subject to Issue OFBIZ-10688. Thank you for the groovy conversion. I will check it as you demanded and additionally check if the Bug of former mentioned issue is still occuring. You might already have fixed it, if not, I would gladly use your conversion as a starting point. Greetings! > Convert createArticleContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11383 > URL: https://issues.apache.org/jira/browse/OFBIZ-11383 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11383.patch > > > Convert createArticleContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044415#comment-17044415 ] Priya Sharma commented on OFBIZ-11383: -- Hello All, I have added the patch with the following changes: * Updated the service definition * Added a new service for the groovy version of it * Removed the minilang version of the service Since the service handles many cases, I would request someone to please verify the patch thoroughly, as I could not verify all the test cases, the ecommerce UI doesnot support adding images or files, only text data can be added. Please verify and let me know if I missed something. Thanks! > Convert createArticleContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11383 > URL: https://issues.apache.org/jira/browse/OFBIZ-11383 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11383.patch > > > Convert createArticleContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
