[jira] [Commented] (OFBIZ-11437) Add 2020 version of Incoterms

2020-03-06 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053153#comment-17053153
 ] 

Pierre Smits commented on OFBIZ-11437:
--

Jacques, 

That discussion/vote was prior to this ticket, and regarding a different 
subject. And IMO didn't give a pass to have any improvement back ported to the 
r17.12 branch.

> Add 2020 version of Incoterms
> -
>
> Key: OFBIZ-11437
> URL: https://issues.apache.org/jira/browse/OFBIZ-11437
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Reporter: Daniel Watford
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 18.12.01, 17.12.02
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> PartySeedData.xml includes a number of TermType entries corresponding to 
> Incoterms ([https://en.wikipedia.org/wiki/Incoterms])
> Incoterms 2020 came into effect on January 1st 2020 
> ([https://iccwbo.org/resources-for-business/incoterms-rules/]) but all other 
> versions of Incoterms remain valid as long as both parties to a 
> contract/agreement agree on the version in force.
> The Incoterms listed in PartySeedData are out of date and also appear to be 
> dated from the 2010 and 2000 version of Incoterms.
> This ticket is for the updating of PartySeedData to include the 2020 
> Incoterms. Existing incoterms should be maintained with their current IDs, 
> but their parent terms and their descriptions can be altered to indicate the 
> incoterms version they refer to. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11437) Add 2020 version of Incoterms

2020-03-06 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053145#comment-17053145
 ] 

Jacques Le Roux commented on OFBIZ-11437:
-

Pierre,

This has somehow already been discussed and voted: 
https://markmail.org/message/5g4nlqrqcpooty53

> Add 2020 version of Incoterms
> -
>
> Key: OFBIZ-11437
> URL: https://issues.apache.org/jira/browse/OFBIZ-11437
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Reporter: Daniel Watford
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 18.12.01, 17.12.02
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> PartySeedData.xml includes a number of TermType entries corresponding to 
> Incoterms ([https://en.wikipedia.org/wiki/Incoterms])
> Incoterms 2020 came into effect on January 1st 2020 
> ([https://iccwbo.org/resources-for-business/incoterms-rules/]) but all other 
> versions of Incoterms remain valid as long as both parties to a 
> contract/agreement agree on the version in force.
> The Incoterms listed in PartySeedData are out of date and also appear to be 
> dated from the 2010 and 2000 version of Incoterms.
> This ticket is for the updating of PartySeedData to include the 2020 
> Incoterms. Existing incoterms should be maintained with their current IDs, 
> but their parent terms and their descriptions can be altered to indicate the 
> incoterms version they refer to. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11437) Add 2020 version of Incoterms

2020-03-05 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053115#comment-17053115
 ] 

Pierre Smits commented on OFBIZ-11437:
--

IMO, we should not have back ported this to the r17.12 branch. But rather with 
this enhancement, work towards getting the first release of 18.11 out asap.

> Add 2020 version of Incoterms
> -
>
> Key: OFBIZ-11437
> URL: https://issues.apache.org/jira/browse/OFBIZ-11437
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Reporter: Daniel Watford
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 18.12.01, 17.12.02
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> PartySeedData.xml includes a number of TermType entries corresponding to 
> Incoterms ([https://en.wikipedia.org/wiki/Incoterms])
> Incoterms 2020 came into effect on January 1st 2020 
> ([https://iccwbo.org/resources-for-business/incoterms-rules/]) but all other 
> versions of Incoterms remain valid as long as both parties to a 
> contract/agreement agree on the version in force.
> The Incoterms listed in PartySeedData are out of date and also appear to be 
> dated from the 2010 and 2000 version of Incoterms.
> This ticket is for the updating of PartySeedData to include the 2020 
> Incoterms. Existing incoterms should be maintained with their current IDs, 
> but their parent terms and their descriptions can be altered to indicate the 
> incoterms version they refer to. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11437) Add 2020 version of Incoterms

2020-03-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053114#comment-17053114
 ] 

ASF subversion and git services commented on OFBIZ-11437:
-

Commit 2981ad988eda16e6ce7fc4568f6f063b8352be9f in ofbiz-framework's branch 
refs/heads/release18.12 from Daniel Watford
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=2981ad9 ]

Improved: Add 2020 version of Incoterms

(OFBIZ-11437)

Alter the parent type and descriptions of existing Incoterm TermTypes to
indicate the version of Incoterms they relate to.

Added new Incoterm TermTypes and descriptions correspoding to the
Incoterms 2020 set.


> Add 2020 version of Incoterms
> -
>
> Key: OFBIZ-11437
> URL: https://issues.apache.org/jira/browse/OFBIZ-11437
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Reporter: Daniel Watford
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 18.12.01, 17.12.02
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> PartySeedData.xml includes a number of TermType entries corresponding to 
> Incoterms ([https://en.wikipedia.org/wiki/Incoterms])
> Incoterms 2020 came into effect on January 1st 2020 
> ([https://iccwbo.org/resources-for-business/incoterms-rules/]) but all other 
> versions of Incoterms remain valid as long as both parties to a 
> contract/agreement agree on the version in force.
> The Incoterms listed in PartySeedData are out of date and also appear to be 
> dated from the 2010 and 2000 version of Incoterms.
> This ticket is for the updating of PartySeedData to include the 2020 
> Incoterms. Existing incoterms should be maintained with their current IDs, 
> but their parent terms and their descriptions can be altered to indicate the 
> incoterms version they refer to. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11437) Add 2020 version of Incoterms

2020-03-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053113#comment-17053113
 ] 

ASF subversion and git services commented on OFBIZ-11437:
-

Commit 0355006c62e33eac0867e2be88ffb435941830d4 in ofbiz-framework's branch 
refs/heads/release17.12 from Daniel Watford
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=0355006 ]

Improved: Add 2020 version of Incoterms
(OFBIZ-11437)

Alter the parent type and descriptions of existing Incoterm TermTypes to
indicate the version of Incoterms they relate to.

Added new Incoterm TermTypes and descriptions correspoding to the
Incoterms 2020 set.

Conflicts handled by hand:
applications/datamodel/data/seed/PartySeedData.xml
applications/party/config/PartyEntityLabels.xml


> Add 2020 version of Incoterms
> -
>
> Key: OFBIZ-11437
> URL: https://issues.apache.org/jira/browse/OFBIZ-11437
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Reporter: Daniel Watford
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 18.12.01, 17.12.02
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> PartySeedData.xml includes a number of TermType entries corresponding to 
> Incoterms ([https://en.wikipedia.org/wiki/Incoterms])
> Incoterms 2020 came into effect on January 1st 2020 
> ([https://iccwbo.org/resources-for-business/incoterms-rules/]) but all other 
> versions of Incoterms remain valid as long as both parties to a 
> contract/agreement agree on the version in force.
> The Incoterms listed in PartySeedData are out of date and also appear to be 
> dated from the 2010 and 2000 version of Incoterms.
> This ticket is for the updating of PartySeedData to include the 2020 
> Incoterms. Existing incoterms should be maintained with their current IDs, 
> but their parent terms and their descriptions can be altered to indicate the 
> incoterms version they refer to. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11437) Add 2020 version of Incoterms

2020-03-05 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053107#comment-17053107
 ] 

Jacques Le Roux commented on OFBIZ-11437:
-

Hi Daniel,

Indeed, sorry I missed your 1st message, looking at it... Thanks for the 
reminder...

> Add 2020 version of Incoterms
> -
>
> Key: OFBIZ-11437
> URL: https://issues.apache.org/jira/browse/OFBIZ-11437
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Reporter: Daniel Watford
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 18.12.01, 17.12.02
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> PartySeedData.xml includes a number of TermType entries corresponding to 
> Incoterms ([https://en.wikipedia.org/wiki/Incoterms])
> Incoterms 2020 came into effect on January 1st 2020 
> ([https://iccwbo.org/resources-for-business/incoterms-rules/]) but all other 
> versions of Incoterms remain valid as long as both parties to a 
> contract/agreement agree on the version in force.
> The Incoterms listed in PartySeedData are out of date and also appear to be 
> dated from the 2010 and 2000 version of Incoterms.
> This ticket is for the updating of PartySeedData to include the 2020 
> Incoterms. Existing incoterms should be maintained with their current IDs, 
> but their parent terms and their descriptions can be altered to indicate the 
> incoterms version they refer to. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11437) Add 2020 version of Incoterms

2020-03-04 Thread Daniel Watford (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051261#comment-17051261
 ] 

Daniel Watford commented on OFBIZ-11437:


[~jleroux] I don't think the changes got merged into R18 or R17 correctly.

 

Please see the commits here:

R18 - 
[https://github.com/apache/ofbiz-framework/commit/38deff91acf1b05e75dc532b3f792368c561330c]

R17 - 
[https://github.com/apache/ofbiz-framework/commit/3d9b551d65a24d4ad0554db862af5aaac110633d]

 

The changes in those commits do not contain any of the Incoterms.

> Add 2020 version of Incoterms
> -
>
> Key: OFBIZ-11437
> URL: https://issues.apache.org/jira/browse/OFBIZ-11437
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Reporter: Daniel Watford
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 18.12.01, 17.12.02
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> PartySeedData.xml includes a number of TermType entries corresponding to 
> Incoterms ([https://en.wikipedia.org/wiki/Incoterms])
> Incoterms 2020 came into effect on January 1st 2020 
> ([https://iccwbo.org/resources-for-business/incoterms-rules/]) but all other 
> versions of Incoterms remain valid as long as both parties to a 
> contract/agreement agree on the version in force.
> The Incoterms listed in PartySeedData are out of date and also appear to be 
> dated from the 2010 and 2000 version of Incoterms.
> This ticket is for the updating of PartySeedData to include the 2020 
> Incoterms. Existing incoterms should be maintained with their current IDs, 
> but their parent terms and their descriptions can be altered to indicate the 
> incoterms version they refer to. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11437) Add 2020 version of Incoterms

2020-03-04 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051256#comment-17051256
 ] 

Jacques Le Roux commented on OFBIZ-11437:
-

I finally backported, nothing was used OOTB and they can be no harm, custom 
projects will adapt if necessary...

> Add 2020 version of Incoterms
> -
>
> Key: OFBIZ-11437
> URL: https://issues.apache.org/jira/browse/OFBIZ-11437
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Reporter: Daniel Watford
>Priority: Minor
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> PartySeedData.xml includes a number of TermType entries corresponding to 
> Incoterms ([https://en.wikipedia.org/wiki/Incoterms])
> Incoterms 2020 came into effect on January 1st 2020 
> ([https://iccwbo.org/resources-for-business/incoterms-rules/]) but all other 
> versions of Incoterms remain valid as long as both parties to a 
> contract/agreement agree on the version in force.
> The Incoterms listed in PartySeedData are out of date and also appear to be 
> dated from the 2010 and 2000 version of Incoterms.
> This ticket is for the updating of PartySeedData to include the 2020 
> Incoterms. Existing incoterms should be maintained with their current IDs, 
> but their parent terms and their descriptions can be altered to indicate the 
> incoterms version they refer to. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11437) Add 2020 version of Incoterms

2020-03-04 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051253#comment-17051253
 ] 

ASF subversion and git services commented on OFBIZ-11437:
-

Commit 38deff91acf1b05e75dc532b3f792368c561330c in ofbiz-framework's branch 
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=38deff9 ]

Merge pull request #42 from danwatford/ofbiz-11437-2020-incoterms-improvement

OFBIZ-11437: Improved: Added 2020 version of Incoterms
(cherry picked from commit 7a34e9cda86f7cc8f946377a47c700d6f0b72aa8)


> Add 2020 version of Incoterms
> -
>
> Key: OFBIZ-11437
> URL: https://issues.apache.org/jira/browse/OFBIZ-11437
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Reporter: Daniel Watford
>Priority: Minor
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> PartySeedData.xml includes a number of TermType entries corresponding to 
> Incoterms ([https://en.wikipedia.org/wiki/Incoterms])
> Incoterms 2020 came into effect on January 1st 2020 
> ([https://iccwbo.org/resources-for-business/incoterms-rules/]) but all other 
> versions of Incoterms remain valid as long as both parties to a 
> contract/agreement agree on the version in force.
> The Incoterms listed in PartySeedData are out of date and also appear to be 
> dated from the 2010 and 2000 version of Incoterms.
> This ticket is for the updating of PartySeedData to include the 2020 
> Incoterms. Existing incoterms should be maintained with their current IDs, 
> but their parent terms and their descriptions can be altered to indicate the 
> incoterms version they refer to. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11437) Add 2020 version of Incoterms

2020-03-04 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051252#comment-17051252
 ] 

ASF subversion and git services commented on OFBIZ-11437:
-

Commit 3d9b551d65a24d4ad0554db862af5aaac110633d in ofbiz-framework's branch 
refs/heads/release17.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=3d9b551 ]

Merge pull request #42 from danwatford/ofbiz-11437-2020-incoterms-improvement

OFBIZ-11437: Improved: Added 2020 version of Incoterms
(cherry picked from commit 7a34e9cda86f7cc8f946377a47c700d6f0b72aa8)


> Add 2020 version of Incoterms
> -
>
> Key: OFBIZ-11437
> URL: https://issues.apache.org/jira/browse/OFBIZ-11437
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Reporter: Daniel Watford
>Priority: Minor
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> PartySeedData.xml includes a number of TermType entries corresponding to 
> Incoterms ([https://en.wikipedia.org/wiki/Incoterms])
> Incoterms 2020 came into effect on January 1st 2020 
> ([https://iccwbo.org/resources-for-business/incoterms-rules/]) but all other 
> versions of Incoterms remain valid as long as both parties to a 
> contract/agreement agree on the version in force.
> The Incoterms listed in PartySeedData are out of date and also appear to be 
> dated from the 2010 and 2000 version of Incoterms.
> This ticket is for the updating of PartySeedData to include the 2020 
> Incoterms. Existing incoterms should be maintained with their current IDs, 
> but their parent terms and their descriptions can be altered to indicate the 
> incoterms version they refer to. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11437) Add 2020 version of Incoterms

2020-03-04 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051243#comment-17051243
 ] 

ASF subversion and git services commented on OFBIZ-11437:
-

Commit bbd570ad2234b739481f1933bc64af9140821606 in ofbiz-framework's branch 
refs/heads/trunk from Daniel Watford
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=bbd570a ]

Improved: Add 2020 version of Incoterms

(OFBIZ-11437)

Alter the parent type and descriptions of existing Incoterm TermTypes to
indicate the version of Incoterms they relate to.

Added new Incoterm TermTypes and descriptions correspoding to the
Incoterms 2020 set.


> Add 2020 version of Incoterms
> -
>
> Key: OFBIZ-11437
> URL: https://issues.apache.org/jira/browse/OFBIZ-11437
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Reporter: Daniel Watford
>Priority: Minor
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> PartySeedData.xml includes a number of TermType entries corresponding to 
> Incoterms ([https://en.wikipedia.org/wiki/Incoterms])
> Incoterms 2020 came into effect on January 1st 2020 
> ([https://iccwbo.org/resources-for-business/incoterms-rules/]) but all other 
> versions of Incoterms remain valid as long as both parties to a 
> contract/agreement agree on the version in force.
> The Incoterms listed in PartySeedData are out of date and also appear to be 
> dated from the 2010 and 2000 version of Incoterms.
> This ticket is for the updating of PartySeedData to include the 2020 
> Incoterms. Existing incoterms should be maintained with their current IDs, 
> but their parent terms and their descriptions can be altered to indicate the 
> incoterms version they refer to. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11437) Add 2020 version of Incoterms

2020-03-04 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051244#comment-17051244
 ] 

ASF subversion and git services commented on OFBIZ-11437:
-

Commit 7a34e9cda86f7cc8f946377a47c700d6f0b72aa8 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=7a34e9c ]

Merge pull request #42 from danwatford/ofbiz-11437-2020-incoterms-improvement

OFBIZ-11437: Improved: Added 2020 version of Incoterms

> Add 2020 version of Incoterms
> -
>
> Key: OFBIZ-11437
> URL: https://issues.apache.org/jira/browse/OFBIZ-11437
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Reporter: Daniel Watford
>Priority: Minor
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> PartySeedData.xml includes a number of TermType entries corresponding to 
> Incoterms ([https://en.wikipedia.org/wiki/Incoterms])
> Incoterms 2020 came into effect on January 1st 2020 
> ([https://iccwbo.org/resources-for-business/incoterms-rules/]) but all other 
> versions of Incoterms remain valid as long as both parties to a 
> contract/agreement agree on the version in force.
> The Incoterms listed in PartySeedData are out of date and also appear to be 
> dated from the 2010 and 2000 version of Incoterms.
> This ticket is for the updating of PartySeedData to include the 2020 
> Incoterms. Existing incoterms should be maintained with their current IDs, 
> but their parent terms and their descriptions can be altered to indicate the 
> incoterms version they refer to. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11437) Add 2020 version of Incoterms

2020-03-04 Thread Daniel Watford (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051201#comment-17051201
 ] 

Daniel Watford commented on OFBIZ-11437:


Should we backport as well seeing as by the time R18 is released we will be 
well beyond the date Incoterms 2020 came into effect?

> Add 2020 version of Incoterms
> -
>
> Key: OFBIZ-11437
> URL: https://issues.apache.org/jira/browse/OFBIZ-11437
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Reporter: Daniel Watford
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> PartySeedData.xml includes a number of TermType entries corresponding to 
> Incoterms ([https://en.wikipedia.org/wiki/Incoterms])
> Incoterms 2020 came into effect on January 1st 2020 
> ([https://iccwbo.org/resources-for-business/incoterms-rules/]) but all other 
> versions of Incoterms remain valid as long as both parties to a 
> contract/agreement agree on the version in force.
> The Incoterms listed in PartySeedData are out of date and also appear to be 
> dated from the 2010 and 2000 version of Incoterms.
> This ticket is for the updating of PartySeedData to include the 2020 
> Incoterms. Existing incoterms should be maintained with their current IDs, 
> but their parent terms and their descriptions can be altered to indicate the 
> incoterms version they refer to. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11437) Add 2020 version of Incoterms

2020-03-04 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051162#comment-17051162
 ] 

Pierre Smits commented on OFBIZ-11437:
--

Then we should consider it for merging (if acceptable). No need to have it 
gowing stale.

> Add 2020 version of Incoterms
> -
>
> Key: OFBIZ-11437
> URL: https://issues.apache.org/jira/browse/OFBIZ-11437
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Reporter: Daniel Watford
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> PartySeedData.xml includes a number of TermType entries corresponding to 
> Incoterms ([https://en.wikipedia.org/wiki/Incoterms])
> Incoterms 2020 came into effect on January 1st 2020 
> ([https://iccwbo.org/resources-for-business/incoterms-rules/]) but all other 
> versions of Incoterms remain valid as long as both parties to a 
> contract/agreement agree on the version in force.
> The Incoterms listed in PartySeedData are out of date and also appear to be 
> dated from the 2010 and 2000 version of Incoterms.
> This ticket is for the updating of PartySeedData to include the 2020 
> Incoterms. Existing incoterms should be maintained with their current IDs, 
> but their parent terms and their descriptions can be altered to indicate the 
> incoterms version they refer to. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11437) Add 2020 version of Incoterms

2020-03-04 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051138#comment-17051138
 ] 

Jacques Le Roux commented on OFBIZ-11437:
-

Nope

> Add 2020 version of Incoterms
> -
>
> Key: OFBIZ-11437
> URL: https://issues.apache.org/jira/browse/OFBIZ-11437
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Reporter: Daniel Watford
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> PartySeedData.xml includes a number of TermType entries corresponding to 
> Incoterms ([https://en.wikipedia.org/wiki/Incoterms])
> Incoterms 2020 came into effect on January 1st 2020 
> ([https://iccwbo.org/resources-for-business/incoterms-rules/]) but all other 
> versions of Incoterms remain valid as long as both parties to a 
> contract/agreement agree on the version in force.
> The Incoterms listed in PartySeedData are out of date and also appear to be 
> dated from the 2010 and 2000 version of Incoterms.
> This ticket is for the updating of PartySeedData to include the 2020 
> Incoterms. Existing incoterms should be maintained with their current IDs, 
> but their parent terms and their descriptions can be altered to indicate the 
> incoterms version they refer to. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11437) Add 2020 version of Incoterms

2020-03-04 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051119#comment-17051119
 ] 

Pierre Smits commented on OFBIZ-11437:
--

[~jleroux],

Is it already incorporated in the codebase?

> Add 2020 version of Incoterms
> -
>
> Key: OFBIZ-11437
> URL: https://issues.apache.org/jira/browse/OFBIZ-11437
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Reporter: Daniel Watford
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> PartySeedData.xml includes a number of TermType entries corresponding to 
> Incoterms ([https://en.wikipedia.org/wiki/Incoterms])
> Incoterms 2020 came into effect on January 1st 2020 
> ([https://iccwbo.org/resources-for-business/incoterms-rules/]) but all other 
> versions of Incoterms remain valid as long as both parties to a 
> contract/agreement agree on the version in force.
> The Incoterms listed in PartySeedData are out of date and also appear to be 
> dated from the 2010 and 2000 version of Incoterms.
> This ticket is for the updating of PartySeedData to include the 2020 
> Incoterms. Existing incoterms should be maintained with their current IDs, 
> but their parent terms and their descriptions can be altered to indicate the 
> incoterms version they refer to. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11437) Add 2020 version of Incoterms

2020-03-04 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17050986#comment-17050986
 ] 

Jacques Le Roux commented on OFBIZ-11437:
-

Pierre,

I'll  use the work already done by Daniel. You may  create a Jira to move the 
data...

> Add 2020 version of Incoterms
> -
>
> Key: OFBIZ-11437
> URL: https://issues.apache.org/jira/browse/OFBIZ-11437
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Reporter: Daniel Watford
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> PartySeedData.xml includes a number of TermType entries corresponding to 
> Incoterms ([https://en.wikipedia.org/wiki/Incoterms])
> Incoterms 2020 came into effect on January 1st 2020 
> ([https://iccwbo.org/resources-for-business/incoterms-rules/]) but all other 
> versions of Incoterms remain valid as long as both parties to a 
> contract/agreement agree on the version in force.
> The Incoterms listed in PartySeedData are out of date and also appear to be 
> dated from the 2010 and 2000 version of Incoterms.
> This ticket is for the updating of PartySeedData to include the 2020 
> Incoterms. Existing incoterms should be maintained with their current IDs, 
> but their parent terms and their descriptions can be altered to indicate the 
> incoterms version they refer to. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11437) Add 2020 version of Incoterms

2020-03-03 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17050524#comment-17050524
 ] 

Pierre Smits commented on OFBIZ-11437:
--

The same can be done in the Order component, when creating a new order. After 
you have added a product, and click on 'finalize' you'll be step through 
various options until you get to the 'Order Terms'.

> Add 2020 version of Incoterms
> -
>
> Key: OFBIZ-11437
> URL: https://issues.apache.org/jira/browse/OFBIZ-11437
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Reporter: Daniel Watford
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> PartySeedData.xml includes a number of TermType entries corresponding to 
> Incoterms ([https://en.wikipedia.org/wiki/Incoterms])
> Incoterms 2020 came into effect on January 1st 2020 
> ([https://iccwbo.org/resources-for-business/incoterms-rules/]) but all other 
> versions of Incoterms remain valid as long as both parties to a 
> contract/agreement agree on the version in force.
> The Incoterms listed in PartySeedData are out of date and also appear to be 
> dated from the 2010 and 2000 version of Incoterms.
> This ticket is for the updating of PartySeedData to include the 2020 
> Incoterms. Existing incoterms should be maintained with their current IDs, 
> but their parent terms and their descriptions can be altered to indicate the 
> incoterms version they refer to. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11437) Add 2020 version of Incoterms

2020-03-03 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17050519#comment-17050519
 ] 

Pierre Smits commented on OFBIZ-11437:
--

[~danwatford],

Indeed. That is why you can create an agreement in the Accounting component, 
see https://demo-trunk.ofbiz.apache.org/accounting/control/FindAgreement.

When you go to 
https://demo-trunk.ofbiz.apache.org/accounting/control/EditAgreementTerms?agreementId=AGR_SALES,
 you can select a.o. the incoterms.

> Add 2020 version of Incoterms
> -
>
> Key: OFBIZ-11437
> URL: https://issues.apache.org/jira/browse/OFBIZ-11437
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Reporter: Daniel Watford
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> PartySeedData.xml includes a number of TermType entries corresponding to 
> Incoterms ([https://en.wikipedia.org/wiki/Incoterms])
> Incoterms 2020 came into effect on January 1st 2020 
> ([https://iccwbo.org/resources-for-business/incoterms-rules/]) but all other 
> versions of Incoterms remain valid as long as both parties to a 
> contract/agreement agree on the version in force.
> The Incoterms listed in PartySeedData are out of date and also appear to be 
> dated from the 2010 and 2000 version of Incoterms.
> This ticket is for the updating of PartySeedData to include the 2020 
> Incoterms. Existing incoterms should be maintained with their current IDs, 
> but their parent terms and their descriptions can be altered to indicate the 
> incoterms version they refer to. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11437) Add 2020 version of Incoterms

2020-03-03 Thread Daniel Watford (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17050500#comment-17050500
 ] 

Daniel Watford commented on OFBIZ-11437:


[~pierresmits] - possibly, but I can also see a weak argument that Agreements 
exist between parties.

I poked around placing an order but couldn't see where terms would be applied. 
For my particular use case Incoterms are more relevant to an Order, so that 
would be a good place to seed them if appropriate.

I couldn't find anything using incoterms in ofbiz-framework or ofbiz-plugins, 
and don't yet have a good understanding about how Agreements are used and 
whether they drive any behaviour in Ofbiz. So I decided to stay with the status 
quo and add/modify incoterms in their current location.

If we get agreement on the content of these changes we can move the content to 
an alternative data seed and label files at a later date.

> Add 2020 version of Incoterms
> -
>
> Key: OFBIZ-11437
> URL: https://issues.apache.org/jira/browse/OFBIZ-11437
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Reporter: Daniel Watford
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> PartySeedData.xml includes a number of TermType entries corresponding to 
> Incoterms ([https://en.wikipedia.org/wiki/Incoterms])
> Incoterms 2020 came into effect on January 1st 2020 
> ([https://iccwbo.org/resources-for-business/incoterms-rules/]) but all other 
> versions of Incoterms remain valid as long as both parties to a 
> contract/agreement agree on the version in force.
> The Incoterms listed in PartySeedData are out of date and also appear to be 
> dated from the 2010 and 2000 version of Incoterms.
> This ticket is for the updating of PartySeedData to include the 2020 
> Incoterms. Existing incoterms should be maintained with their current IDs, 
> but their parent terms and their descriptions can be altered to indicate the 
> incoterms version they refer to. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11437) Add 2020 version of Incoterms

2020-03-03 Thread Daniel Watford (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17050498#comment-17050498
 ] 

Daniel Watford commented on OFBIZ-11437:


The following site was used to determine the year for each of the incoterms 
that already existed in Ofbiz - 
[http://www.esandis.com/uk/import_export_training/historical_incoterms.php#]

> Add 2020 version of Incoterms
> -
>
> Key: OFBIZ-11437
> URL: https://issues.apache.org/jira/browse/OFBIZ-11437
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Reporter: Daniel Watford
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> PartySeedData.xml includes a number of TermType entries corresponding to 
> Incoterms ([https://en.wikipedia.org/wiki/Incoterms])
> Incoterms 2020 came into effect on January 1st 2020 
> ([https://iccwbo.org/resources-for-business/incoterms-rules/]) but all other 
> versions of Incoterms remain valid as long as both parties to a 
> contract/agreement agree on the version in force.
> The Incoterms listed in PartySeedData are out of date and also appear to be 
> dated from the 2010 and 2000 version of Incoterms.
> This ticket is for the updating of PartySeedData to include the 2020 
> Incoterms. Existing incoterms should be maintained with their current IDs, 
> but their parent terms and their descriptions can be altered to indicate the 
> incoterms version they refer to. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11437) Add 2020 version of Incoterms

2020-03-03 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17050497#comment-17050497
 ] 

Pierre Smits commented on OFBIZ-11437:
--

This seems to be more related to agreements and/or orders and would it therefor 
be more suited to be in the order component.

Wouldn't you agree?

> Add 2020 version of Incoterms
> -
>
> Key: OFBIZ-11437
> URL: https://issues.apache.org/jira/browse/OFBIZ-11437
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Reporter: Daniel Watford
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> PartySeedData.xml includes a number of TermType entries corresponding to 
> Incoterms ([https://en.wikipedia.org/wiki/Incoterms])
> Incoterms 2020 came into effect on January 1st 2020 
> ([https://iccwbo.org/resources-for-business/incoterms-rules/]) but all other 
> versions of Incoterms remain valid as long as both parties to a 
> contract/agreement agree on the version in force.
> The Incoterms listed in PartySeedData are out of date and also appear to be 
> dated from the 2010 and 2000 version of Incoterms.
> This ticket is for the updating of PartySeedData to include the 2020 
> Incoterms. Existing incoterms should be maintained with their current IDs, 
> but their parent terms and their descriptions can be altered to indicate the 
> incoterms version they refer to. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)