[jira] [Commented] (OFBIZ-11491) Convert createPaymentAndApplicationForParty service from mini-lang to groovy DSL

2020-05-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114673#comment-17114673
 ] 

ASF subversion and git services commented on OFBIZ-11491:
-

Commit 9e194b0e9ae0ada8ef2f0078f4dc6b71ecc922c6 in ofbiz-framework's branch 
refs/heads/trunk from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=9e194b0 ]

Improved: Converted createPaymentAndApplicationForParty service from mini-lang 
to groovy
(OFBIZ-11491)
Thanks Devanshu Vyas for reporting and Sourabh Punyani for providing the patch.


> Convert createPaymentAndApplicationForParty service from mini-lang to groovy 
> DSL
> 
>
> Key: OFBIZ-11491
> URL: https://issues.apache.org/jira/browse/OFBIZ-11491
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-11491.patch, OFBIZ-11491.patch
>
>
> Convert the createPaymentAndApplicationForParty service code from mini-lang 
> to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11491) Convert createPaymentAndApplicationForParty service from mini-lang to groovy DSL

2020-05-23 Thread Sourabh Punyani (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114659#comment-17114659
 ] 

Sourabh Punyani commented on OFBIZ-11491:
-

Hello [~surajk],

The patch you have provided looks fine to me. Thanks for updating it.

> Convert createPaymentAndApplicationForParty service from mini-lang to groovy 
> DSL
> 
>
> Key: OFBIZ-11491
> URL: https://issues.apache.org/jira/browse/OFBIZ-11491
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-11491.patch, OFBIZ-11491.patch
>
>
> Convert the createPaymentAndApplicationForParty service code from mini-lang 
> to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11491) Convert createPaymentAndApplicationForParty service from mini-lang to groovy DSL

2020-05-23 Thread Suraj Khurana (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114633#comment-17114633
 ] 

Suraj Khurana commented on OFBIZ-11491:
---

Hello Sourabh,

I have updated the patch as it was throwing some errors related to missing 
context and properties on groovy file on testIntegration.

Could you please check and confirm it once again?

Thanks !!

 

> Convert createPaymentAndApplicationForParty service from mini-lang to groovy 
> DSL
> 
>
> Key: OFBIZ-11491
> URL: https://issues.apache.org/jira/browse/OFBIZ-11491
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-11491.patch, OFBIZ-11491.patch
>
>
> Convert the createPaymentAndApplicationForParty service code from mini-lang 
> to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11491) Convert createPaymentAndApplicationForParty service from mini-lang to groovy DSL

2020-04-25 Thread Sourabh Punyani (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092188#comment-17092188
 ] 

Sourabh Punyani commented on OFBIZ-11491:
-

Hello Devanshu,

I have added a patch (OFBIZ-11491.patch) for the same.

Please verify.

> Convert createPaymentAndApplicationForParty service from mini-lang to groovy 
> DSL
> 
>
> Key: OFBIZ-11491
> URL: https://issues.apache.org/jira/browse/OFBIZ-11491
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Sourabh Punyani
>Priority: Minor
> Attachments: OFBIZ-11491.patch
>
>
> Convert the createPaymentAndApplicationForParty service code from mini-lang 
> to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)