[jira] [Commented] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal
[
https://issues.apache.org/jira/browse/OFBIZ-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159938#comment-17159938
]
Nicolas Malin commented on OFBIZ-11743:
---
[~uHeidfeld] I'm a few disturbed, you example work fine on my local. However,
when you give some parameters to an url it's stronger recommended to use
element parameter.
!Capture d’écran de 2020-07-17 15-45-00.png!
> Multiple menu item link parameters get lost if link type is layered-modal
> -
>
> Key: OFBIZ-11743
> URL: https://issues.apache.org/jira/browse/OFBIZ-11743
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Release Branch 18.12, 17.12.03, Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Labels: Modal, link, menu, menu-item
> Attachments: Capture d’écran de 2020-05-29 17-11-58.png, Capture
> d’écran de 2020-07-17 15-45-00.png
>
>
> I got problems by opening a modal via menu link with two parameters. Only the
> first parameter is successfully accessible in modal's screens definition.
> Investigation revealed that for a menu link of type 'layered-modal' inline
> JS-Code get created with defined action-String. This String is used to set
> following context parameters.
> The problem is, that parameter concatenating expression '&' is not encoded
> like
> {code:java}
> // .../control/uri?param1=1param2=2
> {code}
>
> My solution for this problem was to extend MacroMenuRenderer#renderLink by
> replacing
> {code:java}
> {code}
> by '&'.
> Furthermore, this method shows that submitted parameters, defined between
> menus link tags, will be ignored, if link type is 'layered-modal'. So, within
> action-String, we have to submit parameters.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal
[
https://issues.apache.org/jira/browse/OFBIZ-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126706#comment-17126706
]
Ulrich Heidfeld commented on OFBIZ-11743:
-
Hi [~nmalin],
i have spotted this issue only in menu items. For example this can be tested by
applying following changes:
{code:java}
diff --git a/framework/webtools/widget/Menus.xml
b/framework/webtools/widget/Menus.xml
index 0dab587..02f4a24 100644
--- a/framework/webtools/widget/Menus.xml
+++ b/framework/webtools/widget/Menus.xml
@@ -112,7 +112,7 @@
-
+
diff --git a/framework/webtools/widget/ServiceScreens.xml
b/framework/webtools/widget/ServiceScreens.xml
index 38f7266..d03c1ab 100644
--- a/framework/webtools/widget/ServiceScreens.xml
+++ b/framework/webtools/widget/ServiceScreens.xml
@@ -263,6 +263,8 @@
+
+
{code}
The second parameter is not available in opening modal.
> Multiple menu item link parameters get lost if link type is layered-modal
> -
>
> Key: OFBIZ-11743
> URL: https://issues.apache.org/jira/browse/OFBIZ-11743
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Release Branch 18.12, 17.12.03, Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Labels: Modal, link, menu, menu-item
> Attachments: Capture d’écran de 2020-05-29 17-11-58.png
>
>
> I got problems by opening a modal via menu link with two parameters. Only the
> first parameter is successfully accessible in modal's screens definition.
> Investigation revealed that for a menu link of type 'layered-modal' inline
> JS-Code get created with defined action-String. This String is used to set
> following context parameters.
> The problem is, that parameter concatenating expression '&' is not encoded
> like
> {code:java}
> // .../control/uri?param1=1param2=2
> {code}
>
> My solution for this problem was to extend MacroMenuRenderer#renderLink by
> replacing
> {code:java}
> {code}
> by '&'.
> Furthermore, this method shows that submitted parameters, defined between
> menus link tags, will be ignored, if link type is 'layered-modal'. So, within
> action-String, we have to submit parameters.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal
[
https://issues.apache.org/jira/browse/OFBIZ-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119696#comment-17119696
]
Nicolas Malin commented on OFBIZ-11743:
---
[~uHeidfeld], I tried to reproduce and understand to find the root, but
unsuccessfully.
I applied :
{code:patch}
diff --git a/framework/webtools/widget/ServiceScreens.xml
b/framework/webtools/widget/ServiceScreens.xml
index a3545e1305..962b3a75b6 100644
--- a/framework/webtools/widget/ServiceScreens.xml
+++ b/framework/webtools/widget/ServiceScreens.xml
@@ -238,7 +238,10 @@ under the License.
-
+
+
+
+
@@ -263,6 +266,8 @@ under the License.
+
+
{code}
But when I call the modal, the result is good.
This generate a link
{code:java}
Add
{code}
And in the modal my values are as attendee
!Capture d’écran de 2020-05-29 17-11-58.png!
Can you help me to spot the problem raise in this issue ?
> Multiple menu item link parameters get lost if link type is layered-modal
> -
>
> Key: OFBIZ-11743
> URL: https://issues.apache.org/jira/browse/OFBIZ-11743
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Release Branch 18.12, 17.12.03, Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Labels: Modal, link, menu, menu-item
> Attachments: Capture d’écran de 2020-05-29 17-11-58.png
>
>
> I got problems by opening a modal via menu link with two parameters. Only the
> first parameter is successfully accessible in modal's screens definition.
> Investigation revealed that for a menu link of type 'layered-modal' inline
> JS-Code get created with defined action-String. This String is used to set
> following context parameters.
> The problem is, that parameter concatenating expression '&' is not encoded
> like
> {code:java}
> // .../control/uri?param1=1param2=2
> {code}
>
> My solution for this problem was to extend MacroMenuRenderer#renderLink by
> replacing
> {code:java}
> {code}
> by '&'.
> Furthermore, this method shows that submitted parameters, defined between
> menus link tags, will be ignored, if link type is 'layered-modal'. So, within
> action-String, we have to submit parameters.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal
[
https://issues.apache.org/jira/browse/OFBIZ-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116716#comment-17116716
]
Ulrich Heidfeld commented on OFBIZ-11743:
-
Hi [~nmalin],
i have created a [GitHub pull
request|https://github.com/apache/ofbiz-framework/pull/163].
> Multiple menu item link parameters get lost if link type is layered-modal
> -
>
> Key: OFBIZ-11743
> URL: https://issues.apache.org/jira/browse/OFBIZ-11743
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Release Branch 18.12, 17.12.03, Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Labels: Modal, link, menu, menu-item
>
> I got problems by opening a modal via menu link with two parameters. Only the
> first parameter is successfully accessible in modal's screens definition.
> Investigation revealed that for a menu link of type 'layered-modal' inline
> JS-Code get created with defined action-String. This String is used to set
> following context parameters.
> The problem is, that parameter concatenating expression '&' is not encoded
> like
> {code:java}
> // .../control/uri?param1=1param2=2
> {code}
>
> My solution for this problem was to extend MacroMenuRenderer#renderLink by
> replacing
> {code:java}
> {code}
> by '&'.
> Furthermore, this method shows that submitted parameters, defined between
> menus link tags, will be ignored, if link type is 'layered-modal'. So, within
> action-String, we have to submit parameters.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal
[
https://issues.apache.org/jira/browse/OFBIZ-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116708#comment-17116708
]
Pierre Smits commented on OFBIZ-11743:
--
Manually added link to PR.
> Multiple menu item link parameters get lost if link type is layered-modal
> -
>
> Key: OFBIZ-11743
> URL: https://issues.apache.org/jira/browse/OFBIZ-11743
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Release Branch 18.12, 17.12.03, Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Labels: Modal, link, menu, menu-item
>
> I got problems by opening a modal via menu link with two parameters. Only the
> first parameter is successfully accessible in modal's screens definition.
> Investigation revealed that for a menu link of type 'layered-modal' inline
> JS-Code get created with defined action-String. This String is used to set
> following context parameters.
> The problem is, that parameter concatenating expression '&' is not encoded
> like
> {code:java}
> // .../control/uri?param1=1param2=2
> {code}
>
> My solution for this problem was to extend MacroMenuRenderer#renderLink by
> replacing
> {code:java}
> {code}
> by '&'.
> Furthermore, this method shows that submitted parameters, defined between
> menus link tags, will be ignored, if link type is 'layered-modal'. So, within
> action-String, we have to submit parameters.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal
[
https://issues.apache.org/jira/browse/OFBIZ-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116703#comment-17116703
]
Pierre Smits commented on OFBIZ-11743:
--
HI [~nmalin],
A PR exists. See https://github.com/apache/ofbiz-framework/pull/163.
Unfortunately, it is not listed under links (which normally happens when
everything is ok). Maybe there is some delay happening.
> Multiple menu item link parameters get lost if link type is layered-modal
> -
>
> Key: OFBIZ-11743
> URL: https://issues.apache.org/jira/browse/OFBIZ-11743
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Release Branch 18.12, 17.12.03, Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Labels: Modal, link, menu, menu-item
>
> I got problems by opening a modal via menu link with two parameters. Only the
> first parameter is successfully accessible in modal's screens definition.
> Investigation revealed that for a menu link of type 'layered-modal' inline
> JS-Code get created with defined action-String. This String is used to set
> following context parameters.
> The problem is, that parameter concatenating expression '&' is not encoded
> like
> {code:java}
> // .../control/uri?param1=1param2=2
> {code}
>
> My solution for this problem was to extend MacroMenuRenderer#renderLink by
> replacing
> {code:java}
> {code}
> by '&'.
> Furthermore, this method shows that submitted parameters, defined between
> menus link tags, will be ignored, if link type is 'layered-modal'. So, within
> action-String, we have to submit parameters.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal
[
https://issues.apache.org/jira/browse/OFBIZ-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116701#comment-17116701
]
Nicolas Malin commented on OFBIZ-11743:
---
Hi [~uHeidfeld] do you have a patch to submit ? otherwise I will investigate.
> Multiple menu item link parameters get lost if link type is layered-modal
> -
>
> Key: OFBIZ-11743
> URL: https://issues.apache.org/jira/browse/OFBIZ-11743
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Release Branch 18.12, 17.12.03, Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Labels: Modal, link, menu, menu-item
>
> I got problems by opening a modal via menu link with two parameters. Only the
> first parameter is successfully accessible in modal's screens definition.
> Investigation revealed that for a menu link of type 'layered-modal' inline
> JS-Code get created with defined action-String. This String is used to set
> following context parameters.
> The problem is, that parameter concatenating expression '&' is not encoded
> like
> {code:java}
> // .../control/uri?param1=1param2=2
> {code}
>
> My solution for this problem was to extend MacroMenuRenderer#renderLink by
> replacing
> {code:java}
> {code}
> by '&'.
> Furthermore, this method shows that submitted parameters, defined between
> menus link tags, will be ignored, if link type is 'layered-modal'. So, within
> action-String, we have to submit parameters.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal
[
https://issues.apache.org/jira/browse/OFBIZ-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116661#comment-17116661
]
Pierre Smits commented on OFBIZ-11743:
--
Hi [~uHeidfeld],
I made the 'Affected Version(s) field a bit more specific. Unfortunately,
17.12.01 couldn't be selected, due to guidelines/policies. See [1] and [2]
IMO, release 18.12 shouldn't be selected either, as it has no releases. It
should, however, be used in the 'Fix version(s) if and when back ported.
[1] https://cwiki.apache.org/confluence/display/OFBIZ/Guidelines+For+Using+JIRA
[2]
https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Committers+Roles+and+Responsibilities
> Multiple menu item link parameters get lost if link type is layered-modal
> -
>
> Key: OFBIZ-11743
> URL: https://issues.apache.org/jira/browse/OFBIZ-11743
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Release Branch 18.12, 17.12.03, Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Labels: Modal, link, menu, menu-item
>
> I got problems by opening a modal via menu link with two parameters. Only the
> first parameter is successfully accessible in modal's screens definition.
> Investigation revealed that for a menu link of type 'layered-modal' inline
> JS-Code get created with defined action-String. This String is used to set
> following context parameters.
> The problem is, that parameter concatenating expression '&' is not encoded
> like
> {code:java}
> // .../control/uri?param1=1param2=2
> {code}
>
> My solution for this problem was to extend MacroMenuRenderer#renderLink by
> replacing
> {code:java}
> {code}
> by '&'.
> Furthermore, this method shows that submitted parameters, defined between
> menus link tags, will be ignored, if link type is 'layered-modal'. So, within
> action-String, we have to submit parameters.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal
[
https://issues.apache.org/jira/browse/OFBIZ-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116649#comment-17116649
]
Ulrich Heidfeld commented on OFBIZ-11743:
-
Hi [~pierresmits],
this bug appears in 17.12.1, 17.12.3 and 18.12 too. It would be nice, if this
versions also get fixed.
> Multiple menu item link parameters get lost if link type is layered-modal
> -
>
> Key: OFBIZ-11743
> URL: https://issues.apache.org/jira/browse/OFBIZ-11743
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Labels: Modal, link, menu, menu-item
>
> I got problems by opening a modal via menu link with two parameters. Only the
> first parameter is successfully accessible in modal's screens definition.
> Investigation revealed that for a menu link of type 'layered-modal' inline
> JS-Code get created with defined action-String. This String is used to set
> following context parameters.
> The problem is, that parameter concatenating expression '&' is not encoded
> like
> {code:java}
> // .../control/uri?param1=1param2=2
> {code}
>
> My solution for this problem was to extend MacroMenuRenderer#renderLink by
> replacing
> {code:java}
> {code}
> by '&'.
> Furthermore, this method shows that submitted parameters, defined between
> menus link tags, will be ignored, if link type is 'layered-modal'. So, within
> action-String, we have to submit parameters.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal
[
https://issues.apache.org/jira/browse/OFBIZ-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116616#comment-17116616
]
Pierre Smits commented on OFBIZ-11743:
--
This also appears in releases (17.12.1 and 17.12.3)? If so, should we backport?
> Multiple menu item link parameters get lost if link type is layered-modal
> -
>
> Key: OFBIZ-11743
> URL: https://issues.apache.org/jira/browse/OFBIZ-11743
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Labels: Modal, link, menu, menu-item
>
> I got problems by opening a modal via menu link with two parameters. Only the
> first parameter is successfully accessible in modal's screens definition.
> Investigation revealed that for a menu link of type 'layered-modal' inline
> JS-Code get created with defined action-String. This String is used to set
> following context parameters.
> The problem is, that parameter concatenating expression '&' is not encoded
> like
> {code:java}
> // .../control/uri?param1=1param2=2
> {code}
>
> My solution for this problem was to extend MacroMenuRenderer#renderLink by
> replacing
> {code:java}
> {code}
> by '&'.
> Furthermore, this method shows that submitted parameters, defined between
> menus link tags, will be ignored, if link type is 'layered-modal'. So, within
> action-String, we have to submit parameters.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal
[
https://issues.apache.org/jira/browse/OFBIZ-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116610#comment-17116610
]
Pierre Smits commented on OFBIZ-11743:
--
Hi [~uHeidfeld],
+1. Makes sense. Layer-model application in widgets (and templates) are
essential to modern-day solutions visavis usability.
Can you update the component and label fields?
> Multiple menu item link parameters get lost if link type is layered-modal
> -
>
> Key: OFBIZ-11743
> URL: https://issues.apache.org/jira/browse/OFBIZ-11743
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
>
> I got problems by opening a modal via menu link with two parameters. Only the
> first parameter is successfully accessible in modal's screens definition.
> Investigation revealed that for a menu link of type 'layered-modal' inline
> JS-Code get created with defined action-String. This String is used to set
> following context parameters.
> The problem is, that parameter concatenating expression '&' is not encoded
> like
> {code:java}
> // .../control/uri?param1=1param2=2
> {code}
>
> My solution for this problem was to extend MacroMenuRenderer#renderLink by
> replacing
> {code:java}
> {code}
> by '&'.
> Furthermore, this method shows that submitted parameters, defined between
> menus link tags, will be ignored, if link type is 'layered-modal'. So, within
> action-String, we have to submit parameters.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
