[jira] [Commented] (OFBIZ-11745) plugins in common-theme/webapp/common/js is not monitored by git
[ https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129245#comment-17129245 ] ASF subversion and git services commented on OFBIZ-11745: - Commit abad801b0c5928c8427ec8baef0ecbe72b081245 in ofbiz-framework's branch refs/heads/release17.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=abad801 ] Fixed: plugins in common-theme/webapp/common/js is not monitored by git (OFBIZ-11745) In .gitignore in root ofbiz directory there is plugins/ so all directory plugins are ignored if the line is replace by /plugins/ only root directory plugins is ignored Thanks: Olivier Conflict handled by hand > plugins in common-theme/webapp/common/js is not monitored by git > > > Key: OFBIZ-11745 > URL: https://issues.apache.org/jira/browse/OFBIZ-11745 > Project: OFBiz > Issue Type: Bug > Components: git >Affects Versions: Trunk >Reporter: Olivier Heintz >Assignee: Jacques Le Roux >Priority: Major > Fix For: Trunk > > > in .gitignore in root ofbiz directory there is plugins/ > so all directory plugins are ignored > if the line is replace by plugins/* only root directory plugins is ignored -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11745) plugins in common-theme/webapp/common/js is not monitored by git
[ https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129238#comment-17129238 ] ASF subversion and git services commented on OFBIZ-11745: - Commit 324edc9e8a90fe57de38fb9c4ca8662dc0d74f11 in ofbiz-framework's branch refs/heads/release18.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=324edc9 ] Fixed: plugins in common-theme/webapp/common/js is not monitored by git (OFBIZ-11745) In .gitignore in root ofbiz directory there is plugins/ so all directory plugins are ignored if the line is replace by /plugins/ only root directory plugins is ignored Can't cherry-pick so trying by hand (easy stuff) Thanks: Olivier > plugins in common-theme/webapp/common/js is not monitored by git > > > Key: OFBIZ-11745 > URL: https://issues.apache.org/jira/browse/OFBIZ-11745 > Project: OFBiz > Issue Type: Bug > Components: git >Affects Versions: Trunk >Reporter: Olivier Heintz >Assignee: Jacques Le Roux >Priority: Major > Fix For: Trunk > > > in .gitignore in root ofbiz directory there is plugins/ > so all directory plugins are ignored > if the line is replace by plugins/* only root directory plugins is ignored -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11745) plugins in common-theme/webapp/common/js is not monitored by git
[ https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129137#comment-17129137 ] ASF subversion and git services commented on OFBIZ-11745: - Commit ed6a6fe3d38f1489863b1bce77a38da88540493d in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=ed6a6fe ] Fixed: plugins in common-theme/webapp/common/js is not monitored by git (OFBIZ-11745) In .gitignore in root ofbiz directory there is plugins/ so all directory plugins are ignored if the line is replace by /plugins/ only root directory plugins is ignored Thanks: Olivier > plugins in common-theme/webapp/common/js is not monitored by git > > > Key: OFBIZ-11745 > URL: https://issues.apache.org/jira/browse/OFBIZ-11745 > Project: OFBiz > Issue Type: Bug > Components: git >Affects Versions: Trunk >Reporter: Olivier Heintz >Assignee: Jacques Le Roux >Priority: Major > Fix For: Trunk > > > in .gitignore in root ofbiz directory there is plugins/ > so all directory plugins are ignored > if the line is replace by plugins/* only root directory plugins is ignored -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11745) plugins in common-theme/webapp/common/js is not monitored by git
[ https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128415#comment-17128415 ] Jacques Le Roux commented on OFBIZ-11745: - Thanks OLivier, Works for me, +1 for commit > plugins in common-theme/webapp/common/js is not monitored by git > > > Key: OFBIZ-11745 > URL: https://issues.apache.org/jira/browse/OFBIZ-11745 > Project: OFBiz > Issue Type: Bug > Components: git >Affects Versions: Trunk >Reporter: Olivier Heintz >Assignee: Olivier Heintz >Priority: Major > Fix For: Trunk > > > in .gitignore in root ofbiz directory there is plugins/ > so all directory plugins are ignored > if the line is replace by plugins/* only root directory plugins is ignored -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11745) plugins in common-theme/webapp/common/js is not monitored by git
[ https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128384#comment-17128384 ] Olivier Heintz commented on OFBIZ-11745: Thanks Jacques, corrections done in my comment (a lot of s forgot !! ) > plugins in common-theme/webapp/common/js is not monitored by git > > > Key: OFBIZ-11745 > URL: https://issues.apache.org/jira/browse/OFBIZ-11745 > Project: OFBiz > Issue Type: Bug > Components: git >Affects Versions: Trunk >Reporter: Olivier Heintz >Assignee: Olivier Heintz >Priority: Major > Fix For: Trunk > > > in .gitignore in root ofbiz directory there is plugins/ > so all directory plugins are ignored > if the line is replace by plugins/* only root directory plugins is ignored -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11745) plugins in common-theme/webapp/common/js is not monitored by git
[ https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128304#comment-17128304 ] Jacques Le Roux commented on OFBIZ-11745: - Thanks Olivier, Still wondering, /plugin/ or /plugins/ I guess the later, right? > plugins in common-theme/webapp/common/js is not monitored by git > > > Key: OFBIZ-11745 > URL: https://issues.apache.org/jira/browse/OFBIZ-11745 > Project: OFBiz > Issue Type: Bug > Components: git >Affects Versions: Trunk >Reporter: Olivier Heintz >Assignee: Olivier Heintz >Priority: Major > Fix For: Trunk > > > in .gitignore in root ofbiz directory there is plugins/ > so all directory plugins are ignored > if the line is replace by plugins/* only root directory plugins is ignored -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11745) plugins in common-theme/webapp/common/js is not monitored by git
[ https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128086#comment-17128086 ] Olivier Heintz commented on OFBIZ-11745: hi Jacques, I mean /plugin/ after previous commit with plugin/* and other commit with plugin as submodule, plugin appear in my eclipse config, and so I generate a .gitignore update for directory plugins, the result was /plugins/ so I search and find that * plugins <= is for all file name plugins * plugins/ <= is for all directory name plugins * plugins/* <= is all files in a directory name plugins * /plugin/ <= the directory plugins in the root directory so my previous commit was wrong, the correct one should be /plugins/ > plugins in common-theme/webapp/common/js is not monitored by git > > > Key: OFBIZ-11745 > URL: https://issues.apache.org/jira/browse/OFBIZ-11745 > Project: OFBiz > Issue Type: Bug > Components: git >Affects Versions: Trunk >Reporter: Olivier Heintz >Assignee: Olivier Heintz >Priority: Major > Fix For: Trunk > > > in .gitignore in root ofbiz directory there is plugins/ > so all directory plugins are ignored > if the line is replace by plugins/* only root directory plugins is ignored -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11745) plugins in common-theme/webapp/common/js is not monitored by git
[ https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128006#comment-17128006 ] Jacques Le Roux commented on OFBIZ-11745: - Hi Olivier, You say: bq. the correct value seem to be /plugin/ the first slash to exclude only at the root directory Do you mean /plugins/ or /plugins/* ? Could you explain more why? What did you cross? TIA > plugins in common-theme/webapp/common/js is not monitored by git > > > Key: OFBIZ-11745 > URL: https://issues.apache.org/jira/browse/OFBIZ-11745 > Project: OFBiz > Issue Type: Bug > Components: git >Affects Versions: Trunk >Reporter: Olivier Heintz >Assignee: Olivier Heintz >Priority: Major > Fix For: Trunk > > > in .gitignore in root ofbiz directory there is plugins/ > so all directory plugins are ignored > if the line is replace by plugins/* only root directory plugins is ignored -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11745) plugins in common-theme/webapp/common/js is not monitored by git
[ https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127694#comment-17127694 ] Jacques Le Roux commented on OFBIZ-11745: - I finally pushed to not be blocked > plugins in common-theme/webapp/common/js is not monitored by git > > > Key: OFBIZ-11745 > URL: https://issues.apache.org/jira/browse/OFBIZ-11745 > Project: OFBiz > Issue Type: Bug > Components: git >Affects Versions: Trunk >Reporter: Olivier Heintz >Assignee: Olivier Heintz >Priority: Major > Fix For: Trunk > > > in .gitignore in root ofbiz directory there is plugins/ > so all directory plugins are ignored > if the line is replace by plugins/* only root directory plugins is ignored -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11745) plugins in common-theme/webapp/common/js is not monitored by git
[
https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127675#comment-17127675
]
Jacques Le Roux commented on OFBIZ-11745:
-
Hi Olivier,
More about my comment above.
What I see with "git diff" is
{noformat}
diff --git a/plugins b/plugins
index 2c65f7d17b..b08fa4a944 16
--- a/plugins
+++ b/plugins
@@ -1 +1 @@
-Subproject commit 2c65f7d17bcdbccd7d166701365c56bca40d2f2d
+Subproject commit b08fa4a9441f4f67b210b29ef424f0eaf6ff0433-dirty
{noformat}
I never declared the plugins a submodule, and I have no pending change. So I
looked for an answer and found several commits done for OFBIZ-8459 where
plugins what successively added, reverted and added again:
https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b39c179
https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=3a4d22
https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=bda6192
I have removed it locally (committed but not pushed it yet) and that should
clear my concern. I'll ask on dev ML before pushing...
> plugins in common-theme/webapp/common/js is not monitored by git
>
>
> Key: OFBIZ-11745
> URL: https://issues.apache.org/jira/browse/OFBIZ-11745
> Project: OFBiz
> Issue Type: Bug
> Components: git
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Olivier Heintz
>Priority: Major
> Fix For: Trunk
>
>
> in .gitignore in root ofbiz directory there is plugins/
> so all directory plugins are ignored
> if the line is replace by plugins/* only root directory plugins is ignored
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11745) plugins in common-theme/webapp/common/js is not monitored by git
[ https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127384#comment-17127384 ] Olivier Heintz commented on OFBIZ-11745: the correct value seem to be /plugin/ the first slash to exclude only at the root directory I will commit the correction in a few days > plugins in common-theme/webapp/common/js is not monitored by git > > > Key: OFBIZ-11745 > URL: https://issues.apache.org/jira/browse/OFBIZ-11745 > Project: OFBiz > Issue Type: Bug > Components: git >Affects Versions: Trunk >Reporter: Olivier Heintz >Assignee: Olivier Heintz >Priority: Major > Fix For: Trunk > > > in .gitignore in root ofbiz directory there is plugins/ > so all directory plugins are ignored > if the line is replace by plugins/* only root directory plugins is ignored -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11745) plugins in common-theme/webapp/common/js is not monitored by git
[ https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119336#comment-17119336 ] Jacques Le Roux commented on OFBIZ-11745: - The only minor issue with plugins/* vs plugins/ is that when you embedd the plugins repo in the framework repo then you see it in git status, not a big deal. > plugins in common-theme/webapp/common/js is not monitored by git > > > Key: OFBIZ-11745 > URL: https://issues.apache.org/jira/browse/OFBIZ-11745 > Project: OFBiz > Issue Type: Bug > Components: git >Affects Versions: Trunk >Reporter: Olivier Heintz >Assignee: Olivier Heintz >Priority: Major > Fix For: Trunk > > > in .gitignore in root ofbiz directory there is plugins/ > so all directory plugins are ignored > if the line is replace by plugins/* only root directory plugins is ignored -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11745) plugins in common-theme/webapp/common/js is not monitored by git
[ https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118637#comment-17118637 ] Olivier Heintz commented on OFBIZ-11745: done, I have choose to put plugins/* because with only plugins eclipse not see creation in sub directory plugins with plugins/* command line git and eclipse have a correct monitoring. > plugins in common-theme/webapp/common/js is not monitored by git > > > Key: OFBIZ-11745 > URL: https://issues.apache.org/jira/browse/OFBIZ-11745 > Project: OFBiz > Issue Type: Bug > Components: git >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Major > > in .gitignore in root ofbiz directory there is plugins/ > so all directory plugins are ignored > if the line is replace by plugins/* only root directory plugins is ignored -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11745) plugins in common-theme/webapp/common/js is not monitored by git
[ https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118545#comment-17118545 ] Aditya Sharma commented on OFBIZ-11745: --- +1 [~holivier] I think we should move ahead with it > plugins in common-theme/webapp/common/js is not monitored by git > > > Key: OFBIZ-11745 > URL: https://issues.apache.org/jira/browse/OFBIZ-11745 > Project: OFBiz > Issue Type: Bug > Components: git >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Major > > in .gitignore in root ofbiz directory there is plugins/ > so all directory plugins are ignored > if the line is replace by plugins/* only root directory plugins is ignored -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11745) plugins in common-theme/webapp/common/js is not monitored by git
[ https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117723#comment-17117723 ] Jacques Le Roux commented on OFBIZ-11745: - You are actually right Olivier, works also for me if I simply removes the trailing slash, +1 for commit > plugins in common-theme/webapp/common/js is not monitored by git > > > Key: OFBIZ-11745 > URL: https://issues.apache.org/jira/browse/OFBIZ-11745 > Project: OFBiz > Issue Type: Bug > Components: git >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Major > > in .gitignore in root ofbiz directory there is plugins/ > so all directory plugins are ignored > if the line is replace by plugins/* only root directory plugins is ignored -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11745) plugins in common-theme/webapp/common/js is not monitored by git
[ https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117656#comment-17117656 ] Olivier Heintz commented on OFBIZ-11745: Hi Jacques, Thank for your answers, Maybe it's a configuration problem in my local dev environment, Currently if I add a new js file in common-theme/webapp/common/js/plugins the git status (at ofbiz root directory) give no new file ! after the modification I suggest git status give me a new file to add with git add > plugins in common-theme/webapp/common/js is not monitored by git > > > Key: OFBIZ-11745 > URL: https://issues.apache.org/jira/browse/OFBIZ-11745 > Project: OFBiz > Issue Type: Bug > Components: git >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Major > > in .gitignore in root ofbiz directory there is plugins/ > so all directory plugins are ignored > if the line is replace by plugins/* only root directory plugins is ignored -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11745) plugins in common-theme/webapp/common/js is not monitored by git
[ https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117560#comment-17117560 ] Jacques Le Roux commented on OFBIZ-11745: - BTW I think you made a confusion. common-theme/webapp/common/js/plugins is monitored by git. You can check by yourself. > plugins in common-theme/webapp/common/js is not monitored by git > > > Key: OFBIZ-11745 > URL: https://issues.apache.org/jira/browse/OFBIZ-11745 > Project: OFBiz > Issue Type: Bug > Components: git >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Major > > in .gitignore in root ofbiz directory there is plugins/ > so all directory plugins are ignored > if the line is replace by plugins/* only root directory plugins is ignored -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11745) plugins in common-theme/webapp/common/js is not monitored by git
[ https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117554#comment-17117554 ] Jacques Le Roux commented on OFBIZ-11745: - Hi Olivier Plugins are part of another repository: ofbiz-plugins. So it makes no sense to change that. > plugins in common-theme/webapp/common/js is not monitored by git > > > Key: OFBIZ-11745 > URL: https://issues.apache.org/jira/browse/OFBIZ-11745 > Project: OFBiz > Issue Type: Bug > Components: git >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Major > > in .gitignore in root ofbiz directory there is plugins/ > so all directory plugins are ignored > if the line is replace by plugins/* only root directory plugins is ignored -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11745) plugins in common-theme/webapp/common/js is not monitored by git
[ https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117522#comment-17117522 ] Olivier Heintz commented on OFBIZ-11745: status is "Patch Available", because there is only one line to change. > plugins in common-theme/webapp/common/js is not monitored by git > > > Key: OFBIZ-11745 > URL: https://issues.apache.org/jira/browse/OFBIZ-11745 > Project: OFBiz > Issue Type: Bug > Components: git >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Major > > in .gitignore in root ofbiz directory there is plugins/ > so all directory plugins are ignored > if the line is replace by plugins/* only root directory plugins is ignored -- This message was sent by Atlassian Jira (v8.3.4#803005)
