[jira] [Commented] (OFBIZ-11877) Convert testCreateAndUpdateContactList test from XML to Groovy

2020-08-19 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180515#comment-17180515
 ] 

Jacques Le Roux commented on OFBIZ-11877:
-

Ha, did not see your answer Pawa, was about to work on it, thanks.

I must say I only tested with
bq. gradlew "ofbiz --test component=marketing --test suitename=marketingtests"

Works for me again after update locally.

> Convert testCreateAndUpdateContactList test from XML to Groovy
> --
>
> Key: OFBIZ-11877
> URL: https://issues.apache.org/jira/browse/OFBIZ-11877
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: marketing
>Affects Versions: Trunk
>Reporter: Akash Jain
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11877.patch
>
>
> Convert testCreateAndUpdateContactList test from XML to Groovy.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11877) Convert testCreateAndUpdateContactList test from XML to Groovy

2020-08-19 Thread Pawan Verma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180506#comment-17180506
 ] 

Pawan Verma commented on OFBIZ-11877:
-

Hello [~Dennis Balkir]

Thanks, for the report. I've corrected it at R#71cfe0f. Please have a look!

> Convert testCreateAndUpdateContactList test from XML to Groovy
> --
>
> Key: OFBIZ-11877
> URL: https://issues.apache.org/jira/browse/OFBIZ-11877
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: marketing
>Affects Versions: Trunk
>Reporter: Akash Jain
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11877.patch
>
>
> Convert testCreateAndUpdateContactList test from XML to Groovy.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11877) Convert testCreateAndUpdateContactList test from XML to Groovy

2020-08-19 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180504#comment-17180504
 ] 

ASF subversion and git services commented on OFBIZ-11877:
-

Commit 71cfe0f8e3c0757ef9e70fccdba7f1d3d1d2fddd in ofbiz-framework's branch 
refs/heads/trunk from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=71cfe0f ]

Fixed: Corrected package for marketing tests(OFBIZ-11877)

Thanks, Dennis Balkir for the report.


> Convert testCreateAndUpdateContactList test from XML to Groovy
> --
>
> Key: OFBIZ-11877
> URL: https://issues.apache.org/jira/browse/OFBIZ-11877
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: marketing
>Affects Versions: Trunk
>Reporter: Akash Jain
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11877.patch
>
>
> Convert testCreateAndUpdateContactList test from XML to Groovy.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11877) Convert testCreateAndUpdateContactList test from XML to Groovy

2020-08-19 Thread Dennis Balkir (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180489#comment-17180489
 ] 

Dennis Balkir commented on OFBIZ-11877:
---

Hello [~jleroux],

I actuall got an error out of this change:

{{The declared package 
"applications.marketing.src.main.groovy.org.apache.ofbiz.marketing" does not 
match the expected package "org.apache.ofbiz.marketing"}}

 

The declared package looks weird to me too. Can you take a look at this?

> Convert testCreateAndUpdateContactList test from XML to Groovy
> --
>
> Key: OFBIZ-11877
> URL: https://issues.apache.org/jira/browse/OFBIZ-11877
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: marketing
>Affects Versions: Trunk
>Reporter: Akash Jain
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11877.patch
>
>
> Convert testCreateAndUpdateContactList test from XML to Groovy.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11877) Convert testCreateAndUpdateContactList test from XML to Groovy

2020-07-31 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168427#comment-17168427
 ] 

ASF subversion and git services commented on OFBIZ-11877:
-

Commit d962777c771285683737795a0c6db9c55e9d7823 in ofbiz-framework's branch 
refs/heads/trunk from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=d962777 ]

Improved: Convert testCreateAndUpdateContactList test from XML to 
Groovy(OFBIZ-11877)

Thanks, Jacques for the review.


> Convert testCreateAndUpdateContactList test from XML to Groovy
> --
>
> Key: OFBIZ-11877
> URL: https://issues.apache.org/jira/browse/OFBIZ-11877
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: marketing
>Affects Versions: Trunk
>Reporter: Akash Jain
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-11877.patch
>
>
> Convert testCreateAndUpdateContactList test from XML to Groovy.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11877) Convert testCreateAndUpdateContactList test from XML to Groovy

2020-07-30 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167832#comment-17167832
 ] 

Jacques Le Roux commented on OFBIZ-11877:
-

Works for me, +1 fo commit

> Convert testCreateAndUpdateContactList test from XML to Groovy
> --
>
> Key: OFBIZ-11877
> URL: https://issues.apache.org/jira/browse/OFBIZ-11877
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: marketing
>Affects Versions: Trunk
>Reporter: Akash Jain
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-11877.patch
>
>
> Convert testCreateAndUpdateContactList test from XML to Groovy.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11877) Convert testCreateAndUpdateContactList test from XML to Groovy

2020-07-30 Thread Pawan Verma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167741#comment-17167741
 ] 

Pawan Verma commented on OFBIZ-11877:
-

This can be tested using:

./gradlew "ofbiz --test component=marketing --test suitename=marketingtests"

> Convert testCreateAndUpdateContactList test from XML to Groovy
> --
>
> Key: OFBIZ-11877
> URL: https://issues.apache.org/jira/browse/OFBIZ-11877
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: marketing
>Affects Versions: Trunk
>Reporter: Akash Jain
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-11877.patch
>
>
> Convert testCreateAndUpdateContactList test from XML to Groovy.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)