[jira] [Commented] (OFBIZ-11882) Rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166327#comment-17166327 ] Jacques Le Roux commented on OFBIZ-11882: - After Aditya message at https://markmail.org/message/5wgw64l5a2s4diww bq. As I get some time I will try to come up with some solution using the requirejs, node, etc to ease these things. https://plugins.gradle.org/plugin/com.github.node-gradle.node I guess we will rather use this method with maybe the poping alert done at https://cwiki.apache.org/confluence/display/OFBIZ/About+retire.js > Rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: 18.12.01, 17.12.05 > > Attachments: ecommerce-js.patch, ecommerce-js2.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) Rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164829#comment-17164829 ] Jacques Le Roux commented on OFBIZ-11882: - Thanks Aditya for the reminder! > Rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: 18.12.01, 17.12.05 > > Attachments: ecommerce-js.patch, ecommerce-js2.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) Rename a few map files
[
https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164756#comment-17164756
]
Aditya Sharma commented on OFBIZ-11882:
---
Thanks Jacques! Sounds promising.
{quote}I have notably found that I can't view jQuery source
{quote}
We will get source map URL in most of the libraries except jQuery, we will have
to manually add it
[https://github.com/jquery/jquery/issues/4166]
> Rename a few map files
> --
>
> Key: OFBIZ-11882
> URL: https://issues.apache.org/jira/browse/OFBIZ-11882
> Project: OFBiz
> Issue Type: Improvement
> Components: ecommerce
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: 18.12.01, 17.12.05
>
> Attachments: ecommerce-js.patch, ecommerce-js2.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> tells a few files to be renamed, to suppress warnings in the browser console.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) Rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164458#comment-17164458 ] Jacques Le Roux commented on OFBIZ-11882: - I had a look at the tools for creating maps and minifying. It's all about js and I don't like it much. I want a clean easy solution: a Gradle task :) Despite being kinda abandoned https://github.com/eriwen/gradle-js-plugin is still the best solution for us. Trunk currently uses Gradle 6.3. So we need to find a fork which supports that or need to create our own fork. https://github.com/twwwt/gradle-js-plugin which claims to handle 6.1.1 could be a good start if we don't find better. I came to this conclusion after my last comment at OFBIZ-11882: bq. Sure we should have source maps for CSS files too, even in production: https://css-tricks.com/should-i-use-source-maps-in-production/ I wrote but did not publish this few days ago. In the meantime I have created my own plugin based on eriwen's and modified following twwwt's. I'll publish it soon, will close here and will see what I can get from it. I have notably found that I can't view jQuery source. I never missed that, but if the plugin works as expected we would have all the necessary maps. > Rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: 18.12.01, 17.12.05 > > Attachments: ecommerce-js.patch, ecommerce-js2.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) Rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163275#comment-17163275 ] ASF subversion and git services commented on OFBIZ-11882: - Commit 7a51784e2a96ad4c48a0defdc6d56b86069a7e70 in ofbiz-plugins's branch refs/heads/release18.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=7a51784 ] Improved: Rename a few map files (OFBIZ-11882) Renames a few files to suppress warnings in the browser console. Thanks: Alex Bodnaru > Rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch, ecommerce-js2.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) Rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163274#comment-17163274 ] ASF subversion and git services commented on OFBIZ-11882: - Commit d335f7890f8472b90195576231b2aed2c5aec858 in ofbiz-plugins's branch refs/heads/release17.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=d335f78 ] Improved: Rename a few map files (OFBIZ-11882) Renames a few files to suppress warnings in the browser console. Thanks: Alex Bodnaru > Rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch, ecommerce-js2.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) Rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160981#comment-17160981 ] Jacques Le Roux commented on OFBIZ-11882: - Hi Alex, It would be great if you could subscribe to our main MLs: dev and user. Please see https://ofbiz.apache.org/mailing-lists.html TIA > Rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch, ecommerce-js2.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) Rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160702#comment-17160702 ] Alex Bodnaru commented on OFBIZ-11882: -- thank you jacques, that will do. we can move forward to more interesting bugs ;) > Rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch, ecommerce-js2.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) Rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160697#comment-17160697 ] ASF subversion and git services commented on OFBIZ-11882: - Commit a905d459bda216aa983a9eebe9f4d7b34f8559c5 in ofbiz-plugins's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=a905d45 ] Improved: Rename a few map files (OFBIZ-11882) Renames a few files to suppress warnings in the browser console. Thanks: Alex Bodnaru > Rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch, ecommerce-js2.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) rename a few map files
[
https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160690#comment-17160690
]
Jacques Le Roux commented on OFBIZ-11882:
-
I checked minified files with sourceMappingURL: are
bootstrap-4.3.1.min.js
7: //# sourceMappingURL=bootstrap.min.js.map
bootstrap.bundle-4.3.1.min.js
7: //# sourceMappingURL=bootstrap.bundle.min.js.map
jquery.jgrowl-1.4.6.min.js
2: //# sourceMappingURL=jquery.jgrowl.map
jquery.form.min.js
23: //# sourceMappingURL=jquery.form.min.js.map
imagemanagement
sizzle.min.js
3: //# sourceMappingURL=dist/sizzle.min.map
less.min.js
14: ... rn a?"/*# sourceMappingURL="+a+"
*/":""},c.prototype.getExternalSourceMap=function()\{return
this.sourceMap},c.prototype.setExternalSourceMap=function(a ...
bootstrap-4.3.1.min.css
7: /*# sourceMappingURL=bootstrap.min.css.map */
bootstrap-grid.min.css
7: /*# sourceMappingURL=bootstrap-grid.min.css.map */
bootstrap-reboot.min.css
8: /*# sourceMappingURL=bootstrap-reboot.min.css.map */
So only bootstrap minified files have sourceMappingURL, normal?
> rename a few map files
> --
>
> Key: OFBIZ-11882
> URL: https://issues.apache.org/jira/browse/OFBIZ-11882
> Project: OFBiz
> Issue Type: Improvement
> Components: ecommerce
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Assignee: Jacques Le Roux
>Priority: Trivial
> Attachments: ecommerce-js.patch, ecommerce-js2.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> tells a few files to be renamed, to suppress warnings in the browser console.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) rename a few map files
[
https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160604#comment-17160604
]
Jacques Le Roux commented on OFBIZ-11882:
-
I have updated the Alert at
https://cwiki.apache.org/confluence/display/OFBIZ/About+retire.js
Here is the content:
{quote}
h6. Javascript source maps
When we update a library and we use the minified version we need to
# verify that we have the source (js and/or css);
# create a JavaScript source map if it does not exist you may use a tool like
https://github.com/mozilla/source-map;
# change or add a sourceMappingURL comment in the the minified version. You can
follow
https://developer.mozilla.org/en-US/docs/Tools/Debugger/How_to/Use_a_source_map.
# We need to follow a convention for minified files with maps. Like:
jquery-3.5.1.js, jquery-3.5.1.min.js and jquery-3.5.1.min.js.map
{quote}
> rename a few map files
> --
>
> Key: OFBIZ-11882
> URL: https://issues.apache.org/jira/browse/OFBIZ-11882
> Project: OFBiz
> Issue Type: Improvement
> Components: ecommerce
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Assignee: Jacques Le Roux
>Priority: Trivial
> Attachments: ecommerce-js.patch, ecommerce-js2.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> tells a few files to be renamed, to suppress warnings in the browser console.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160598#comment-17160598 ] Jacques Le Roux commented on OFBIZ-11882: - OK, I'll check your patches and commit them if all is OK with me. I'll also check that none of our 3rd libs miss maps and source and have minified files with correct references in them. That should be it before maybe a backport if all things went well. bq. this should probably be configurable, much like compiling with the debugging symbols (in the c/c++ parlace). We will say that later, as we discussed and you suggested. That will be another Jira... > rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch, ecommerce-js2.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160530#comment-17160530 ] Alex Bodnaru commented on OFBIZ-11882: -- i have only patched the wrongly named map files, where they have been provided at all by upstream. as you previously cited jquery developers, they do recommend against map files, so that there's no sourceMappingUrl in their minified files, so that there's also no 404 error. the moment we'll generate our own minified files, we'll use the sources (e.g. [xyz].js) to create only one concatenated and minified all.min.js, and generate all.min.js.map and point sourceMappingUrl to it, if we'll decide to provide a map for this file. this should probably be configurable, much like compiling with the debugging symbols (in the c/c++ parlace). > rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch, ecommerce-js2.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160360#comment-17160360 ] Jacques Le Roux commented on OFBIZ-11882: - Thanks Aditya, This confirms what I supposed initially. It's a CI and ultimately production thing. Users downstream will have to handle their part if they use a CDN or whatnot. [~alexbodn] will you handle that as you suggested above?: bq. there's a much shorter way to fix for the mean time. changing only the map file name in each min file. would you accept that? Could you then provide a patch for all the maps I listed above? TIA :) I guess the effect will be the same than what is suggested by [https://developer.mozilla.org/en-US/docs/Tools/Debugger/How_to/Use_a_source_map] and (quoting developer.mozilla.org): bq. include a comment in the transformed file, that points to the source map (?) BTW I have created an alert at [https://cwiki.apache.org/confluence/display/OFBIZ/About+retire.js]. We can update it to have only one simple way: * to comment in our map * or in the the transformed (for us minified) file > rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch, ecommerce-js2.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159260#comment-17159260 ] Aditya Sharma commented on OFBIZ-11882: --- Hi Jacques, For most of the libraries we have added/upgraded we simply download the official packages and added/replaced. We tried to ensure that we do least or no changes to original packages. Also, we haven't minified any of the files, most of the minified files are from the official release. I think for jQuery I have downloaded the files through the links from the official blog and simply replaced them. [https://blog.jquery.com/2020/05/04/jquery-3-5-1-released-fixing-a-regression/] But, it seems the path through [download|https://jquery.com/download/] page or [GitHub|https://github.com/jquery/jquery/releases/tag/3.5.1] would have been a much better option. I noticed that the minified files for jQuery don't come with a sourceMappingUrl as a comment in them [https://github.com/jquery/jquery/issues/4166] [|https://blog.jquery.com/2014/01/24/jquery-1-11-and-2-1-released/] |We've removed the comment on purpose, see [https://blog.jquery.com/2014/01/24/jquery-1-11-and-2-1-released/]. There are many problems with including the comment, one of them being that different CDNs use different file names so the comment would have to be different for different CDNs and that kills security features like Subresource Integrity. You can still attach the map manually via DevTools, at least Chrome supports that.| We will have to add the sourceMappingUrl to the minified file manually and add the source map file. > rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch, ecommerce-js2.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159102#comment-17159102 ] Alex Bodnaru commented on OFBIZ-11882: -- agree with you. gradle-js or other similar tool will be needed to higher revamp js/css usage. the result will be a gain in performance, reduction of downloaded resources (in count at least). what we're doing now, is bug-fixing only. > rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch, ecommerce-js2.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159055#comment-17159055 ] Jacques Le Roux commented on OFBIZ-11882: - About ["twwwt"|https://github.com/twwwt/gradle-js-plugin], we need to be sure about going this way, and that's the community to decide. Why picking this fork rather than one of the 108 others? Maybe better document a manual way in https://cwiki.apache.org/confluence/display/OFBIZ/About+retire.js, et voilà :) That happens like one or twice a year, so not a big deal... > rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch, ecommerce-js2.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159046#comment-17159046 ] Jacques Le Roux commented on OFBIZ-11882: - I wrote above: bq. OK better do that manually when "retiring" then. I'll start a thread on dev ML and will post the link here soon. I did not start it yet, better clarify things here before asking the community. > rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch, ecommerce-js2.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159043#comment-17159043 ] Jacques Le Roux commented on OFBIZ-11882: - I was not sure what ol was, here is an explaining link: https://openlayers.org/download/ > rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch, ecommerce-js2.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) rename a few map files
[
https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159040#comment-17159040
]
Jacques Le Roux commented on OFBIZ-11882:
-
Alex,
You asked me:
{quote}how are the js/css files getting into ofbiz repository?
there may be a flaw somewhere.
{quote}
And I did not give you the righ answer. I was thinking about code when you
asked about the repo.
As you may have seen since, the js/css/map files are modified when we decide to
use retire.js:
[https://cwiki.apache.org/confluence/display/OFBIZ/About+retire.js]
It started with OFBIZ-9269 OFBIZ-9978 is also related, and there have been few
more since:
[https://issues.apache.org/jira/issues/?jql=project%20%3D%20OFBIZ%20AND%20text%20~%20%22retire.js%22]
As you can see, most of the work was done by Aditya (thank you again Aditya!
:)). So we need to know how you did the minification [~adityasharma].
I had a look at the map files we have
{noformat}
plugins\ecommerce\webapp\ecommerce\js\bootstrap\css
bootstrap-4.3.1.css.map
bootstrap-4.3.1.min.css.map
bootstrap-grid.css.map
bootstrap-grid.min.css.map
bootstrap-reboot.css.map
bootstrap-reboot.min.css.map
plugins\ecommerce\webapp\ecommerce\js\bootstrap\js
bootstrap-4.3.1.js.map
bootstrap-4.3.1.min.js.map
bootstrap.bundle-4.3.1.js.map
bootstrap.bundle-4.3.1.min.js.map
themes\common-theme\webapp\common\js\jquery\plugins\validate\lib
jquery.form.min.js.map
themes\common-theme\webapp\common\js\plugins\imagemanagement
sizzle.min.map
{noformat}
BTW, if we have the maps, should we not get rid of the source files?
> rename a few map files
> --
>
> Key: OFBIZ-11882
> URL: https://issues.apache.org/jira/browse/OFBIZ-11882
> Project: OFBiz
> Issue Type: Improvement
> Components: ecommerce
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Assignee: Jacques Le Roux
>Priority: Trivial
> Attachments: ecommerce-js.patch, ecommerce-js2.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> tells a few files to be renamed, to suppress warnings in the browser console.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158995#comment-17158995 ] Alex Bodnaru commented on OFBIZ-11882: -- hello [~adityasharma], [~jleroux], there is a fork by twwwt that has commits in the last months, and mentions support of gradle 6.0.1. there is room for upgrading the js/css handling, indeed. > rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch, ecommerce-js2.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158993#comment-17158993 ] Jacques Le Roux commented on OFBIZ-11882: - Thanks Aditya, OK better do that manually when "retiring" then. I'll start a thread on dev ML and will post the link here soon. > rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch, ecommerce-js2.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158984#comment-17158984 ] Aditya Sharma commented on OFBIZ-11882: --- Hi Jacques, Alex, [gradle-js-plugin|https://github.com/eriwen/gradle-js-plugin] did catch my eye too, but for me, it's a dead end. Last release in 2016 [https://github.com/eriwen/gradle-js-plugin/releases] Lacks support for current Gradle versions [https://github.com/eriwen/gradle-js-plugin/pull/176] Not sure if we should place a bet on it > rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch, ecommerce-js2.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158956#comment-17158956 ] Alex Bodnaru commented on OFBIZ-11882: -- hello jacques, there is more to do with gradle js, especially concatenating and minifying all js and css in one file of each type. this will be an improvement in the build workflow. the min and map files should then be generated locally. my report and solution would simply fix a flaw resulted from the minifying process of the existent files, with imediate impact, thus i'm kindly asking you to go ahead. if youl'd tell the way these files arrived here, we may find the original flaw and fix it (or not, if someone else is doing the minification). it's a pitty to live with a problem you can easily fix, only because the full blown solution is somewhere else. i also have some more significant bugs and fixes to report, that these diffs are making it hard to me to isolate. thanks in advance, alex > rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch, ecommerce-js2.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158946#comment-17158946 ] Jacques Le Roux commented on OFBIZ-11882: - Hi Alex, Actually after having slept on it, I wonder if using https://github.com/eriwen/gradle-js-plugin is worth it. I see one advantage: the things would be done correctly no need to worry about that. On the other hand it's maybe a lot of work for not that much to do every year or so when using retire.js. It could be done then. I'll ask the community on dev ML... > rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch, ecommerce-js2.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158644#comment-17158644 ] Alex Bodnaru commented on OFBIZ-11882: -- thank you Jacques, I'll change the approach asap > rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158637#comment-17158637 ] Jacques Le Roux commented on OFBIZ-11882: - Yes > rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158616#comment-17158616 ] Alex Bodnaru commented on OFBIZ-11882: -- pardon me, I didn't understand. will you accept such patch till the Gradle solution? tia > rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158613#comment-17158613 ] Jacques Le Roux commented on OFBIZ-11882: - OK for Gradle later > rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158609#comment-17158609 ] Alex Bodnaru commented on OFBIZ-11882: -- there's a much shorter way to fix for the mean time. changing only the map file name in each min file. would you accept that? > rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158604#comment-17158604 ] Alex Bodnaru commented on OFBIZ-11882: -- though i don't know how to do it with Gradle, the principle would be to keep the, say x.js as the source file, an minify it to generate both x.min.js and x.js.map. the problem, by now, is that the process is done incorrectly, so that the x.min.js points to a wrong map file. gradlew clean should delete both generated files. > rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158573#comment-17158573 ] Jacques Le Roux commented on OFBIZ-11882: - I understand. My point is to automate this with Gradle to not have to care about that in the future. The minification, maps, etc. would be done by Gradle, while runing Buildbot, then automatically included in the source. So tasks like OFBIZ-11752 would not thave to worry about those steps (minification, maps, etc. ) > rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158486#comment-17158486 ] Alex Bodnaru commented on OFBIZ-11882: -- the map files are provided with the minified css and js. as i told you before, there is a practice of making a concatenation of js files, and one of css. these concatenations may be minified, a process that also generates the map file. ofbiz does not concatenate the files, and each minifyied file does point to a map, hence i've just adjusted the map file names to the name in it's refering minifyed file. we may discuss this issue with the ofbiz developer that selected and downloaded the css and js files to be used in ofbiz. > rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158220#comment-17158220 ] Jacques Le Roux commented on OFBIZ-11882: - OK, after hastily reading the 1st section of https://www.html5rocks.com/en/tutorials/developertools/sourcemaps/ I know now what a js/css map file is. This looks like a task for CI. So https://github.com/eriwen/gradle-js-plugin sounds like the best option. [This sounds interesting|https://www.concurrenthashmap.com/blog/2017/10/08/gradle-tasks-for-javascript-and-css-minification-and-combination-using-threadpoolexecutor-for-parallel-execution/] as well, not sure we need it. Maybe [this|https://dzone.com/articles/javascript-webapps-gradle] is more up to date. So the idea is to dynamically build map files and place them in the right place when needed. > rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158071#comment-17158071 ] Jacques Le Roux commented on OFBIZ-11882: - There will be 2 methods, the later should replace the older # Look for "layoutSettings" in *een*.xml files # OFBIZ-11799 is a WIP, nothing done yet, you may participate... > rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158014#comment-17158014 ] Alex Bodnaru commented on OFBIZ-11882: -- how are the js/css files getting into ofbiz repository? there may be a flaw somewhere. > rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158013#comment-17158013 ] Alex Bodnaru commented on OFBIZ-11882: -- exactly these things were to be learned from a mentor. > rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158010#comment-17158010 ] Jacques Le Roux commented on OFBIZ-11882: - Hi Alex, We were using yuicompressor. It was conflicting with BIRT reporting tool, see: https://markmail.org/message/7kscgfexnldo2oyw. I don't think this has changed. BIRT is not evolving much nowadays. Here are links to possibler BIRT current situation: https://www.eclipse.org/birt/ https://www.eclipse.org/forums/index.php/t/1089223/ > rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158003#comment-17158003 ] Alex Bodnaru commented on OFBIZ-11882: -- the minifying process may need to be tuned up. > rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157916#comment-17157916 ] Alex Bodnaru commented on OFBIZ-11882: -- hello [~jleroux] , the name of the map file is inside the minified file. look, for example at : ecommerce/webapp/ecommerce/js/bootstrap/css/bootstrap-4.3.1.min.css /*# sourceMappingURL=bootstrap.min.css.map */ this line is created in the process of minifying. at a later time, yuicompressor may be included in the build process to unify and minify the js and css. hope that explains, alex > rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157885#comment-17157885 ] Jacques Le Roux commented on OFBIZ-11882: - Hi Alex, What's the rationale for that? We intentionally keep the real names for security reason: to easily update when necessary using retire.js > rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Trivial > Attachments: ecommerce-js.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
