[jira] [Commented] (OFBIZ-11886) Allow single line statements in checkstyle
[ https://issues.apache.org/jira/browse/OFBIZ-11886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17161799#comment-17161799 ] ASF subversion and git services commented on OFBIZ-11886: - Commit afa98bb8a6665484dd4f20815e20cb1b12b6a9d7 in ofbiz-framework's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=afa98bb ] Improved: Updated checkstyle.xml with allowSingleLineStatement as true, this brings down checkstyle maxErrors to 20037.(-625). (OFBIZ-11886) Thanks Jacques for your suggestions and comments. > Allow single line statements in checkstyle > -- > > Key: OFBIZ-11886 > URL: https://issues.apache.org/jira/browse/OFBIZ-11886 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11886-format-LoginServices-checkNewPassword.patch, > OFBIZ-11886-plugins.patch, OFBIZ-11886.patch, OFBIZ-11886.patch > > > We need to add this module in checkstyle.xml > > > > After this, single line statements like: > if (Debug.verboseOn()) Debug.logVerbose(...) > Will be considered safe. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11886) Allow single line statements in checkstyle
[ https://issues.apache.org/jira/browse/OFBIZ-11886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17161777#comment-17161777 ] ASF subversion and git services commented on OFBIZ-11886: - Commit 22ccc6801ffbfb31afc7147e207ace958d2ba54f in ofbiz-plugins's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=22ccc68 ] Improved: Corrected some single line statements to fix checkstyle issues, also removed some remaining extra spaces from code to avoid checkstyle erros in plugins component. (OFBIZ-11886) > Allow single line statements in checkstyle > -- > > Key: OFBIZ-11886 > URL: https://issues.apache.org/jira/browse/OFBIZ-11886 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11886-format-LoginServices-checkNewPassword.patch, > OFBIZ-11886-plugins.patch, OFBIZ-11886.patch, OFBIZ-11886.patch > > > We need to add this module in checkstyle.xml > > > > After this, single line statements like: > if (Debug.verboseOn()) Debug.logVerbose(...) > Will be considered safe. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11886) Allow single line statements in checkstyle
[ https://issues.apache.org/jira/browse/OFBIZ-11886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17161772#comment-17161772 ] ASF subversion and git services commented on OFBIZ-11886: - Commit 7b251e43d96dea3a4d98c3e77955575a90353ae3 in ofbiz-framework's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=7b251e4 ] Improved: Corrected some single line statements to fix checkstyle issues, also removed some remaining extra spaces from code to avoid checkstyle erros in framework component. (OFBIZ-11886) > Allow single line statements in checkstyle > -- > > Key: OFBIZ-11886 > URL: https://issues.apache.org/jira/browse/OFBIZ-11886 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11886-format-LoginServices-checkNewPassword.patch, > OFBIZ-11886-plugins.patch, OFBIZ-11886.patch, OFBIZ-11886.patch > > > We need to add this module in checkstyle.xml > > > > After this, single line statements like: > if (Debug.verboseOn()) Debug.logVerbose(...) > Will be considered safe. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11886) Allow single line statements in checkstyle
[ https://issues.apache.org/jira/browse/OFBIZ-11886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17161770#comment-17161770 ] ASF subversion and git services commented on OFBIZ-11886: - Commit 038d46e51d477c1c1082202bae928202ad3fde4d in ofbiz-framework's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=038d46e ] Improved: Corrected some single line statements to fix checkstyle issues, also removed some remaining extra spaces from code to avoid checkstyle erros in applications component. (OFBIZ-11886) > Allow single line statements in checkstyle > -- > > Key: OFBIZ-11886 > URL: https://issues.apache.org/jira/browse/OFBIZ-11886 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11886-format-LoginServices-checkNewPassword.patch, > OFBIZ-11886-plugins.patch, OFBIZ-11886.patch, OFBIZ-11886.patch > > > We need to add this module in checkstyle.xml > > > > After this, single line statements like: > if (Debug.verboseOn()) Debug.logVerbose(...) > Will be considered safe. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11886) Allow single line statements in checkstyle
[ https://issues.apache.org/jira/browse/OFBIZ-11886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160399#comment-17160399 ] Suraj Khurana commented on OFBIZ-11886: --- Thanks Jacques. I have corrected some straight forward occurrences of single line if statements, so I am planning to commit both, checkstyle patch and corrected occurrences. Please confirm if this looks good to you as well. > Allow single line statements in checkstyle > -- > > Key: OFBIZ-11886 > URL: https://issues.apache.org/jira/browse/OFBIZ-11886 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11886-format-LoginServices-checkNewPassword.patch, > OFBIZ-11886-plugins.patch, OFBIZ-11886.patch, OFBIZ-11886.patch > > > We need to add this module in checkstyle.xml > > > > After this, single line statements like: > if (Debug.verboseOn()) Debug.logVerbose(...) > Will be considered safe. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11886) Allow single line statements in checkstyle
[ https://issues.apache.org/jira/browse/OFBIZ-11886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160369#comment-17160369 ] Jacques Le Roux commented on OFBIZ-11886: - Following my last message in the thread, +1 for commit > Allow single line statements in checkstyle > -- > > Key: OFBIZ-11886 > URL: https://issues.apache.org/jira/browse/OFBIZ-11886 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11886-format-LoginServices-checkNewPassword.patch, > OFBIZ-11886.patch > > > We need to add this module in checkstyle.xml > > > > After this, single line statements like: > if (Debug.verboseOn()) Debug.logVerbose(...) > Will be considered safe. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11886) Allow single line statements in checkstyle
[ https://issues.apache.org/jira/browse/OFBIZ-11886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157318#comment-17157318 ] ASF subversion and git services commented on OFBIZ-11886: - Commit 33ca531db450d757399ff26a7300546731be0cef in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=33ca531 ] Improved: correct formatting of LoginServices This was a WIP related to "Allow single line statements in checkstyle" (OFBIZ-11886) but not really part of it. See OFBIZ-11886-format-LoginServices-checkNewPassword.patch. It may also include changes from "Checkstyle formatting issues: 'typecast' is not followed by whitespace" (OFBIZ-11887) > Allow single line statements in checkstyle > -- > > Key: OFBIZ-11886 > URL: https://issues.apache.org/jira/browse/OFBIZ-11886 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11886-format-LoginServices-checkNewPassword.patch, > OFBIZ-11886.patch > > > We need to add this module in checkstyle.xml > > > > After this, single line statements like: > if (Debug.verboseOn()) Debug.logVerbose(...) > Will be considered safe. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11886) Allow single line statements in checkstyle
[ https://issues.apache.org/jira/browse/OFBIZ-11886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157319#comment-17157319 ] ASF subversion and git services commented on OFBIZ-11886: - Commit 33ca531db450d757399ff26a7300546731be0cef in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=33ca531 ] Improved: correct formatting of LoginServices This was a WIP related to "Allow single line statements in checkstyle" (OFBIZ-11886) but not really part of it. See OFBIZ-11886-format-LoginServices-checkNewPassword.patch. It may also include changes from "Checkstyle formatting issues: 'typecast' is not followed by whitespace" (OFBIZ-11887) > Allow single line statements in checkstyle > -- > > Key: OFBIZ-11886 > URL: https://issues.apache.org/jira/browse/OFBIZ-11886 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11886-format-LoginServices-checkNewPassword.patch, > OFBIZ-11886.patch > > > We need to add this module in checkstyle.xml > > > > After this, single line statements like: > if (Debug.verboseOn()) Debug.logVerbose(...) > Will be considered safe. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11886) Allow single line statements in checkstyle
[ https://issues.apache.org/jira/browse/OFBIZ-11886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157209#comment-17157209 ] Jacques Le Roux commented on OFBIZ-11886: - Hi Suraj, I posted a message on the dev ML in [your "Single line statements - checkstyle" thread|https://markmail.org/message/ahf373lljgkypkxn]. Here is the patch I speak about there: [^OFBIZ-11886-format-LoginServices-checkNewPassword.patch] > Allow single line statements in checkstyle > -- > > Key: OFBIZ-11886 > URL: https://issues.apache.org/jira/browse/OFBIZ-11886 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11886-format-LoginServices-checkNewPassword.patch, > OFBIZ-11886.patch > > > We need to add this module in checkstyle.xml > > > > After this, single line statements like: > if (Debug.verboseOn()) Debug.logVerbose(...) > Will be considered safe. -- This message was sent by Atlassian Jira (v8.3.4#803005)
