[jira] [Commented] (OFBIZ-11887) Checkstyle formatting issues: 'typecast' is not followed by whitespace.
[ https://issues.apache.org/jira/browse/OFBIZ-11887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160353#comment-17160353 ] ASF subversion and git services commented on OFBIZ-11887: - Commit 2144763bc0f7130e443e48fd1a3835d352a577d7 in ofbiz-plugins's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=2144763 ] Improved: Corrected all checkstyle formatting issues: 'typecast' is not followed by whitespace in plugins component. (OFBIZ-11887) > Checkstyle formatting issues: 'typecast' is not followed by whitespace. > --- > > Key: OFBIZ-11887 > URL: https://issues.apache.org/jira/browse/OFBIZ-11887 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11887-plugins.patch, OFBIZ-11887.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11887) Checkstyle formatting issues: 'typecast' is not followed by whitespace.
[ https://issues.apache.org/jira/browse/OFBIZ-11887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160354#comment-17160354 ] ASF subversion and git services commented on OFBIZ-11887: - Commit 8b1e0dbd8539a3fb325221e013d3a6d1824b8210 in ofbiz-framework's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=8b1e0db ] Improved: Corrected all checkstyle formatting issues: 'typecast' is not followed by whitespace in framework component. (OFBIZ-11887) > Checkstyle formatting issues: 'typecast' is not followed by whitespace. > --- > > Key: OFBIZ-11887 > URL: https://issues.apache.org/jira/browse/OFBIZ-11887 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11887-plugins.patch, OFBIZ-11887.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11887) Checkstyle formatting issues: 'typecast' is not followed by whitespace.
[ https://issues.apache.org/jira/browse/OFBIZ-11887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160352#comment-17160352 ] ASF subversion and git services commented on OFBIZ-11887: - Commit 0524945bda30dd3603ee3202bf02bbead3d8bfdd in ofbiz-framework's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=0524945 ] Improved: Corrected all checkstyle formatting issues: 'typecast' is not followed by whitespace in applications component. (OFBIZ-11887) > Checkstyle formatting issues: 'typecast' is not followed by whitespace. > --- > > Key: OFBIZ-11887 > URL: https://issues.apache.org/jira/browse/OFBIZ-11887 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11887-plugins.patch, OFBIZ-11887.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11887) Checkstyle formatting issues: 'typecast' is not followed by whitespace.
[ https://issues.apache.org/jira/browse/OFBIZ-11887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157323#comment-17157323 ] Jacques Le Roux commented on OFBIZ-11887: - Hi Suraj, I was unsure because we have a lot of them and I used to do the same (no space after cast). So I checked, both Oracle ((actually initially Sun) and Google say the same than you Suraj: https://www.oracle.com/technetwork/java/javase/documentation/codeconventions-141388.html https://google.github.io/styleguide/javaguide.html#s4.6-whitespace I then tested the patches and they are OK with me: +1 for commit > Checkstyle formatting issues: 'typecast' is not followed by whitespace. > --- > > Key: OFBIZ-11887 > URL: https://issues.apache.org/jira/browse/OFBIZ-11887 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11887-plugins.patch, OFBIZ-11887.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11887) Checkstyle formatting issues: 'typecast' is not followed by whitespace.
[ https://issues.apache.org/jira/browse/OFBIZ-11887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157320#comment-17157320 ] ASF subversion and git services commented on OFBIZ-11887: - Commit 33ca531db450d757399ff26a7300546731be0cef in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=33ca531 ] Improved: correct formatting of LoginServices This was a WIP related to "Allow single line statements in checkstyle" (OFBIZ-11886) but not really part of it. See OFBIZ-11886-format-LoginServices-checkNewPassword.patch. It may also include changes from "Checkstyle formatting issues: 'typecast' is not followed by whitespace" (OFBIZ-11887) > Checkstyle formatting issues: 'typecast' is not followed by whitespace. > --- > > Key: OFBIZ-11887 > URL: https://issues.apache.org/jira/browse/OFBIZ-11887 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11887-plugins.patch, OFBIZ-11887.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
