[jira] [Commented] (OFBIZ-11894) Convert createRoleType service to entity-auto from Java and update its service calls
[ https://issues.apache.org/jira/browse/OFBIZ-11894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162501#comment-17162501 ] ASF subversion and git services commented on OFBIZ-11894: - Commit 679b2883e143105f35313807b4fc028b65c1e092 in ofbiz-framework's branch refs/heads/trunk from Priya Sharma [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=679b288 ] Improved : Convert createRoleType service to entity-auto from Java and update its service calls (OFBIZ-11894) (#215) (OFBIZ-11894) * Improved: Convert createRoleType service to entity-auto from Java and update its service calls - Removed the java implementation - Converted the service to entity-auto - updated the service call in Party tests where this service was used. * Improved: Removed the testCreateRoleType test, as the base service is now converted to entity-auto and will be handled in entity-auto tests. (OFBIZ-11984) Co-authored-by: Priya Sharma Thanks: Pawan Verma for review. > Convert createRoleType service to entity-auto from Java and update its > service calls > > > Key: OFBIZ-11894 > URL: https://issues.apache.org/jira/browse/OFBIZ-11894 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Suraj Khurana >Priority: Minor > > Convert createRoleType service to entity-auto from Java and update its > service calls > Service should return roleTypeId instead of GenericValue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11894) Convert createRoleType service to entity-auto from Java and update its service calls
[ https://issues.apache.org/jira/browse/OFBIZ-11894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162500#comment-17162500 ] ASF subversion and git services commented on OFBIZ-11894: - Commit 679b2883e143105f35313807b4fc028b65c1e092 in ofbiz-framework's branch refs/heads/trunk from Priya Sharma [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=679b288 ] Improved : Convert createRoleType service to entity-auto from Java and update its service calls (OFBIZ-11894) (#215) (OFBIZ-11894) * Improved: Convert createRoleType service to entity-auto from Java and update its service calls - Removed the java implementation - Converted the service to entity-auto - updated the service call in Party tests where this service was used. * Improved: Removed the testCreateRoleType test, as the base service is now converted to entity-auto and will be handled in entity-auto tests. (OFBIZ-11984) Co-authored-by: Priya Sharma Thanks: Pawan Verma for review. > Convert createRoleType service to entity-auto from Java and update its > service calls > > > Key: OFBIZ-11894 > URL: https://issues.apache.org/jira/browse/OFBIZ-11894 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Suraj Khurana >Priority: Minor > > Convert createRoleType service to entity-auto from Java and update its > service calls > Service should return roleTypeId instead of GenericValue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11894) Convert createRoleType service to entity-auto from Java and update its service calls
[ https://issues.apache.org/jira/browse/OFBIZ-11894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17161252#comment-17161252 ] Suraj Khurana commented on OFBIZ-11894: --- Looks good, let's wait for couple of days in case of any further suggestions or reviews. > Convert createRoleType service to entity-auto from Java and update its > service calls > > > Key: OFBIZ-11894 > URL: https://issues.apache.org/jira/browse/OFBIZ-11894 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Minor > > Convert createRoleType service to entity-auto from Java and update its > service calls > Service should return roleTypeId instead of GenericValue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11894) Convert createRoleType service to entity-auto from Java and update its service calls
[ https://issues.apache.org/jira/browse/OFBIZ-11894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17161013#comment-17161013 ] Pawan Verma commented on OFBIZ-11894: - Thanks, [~priya.sharma.9362] [~surajk] I've approved the PR, if it looks good to you please go ahead and merge :) > Convert createRoleType service to entity-auto from Java and update its > service calls > > > Key: OFBIZ-11894 > URL: https://issues.apache.org/jira/browse/OFBIZ-11894 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Minor > > Convert createRoleType service to entity-auto from Java and update its > service calls > Service should return roleTypeId instead of GenericValue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11894) Convert createRoleType service to entity-auto from Java and update its service calls
[ https://issues.apache.org/jira/browse/OFBIZ-11894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160998#comment-17160998 ] Priya Sharma commented on OFBIZ-11894: -- Thanks Suraj and Pawan! I have updated the PR with the suggested change. > Convert createRoleType service to entity-auto from Java and update its > service calls > > > Key: OFBIZ-11894 > URL: https://issues.apache.org/jira/browse/OFBIZ-11894 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Minor > > Convert createRoleType service to entity-auto from Java and update its > service calls > Service should return roleTypeId instead of GenericValue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11894) Convert createRoleType service to entity-auto from Java and update its service calls
[ https://issues.apache.org/jira/browse/OFBIZ-11894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160898#comment-17160898 ] Pawan Verma commented on OFBIZ-11894: - +1 Suraj, Good point. [~priya.sharma.9362] Lets remove the test case, it's not needed now. > Convert createRoleType service to entity-auto from Java and update its > service calls > > > Key: OFBIZ-11894 > URL: https://issues.apache.org/jira/browse/OFBIZ-11894 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Minor > > Convert createRoleType service to entity-auto from Java and update its > service calls > Service should return roleTypeId instead of GenericValue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11894) Convert createRoleType service to entity-auto from Java and update its service calls
[ https://issues.apache.org/jira/browse/OFBIZ-11894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160894#comment-17160894 ] Suraj Khurana commented on OFBIZ-11894: --- +1, looks good to me. Also, shouldn't we remove the testCreateRoleType service as base service has been moved to entity-auto? We have entity-auto tests available already. WDYT? > Convert createRoleType service to entity-auto from Java and update its > service calls > > > Key: OFBIZ-11894 > URL: https://issues.apache.org/jira/browse/OFBIZ-11894 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Minor > > Convert createRoleType service to entity-auto from Java and update its > service calls > Service should return roleTypeId instead of GenericValue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11894) Convert createRoleType service to entity-auto from Java and update its service calls
[ https://issues.apache.org/jira/browse/OFBIZ-11894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160667#comment-17160667 ] Pawan Verma commented on OFBIZ-11894: - Hi [~priya.sharma.9362] Thanks for your quick work, it looks good to me :) I've tested it locally it works well, thanks again! will merge soon. > Convert createRoleType service to entity-auto from Java and update its > service calls > > > Key: OFBIZ-11894 > URL: https://issues.apache.org/jira/browse/OFBIZ-11894 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Minor > > Convert createRoleType service to entity-auto from Java and update its > service calls > Service should return roleTypeId instead of GenericValue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11894) Convert createRoleType service to entity-auto from Java and update its service calls
[ https://issues.apache.org/jira/browse/OFBIZ-11894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160657#comment-17160657 ] Priya Sharma commented on OFBIZ-11894: -- Hi Pawan, I have created a PR for this task. Please review it and let me know if any updates are needed. TIA! > Convert createRoleType service to entity-auto from Java and update its > service calls > > > Key: OFBIZ-11894 > URL: https://issues.apache.org/jira/browse/OFBIZ-11894 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Priya Sharma >Priority: Minor > > Convert createRoleType service to entity-auto from Java and update its > service calls > Service should return roleTypeId instead of GenericValue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11894) Convert createRoleType service to entity-auto from Java and update its service calls
[ https://issues.apache.org/jira/browse/OFBIZ-11894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159964#comment-17159964 ] Suraj Khurana commented on OFBIZ-11894: --- +1 > Convert createRoleType service to entity-auto from Java and update its > service calls > > > Key: OFBIZ-11894 > URL: https://issues.apache.org/jira/browse/OFBIZ-11894 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Pawan Verma >Priority: Minor > > Convert createRoleType service to entity-auto from Java and update its > service calls > Service should return roleTypeId instead of GenericValue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
