[jira] [Commented] (OFBIZ-11996) Well-formed html in ftl template
[ https://issues.apache.org/jira/browse/OFBIZ-11996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17467632#comment-17467632 ] Jacques Le Roux commented on OFBIZ-11996: - Hi James, What the situation here, should we not close? > Well-formed html in ftl template > > > Key: OFBIZ-11996 > URL: https://issues.apache.org/jira/browse/OFBIZ-11996 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11996.patch > > > Check for well-formed html in ftl templates to catch programming errors. > To test, set print.verbose=true and start up ofbiz. > Misformed HTML fragments are logged as warnings. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-11996) Well-formed html in ftl template
[ https://issues.apache.org/jira/browse/OFBIZ-11996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17193520#comment-17193520 ] ASF subversion and git services commented on OFBIZ-11996: - Commit a74eac00601c6f4cac5a99d1b9b8f0b42b727744 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a74eac0 ] Fixed: Well-formed html in ftl template (OFBIZ-11996) Fixes Java method names issues Thanks: Girish > Well-formed html in ftl template > > > Key: OFBIZ-11996 > URL: https://issues.apache.org/jira/browse/OFBIZ-11996 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11996.patch > > > Check for well-formed html in ftl templates to catch programming errors. > To test, set print.verbose=true and start up ofbiz. > Then navigate to the page and search for ^^^ in the log console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11996) Well-formed html in ftl template
[ https://issues.apache.org/jira/browse/OFBIZ-11996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17193487#comment-17193487 ] ASF subversion and git services commented on OFBIZ-11996: - Commit 161c0c0c05ad33474779706cf8bf1d548528f817 in ofbiz-framework's branch refs/heads/trunk from James Yong [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=161c0c0 ] Improved: Well-formed html in ftl template (OFBIZ-11996) refactoring + add test case > Well-formed html in ftl template > > > Key: OFBIZ-11996 > URL: https://issues.apache.org/jira/browse/OFBIZ-11996 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11996.patch > > > Check for well-formed html in ftl templates to catch programming errors. > To test, set print.verbose=true and start up ofbiz. > Then navigate to the page and search for ^^^ in the log console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11996) Well-formed html in ftl template
[ https://issues.apache.org/jira/browse/OFBIZ-11996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17193376#comment-17193376 ] ASF subversion and git services commented on OFBIZ-11996: - Commit aab02b514275a096f5bbb2dbb04ead601e0cfc62 in ofbiz-framework's branch refs/heads/trunk from James Yong [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=aab02b5 ] Improved: Well-formed html in ftl template (OFBIZ-11996) Add code to check closing tags and refactoring > Well-formed html in ftl template > > > Key: OFBIZ-11996 > URL: https://issues.apache.org/jira/browse/OFBIZ-11996 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11996.patch > > > Check for well-formed html in ftl templates to catch programming errors. > To test, set print.verbose=true and start up ofbiz. > Then navigate to the page and search for ^^^ in the log console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11996) Well-formed html in ftl template
[ https://issues.apache.org/jira/browse/OFBIZ-11996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191758#comment-17191758 ] James Yong commented on OFBIZ-11996: Agree parameterized list is better. Thanks Jacques. > Well-formed html in ftl template > > > Key: OFBIZ-11996 > URL: https://issues.apache.org/jira/browse/OFBIZ-11996 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11996.patch > > > Check for well-formed html in ftl templates to catch programming errors. > To test, set print.verbose=true and start up ofbiz. > Then navigate to the page and search for ^^^ in the log console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11996) Well-formed html in ftl template
[
https://issues.apache.org/jira/browse/OFBIZ-11996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191583#comment-17191583
]
Jacques Le Roux commented on OFBIZ-11996:
-
Hi James,
Actually it's not Spotbugs (I removed its marks to be sure) but Eclipse. The
other solution (preferred IMO) is to parameterize the type of the list.
{code:java}
if (parser.isTrackErrors()) {
List list = parser.getErrors();
list.forEach(logError);
}
{code}
> Well-formed html in ftl template
>
>
> Key: OFBIZ-11996
> URL: https://issues.apache.org/jira/browse/OFBIZ-11996
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11996.patch
>
>
> Check for well-formed html in ftl templates to catch programming errors.
> To test, set print.verbose=true and start up ofbiz.
> Then navigate to the page and search for ^^^ in the log console.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11996) Well-formed html in ftl template
[
https://issues.apache.org/jira/browse/OFBIZ-11996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191237#comment-17191237
]
James Yong commented on OFBIZ-11996:
Hi Jacques,
Thanks for letting me know about SpotBugs.
I am using Intellij which indicates the casting is redundant.
{code:java}
ParseErrorList list = (ParseErrorList) parser.getErrors();
{code}
> Well-formed html in ftl template
>
>
> Key: OFBIZ-11996
> URL: https://issues.apache.org/jira/browse/OFBIZ-11996
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11996.patch
>
>
> Check for well-formed html in ftl templates to catch programming errors.
> To test, set print.verbose=true and start up ofbiz.
> Then navigate to the page and search for ^^^ in the log console.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11996) Well-formed html in ftl template
[ https://issues.apache.org/jira/browse/OFBIZ-11996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191236#comment-17191236 ] ASF subversion and git services commented on OFBIZ-11996: - Commit d322ae51e31e9f8ba60cb59683fbabb06c4d2b6a in ofbiz-framework's branch refs/heads/trunk from James Yong [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=d322ae5 ] Improved: Well-formed html in ftl template (OFBIZ-11996) fix checkstyle issue > Well-formed html in ftl template > > > Key: OFBIZ-11996 > URL: https://issues.apache.org/jira/browse/OFBIZ-11996 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11996.patch > > > Check for well-formed html in ftl templates to catch programming errors. > To test, set print.verbose=true and start up ofbiz. > Then navigate to the page and search for ^^^ in the log console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11996) Well-formed html in ftl template
[ https://issues.apache.org/jira/browse/OFBIZ-11996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191164#comment-17191164 ] ASF subversion and git services commented on OFBIZ-11996: - Commit 8cbdb6a225eed7b4571840bf6ff9cbe139ae088c in ofbiz-framework's branch refs/heads/trunk from James Yong [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=8cbdb6a ] Improved: Well-formed html in ftl template (OFBIZ-11996) When print.verbose=true, check for well-formed html in ftl templates to catch programming errors. > Well-formed html in ftl template > > > Key: OFBIZ-11996 > URL: https://issues.apache.org/jira/browse/OFBIZ-11996 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11996.patch > > > When print.verbose=true, check for well-formed html in ftl templates to catch > programming errors. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11996) Well-formed html in ftl template
[ https://issues.apache.org/jira/browse/OFBIZ-11996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191031#comment-17191031 ] James Yong commented on OFBIZ-11996: Hi Jacques, Thanks for the review. Forgot to mention that the check is only done when print.verbose=true Regards, James > Well-formed html in ftl template > > > Key: OFBIZ-11996 > URL: https://issues.apache.org/jira/browse/OFBIZ-11996 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11996.patch > > > Check for well-formed html in ftl templates to catch programming errors. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11996) Well-formed html in ftl template
[
https://issues.apache.org/jira/browse/OFBIZ-11996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191027#comment-17191027
]
Jacques Le Roux commented on OFBIZ-11996:
-
Ah, Spotbugs suggests a cast here:
{code:java}
// print any parse error
if (parser.isTrackErrors()) {
ParseErrorList list = (ParseErrorList) parser.getErrors();
list.forEach(logError);
}
{code}
> Well-formed html in ftl template
>
>
> Key: OFBIZ-11996
> URL: https://issues.apache.org/jira/browse/OFBIZ-11996
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11996.patch
>
>
> Check for well-formed html in ftl templates to catch programming errors.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11996) Well-formed html in ftl template
[ https://issues.apache.org/jira/browse/OFBIZ-11996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191026#comment-17191026 ] Jacques Le Roux commented on OFBIZ-11996: - Hi James, Mainly tested (cursorily review), works here, +1 for commit > Well-formed html in ftl template > > > Key: OFBIZ-11996 > URL: https://issues.apache.org/jira/browse/OFBIZ-11996 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11996.patch > > > Check for well-formed html in ftl templates to catch programming errors. -- This message was sent by Atlassian Jira (v8.3.4#803005)
