[jira] [Commented] (OFBIZ-12057) Prevent arbitary file write using webtools/control/EntitySQLProcessor.

2020-11-16 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17232745#comment-17232745
 ] 

ASF subversion and git services commented on OFBIZ-12057:
-

Commit f34a0d9ff584ff139b9d302ba46a6243138107c1 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=f34a0d9 ]

Fixed: Prevent arbitary file write using webtools/control/EntitySQLProcessor. 
(OFBIZ-12057)

Shuibo Ye  reported a possible arbitary file write using
webtools/control/EntitySQLProcessor.

In the "SQL Command" part, I create a table and insert some strings and
export the table to a file one sentence at a time.
PoC: CREATE TABLE "test" (string VARCHAR(80))
INSERT INTO "test" (string) VALUES ('<%= system.getProperty("user.dir") %>')
call 
SYSCS_UTIL.SYSCS_EXPORT_TABLE(null,'test','.\framework\webtools\webapp\webtools\default.jsp',null,'*',null)

After executing the three sentences,I successfully write the file and its 
url
is https://localhost:8443/webtools/default.jsp.

I fixed it preventing execution on SYSCS_UTIL.SYSCS_EXPORT_TABLE and JSP, more
could be added if necessary


> Prevent arbitary file write using webtools/control/EntitySQLProcessor.
> --
>
> Key: OFBIZ-12057
> URL: https://issues.apache.org/jira/browse/OFBIZ-12057
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> Shuibo Ye  reported a possible arbitary file write using 
> webtools/control/EntitySQLProcessor.
> {quote}
> In the "SQL Command" part, I create a table and insert some strings and 
> export the table to a file *one sentence at a time*.
> PoC:  CREATE TABLE "test" (string VARCHAR(80))
> INSERT INTO "test" (string) VALUES ('<%= 
> system.getProperty("user.dir") %>')
> call 
> SYSCS_UTIL.SYSCS_EXPORT_TABLE(null,'test','.\framework\webtools\webapp\webtools\default.jsp',null,'*',null)
> After executing the three sentences,I successfully write the file and its url 
> is https://localhost:8443/webtools/default.jsp.
> {quote}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12057) Prevent arbitary file write using webtools/control/EntitySQLProcessor.

2020-11-16 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17232744#comment-17232744
 ] 

ASF subversion and git services commented on OFBIZ-12057:
-

Commit 792f45773fd062fe1f57f5b1af9da9e65637ec54 in ofbiz-framework's branch 
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=792f457 ]

Fixed: Prevent arbitary file write using webtools/control/EntitySQLProcessor. 
(OFBIZ-12057)

Shuibo Ye  reported a possible arbitary file write using
webtools/control/EntitySQLProcessor.

In the "SQL Command" part, I create a table and insert some strings and
export the table to a file one sentence at a time.
PoC: CREATE TABLE "test" (string VARCHAR(80))
INSERT INTO "test" (string) VALUES ('<%= system.getProperty("user.dir") %>')
call 
SYSCS_UTIL.SYSCS_EXPORT_TABLE(null,'test','.\framework\webtools\webapp\webtools\default.jsp',null,'*',null)

After executing the three sentences,I successfully write the file and its 
url
is https://localhost:8443/webtools/default.jsp.

I fixed it preventing execution on SYSCS_UTIL.SYSCS_EXPORT_TABLE and JSP, more
could be added if necessary


> Prevent arbitary file write using webtools/control/EntitySQLProcessor.
> --
>
> Key: OFBIZ-12057
> URL: https://issues.apache.org/jira/browse/OFBIZ-12057
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> Shuibo Ye  reported a possible arbitary file write using 
> webtools/control/EntitySQLProcessor.
> {quote}
> In the "SQL Command" part, I create a table and insert some strings and 
> export the table to a file *one sentence at a time*.
> PoC:  CREATE TABLE "test" (string VARCHAR(80))
> INSERT INTO "test" (string) VALUES ('<%= 
> system.getProperty("user.dir") %>')
> call 
> SYSCS_UTIL.SYSCS_EXPORT_TABLE(null,'test','.\framework\webtools\webapp\webtools\default.jsp',null,'*',null)
> After executing the three sentences,I successfully write the file and its url 
> is https://localhost:8443/webtools/default.jsp.
> {quote}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12057) Prevent arbitary file write using webtools/control/EntitySQLProcessor.

2020-11-16 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17232743#comment-17232743
 ] 

ASF subversion and git services commented on OFBIZ-12057:
-

Commit 28a6d4391a2c309f30b6320733fd9f9d8eb1711f in ofbiz-framework's branch 
refs/heads/release17.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=28a6d43 ]

Fixed: Prevent arbitary file write using webtools/control/EntitySQLProcessor. 
(OFBIZ-12057)

Shuibo Ye  reported a possible arbitary file write using
webtools/control/EntitySQLProcessor.

In the "SQL Command" part, I create a table and insert some strings and
export the table to a file one sentence at a time.
PoC: CREATE TABLE "test" (string VARCHAR(80))
INSERT INTO "test" (string) VALUES ('<%= system.getProperty("user.dir") %>')
call 
SYSCS_UTIL.SYSCS_EXPORT_TABLE(null,'test','.\framework\webtools\webapp\webtools\default.jsp',null,'*',null)

After executing the three sentences,I successfully write the file and its 
url
is https://localhost:8443/webtools/default.jsp.

I fixed it preventing execution on SYSCS_UTIL.SYSCS_EXPORT_TABLE and JSP, more
could be added if necessary


> Prevent arbitary file write using webtools/control/EntitySQLProcessor.
> --
>
> Key: OFBIZ-12057
> URL: https://issues.apache.org/jira/browse/OFBIZ-12057
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> Shuibo Ye  reported a possible arbitary file write using 
> webtools/control/EntitySQLProcessor.
> {quote}
> In the "SQL Command" part, I create a table and insert some strings and 
> export the table to a file *one sentence at a time*.
> PoC:  CREATE TABLE "test" (string VARCHAR(80))
> INSERT INTO "test" (string) VALUES ('<%= 
> system.getProperty("user.dir") %>')
> call 
> SYSCS_UTIL.SYSCS_EXPORT_TABLE(null,'test','.\framework\webtools\webapp\webtools\default.jsp',null,'*',null)
> After executing the three sentences,I successfully write the file and its url 
> is https://localhost:8443/webtools/default.jsp.
> {quote}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)