[jira] [Commented] (OFBIZ-12233) Plugin not showing in menu due to permission
[
https://issues.apache.org/jira/browse/OFBIZ-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346040#comment-17346040
]
Jacques Le Roux commented on OFBIZ-12233:
-
I wanted to assign to Gaetan, but it's impossible (no Gaetan in Jira, weird)
> Plugin not showing in menu due to permission
> -
>
> Key: OFBIZ-12233
> URL: https://issues.apache.org/jira/browse/OFBIZ-12233
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Upcoming
> Branch
> Environment: openjdk 11.0.11 2021-04-20
> OpenJDK Runtime Environment (build 11.0.11+9-Ubuntu-0ubuntu2.20.04)
> OpenJDK 64-Bit Server VM (build 11.0.11+9-Ubuntu-0ubuntu2.20.04, mixed mode,
> sharing)
> Ubuntu 20.04.2 LTS
>Reporter: Gaetan Chaboussie
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 18.12.01, Release Branch 17.12
>
> Attachments: OFBIZ-12233.patch
>
>
> When creating a plugin via gradle :
> {code}
> ./gradlew createPlugin -PpluginId=plugin-test -PpluginResourceName=PluginTest
> -PwebappName=plugin-test -PbasePermission=PLUGIN_TEST
> {code}
> and loading all the required data and permissions, the plugin doesn"t appear
> in the menu.
> I think it comes from the ComponentConfig.java file, L1229, when the
> permissions gets trimmed and modified. Are those lines still useful ?
> I tried removing it locally and it fixed the problem.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12233) Plugin not showing in menu due to permission
[
https://issues.apache.org/jira/browse/OFBIZ-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346037#comment-17346037
]
ASF subversion and git services commented on OFBIZ-12233:
-
Commit fb0701b7bdf0e5c0e75f51237e2ee85689413b51 in ofbiz-framework's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=fb0701b ]
Fixed: Plugin not showing in menu due to permission (OFBIZ-12233)
When creating a plugin via gradle :
./gradlew createPlugin -PpluginId=plugin-test -PpluginResourceName=PluginTest
-PwebappName=plugin-test -PbasePermission=PLUGIN_TEST
and loading all the required data and permissions, the plugin doesn't appear
in the menu.
It comes from the ComponentConfig.java file, L1229, when the permissions gets
trimmed and modified. I tried removing it locally and it fixed the problem.
Thanks: Gaetan Chaboussie
> Plugin not showing in menu due to permission
> -
>
> Key: OFBIZ-12233
> URL: https://issues.apache.org/jira/browse/OFBIZ-12233
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Upcoming
> Branch
> Environment: openjdk 11.0.11 2021-04-20
> OpenJDK Runtime Environment (build 11.0.11+9-Ubuntu-0ubuntu2.20.04)
> OpenJDK 64-Bit Server VM (build 11.0.11+9-Ubuntu-0ubuntu2.20.04, mixed mode,
> sharing)
> Ubuntu 20.04.2 LTS
>Reporter: Gaetan Chaboussie
>Priority: Minor
> Attachments: OFBIZ-12233.patch
>
>
> When creating a plugin via gradle :
> {code}
> ./gradlew createPlugin -PpluginId=plugin-test -PpluginResourceName=PluginTest
> -PwebappName=plugin-test -PbasePermission=PLUGIN_TEST
> {code}
> and loading all the required data and permissions, the plugin doesn"t appear
> in the menu.
> I think it comes from the ComponentConfig.java file, L1229, when the
> permissions gets trimmed and modified. Are those lines still useful ?
> I tried removing it locally and it fixed the problem.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12233) Plugin not showing in menu due to permission
[
https://issues.apache.org/jira/browse/OFBIZ-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346035#comment-17346035
]
ASF subversion and git services commented on OFBIZ-12233:
-
Commit 69ce0dffc88a35a5a4753754e36685c6824ad43a in ofbiz-framework's branch
refs/heads/release17.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=69ce0df ]
Fixed: Plugin not showing in menu due to permission (OFBIZ-12233)
When creating a plugin via gradle :
./gradlew createPlugin -PpluginId=plugin-test -PpluginResourceName=PluginTest
-PwebappName=plugin-test -PbasePermission=PLUGIN_TEST
and loading all the required data and permissions, the plugin doesn't appear
in the menu.
It comes from the ComponentConfig.java file, L1229, when the permissions gets
trimmed and modified. I tried removing it locally and it fixed the problem.
Thanks: Gaetan Chaboussie
> Plugin not showing in menu due to permission
> -
>
> Key: OFBIZ-12233
> URL: https://issues.apache.org/jira/browse/OFBIZ-12233
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Upcoming
> Branch
> Environment: openjdk 11.0.11 2021-04-20
> OpenJDK Runtime Environment (build 11.0.11+9-Ubuntu-0ubuntu2.20.04)
> OpenJDK 64-Bit Server VM (build 11.0.11+9-Ubuntu-0ubuntu2.20.04, mixed mode,
> sharing)
> Ubuntu 20.04.2 LTS
>Reporter: Gaetan Chaboussie
>Priority: Minor
> Attachments: OFBIZ-12233.patch
>
>
> When creating a plugin via gradle :
> {code}
> ./gradlew createPlugin -PpluginId=plugin-test -PpluginResourceName=PluginTest
> -PwebappName=plugin-test -PbasePermission=PLUGIN_TEST
> {code}
> and loading all the required data and permissions, the plugin doesn"t appear
> in the menu.
> I think it comes from the ComponentConfig.java file, L1229, when the
> permissions gets trimmed and modified. Are those lines still useful ?
> I tried removing it locally and it fixed the problem.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12233) Plugin not showing in menu due to permission
[
https://issues.apache.org/jira/browse/OFBIZ-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346036#comment-17346036
]
ASF subversion and git services commented on OFBIZ-12233:
-
Commit b8f9c029cedea15d6145a6325e8b203a05bd27cf in ofbiz-framework's branch
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b8f9c02 ]
Fixed: Plugin not showing in menu due to permission (OFBIZ-12233)
When creating a plugin via gradle :
./gradlew createPlugin -PpluginId=plugin-test -PpluginResourceName=PluginTest
-PwebappName=plugin-test -PbasePermission=PLUGIN_TEST
and loading all the required data and permissions, the plugin doesn't appear
in the menu.
It comes from the ComponentConfig.java file, L1229, when the permissions gets
trimmed and modified. I tried removing it locally and it fixed the problem.
Thanks: Gaetan Chaboussie
> Plugin not showing in menu due to permission
> -
>
> Key: OFBIZ-12233
> URL: https://issues.apache.org/jira/browse/OFBIZ-12233
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Upcoming
> Branch
> Environment: openjdk 11.0.11 2021-04-20
> OpenJDK Runtime Environment (build 11.0.11+9-Ubuntu-0ubuntu2.20.04)
> OpenJDK 64-Bit Server VM (build 11.0.11+9-Ubuntu-0ubuntu2.20.04, mixed mode,
> sharing)
> Ubuntu 20.04.2 LTS
>Reporter: Gaetan Chaboussie
>Priority: Minor
> Attachments: OFBIZ-12233.patch
>
>
> When creating a plugin via gradle :
> {code}
> ./gradlew createPlugin -PpluginId=plugin-test -PpluginResourceName=PluginTest
> -PwebappName=plugin-test -PbasePermission=PLUGIN_TEST
> {code}
> and loading all the required data and permissions, the plugin doesn"t appear
> in the menu.
> I think it comes from the ComponentConfig.java file, L1229, when the
> permissions gets trimmed and modified. Are those lines still useful ?
> I tried removing it locally and it fixed the problem.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12233) Plugin not showing in menu due to permission
[
https://issues.apache.org/jira/browse/OFBIZ-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17345657#comment-17345657
]
Michael Brohl commented on OFBIZ-12233:
---
+1, we use a lot of plugins named with a minus sign in our projects without
issues.
> Plugin not showing in menu due to permission
> -
>
> Key: OFBIZ-12233
> URL: https://issues.apache.org/jira/browse/OFBIZ-12233
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Upcoming
> Branch
> Environment: openjdk 11.0.11 2021-04-20
> OpenJDK Runtime Environment (build 11.0.11+9-Ubuntu-0ubuntu2.20.04)
> OpenJDK 64-Bit Server VM (build 11.0.11+9-Ubuntu-0ubuntu2.20.04, mixed mode,
> sharing)
> Ubuntu 20.04.2 LTS
>Reporter: Gaetan Chaboussie
>Priority: Minor
> Attachments: OFBIZ-12233.patch
>
>
> When creating a plugin via gradle :
> {code}
> ./gradlew createPlugin -PpluginId=plugin-test -PpluginResourceName=PluginTest
> -PwebappName=plugin-test -PbasePermission=PLUGIN_TEST
> {code}
> and loading all the required data and permissions, the plugin doesn"t appear
> in the menu.
> I think it comes from the ComponentConfig.java file, L1229, when the
> permissions gets trimmed and modified. Are those lines still useful ?
> I tried removing it locally and it fixed the problem.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12233) Plugin not showing in menu due to permission
[
https://issues.apache.org/jira/browse/OFBIZ-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17345652#comment-17345652
]
Gil Portenseigne commented on OFBIZ-12233:
--
+1 to commit, there is no technical issue using "-" and i''m not aware of any
plugin naming convention forbidding that.
> Plugin not showing in menu due to permission
> -
>
> Key: OFBIZ-12233
> URL: https://issues.apache.org/jira/browse/OFBIZ-12233
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Upcoming
> Branch
> Environment: openjdk 11.0.11 2021-04-20
> OpenJDK Runtime Environment (build 11.0.11+9-Ubuntu-0ubuntu2.20.04)
> OpenJDK 64-Bit Server VM (build 11.0.11+9-Ubuntu-0ubuntu2.20.04, mixed mode,
> sharing)
> Ubuntu 20.04.2 LTS
>Reporter: Gaetan Chaboussie
>Priority: Minor
> Attachments: OFBIZ-12233.patch
>
>
> When creating a plugin via gradle :
> {code}
> ./gradlew createPlugin -PpluginId=plugin-test -PpluginResourceName=PluginTest
> -PwebappName=plugin-test -PbasePermission=PLUGIN_TEST
> {code}
> and loading all the required data and permissions, the plugin doesn"t appear
> in the menu.
> I think it comes from the ComponentConfig.java file, L1229, when the
> permissions gets trimmed and modified. Are those lines still useful ?
> I tried removing it locally and it fixed the problem.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12233) Plugin not showing in menu due to permission
[
https://issues.apache.org/jira/browse/OFBIZ-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344658#comment-17344658
]
Jacques Le Roux commented on OFBIZ-12233:
-
Hi Gaetan,
After loading date from PluginTestSecurityGroupDemoData.xml according to
https://markmail.org/message/b6iz7g27xuow4sgr, your patch works for me and does
the job since it's only about removing spaces from permissions, as the related
comment says:
bq. // trim the permissions (remove spaces)
I confirm that it has no side effects and the plugin does not show in menu w/o.
If you get to https://localhost:8443/plugin-test/control/main you get this
error and more in log:
bq. java.lang.IllegalArgumentException: Could not find resource bundle
[PluginTestUiLabels] in the locale [fr]
using English instead of French does not change, adding French labels fixes the
issue. Maybe we could add French label as default in the plugin template.
There is though one point to check. If you add <> to <<> it should be after "Example Ext" that is using
<>. But it does not, it's just after Scrum which is
<>. It's obviously not related to your change, certainly more to
OFBIZ-12166. You may have found another issue, would you mind have a look?
Just as a note: I wonder if using a hyphen ("-") in the plugin name is not a
bit confusing, anyway not a problem.
If nobody objects I'll commit Monday.
> Plugin not showing in menu due to permission
> -
>
> Key: OFBIZ-12233
> URL: https://issues.apache.org/jira/browse/OFBIZ-12233
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Upcoming
> Branch
> Environment: openjdk 11.0.11 2021-04-20
> OpenJDK Runtime Environment (build 11.0.11+9-Ubuntu-0ubuntu2.20.04)
> OpenJDK 64-Bit Server VM (build 11.0.11+9-Ubuntu-0ubuntu2.20.04, mixed mode,
> sharing)
> Ubuntu 20.04.2 LTS
>Reporter: Gaetan Chaboussie
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-12233.patch
>
>
> When creating a plugin via gradle :
> {code}
> ./gradlew createPlugin -PpluginId=plugin-test -PpluginResourceName=PluginTest
> -PwebappName=plugin-test -PbasePermission=PLUGIN_TEST
> {code}
> and loading all the required data and permissions, the plugin doesn"t appear
> in the menu.
> I think it comes from the ComponentConfig.java file, L1229, when the
> permissions gets trimmed and modified. Are those lines still useful ?
> I tried removing it locally and it fixed the problem.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12233) Plugin not showing in menu due to permission
[
https://issues.apache.org/jira/browse/OFBIZ-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340884#comment-17340884
]
Gaetan Chaboussie commented on OFBIZ-12233:
---
Here is the correction i suggest, wich is obviously open to review.
> Plugin not showing in menu due to permission
> -
>
> Key: OFBIZ-12233
> URL: https://issues.apache.org/jira/browse/OFBIZ-12233
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Upcoming
> Branch
> Environment: openjdk 11.0.11 2021-04-20
> OpenJDK Runtime Environment (build 11.0.11+9-Ubuntu-0ubuntu2.20.04)
> OpenJDK 64-Bit Server VM (build 11.0.11+9-Ubuntu-0ubuntu2.20.04, mixed mode,
> sharing)
> Ubuntu 20.04.2 LTS
>Reporter: Gaetan Chaboussie
>Priority: Minor
> Attachments: OFBIZ-12233.patch
>
>
> When creating a plugin via gradle :
> {code}
> ./gradlew createPlugin -PpluginId=plugin-test -PpluginResourceName=PluginTest
> -PwebappName=plugin-test -PbasePermission=PLUGIN_TEST
> {code}
> and loading all the required data and permissions, the plugin doesn"t appear
> in the menu.
> I think it comes from the ComponentConfig.java file, L1229, when the
> permissions gets trimmed and modified. Are those lines still useful ?
> I tried removing it locally and it fixed the problem.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
