[jira] [Commented] (OFBIZ-12802) Extending calculateProductPrice (custom) Service and ShoppingCart / OrderItem to deliver/hold an individual discountRate value
[ https://issues.apache.org/jira/browse/OFBIZ-12802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17813564#comment-17813564 ] ASF subversion and git services commented on OFBIZ-12802: - Commit 79242f65b3337be7c5218ef8902a16cc4e14134e in ofbiz-framework's branch refs/heads/trunk from Michael Brohl [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=79242f65b3 ] Fixed: Set discountRate from ShoppingCartItem (OFBIZ-12802) > Extending calculateProductPrice (custom) Service and ShoppingCart / OrderItem > to deliver/hold an individual discountRate value > -- > > Key: OFBIZ-12802 > URL: https://issues.apache.org/jira/browse/OFBIZ-12802 > Project: OFBiz > Issue Type: New Feature >Reporter: Adrian Wolf >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > > Background is the communication of an individually (informally) calculated > discount rate from the price calculation to the OrderItem, with easy access > to it (because of this not via the orderItemPriceInfos substructure). > > Extending ProductPrice.calculateProductPrice Service (all in > PriceServices.java and services_pricepromo.xml): > * Addition of additional context information "productStoreGroupId" and > "partyId" to the call parameters of a "customMethodName" price-calc-service > * Obtaining the fields discountRate and listPrice from calling a > "customMethodName" price-calc-service > * discountRate as Result Field > * Retaining the bypassing of the OFBiz Standard PriceRules based on the > presence of a ListPrice (only that it can now also come from the > "customMethodName", therefore slightly changed decision logic) > Extending ShoppingCart/Item, OrderItem Entity: > * Transport original discount rate from custom price calculation over cart > to order to have the correct rate instead of back-calculating it from > unitPrice and unitListPrice -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12802) Extending calculateProductPrice (custom) Service and ShoppingCart / OrderItem to deliver/hold an individual discountRate value
[ https://issues.apache.org/jira/browse/OFBIZ-12802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810121#comment-17810121 ] ASF subversion and git services commented on OFBIZ-12802: - Commit a07c44f51660f091feec66723017b3366b243b11 in ofbiz-framework's branch refs/heads/trunk from Adrian Wolf [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a07c44f516 ] Extending individual discountRate value (OFBIZ-12802) + Addition of additional context information "productStoreGroupId" and "partyId" to the call parameters of a "customMethodName" price-calc-service + Obtaining the fields discountRate and listPrice from calling a "customMethodName" price-calc-service + discountRate as Result Field + Transport original discount rate from custom price calculation over cart to order to have the correct rate instead of back-calculating it from unitPrice and unitListPrice > Extending calculateProductPrice (custom) Service and ShoppingCart / OrderItem > to deliver/hold an individual discountRate value > -- > > Key: OFBIZ-12802 > URL: https://issues.apache.org/jira/browse/OFBIZ-12802 > Project: OFBiz > Issue Type: New Feature >Reporter: Adrian Wolf >Assignee: Michael Brohl >Priority: Minor > > Background is the communication of an individually (informally) calculated > discount rate from the price calculation to the OrderItem, with easy access > to it (because of this not via the orderItemPriceInfos substructure). > > Extending ProductPrice.calculateProductPrice Service (all in > PriceServices.java and services_pricepromo.xml): > * Addition of additional context information "productStoreGroupId" and > "partyId" to the call parameters of a "customMethodName" price-calc-service > * Obtaining the fields discountRate and listPrice from calling a > "customMethodName" price-calc-service > * discountRate as Result Field > * Retaining the bypassing of the OFBiz Standard PriceRules based on the > presence of a ListPrice (only that it can now also come from the > "customMethodName", therefore slightly changed decision logic) > Extending ShoppingCart/Item, OrderItem Entity: > * Transport original discount rate from custom price calculation over cart > to order to have the correct rate instead of back-calculating it from > unitPrice and unitListPrice -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12802) Extending calculateProductPrice (custom) Service and ShoppingCart / OrderItem to deliver/hold an individual discountRate value
[ https://issues.apache.org/jira/browse/OFBIZ-12802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748650#comment-17748650 ] Jacques Le Roux commented on OFBIZ-12802: - +1 for pushing > Extending calculateProductPrice (custom) Service and ShoppingCart / OrderItem > to deliver/hold an individual discountRate value > -- > > Key: OFBIZ-12802 > URL: https://issues.apache.org/jira/browse/OFBIZ-12802 > Project: OFBiz > Issue Type: New Feature >Reporter: Adrian Wolf >Assignee: Michael Brohl >Priority: Minor > > Background is the communication of an individually (informally) calculated > discount rate from the price calculation to the OrderItem, with easy access > to it (because of this not via the orderItemPriceInfos substructure). > > Extending ProductPrice.calculateProductPrice Service (all in > PriceServices.java and services_pricepromo.xml): > * Addition of additional context information "productStoreGroupId" and > "partyId" to the call parameters of a "customMethodName" price-calc-service > * Obtaining the fields discountRate and listPrice from calling a > "customMethodName" price-calc-service > * discountRate as Result Field > * Retaining the bypassing of the OFBiz Standard PriceRules based on the > presence of a ListPrice (only that it can now also come from the > "customMethodName", therefore slightly changed decision logic) > Extending ShoppingCart/Item, OrderItem Entity: > * Transport original discount rate from custom price calculation over cart > to order to have the correct rate instead of back-calculating it from > unitPrice and unitListPrice -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12802) Extending calculateProductPrice (custom) Service and ShoppingCart / OrderItem to deliver/hold an individual discountRate value
[ https://issues.apache.org/jira/browse/OFBIZ-12802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748225#comment-17748225 ] Michael Brohl commented on OFBIZ-12802: --- Looks good to me. Any objections to merge? > Extending calculateProductPrice (custom) Service and ShoppingCart / OrderItem > to deliver/hold an individual discountRate value > -- > > Key: OFBIZ-12802 > URL: https://issues.apache.org/jira/browse/OFBIZ-12802 > Project: OFBiz > Issue Type: New Feature >Reporter: Adrian Wolf >Assignee: Michael Brohl >Priority: Minor > > Background is the communication of an individually (informally) calculated > discount rate from the price calculation to the OrderItem, with easy access > to it (because of this not via the orderItemPriceInfos substructure). > > Extending ProductPrice.calculateProductPrice Service (all in > PriceServices.java and services_pricepromo.xml): > * Addition of additional context information "productStoreGroupId" and > "partyId" to the call parameters of a "customMethodName" price-calc-service > * Obtaining the fields discountRate and listPrice from calling a > "customMethodName" price-calc-service > * discountRate as Result Field > * Retaining the bypassing of the OFBiz Standard PriceRules based on the > presence of a ListPrice (only that it can now also come from the > "customMethodName", therefore slightly changed decision logic) > Extending ShoppingCart/Item, OrderItem Entity: > * Transport original discount rate from custom price calculation over cart > to order to have the correct rate instead of back-calculating it from > unitPrice and unitListPrice -- This message was sent by Atlassian Jira (v8.20.10#820010)
