[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820944#comment-16820944 ] Jacques Le Roux commented on OFBIZ-4160: Thanks Pierre, Looking forward... > Tax not added for order shipping or promotion > - > > Key: OFBIZ-4160 > URL: https://issues.apache.org/jira/browse/OFBIZ-4160 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk > Environment: rev 1065908 >Reporter: Paul Foxworthy >Assignee: Jacques Le Roux >Priority: Major > Labels: VAT, tax > Fix For: 17.12.01 > > Attachments: OFBIZ-4160_shipping_tax.patch, > OFBIZ-4160_weighted_shipping_tax.patch > > > When shipping is calculated for the entire order or a promotion adjustment is > made, the relevant tax rows from the TaxAuthorityRateProduct table are not > being found. > Here's a patch. > This bug was discovered independently by Sergei Biletnikov, see > http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820915#comment-16820915 ] Pierre Smits commented on OFBIZ-4160: - Hi Jacques, Of course, if and when that leads to more parties contributing > Tax not added for order shipping or promotion > - > > Key: OFBIZ-4160 > URL: https://issues.apache.org/jira/browse/OFBIZ-4160 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk > Environment: rev 1065908 >Reporter: Paul Foxworthy >Assignee: Jacques Le Roux >Priority: Major > Labels: VAT, tax > Fix For: 17.12.01 > > Attachments: OFBIZ-4160_shipping_tax.patch, > OFBIZ-4160_weighted_shipping_tax.patch > > > When shipping is calculated for the entire order or a promotion adjustment is > made, the relevant tax rows from the TaxAuthorityRateProduct table are not > being found. > Here's a patch. > This bug was discovered independently by Sergei Biletnikov, see > http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820837#comment-16820837 ] Jacques Le Roux commented on OFBIZ-4160: Hi Benjamin, Pierre, Should we not create a Jira to make shipping VAT rate possibly different than product VAT rate? > Tax not added for order shipping or promotion > - > > Key: OFBIZ-4160 > URL: https://issues.apache.org/jira/browse/OFBIZ-4160 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk > Environment: rev 1065908 >Reporter: Paul Foxworthy >Assignee: Jacques Le Roux >Priority: Major > Labels: VAT, tax > Fix For: 17.12.01 > > Attachments: OFBIZ-4160_shipping_tax.patch, > OFBIZ-4160_weighted_shipping_tax.patch > > > When shipping is calculated for the entire order or a promotion adjustment is > made, the relevant tax rows from the TaxAuthorityRateProduct table are not > being found. > Here's a patch. > This bug was discovered independently by Sergei Biletnikov, see > http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702819#comment-16702819 ] Jacques Le Roux commented on OFBIZ-4160: I'll try to fix the tests (I suppose they need to be amended). If it does not work I'll revert > Tax not added for order shipping or promotion > - > > Key: OFBIZ-4160 > URL: https://issues.apache.org/jira/browse/OFBIZ-4160 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk > Environment: rev 1065908 >Reporter: Paul Foxworthy >Assignee: Jacques Le Roux >Priority: Major > Labels: VAT, tax > Fix For: 17.12.01 > > Attachments: OFBIZ-4160_shipping_tax.patch, > OFBIZ-4160_weighted_shipping_tax.patch > > > When shipping is calculated for the entire order or a promotion adjustment is > made, the relevant tax rows from the TaxAuthorityRateProduct table are not > being found. > Here's a patch. > This bug was discovered independently by Sergei Biletnikov, see > http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702454#comment-16702454 ] Jacques Le Roux commented on OFBIZ-4160: Seems that there are some tests issue. I'll check that tmrw... > Tax not added for order shipping or promotion > - > > Key: OFBIZ-4160 > URL: https://issues.apache.org/jira/browse/OFBIZ-4160 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk > Environment: rev 1065908 >Reporter: Paul Foxworthy >Assignee: Jacques Le Roux >Priority: Major > Labels: VAT, tax > Fix For: 17.12.01 > > Attachments: OFBIZ-4160_shipping_tax.patch, > OFBIZ-4160_weighted_shipping_tax.patch > > > When shipping is calculated for the entire order or a promotion adjustment is > made, the relevant tax rows from the TaxAuthorityRateProduct table are not > being found. > Here's a patch. > This bug was discovered independently by Sergei Biletnikov, see > http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702449#comment-16702449 ] Jacques Le Roux commented on OFBIZ-4160: Thanks Benjamin, Your patch is in trunk r1847670 R17 r1847671 I did not backport in R16, too much conflicts > Tax not added for order shipping or promotion > - > > Key: OFBIZ-4160 > URL: https://issues.apache.org/jira/browse/OFBIZ-4160 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk > Environment: rev 1065908 >Reporter: Paul Foxworthy >Assignee: Jacques Le Roux >Priority: Major > Labels: VAT, tax > Fix For: 17.12.01 > > Attachments: OFBIZ-4160_shipping_tax.patch, > OFBIZ-4160_weighted_shipping_tax.patch > > > When shipping is calculated for the entire order or a promotion adjustment is > made, the relevant tax rows from the TaxAuthorityRateProduct table are not > being found. > Here's a patch. > This bug was discovered independently by Sergei Biletnikov, see > http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701917#comment-16701917 ] Benjamin Jugl commented on OFBIZ-4160: -- We do not use it, since it was only something that I discovered while working on an international tax-calculation for a customer (who does only have one item per shipment, so this does not really benefit him) but I tested it. > Tax not added for order shipping or promotion > - > > Key: OFBIZ-4160 > URL: https://issues.apache.org/jira/browse/OFBIZ-4160 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk > Environment: rev 1065908 >Reporter: Paul Foxworthy >Assignee: Jacques Le Roux >Priority: Major > Labels: VAT, tax > Attachments: OFBIZ-4160_shipping_tax.patch, > OFBIZ-4160_weighted_shipping_tax.patch > > > When shipping is calculated for the entire order or a promotion adjustment is > made, the relevant tax rows from the TaxAuthorityRateProduct table are not > being found. > Here's a patch. > This bug was discovered independently by Sergei Biletnikov, see > http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694393#comment-16694393 ] Jacques Le Roux commented on OFBIZ-4160: Hi [~bjugl] Before I commit could you please confirm you tested and use this feature? > Tax not added for order shipping or promotion > - > > Key: OFBIZ-4160 > URL: https://issues.apache.org/jira/browse/OFBIZ-4160 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk > Environment: rev 1065908 >Reporter: Paul Foxworthy >Assignee: Jacques Le Roux >Priority: Major > Labels: VAT, tax > Attachments: OFBIZ-4160_shipping_tax.patch, > OFBIZ-4160_weighted_shipping_tax.patch > > > When shipping is calculated for the entire order or a promotion adjustment is > made, the relevant tax rows from the TaxAuthorityRateProduct table are not > being found. > Here's a patch. > This bug was discovered independently by Sergei Biletnikov, see > http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion
[
https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689503#comment-16689503
]
Jacques Le Roux commented on OFBIZ-4160:
Hi Benjamin,
Your patch looks good to me. Before I commit: I did not test, but I guess you
did?
Also I'd
* remove this comment:
{code}
// FIXME handles shipping and promo tax. Simple solution, see
// https://issues.apache.org/jira/browse/OFBIZ-4160 for a better one
{code}
* would remove AccountingTaxAuthorityCategoryAdvice
* would close as won't fix OFBIZ-5662
I let you (or Pierre) create a new Jira for the discussion you had wich makes
sense to me, thanks.
> Tax not added for order shipping or promotion
> -
>
> Key: OFBIZ-4160
> URL: https://issues.apache.org/jira/browse/OFBIZ-4160
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk
> Environment: rev 1065908
>Reporter: Paul Foxworthy
>Assignee: Jacques Le Roux
>Priority: Major
> Labels: VAT, tax
> Attachments: OFBIZ-4160_shipping_tax.patch,
> OFBIZ-4160_weighted_shipping_tax.patch
>
>
> When shipping is calculated for the entire order or a promotion adjustment is
> made, the relevant tax rows from the TaxAuthorityRateProduct table are not
> being found.
> Here's a patch.
> This bug was discovered independently by Sergei Biletnikov, see
> http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689277#comment-16689277 ] Benjamin Jugl commented on OFBIZ-4160: -- Sorry, i am currently a little bit entangled in projects for customers. I will have a look asap. Thank you for your (still unseen) efford so far. :) > Tax not added for order shipping or promotion > - > > Key: OFBIZ-4160 > URL: https://issues.apache.org/jira/browse/OFBIZ-4160 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk > Environment: rev 1065908 >Reporter: Paul Foxworthy >Assignee: Jacques Le Roux >Priority: Major > Labels: VAT, tax > Attachments: OFBIZ-4160_shipping_tax.patch, > OFBIZ-4160_weighted_shipping_tax.patch > > > When shipping is calculated for the entire order or a promotion adjustment is > made, the relevant tax rows from the TaxAuthorityRateProduct table are not > being found. > Here's a patch. > This bug was discovered independently by Sergei Biletnikov, see > http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683545#comment-16683545 ] Pierre Smits commented on OFBIZ-4160: - I agree. let's not dilute this issue (too much). > Tax not added for order shipping or promotion > - > > Key: OFBIZ-4160 > URL: https://issues.apache.org/jira/browse/OFBIZ-4160 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk > Environment: rev 1065908 >Reporter: Paul Foxworthy >Assignee: Jacques Le Roux >Priority: Major > Labels: VAT, tax > Attachments: OFBIZ-4160_shipping_tax.patch, > OFBIZ-4160_weighted_shipping_tax.patch > > > When shipping is calculated for the entire order or a promotion adjustment is > made, the relevant tax rows from the TaxAuthorityRateProduct table are not > being found. > Here's a patch. > This bug was discovered independently by Sergei Biletnikov, see > http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683521#comment-16683521 ] Benjamin Jugl commented on OFBIZ-4160: -- That is exactly how it is used in Germany and I think most European countries do it the same way. But in the USA it is handled differently. They just display gross prices, because tax-rates vary from state to state. Would it be advisable to open a new issue for this topic of where and how taxes should be shown and only deal with the shipping-tax issue in here? > Tax not added for order shipping or promotion > - > > Key: OFBIZ-4160 > URL: https://issues.apache.org/jira/browse/OFBIZ-4160 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk > Environment: rev 1065908 >Reporter: Paul Foxworthy >Assignee: Jacques Le Roux >Priority: Major > Labels: VAT, tax > Attachments: OFBIZ-4160_shipping_tax.patch, > OFBIZ-4160_weighted_shipping_tax.patch > > > When shipping is calculated for the entire order or a promotion adjustment is > made, the relevant tax rows from the TaxAuthorityRateProduct table are not > being found. > Here's a patch. > This bug was discovered independently by Sergei Biletnikov, see > http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682297#comment-16682297 ] Pierre Smits commented on OFBIZ-4160: - The Nederlandse Belastingdienst states on their website regarding BTW requirements on the invoice: * the invoice must show the amount the company charges the customer to pay, without VAT, * the VAT rate (per product category), * the VAT amount (split per VAT rate). How that is displayed in product pages and shopping carts in e-stores is up to the company, and I must say influenced by marketing purposes, pragmatism and historically influenced: * if the (main) focus is B2C then - commonly - prices in product pages and shopping carts are shown including VAT, with some listing the VAT amount as well. This is inline with what is shown in B%M stores, * if the (main) focus is B2B then prices in product pages and shopping carts are shown excluding VAT, optionally listing the VAT amount (and rate). As an example: see [https://www.amac.nl/apple-mac-mini-2-6ghz-dual-core-i5-8gb-1tb] offering a Mac Mini. This is a company (with a main focus on B2C, but does B2B too). The product page shows the price including VAT (with no VAT amount listed). However the invoice will state: * On the product line for each product/service the unit price ex VAT, quantity, the VAT rate and the total amount ex VAT. * If shipping cost were involved this would be shown on a new product line stating the VAT rate and the calculated/charged amount. And below the product lines, the following would be shown: * the sub total (ex VAT) * the total amounts per VAT rate * the grand total amount (amount to be paid by the customer). Some e-stores offer a toggle mechanism to show prices including/excluding VAT. See [https://maxict.nl/apple-mini-26ghz-nettop-intel-core-i5-zilver-pc-p4604260.html] I trust the above helps. > Tax not added for order shipping or promotion > - > > Key: OFBIZ-4160 > URL: https://issues.apache.org/jira/browse/OFBIZ-4160 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk > Environment: rev 1065908 >Reporter: Paul Foxworthy >Assignee: Jacques Le Roux >Priority: Major > Labels: VAT, tax > Attachments: OFBIZ-4160_shipping_tax.patch, > OFBIZ-4160_weighted_shipping_tax.patch > > > When shipping is calculated for the entire order or a promotion adjustment is > made, the relevant tax rows from the TaxAuthorityRateProduct table are not > being found. > Here's a patch. > This bug was discovered independently by Sergei Biletnikov, see > http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681569#comment-16681569 ] Benjamin Jugl commented on OFBIZ-4160: -- I would not want to change that, after all, they are calculated per order and not per item. A seperate Column should indicate, what amount of tax is applied to the shipping costs though. Is the BTW already included in Prices? MwSt is, and I had the feeling that this calculation does not work very well. The prices in the checkout are given as net with a line for the taxes to be applied underneath every item. But on the order-level all taxes (this time including those applied to shipping and promotions) are once again added to the sub-total. But perhaps this should be dealt with in another ticket? > Tax not added for order shipping or promotion > - > > Key: OFBIZ-4160 > URL: https://issues.apache.org/jira/browse/OFBIZ-4160 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk > Environment: rev 1065908 >Reporter: Paul Foxworthy >Assignee: Jacques Le Roux >Priority: Major > Labels: VAT, tax > Attachments: OFBIZ-4160_shipping_tax.patch, > OFBIZ-4160_weighted_shipping_tax.patch > > > When shipping is calculated for the entire order or a promotion adjustment is > made, the relevant tax rows from the TaxAuthorityRateProduct table are not > being found. > Here's a patch. > This bug was discovered independently by Sergei Biletnikov, see > http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681457#comment-16681457 ] Pierre Smits commented on OFBIZ-4160: - I don't think that there is a need for that. The setup of various TaxAuthority records (TaxAuthorityCategory and TAX_AUTHORITY_RATE_PRODUCT) is sufficient. However, the difficulty lies in the aspect of tying an applied shipping method in a store to such setup for any given 3rd party logistics service integration. Current implementations add shipping cost not as a (taxable) service product above the subTotal line of an order, but below the line. > Tax not added for order shipping or promotion > - > > Key: OFBIZ-4160 > URL: https://issues.apache.org/jira/browse/OFBIZ-4160 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk > Environment: rev 1065908 >Reporter: Paul Foxworthy >Assignee: Jacques Le Roux >Priority: Major > Labels: VAT, tax > Attachments: OFBIZ-4160_shipping_tax.patch, > OFBIZ-4160_weighted_shipping_tax.patch > > > When shipping is calculated for the entire order or a promotion adjustment is > made, the relevant tax rows from the TaxAuthorityRateProduct table are not > being found. > Here's a patch. > This bug was discovered independently by Sergei Biletnikov, see > http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681204#comment-16681204 ] Benjamin Jugl commented on OFBIZ-4160: -- That is a tough one. I had a good thought about that and I think it is advisable to introduce a new ProductCategory "TAX_SHIPPING". This could be administered through TAX_AUTHORITY_RATE_PRODUCT for individual tax authorities. Then there could be a condition before my newly implemented logic, to use this tax rate, if it is found, and if it is not, my logic is executed. This would be sufficient, if the range of possible handling for shipping tax does not exceed this two options. If it did, a new field could be added to TAX_AUTHORITY, to indicate the proper way of handling shipping taxes. > Tax not added for order shipping or promotion > - > > Key: OFBIZ-4160 > URL: https://issues.apache.org/jira/browse/OFBIZ-4160 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk > Environment: rev 1065908 >Reporter: Paul Foxworthy >Assignee: Jacques Le Roux >Priority: Major > Labels: VAT, tax > Attachments: OFBIZ-4160_shipping_tax.patch, > OFBIZ-4160_weighted_shipping_tax.patch > > > When shipping is calculated for the entire order or a promotion adjustment is > made, the relevant tax rows from the TaxAuthorityRateProduct table are not > being found. > Here's a patch. > This bug was discovered independently by Sergei Biletnikov, see > http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679532#comment-16679532 ] Pierre Smits commented on OFBIZ-4160: - How do we factor in the possibility that shipping has a different tax schema than the good shipped? > Tax not added for order shipping or promotion > - > > Key: OFBIZ-4160 > URL: https://issues.apache.org/jira/browse/OFBIZ-4160 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk > Environment: rev 1065908 >Reporter: Paul Foxworthy >Assignee: Jacques Le Roux >Priority: Major > Labels: VAT, tax > Attachments: OFBIZ-4160_shipping_tax.patch, > OFBIZ-4160_weighted_shipping_tax.patch > > > When shipping is calculated for the entire order or a promotion adjustment is > made, the relevant tax rows from the TaxAuthorityRateProduct table are not > being found. > Here's a patch. > This bug was discovered independently by Sergei Biletnikov, see > http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678447#comment-16678447 ] Benjamin Jugl commented on OFBIZ-4160: -- Patch Provided. Tax on shipping is now weighted as discussed before. Additionally I made some adjustments to the previous patch: Originally the condition for the shipping-taxes was created for promotions as well (and vice versa). > Tax not added for order shipping or promotion > - > > Key: OFBIZ-4160 > URL: https://issues.apache.org/jira/browse/OFBIZ-4160 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk > Environment: rev 1065908 >Reporter: Paul Foxworthy >Assignee: Jacques Le Roux >Priority: Major > Labels: VAT, tax > Attachments: OFBIZ-4160_shipping_tax.patch, > OFBIZ-4160_weighted_shipping_tax.patch > > > When shipping is calculated for the entire order or a promotion adjustment is > made, the relevant tax rows from the TaxAuthorityRateProduct table are not > being found. > Here's a patch. > This bug was discovered independently by Sergei Biletnikov, see > http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641808#comment-16641808 ] Jacques Le Roux commented on OFBIZ-4160: Hi Benjami, Sounds good, please proceed > Tax not added for order shipping or promotion > - > > Key: OFBIZ-4160 > URL: https://issues.apache.org/jira/browse/OFBIZ-4160 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk > Environment: rev 1065908 >Reporter: Paul Foxworthy >Assignee: Jacques Le Roux >Priority: Major > Labels: VAT, tax > Attachments: OFBIZ-4160_shipping_tax.patch > > > When shipping is calculated for the entire order or a promotion adjustment is > made, the relevant tax rows from the TaxAuthorityRateProduct table are not > being found. > Here's a patch. > This bug was discovered independently by Sergei Biletnikov, see > http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion
[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641681#comment-16641681 ] Benjamin Jugl commented on OFBIZ-4160: -- Hi, I am currently implementing multinational tax-calculation for a customer. The patch you provided herein works fine. Except when there are shippings and promotions to calculate. Then the algorithm searches for all entries in TAX_AUTHORITY_RATE_PRODUCT that are available for the PRODUCT_STORE and TAX_AUTH (and apply to shipping/promotions). So all taxes (regular and reduced) are applied to the shipping costs, which naturally leads to a higher amount overall. The correct procedure (at least in Germany and Austria) is to apply the tax for shipping according to the shipped items. So, if regular tax applies to the good, regular tax is applied to the shipping-costs. If multiple items are shipped and they have mixed taxes (some regular, some reduced) the calculation of the tax for shipping is weighted accordingly. I will dedicate myself to implementing this in this style and provide a patch when ready - provided that there are no objections. > Tax not added for order shipping or promotion > - > > Key: OFBIZ-4160 > URL: https://issues.apache.org/jira/browse/OFBIZ-4160 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk > Environment: rev 1065908 >Reporter: Paul Foxworthy >Assignee: Jacques Le Roux >Priority: Major > Labels: VAT, tax > Attachments: OFBIZ-4160_shipping_tax.patch > > > When shipping is calculated for the entire order or a promotion adjustment is > made, the relevant tax rows from the TaxAuthorityRateProduct table are not > being found. > Here's a patch. > This bug was discovered independently by Sergei Biletnikov, see > http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
