[jira] [Commented] (OFBIZ-7532) Form Display Field improvement to manage multiple number format
[ https://issues.apache.org/jira/browse/OFBIZ-7532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889709#comment-16889709 ] Nicolas Malin commented on OFBIZ-7532: -- And after svn update to include Mathieu's works :) [^OFBIZ-7532.patch] > Form Display Field improvement to manage multiple number format > --- > > Key: OFBIZ-7532 > URL: https://issues.apache.org/jira/browse/OFBIZ-7532 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Charles STELTZLEN >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-7532.patch, OFBIZ-7532.patch, OFBIZ-7532.patch, > OFBIZ-7532.patch, OFBIZ-7532.patch, Sélection_238.png > > > On display field used in forms, there is a "type" "accounting-number" which > is used to format number like property configuration : > #,##0.;(#,##0.). > This JIRA propose to extend this idea by using a "type" "number" and an > additional attribute called "format-pattern". This field will be used by form > renderer to get the good property. It use FlexibleString to manage variable > in this field and so allow to have different format for the same column > according to some conditions. > example: format-pattern="accounting"/> > The "format-pattern" will be stored in arithmetic.properties. > example: > # the default number format > default.number.format = ##0.00 > accounting.number.format = #,##0.;(#,##0.) > quantity.number.format = ##0.00 > integer-quantity.number.format = #0 > percentage.number.format = ##.##% > export.number.format = #.00 > In ModelFormField.java, the system gets property using > EntityUtilProperties.getPropertyValue to ba able to quickly add a new format. > I think that it will require a discussion on Dev mailing-list to validate the > choices. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (OFBIZ-7532) Form Display Field improvement to manage multiple number format
[
https://issues.apache.org/jira/browse/OFBIZ-7532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889707#comment-16889707
]
Nicolas Malin commented on OFBIZ-7532:
--
Hi Jacques
{code:java}
~/workspace/apache-svn/ofbiz-trunk
poveglia$ svn st | grep ?
? framework/common/config/number.properties
?
framework/webapp/src/main/java/org/apache/ofbiz/webapp/ftl/OfbizNumberTransform.java{code}
[https://gph.is/28PupM2v]
no comment
I correct this miss with [^OFBIZ-7532.patch]
> Form Display Field improvement to manage multiple number format
> ---
>
> Key: OFBIZ-7532
> URL: https://issues.apache.org/jira/browse/OFBIZ-7532
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Charles STELTZLEN
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-7532.patch, OFBIZ-7532.patch, OFBIZ-7532.patch,
> OFBIZ-7532.patch, Sélection_238.png
>
>
> On display field used in forms, there is a "type" "accounting-number" which
> is used to format number like property configuration :
> #,##0.;(#,##0.).
> This JIRA propose to extend this idea by using a "type" "number" and an
> additional attribute called "format-pattern". This field will be used by form
> renderer to get the good property. It use FlexibleString to manage variable
> in this field and so allow to have different format for the same column
> according to some conditions.
> example: format-pattern="accounting"/>
> The "format-pattern" will be stored in arithmetic.properties.
> example:
> # the default number format
> default.number.format = ##0.00
> accounting.number.format = #,##0.;(#,##0.)
> quantity.number.format = ##0.00
> integer-quantity.number.format = #0
> percentage.number.format = ##.##%
> export.number.format = #.00
> In ModelFormField.java, the system gets property using
> EntityUtilProperties.getPropertyValue to ba able to quickly add a new format.
> I think that it will require a discussion on Dev mailing-list to validate the
> choices.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (OFBIZ-7532) Form Display Field improvement to manage multiple number format
[ https://issues.apache.org/jira/browse/OFBIZ-7532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889705#comment-16889705 ] Jacques Le Roux commented on OFBIZ-7532: Hi Nicolas, I'm cursorily reviewing, It seems you missed to add the common/config/number.properties file in the patch. I have also an issue applying the patch with UtilFormatOut class. I guess you need to update after Mathieu's recent changes. > Form Display Field improvement to manage multiple number format > --- > > Key: OFBIZ-7532 > URL: https://issues.apache.org/jira/browse/OFBIZ-7532 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Charles STELTZLEN >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-7532.patch, OFBIZ-7532.patch, OFBIZ-7532.patch, > Sélection_238.png > > > On display field used in forms, there is a "type" "accounting-number" which > is used to format number like property configuration : > #,##0.;(#,##0.). > This JIRA propose to extend this idea by using a "type" "number" and an > additional attribute called "format-pattern". This field will be used by form > renderer to get the good property. It use FlexibleString to manage variable > in this field and so allow to have different format for the same column > according to some conditions. > example: format-pattern="accounting"/> > The "format-pattern" will be stored in arithmetic.properties. > example: > # the default number format > default.number.format = ##0.00 > accounting.number.format = #,##0.;(#,##0.) > quantity.number.format = ##0.00 > integer-quantity.number.format = #0 > percentage.number.format = ##.##% > export.number.format = #.00 > In ModelFormField.java, the system gets property using > EntityUtilProperties.getPropertyValue to ba able to quickly add a new format. > I think that it will require a discussion on Dev mailing-list to validate the > choices. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (OFBIZ-7532) Form Display Field improvement to manage multiple number format
[ https://issues.apache.org/jira/browse/OFBIZ-7532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889397#comment-16889397 ] Nicolas Malin commented on OFBIZ-7532: -- I created a new patch [^OFBIZ-7532.patch] to continue to homogenize number displaying format with : * move properties on common/config/number.properties (I open to another name if you have) * create new OfbizNumberTransform to call on ftl the displaying by <@ofbizNumber number=size format='quantity' /> * change OfbizAmountTransform to extend OfbizNumberTransform with format='amount' and keep backward compatibility to use amount argument instead number * change format-type to format on xsd to keep same naming with ftl rendering * add some example on Quote's screen I think this version is ready to commit, If no remarks I will load it on trunk > Form Display Field improvement to manage multiple number format > --- > > Key: OFBIZ-7532 > URL: https://issues.apache.org/jira/browse/OFBIZ-7532 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Charles STELTZLEN >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-7532.patch, OFBIZ-7532.patch, OFBIZ-7532.patch, > Sélection_238.png > > > On display field used in forms, there is a "type" "accounting-number" which > is used to format number like property configuration : > #,##0.;(#,##0.). > This JIRA propose to extend this idea by using a "type" "number" and an > additional attribute called "format-pattern". This field will be used by form > renderer to get the good property. It use FlexibleString to manage variable > in this field and so allow to have different format for the same column > according to some conditions. > example: format-pattern="accounting"/> > The "format-pattern" will be stored in arithmetic.properties. > example: > # the default number format > default.number.format = ##0.00 > accounting.number.format = #,##0.;(#,##0.) > quantity.number.format = ##0.00 > integer-quantity.number.format = #0 > percentage.number.format = ##.##% > export.number.format = #.00 > In ModelFormField.java, the system gets property using > EntityUtilProperties.getPropertyValue to ba able to quickly add a new format. > I think that it will require a discussion on Dev mailing-list to validate the > choices. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (OFBIZ-7532) Form Display Field improvement to manage multiple number format
[ https://issues.apache.org/jira/browse/OFBIZ-7532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812651#comment-16812651 ] Jacques Le Roux commented on OFBIZ-7532: (y) > Form Display Field improvement to manage multiple number format > --- > > Key: OFBIZ-7532 > URL: https://issues.apache.org/jira/browse/OFBIZ-7532 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Charles STELTZLEN >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-7532.patch, OFBIZ-7532.patch, Sélection_238.png > > > On display field used in forms, there is a "type" "accounting-number" which > is used to format number like property configuration : > #,##0.;(#,##0.). > This JIRA propose to extend this idea by using a "type" "number" and an > additional attribute called "format-pattern". This field will be used by form > renderer to get the good property. It use FlexibleString to manage variable > in this field and so allow to have different format for the same column > according to some conditions. > example: format-pattern="accounting"/> > The "format-pattern" will be stored in arithmetic.properties. > example: > # the default number format > default.number.format = ##0.00 > accounting.number.format = #,##0.;(#,##0.) > quantity.number.format = ##0.00 > integer-quantity.number.format = #0 > percentage.number.format = ##.##% > export.number.format = #.00 > In ModelFormField.java, the system gets property using > EntityUtilProperties.getPropertyValue to ba able to quickly add a new format. > I think that it will require a discussion on Dev mailing-list to validate the > choices. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7532) Form Display Field improvement to manage multiple number format
[ https://issues.apache.org/jira/browse/OFBIZ-7532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812275#comment-16812275 ] Nicolas Malin commented on OFBIZ-7532: -- Thanks Jacques, Currently this patch isn't ready to commit, I have some thinking about where set correctly properties (on general, arthitmetic or an other dedicate), how call properties with delegator from ftl macro and what format type we support by default on standard. I forgot to give an example that I created with the number -9.958 on different format type !Sélection_238.png! > Form Display Field improvement to manage multiple number format > --- > > Key: OFBIZ-7532 > URL: https://issues.apache.org/jira/browse/OFBIZ-7532 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Charles STELTZLEN >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-7532.patch, OFBIZ-7532.patch, Sélection_238.png > > > On display field used in forms, there is a "type" "accounting-number" which > is used to format number like property configuration : > #,##0.;(#,##0.). > This JIRA propose to extend this idea by using a "type" "number" and an > additional attribute called "format-pattern". This field will be used by form > renderer to get the good property. It use FlexibleString to manage variable > in this field and so allow to have different format for the same column > according to some conditions. > example: format-pattern="accounting"/> > The "format-pattern" will be stored in arithmetic.properties. > example: > # the default number format > default.number.format = ##0.00 > accounting.number.format = #,##0.;(#,##0.) > quantity.number.format = ##0.00 > integer-quantity.number.format = #0 > percentage.number.format = ##.##% > export.number.format = #.00 > In ModelFormField.java, the system gets property using > EntityUtilProperties.getPropertyValue to ba able to quickly add a new format. > I think that it will require a discussion on Dev mailing-list to validate the > choices. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7532) Form Display Field improvement to manage multiple number format
[ https://issues.apache.org/jira/browse/OFBIZ-7532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811556#comment-16811556 ] Jacques Le Roux commented on OFBIZ-7532: The patch looks good to me, I did not test only reviewed: +1 > Form Display Field improvement to manage multiple number format > --- > > Key: OFBIZ-7532 > URL: https://issues.apache.org/jira/browse/OFBIZ-7532 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Charles STELTZLEN >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-7532.patch, OFBIZ-7532.patch > > > On display field used in forms, there is a "type" "accounting-number" which > is used to format number like property configuration : > #,##0.;(#,##0.). > This JIRA propose to extend this idea by using a "type" "number" and an > additional attribute called "format-pattern". This field will be used by form > renderer to get the good property. It use FlexibleString to manage variable > in this field and so allow to have different format for the same column > according to some conditions. > example: format-pattern="accounting"/> > The "format-pattern" will be stored in arithmetic.properties. > example: > # the default number format > default.number.format = ##0.00 > accounting.number.format = #,##0.;(#,##0.) > quantity.number.format = ##0.00 > integer-quantity.number.format = #0 > percentage.number.format = ##.##% > export.number.format = #.00 > In ModelFormField.java, the system gets property using > EntityUtilProperties.getPropertyValue to ba able to quickly add a new format. > I think that it will require a discussion on Dev mailing-list to validate the > choices. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7532) Form Display Field improvement to manage multiple number format
[ https://issues.apache.org/jira/browse/OFBIZ-7532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811513#comment-16811513 ] Jacques Le Roux commented on OFBIZ-7532: Hi Nicolas, looking forward :) > Form Display Field improvement to manage multiple number format > --- > > Key: OFBIZ-7532 > URL: https://issues.apache.org/jira/browse/OFBIZ-7532 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Charles STELTZLEN >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-7532.patch, OFBIZ-7532.patch > > > On display field used in forms, there is a "type" "accounting-number" which > is used to format number like property configuration : > #,##0.;(#,##0.). > This JIRA propose to extend this idea by using a "type" "number" and an > additional attribute called "format-pattern". This field will be used by form > renderer to get the good property. It use FlexibleString to manage variable > in this field and so allow to have different format for the same column > according to some conditions. > example: format-pattern="accounting"/> > The "format-pattern" will be stored in arithmetic.properties. > example: > # the default number format > default.number.format = ##0.00 > accounting.number.format = #,##0.;(#,##0.) > quantity.number.format = ##0.00 > integer-quantity.number.format = #0 > percentage.number.format = ##.##% > export.number.format = #.00 > In ModelFormField.java, the system gets property using > EntityUtilProperties.getPropertyValue to ba able to quickly add a new format. > I think that it will require a discussion on Dev mailing-list to validate the > choices. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7532) Form Display Field improvement to manage multiple number format
[ https://issues.apache.org/jira/browse/OFBIZ-7532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811046#comment-16811046 ] Nicolas Malin commented on OFBIZ-7532: -- Hello, I will continue Charle's idea :), as I announced on [mailing list|https://lists.apache.org/thread.html/557de68373ca5592d709cea2326f945cb97d617e230d2b3806c3e659@%3Cdev.ofbiz.apache.org%3E], it's an other vision that more homogenize than the first patch, this [^OFBIZ-7532.patch] push idea on all ofbiz with a refactoring of all UtilFormatOut.format*Number* to slim source code. > Form Display Field improvement to manage multiple number format > --- > > Key: OFBIZ-7532 > URL: https://issues.apache.org/jira/browse/OFBIZ-7532 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Charles STELTZLEN >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-7532.patch, OFBIZ-7532.patch > > > On display field used in forms, there is a "type" "accounting-number" which > is used to format number like property configuration : > #,##0.;(#,##0.). > This JIRA propose to extend this idea by using a "type" "number" and an > additional attribute called "format-pattern". This field will be used by form > renderer to get the good property. It use FlexibleString to manage variable > in this field and so allow to have different format for the same column > according to some conditions. > example: format-pattern="accounting"/> > The "format-pattern" will be stored in arithmetic.properties. > example: > # the default number format > default.number.format = ##0.00 > accounting.number.format = #,##0.;(#,##0.) > quantity.number.format = ##0.00 > integer-quantity.number.format = #0 > percentage.number.format = ##.##% > export.number.format = #.00 > In ModelFormField.java, the system gets property using > EntityUtilProperties.getPropertyValue to ba able to quickly add a new format. > I think that it will require a discussion on Dev mailing-list to validate the > choices. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7532) Form Display Field improvement to manage multiple number format
[ https://issues.apache.org/jira/browse/OFBIZ-7532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970498#comment-15970498 ] Jacques Le Roux commented on OFBIZ-7532: Hi Charles, any chances? > Form Display Field improvement to manage multiple number format > --- > > Key: OFBIZ-7532 > URL: https://issues.apache.org/jira/browse/OFBIZ-7532 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Charles STELTZLEN >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-7532.patch > > > On display field used in forms, there is a "type" "accounting-number" which > is used to format number like property configuration : > #,##0.;(#,##0.). > This JIRA propose to extend this idea by using a "type" "number" and an > additional attribute called "format-pattern". This field will be used by form > renderer to get the good property. It use FlexibleString to manage variable > in this field and so allow to have different format for the same column > according to some conditions. > example: format-pattern="accounting"/> > The "format-pattern" will be stored in arithmetic.properties. > example: > # the default number format > default.number.format = ##0.00 > accounting.number.format = #,##0.;(#,##0.) > quantity.number.format = ##0.00 > integer-quantity.number.format = #0 > percentage.number.format = ##.##% > export.number.format = #.00 > In ModelFormField.java, the system gets property using > EntityUtilProperties.getPropertyValue to ba able to quickly add a new format. > I think that it will require a discussion on Dev mailing-list to validate the > choices. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
