[jira] [Commented] (OFBIZ-8250) SvnInfo.ftl and GitInfo.ftl are not generated by default
[ https://issues.apache.org/jira/browse/OFBIZ-8250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502792#comment-15502792 ] Jacopo Cappellato commented on OFBIZ-8250: -- Thank you [~mbrohl] for providing the fix for this annoying error; it was bothering me so thanks for taking the time to implement the patch! > SvnInfo.ftl and GitInfo.ftl are not generated by default > > > Key: OFBIZ-8250 > URL: https://issues.apache.org/jira/browse/OFBIZ-8250 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > Attachments: Image 014.png, OFBIZ-8250-2.patch, OFBIZ-8250.patch > > > The two files are not generated which results in an FTL stacktrace in the > footer of the backend applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8250) SvnInfo.ftl and GitInfo.ftl are not generated by default
[ https://issues.apache.org/jira/browse/OFBIZ-8250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502479#comment-15502479 ] Taher Alkhateeb commented on OFBIZ-8250: Hi Jacques, thank you for the commit. I think it would be more appropriate in the future to let committers commit their own work. Michael added the patch in this JIRA for feedback and help, not committing, as he is the assignee of this JIRA. > SvnInfo.ftl and GitInfo.ftl are not generated by default > > > Key: OFBIZ-8250 > URL: https://issues.apache.org/jira/browse/OFBIZ-8250 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > Attachments: Image 014.png, OFBIZ-8250-2.patch, OFBIZ-8250.patch > > > The two files are not generated which results in an FTL stacktrace in the > footer of the backend applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8250) SvnInfo.ftl and GitInfo.ftl are not generated by default
[ https://issues.apache.org/jira/browse/OFBIZ-8250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502439#comment-15502439 ] Jacques Le Roux commented on OFBIZ-8250: After reading at http://freemarker.org/docs/ref_directive_include.html the ignore_missing description of this <#include attribute bq. ignore_missing: When true, suppresses the error when the template to include is missing, instead <#include ...> will print nothing. When false, the template processing will stop with error if the template is missing. If you omit this option, then it defaults to false. I thought that we could get rid of the empty files creation when building. But like Deepak [here|https://issues.apache.org/jira/browse/OFBIZ-7942?focusedCommentId=15409322=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15409322 ] I found that it's not working. So I agree that the proposed patch is the best solution so far. I have reopened OFBIZ-7942 because I did not understood the problem there when I closed. We need to report to Apache Freemarker (incubating) because as mentionned Deepak the ignore_missing attribute of the <#include directive does not work. When it will work we will use it and remove the need of creating empty files when running the build task. I commit the proposed patch now, thanks for your patience :) > SvnInfo.ftl and GitInfo.ftl are not generated by default > > > Key: OFBIZ-8250 > URL: https://issues.apache.org/jira/browse/OFBIZ-8250 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > Attachments: Image 014.png, OFBIZ-8250-2.patch, OFBIZ-8250.patch > > > The two files are not generated which results in an FTL stacktrace in the > footer of the backend applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8250) SvnInfo.ftl and GitInfo.ftl are not generated by default
[ https://issues.apache.org/jira/browse/OFBIZ-8250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15501670#comment-15501670 ] Jacques Le Roux commented on OFBIZ-8250: See comment below > SvnInfo.ftl and GitInfo.ftl are not generated by default > > > Key: OFBIZ-8250 > URL: https://issues.apache.org/jira/browse/OFBIZ-8250 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > Attachments: Image 014.png, OFBIZ-8250-2.patch, OFBIZ-8250.patch > > > The two files are not generated which results in an FTL stacktrace in the > footer of the backend applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8250) SvnInfo.ftl and GitInfo.ftl are not generated by default
[ https://issues.apache.org/jira/browse/OFBIZ-8250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15501629#comment-15501629 ] Michael Brohl commented on OFBIZ-8250: -- How does Eclipse behave on your site if the project stated in the header does not exist in the workspace? > SvnInfo.ftl and GitInfo.ftl are not generated by default > > > Key: OFBIZ-8250 > URL: https://issues.apache.org/jira/browse/OFBIZ-8250 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-8250-2.patch, OFBIZ-8250.patch > > > The two files are not generated which results in an FTL stacktrace in the > footer of the backend applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8250) SvnInfo.ftl and GitInfo.ftl are not generated by default
[ https://issues.apache.org/jira/browse/OFBIZ-8250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15501304#comment-15501304 ] Jacques Le Roux commented on OFBIZ-8250: This is only a issue in Eclipse. When you apply it in Eclipse, it then searches for a project that you might not have. Mine is not named ofbiz-svn for instance > SvnInfo.ftl and GitInfo.ftl are not generated by default > > > Key: OFBIZ-8250 > URL: https://issues.apache.org/jira/browse/OFBIZ-8250 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-8250-2.patch, OFBIZ-8250.patch > > > The two files are not generated which results in an FTL stacktrace in the > footer of the backend applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8250) SvnInfo.ftl and GitInfo.ftl are not generated by default
[ https://issues.apache.org/jira/browse/OFBIZ-8250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15501253#comment-15501253 ] Jacopo Cappellato commented on OFBIZ-8250: -- I don't see a problem with the header, since it is a comment that doesn't cause any confusion or issue while reviewing or applying the patch. > SvnInfo.ftl and GitInfo.ftl are not generated by default > > > Key: OFBIZ-8250 > URL: https://issues.apache.org/jira/browse/OFBIZ-8250 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-8250-2.patch, OFBIZ-8250.patch > > > The two files are not generated which results in an FTL stacktrace in the > footer of the backend applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8250) SvnInfo.ftl and GitInfo.ftl are not generated by default
[ https://issues.apache.org/jira/browse/OFBIZ-8250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15500925#comment-15500925 ] Michael Brohl commented on OFBIZ-8250: -- Yes, the cleanup part is needed anyway. Of course, we can also change the includes in every themes' footer. I find it more efficient to have the files in place per default. > SvnInfo.ftl and GitInfo.ftl are not generated by default > > > Key: OFBIZ-8250 > URL: https://issues.apache.org/jira/browse/OFBIZ-8250 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-8250-2.patch, OFBIZ-8250.patch > > > The two files are not generated which results in an FTL stacktrace in the > footer of the backend applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8250) SvnInfo.ftl and GitInfo.ftl are not generated by default
[
https://issues.apache.org/jira/browse/OFBIZ-8250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15500917#comment-15500917
]
Michael Brohl commented on OFBIZ-8250:
--
This patch basically implements a functionality we had in the old ant build
target:
{code:xml}
{code}
> SvnInfo.ftl and GitInfo.ftl are not generated by default
>
>
> Key: OFBIZ-8250
> URL: https://issues.apache.org/jira/browse/OFBIZ-8250
> Project: OFBiz
> Issue Type: Bug
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-8250-2.patch, OFBIZ-8250.patch
>
>
> The two files are not generated which results in an FTL stacktrace in the
> footer of the backend applications.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-8250) SvnInfo.ftl and GitInfo.ftl are not generated by default
[ https://issues.apache.org/jira/browse/OFBIZ-8250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15500910#comment-15500910 ] Taher Alkhateeb commented on OFBIZ-8250: Hmmm, we are still left with the problem of generated files from svnInfoFooter and gitInfoFooter not cleaned up. Anyway, I leave this discussion for you and Michael to continue to devise a solution. > SvnInfo.ftl and GitInfo.ftl are not generated by default > > > Key: OFBIZ-8250 > URL: https://issues.apache.org/jira/browse/OFBIZ-8250 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-8250-2.patch, OFBIZ-8250.patch > > > The two files are not generated which results in an FTL stacktrace in the > footer of the backend applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8250) SvnInfo.ftl and GitInfo.ftl are not generated by default
[ https://issues.apache.org/jira/browse/OFBIZ-8250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15500882#comment-15500882 ] Jacques Le Roux commented on OFBIZ-8250: Please don't tell me what I have to do or not, thanks! > SvnInfo.ftl and GitInfo.ftl are not generated by default > > > Key: OFBIZ-8250 > URL: https://issues.apache.org/jira/browse/OFBIZ-8250 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-8250-2.patch, OFBIZ-8250.patch > > > The two files are not generated which results in an FTL stacktrace in the > footer of the backend applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8250) SvnInfo.ftl and GitInfo.ftl are not generated by default
[ https://issues.apache.org/jira/browse/OFBIZ-8250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15500847#comment-15500847 ] Taher Alkhateeb commented on OFBIZ-8250: Unless you caught an error, I don't think you need to slow down this JIRA with a review. Michael checked it, I checked it, it runs, it works. You said yourself that your objective is to understand the _reason_ not correctness of the patch which I explained above (maybe Michael can add more). This patch is simply a bug fix for not generating the footer files. > SvnInfo.ftl and GitInfo.ftl are not generated by default > > > Key: OFBIZ-8250 > URL: https://issues.apache.org/jira/browse/OFBIZ-8250 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-8250-2.patch, OFBIZ-8250.patch > > > The two files are not generated which results in an FTL stacktrace in the > footer of the backend applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8250) SvnInfo.ftl and GitInfo.ftl are not generated by default
[ https://issues.apache.org/jira/browse/OFBIZ-8250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15500822#comment-15500822 ] Jacques Le Roux commented on OFBIZ-8250: Thanks Taher, it will be much easy to review the patch :). BTW Michael, please no Eclipse headers in patches ;) > SvnInfo.ftl and GitInfo.ftl are not generated by default > > > Key: OFBIZ-8250 > URL: https://issues.apache.org/jira/browse/OFBIZ-8250 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-8250-2.patch, OFBIZ-8250.patch > > > The two files are not generated which results in an FTL stacktrace in the > footer of the backend applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8250) SvnInfo.ftl and GitInfo.ftl are not generated by default
[ https://issues.apache.org/jira/browse/OFBIZ-8250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15500809#comment-15500809 ] Taher Alkhateeb commented on OFBIZ-8250: Hi Jacques. Michael discovered that by default on a clean checkout of OFBiz the files SvnInfo.ftl and GitInfo.ftl are not generated (but they used to be generated during the days of Ant). So this means, on a new checkout doing ./gradlew cleanAll loadDefault "ofbiz --start" would yield exceptions at the bottom of the page because of missing footer files. The purpose of the patch designed by Michael as far as I see is to generate these files (empty) if they are missing to avoid this exception stack-trace in the user interface, and he also added a clean task to remove the files when calling cleanAll. So what Michael did is make things nice and automatic so that users don't have to worry or intentionally call svnInfoFooter and gitInfoFooter. > SvnInfo.ftl and GitInfo.ftl are not generated by default > > > Key: OFBIZ-8250 > URL: https://issues.apache.org/jira/browse/OFBIZ-8250 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-8250-2.patch, OFBIZ-8250.patch > > > The two files are not generated which results in an FTL stacktrace in the > footer of the backend applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8250) SvnInfo.ftl and GitInfo.ftl are not generated by default
[ https://issues.apache.org/jira/browse/OFBIZ-8250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15500793#comment-15500793 ] Jacques Le Roux commented on OFBIZ-8250: I'd like to review this patch but I'm short on time. I'm not questionning the patch but the reason why it's done. Maybe you can explain? Else please wait before committing, thanks! > SvnInfo.ftl and GitInfo.ftl are not generated by default > > > Key: OFBIZ-8250 > URL: https://issues.apache.org/jira/browse/OFBIZ-8250 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-8250-2.patch, OFBIZ-8250.patch > > > The two files are not generated which results in an FTL stacktrace in the > footer of the backend applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8250) SvnInfo.ftl and GitInfo.ftl are not generated by default
[ https://issues.apache.org/jira/browse/OFBIZ-8250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15497780#comment-15497780 ] Michael Brohl commented on OFBIZ-8250: -- [~taher], can you please review the patch if it is correct and follows best practices for the gradle build? The task for file generation should be executed on every gradle execution, that happens e.g. when ./gradlew ofbiz is executed. The cleanFooterFiles task can be executed standalone and should be executed also when cleanAll is run. I have defined the files in the upper section of the gradle build file and removed them in the existing generation tasks for the git/svn info. Thanks for feedback, Michael > SvnInfo.ftl and GitInfo.ftl are not generated by default > > > Key: OFBIZ-8250 > URL: https://issues.apache.org/jira/browse/OFBIZ-8250 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-8250.patch > > > The two files are not generated which results in an FTL stacktrace in the > footer of the backend applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
