[jira] [Commented] (OFBIZ-8733) Improvements in ProductCategoryType entity definition and services

2016-11-04 Thread Arun Patidar (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15638551#comment-15638551
 ] 

Arun Patidar commented on OFBIZ-8733:
-

Committed changes in trunk at rev: 1768080.

Thanks [~rahul.kushwah] and [~rishisolankii] for the contribution.

> Improvements in ProductCategoryType entity definition and services
> --
>
> Key: OFBIZ-8733
> URL: https://issues.apache.org/jira/browse/OFBIZ-8733
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Arun Patidar
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-8733.patch
>
>
> Required improvements;
> - All is good with entity definition.
> - Add CRUD services using entity-auto. Make sure PK is optional while create 
> service, so that can be generated from OFBiz sequence generator.
> - Do related changes if any occurrence found for direct create/update/delete 
> of this entity, and replace them with crud services implemented.
> - As no status/from date/thru date exists in entity, so nothing needs to be 
> taken care while deleting the records from service.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8733) Improvements in ProductCategoryType entity definition and services

2016-11-03 Thread Rahul Singh (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633348#comment-15633348
 ] 

Rahul Singh commented on OFBIZ-8733:


Added the patch to fix this issue. Thanks, [~rishisolankii] for the detailed 
description. Also, verify the same from entity engine.


> Improvements in ProductCategoryType entity definition and services
> --
>
> Key: OFBIZ-8733
> URL: https://issues.apache.org/jira/browse/OFBIZ-8733
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-8733.patch
>
>
> Required improvements;
> - All is good with entity definition.
> - Add CRUD services using entity-auto. Make sure PK is optional while create 
> service, so that can be generated from OFBiz sequence generator.
> - Do related changes if any occurrence found for direct create/update/delete 
> of this entity, and replace them with crud services implemented.
> - As no status/from date/thru date exists in entity, so nothing needs to be 
> taken care while deleting the records from service.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)