[jira] [Commented] (OFBIZ-9088) Unit test case for service - addProductCategoryToCategory
[ https://issues.apache.org/jira/browse/OFBIZ-9088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100493#comment-17100493 ] ASF subversion and git services commented on OFBIZ-9088: Commit ff53e54a4ed487eed48067ab35b6faa5799b7db2 in ofbiz-framework's branch refs/heads/trunk from Pawan Verma [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=ff53e54 ] Improved: Groovy DSL test case for service addProductCategoryToCategory and getProductCategoryAndLimitedMembers (#111) * Improved: Groovy DSL test case for service addProductCategoryToCategory and getProductCategoryAndLimitedMembers (OFBIZ-9088) Thanks: Pradhan Yash Sharma for report and initial patch and Suraj and Jacques for the review. > Unit test case for service - addProductCategoryToCategory > - > > Key: OFBIZ-9088 > URL: https://issues.apache.org/jira/browse/OFBIZ-9088 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Pradhan Yash Sharma >Assignee: Pawan Verma >Priority: Minor > Attachments: OFBIZ-9088.patch > > > Unit test case for service - addProductCategoryToCategory -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-9088) Unit test case for service - addProductCategoryToCategory
[ https://issues.apache.org/jira/browse/OFBIZ-9088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099726#comment-17099726 ] Jacques Le Roux commented on OFBIZ-9088: Thanks Pawan, Works for me: +1 for commit > Unit test case for service - addProductCategoryToCategory > - > > Key: OFBIZ-9088 > URL: https://issues.apache.org/jira/browse/OFBIZ-9088 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Pradhan Yash Sharma >Assignee: Pawan Verma >Priority: Minor > Attachments: OFBIZ-9088.patch > > > Unit test case for service - addProductCategoryToCategory -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-9088) Unit test case for service - addProductCategoryToCategory
[ https://issues.apache.org/jira/browse/OFBIZ-9088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099631#comment-17099631 ] Pawan Verma commented on OFBIZ-9088: This has been done in PR: [https://github.com/apache/ofbiz-framework/pull/111] I've also converted existing testGetProductCategoryAndLimitedMembers Category test from XML to Groovy. This can be tested via: ./gradlew "ofbiz --test component=product --test suitename=catalogtests" > Unit test case for service - addProductCategoryToCategory > - > > Key: OFBIZ-9088 > URL: https://issues.apache.org/jira/browse/OFBIZ-9088 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Pradhan Yash Sharma >Assignee: Pawan Verma >Priority: Minor > Attachments: OFBIZ-9088.patch > > > Unit test case for service - addProductCategoryToCategory -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-9088) Unit test case for service - addProductCategoryToCategory
[ https://issues.apache.org/jira/browse/OFBIZ-9088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17082470#comment-17082470 ] Pawan Verma commented on OFBIZ-9088: I'll take care of its conversion and will send it to the repository. > Unit test case for service - addProductCategoryToCategory > - > > Key: OFBIZ-9088 > URL: https://issues.apache.org/jira/browse/OFBIZ-9088 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Pradhan Yash Sharma >Priority: Minor > Attachments: OFBIZ-9088.patch > > > Unit test case for service - addProductCategoryToCategory -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-9088) Unit test case for service - addProductCategoryToCategory
[ https://issues.apache.org/jira/browse/OFBIZ-9088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16879872#comment-16879872 ] Jacques Le Roux commented on OFBIZ-9088: Thanks Suraj! BTW for the sake of history here is my conclusion on the discussion on dev ML I started following the one in OFBIZ-1463, [[DISCUSSION] Committing Minilang test patches under OFBIZ-1463|https://markmail.org/message/yejhuoyfxo5wnnl5]: bq. After 3 days, only people against expressed their opinions, so I think the discussion is closed. > Unit test case for service - addProductCategoryToCategory > - > > Key: OFBIZ-9088 > URL: https://issues.apache.org/jira/browse/OFBIZ-9088 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Pradhan Yash Sharma >Assignee: Suraj Khurana >Priority: Minor > Attachments: OFBIZ-9088.patch > > > Unit test case for service - addProductCategoryToCategory -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9088) Unit test case for service - addProductCategoryToCategory
[ https://issues.apache.org/jira/browse/OFBIZ-9088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16879822#comment-16879822 ] Suraj Khurana commented on OFBIZ-9088: -- Yes, I will take care of this conversion and will proceed. > Unit test case for service - addProductCategoryToCategory > - > > Key: OFBIZ-9088 > URL: https://issues.apache.org/jira/browse/OFBIZ-9088 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Pradhan Yash Sharma >Priority: Minor > Attachments: OFBIZ-9088.patch > > > Unit test case for service - addProductCategoryToCategory -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9088) Unit test case for service - addProductCategoryToCategory
[ https://issues.apache.org/jira/browse/OFBIZ-9088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16853948#comment-16853948 ] Jacques Le Roux commented on OFBIZ-9088: Thanks Yash, We have decided to move from Minilang to Groovy so, as dicussed in OFBIZ-1463 we are insure about commiting this (stumbled uopn by chance), I'm still wondering about that. Because, even if the logic will still be the same it would be a pity to lose the work done because the patches don't apply. Anyway discussing this in OFBIZ-1463 is better. > Unit test case for service - addProductCategoryToCategory > - > > Key: OFBIZ-9088 > URL: https://issues.apache.org/jira/browse/OFBIZ-9088 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Pradhan Yash Sharma >Priority: Minor > Attachments: OFBIZ-9088.patch > > > Unit test case for service - addProductCategoryToCategory -- This message was sent by Atlassian JIRA (v7.6.3#76005)
