[jira] [Commented] (OFBIZ-9204) Cancelled OrderItems are still included in orderGrandTotal
[ https://issues.apache.org/jira/browse/OFBIZ-9204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855881#comment-15855881 ] Michael Brohl commented on OFBIZ-9204: -- Yes, please file a new issue, thanks Maurice! > Cancelled OrderItems are still included in orderGrandTotal > -- > > Key: OFBIZ-9204 > URL: https://issues.apache.org/jira/browse/OFBIZ-9204 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 14.12, Release Branch 15.12, Upcoming > Release, Release Branch 16.11 >Reporter: Maurice Meyer >Assignee: Michael Brohl > Fix For: Release Branch 14.12, Release Branch 15.12, Upcoming > Release, 16.11.02 > > Attachments: OFBIZ-9204.patch > > > Cancelled OrderItems are still included in the calculation of the order price. > Tested with release 16.11, revision: 1781126 > Steps to reproduce: > 1. Setup a fresh OFBiz and do loadDefault > 2. Go to the Order Manager and cancel the only existing demo order named > DEMO10090 here: > https://localhost:8443/ordermgr/control/orderview?orderId=DEMO10090 > 3. The "Total Due" at the bottom right still states 38.36$. It should be 0$ > because all the items got cancelled. > The error is probably in OrderView.groovy line 119: > OrderReadHelper.getOrderGrandTotal(orderItems, orderAdjustments) > This method apparently includes cancelled OrderItems in the grandTotal. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9204) Cancelled OrderItems are still included in orderGrandTotal
[ https://issues.apache.org/jira/browse/OFBIZ-9204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855863#comment-15855863 ] Maurice Meyer commented on OFBIZ-9204: -- Great, thanks for comitting. What about the tax issue? With the patch applied the "Total Due" of the cancelled order "DEMO10090" is - 0.04$. That's not working as intended, is it? Should a new Ticket be opened for that? > Cancelled OrderItems are still included in orderGrandTotal > -- > > Key: OFBIZ-9204 > URL: https://issues.apache.org/jira/browse/OFBIZ-9204 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 14.12, Release Branch 15.12, Upcoming > Release, Release Branch 16.11 >Reporter: Maurice Meyer >Assignee: Michael Brohl > Fix For: Release Branch 14.12, Release Branch 15.12, Upcoming > Release, 16.11.02 > > Attachments: OFBIZ-9204.patch > > > Cancelled OrderItems are still included in the calculation of the order price. > Tested with release 16.11, revision: 1781126 > Steps to reproduce: > 1. Setup a fresh OFBiz and do loadDefault > 2. Go to the Order Manager and cancel the only existing demo order named > DEMO10090 here: > https://localhost:8443/ordermgr/control/orderview?orderId=DEMO10090 > 3. The "Total Due" at the bottom right still states 38.36$. It should be 0$ > because all the items got cancelled. > The error is probably in OrderView.groovy line 119: > OrderReadHelper.getOrderGrandTotal(orderItems, orderAdjustments) > This method apparently includes cancelled OrderItems in the grandTotal. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9204) Cancelled OrderItems are still included in orderGrandTotal
[ https://issues.apache.org/jira/browse/OFBIZ-9204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855416#comment-15855416 ] Jacques Le Roux commented on OFBIZ-9204: I guess Deepak means bq. orderReadHelper.getOrderGrandTotal() > Cancelled OrderItems are still included in orderGrandTotal > -- > > Key: OFBIZ-9204 > URL: https://issues.apache.org/jira/browse/OFBIZ-9204 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 16.11 >Reporter: Maurice Meyer >Assignee: Michael Brohl > > Cancelled OrderItems are still included in the calculation of the order price. > Tested with release 16.11, revision: 1781126 > Steps to reproduce: > 1. Setup a fresh OFBiz and do loadDefault > 2. Go to the Order Manager and cancel the only existing demo order named > DEMO10090 here: > https://localhost:8443/ordermgr/control/orderview?orderId=DEMO10090 > 3. The "Total Due" at the bottom right still states 38.36$. It should be 0$ > because all the items got cancelled. > The error is probably in OrderView.groovy line 119: > OrderReadHelper.getOrderGrandTotal(orderItems, orderAdjustments) > This method apparently includes cancelled OrderItems in the grandTotal. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9204) Cancelled OrderItems are still included in orderGrandTotal
[
https://issues.apache.org/jira/browse/OFBIZ-9204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855385#comment-15855385
]
Deepak Dixit commented on OFBIZ-9204:
-
Hi Maurice,
Better fix is to use OrderReadHelper method directly to get grandTotal.
{code}
orh,getOrderGrandTotal()
{code}
You can create patch with these changes.
> Cancelled OrderItems are still included in orderGrandTotal
> --
>
> Key: OFBIZ-9204
> URL: https://issues.apache.org/jira/browse/OFBIZ-9204
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 16.11
>Reporter: Maurice Meyer
>Assignee: Michael Brohl
>
> Cancelled OrderItems are still included in the calculation of the order price.
> Tested with release 16.11, revision: 1781126
> Steps to reproduce:
> 1. Setup a fresh OFBiz and do loadDefault
> 2. Go to the Order Manager and cancel the only existing demo order named
> DEMO10090 here:
> https://localhost:8443/ordermgr/control/orderview?orderId=DEMO10090
> 3. The "Total Due" at the bottom right still states 38.36$. It should be 0$
> because all the items got cancelled.
> The error is probably in OrderView.groovy line 119:
> OrderReadHelper.getOrderGrandTotal(orderItems, orderAdjustments)
> This method apparently includes cancelled OrderItems in the grandTotal.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OFBIZ-9204) Cancelled OrderItems are still included in orderGrandTotal
[ https://issues.apache.org/jira/browse/OFBIZ-9204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15854355#comment-15854355 ] Michael Brohl commented on OFBIZ-9204: -- Hi Maurice, thanks for bringing this up. Is it possible for you to provide a patch for this issue? Thanks and regards, Michael > Cancelled OrderItems are still included in orderGrandTotal > -- > > Key: OFBIZ-9204 > URL: https://issues.apache.org/jira/browse/OFBIZ-9204 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 16.11 >Reporter: Maurice Meyer >Assignee: Michael Brohl > > Cancelled OrderItems are still included in the calculation of the order price. > Tested with release 16.11, revision: 1781126 > Steps to reproduce: > 1. Setup a fresh OFBiz and do loadDefault > 2. Go to the Order Manager and cancel the only existing demo order named > DEMO10090 here: > https://localhost:8443/ordermgr/control/orderview?orderId=DEMO10090 > 3. The "Total Due" at the bottom right still states 38.36$. It should be 0$ > because all the items got cancelled. > The error is probably in OrderView.groovy line 119: > OrderReadHelper.getOrderGrandTotal(orderItems, orderAdjustments) > This method apparently includes cancelled OrderItems in the grandTotal. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
