[jira] [Commented] (OFBIZ-9372) Convert AcctgAdminServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-9372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028829#comment-16028829 ] Leila Mekika commented on OFBIZ-9372: - Thanks [~gil portenseigne]. And thanks [~deepak.dixit] and [~jacques.le.roux] for the review and advices ! > Convert AcctgAdminServices.xml mini lang to groovy > -- > > Key: OFBIZ-9372 > URL: https://issues.apache.org/jira/browse/OFBIZ-9372 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Leila Mekika >Assignee: Gil Portenseigne >Priority: Minor > Attachments: OFBIZ-9372.patch > > > This is an attempt to migrate AcctgAdminServices.xml to groovy file version. > The discussion is still running about the automation of the migration and the > langage to use for service migration (Java or groovy) > In both case, maybe this can help migrate it to java or to identify some > automatic migration matching patterns. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9372) Convert AcctgAdminServices.xml mini lang to groovy
[
https://issues.apache.org/jira/browse/OFBIZ-9372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027411#comment-16027411
]
Jacques Le Roux commented on OFBIZ-9372:
Hi Leila, Deepak,
About
bq. Please use != null check for genericValue instead of using UtilValidate
method
Actually you can even follow
http://groovy-lang.org/semantics.html#Groovy-Truth. Also for String, etc.
So for instance
bq. while ( UtilValidate.isNotEmpty(currentOrganizationPartyId) &&
containsEmptyFields) {
can be written
bq. while (currentOrganizationPartyId && containsEmptyFields) {
and
bq. if (UtilValidate.isNotEmpty(currentPartyAcctgPref)) {
bq. if (currentPartyAcctgPref) {
etc. There are plenty of examples in current source.
> Convert AcctgAdminServices.xml mini lang to groovy
> --
>
> Key: OFBIZ-9372
> URL: https://issues.apache.org/jira/browse/OFBIZ-9372
> Project: OFBiz
> Issue Type: Sub-task
> Components: accounting
>Affects Versions: Trunk
>Reporter: Leila Mekika
>Priority: Minor
> Attachments: OFBIZ-9372.patch
>
>
> This is an attempt to migrate AcctgAdminServices.xml to groovy file version.
> The discussion is still running about the automation of the migration and the
> langage to use for service migration (Java or groovy)
> In both case, maybe this can help migrate it to java or to identify some
> automatic migration matching patterns.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OFBIZ-9372) Convert AcctgAdminServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-9372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027305#comment-16027305 ] Deepak Dixit commented on OFBIZ-9372: - Hi Leila, I reviewed your patch and it looks good to me, here are some couple of improvement that can be done - We can use entity-auto for createPartyAcctgPreference service - Please use != null check for genericValue instead of using UtilValidate method - We can use EntityConditionBuilder to make the entity condition. > Convert AcctgAdminServices.xml mini lang to groovy > -- > > Key: OFBIZ-9372 > URL: https://issues.apache.org/jira/browse/OFBIZ-9372 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Leila Mekika >Priority: Minor > Attachments: OFBIZ-9372.patch > > > This is an attempt to migrate AcctgAdminServices.xml to groovy file version. > The discussion is still running about the automation of the migration and the > langage to use for service migration (Java or groovy) > In both case, maybe this can help migrate it to java or to identify some > automatic migration matching patterns. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9372) Convert AcctgAdminServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-9372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027299#comment-16027299 ] Deepak Dixit commented on OFBIZ-9372: - Converted this ticket as sub-ticket of OFBIZ-9350, It will help to track the whole effort. > Convert AcctgAdminServices.xml mini lang to groovy > -- > > Key: OFBIZ-9372 > URL: https://issues.apache.org/jira/browse/OFBIZ-9372 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Leila Mekika >Priority: Minor > Attachments: OFBIZ-9372.patch > > > This is an attempt to migrate AcctgAdminServices.xml to groovy file version. > The discussion is still running about the automation of the migration and the > langage to use for service migration (Java or groovy) > In both case, maybe this can help migrate it to java or to identify some > automatic migration matching patterns. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
