[jira] [Commented] (OFBIZ-9383) Birt plugin depends on example plugin

2018-01-12 Thread Taher Alkhateeb (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323820#comment-16323820
 ] 

Taher Alkhateeb commented on OFBIZ-9383:


Reverted in r1820962 the code which caused issues in installing the BIRT 
component.

Between the two solutions that Michael suggested, I think the cleaner one is to 
"provide BIRT's own example data with example reports". I think maybe If BIRT 
is going to depend on something then it should be a core component, not another 
plugin. Less dependencies means less state, less wiring, and less complexity

> Birt plugin depends on example plugin 
> --
>
> Key: OFBIZ-9383
> URL: https://issues.apache.org/jira/browse/OFBIZ-9383
> Project: OFBiz
>  Issue Type: Bug
>  Components: birt
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Jacques Le Roux
> Fix For: 17.12.01
>
>
> The BIRT demo data for flexible reports depends on the Example entity from 
> the Example plugin.
> We should either provide BIRT's own example data with example reports OR 
> setup a gradle dependency on the example plugin so that everything is in 
> place.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9383) Birt plugin depends on example plugin

2017-12-12 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16287407#comment-16287407
 ] 

Jacques Le Roux commented on OFBIZ-9383:


For my tests, I initially make Birt example dependent on catalog then you don't 
have a plugin dependency, but still one on application (which is hidden for now 
since all is "framework"). But it fits more in example.

> Birt plugin depends on example plugin 
> --
>
> Key: OFBIZ-9383
> URL: https://issues.apache.org/jira/browse/OFBIZ-9383
> Project: OFBiz
>  Issue Type: Bug
>  Components: birt
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Jacques Le Roux
> Fix For: Upcoming Release
>
>
> The BIRT demo data for flexible reports depends on the Example entity from 
> the Example plugin.
> We should either provide BIRT's own example data with example reports OR 
> setup a gradle dependency on the example plugin so that everything is in 
> place.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9383) Birt plugin depends on example plugin

2017-12-12 Thread Michael Brohl (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16287339#comment-16287339
 ] 

Michael Brohl commented on OFBIZ-9383:
--

Ah, missed this commit. I think this can be improved indeed :-)

> Birt plugin depends on example plugin 
> --
>
> Key: OFBIZ-9383
> URL: https://issues.apache.org/jira/browse/OFBIZ-9383
> Project: OFBiz
>  Issue Type: Bug
>  Components: birt
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Jacques Le Roux
> Fix For: Upcoming Release
>
>
> The BIRT demo data for flexible reports depends on the Example entity from 
> the Example plugin.
> We should either provide BIRT's own example data with example reports OR 
> setup a gradle dependency on the example plugin so that everything is in 
> place.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)