[jira] [Commented] (OFBIZ-9849) Replace Inline js with External js in renderDropDownField macro
[ https://issues.apache.org/jira/browse/OFBIZ-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805708#comment-16805708 ] Aditya Sharma commented on OFBIZ-9849: -- Done for trunk at R1856610 and R18.12 at R1856611. Silghtly modified patch as Specify-other Dropdown field were not working. Refactored code in combobox.js file Thanks Dhaval Wagela for the initial patch > Replace Inline js with External js in renderDropDownField macro > --- > > Key: OFBIZ-9849 > URL: https://issues.apache.org/jira/browse/OFBIZ-9849 > Project: OFBiz > Issue Type: Sub-task >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Minor > Attachments: OFBIZ-9849.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9849) Replace Inline js with External js in renderDropDownField macro
[ https://issues.apache.org/jira/browse/OFBIZ-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788611#comment-16788611 ] Aditya Sharma commented on OFBIZ-9849: -- Hi Dhaval, While applying your patch I noticed that 'specify other' doesn't work anymore. Refer Specify-other Dropdown field from [Form Widget Examples|https://localhost:8443/example/control/FormWidgetExamples]. I will look further if I can fix that and then commit. > Replace Inline js with External js in renderDropDownField macro > --- > > Key: OFBIZ-9849 > URL: https://issues.apache.org/jira/browse/OFBIZ-9849 > Project: OFBiz > Issue Type: Sub-task >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Minor > Attachments: OFBIZ-9849.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9849) Replace Inline js with External js in renderDropDownField macro
[ https://issues.apache.org/jira/browse/OFBIZ-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744794#comment-16744794 ] Aditya Sharma commented on OFBIZ-9849: -- Thanks [~dhaval.wagela] . I will commit soon. > Replace Inline js with External js in renderDropDownField macro > --- > > Key: OFBIZ-9849 > URL: https://issues.apache.org/jira/browse/OFBIZ-9849 > Project: OFBiz > Issue Type: Sub-task >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Minor > Attachments: OFBIZ-9849.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9849) Replace Inline js with External js in renderDropDownField macro
[ https://issues.apache.org/jira/browse/OFBIZ-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491553#comment-16491553 ] Dhaval Wagela commented on OFBIZ-9849: -- Replaced inline js from renderDropDownField macro to external js in OfbizUtils.js Done following: Added class 'autoCompleteDropDown' to the field if ajaxEnabled is true, removed the code for the condition from the markup and added in OfbizUtils.js for the class 'autoCompleteDropDown'. Removed js code for change event from the markup and added it to the 'change' event of combobox in ajaxAutoCompleteDropDown function. Steps to verify: Navigate to FormWidgetExamples([https://localhost:8443/example/control/FormWidgetExamples]). Check the functionality of Autocomplete Dropdown in 'Drop down fields section'. > Replace Inline js with External js in renderDropDownField macro > --- > > Key: OFBIZ-9849 > URL: https://issues.apache.org/jira/browse/OFBIZ-9849 > Project: OFBiz > Issue Type: Sub-task >Reporter: Aditya Sharma >Assignee: Dhaval Wagela >Priority: Minor > Attachments: OFBIZ-9849.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
