[jira] [Commented] (OFBIZ-9984) Convert OrderServices.xml mini-lang to groovyDSL
[ https://issues.apache.org/jira/browse/OFBIZ-9984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850010#comment-17850010 ] Jacques Le Roux commented on OFBIZ-9984: Hi [~pgil], Would you mind takeover? It seems to me that [Sebastian is no longer working on OFBiz for almost a year|https://issues.apache.org/jira/secure/ViewProfile.jspa?name=sberg] > Convert OrderServices.xml mini-lang to groovyDSL > > > Key: OFBIZ-9984 > URL: https://issues.apache.org/jira/browse/OFBIZ-9984 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk, Upcoming Branch >Reporter: Julien NICOLAS >Assignee: Gil Portenseigne >Priority: Minor > Labels: groovy, mini-lang > Attachments: OFBIZ-9984-v1.patch, OFBIZ-9984.patch > > > With the purpose to deprecate mini-lang OFBIZ-9350, I tried to convert some > mini-lang service to groovy script. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-9984) Convert OrderServices.xml mini-lang to groovyDSL
[ https://issues.apache.org/jira/browse/OFBIZ-9984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687808#comment-17687808 ] Gil Portenseigne commented on OFBIZ-9984: - Hello Jacques, IIRW it was not complete, only partly done, as [~sberg] offers to continue the work, i stopped working on it and got on other subject. [~sberg] do you intent to continue ? Thanks Gil > Convert OrderServices.xml mini-lang to groovyDSL > > > Key: OFBIZ-9984 > URL: https://issues.apache.org/jira/browse/OFBIZ-9984 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk, Upcoming Branch >Reporter: Julien NICOLAS >Assignee: Gil Portenseigne >Priority: Minor > Labels: groovy, mini-lang > Attachments: OFBIZ-9984-v1.patch, OFBIZ-9984.patch > > > With the purpose to deprecate mini-lang OFBIZ-9350, I tried to convert some > mini-lang service to groovy script. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-9984) Convert OrderServices.xml mini-lang to groovyDSL
[ https://issues.apache.org/jira/browse/OFBIZ-9984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687385#comment-17687385 ] Jacques Le Roux commented on OFBIZ-9984: Hi Gil, Is that not complete? > Convert OrderServices.xml mini-lang to groovyDSL > > > Key: OFBIZ-9984 > URL: https://issues.apache.org/jira/browse/OFBIZ-9984 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk, Upcoming Branch >Reporter: Julien NICOLAS >Assignee: Gil Portenseigne >Priority: Minor > Labels: groovy, mini-lang > Attachments: OFBIZ-9984-v1.patch, OFBIZ-9984.patch > > > With the purpose to deprecate mini-lang OFBIZ-9350, I tried to convert some > mini-lang service to groovy script. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-9984) Convert OrderServices.xml mini-lang to groovyDSL
[ https://issues.apache.org/jira/browse/OFBIZ-9984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140613#comment-17140613 ] ASF subversion and git services commented on OFBIZ-9984: Commit 7c8aab3d9d92fb3d52661ef436f767516609cad0 in ofbiz-framework's branch refs/heads/trunk from Gil Portenseigne [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=7c8aab3 ] Improved: Migrate checkCreateOrderRequirement service to groovy (OFBIZ-9984) This commit migrate also dependent method and remove createRequirementFromItemATP service > Convert OrderServices.xml mini-lang to groovyDSL > > > Key: OFBIZ-9984 > URL: https://issues.apache.org/jira/browse/OFBIZ-9984 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Julien NICOLAS >Assignee: Gil Portenseigne >Priority: Minor > Labels: groovy, mini-lang > Attachments: OFBIZ-9984-v1.patch, OFBIZ-9984.patch > > > With the purpose to deprecate mini-lang OFBIZ-9350, I tried to convert some > mini-lang service to groovy script. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-9984) Convert OrderServices.xml mini-lang to groovyDSL
[ https://issues.apache.org/jira/browse/OFBIZ-9984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053580#comment-17053580 ] ASF subversion and git services commented on OFBIZ-9984: Commit b79c95b151a2daaccefa6436390865e83dff2841 in ofbiz-framework's branch refs/heads/trunk from Gil Portenseigne [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b79c95b ] Fixed: Convert OrderServices.xml mini-lang to groovyDSL : getNextOrderId (OFBIZ-9984) Fix introduced NPE detected by the introduced test. > Convert OrderServices.xml mini-lang to groovyDSL > > > Key: OFBIZ-9984 > URL: https://issues.apache.org/jira/browse/OFBIZ-9984 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Julien NICOLAS >Assignee: Gil Portenseigne >Priority: Minor > Labels: groovy, mini-lang > Attachments: OFBIZ-9984-v1.patch, OFBIZ-9984.patch > > > With the purpose to deprecate mini-lang OFBIZ-9350, I tried to convert some > mini-lang service to groovy script. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-9984) Convert OrderServices.xml mini-lang to groovyDSL
[ https://issues.apache.org/jira/browse/OFBIZ-9984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053483#comment-17053483 ] ASF subversion and git services commented on OFBIZ-9984: Commit eba4157c59bcc0c34c4414e3667333177225c239 in ofbiz-framework's branch refs/heads/trunk from Gil Portenseigne [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=eba4157 ] Improved: Convert OrderServices.xml mini-lang to groovyDSL : getNextOrderId (OFBIZ-9984) Thanks Julien for your old patch, it has been improved. Add a new integration test for the service 'getNextOrderId' > Convert OrderServices.xml mini-lang to groovyDSL > > > Key: OFBIZ-9984 > URL: https://issues.apache.org/jira/browse/OFBIZ-9984 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Julien NICOLAS >Assignee: Gil Portenseigne >Priority: Minor > Labels: groovy, mini-lang > Attachments: OFBIZ-9984-v1.patch, OFBIZ-9984.patch > > > With the purpose to deprecate mini-lang OFBIZ-9350, I tried to convert some > mini-lang service to groovy script. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-9984) Convert OrderServices.xml mini-lang to groovyDSL
[ https://issues.apache.org/jira/browse/OFBIZ-9984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053484#comment-17053484 ] ASF subversion and git services commented on OFBIZ-9984: Commit 53a8b812607f9987a1063f18062a5318cafe444c in ofbiz-framework's branch refs/heads/trunk from Gil Portenseigne [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=53a8b81 ] Improved: Convert OrderServices.xml mini-lang to groovyDSL : getOrderedSummaryInformation (OFBIZ-9984) Thanks Julien for your contribution > Convert OrderServices.xml mini-lang to groovyDSL > > > Key: OFBIZ-9984 > URL: https://issues.apache.org/jira/browse/OFBIZ-9984 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Julien NICOLAS >Assignee: Gil Portenseigne >Priority: Minor > Labels: groovy, mini-lang > Attachments: OFBIZ-9984-v1.patch, OFBIZ-9984.patch > > > With the purpose to deprecate mini-lang OFBIZ-9350, I tried to convert some > mini-lang service to groovy script. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-9984) Convert OrderServices.xml mini-lang to groovyDSL
[ https://issues.apache.org/jira/browse/OFBIZ-9984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053474#comment-17053474 ] Gil Portenseigne commented on OFBIZ-9984: - Hello [~sberg] Sorry for the delay, i will commit soon [~julien.nicolas] contribution with updates. And i'm starting requirement services. We can share the work for sure ! I'm on invoke="checkCreateOrderRequirement" and invoke="createRequirementFromItemATP". > Convert OrderServices.xml mini-lang to groovyDSL > > > Key: OFBIZ-9984 > URL: https://issues.apache.org/jira/browse/OFBIZ-9984 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Julien NICOLAS >Assignee: Gil Portenseigne >Priority: Minor > Labels: groovy, mini-lang > Attachments: OFBIZ-9984-v1.patch, OFBIZ-9984.patch > > > With the purpose to deprecate mini-lang OFBIZ-9350, I tried to convert some > mini-lang service to groovy script. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-9984) Convert OrderServices.xml mini-lang to groovyDSL
[ https://issues.apache.org/jira/browse/OFBIZ-9984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052201#comment-17052201 ] Sebastian Berg commented on OFBIZ-9984: --- Hi, I would like to convert the remaining Methods in OrderServices.xml to groovy. Do you mind if I take this one on me [~pgil]? > Convert OrderServices.xml mini-lang to groovyDSL > > > Key: OFBIZ-9984 > URL: https://issues.apache.org/jira/browse/OFBIZ-9984 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Julien NICOLAS >Assignee: Gil Portenseigne >Priority: Minor > Labels: groovy, mini-lang > Attachments: OFBIZ-9984-v1.patch, OFBIZ-9984.patch > > > With the purpose to deprecate mini-lang OFBIZ-9350, I tried to convert some > mini-lang service to groovy script. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-9984) Convert OrderServices.xml mini-lang to groovyDSL
[
https://issues.apache.org/jira/browse/OFBIZ-9984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17040028#comment-17040028
]
Pierre Smits commented on OFBIZ-9984:
-
Some vetting feedback:
{code:java}
+1 overall
_
/ ___| _ _ ___ ___ ___ ___ ___| |
\___ \| | | |/ __/ __/ _ \/ __/ __| |
___) | |_| | (_| (_| __/\__ \__ \_|
|/ \__,_|\___\___\___||___/___(_)
| Vote | Subsystem | Runtime | Comment
| 0 | reexec | 0m 30s | Docker mode activated.
+---
| | | | Prechecks
+---
| +1 | dupname | 0m 1s | No case conflicting files found.
| +1 | @author | 0m 0s | The patch does not contain any @author
| | | | tags.
| +1 | test4tests | 0m 0s | The patch appears to include 1 new or
| | | | modified test files.
+---
| | | | trunk Compile Tests
+---
| +1 | compile | 21m 38s | trunk passed
| +1 | checkstyle | 12m 39s | trunk passed
| +1 | javadoc | 3m 25s | trunk passed
+---
| | | | Patch Compile Tests
+---
| +1 | compile | 5m 48s | the patch passed
| +1 | javac | 5m 48s | the patch passed
| -0 | checkstyle | 15m 51s | root: The patch generated 1 new + 17
| | | | unchanged - 0 fixed = 18 total (was 17)
| +1 | whitespace | 0m 0s | The patch has no whitespace issues.
| +1 | xml | 0m 4s | The patch has no ill-formed XML file.
| +1 | javadoc | 6m 9s | the patch passed
+---
| | | | Other Tests
+---
| 0 | asflicense | 0m 50s | ASF License check generated no output?
| | | 79m 9s |
|| Subsystem || Report/Notes ||
| Docker | Client=18.09.2 Server=18.09.2 base:
/Users/nl04748/dev/test/yetus/ofbiz/OFBIZ-9984/Dockerfile |
| JIRA Issue | OFBIZ-9984 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12943854/OFBIZ-9984.patch |
{code}
> Convert OrderServices.xml mini-lang to groovyDSL
>
>
> Key: OFBIZ-9984
> URL: https://issues.apache.org/jira/browse/OFBIZ-9984
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
>Affects Versions: Trunk
>Reporter: Julien NICOLAS
>Assignee: Gil Portenseigne
>Priority: Minor
> Labels: groovy, mini-lang
> Attachments: OFBIZ-9984-v1.patch, OFBIZ-9984.patch
>
>
> With the purpose to deprecate mini-lang OFBIZ-9350, I tried to convert some
> mini-lang service to groovy script.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-9984) Convert OrderServices.xml mini-lang to groovyDSL
[ https://issues.apache.org/jira/browse/OFBIZ-9984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649542#comment-16649542 ] Gil Portenseigne commented on OFBIZ-9984: - I just add a reworked patch with a new test for getNextOrderId service. I'll re-read it in few days and clear mind ;) > Convert OrderServices.xml mini-lang to groovyDSL > > > Key: OFBIZ-9984 > URL: https://issues.apache.org/jira/browse/OFBIZ-9984 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Julien NICOLAS >Assignee: Gil Portenseigne >Priority: Minor > Labels: groovy, mini-lang > Attachments: OFBIZ-9984-v1.patch, OFBIZ-9984.patch > > > With the purpose to deprecate mini-lang OFBIZ-9350, I tried to convert some > mini-lang service to groovy script. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
