[jira] [Commented] (OFBIZ-9993) Convert CommonPermissionServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-9993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354615#comment-16354615 ] Nicolas Malin commented on OFBIZ-9993: -- It's ok for me Dennis, I clear a few the code and commit it at revision 1823397 on trunk. > Convert CommonPermissionServices.xml mini lang to groovy > > > Key: OFBIZ-9993 > URL: https://issues.apache.org/jira/browse/OFBIZ-9993 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Nicolas Malin >Priority: Minor > Attachments: > OFBIZ-9993_org.apache.ofbiz.common.permission.CommonPermissionServices_convert.patch, > > OFBIZ-9993_org.apache.ofbiz.common.permission.CommonPermissionServices_convert.patch, > > OFBIZ-9993_org.apache.ofbiz.common.permission.CommonPermissionServices_convert.patch > > > Migration of the CommonPermissionServices.xml to Groovy -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9993) Convert CommonPermissionServices.xml mini lang to groovy
[
https://issues.apache.org/jira/browse/OFBIZ-9993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354093#comment-16354093
]
Dennis Balkir commented on OFBIZ-9993:
--
So I made a few mistakes with this:
# I used the MiniLang tag but it didn't do what I expected,
so actually the field I tried to put into the result map of
genericBasePermissionCheck did not really find its way into the result. I
changed that, this works now
# I had to add the old if-phrases into the genericBasePermissionCheck
simple-method (which is still only there to call the groovy-service), because
there were some cases in which the fields did not have the values they should
have had and this will check for those cases
# I recognized, that I forgot to put "_" in front of the {{mainAction}} field
while using {{hasEntityPermission}}, this resulted in the method not getting
the permissions right. Somehow I managed to not forget it for my other
conversions, which makes this kind of weird. It works fine now though
The testIntegration succeed now and the manual checking of the method seems to
work too
> Convert CommonPermissionServices.xml mini lang to groovy
>
>
> Key: OFBIZ-9993
> URL: https://issues.apache.org/jira/browse/OFBIZ-9993
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments:
> OFBIZ-9993_org.apache.ofbiz.common.permission.CommonPermissionServices_convert.patch,
>
> OFBIZ-9993_org.apache.ofbiz.common.permission.CommonPermissionServices_convert.patch,
>
> OFBIZ-9993_org.apache.ofbiz.common.permission.CommonPermissionServices_convert.patch
>
>
> Migration of the CommonPermissionServices.xml to Groovy
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-9993) Convert CommonPermissionServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-9993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350519#comment-16350519 ] Dennis Balkir commented on OFBIZ-9993: -- Hi Nicolas, actually I got this too. I tested the services on the web-page via service-engine, in which they work fine, but it seems like there still is a mistake in my conversion, I am sorry for that! I currently am trying to fix it, I will upload a new patch asap > Convert CommonPermissionServices.xml mini lang to groovy > > > Key: OFBIZ-9993 > URL: https://issues.apache.org/jira/browse/OFBIZ-9993 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Nicolas Malin >Priority: Minor > Attachments: > OFBIZ-9993_org.apache.ofbiz.common.permission.CommonPermissionServices_convert.patch, > > OFBIZ-9993_org.apache.ofbiz.common.permission.CommonPermissionServices_convert.patch > > > Migration of the CommonPermissionServices.xml to Groovy -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9993) Convert CommonPermissionServices.xml mini lang to groovy
[
https://issues.apache.org/jira/browse/OFBIZ-9993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349460#comment-16349460
]
Nicolas Malin commented on OFBIZ-9993:
--
Hi Dennis,
Integration tests failed with your patch
{quote}...--> marketing-tests.testCreateAndUpdateContactList...The following
required parameter is missing: [IN]
[genericBasePermissionCheck.primaryPermission]]]
{quote}
Do you have the same result ?
> Convert CommonPermissionServices.xml mini lang to groovy
>
>
> Key: OFBIZ-9993
> URL: https://issues.apache.org/jira/browse/OFBIZ-9993
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments:
> OFBIZ-9993_org.apache.ofbiz.common.permission.CommonPermissionServices_convert.patch,
>
> OFBIZ-9993_org.apache.ofbiz.common.permission.CommonPermissionServices_convert.patch
>
>
> Migration of the CommonPermissionServices.xml to Groovy
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-9993) Convert CommonPermissionServices.xml mini lang to groovy
[
https://issues.apache.org/jira/browse/OFBIZ-9993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345291#comment-16345291
]
Dennis Balkir commented on OFBIZ-9993:
--
Found a "small" mistake.
I tested the services, by starting them manually or by searching for
menu-points which may start them.
The service {{genericBasePermissionCheck}} worked fine while starting it
manually, but the changed simple-method I used to redirect the
simple-method-calls of {{genericBasePermissionCheck}} to a service-call had
some mistakes.
I looked a littlebit deeper into this and it should work now, at least for me
it is not producing errors anymore.
(It wouldn't find the necessary in-parameters to actually get the service
started, I simply forgot to set them)
> Convert CommonPermissionServices.xml mini lang to groovy
>
>
> Key: OFBIZ-9993
> URL: https://issues.apache.org/jira/browse/OFBIZ-9993
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments:
> OFBIZ-9993_org.apache.ofbiz.common.permission.CommonPermissionServices_convert.patch,
>
> OFBIZ-9993_org.apache.ofbiz.common.permission.CommonPermissionServices_convert.patch
>
>
> Migration of the CommonPermissionServices.xml to Groovy
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-9993) Convert CommonPermissionServices.xml mini lang to groovy
[
https://issues.apache.org/jira/browse/OFBIZ-9993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344994#comment-16344994
]
Dennis Balkir commented on OFBIZ-9993:
--
The simple-method {{genericBasePermissionCheck}} was called via simple-method
calls throughout OFBiz. I had to leave the simple method in because of this,
but changed it so it just calls the service which defines the method (the
service was there before).
I tested all the services in this file as good as I could, they seem to work
and do what they should do and I would appreciate if one of the involved people
can give me a feedback on this file
> Convert CommonPermissionServices.xml mini lang to groovy
>
>
> Key: OFBIZ-9993
> URL: https://issues.apache.org/jira/browse/OFBIZ-9993
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Priority: Minor
> Attachments:
> OFBIZ-9993_org.apache.ofbiz.common.permission.CommonPermissionServices_convert.patch
>
>
> Migration of the CommonPermissionServices.xml to Groovy
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
