[
https://issues.apache.org/jira/browse/OFBIZ-9711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Balkir updated OFBIZ-9711:
---------------------------------
Attachment: OFBIZ-9711_org.apache.ofbiz.entity.cache_bugfixes.patch
- Diamond Operators fixed
- Line 68: removed the unnecessary if, {{model}} cannot be null at this point
- Line 167: not used if phase removed
- Line 181: not used if phrase removed
> [FB] Package org.apache.ofbiz.entity.cache
> ------------------------------------------
>
> Key: OFBIZ-9711
> URL: https://issues.apache.org/jira/browse/OFBIZ-9711
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
> Affects Versions: Trunk
> Reporter: Dennis Balkir
> Priority: Minor
> Attachments: OFBIZ-9711_org.apache.ofbiz.entity.cache_bugfixes.patch
>
>
> - AbstractEntityConditionCache.java:68,
> RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE
> RCN: Redundant nullcheck of model, which is known to be non-null in
> org.apache.ofbiz.entity.cache.AbstractEntityConditionCache.remove(GenericEntity)
> This method contains a redundant check of a known non-null value against the
> constant null.
> - AbstractEntityConditionCache.java:169, UCF_USELESS_CONTROL_FLOW
> UCF: Useless control flow in
> org.apache.ofbiz.entity.cache.AbstractEntityConditionCache.storeHook(boolean,
> GenericEntity, GenericEntity)
> This method contains a useless control flow statement, where control flow
> continues onto the same place regardless of whether or not the branch is
> taken. For example, this is caused by having an empty statement block for an
> if statement:
> if (argv.length == 0) {
> // TODO: handle this case
> }
> - AbstractEntityConditionCache.java:183, UCF_USELESS_CONTROL_FLOW
> UCF: Useless control flow in
> org.apache.ofbiz.entity.cache.AbstractEntityConditionCache.storeHook(String,
> boolean, List, List)
> This method contains a useless control flow statement, where control flow
> continues onto the same place regardless of whether or not the branch is
> taken. For example, this is caused by having an empty statement block for an
> if statement:
> if (argv.length == 0) {
> // TODO: handle this case
> }
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
