[jira] [Commented] (OFBIZ-10393) Remove `createContent` Java service implementation
[ https://issues.apache.org/jira/browse/OFBIZ-10393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464052#comment-16464052 ] Jacques Le Roux commented on OFBIZ-10393: - Hi Mathieu, Wait, we have decided to deprecate Minilang. So I wonder if we should not go the other way around. Better to ask on dev ML, thanks! > Remove `createContent` Java service implementation > -- > > Key: OFBIZ-10393 > URL: https://issues.apache.org/jira/browse/OFBIZ-10393 > Project: OFBiz > Issue Type: Improvement > Components: content >Reporter: Mathieu Lirzin >Priority: Trivial > Attachments: > OFBIZ-10393-improved-Remove-createContent-Java-service-implement.patch > > > The `createContent` service has been replaced by a minilang implementation > since 2007 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-6858) Solr logging doesn't work
[ https://issues.apache.org/jira/browse/OFBIZ-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464590#comment-16464590 ] Shawn Heisey commented on OFBIZ-6858: - Solr 7.4 will ship with log4j2. The release hasn't been started yet. I don't know when that's going to happen. The 7.3.1 release is underway right at this moment. Note that running Solr in a container other than the Jetty it ships with is an unsupported configuration. https://wiki.apache.org/solr/WhyNoWar The logging tab in the admin UI was the major complication on SOLR-7887. The code that populated that page was *specific* to log4j 1.2, and had to be re-implemented with log4j2. Upgrading to log4j2 would have been quite easy if the admin UI did not have a logging page. > Solr logging doesn't work > - > > Key: OFBIZ-6858 > URL: https://issues.apache.org/jira/browse/OFBIZ-6858 > Project: OFBiz > Issue Type: Bug > Components: solr >Affects Versions: Trunk, Release Branch 15.12 >Reporter: Pierre Smits >Assignee: Shi Jinghai >Priority: Major > Attachments: Image2.png > > > When looking at the logging screen in demo-trunk > (https://demo-trunk-ofbiz.apache.org/solr/#/~logging) no logging results are > shown. Nor does https://demo-trunk-ofbiz.apache.org/solr/#/~logging/level > provide any insights. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10394) Fix typo "paramters" => "parameters"
[ https://issues.apache.org/jira/browse/OFBIZ-10394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit reassigned OFBIZ-10394: Assignee: Deepak Dixit > Fix typo "paramters" => "parameters" > > > Key: OFBIZ-10394 > URL: https://issues.apache.org/jira/browse/OFBIZ-10394 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Deepak Dixit >Priority: Minor > Attachments: OFBIZ-10394-Fix-typo-paramters-parameters.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10394) Fix typo "paramters" => "parameters"
[ https://issues.apache.org/jira/browse/OFBIZ-10394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464316#comment-16464316 ] Deepak Dixit commented on OFBIZ-10394: -- Thanks Mathieu Lirzin for your contribution, This as been fixed at ofbiz framework trunk at r#1830936 ofbiz framework R17.12 at r#1830938 release 16.11 at r#1830939 [~mthl] It would be good if you provide patch using svn diff, or if you are using git you can create patch using git diff --no-prefix. > Fix typo "paramters" => "parameters" > > > Key: OFBIZ-10394 > URL: https://issues.apache.org/jira/browse/OFBIZ-10394 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Deepak Dixit >Priority: Minor > Fix For: 16.11.05 > > Attachments: OFBIZ-10394-Fix-typo-paramters-parameters.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10221) Improve layout and structure of forms
[ https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463635#comment-16463635 ] Jacques Le Roux commented on OFBIZ-10221: - Wait, I was just testing OFBIZ-10036 and found a difference in the product/catalog main page between stable and trunk and I prefer stable. I'd like to have other opinions, please compare [https://demo-stable.ofbiz.apache.org/catalog/control/main?USERNAME=admin=ofbiz=Y] [https://demo-trunk.ofbiz.apache.org/catalog/control/main?USERNAME=admin=ofbiz=Y] and let me know I have not checked much other pages yet, [https://localhost:8443/catalog/control/FindCatalog] and [https://localhost:8443/catalog/control/FindCategory] and it's maybe only "an issue" with /applications/product/template/Main.ftl (or other ftl files?) > Improve layout and structure of forms > - > > Key: OFBIZ-10221 > URL: https://issues.apache.org/jira/browse/OFBIZ-10221 > Project: OFBiz > Issue Type: Improvement >Reporter: Julian Leichert >Assignee: Michael Brohl >Priority: Minor > Labels: backport-needed > Fix For: 17.12.01 > > Attachments: OFBIZ-10221-product.template.Main.patch, > OFBIZ-10221_content.content.ContentSearchOptions.patch, > OFBIZ-10221_content.template.cms.AddSubSite.patch, > OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, > OFBIZ-10221_party.template.party.AddressMatchMap.patch, > OFBIZ-10221_product.template.AddMultipleImages.patch, > OFBIZ-10221_product.template.Main.patch, > OFBIZ-10221_webtools.entity.ArtifactInfo.patch, > OFBIZ-10221_webtools.entity.CheckDb.patch, > OFBIZ-10221_webtools.entity.EntityExportAll.patch, > OFBIZ-10221_webtools.entity.EntityImport.patch, > OFBIZ-10221_webtools.entity.EntityImportDir.patch, > OFBIZ-10221_webtools.entity.EntityImportReaders.patch, > OFBIZ-10221_webtools.entity.FetchLogs.patch, > OFBIZ-10221_webtools.entity.ViewDataFile.patch, > OFBIZ-10221_webtools.entity.XmlDsDump.patch > > > While working at a Theme, i discovered that the forms differ in their style > and structure. > I propose a standard form-structure, so that further styling and look is > coherent. > I.e. class definitions ( class="basic-form") are often missing, input-fields > vary in size and the layout does not follow a standard structure. > As mentioned in > [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E] > I have attached an example patch, which modifies a form defined in FreeMarker > to conform it to the forms defined in any *Forms.xml. > Often those forms within FreeMarker templates differ from most other forms in > Ofbiz, > I propose a refactoring of these FreeMarker forms, to equalize all forms. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10365) Document design approaches for Inventory Transfer
[ https://issues.apache.org/jira/browse/OFBIZ-10365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463613#comment-16463613 ] Pawan Verma commented on OFBIZ-10365: - While refining design of this task, we have found that we need to add item section for inventory transfer requirement view screen same as quote items, shipment items. From this screen, the user can add/edit inventory transfer item and manually override inventory assigned to the specific item. I am working on this and will refine design processes soon. > Document design approaches for Inventory Transfer > -- > > Key: OFBIZ-10365 > URL: https://issues.apache.org/jira/browse/OFBIZ-10365 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Minor > Attachments: InventoryTransferModelLevel1.png, > OrderModelActivityLevel1.png > > > h2. Here is the link for the > [discussion|https://markmail.org/message/7qrjhpuvkc3n6hk4]. > h2. *Design Approach #1:* > * Create Header entity *InventoryTransferHeader (ITH)* > ** inventoryTransferId* > ** statusId > ** facilityId > ** locationSeqId > ** facilityIdTo > ** locationSeqIdTo > ** primaryShipmentId > > * Refactor existing *InventoryTransfer* entity to *InventoryTransferItem* so > as to support item level details as follows: > ** inventoryTransferId* > ** invTransferItemSeqId* > ** inventoryItemId > ** shipmentId > ** shipmentItemSeqId > ** quantity > ** unitPrice > > Having InventoryItem detail at InventoryTransferItem level will help us to > manage multiple Items under same InventoryTransfer and each > InventoryTransferItem can be fulfilled via multiple Inventory items and/or > multiple Shipments. > > * Create *TransferItemBilling* entity to support invoicing (if needed) > ** inventoryTransferId* > ** invTransferItemSeqId* > ** invoiceId* > ** invoiceItemSeqId* > ** itemIssuanceId > ** shipmentReceiptId > ** quantity > ** Amount > * Create *InventoryTransferContanctMech* entity to support InventoryTransfer > Contact Mechanism > ** inventoryTransferId* > ** contactMechPurposeTypeId* > ** contactMechId* > * Create *RequirementInventoryTransfer* entity > ** requirementId* > ** inventoryTransferId* > * Refactor existing *InventoryItemDetail* entity > ** inventoryTransferId > ** invTransferItemSeqId > *Screenflow for Approach #1:* > * Add a new *Find Transfer Requirements* screen. > ** Transfer Requirements can be searched with following parameters: > *** Requirement ID > *** Status ID > *** Shipment ID > *** Origin Facility ID > *** Destination Facility ID > *** Product ID > *** Description > *** Requirement Start Date > *** Required By Date > > * Option for creating Inventory Transfer for Un-approved requirements will > be disabled. > * User can select multiple Approved Transfer Requirements between any two > given facilities to create Single Inventory Transfer between them. > * When user hit ‘Create Inventory Transfer’ option new Inventory Transfers > would be created by consolidating all products/items requirements between any > two given locations. > * System would auto-assign the required quantity from existing > inventoryItems based on FIFO. > * Add a new *View Inventory Transfer* screen > ** From here user can manually override the auto-assigned InventoryItems > against each product. > ** User can Add/Edit/Delete the Transfer Items. > ** After assigning InventoryItems user can Approve the Inventory Transfer. > ** Upon Approval ATP would get reduced to the tune of assigned quantity from > each inventory item. > * Refactor the ‘Packing’ screen and allow to submit the Approved Inventory > Transfer Id (aka OrderId). Only Approved Inventory Transfer will be available > to pack. > * Upon completion of packing reduce the QOH from assigned inventory items to > the tune of packed quantity. > * After completing packing, shipment will be created in shipped status and > Inventory Transfer will be marked as 'SENT'. > * Once received at destination location the ATP/QOH would be increased up to > the transferred quantity per product and shipment will be marked as > 'RECEIVED' and Inventory Transfer will be marked as 'COMPLETED'. > > *To Be Business Process for Approach #1:* > *!InventoryTransferModelLevel1.png!* > > h2. *Design Approach #2:* > * Alter *InventoryTransfer* entity as header entity as follows: > ** Add primaryShipmentId > ** Remove inventoryItemId > > * Add new entity *InventoryTransferItem* > ** inventoryTransferId* > ** invTransferItemSeqId* > ** inventoryItemId > ** shipmentId > ** shipmentItemSeqId > ** quantity > ** unitPrice > Having InventoryItem detail at
[jira] [Commented] (OFBIZ-10221) Improve layout and structure of forms
[ https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463643#comment-16463643 ] Jacques Le Roux commented on OFBIZ-10221: - I just tested all catalog main pages, all the same than in stable (at 1st glance) and OK with me. > Improve layout and structure of forms > - > > Key: OFBIZ-10221 > URL: https://issues.apache.org/jira/browse/OFBIZ-10221 > Project: OFBiz > Issue Type: Improvement >Reporter: Julian Leichert >Assignee: Michael Brohl >Priority: Minor > Labels: backport-needed > Fix For: 17.12.01 > > Attachments: OFBIZ-10221-product.template.Main.patch, > OFBIZ-10221_content.content.ContentSearchOptions.patch, > OFBIZ-10221_content.template.cms.AddSubSite.patch, > OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, > OFBIZ-10221_party.template.party.AddressMatchMap.patch, > OFBIZ-10221_product.template.AddMultipleImages.patch, > OFBIZ-10221_product.template.Main.patch, > OFBIZ-10221_webtools.entity.ArtifactInfo.patch, > OFBIZ-10221_webtools.entity.CheckDb.patch, > OFBIZ-10221_webtools.entity.EntityExportAll.patch, > OFBIZ-10221_webtools.entity.EntityImport.patch, > OFBIZ-10221_webtools.entity.EntityImportDir.patch, > OFBIZ-10221_webtools.entity.EntityImportReaders.patch, > OFBIZ-10221_webtools.entity.FetchLogs.patch, > OFBIZ-10221_webtools.entity.ViewDataFile.patch, > OFBIZ-10221_webtools.entity.XmlDsDump.patch > > > While working at a Theme, i discovered that the forms differ in their style > and structure. > I propose a standard form-structure, so that further styling and look is > coherent. > I.e. class definitions ( class="basic-form") are often missing, input-fields > vary in size and the layout does not follow a standard structure. > As mentioned in > [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E] > I have attached an example patch, which modifies a form defined in FreeMarker > to conform it to the forms defined in any *Forms.xml. > Often those forms within FreeMarker templates differ from most other forms in > Ofbiz, > I propose a refactoring of these FreeMarker forms, to equalize all forms. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10036) Update to Tomcat 9.0.x
[
https://issues.apache.org/jira/browse/OFBIZ-10036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463648#comment-16463648
]
Jacques Le Roux commented on OFBIZ-10036:
-
Thanks Jacopo,
All tests pass on Windows 7 and the UI seems to work w/ issues on both back and
front end.
+ 1 for commit, this will allow me to continue safely on the dependent pending
issues...
> Update to Tomcat 9.0.x
> --
>
> Key: OFBIZ-10036
> URL: https://issues.apache.org/jira/browse/OFBIZ-10036
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-10036.patch
>
>
> We should try to update from Tomcat 8.5.24 to 9.0.2 or later.
> A first try during the work on OFBIZ-10026 causes the tests to hang when
> starting the testXmlMacroLibrary tests. There is no error, just no activity
> after more than 30 minutes.
> {noformat}
> 2017-12-02 18:56:49,658 |main |TestRunContainer
> |I| [JUNIT] : service-xml-rpc-local-engine finished.
> 2017-12-02 18:56:49,658 |main |GenericDelegator
> |I| Rolling back 52 entity operations
> 2017-12-02 18:56:49,783 |main |TestRunContainer
> |I| [JUNIT] Results for test suite: servicetests
> 2017-12-02 18:56:49,783 |main |TestRunContainer
> |I| [JUNIT] Pass: true | # Tests: 31 | # Failed: 0 # Errors: 0
> 2017-12-02 18:56:49,789 |main |TestRunContainer
> |I| [JUNIT] : testXmlMacroLibrary starting...
> {noformat}
> This will need further investigation and maybe an in-depth check of the
> documentation, see
> https://tomcat.apache.org/migration-9.html#Migrating_from_8.0.x_or_8.5.x_to_9.0.x
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10351) Tree View of Call Graph for Services and Simple Methods
[ https://issues.apache.org/jira/browse/OFBIZ-10351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463904#comment-16463904 ] Taher Alkhateeb commented on OFBIZ-10351: - Hello James, Thank you for your work again! Okay I reviewed this feature and I have some comments: * I felt a little nervous with this implementation, it touches core classes like the ControlServlet and ServiceEcaRule at multiple points. * This intrusion is then wired into a logic that passes plain text to a class that indents text based on the location in the call graph using a ThreadLocal variable. It does not provide any standard data structure format (XML, JSON, or anything else) * Whether the option "showServiceCallGraph" is turned on or not, the code you introduced to the core classes would always execute, and you would only inhibit the output to logs. I would much prefer if the call graph is first converted to a model or some data structure, and then data is rendered from that model not manually by an indentation helper class but a proper data structure rendering class / API. We have plenty of things that can be used in OFBiz to that effect. I think I would also prefer not to weave the logic right into the heart of the framework, this should be a boxed logic that is called into when needed, not called always and inhibited. I hope you take this feedback positively and consider maybe a safer approach. The classes I mentioned above already require a lot of refactoring and cleanup, and more entanglements would make them heavier and more difficult to refactor. > Tree View of Call Graph for Services and Simple Methods > --- > > Key: OFBIZ-10351 > URL: https://issues.apache.org/jira/browse/OFBIZ-10351 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10351.patch, OFBIZ-10351.patch > > > Option to log a tree view of services and simple methods, and events that are > called in a request. > Some discussion at > https://lists.apache.org/thread.html/079455a596056334265ecbd410b4de13b6e61e1449ac258af5e9679b@%3Cdev.ofbiz.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10394) Fix typo "paramters" => "parameters"
[ https://issues.apache.org/jira/browse/OFBIZ-10394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10394: --- Attachment: OFBIZ-10394-Fix-typo-paramters-parameters.patch > Fix typo "paramters" => "parameters" > > > Key: OFBIZ-10394 > URL: https://issues.apache.org/jira/browse/OFBIZ-10394 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Priority: Major > Attachments: OFBIZ-10394-Fix-typo-paramters-parameters.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10394) Fix typo "paramters" => "parameters"
[ https://issues.apache.org/jira/browse/OFBIZ-10394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10394: --- Priority: Minor (was: Major) > Fix typo "paramters" => "parameters" > > > Key: OFBIZ-10394 > URL: https://issues.apache.org/jira/browse/OFBIZ-10394 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Priority: Minor > Attachments: OFBIZ-10394-Fix-typo-paramters-parameters.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10393) Remove `createContent` Java service implementation
Mathieu Lirzin created OFBIZ-10393: -- Summary: Remove `createContent` Java service implementation Key: OFBIZ-10393 URL: https://issues.apache.org/jira/browse/OFBIZ-10393 Project: OFBiz Issue Type: Improvement Components: content Reporter: Mathieu Lirzin The `createContent` service has been replaced by a minilang implementation since 2007 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10393) Remove `createContent` Java service implementation
[ https://issues.apache.org/jira/browse/OFBIZ-10393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10393: --- Attachment: OFBIZ-10393-improved-Remove-createContent-Java-service-implement.patch > Remove `createContent` Java service implementation > -- > > Key: OFBIZ-10393 > URL: https://issues.apache.org/jira/browse/OFBIZ-10393 > Project: OFBiz > Issue Type: Improvement > Components: content >Reporter: Mathieu Lirzin >Priority: Trivial > Attachments: > OFBIZ-10393-improved-Remove-createContent-Java-service-implement.patch > > > The `createContent` service has been replaced by a minilang implementation > since 2007 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10394) Fix typo "paramters" => "parameters"
Mathieu Lirzin created OFBIZ-10394: -- Summary: Fix typo "paramters" => "parameters" Key: OFBIZ-10394 URL: https://issues.apache.org/jira/browse/OFBIZ-10394 Project: OFBiz Issue Type: Bug Components: content Affects Versions: Trunk Reporter: Mathieu Lirzin -- This message was sent by Atlassian JIRA (v7.6.3#76005)
