[jira] [Commented] (OFBIZ-12060) migrated Wiki Glossary to glossary asciidoc files
[ https://issues.apache.org/jira/browse/OFBIZ-12060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234813#comment-17234813 ] ASF subversion and git services commented on OFBIZ-12060: - Commit c2c1eae612932fe54f9dbc3040c108f21e920c41 in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=c2c1eae ] Documented: migrated Wiki Glossary to glossary asciidoc files (OFBIZ-12060) - Accounting Glossary, - declare it as glossary - re-order existing items - add a comment at beginning about importance of order items - correction for some ID: change space to _ - add some items coming from wiki glossary - Facility - add glossary directly in facility.adoc - Human Resource Glossary - re-order existing items - add a comment at beginning about importance of order items - move some items to Party Glossary or global Glossary - HR appendix: add link to wiki OFBiz related book for Data Model Reference Book - Add Party Glossary and included it in party.adoc - add some items coming from wiki glossary and HR glossary - General Glossary - add a comment at beginning about importance of order items - add some items coming from wiki glossary and HR glossary > migrated Wiki Glossary to glossary asciidoc files > - > > Key: OFBIZ-12060 > URL: https://issues.apache.org/jira/browse/OFBIZ-12060 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Olivier Heintz >Assignee: Olivier Heintz >Priority: Major > Labels: Documentation > > Put in Glossary asciidoc files, GeneralGlossary or glossary per component all > wiki glossary entries. > Each time a entry is put in a asciidoc file, update wiki to replace text by a > link to the glossary entry (in html generated manual) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11036) User Manual : change the level of from 2 to 1
[ https://issues.apache.org/jira/browse/OFBIZ-11036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234814#comment-17234814 ] ASF subversion and git services commented on OFBIZ-11036: - Commit 1ddf7f5a41dfaada3e189953a99d77a41100a21a in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=1ddf7f5 ] Documented: User Manual : change the level of from 2 to 1 (OFBIZ-11036) > User Manual : change the level of from 2 to 1 > -- > > Key: OFBIZ-11036 > URL: https://issues.apache.org/jira/browse/OFBIZ-11036 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Olivier Heintz >Assignee: Kaustubh Choudhary >Priority: Minor > Labels: Documentation > Attachments: > 0001-Documented-User-Manual-change-the-level-of-Core-Busi.patch > > > If is on level 1, it become a main separator in > TOC not a chapter > TOC become > {code:java} > ... > 2. Quick start > Core Business Applications > 3. Accounting > 4. Human Resources > {code} > and so we have one more level (in TOC) for each application -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12060) migrated Wiki Glossary to glossary asciidoc files
[ https://issues.apache.org/jira/browse/OFBIZ-12060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234798#comment-17234798 ] ASF subversion and git services commented on OFBIZ-12060: - Commit c2c1eae612932fe54f9dbc3040c108f21e920c41 in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=c2c1eae ] Documented: migrated Wiki Glossary to glossary asciidoc files (OFBIZ-12060) - Accounting Glossary, - declare it as glossary - re-order existing items - add a comment at beginning about importance of order items - correction for some ID: change space to _ - add some items coming from wiki glossary - Facility - add glossary directly in facility.adoc - Human Resource Glossary - re-order existing items - add a comment at beginning about importance of order items - move some items to Party Glossary or global Glossary - HR appendix: add link to wiki OFBiz related book for Data Model Reference Book - Add Party Glossary and included it in party.adoc - add some items coming from wiki glossary and HR glossary - General Glossary - add a comment at beginning about importance of order items - add some items coming from wiki glossary and HR glossary > migrated Wiki Glossary to glossary asciidoc files > - > > Key: OFBIZ-12060 > URL: https://issues.apache.org/jira/browse/OFBIZ-12060 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Olivier Heintz >Assignee: Olivier Heintz >Priority: Major > Labels: Documentation > > Put in Glossary asciidoc files, GeneralGlossary or glossary per component all > wiki glossary entries. > Each time a entry is put in a asciidoc file, update wiki to replace text by a > link to the glossary entry (in html generated manual) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12060) migrated Wiki Glossary to glossary asciidoc files
[ https://issues.apache.org/jira/browse/OFBIZ-12060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234784#comment-17234784 ] ASF subversion and git services commented on OFBIZ-12060: - Commit c2c1eae612932fe54f9dbc3040c108f21e920c41 in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=c2c1eae ] Documented: migrated Wiki Glossary to glossary asciidoc files (OFBIZ-12060) - Accounting Glossary, - declare it as glossary - re-order existing items - add a comment at beginning about importance of order items - correction for some ID: change space to _ - add some items coming from wiki glossary - Facility - add glossary directly in facility.adoc - Human Resource Glossary - re-order existing items - add a comment at beginning about importance of order items - move some items to Party Glossary or global Glossary - HR appendix: add link to wiki OFBiz related book for Data Model Reference Book - Add Party Glossary and included it in party.adoc - add some items coming from wiki glossary and HR glossary - General Glossary - add a comment at beginning about importance of order items - add some items coming from wiki glossary and HR glossary > migrated Wiki Glossary to glossary asciidoc files > - > > Key: OFBIZ-12060 > URL: https://issues.apache.org/jira/browse/OFBIZ-12060 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Olivier Heintz >Assignee: Olivier Heintz >Priority: Major > Labels: Documentation > > Put in Glossary asciidoc files, GeneralGlossary or glossary per component all > wiki glossary entries. > Each time a entry is put in a asciidoc file, update wiki to replace text by a > link to the glossary entry (in html generated manual) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11036) User Manual : change the level of from 2 to 1
[ https://issues.apache.org/jira/browse/OFBIZ-11036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234799#comment-17234799 ] ASF subversion and git services commented on OFBIZ-11036: - Commit 1ddf7f5a41dfaada3e189953a99d77a41100a21a in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=1ddf7f5 ] Documented: User Manual : change the level of from 2 to 1 (OFBIZ-11036) > User Manual : change the level of from 2 to 1 > -- > > Key: OFBIZ-11036 > URL: https://issues.apache.org/jira/browse/OFBIZ-11036 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Olivier Heintz >Assignee: Kaustubh Choudhary >Priority: Minor > Labels: Documentation > Attachments: > 0001-Documented-User-Manual-change-the-level-of-Core-Busi.patch > > > If is on level 1, it become a main separator in > TOC not a chapter > TOC become > {code:java} > ... > 2. Quick start > Core Business Applications > 3. Accounting > 4. Human Resources > {code} > and so we have one more level (in TOC) for each application -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-12060) migrated Wiki Glossary to glossary asciidoc files
[ https://issues.apache.org/jira/browse/OFBIZ-12060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Heintz closed OFBIZ-12060. -- Resolution: Fixed > migrated Wiki Glossary to glossary asciidoc files > - > > Key: OFBIZ-12060 > URL: https://issues.apache.org/jira/browse/OFBIZ-12060 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Olivier Heintz >Assignee: Olivier Heintz >Priority: Major > Labels: Documentation > > Put in Glossary asciidoc files, GeneralGlossary or glossary per component all > wiki glossary entries. > Each time a entry is put in a asciidoc file, update wiki to replace text by a > link to the glossary entry (in html generated manual) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11036) User Manual : change the level of from 2 to 1
[ https://issues.apache.org/jira/browse/OFBIZ-11036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Heintz closed OFBIZ-11036. -- Resolution: Fixed > User Manual : change the level of from 2 to 1 > -- > > Key: OFBIZ-11036 > URL: https://issues.apache.org/jira/browse/OFBIZ-11036 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Olivier Heintz >Assignee: Kaustubh Choudhary >Priority: Minor > Labels: Documentation > Attachments: > 0001-Documented-User-Manual-change-the-level-of-Core-Busi.patch > > > If is on level 1, it become a main separator in > TOC not a chapter > TOC become > {code:java} > ... > 2. Quick start > Core Business Applications > 3. Accounting > 4. Human Resources > {code} > and so we have one more level (in TOC) for each application -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12061) Comment out HideUtilityClassConstructor in checkstyle.xml
Jacques Le Roux created OFBIZ-12061: --- Summary: Comment out HideUtilityClassConstructor in checkstyle.xml Key: OFBIZ-12061 URL: https://issues.apache.org/jira/browse/OFBIZ-12061 Project: OFBiz Issue Type: Improvement Reporter: Jacques Le Roux Currently Checkstyle returns 222 occurrences of the message "Utility classes should not have a public or default constructor." This is due to https://checkstyle.sourceforge.io/config_design.html#HideUtilityClassConstructor I don't think we need to follow the "prevents calls from subclass" suggestion there. I rather suggest to comment out the related class in checkstyle.xml: bq. ie Then should remain only 280 errors and hopefully most will be easy to fix. At least they will be easier to spot... -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12061) Comment out HideUtilityClassConstructor in checkstyle.xml
[ https://issues.apache.org/jira/browse/OFBIZ-12061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234772#comment-17234772 ] ASF subversion and git services commented on OFBIZ-12061: - Commit 2480c52c6ac2b0498bc7a958c2a8dcbd4c8afbd9 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=2480c52 ] Improved: Comment out HideUtilityClassConstructor in checkstyle.xml (OFBIZ-12061) Currently Checkstyle returns 222 occurrences of the message "Utility classes should not have a public or default constructor." This is due to https://checkstyle.sourceforge.io/config_design.html#HideUtilityClassConstructor I don't think we need to follow the "prevents calls from subclass" suggestion there. I rather suggest to comment out the related class in checkstyle.xml: ie Then should remain only 280 errors and hopefully most will be easy to fix. At least they will be easier to spot... Note: I'm working on something else, so I will change tasks.checkstyleMain.maxErrors from 502 to 280 later... Thanks: Suraj and Aditya for confirmation > Comment out HideUtilityClassConstructor in checkstyle.xml > - > > Key: OFBIZ-12061 > URL: https://issues.apache.org/jira/browse/OFBIZ-12061 > Project: OFBiz > Issue Type: Improvement >Reporter: Jacques Le Roux >Priority: Major > > Currently Checkstyle returns 222 occurrences of the message "Utility classes > should not have a public or default constructor." > This is due to > https://checkstyle.sourceforge.io/config_design.html#HideUtilityClassConstructor > I don't think we need to follow the "prevents calls from subclass" suggestion > there. > I rather suggest to comment out the related class in checkstyle.xml: > bq. ie > Then should remain only 280 errors and hopefully most will be easy to fix. At > least they will be easier to spot... -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #238: Spanish translations added
JacquesLeRoux commented on pull request #238: URL: https://github.com/apache/ofbiz-framework/pull/238#issuecomment-729782485 Thanks Zottacko WallyMan, Your PR is in at https://github.com/apache/ofbiz-framework/commit/17de4f6e0780c842b5e2114137015afeada0c56d/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (OFBIZ-12061) Comment out HideUtilityClassConstructor in checkstyle.xml
[ https://issues.apache.org/jira/browse/OFBIZ-12061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-12061: --- Assignee: Jacques Le Roux > Comment out HideUtilityClassConstructor in checkstyle.xml > - > > Key: OFBIZ-12061 > URL: https://issues.apache.org/jira/browse/OFBIZ-12061 > Project: OFBiz > Issue Type: Improvement >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > > Currently Checkstyle returns 222 occurrences of the message "Utility classes > should not have a public or default constructor." > This is due to > https://checkstyle.sourceforge.io/config_design.html#HideUtilityClassConstructor > I don't think we need to follow the "prevents calls from subclass" suggestion > there. > I rather suggest to comment out the related class in checkstyle.xml: > bq. ie > Then should remain only 280 errors and hopefully most will be easy to fix. At > least they will be easier to spot... -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #238: Spanish translations added
JacquesLeRoux commented on pull request #238: URL: https://github.com/apache/ofbiz-framework/pull/238#issuecomment-729923542 I had to remove your changes in ServiceDemoData.xml due to an error with MX_FED_HOLIDAYS LoadAll was failing: https://ci.apache.org/builders/ofbizTrunkFramework/builds/1970/steps/loadAll/logs/stdio Please fix it, TIA This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org