[jira] [Created] (OFBIZ-9262) Error message when svn updating due to pullAllPluginsSource
Jacques Le Roux created OFBIZ-9262: -- Summary: Error message when svn updating due to pullAllPluginsSource Key: OFBIZ-9262 URL: https://issues.apache.org/jira/browse/OFBIZ-9262 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux Priority: Critical Fix For: Upcoming Release When try to update a ofbiz-framework working copy after having used pullAllPluginsSource, you get an error message "Skipped obstructing working copy". This is because we have already a plugins folder in the ofbiz-framework/trunk branch and when we use pullAllPluginsSource we replace it by a new one (plugins folder) and the main .svn gets confused (in root) In other words, because of the plugins/README.txt file when you create a working copy from the ofbiz-framework/trunk branch you generate a .svn in root folder where there is a "knowledge" of this file and the plugins directory. So, we can't delete the whole plugins directory and replace it by another different plugins directory with the plugins sub-folders inside. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9262) Error message when svn updating due to pullAllPluginsSource
[ https://issues.apache.org/jira/browse/OFBIZ-9262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926296#comment-15926296 ] Jacques Le Roux commented on OFBIZ-9262: I continue with another idea.. > Error message when svn updating due to pullAllPluginsSource > --- > > Key: OFBIZ-9262 > URL: https://issues.apache.org/jira/browse/OFBIZ-9262 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Critical > Fix For: Upcoming Release > > > When try to update a ofbiz-framework working copy after having used > pullAllPluginsSource, you get an error message "Skipped obstructing working > copy". > This is because we have already a plugins folder in the ofbiz-framework/trunk > branch and when we use pullAllPluginsSource we replace it by a new one > (plugins folder) and the main .svn gets confused (in root) > In other words, because of the plugins/README.txt file when you create a > working copy from the ofbiz-framework/trunk branch you generate a .svn in > root folder where there is a "knowledge" of this file and the plugins > directory. > So, we can't delete the whole plugins directory and replace it by another > different plugins directory with the plugins sub-folders inside. > Morevoer you can't make a chekout (which pullAllPluginsSource currently does) > in a non empty folder. > And If you temporarily move the plugins/README.txt file to get an empty > directory you get this error message > > svn-checkout failed for > > https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk > svn: E155000: 'C:\projectsASF\ofbiz-framework\plugins' is already a working > copy for a different URL; perform update to complete it. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OFBIZ-9262) Error message when svn updating due to pullAllPluginsSource
[ https://issues.apache.org/jira/browse/OFBIZ-9262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-9262: --- Description: When try to update a ofbiz-framework working copy after having used pullAllPluginsSource, you get an error message "Skipped obstructing working copy". This is because we have already a plugins folder in the ofbiz-framework/trunk branch and when we use pullAllPluginsSource we replace it by a new one (plugins folder) and the main .svn gets confused (in root) In other words, because of the plugins/README.txt file when you create a working copy from the ofbiz-framework/trunk branch you generate a .svn in root folder where there is a "knowledge" of this file and the plugins directory. So, we can't delete the whole plugins directory and replace it by another different plugins directory with the plugins sub-folders inside. Morevoer you can't make a chekout (which pullAllPluginsSource currently does) in a non empty folder. And If you temporarily move the plugins/README.txt file to get an empty directory you get this error message > svn-checkout failed for > https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk svn: E155000: 'C:\projectsASF\ofbiz-framework\plugins' is already a working copy for a different URL; perform update to complete it. was: When try to update a ofbiz-framework working copy after having used pullAllPluginsSource, you get an error message "Skipped obstructing working copy". This is because we have already a plugins folder in the ofbiz-framework/trunk branch and when we use pullAllPluginsSource we replace it by a new one (plugins folder) and the main .svn gets confused (in root) In other words, because of the plugins/README.txt file when you create a working copy from the ofbiz-framework/trunk branch you generate a .svn in root folder where there is a "knowledge" of this file and the plugins directory. So, we can't delete the whole plugins directory and replace it by another different plugins directory with the plugins sub-folders inside. > Error message when svn updating due to pullAllPluginsSource > --- > > Key: OFBIZ-9262 > URL: https://issues.apache.org/jira/browse/OFBIZ-9262 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Critical > Fix For: Upcoming Release > > > When try to update a ofbiz-framework working copy after having used > pullAllPluginsSource, you get an error message "Skipped obstructing working > copy". > This is because we have already a plugins folder in the ofbiz-framework/trunk > branch and when we use pullAllPluginsSource we replace it by a new one > (plugins folder) and the main .svn gets confused (in root) > In other words, because of the plugins/README.txt file when you create a > working copy from the ofbiz-framework/trunk branch you generate a .svn in > root folder where there is a "knowledge" of this file and the plugins > directory. > So, we can't delete the whole plugins directory and replace it by another > different plugins directory with the plugins sub-folders inside. > Morevoer you can't make a chekout (which pullAllPluginsSource currently does) > in a non empty folder. > And If you temporarily move the plugins/README.txt file to get an empty > directory you get this error message > > svn-checkout failed for > > https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk > svn: E155000: 'C:\projectsASF\ofbiz-framework\plugins' is already a working > copy for a different URL; perform update to complete it. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9264) Make sure the local date time uses the time zone from the local browser.
[ https://issues.apache.org/jira/browse/OFBIZ-9264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927691#comment-15927691 ] Jacques Le Roux commented on OFBIZ-9264: Thanks Francis, I'll double check, and if nobody oppose I'll commit > Make sure the local date time uses the time zone from the local browser. > > > Key: OFBIZ-9264 > URL: https://issues.apache.org/jira/browse/OFBIZ-9264 > Project: OFBiz > Issue Type: New Feature >Affects Versions: Trunk >Reporter: Francis Douet >Priority: Minor > Labels: timezone > Attachments: OFBIZ-9264.diff > > > This feature was requested by one of our clients, it sets the time zone of > the user logged in to it's browser time zone. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9262) Error message when svn updating due to pullAllPluginsSource
[ https://issues.apache.org/jira/browse/OFBIZ-9262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927689#comment-15927689 ] Jacques Le Roux commented on OFBIZ-9262: plugins dir removed at r1787143 Taher's patch committed at r1787144 I'll continue with the documentation > Error message when svn updating due to pullAllPluginsSource > --- > > Key: OFBIZ-9262 > URL: https://issues.apache.org/jira/browse/OFBIZ-9262 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Critical > Fix For: Upcoming Release > > Attachments: OFBIZ-9262.patch > > > When try to update a ofbiz-framework working copy after having used > pullAllPluginsSource, you get an error message "Skipped obstructing working > copy". > This is because we have already a plugins folder in the ofbiz-framework/trunk > branch and when we use pullAllPluginsSource we replace it by a new one > (plugins folder) and the main .svn gets confused (in root) > In other words, because of the plugins/README.txt file when you create a > working copy from the ofbiz-framework/trunk branch you generate a .svn in > root folder where there is a "knowledge" of this file and the plugins > directory. > So, we can't delete the whole plugins directory and replace it by another > different plugins directory with the plugins sub-folders inside. > Morevoer you can't make a chekout (which pullAllPluginsSource currently does) > in a non empty folder. > And If you temporarily move the plugins/README.txt file to get an empty > directory you get this error message > > svn-checkout failed for > > https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk > svn: E155000: 'C:\projectsASF\ofbiz-framework\plugins' is already a working > copy for a different URL; perform update to complete it. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Comment Edited] (OFBIZ-8290) Disentangle unused Accounting labels
[ https://issues.apache.org/jira/browse/OFBIZ-8290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927577#comment-15927577 ] Jacques Le Roux edited comment on OFBIZ-8290 at 3/16/17 9:06 AM: - Thanks Pierre, Your patch is in trunk at revision: 1787132 Because of OFBIZ-8154 being unfinished (but mostly done), I all checked them by hand. So I'm sure they are really unused Note: Remains 304 unused Accounting labels (yes it's trivial, but it's major and tedious, some would say menial, work). So I don't close this issue Finally, I really wonder why all these labels have been created and are now not used, which worries me a bit. was (Author: jacques.le.roux): Thanks Pierre, Your patch is in trunk at revision: 1787132 Because of OFBIZ-8154 being unfinished (but mostly done), I all checked them by hand. So I'm sure they are really unused Note: Remains 304 unused Accounting labels (yes it's trivial, but it's major and tedious, some would say lenial, work). So I don't close this issue Finally, I really wonder why all these labels have been created and are now not used, which worries me a bit. > Disentangle unused Accounting labels > > > Key: OFBIZ-8290 > URL: https://issues.apache.org/jira/browse/OFBIZ-8290 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Trivial > Labels: labels, refactoring > Attachments: OFBIZ-8290-AccountingUiLabels.xml.patch > > > Disentanglement of unused labels from the accounting component makes the > component better. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9247) Refactor list related forms in Marketing widgets
[ https://issues.apache.org/jira/browse/OFBIZ-9247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927687#comment-15927687 ] Jacques Le Roux commented on OFBIZ-9247: Thanks Pierre That makes more sense than my own vision. I'll also stick to it, KISS way! > Refactor list related forms in Marketing widgets > > > Key: OFBIZ-9247 > URL: https://issues.apache.org/jira/browse/OFBIZ-9247 > Project: OFBiz > Issue Type: Improvement > Components: marketing >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits > Fix For: Trunk > > Attachments: OFBIZ-9247-Marketing-widget.patch > > > Refactor various lists forms into grids > Refactor various list form references in screen widgets -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9247) Refactor list related forms in Marketing widgets
[ https://issues.apache.org/jira/browse/OFBIZ-9247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927620#comment-15927620 ] Jacques Le Roux commented on OFBIZ-9247: Ha also Pierre, Could you clearly explain why you assign issues to yourself, when I see more the commit responsible assigned, please answer. > Refactor list related forms in Marketing widgets > > > Key: OFBIZ-9247 > URL: https://issues.apache.org/jira/browse/OFBIZ-9247 > Project: OFBiz > Issue Type: Improvement > Components: marketing >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits > Fix For: Trunk > > Attachments: OFBIZ-9247-Marketing-widget.patch > > > Refactor various lists forms into grids > Refactor various list form references in screen widgets -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9262) Error message when svn updating due to pullAllPluginsSource
[ https://issues.apache.org/jira/browse/OFBIZ-9262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927667#comment-15927667 ] Jacques Le Roux commented on OFBIZ-9262: Thanks Deepak, That's what I thought, better not add ignore. It concerns only committers, if a committer want to add a new component, etc. it will be easier. I'll proceed now and will begin by documenting the change in the main README.md and source repositories page. Any ideas about documenting this better? > Error message when svn updating due to pullAllPluginsSource > --- > > Key: OFBIZ-9262 > URL: https://issues.apache.org/jira/browse/OFBIZ-9262 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Critical > Fix For: Upcoming Release > > Attachments: OFBIZ-9262.patch > > > When try to update a ofbiz-framework working copy after having used > pullAllPluginsSource, you get an error message "Skipped obstructing working > copy". > This is because we have already a plugins folder in the ofbiz-framework/trunk > branch and when we use pullAllPluginsSource we replace it by a new one > (plugins folder) and the main .svn gets confused (in root) > In other words, because of the plugins/README.txt file when you create a > working copy from the ofbiz-framework/trunk branch you generate a .svn in > root folder where there is a "knowledge" of this file and the plugins > directory. > So, we can't delete the whole plugins directory and replace it by another > different plugins directory with the plugins sub-folders inside. > Morevoer you can't make a chekout (which pullAllPluginsSource currently does) > in a non empty folder. > And If you temporarily move the plugins/README.txt file to get an empty > directory you get this error message > > svn-checkout failed for > > https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk > svn: E155000: 'C:\projectsASF\ofbiz-framework\plugins' is already a working > copy for a different URL; perform update to complete it. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-7473) Induce Model XML from Database throws exception
[
https://issues.apache.org/jira/browse/OFBIZ-7473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15931155#comment-15931155
]
Jacques Le Roux commented on OFBIZ-7473:
view/checkdb works
But I noticed that, among these old JSP stuff, it's the only one and we have
also this block commented out by Jacopo since 2007:
{code}
<#-- want to leave these out because they are only working so-so, and
cause people more problems that they solve, IMHO
Edit Entity Definitions
Generate Entity Model XML (all in one)
Save Entity Model XML to Files
-->
<#-- not working right now anyway
Generate Entity Group XML
Save Entity Group XML to File
-->
<#--
MySQL Table
Creation SQL
MySQL Auto Data
SQL
-->
{code}
But view/ModelInduceFromDb is more annoying
> Induce Model XML from Database throws exception
> ---
>
> Key: OFBIZ-7473
> URL: https://issues.apache.org/jira/browse/OFBIZ-7473
> Project: OFBiz
> Issue Type: Bug
> Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Gopal Yadav
>Assignee: Jacques Le Roux
> Fix For: Upcoming Release, 16.11.02
>
> Attachments: OFBIZ-7473.patch
>
>
> Go to Webtools -> Import/Export -> Induce Model XML from Database
> (https://localhost:8443/webtools/control/view/ModelInduceFromDb)
> An exception is thrown: javax.servlet.ServletException: File
> [/entity/ModelInduceFromDb.jsp] not found.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OFBIZ-9190) Ugrade FishEye references
[ https://issues.apache.org/jira/browse/OFBIZ-9190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15931162#comment-15931162 ] Jacques Le Roux commented on OFBIZ-9190: BTW, we have now Fisheye links to commits in Jira. But it does not completely works in FF (and IIRW in Chrome) because it does not accept applets and this uses them. I saw things in IE. > Ugrade FishEye references > - > > Key: OFBIZ-9190 > URL: https://issues.apache.org/jira/browse/OFBIZ-9190 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS, site >Reporter: Pierre Smits > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (OFBIZ-7473) Induce Model XML from Database throws exception
[ https://issues.apache.org/jira/browse/OFBIZ-7473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-7473: -- Assignee: Jacques Le Roux > Induce Model XML from Database throws exception > --- > > Key: OFBIZ-7473 > URL: https://issues.apache.org/jira/browse/OFBIZ-7473 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: Trunk >Reporter: Gopal Yadav >Assignee: Jacques Le Roux > Attachments: OFBIZ-7473.patch > > > Go to Webtools -> Import/Export -> Induce Model XML from Database > (https://localhost:8443/webtools/control/view/ModelInduceFromDb) > An exception is thrown: javax.servlet.ServletException: File > [/entity/ModelInduceFromDb.jsp] not found. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (OFBIZ-7473) Induce Model XML from Database throws exception
[ https://issues.apache.org/jira/browse/OFBIZ-7473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-7473. -- Resolution: Fixed Fix Version/s: 16.11.02 Upcoming Release Actually after moving FTL templates to the template sub-dir we forgot links in the ctrlr. Changing the ctrlr is the best way. Fixed in trunk r1787535 R16.11 r1787536 > Induce Model XML from Database throws exception > --- > > Key: OFBIZ-7473 > URL: https://issues.apache.org/jira/browse/OFBIZ-7473 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: Trunk >Reporter: Gopal Yadav >Assignee: Jacques Le Roux > Fix For: Upcoming Release, 16.11.02 > > Attachments: OFBIZ-7473.patch > > > Go to Webtools -> Import/Export -> Induce Model XML from Database > (https://localhost:8443/webtools/control/view/ModelInduceFromDb) > An exception is thrown: javax.servlet.ServletException: File > [/entity/ModelInduceFromDb.jsp] not found. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-7473) Induce Model XML from Database throws exception
[ https://issues.apache.org/jira/browse/OFBIZ-7473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15931137#comment-15931137 ] Jacques Le Roux commented on OFBIZ-7473: Thanks for the report Gopal. Yes you are right William we must do a svn move rather than a delete+add to not lose svn history > Induce Model XML from Database throws exception > --- > > Key: OFBIZ-7473 > URL: https://issues.apache.org/jira/browse/OFBIZ-7473 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: Trunk >Reporter: Gopal Yadav >Assignee: Jacques Le Roux > Attachments: OFBIZ-7473.patch > > > Go to Webtools -> Import/Export -> Induce Model XML from Database > (https://localhost:8443/webtools/control/view/ModelInduceFromDb) > An exception is thrown: javax.servlet.ServletException: File > [/entity/ModelInduceFromDb.jsp] not found. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Reopened] (OFBIZ-7473) Induce Model XML from Database throws exception
[ https://issues.apache.org/jira/browse/OFBIZ-7473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-7473: > Induce Model XML from Database throws exception > --- > > Key: OFBIZ-7473 > URL: https://issues.apache.org/jira/browse/OFBIZ-7473 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: Trunk >Reporter: Gopal Yadav >Assignee: Jacques Le Roux > Fix For: Upcoming Release, 16.11.02 > > Attachments: OFBIZ-7473.patch > > > Go to Webtools -> Import/Export -> Induce Model XML from Database > (https://localhost:8443/webtools/control/view/ModelInduceFromDb) > An exception is thrown: javax.servlet.ServletException: File > [/entity/ModelInduceFromDb.jsp] not found. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-7473) Induce Model XML from Database throws exception
[ https://issues.apache.org/jira/browse/OFBIZ-7473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15931141#comment-15931141 ] Jacques Le Roux commented on OFBIZ-7473: Ooops, got a StackOverflowError with trunk, checking why... > Induce Model XML from Database throws exception > --- > > Key: OFBIZ-7473 > URL: https://issues.apache.org/jira/browse/OFBIZ-7473 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: Trunk >Reporter: Gopal Yadav >Assignee: Jacques Le Roux > Fix For: Upcoming Release, 16.11.02 > > Attachments: OFBIZ-7473.patch > > > Go to Webtools -> Import/Export -> Induce Model XML from Database > (https://localhost:8443/webtools/control/view/ModelInduceFromDb) > An exception is thrown: javax.servlet.ServletException: File > [/entity/ModelInduceFromDb.jsp] not found. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-7473) Induce Model XML from Database throws exception
[ https://issues.apache.org/jira/browse/OFBIZ-7473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15931144#comment-15931144 ] Jacques Le Roux commented on OFBIZ-7473: OK found it: Could not initialize class org.apache.ofbiz.base.util.UtilCodec. Let's see... > Induce Model XML from Database throws exception > --- > > Key: OFBIZ-7473 > URL: https://issues.apache.org/jira/browse/OFBIZ-7473 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: Trunk >Reporter: Gopal Yadav >Assignee: Jacques Le Roux > Fix For: Upcoming Release, 16.11.02 > > Attachments: OFBIZ-7473.patch > > > Go to Webtools -> Import/Export -> Induce Model XML from Database > (https://localhost:8443/webtools/control/view/ModelInduceFromDb) > An exception is thrown: javax.servlet.ServletException: File > [/entity/ModelInduceFromDb.jsp] not found. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-7473) Induce Model XML from Database throws exception
[
https://issues.apache.org/jira/browse/OFBIZ-7473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15931146#comment-15931146
]
Jacques Le Roux commented on OFBIZ-7473:
No it's really a StackOverflowError
The error above is due to this line in
org.apache.ofbiz.webapp.control.ControlServlet.doGet()
bq. request.setAttribute("_ERROR_MESSAGE_",
UtilCodec.getEncoder("html").encode(throwable.toString()));
I have yet no ideas about the StackOverflowError :/
> Induce Model XML from Database throws exception
> ---
>
> Key: OFBIZ-7473
> URL: https://issues.apache.org/jira/browse/OFBIZ-7473
> Project: OFBiz
> Issue Type: Bug
> Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Gopal Yadav
>Assignee: Jacques Le Roux
> Fix For: Upcoming Release, 16.11.02
>
> Attachments: OFBIZ-7473.patch
>
>
> Go to Webtools -> Import/Export -> Induce Model XML from Database
> (https://localhost:8443/webtools/control/view/ModelInduceFromDb)
> An exception is thrown: javax.servlet.ServletException: File
> [/entity/ModelInduceFromDb.jsp] not found.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Closed] (OFBIZ-9272) Update OFBiz Buildbot config after the pullAllPluginsSource Gradle task creation
[ https://issues.apache.org/jira/browse/OFBIZ-9272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-9272. -- Resolution: Done Done, all works as expected. I'm even surprised that tests pass, but that's good anyway > Update OFBiz Buildbot config after the pullAllPluginsSource Gradle task > creation > > > Key: OFBIZ-9272 > URL: https://issues.apache.org/jira/browse/OFBIZ-9272 > Project: OFBiz > Issue Type: Task > Components: BuildBot >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux > Fix For: Upcoming Release > > > * Add a new build *ofbiz-trunk-framework + plugins* which run tests . Only > tests, the framework and plugins are now separated products. > * Change the *ofbiz-trunk-framework* build. No separated tests, they still > depends on plugins. Only build and snapshot archive creation. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (OFBIZ-9272) Update OFBiz Buildbot config after the pullAllPluginsSource Gradle task creation
Jacques Le Roux created OFBIZ-9272: -- Summary: Update OFBiz Buildbot config after the pullAllPluginsSource Gradle task creation Key: OFBIZ-9272 URL: https://issues.apache.org/jira/browse/OFBIZ-9272 Project: OFBiz Issue Type: Task Components: BuildBot Affects Versions: Trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux Fix For: Upcoming Release * Add a new build *ofbiz-trunk-framework + plugins* which run tests . Only tests, the framework and plugins are now separated products. * Change the *ofbiz-trunk-framework* build. No separated tests, they still depends on plugins. Only build and snapshot archive creation. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (OFBIZ-9196) Regression: a commit between R15 and the Gradle switch uses/blocks the ports
[ https://issues.apache.org/jira/browse/OFBIZ-9196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-9196: -- Assignee: Jacques Le Roux > Regression: a commit between R15 and the Gradle switch uses/blocks the ports > > > Key: OFBIZ-9196 > URL: https://issues.apache.org/jira/browse/OFBIZ-9196 > Project: OFBiz > Issue Type: Bug > Components: Gradle >Affects Versions: Trunk, Release Branch 16.11 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Release, 16.11.02 > > > We got an issue on Buildbot because of a Puppet misconfiguration which was > always using the port 8080. Pre-gradle OFBiz tests were still running fine on > Buildbot. > Before the Puppet misconfiguration fix by infra (INFRA-13402), to bypass this > issue I tried last weekend to use portoffset in Gradle versions. From the > documentation, it's theoretically possible but does not work. > Taher suggested, to get back to the previous behaviour were tests were not > using/blocking the 8080 port, and to have a look into Config.java... > It's a regression because it was nice to not have ports blocked during tests, > as it was before Gradle. So you can use another (or more) OFBiz instance > while running tests, and vice-versa. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Reopened] (OFBIZ-9273) The createTenant Gradle task fails
[
https://issues.apache.org/jira/browse/OFBIZ-9273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux reopened OFBIZ-9273:
Actually no, it's related to changes I made but I can't reproduced
> The createTenant Gradle task fails
> --
>
> Key: OFBIZ-9273
> URL: https://issues.apache.org/jira/browse/OFBIZ-9273
> Project: OFBiz
> Issue Type: Bug
> Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
> Fix For: Upcoming Release
>
>
> When you enter
> bq. gradlew createTenant -PtenantId=test
> you get
> {code}
> FAILURE: Build failed with an exception.
> * Where:
> Build file 'C:\projectsASF\ofbiz-framework\build.gradle' line: 764
> * What went wrong:
> A problem occurred evaluating root project 'ofbiz'.
> > Could not get unknown property 'pluginId' for task ':installAllPlugins' of
> > type org.gradle.api.DefaultTask.
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Created] (OFBIZ-9273) The createTenant Gradle task fails
Jacques Le Roux created OFBIZ-9273:
--
Summary: The createTenant Gradle task fails
Key: OFBIZ-9273
URL: https://issues.apache.org/jira/browse/OFBIZ-9273
Project: OFBiz
Issue Type: Bug
Components: Gradle
Affects Versions: Trunk
Reporter: Jacques Le Roux
Fix For: Upcoming Release
When you enter
bq. gradlew createTenant -PtenantId=test
you get
{code}
FAILURE: Build failed with an exception.
* Where:
Build file 'C:\projectsASF\ofbiz-framework\build.gradle' line: 764
* What went wrong:
A problem occurred evaluating root project 'ofbiz'.
> Could not get unknown property 'pluginId' for task ':installAllPlugins' of
> type org.gradle.api.DefaultTask.
{code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Closed] (OFBIZ-9124) Upgrade Tomcat to 8.0.39
[ https://issues.apache.org/jira/browse/OFBIZ-9124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-9124. -- Resolution: Fixed I close this issue because it's pending for too long and we will not release R14 and R15, and R13 is at end of support. So I let interested persons handle the work by themselves, feel free to reopen and assign to yourself. > Upgrade Tomcat to 8.0.39 > > > Key: OFBIZ-9124 > URL: https://issues.apache.org/jira/browse/OFBIZ-9124 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > 16.11.01, Release Branch 15.12 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux > Labels: CVE > Fix For: Upcoming Release > > > Because of CVE-2016-6816 and CVE-2016-8735 (both are important) it's > necessary to update Tomcat to 8.0.39 ASAP -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9258) Render form values from pulled data
[
https://issues.apache.org/jira/browse/OFBIZ-9258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929643#comment-15929643
]
Jacques Le Roux commented on OFBIZ-9258:
Hi James,
Thought I did not review all details in code, I tend to agree with Nicolas.
You said:
{quote}
OFBIZ-6967: Allow form to be rendered as JSON. Not sure if it means form +
data, or data only.
OFBIZ-9258: Form, in html, can have the data pulled (ajax query) from the
server. Data are formatted as JSON.
{quote}
It seems to that OFBIZ-6967 is data only. I'll ask there to be sure. If we
commit your work we should close OFBIZ-6967 as a duplicate.
> Render form values from pulled data
> ---
>
> Key: OFBIZ-9258
> URL: https://issues.apache.org/jira/browse/OFBIZ-9258
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Upcoming Release
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Attachments: OFBIZ-9258.patch
>
>
> Currently, form data is being rendered together with the form widgets. To
> better facilitate the use of Single Page or Mobile Application in the future,
> it would be better to let the form widgets pull data from the server instead.
> An initial discussion was made at
> http://ofbiz.135035.n4.nabble.com/Render-table-rows-from-pulled-data-td4703142.html
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Closed] (OFBIZ-9262) Error message when svn updating due to pullAllPluginsSource
[ https://issues.apache.org/jira/browse/OFBIZ-9262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-9262. -- Resolution: Fixed I completed the documentation at r1787307, feel free to amend... > Error message when svn updating due to pullAllPluginsSource > --- > > Key: OFBIZ-9262 > URL: https://issues.apache.org/jira/browse/OFBIZ-9262 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Critical > Fix For: Upcoming Release > > Attachments: OFBIZ-9262.patch > > > When try to update a ofbiz-framework working copy after having used > pullAllPluginsSource, you get an error message "Skipped obstructing working > copy". > This is because we have already a plugins folder in the ofbiz-framework/trunk > branch and when we use pullAllPluginsSource we replace it by a new one > (plugins folder) and the main .svn gets confused (in root) > In other words, because of the plugins/README.txt file when you create a > working copy from the ofbiz-framework/trunk branch you generate a .svn in > root folder where there is a "knowledge" of this file and the plugins > directory. > So, we can't delete the whole plugins directory and replace it by another > different plugins directory with the plugins sub-folders inside. > Morevoer you can't make a chekout (which pullAllPluginsSource currently does) > in a non empty folder. > And If you temporarily move the plugins/README.txt file to get an empty > directory you get this error message > > svn-checkout failed for > > https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk > svn: E155000: 'C:\projectsASF\ofbiz-framework\plugins' is already a working > copy for a different URL; perform update to complete it. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (OFBIZ-9265) Error in accounting report inventory valuation with through date with an empty value.
[ https://issues.apache.org/jira/browse/OFBIZ-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-9265. -- Resolution: Fixed Fix Version/s: Release Branch 13.07 Release Branch 14.12 Release Branch 15.12 Release Branch 16.11 16.11.02 Upcoming Release Thanks Francis, Your patch is in trunk r1787176 R16.11 r1787177 R15.12 r1787178 R14.12 r1787179 R13.07 r1787180 > Error in accounting report inventory valuation with through date with an > empty value. > - > > Key: OFBIZ-9265 > URL: https://issues.apache.org/jira/browse/OFBIZ-9265 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk >Reporter: Francis Douet >Assignee: Jacques Le Roux >Priority: Minor > Labels: accounting > Fix For: Upcoming Release, 16.11.02, Release Branch 16.11, > Release Branch 15.12, Release Branch 14.12, Release Branch 13.07 > > Attachments: OFBIZ-9265.diff > > > Go to https://localhost:8443/accounting/control/InventoryValuation and clear > the Through Date, we get an error. The provided patch fixes this by setting > the default thruDate to now. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (OFBIZ-9275) Add a Gradle task to svn update all plugins
Jacques Le Roux created OFBIZ-9275:
--
Summary: Add a Gradle task to svn update all plugins
Key: OFBIZ-9275
URL: https://issues.apache.org/jira/browse/OFBIZ-9275
Project: OFBiz
Issue Type: Improvement
Components: Gradle
Affects Versions: Trunk
Reporter: Jacques Le Roux
Priority: Minor
Fix For: Upcoming Release
When you svn update the framework, unlike for svn:externals, it does not update
the plugins because it's an embedded working copy. So I have tried that w/o
success so far:
{code}
Index: build.gradle
===
--- build.gradle(revision 1788020)
+++ build.gradle(working copy)
@@ -17,6 +17,7 @@
* under the License.
*/
import at.bxm.gradleplugins.svntools.tasks.SvnCheckout
+import at.bxm.gradleplugins.svntools.tasks.SvnUpdate
import org.apache.tools.ant.filters.ReplaceTokens
/*
@@ -774,6 +775,14 @@
}
}
+task updateAllPluginsSource(group: ofbizPlugin,
+description: 'Update all plugins from source control.') {
+
+task updatePluginsFromSvn(type: SvnUpdate) {
+workspaceDir = "${pluginsDir}"
+}
+}
+
// == Clean up tasks ==
task cleanCatalina(group: cleanupGroup, description: 'Clean Catalina data in
runtime/catalina/work') {
doLast { delete "${rootDir}/runtime/catalina/work" }
{code}
The doc is here
https://github.com/martoe/gradle-svntools-plugin/blob/master/docs/SvnUpdate.md
https://github.com/martoe/gradle-svntools-plugin/blob/master/src/main/groovy/at/bxm/gradleplugins/svntools/tasks/SvnUpdate.groovy
BTW somehow related there is no Gradle svn plugin way to get the status. So you
have to move to the plugins directory. A bit tedious, I propose a
pluginsStatus.bat script for that (could be in tools but I'll move it in
another branch)
{code}
@echo off
cd plugins
svn st
cd ..
{code}
If we agree I can add the same .sh
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (OFBIZ-9275) Add a Gradle task to svn update all plugins
[
https://issues.apache.org/jira/browse/OFBIZ-9275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-9275:
---
Description:
When you svn update the framework, unlike for svn:externals, it does not update
the plugins because it's an embedded working copy. So I have tried that w/o
success so far:
{code}
Index: build.gradle
===
--- build.gradle(revision 1788020)
+++ build.gradle(working copy)
@@ -17,6 +17,7 @@
* under the License.
*/
import at.bxm.gradleplugins.svntools.tasks.SvnCheckout
+import at.bxm.gradleplugins.svntools.tasks.SvnUpdate
import org.apache.tools.ant.filters.ReplaceTokens
/*
@@ -774,6 +775,14 @@
}
}
+task updateAllPluginsSource(group: ofbizPlugin,
+description: 'Update all plugins from source control.') {
+
+task updatePluginsFromSvn(type: SvnUpdate) {
+workspaceDir = "${pluginsDir}"
+}
+}
+
// == Clean up tasks ==
task cleanCatalina(group: cleanupGroup, description: 'Clean Catalina data in
runtime/catalina/work') {
doLast { delete "${rootDir}/runtime/catalina/work" }
{code}
The doc is here
https://github.com/martoe/gradle-svntools-plugin/blob/master/docs/SvnUpdate.md
https://github.com/martoe/gradle-svntools-plugin/blob/master/src/main/groovy/at/bxm/gradleplugins/svntools/tasks/SvnUpdate.groovy
BTW somehow related there is no Gradle svn plugin way to get the status. So you
have to move to the plugins directory. A bit tedious, I propose a
pluginsStatus.bat script for that (could be in tools but I'll move it in
another branch)
{code}
@echo off
cd plugins
svn st
cd ..
{code}
If we agree I can add the same pluginsStatus.sh
was:
When you svn update the framework, unlike for svn:externals, it does not update
the plugins because it's an embedded working copy. So I have tried that w/o
success so far:
{code}
Index: build.gradle
===
--- build.gradle(revision 1788020)
+++ build.gradle(working copy)
@@ -17,6 +17,7 @@
* under the License.
*/
import at.bxm.gradleplugins.svntools.tasks.SvnCheckout
+import at.bxm.gradleplugins.svntools.tasks.SvnUpdate
import org.apache.tools.ant.filters.ReplaceTokens
/*
@@ -774,6 +775,14 @@
}
}
+task updateAllPluginsSource(group: ofbizPlugin,
+description: 'Update all plugins from source control.') {
+
+task updatePluginsFromSvn(type: SvnUpdate) {
+workspaceDir = "${pluginsDir}"
+}
+}
+
// == Clean up tasks ==
task cleanCatalina(group: cleanupGroup, description: 'Clean Catalina data in
runtime/catalina/work') {
doLast { delete "${rootDir}/runtime/catalina/work" }
{code}
The doc is here
https://github.com/martoe/gradle-svntools-plugin/blob/master/docs/SvnUpdate.md
https://github.com/martoe/gradle-svntools-plugin/blob/master/src/main/groovy/at/bxm/gradleplugins/svntools/tasks/SvnUpdate.groovy
BTW somehow related there is no Gradle svn plugin way to get the status. So you
have to move to the plugins directory. A bit tedious, I propose a
pluginsStatus.bat script for that (could be in tools but I'll move it in
another branch)
{code}
@echo off
cd plugins
svn st
cd ..
{code}
If we agree I can add the same .sh
> Add a Gradle task to svn update all plugins
> ---
>
> Key: OFBIZ-9275
> URL: https://issues.apache.org/jira/browse/OFBIZ-9275
> Project: OFBiz
> Issue Type: Improvement
> Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Release
>
>
> When you svn update the framework, unlike for svn:externals, it does not
> update the plugins because it's an embedded working copy. So I have tried
> that w/o success so far:
> {code}
> Index: build.gradle
> ===
> --- build.gradle (revision 1788020)
> +++ build.gradle (working copy)
> @@ -17,6 +17,7 @@
> * under the License.
> */
> import at.bxm.gradleplugins.svntools.tasks.SvnCheckout
> +import at.bxm.gradleplugins.svntools.tasks.SvnUpdate
> import org.apache.tools.ant.filters.ReplaceTokens
> /*
> @@ -774,6 +775,14 @@
> }
> }
> +task updateAllPluginsSource(group: ofbizPlugin,
> +description: 'Update all plugins from source control.') {
> +
> +task updatePluginsFromSvn(type: SvnUpdate) {
> +workspaceDir = "${pluginsDir}"
> +}
> +}
> +
> // == Clean up tasks ==
> task cleanCatalina(group: cleanupGroup, description: 'Clean Catalina data in
>
[jira] [Closed] (OFBIZ-8191) Make Create Menu tab bar for Routing consistent
[ https://issues.apache.org/jira/browse/OFBIZ-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-8191. -- Resolution: Done Fix Version/s: (was: Trunk) Upcoming Release Thanks Avnindra for your patch, Pierre for the review, Avnindra, your patch is in trunk at revision: 1787087 > Make Create Menu tab bar for Routing consistent > --- > > Key: OFBIZ-8191 > URL: https://issues.apache.org/jira/browse/OFBIZ-8191 > Project: OFBiz > Issue Type: Sub-task > Components: manufacturing >Reporter: Avnindra Sharma >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Release > > Attachments: OFBIZ-8191.patch > > > Add a create Routing tab bar in the main decorator to maintain the > consistency throughout the tab bar of Routing. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9139) Refactor list related forms into grids in ProjectMgr
[ https://issues.apache.org/jira/browse/OFBIZ-9139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925599#comment-15925599 ] Jacques Le Roux commented on OFBIZ-9139: Sorry Pierre, This patch is deprecated, we no longer have specialpurpose in repo > Refactor list related forms into grids in ProjectMgr > > > Key: OFBIZ-9139 > URL: https://issues.apache.org/jira/browse/OFBIZ-9139 > Project: OFBiz > Issue Type: Improvement > Components: projectmgr >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits > Labels: refactoring, widget > Attachments: OFBIZ-9139-ProjectMgr-grid.patch > > > Refactoring various list forms into grids. > Refactoring various list form references into grid references in screens. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-6034) Widget Refactoring: Refactor how links are rendered
[ https://issues.apache.org/jira/browse/OFBIZ-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925616#comment-15925616 ] Jacques Le Roux commented on OFBIZ-6034: HI Pierre, What is the status here? I see nothing pending but it's still open. > Widget Refactoring: Refactor how links are rendered > --- > > Key: OFBIZ-6034 > URL: https://issues.apache.org/jira/browse/OFBIZ-6034 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits > Labels: ftl, java, links, xsd > > Currently links are rendered differently across menu, screen and form. > We have: > * link in menu-items > * link in screens > * hyperlink in forms, in field definitions > * sub-hyperlink in forms, in display-entity in field definitions > But how the links are rendered is not consistent. So can > link-type="ajax-window" be used to trigger a popup window, while it can't be > used in a link in a menu-item, nor from a form > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Reopened] (OFBIZ-9229) refactor list related forms in Cost widgets
[ https://issues.apache.org/jira/browse/OFBIZ-9229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-9229: Pierre, Are you using that in a project? Because I reverted at revision: 1786987 I prefered to revert because the grid concept is questionned by Taher. No need to complicate later if we ever revert it all. > refactor list related forms in Cost widgets > --- > > Key: OFBIZ-9229 > URL: https://issues.apache.org/jira/browse/OFBIZ-9229 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits > Fix For: Upcoming Release > > Attachments: OFBIZ-9229-CostWidgets.xml.patch > > > Refactoring various list forms into grids > Refactoring various list form references in screen widgets -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Reopened] (OFBIZ-9232) refactor list related forms in Lookup widgets
[ https://issues.apache.org/jira/browse/OFBIZ-9232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-9232: Pierre, Are you using that in a project? Because I reverted at revision: 1786986 I prefered to revert because the grid concept is questionned by Taher. No need to complicate later if we ever revert it all. > refactor list related forms in Lookup widgets > - > > Key: OFBIZ-9232 > URL: https://issues.apache.org/jira/browse/OFBIZ-9232 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits > Fix For: Upcoming Release > > Attachments: OFBIZ-9323-Accounting-Lookup-widget.patch > > > Refactoring various list forms into grids > Refactoring various list form references in screen widgets -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9264) Make sure the local date time uses the time zone from the local browser.
[ https://issues.apache.org/jira/browse/OFBIZ-9264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927760#comment-15927760 ] Jacques Le Roux commented on OFBIZ-9264: What about the fact that you can set your own time zone independently of the browser? https://demo-trunk.ofbiz.apache.org/catalog/control/ListTimezones > Make sure the local date time uses the time zone from the local browser. > > > Key: OFBIZ-9264 > URL: https://issues.apache.org/jira/browse/OFBIZ-9264 > Project: OFBiz > Issue Type: New Feature >Affects Versions: Trunk >Reporter: Francis Douet >Priority: Minor > Labels: timezone > Attachments: OFBIZ-9264.diff > > > This feature was requested by one of our clients, it sets the time zone of > the user logged in to it's browser time zone. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9264) Make sure the local date time uses the time zone from the local browser.
[ https://issues.apache.org/jira/browse/OFBIZ-9264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927873#comment-15927873 ] Jacques Le Roux commented on OFBIZ-9264: I see, then this makes sense. I'll wait a week for other opinions before reviewing and hopefully committined > Make sure the local date time uses the time zone from the local browser. > > > Key: OFBIZ-9264 > URL: https://issues.apache.org/jira/browse/OFBIZ-9264 > Project: OFBiz > Issue Type: New Feature >Affects Versions: Trunk >Reporter: Francis Douet >Priority: Minor > Labels: timezone > Attachments: OFBIZ-9264.diff > > > This feature was requested by one of our clients, it sets the time zone of > the user logged in to it's browser time zone. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Comment Edited] (OFBIZ-9264) Make sure the local date time uses the time zone from the local browser.
[ https://issues.apache.org/jira/browse/OFBIZ-9264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927873#comment-15927873 ] Jacques Le Roux edited comment on OFBIZ-9264 at 3/16/17 11:49 AM: -- I see, then this makes sense. I'll wait a week for other opinions before reviewing and hopefully committing was (Author: jacques.le.roux): I see, then this makes sense. I'll wait a week for other opinions before reviewing and hopefully committined > Make sure the local date time uses the time zone from the local browser. > > > Key: OFBIZ-9264 > URL: https://issues.apache.org/jira/browse/OFBIZ-9264 > Project: OFBiz > Issue Type: New Feature >Affects Versions: Trunk >Reporter: Francis Douet >Priority: Minor > Labels: timezone > Attachments: OFBIZ-9264.diff > > > This feature was requested by one of our clients, it sets the time zone of > the user logged in to it's browser time zone. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9264) Make sure the local date time uses the time zone from the local browser.
[ https://issues.apache.org/jira/browse/OFBIZ-9264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927774#comment-15927774 ] Jacques Le Roux commented on OFBIZ-9264: Also this is maybe worth reading https://cwiki.apache.org/confluence/display/OFBIZ/Calendars,+Dates,+and+Times > Make sure the local date time uses the time zone from the local browser. > > > Key: OFBIZ-9264 > URL: https://issues.apache.org/jira/browse/OFBIZ-9264 > Project: OFBiz > Issue Type: New Feature >Affects Versions: Trunk >Reporter: Francis Douet >Priority: Minor > Labels: timezone > Attachments: OFBIZ-9264.diff > > > This feature was requested by one of our clients, it sets the time zone of > the user logged in to it's browser time zone. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9264) Make sure the local date time uses the time zone from the local browser.
[ https://issues.apache.org/jira/browse/OFBIZ-9264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927776#comment-15927776 ] Jacques Le Roux commented on OFBIZ-9264: I though think this is still true http://markmail.org/message/bldm5eajql4in3yg Maybe the reason of the initial problem your client crossed? > Make sure the local date time uses the time zone from the local browser. > > > Key: OFBIZ-9264 > URL: https://issues.apache.org/jira/browse/OFBIZ-9264 > Project: OFBiz > Issue Type: New Feature >Affects Versions: Trunk >Reporter: Francis Douet >Priority: Minor > Labels: timezone > Attachments: OFBIZ-9264.diff > > > This feature was requested by one of our clients, it sets the time zone of > the user logged in to it's browser time zone. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Comment Edited] (OFBIZ-9264) Make sure the local date time uses the time zone from the local browser.
[ https://issues.apache.org/jira/browse/OFBIZ-9264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927776#comment-15927776 ] Jacques Le Roux edited comment on OFBIZ-9264 at 3/16/17 10:20 AM: -- I wonder if this is still true http://markmail.org/message/bldm5eajql4in3yg (did not check) Maybe the reason of the initial problem your client crossed? was (Author: jacques.le.roux): I though think this is still true http://markmail.org/message/bldm5eajql4in3yg Maybe the reason of the initial problem your client crossed? > Make sure the local date time uses the time zone from the local browser. > > > Key: OFBIZ-9264 > URL: https://issues.apache.org/jira/browse/OFBIZ-9264 > Project: OFBiz > Issue Type: New Feature >Affects Versions: Trunk >Reporter: Francis Douet >Priority: Minor > Labels: timezone > Attachments: OFBIZ-9264.diff > > > This feature was requested by one of our clients, it sets the time zone of > the user logged in to it's browser time zone. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Comment Edited] (OFBIZ-9302) logout security
[ https://issues.apache.org/jira/browse/OFBIZ-9302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15954763#comment-15954763 ] Jacques Le Roux edited comment on OFBIZ-9302 at 4/4/17 8:53 AM: Could you please try the same with a browser cache clear before going back? was (Author: jacques.le.roux): Could you please try the same with a browser cache clear before using going back? > logout security > --- > > Key: OFBIZ-9302 > URL: https://issues.apache.org/jira/browse/OFBIZ-9302 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Release Branch 16.11 >Reporter: Moatasim Al Masri > Attachments: logout2.wmv, logout.wmv > > > am trying to check OFBIZ security authentication, and I found when we > logedout the session still open in browser, that if we press back from > browser we can reopen the session and continue see our application without > any authentication. > please see the video attached : logout.wmv -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9302) logout security
[ https://issues.apache.org/jira/browse/OFBIZ-9302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15954855#comment-15954855 ] Jacques Le Roux commented on OFBIZ-9302: But I reproduce on FF and IE11, weird again. > logout security > --- > > Key: OFBIZ-9302 > URL: https://issues.apache.org/jira/browse/OFBIZ-9302 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Release Branch 16.11 >Reporter: Moatasim Al Masri > Attachments: logout2.wmv, logout.wmv > > > am trying to check OFBIZ security authentication, and I found when we > logedout the session still open in browser, that if we press back from > browser we can reopen the session and continue see our application without > any authentication. > please see the video attached : logout.wmv -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9302) logout security
[ https://issues.apache.org/jira/browse/OFBIZ-9302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15954883#comment-15954883 ] Jacques Le Roux commented on OFBIZ-9302: I'll use this as reference https://en.wikipedia.org/wiki/Wikipedia:Bypass_your_cache > logout security > --- > > Key: OFBIZ-9302 > URL: https://issues.apache.org/jira/browse/OFBIZ-9302 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Release Branch 16.11 >Reporter: Moatasim Al Masri > Attachments: logout2.wmv, logout.wmv > > > am trying to check OFBIZ security authentication, and I found when we > logedout the session still open in browser, that if we press back from > browser we can reopen the session and continue see our application without > any authentication. > please see the video attached : logout.wmv -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9302) logout security
[ https://issues.apache.org/jira/browse/OFBIZ-9302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15954880#comment-15954880 ] Jacques Le Roux commented on OFBIZ-9302: What I mean is it's only a local issue as long as someone has not been able to take the control of your machine (it's only in your local machine cache); wich anyway would be a much greater problem than this. But it's still weird for FF and IE :/ I'll try to investigate there... I'll also check if older versions have this problem or not... > logout security > --- > > Key: OFBIZ-9302 > URL: https://issues.apache.org/jira/browse/OFBIZ-9302 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Release Branch 16.11 >Reporter: Moatasim Al Masri > Attachments: logout2.wmv, logout.wmv > > > am trying to check OFBIZ security authentication, and I found when we > logedout the session still open in browser, that if we press back from > browser we can reopen the session and continue see our application without > any authentication. > please see the video attached : logout.wmv -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9302) logout security
[ https://issues.apache.org/jira/browse/OFBIZ-9302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15954763#comment-15954763 ] Jacques Le Roux commented on OFBIZ-9302: Could you please try the same with a browser cache clear before using going back? > logout security > --- > > Key: OFBIZ-9302 > URL: https://issues.apache.org/jira/browse/OFBIZ-9302 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Release Branch 16.11 >Reporter: Moatasim Al Masri > Attachments: logout.wmv > > > am trying to check OFBIZ security authentication, and I found when we > logedout the session still open in browser, that if we press back from > browser we can reopen the session and continue see our application without > any authentication. > please see the video attached : logout.wmv -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9302) logout security
[ https://issues.apache.org/jira/browse/OFBIZ-9302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15954853#comment-15954853 ] Jacques Le Roux commented on OFBIZ-9302: I mean just after having logged out and before going back. Because I don't reproduce on Chrome when using Ctrl+F5 then. > logout security > --- > > Key: OFBIZ-9302 > URL: https://issues.apache.org/jira/browse/OFBIZ-9302 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Release Branch 16.11 >Reporter: Moatasim Al Masri > Attachments: logout2.wmv, logout.wmv > > > am trying to check OFBIZ security authentication, and I found when we > logedout the session still open in browser, that if we press back from > browser we can reopen the session and continue see our application without > any authentication. > please see the video attached : logout.wmv -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9300) Strange behaviour of Keyboard Shortcuts in WebPos
[ https://issues.apache.org/jira/browse/OFBIZ-9300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15953387#comment-15953387 ] Jacques Le Roux commented on OFBIZ-9300: Thanks Aditya, DId you check that this was not already reported in an issue https://issues.apache.org/jira/browse/OFBIZ-7945?filter=12340482=project%20%3D%20OFBIZ%20AND%20component%20%3D%20webpos%20AND%20text%20~%20%22key%22%20ORDER%20BY%20cf%5B12310220%5D%20DESC ? > Strange behaviour of Keyboard Shortcuts in WebPos > - > > Key: OFBIZ-9300 > URL: https://issues.apache.org/jira/browse/OFBIZ-9300 > Project: OFBiz > Issue Type: Bug >Reporter: Aditya Sharma >Assignee: Aditya Sharma > > Steps to regenerate: > 1. Navigate to https://localhost:8443/webpos/control/main. > 2. Use Keyboard Shortcuts specified there. > 3. From "Pay Pin" all are working for its subsequent operation.For example > when you click on "Pay By CC" or use shortcut F7 it will perform Checkout > which is next operation in the list. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9298) logout
[ https://issues.apache.org/jira/browse/OFBIZ-9298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15953366#comment-15953366 ] Jacques Le Roux commented on OFBIZ-9298: I can't reproduce please give more detail on the steps used, the theme used, etc. > logout > -- > > Key: OFBIZ-9298 > URL: https://issues.apache.org/jira/browse/OFBIZ-9298 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Release Branch 16.11 >Reporter: Moatasim Al Masri > > if log in in any components, for example : > https://demo-stable.ofbiz.apache.org/humanres/control/main > after then got to content component then the system will logout directly and > go to login again. > note: after this logout if we are log in again without close web browser will > not appear this issue, but if we close web browser and repeat it the issue > will appear again -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9298) logout
[ https://issues.apache.org/jira/browse/OFBIZ-9298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15953810#comment-15953810 ] Jacques Le Roux commented on OFBIZ-9298: I don't reproduce locally with the trunk HEAD but I reproduce on trunk demo, even more weird... > logout > -- > > Key: OFBIZ-9298 > URL: https://issues.apache.org/jira/browse/OFBIZ-9298 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Release Branch 16.11 >Reporter: Moatasim Al Masri > Attachments: content manager .wmv > > > if log in in any components, for example : > https://demo-stable.ofbiz.apache.org/humanres/control/main > after then got to content component then the system will logout directly and > go to login again. > note: after this logout if we are log in again without close web browser will > not appear this issue, but if we close web browser and repeat it the issue > will appear again -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OFBIZ-9299) image content
[ https://issues.apache.org/jira/browse/OFBIZ-9299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-9299: --- Labels: Rainbow theme (was: ) Thanks! > image content > - > > Key: OFBIZ-9299 > URL: https://issues.apache.org/jira/browse/OFBIZ-9299 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Release Branch 16.11 >Reporter: Moatasim Al Masri > Labels: Rainbow, theme > Attachments: Capture1.PNG, Capture2.PNG > > > logo image not displayed untill we press in content component > see attached capture two images > we can upload this image from party profile --> Party Content -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (OFBIZ-9293) Review and possibly refactor code (not only Java, but mostly) in the ebaystore component
Jacques Le Roux created OFBIZ-9293: -- Summary: Review and possibly refactor code (not only Java, but mostly) in the ebaystore component Key: OFBIZ-9293 URL: https://issues.apache.org/jira/browse/OFBIZ-9293 Project: OFBiz Issue Type: Improvement Components: ebaystore Affects Versions: Trunk Reporter: Jacques Le Roux Priority: Minor Fix For: Upcoming Release While working on another issue, I noticed the ebaystore component code needs some love... -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OFBIZ-9291) EntityListIterator Not Closed for Entity [Content], caught in Finalize
[
https://issues.apache.org/jira/browse/OFBIZ-9291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-9291:
---
Description:
While working on OFBIZ-7759 I noticed this error in log
{code}
2017-03-31 22:03:53,047 |http-nio-8443-exec-1 |ControlServlet
|T| [[[LookupContent(Domain:https://localhost)] Request Done- total:3.571,since
last([LookupContent(Do...):3.571]]
2017-03-31 22:04:06,552 |Finalizer|EntityListIterator|E|
EntityListIterator Not Closed for Entity [Content], caught in Finalize
{code}
It's not really a bug because the EntityListIterator takes care of it and
there is no side effects. But it's not clean and need to be improved.
was:
While working on OFBIZ-7759I noticed this error in log
{code}
2017-03-31 22:03:53,047 |http-nio-8443-exec-1 |ControlServlet
|T| [[[LookupContent(Domain:https://localhost)] Request Done- total:3.571,since
last([LookupContent(Do...):3.571]]
2017-03-31 22:04:06,552 |Finalizer|EntityListIterator|E|
EntityListIterator Not Closed for Entity [Content], caught in Finalize
{code}
It's not really a bug because the EntityListIterator takes care of it and
there is no side effects. But it's not clean and need to be improved.
> EntityListIterator Not Closed for Entity [Content], caught in Finalize
> --
>
> Key: OFBIZ-9291
> URL: https://issues.apache.org/jira/browse/OFBIZ-9291
> Project: OFBiz
> Issue Type: Improvement
> Components: content
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Release
>
>
> While working on OFBIZ-7759 I noticed this error in log
> {code}
> 2017-03-31 22:03:53,047 |http-nio-8443-exec-1 |ControlServlet
> |T| [[[LookupContent(Domain:https://localhost)] Request Done-
> total:3.571,since last([LookupContent(Do...):3.571]]
> 2017-03-31 22:04:06,552 |Finalizer|EntityListIterator
> |E|
>
>
> EntityListIterator Not Closed for Entity [Content], caught in Finalize
>
> {code}
> It's not really a bug because the EntityListIterator takes care of it and
> there is no side effects. But it's not clean and need to be improved.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (OFBIZ-9291) EntityListIterator Not Closed for Entity [Content], caught in Finalize
[
https://issues.apache.org/jira/browse/OFBIZ-9291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-9291:
---
Description:
While working on OFBIZ-7759I noticed this error in log
{code}
2017-03-31 22:03:53,047 |http-nio-8443-exec-1 |ControlServlet
|T| [[[LookupContent(Domain:https://localhost)] Request Done- total:3.571,since
last([LookupContent(Do...):3.571]]
2017-03-31 22:04:06,552 |Finalizer|EntityListIterator|E|
EntityListIterator Not Closed for Entity [Content], caught in Finalize
{code}
It's not really a bug because the EntityListIterator takes care of it and
there is no side effects. But it's not clean and need to be improved.
was:
While working on OFBIZ-8341 I noticed this error in log
{code}
2017-03-31 22:03:53,047 |http-nio-8443-exec-1 |ControlServlet
|T| [[[LookupContent(Domain:https://localhost)] Request Done- total:3.571,since
last([LookupContent(Do...):3.571]]
2017-03-31 22:04:06,552 |Finalizer|EntityListIterator|E|
EntityListIterator Not Closed for Entity [Content], caught in Finalize
{code}
It's not really a bug because the EntityListIterator takes care of it and
there is no side effects. But it's not clean and need to be improved.
> EntityListIterator Not Closed for Entity [Content], caught in Finalize
> --
>
> Key: OFBIZ-9291
> URL: https://issues.apache.org/jira/browse/OFBIZ-9291
> Project: OFBiz
> Issue Type: Improvement
> Components: content
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Release
>
>
> While working on OFBIZ-7759I noticed this error in log
> {code}
> 2017-03-31 22:03:53,047 |http-nio-8443-exec-1 |ControlServlet
> |T| [[[LookupContent(Domain:https://localhost)] Request Done-
> total:3.571,since last([LookupContent(Do...):3.571]]
> 2017-03-31 22:04:06,552 |Finalizer|EntityListIterator
> |E|
>
>
> EntityListIterator Not Closed for Entity [Content], caught in Finalize
>
> {code}
> It's not really a bug because the EntityListIterator takes care of it and
> there is no side effects. But it's not clean and need to be improved.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (OFBIZ-5885) EntityListIterator Not Closed for Entity JobSandbox, caught in Finalize
[ https://issues.apache.org/jira/browse/OFBIZ-5885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-5885: --- Issue Type: Sub-task (was: Bug) Parent: OFBIZ-9297 > EntityListIterator Not Closed for Entity JobSandbox, caught in Finalize > --- > > Key: OFBIZ-5885 > URL: https://issues.apache.org/jira/browse/OFBIZ-5885 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Release Branch 13.07, Trunk >Reporter: Deepak Dixit >Assignee: Jacques Le Roux >Priority: Minor > Fix For: 14.12.01, 12.04.06, 13.07.02 > > Attachments: OFBIZ-5885.patch > > > EntityListIterator Not Closed for Entity JobSandbox in > ServiceUtil.purgeOldJobs method. Need to close the entity list iterator > properly. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OFBIZ-9297) EntityListIterator Not Closed for Entity [EntityName], caught in Finalize
[ https://issues.apache.org/jira/browse/OFBIZ-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-9297: --- Issue Type: Improvement (was: Bug) > EntityListIterator Not Closed for Entity [EntityName], caught in Finalize > - > > Key: OFBIZ-9297 > URL: https://issues.apache.org/jira/browse/OFBIZ-9297 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Release > > > This is an umbrella issue for all related ones -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (OFBIZ-9297) EntityListIterator Not Closed for Entity [EntityName], caught in Finalize
Jacques Le Roux created OFBIZ-9297: -- Summary: EntityListIterator Not Closed for Entity [EntityName], caught in Finalize Key: OFBIZ-9297 URL: https://issues.apache.org/jira/browse/OFBIZ-9297 Project: OFBiz Issue Type: Bug Components: ALL APPLICATIONS Affects Versions: Trunk Reporter: Jacques Le Roux Priority: Minor Fix For: Upcoming Release This is an umbrella issue for all related ones -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9280) Sort Links in Lookup for Data Resource Id causes unwanted behaviour on Find Content page
[ https://issues.apache.org/jira/browse/OFBIZ-9280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15952602#comment-15952602 ] Jacques Le Roux commented on OFBIZ-9280: BTW Aditya, The same problem exists in the ListLookupContent that you fixed for another reason at OFBIZ-7759. Could you please apply the same there? > Sort Links in Lookup for Data Resource Id causes unwanted behaviour on Find > Content page > > > Key: OFBIZ-9280 > URL: https://issues.apache.org/jira/browse/OFBIZ-9280 > Project: OFBiz > Issue Type: Bug >Reporter: Aditya Sharma >Assignee: Jacques Le Roux > Fix For: Release Branch 14.12, Release Branch 15.12, Upcoming > Release, 16.11.02 > > Attachments: OFBIZ-9280.patch, OFBIZ-9280.patch, screenshot-1.png > > > How to reproduce : > 1. Log in the Content component > 2. Go to the Content tab. https://localhost:8443/content/control/findContent > 3. In the search form, open the lookup of the field ' Data Resource Id ' > 4. Click on any of the table header links to sort the table. Results will be > displayed on a new unstyled window closing the Lookup dialog. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OFBIZ-7406) Find Projects throw "EntityListIterator Not Closed for Entity" error on terminal
[
https://issues.apache.org/jira/browse/OFBIZ-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-7406:
---
Issue Type: Sub-task (was: Bug)
Parent: OFBIZ-9297
> Find Projects throw "EntityListIterator Not Closed for Entity" error on
> terminal
>
>
> Key: OFBIZ-7406
> URL: https://issues.apache.org/jira/browse/OFBIZ-7406
> Project: OFBiz
> Issue Type: Sub-task
> Components: projectmgr
>Reporter: Vaibhav Jain
>Assignee: Vaibhav Jain
>Priority: Minor
>
> Steps to regenerate issue:
> 1. Go to PROJECTS component
> 2. Click on sub-menu "Projects"
> 3. Click on find button
>
> #Browse the link:
> https://localhost:8443/projectmgr/control/FindProject
>
> {code}
> [java] 2016-06-18 11:06:18,741 |Finalizer|SQLProcessor
> |E| Error closing the result, connection, etc in finalize SQLProcessor
> [java] java.lang.NullPointerException
> [java] at
> org.apache.commons.dbcp2.DelegatingConnection.closeInternal(DelegatingConnection.java:235)
> ~[commons-dbcp2-2.1.jar:2.1]
> [java] at
> org.apache.commons.dbcp2.DelegatingConnection.close(DelegatingConnection.java:218)
> ~[commons-dbcp2-2.1.jar:2.1]
> [java] at
> org.apache.commons.dbcp2.managed.ManagedConnection.close(ManagedConnection.java:166)
> ~[commons-dbcp2-2.1.jar:2.1]
> [java] at org.ofbiz.entity.jdbc.SQLProcessor.close(SQLProcessor.java:235)
> ~[ofbiz-entity.jar:?]
> [java] at
> org.ofbiz.entity.jdbc.SQLProcessor.finalize(SQLProcessor.java:844)
> [ofbiz-entity.jar:?]
> [java] at java.lang.System$2.invokeFinalize(System.java:1270) [?:1.8.0_66]
> [java] at java.lang.ref.Finalizer.runFinalizer(Finalizer.java:98)
> [?:1.8.0_66]
> [java] at java.lang.ref.Finalizer.access$100(Finalizer.java:34)
> [?:1.8.0_66]
> [java] at java.lang.ref.Finalizer$FinalizerThread.run(Finalizer.java:210)
> [?:1.8.0_66]
> [java] 2016-06-18 11:06:18,742 |Finalizer|EntityListIterator
> |E|
> [java]
>
> [java] EntityListIterator Not Closed for Entity
> [WorkEffortAndPartyAssign], caught in Finalize
> [java]
>
> [java]
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (OFBIZ-9291) EntityListIterator Not Closed for Entity [Content], caught in Finalize
[
https://issues.apache.org/jira/browse/OFBIZ-9291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-9291:
---
Issue Type: Sub-task (was: Improvement)
Parent: OFBIZ-9297
> EntityListIterator Not Closed for Entity [Content], caught in Finalize
> --
>
> Key: OFBIZ-9291
> URL: https://issues.apache.org/jira/browse/OFBIZ-9291
> Project: OFBiz
> Issue Type: Sub-task
> Components: content
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Release
>
>
> While working on OFBIZ-7759 I noticed this error in log
> {code}
> 2017-03-31 22:03:53,047 |http-nio-8443-exec-1 |ControlServlet
> |T| [[[LookupContent(Domain:https://localhost)] Request Done-
> total:3.571,since last([LookupContent(Do...):3.571]]
> 2017-03-31 22:04:06,552 |Finalizer|EntityListIterator
> |E|
>
>
> EntityListIterator Not Closed for Entity [Content], caught in Finalize
>
> {code}
> It's not really a bug because the EntityListIterator takes care of it and
> there is no side effects. But it's not clean and need to be improved.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Closed] (OFBIZ-9280) Sort Links in Lookup for Data Resource Id causes unwanted behaviour on Find Content page
[ https://issues.apache.org/jira/browse/OFBIZ-9280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-9280. -- Resolution: Fixed Fix Version/s: Release Branch 14.12 Release Branch 15.12 16.11.02 Upcoming Release Thanks Aditya, Your slightly modidied patch is in trunk r1789863 R16.11 r1789864 R15.12 r1789865 R14.12 r1789866 I simply added the header-row-style="header-row-2" style > Sort Links in Lookup for Data Resource Id causes unwanted behaviour on Find > Content page > > > Key: OFBIZ-9280 > URL: https://issues.apache.org/jira/browse/OFBIZ-9280 > Project: OFBiz > Issue Type: Bug >Reporter: Aditya Sharma >Assignee: Jacques Le Roux > Fix For: Upcoming Release, 16.11.02, Release Branch 15.12, > Release Branch 14.12 > > Attachments: OFBIZ-9280.patch, OFBIZ-9280.patch, screenshot-1.png > > > How to reproduce : > 1. Log in the Content component > 2. Go to the Content tab. https://localhost:8443/content/control/findContent > 3. In the search form, open the lookup of the field ' Data Resource Id ' > 4. Click on any of the table header links to sort the table. Results will be > displayed on a new unstyled window closing the Lookup dialog. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9280) Sort Links in Lookup for Data Resource Id causes unwanted behaviour on Find Content page
[ https://issues.apache.org/jira/browse/OFBIZ-9280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15952608#comment-15952608 ] Jacques Le Roux commented on OFBIZ-9280: Great, thanks Aditya :) > Sort Links in Lookup for Data Resource Id causes unwanted behaviour on Find > Content page > > > Key: OFBIZ-9280 > URL: https://issues.apache.org/jira/browse/OFBIZ-9280 > Project: OFBiz > Issue Type: Bug >Reporter: Aditya Sharma >Assignee: Jacques Le Roux > Fix For: Release Branch 14.12, Release Branch 15.12, Upcoming > Release, 16.11.02 > > Attachments: OFBIZ-9280.patch, OFBIZ-9280.patch, screenshot-1.png > > > How to reproduce : > 1. Log in the Content component > 2. Go to the Content tab. https://localhost:8443/content/control/findContent > 3. In the search form, open the lookup of the field ' Data Resource Id ' > 4. Click on any of the table header links to sort the table. Results will be > displayed on a new unstyled window closing the Lookup dialog. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OFBIZ-4424) EntityListIterator not being closed after storing incoming email
[ https://issues.apache.org/jira/browse/OFBIZ-4424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-4424: --- Issue Type: Sub-task (was: Bug) Parent: OFBIZ-9297 > EntityListIterator not being closed after storing incoming email > > > Key: OFBIZ-4424 > URL: https://issues.apache.org/jira/browse/OFBIZ-4424 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Release 10.04, Trunk > Environment: OFBiz 10.04 release, OS - Ubuntu, DB - PostgreSQL >Reporter: Varun Bhansaly >Assignee: Sascha Rodekamp > Fix For: Release Branch 10.04, Release Branch 11.04, Trunk > > Attachments: OFBIZ-4424.patch > > > CommunicationEventServices.buildListOfWorkEffortInfoFromEmailAddresses() does > not close the entity list iterator resulting in error messages like - > 2011-09-16 06:15:43,736 [ERROR] > > EntityListIterator Not Closed for Entity [WorkEffortContactMechView], caught > in Finalize > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9254) Inconsistent String Comparisons
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15950326#comment-15950326
]
Jacques Le Roux commented on OFBIZ-9254:
Thanks Devanshu,
I have reviewed the Groovy patch and it's OK with me.
Reviewing the Java patch is something else (10+ times more). I was wondering:
did you do your changes with the help of a regexp S/R or all by hand? Because I
could use a regexp S/R to make the same changes and compares with yours.
> Inconsistent String Comparisons
> ---
>
> Key: OFBIZ-9254
> URL: https://issues.apache.org/jira/browse/OFBIZ-9254
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Priority: Minor
> Attachments: OFBIZ-9254_groovy.patch, OFBIZ-9254_java.patch
>
>
> I found an inconsistency in the code for string comparison
> statusId.equals("PRUN_COMPLETED") whereas it should be written as
> "PRUN_COMPLETED".equals(statusId)
> cause the former can throw NullPointerException if the variable found to be
> NULL.
> This pattern should be applied to
> - Java Files
> - Groovy Files
> - FTL Files
> Here is the reference for the discussion done on the dev list.
> http://markmail.org/message/iqfaab3fl3ukxchy
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Closed] (OFBIZ-9279) Sort Links in Lookup for Owner Content Id causes unwanted behaviour on Find Content page
[ https://issues.apache.org/jira/browse/OFBIZ-9279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-9279. -- Resolution: Fixed Fix Version/s: Release Branch 14.12 Release Branch 15.12 16.11.02 Upcoming Release Thanks Aditya, Your patch is in trunk r1789874 R16.11 r1789875 R15.12 r1789876 R14.12 r1789877 > Sort Links in Lookup for Owner Content Id causes unwanted behaviour on Find > Content page > > > Key: OFBIZ-9279 > URL: https://issues.apache.org/jira/browse/OFBIZ-9279 > Project: OFBiz > Issue Type: Bug >Reporter: Aditya Sharma >Assignee: Aditya Sharma > Fix For: Upcoming Release, 16.11.02, Release Branch 15.12, > Release Branch 14.12 > > Attachments: OFBIZ-9279.patch, screenshot-1.png > > > How to reproduce : > 1. Log in the Content component > 2. Go to the Content tab. https://localhost:8443/content/control/findContent > 3. In the search form, open the lookup of the field ' Owner Content Id ' > 4. Click on any of the table header links to sort the table. Results will be > displayed on a new unstyled window closing the Lookup dialog. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9279) Sort Links in Lookup for Owner Content Id causes unwanted behaviour on Find Content page
[ https://issues.apache.org/jira/browse/OFBIZ-9279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15952646#comment-15952646 ] Jacques Le Roux commented on OFBIZ-9279: I said not a biggie, because an easy workaround is to reload the "Find Content" screen, to start anew. But you then lose the already made choices. > Sort Links in Lookup for Owner Content Id causes unwanted behaviour on Find > Content page > > > Key: OFBIZ-9279 > URL: https://issues.apache.org/jira/browse/OFBIZ-9279 > Project: OFBiz > Issue Type: Bug >Reporter: Aditya Sharma >Assignee: Aditya Sharma > Fix For: Release Branch 14.12, Release Branch 15.12, Upcoming > Release, 16.11.02 > > Attachments: OFBIZ-9279.patch, screenshot-1.png > > > How to reproduce : > 1. Log in the Content component > 2. Go to the Content tab. https://localhost:8443/content/control/findContent > 3. In the search form, open the lookup of the field ' Owner Content Id ' > 4. Click on any of the table header links to sort the table. Results will be > displayed on a new unstyled window closing the Lookup dialog. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Reopened] (OFBIZ-9279) Sort Links in Lookup for Owner Content Id causes unwanted behaviour on Find Content page
[ https://issues.apache.org/jira/browse/OFBIZ-9279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-9279: Aditya, I reopen because I have noticed a quirk. Once you have selected a "Owner Content Id" and have it shown in the "Find Content" screen, if you want to change it, you get the "Find Content" screen duplicated instead of the lookup. Not a biggie but annoying, could you have a look when you get a chance? Thanks. Maybe you will prefer to close here and create a new issue, I let you decide... > Sort Links in Lookup for Owner Content Id causes unwanted behaviour on Find > Content page > > > Key: OFBIZ-9279 > URL: https://issues.apache.org/jira/browse/OFBIZ-9279 > Project: OFBiz > Issue Type: Bug >Reporter: Aditya Sharma >Assignee: Aditya Sharma > Fix For: Release Branch 14.12, Release Branch 15.12, Upcoming > Release, 16.11.02 > > Attachments: OFBIZ-9279.patch, screenshot-1.png > > > How to reproduce : > 1. Log in the Content component > 2. Go to the Content tab. https://localhost:8443/content/control/findContent > 3. In the search form, open the lookup of the field ' Owner Content Id ' > 4. Click on any of the table header links to sort the table. Results will be > displayed on a new unstyled window closing the Lookup dialog. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (OFBIZ-9295) Use an "Advanced Search" panel in complicated lookups
Jacques Le Roux created OFBIZ-9295:
--
Summary: Use an "Advanced Search" panel in complicated lookups
Key: OFBIZ-9295
URL: https://issues.apache.org/jira/browse/OFBIZ-9295
Project: OFBiz
Issue Type: Improvement
Components: ALL APPLICATIONS
Affects Versions: Trunk
Reporter: Jacques Le Roux
Priority: Minor
Fix For: Upcoming Release
While working on OFBIZ-9280 I noticed there is a convenient "Advanced Search"
panel. We have a number of confusing lookups where there are too much fields.
We should apply the same concept ("Advanced Search" panel) to all of them
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OFBIZ-9280) Sort Links in Lookup for Data Resource Id causes unwanted behaviour on Find Content page
[ https://issues.apache.org/jira/browse/OFBIZ-9280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15952159#comment-15952159 ] Jacques Le Roux commented on OFBIZ-9280: Hi Aditya, It kinda works but not really because the columns are no longer sortable. There is a good side effect, the size of the view works when it does not w/o the patch > Sort Links in Lookup for Data Resource Id causes unwanted behaviour on Find > Content page > > > Key: OFBIZ-9280 > URL: https://issues.apache.org/jira/browse/OFBIZ-9280 > Project: OFBiz > Issue Type: Bug >Reporter: Aditya Sharma >Assignee: Jacques Le Roux > Attachments: OFBIZ-9280.patch, OFBIZ-9280.patch, screenshot-1.png > > > How to reproduce : > 1. Log in the Content component > 2. Go to the Content tab. https://localhost:8443/content/control/findContent > 3. In the search form, open the lookup of the field ' Data Resource Id ' > 4. Click on any of the table header links to sort the table. Results will be > displayed on a new unstyled window closing the Lookup dialog. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (OFBIZ-9282) Refactor lists related to gateway transactions in accounting
[ https://issues.apache.org/jira/browse/OFBIZ-9282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-9282. -- Resolution: Fixed Fix Version/s: Upcoming Release Thanks Pierre, Your patch is in at revision: 1789781 > Refactor lists related to gateway transactions in accounting > > > Key: OFBIZ-9282 > URL: https://issues.apache.org/jira/browse/OFBIZ-9282 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Reporter: Pierre Smits >Assignee: Pierre Smits > Labels: refactoring, widget > Fix For: Upcoming Release > > Attachments: OFBIZ-9282-Accounting-GatewayTransactions.patch > > > Refactor various list forms into grids. > Refactor various list form references in screen widgets. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9273) The createTenant Gradle task fails
[
https://issues.apache.org/jira/browse/OFBIZ-9273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15952130#comment-15952130
]
Jacques Le Roux commented on OFBIZ-9273:
Thanks Swapnil,
This is an important matter. Since the build.gradle plugin file does nothing
OOTB I think it should simply be a documented how-to. So the option 1) fits
with me!
> The createTenant Gradle task fails
> --
>
> Key: OFBIZ-9273
> URL: https://issues.apache.org/jira/browse/OFBIZ-9273
> Project: OFBiz
> Issue Type: Bug
> Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
> Fix For: Upcoming Release
>
>
> When you enter
> bq. gradlew createTenant -PtenantId=test
> you get
> {code}
> FAILURE: Build failed with an exception.
> * Where:
> Build file 'C:\projectsASF\ofbiz-framework\build.gradle' line: 764
> * What went wrong:
> A problem occurred evaluating root project 'ofbiz'.
> > Could not get unknown property 'pluginId' for task ':installAllPlugins' of
> > type org.gradle.api.DefaultTask.
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Created] (OFBIZ-9296) Update Gradle to 2.4.10
Jacques Le Roux created OFBIZ-9296: -- Summary: Update Gradle to 2.4.10 Key: OFBIZ-9296 URL: https://issues.apache.org/jira/browse/OFBIZ-9296 Project: OFBiz Issue Type: Task Affects Versions: Trunk Reporter: Jacques Le Roux Priority: Trivial Fix For: Upcoming Release While working to see if we can somehow use a mechanism like [try-with-ressources in Groovy|https://stackoverflow.com/questions/23382079/groovy-try-with-resources-construction-analogue] ([it seems autocloseable is available in 2.5|http://docs.groovy-lang.org/docs/next/html/groovy-jdk/java/lang/AutoCloseable.html], but I did not dig enough) I spotted that we could update to 2.4.10. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9254) Inconsistent String Comparisons
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15952212#comment-15952212
]
Jacques Le Roux commented on OFBIZ-9254:
Thanks Devanshu,
Perfect, I'll try to find a regexp and compare the changes. Else I'll simply
review, quite hypnotic...
> Inconsistent String Comparisons
> ---
>
> Key: OFBIZ-9254
> URL: https://issues.apache.org/jira/browse/OFBIZ-9254
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Priority: Minor
> Attachments: OFBIZ-9254_groovy.patch, OFBIZ-9254_java.patch
>
>
> I found an inconsistency in the code for string comparison
> statusId.equals("PRUN_COMPLETED") whereas it should be written as
> "PRUN_COMPLETED".equals(statusId)
> cause the former can throw NullPointerException if the variable found to be
> NULL.
> This pattern should be applied to
> - Java Files
> - Groovy Files
> - FTL Files
> Here is the reference for the discussion done on the dev list.
> http://markmail.org/message/iqfaab3fl3ukxchy
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OFBIZ-9275) Add a Gradle task to svn update all plugins
[
https://issues.apache.org/jira/browse/OFBIZ-9275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15965634#comment-15965634
]
Jacques Le Roux commented on OFBIZ-9275:
I tried that and forgot to remove it so was committed and I removed just after
at
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/build.gradle?r1=1790945=1790944=1790945
> Add a Gradle task to svn update all plugins
> ---
>
> Key: OFBIZ-9275
> URL: https://issues.apache.org/jira/browse/OFBIZ-9275
> Project: OFBiz
> Issue Type: Improvement
> Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Release
>
>
> When you svn update the framework, unlike for svn:externals, it does not
> update the plugins because it's an embedded working copy. So I have tried
> that w/o success so far:
> {code}
> Index: build.gradle
> ===
> --- build.gradle (revision 1788020)
> +++ build.gradle (working copy)
> @@ -17,6 +17,7 @@
> * under the License.
> */
> import at.bxm.gradleplugins.svntools.tasks.SvnCheckout
> +import at.bxm.gradleplugins.svntools.tasks.SvnUpdate
> import org.apache.tools.ant.filters.ReplaceTokens
> /*
> @@ -774,6 +775,14 @@
> }
> }
> +task updateAllPluginsSource(group: ofbizPlugin,
> +description: 'Update all plugins from source control.') {
> +
> +task updatePluginsFromSvn(type: SvnUpdate) {
> +workspaceDir = "${pluginsDir}"
> +}
> +}
> +
> // == Clean up tasks ==
> task cleanCatalina(group: cleanupGroup, description: 'Clean Catalina data in
> runtime/catalina/work') {
> doLast { delete "${rootDir}/runtime/catalina/work" }
> {code}
> The doc is here
> https://github.com/martoe/gradle-svntools-plugin/blob/master/docs/SvnUpdate.md
> https://github.com/martoe/gradle-svntools-plugin/blob/master/src/main/groovy/at/bxm/gradleplugins/svntools/tasks/SvnUpdate.groovy
> BTW somehow related there is no Gradle svn plugin way to get the status. So
> you have to move to the plugins directory. A bit tedious, I propose a
> pluginsStatus.bat script for that (could be in tools but I'll move it in
> another branch)
> {code}
> @echo off
> cd plugins
> svn st
> cd ..
> {code}
> If we agree I can add the same pluginsStatus.sh
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Comment Edited] (OFBIZ-9275) Add a Gradle task to svn update all plugins
[
https://issues.apache.org/jira/browse/OFBIZ-9275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15965634#comment-15965634
]
Jacques Le Roux edited comment on OFBIZ-9275 at 4/12/17 10:02 AM:
--
I tried that, it did not work and I forgot to remove it so was committed and I
removed just after at
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/build.gradle?r1=1790945=1790944=1790945
was (Author: jacques.le.roux):
I tried that and forgot to remove it so was committed and I removed just after
at
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/build.gradle?r1=1790945=1790944=1790945
> Add a Gradle task to svn update all plugins
> ---
>
> Key: OFBIZ-9275
> URL: https://issues.apache.org/jira/browse/OFBIZ-9275
> Project: OFBiz
> Issue Type: Improvement
> Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Release
>
>
> When you svn update the framework, unlike for svn:externals, it does not
> update the plugins because it's an embedded working copy. So I have tried
> that w/o success so far:
> {code}
> Index: build.gradle
> ===
> --- build.gradle (revision 1788020)
> +++ build.gradle (working copy)
> @@ -17,6 +17,7 @@
> * under the License.
> */
> import at.bxm.gradleplugins.svntools.tasks.SvnCheckout
> +import at.bxm.gradleplugins.svntools.tasks.SvnUpdate
> import org.apache.tools.ant.filters.ReplaceTokens
> /*
> @@ -774,6 +775,14 @@
> }
> }
> +task updateAllPluginsSource(group: ofbizPlugin,
> +description: 'Update all plugins from source control.') {
> +
> +task updatePluginsFromSvn(type: SvnUpdate) {
> +workspaceDir = "${pluginsDir}"
> +}
> +}
> +
> // == Clean up tasks ==
> task cleanCatalina(group: cleanupGroup, description: 'Clean Catalina data in
> runtime/catalina/work') {
> doLast { delete "${rootDir}/runtime/catalina/work" }
> {code}
> The doc is here
> https://github.com/martoe/gradle-svntools-plugin/blob/master/docs/SvnUpdate.md
> https://github.com/martoe/gradle-svntools-plugin/blob/master/src/main/groovy/at/bxm/gradleplugins/svntools/tasks/SvnUpdate.groovy
> BTW somehow related there is no Gradle svn plugin way to get the status. So
> you have to move to the plugins directory. A bit tedious, I propose a
> pluginsStatus.bat script for that (could be in tools but I'll move it in
> another branch)
> {code}
> @echo off
> cd plugins
> svn st
> cd ..
> {code}
> If we agree I can add the same pluginsStatus.sh
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Closed] (OFBIZ-9312) The header show only the userId in at least the Flat Grey theme for the Birt, BI and example components
[ https://issues.apache.org/jira/browse/OFBIZ-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-9312. -- Resolution: Fixed Assignee: Jacques Le Roux > The header show only the userId in at least the Flat Grey theme for the Birt, > BI and example components > --- > > Key: OFBIZ-9312 > URL: https://issues.apache.org/jira/browse/OFBIZ-9312 > Project: OFBiz > Issue Type: Bug > Components: bi, birt, example, exampleext >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > > When using the Tomahawk theme I see "THE PRIVILEGED ADMINISTRATOR" in the > header for the Birt, BI, the example and examplext components. > But in FlatGrey (did not check other themes) it's only "admin" -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (OFBIZ-9273) The createTenant Gradle task fails
[
https://issues.apache.org/jira/browse/OFBIZ-9273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-9273.
--
Resolution: Fixed
Fix Version/s: Release Branch 16.11
Thanks Swapnil
Your patch is in
trunk r1791143
R16.11 r1791144
> The createTenant Gradle task fails
> --
>
> Key: OFBIZ-9273
> URL: https://issues.apache.org/jira/browse/OFBIZ-9273
> Project: OFBiz
> Issue Type: Bug
> Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
> Fix For: Upcoming Release, Release Branch 16.11
>
> Attachments: OFBIZ-9273.patch
>
>
> When you enter
> bq. gradlew createTenant -PtenantId=test
> you get
> {code}
> FAILURE: Build failed with an exception.
> * Where:
> Build file 'C:\projectsASF\ofbiz-framework\build.gradle' line: 764
> * What went wrong:
> A problem occurred evaluating root project 'ofbiz'.
> > Could not get unknown property 'pluginId' for task ':installAllPlugins' of
> > type org.gradle.api.DefaultTask.
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Closed] (OFBIZ-9311) The help button or link does not show for the Birt, BI and example components
[ https://issues.apache.org/jira/browse/OFBIZ-9311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-9311. -- Resolution: Fixed Assignee: Jacques Le Roux Fix Version/s: Release Branch 14.12 Release Branch 15.12 16.11.02 Upcoming Release Pricat was also concerned the GlobalDecorator was used instead of the ApplicationDecorator Fixed in trunk r1791116 R16.11 r1791119 R15.12 r1791120 R14.12 r1791121 > The help button or link does not show for the Birt, BI and example components > - > > Key: OFBIZ-9311 > URL: https://issues.apache.org/jira/browse/OFBIZ-9311 > Project: OFBiz > Issue Type: Bug > Components: bi, birt, example, exampleext >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux > Fix For: Upcoming Release, 16.11.02, Release Branch 15.12, > Release Branch 14.12 > > > The Birt component the BI, the example and examplext components don't show > the help button or link (depending on themes) in the header. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9273) The createTenant Gradle task fails
[
https://issues.apache.org/jira/browse/OFBIZ-9273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966405#comment-15966405
]
Jacques Le Roux commented on OFBIZ-9273:
OK Taher, since you did not answer clearly in dev ML, please comment about
bq. The fix is wrong, and you committed without understanding the root cause of
the problem (which you created).
What did I create?
> The createTenant Gradle task fails
> --
>
> Key: OFBIZ-9273
> URL: https://issues.apache.org/jira/browse/OFBIZ-9273
> Project: OFBiz
> Issue Type: Bug
> Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
> Fix For: Upcoming Release, Release Branch 16.11
>
> Attachments: OFBIZ-9273.patch
>
>
> When you enter
> bq. gradlew createTenant -PtenantId=test
> you get
> {code}
> FAILURE: Build failed with an exception.
> * Where:
> Build file 'C:\projectsASF\ofbiz-framework\build.gradle' line: 764
> * What went wrong:
> A problem occurred evaluating root project 'ofbiz'.
> > Could not get unknown property 'pluginId' for task ':installAllPlugins' of
> > type org.gradle.api.DefaultTask.
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OFBIZ-9273) The createTenant Gradle task fails
[
https://issues.apache.org/jira/browse/OFBIZ-9273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966415#comment-15966415
]
Jacques Le Roux commented on OFBIZ-9273:
Taher,
Sorry we crossed on wire.
For me all the related code was committed by you for OFBIZ-9182
http://ofbiz.markmail.org/search/?q=dependsOn+%22%3Aplugins%3A%24%7BpluginId%7D%3Ainstall%22
Since this issue was random, and looking at your code, I'm not against
reverting. But please explain the issue you said I created and where?
> The createTenant Gradle task fails
> --
>
> Key: OFBIZ-9273
> URL: https://issues.apache.org/jira/browse/OFBIZ-9273
> Project: OFBiz
> Issue Type: Bug
> Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
> Fix For: Upcoming Release, Release Branch 16.11
>
> Attachments: OFBIZ-9273.patch
>
>
> When you enter
> bq. gradlew createTenant -PtenantId=test
> you get
> {code}
> FAILURE: Build failed with an exception.
> * Where:
> Build file 'C:\projectsASF\ofbiz-framework\build.gradle' line: 764
> * What went wrong:
> A problem occurred evaluating root project 'ofbiz'.
> > Could not get unknown property 'pluginId' for task ':installAllPlugins' of
> > type org.gradle.api.DefaultTask.
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OFBIZ-9273) The createTenant Gradle task fails
[
https://issues.apache.org/jira/browse/OFBIZ-9273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966260#comment-15966260
]
Jacques Le Roux commented on OFBIZ-9273:
I Reverted: r1791144
I was totally wrong to backport, R16.11 branch does not contain this issue.
> The createTenant Gradle task fails
> --
>
> Key: OFBIZ-9273
> URL: https://issues.apache.org/jira/browse/OFBIZ-9273
> Project: OFBiz
> Issue Type: Bug
> Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
> Fix For: Upcoming Release, Release Branch 16.11
>
> Attachments: OFBIZ-9273.patch
>
>
> When you enter
> bq. gradlew createTenant -PtenantId=test
> you get
> {code}
> FAILURE: Build failed with an exception.
> * Where:
> Build file 'C:\projectsASF\ofbiz-framework\build.gradle' line: 764
> * What went wrong:
> A problem occurred evaluating root project 'ofbiz'.
> > Could not get unknown property 'pluginId' for task ':installAllPlugins' of
> > type org.gradle.api.DefaultTask.
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OFBIZ-9273) The createTenant Gradle task fails
[
https://issues.apache.org/jira/browse/OFBIZ-9273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966263#comment-15966263
]
Jacques Le Roux commented on OFBIZ-9273:
[~taher] you sent a message in dev ML, I answered, please continue there, thanks
> The createTenant Gradle task fails
> --
>
> Key: OFBIZ-9273
> URL: https://issues.apache.org/jira/browse/OFBIZ-9273
> Project: OFBiz
> Issue Type: Bug
> Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
> Fix For: Upcoming Release, Release Branch 16.11
>
> Attachments: OFBIZ-9273.patch
>
>
> When you enter
> bq. gradlew createTenant -PtenantId=test
> you get
> {code}
> FAILURE: Build failed with an exception.
> * Where:
> Build file 'C:\projectsASF\ofbiz-framework\build.gradle' line: 764
> * What went wrong:
> A problem occurred evaluating root project 'ofbiz'.
> > Could not get unknown property 'pluginId' for task ':installAllPlugins' of
> > type org.gradle.api.DefaultTask.
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Created] (OFBIZ-9306) Check there are no white spaces in the name of a form field when updating a form
Jacques Le Roux created OFBIZ-9306: -- Summary: Check there are no white spaces in the name of a form field when updating a form Key: OFBIZ-9306 URL: https://issues.apache.org/jira/browse/OFBIZ-9306 Project: OFBiz Issue Type: Improvement Components: ALL APPLICATIONS Affects Versions: Trunk Reporter: Jacques Le Roux Priority: Minor Fix For: Upcoming Release Sometimes ago, I lost an hour because of a space at the end of a field's name in a form. In creation it does not pass (the field lacks) but when updating the form it passes and it's hard to find from where comes the problem. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OFBIZ-9305) change debug.properties property value cause ofbiz can't start
[
https://issues.apache.org/jira/browse/OFBIZ-9305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-9305:
---
Description:
change apache-ofbiz-16.11.01\framework\base\config\debug.properties
print.verbose=false to print.verbose=true
restart ofbiz with command line:gradlew.bat ofbiz get error happend;
{code}
org.apache.ofbiz.base.util.UtilCodecTests > testCheckStringForHtmlStrictNone
STANDARD_OUT
11:07:31.743 [Test worker] ERROR org.apache.ofbiz.base.util.UtilCodec -
Canonicalization (format consistency, character escaping that is mixed or
double, etc) error for attribute named [double-encoding], String
[%2%353Cscript]: org.apache.ofbiz.base.util.UtilCodec$IntrusionException: Input
validation failure
org.apache.ofbiz.entity.util.EntitySaxReaderTests > parse STANDARD_OUT
11:07:42.509 [Test worker] ERROR
org.apache.ofbiz.entity.util.EntitySaxReader - An error occurred saving the
data, rolling back transaction (true)
java.lang.NullPointerException
at
org.apache.ofbiz.entity.util.EntitySaxReader.endElement(EntitySaxReader.java:404)
~[main/:?]
at org.apache.xerces.parsers.AbstractSAXParser.endElement(Unknown
Source) ~[xercesImpl-2.9.1.jar:?]
at
org.apache.xerces.parsers.AbstractXMLDocumentParser.emptyElement(Unknown
Source) ~[xercesImpl-2.9.1.jar:?]
at
org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanStartElement(Unknown
Source) ~[xercesImpl-2.9.1.jar:?]
at
org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown
Source) ~[xercesImpl-2.9.1.jar:?]
at
org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown
Source) ~[xercesImpl-2.9.1.jar:?]
at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
~[xercesImpl-2.9.1.jar:?]
at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
~[xercesImpl-2.9.1.jar:?]
at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
~[xercesImpl-2.9.1.jar:?]
at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown Source)
~[xercesImpl-2.9.1.jar:?]
at org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown
Source) ~[xercesImpl-2.9.1.jar:?]
at org.apache.xerces.jaxp.SAXParserImpl.parse(Unknown Source)
~[xercesImpl-2.9.1.jar:?]
at javax.xml.parsers.SAXParser.parse(SAXParser.java:195) ~[?:1.8.0_121]
at
org.apache.ofbiz.entity.util.EntitySaxReader.parse(EntitySaxReader.java:225)
[main/:?]
at
org.apache.ofbiz.entity.util.EntitySaxReader.parse(EntitySaxReader.java:186)
[main/:?]
at
org.apache.ofbiz.entity.util.EntitySaxReaderTests.parse(EntitySaxReaderTests.java:62)
[test/:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
~[?:1.8.0_121]
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
~[?:1.8.0_121]
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
~[?:1.8.0_121]
at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_121]
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
[junit-dep-4.10.jar:?]
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
[junit-dep-4.10.jar:?]
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
[junit-dep-4.10.jar:?]
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
[junit-dep-4.10.jar:?]
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263)
[junit-dep-4.10.jar:?]
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68)
[junit-dep-4.10.jar:?]
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47)
[junit-dep-4.10.jar:?]
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
[junit-dep-4.10.jar:?]
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
[junit-dep-4.10.jar:?]
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229)
[junit-dep-4.10.jar:?]
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50)
[junit-dep-4.10.jar:?]
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222)
[junit-dep-4.10.jar:?]
at org.junit.runners.ParentRunner.run(ParentRunner.java:300)
[junit-dep-4.10.jar:?]
at
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:112)
[gradle-testing-jvm-2.13.jar:2.13]
at
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:56)
[gradle-testing-jvm-2.13.jar:2.13]
at
[jira] [Commented] (OFBIZ-8343) Make data type field length of id fields accept guid ids
[ https://issues.apache.org/jira/browse/OFBIZ-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15958675#comment-15958675 ] Jacques Le Roux commented on OFBIZ-8343: Also I recommend to consider OFBIZ-5648 in such situations, see https://s.apache.org/VHn6 for a bit more explanation. I second Michael for closing. > Make data type field length of id fields accept guid ids > > > Key: OFBIZ-8343 > URL: https://issues.apache.org/jira/browse/OFBIZ-8343 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits > Attachments: OFBIZ-8343-fieldtype-36.patch, OFBIZ-8343-fieldtype.patch > > > Currently the length of id fields is limited to 20 characters. In order for > these fields to accept GUIIDs the length should be increased to 32 characters. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Comment Edited] (OFBIZ-9302) logout security
[ https://issues.apache.org/jira/browse/OFBIZ-9302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15958623#comment-15958623 ] Jacques Le Roux edited comment on OFBIZ-9302 at 4/6/17 10:19 AM: - OK, for the difference between browsers, it depends on your setting. Mine in Chrome included removing cookies, I guess for the domain because nothing was left it seems, I did not check deeper. But other browsers were only cache, not cookies. Anyway, we have session cookies by web application. I guess we are only removing the cookie of the current application when login out. We could remove them for all applications. I'm not yet quite sure about that, did not look at the code yet... was (Author: jacques.le.roux): OK, for the difference between browsers, it depends on your setting. Mine in Chrome included removing cookies, I guess for the domain because nothing was let it seems, I did not check deeper. But other browsers were only cache, not cookies. Anyway, we have session cookies by web application. I guess we are only removing the cookie of the current application when login out. We could remove them for all applications. I'm not yet quite sure about that, did not look at the code yet... > logout security > --- > > Key: OFBIZ-9302 > URL: https://issues.apache.org/jira/browse/OFBIZ-9302 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Release Branch 16.11 >Reporter: Moatasim Al Masri > Attachments: logout2.wmv, logout.wmv > > > am trying to check OFBIZ security authentication, and I found when we > logedout the session still open in browser, that if we press back from > browser we can reopen the session and continue see our application without > any authentication. > please see the video attached : logout.wmv -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (OFBIZ-9312) The header show only the userId in at least the Flat Grey theme for the Birt, BI and example components
Jacques Le Roux created OFBIZ-9312: -- Summary: The header show only the userId in at least the Flat Grey theme for the Birt, BI and example components Key: OFBIZ-9312 URL: https://issues.apache.org/jira/browse/OFBIZ-9312 Project: OFBiz Issue Type: Bug Components: bi, birt, example, exampleext Reporter: Jacques Le Roux Priority: Minor When using the Tomahawk theme I see "THE PRIVILEGED ADMINISTRATOR" in the header for the Birt, BI, the example and examplext components. But in FlatGrey (did not check other themes) it's only "admin" -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (OFBIZ-9309) Ecommerce component showing error screen on searchContent from showcontenttree page
[ https://issues.apache.org/jira/browse/OFBIZ-9309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-9309: -- Assignee: Jacques Le Roux (was: Aditya Sharma) > Ecommerce component showing error screen on searchContent from > showcontenttree page > --- > > Key: OFBIZ-9309 > URL: https://issues.apache.org/jira/browse/OFBIZ-9309 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Reporter: Aditya Sharma >Assignee: Jacques Le Roux > Attachments: OFBIZ-9309.patch, screenshot-1.png, > screenshot-2-whenNoIndex.png > > > Steps to reproduce: > 1.Go to Ecommerce component (https://localhost:8443/ecommerce/control/main) > 2.Click on any of the Content from "Browse Content" section of left panel.It > will be directed to > https://localhost:8443/ecommerce/control/showcontenttree?contentId=STORE_POLICIES=STORE_POLICIES > 3. Click on Search, it directs to > https://localhost:8443/ecommerce/control/searchContent?siteId=STORE_POLICIES > 4. Screen renders with ScreenRenderingException -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (OFBIZ-9309) Ecommerce component showing error screen on searchContent from showcontenttree page
[ https://issues.apache.org/jira/browse/OFBIZ-9309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-9309. -- Resolution: Fixed Fix Version/s: 16.11.02 Upcoming Release Thanks Aditya, Your patch is in trunk r1790810 R16.11 r1790811 (handled by hand) I must say here that your descriptions and comments in Jira are exemplary and we could refer to them as how it should be done! Thanks! > Ecommerce component showing error screen on searchContent from > showcontenttree page > --- > > Key: OFBIZ-9309 > URL: https://issues.apache.org/jira/browse/OFBIZ-9309 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Reporter: Aditya Sharma >Assignee: Jacques Le Roux > Fix For: Upcoming Release, 16.11.02 > > Attachments: OFBIZ-9309.patch, screenshot-1.png, > screenshot-2-whenNoIndex.png > > > Steps to reproduce: > 1.Go to Ecommerce component (https://localhost:8443/ecommerce/control/main) > 2.Click on any of the Content from "Browse Content" section of left panel.It > will be directed to > https://localhost:8443/ecommerce/control/showcontenttree?contentId=STORE_POLICIES=STORE_POLICIES > 3. Click on Search, it directs to > https://localhost:8443/ecommerce/control/searchContent?siteId=STORE_POLICIES > 4. Screen renders with ScreenRenderingException -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (OFBIZ-9308) CMS shows error screen on Product Search
[ https://issues.apache.org/jira/browse/OFBIZ-9308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-9308. -- Resolution: Fixed Fix Version/s: Upcoming Release Thanks Aditya Your patch is in at revision: 1790933. No problems in releases branches > CMS shows error screen on Product Search > > > Key: OFBIZ-9308 > URL: https://issues.apache.org/jira/browse/OFBIZ-9308 > Project: OFBiz > Issue Type: Bug > Components: content >Reporter: Aditya Sharma >Assignee: Jacques Le Roux > Fix For: Upcoming Release > > Attachments: OFBIZ-9308.patch, screenshot-1.png > > > Steps to regenerate: > 1. Go to Content component (https://localhost:8443/content/control/main) > 2. Click on CMS tab (directing to > https://localhost:8443/content/control/CMSContentFind) > 3. Click on Search Products subtab (directing to > https://localhost:8443/content/control/ProductSearch) > 4. Provide a Lucene Query and Click submit. > 5. Screen renders with ScreenRenderingException -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (OFBIZ-9308) CMS shows error screen on Product Search
[ https://issues.apache.org/jira/browse/OFBIZ-9308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-9308: -- Assignee: Jacques Le Roux (was: Aditya Sharma) > CMS shows error screen on Product Search > > > Key: OFBIZ-9308 > URL: https://issues.apache.org/jira/browse/OFBIZ-9308 > Project: OFBiz > Issue Type: Bug > Components: content >Reporter: Aditya Sharma >Assignee: Jacques Le Roux > Attachments: OFBIZ-9308.patch, screenshot-1.png > > > Steps to regenerate: > 1. Go to Content component (https://localhost:8443/content/control/main) > 2. Click on CMS tab (directing to > https://localhost:8443/content/control/CMSContentFind) > 3. Click on Search Products subtab (directing to > https://localhost:8443/content/control/ProductSearch) > 4. Provide a Lucene Query and Click submit. > 5. Screen renders with ScreenRenderingException -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1
[ https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15962058#comment-15962058 ] Jacques Le Roux commented on OFBIZ-8316: (y) > Update Apache Solr/Lucene to release 6.2.1 > -- > > Key: OFBIZ-8316 > URL: https://issues.apache.org/jira/browse/OFBIZ-8316 > Project: OFBiz > Issue Type: Improvement > Components: lucene, solr >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Shi Jinghai >Priority: Minor > Attachments: OFBIZ-8316_corrected.patch, > ofbiz-truck-lucene-6.2.1.patch, ofbiz-truck-solr-6.2.1.patch, > solr6.2.1_1.patch > > > According to the announcements in > https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E > and > https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E > there is a new Solr/Lucene release available. > This issue takes care of the update. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (OFBIZ-9313) Update Tomcat to 8.0.42 because of CVE-2017-5648
Jacques Le Roux created OFBIZ-9313:
--
Summary: Update Tomcat to 8.0.42 because of CVE-2017-5648
Key: OFBIZ-9313
URL: https://issues.apache.org/jira/browse/OFBIZ-9313
Project: OFBiz
Issue Type: Sub-task
Components: framework
Affects Versions: Release Branch 16.11, Trunk
Reporter: Jacques Le Roux
Priority: Trivial
Quoting a message from annou...@apache.org
{quote}
VE-2017-5648 Apache Tomcat Information Disclosure
Severity: Low
Vendor: The Apache Software Foundation
Versions Affected:
Apache Tomcat 9.0.0.M1 to 9.0.0.M17
Apache Tomcat 8.5.0 to 8.5.11
Apache Tomcat 8.0.0.RC1 to 8.0.41
Apache Tomcat 7.0.0 to 7.0.75
Apache Tomcat 6.0.x is not affected
Description
While investigating bug 60718, it was noticed that some calls to
application listeners did not use the appropriate facade object. When
running an untrusted application under a SecurityManager, it was
therefore possible for that untrusted application to retain a reference
to the request or response object and thereby access and/or modify
information associated with another web application.
Mitigation:
Users of the affected versions should apply one of the following
mitigations:
- Upgrade to Apache Tomcat 9.0.0.M18 or later
- Upgrade to Apache Tomcat 8.5.12 or later
- Upgrade to Apache Tomcat 8.0.42 or later
- Upgrade to Apache Tomcat 7.0.76 or later
Credit:
This issue was identified by the Tomcat security team.
History:
2017-04-10 Original advisory
References:
[1] https://bz.apache.org/bugzilla/show_bug.cgi?id=60718
[2] http://tomcat.apache.org/security-9.html
[3] http://tomcat.apache.org/security-8.html
[4] http://tomcat.apache.org/security-7.html
{quote}
It's a low security issue so I'll not backport on no longer or not released
branches
All tests pass and UI seems OK.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OFBIZ-9233) Enable a service to run by a specific service engine
[
https://issues.apache.org/jira/browse/OFBIZ-9233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964360#comment-15964360
]
Jacques Le Roux commented on OFBIZ-9233:
Hi Jinghai,
I began to review and decided to apply on trunk for easier review and test, but
stumbled upon an issue. This hunk, and only this one, does not apply
{code}
@@ -371,163 +372,165 @@
}
public static Map purgeOldJobs(DispatchContext dctx,
Map context) {
-Locale locale = (Locale)context.get("locale");
+Locale locale = (Locale)context.get("locale");
Debug.logWarning("purgeOldJobs service invoked. This service is
obsolete - the Job Scheduler will purge old jobs automatically.", module);
String sendPool = null;
-Calendar cal = Calendar.getInstance();
try {
-sendPool =
ServiceConfigUtil.getServiceEngine().getThreadPool().getSendToPool();
-int daysToKeep =
ServiceConfigUtil.getServiceEngine().getThreadPool().getPurgeJobDays();
-cal.add(Calendar.DAY_OF_YEAR, -daysToKeep);
-} catch (GenericConfigException e) {
-Debug.logWarning(e, "Exception thrown while getting service
configuration: ", module);
-return returnError(UtilProperties.getMessage(ServiceUtil.resource,
"ServiceExceptionThrownWhileGettingServiceConfiguration",
UtilMisc.toMap("errorString", e), locale));
-}
-Delegator delegator = dctx.getDelegator();
+for (ServiceEngine engine :
ServiceConfigUtil.getServiceConfig().getServiceEngines()) {
+Calendar cal = Calendar.getInstance();
+sendPool = engine.getThreadPool().getSendToPool();
+int daysToKeep = engine.getThreadPool().getPurgeJobDays();
+cal.add(Calendar.DAY_OF_YEAR, -daysToKeep);
+Delegator delegator = dctx.getDelegator();
-Timestamp purgeTime = new Timestamp(cal.getTimeInMillis());
+Timestamp purgeTime = new Timestamp(cal.getTimeInMillis());
-// create the conditions to query
-EntityCondition pool = EntityCondition.makeCondition("poolId",
sendPool);
+// create the conditions to query
+EntityCondition pool = EntityCondition.makeCondition("poolId",
sendPool);
-List finExp =
UtilMisc.toList(EntityCondition.makeCondition("finishDateTime",
EntityOperator.NOT_EQUAL, null));
-finExp.add(EntityCondition.makeCondition("finishDateTime",
EntityOperator.LESS_THAN, purgeTime));
+List finExp =
UtilMisc.toList(EntityCondition.makeCondition("finishDateTime",
EntityOperator.NOT_EQUAL, null));
+finExp.add(EntityCondition.makeCondition("finishDateTime",
EntityOperator.LESS_THAN, purgeTime));
-List canExp =
UtilMisc.toList(EntityCondition.makeCondition("cancelDateTime",
EntityOperator.NOT_EQUAL, null));
-canExp.add(EntityCondition.makeCondition("cancelDateTime",
EntityOperator.LESS_THAN, purgeTime));
+List canExp =
UtilMisc.toList(EntityCondition.makeCondition("cancelDateTime",
EntityOperator.NOT_EQUAL, null));
+canExp.add(EntityCondition.makeCondition("cancelDateTime",
EntityOperator.LESS_THAN, purgeTime));
-EntityCondition cancelled = EntityCondition.makeCondition(canExp);
-EntityCondition finished = EntityCondition.makeCondition(finExp);
+EntityCondition cancelled =
EntityCondition.makeCondition(canExp);
+EntityCondition finished =
EntityCondition.makeCondition(finExp);
-EntityCondition doneCond =
EntityCondition.makeCondition(UtilMisc.toList(cancelled, finished),
EntityOperator.OR);
+EntityCondition doneCond =
EntityCondition.makeCondition(UtilMisc.toList(cancelled, finished),
EntityOperator.OR);
-// always suspend the current transaction; use the one internally
-Transaction parent = null;
-try {
-if (TransactionUtil.getStatus() !=
TransactionUtil.STATUS_NO_TRANSACTION) {
-parent = TransactionUtil.suspend();
-}
-
-// lookup the jobs - looping 1000 at a time to avoid problems with
cursors
-// also, using unique transaction to delete as many as possible
even with errors
-boolean noMoreResults = false;
-boolean beganTx1 = false;
-while (!noMoreResults) {
-// current list of records
-List curList = null;
+// always suspend the current transaction; use the one
internally
+Transaction parent = null;
try {
-// begin this transaction
-beganTx1 = TransactionUtil.begin();
+if (TransactionUtil.getStatus() !=
TransactionUtil.STATUS_NO_TRANSACTION) {
+
[jira] [Commented] (OFBIZ-7012) VAT tax are not recorded as separate line items in Invoice for products with VAT tax included in their price
[
https://issues.apache.org/jira/browse/OFBIZ-7012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15969847#comment-15969847
]
Jacques Le Roux commented on OFBIZ-7012:
Should we wait or rather create another ticket?
> VAT tax are not recorded as separate line items in Invoice for products with
> VAT tax included in their price
>
>
> Key: OFBIZ-7012
> URL: https://issues.apache.org/jira/browse/OFBIZ-7012
> Project: OFBiz
> Issue Type: New Feature
> Components: accounting, order
>Reporter: Divesh Dutta
>Assignee: Divesh Dutta
> Attachments: OFBIZ-7012.patch
>
>
> In countries like UK VAT system works. So in VAT system, VAT taxes are
> included in product's price. So OFBiz have support of VAT tax where you can
> include VAT in product's price itself. Here is the example data we create to
> enable VAT calculations:
> {code}
>
>
>
>
>
>
> taxAuthGeoId="GBR" taxAuthPartyId="GB_TA"/>
>
> productStoreId="9000" taxAuthGeoId="GBR" taxAuthPartyId="GB_TA"
> taxAuthorityRateTypeId="VAT_TAX" taxPercentage="20.00" />
> productPricePurposeId="PURCHASE" productPriceTypeId="DEFAULT_PRICE"
> productStoreGroupId="_NA_" taxAuthGeoId="GBR" taxAuthPartyId="GB_TA"
> taxInPrice="Y" />
> {code}
> When invoices are created, tax amount included in product's price is not
> separated in new invoice line item. And when general ledger postings are
> done, then tax amount is not posted in Liability account. So due to this
> organizations have no way to figure out how much tax is to be paid to tax
> authority.
> Ideally, product's actual price (without VAT) should be recorded in revenue
> account and tax should be recorded in liability account.
> For doing this, when invoice is created, VAT amount should be separated and
> created as new line item.
> Recently we have worked for one of our client where we have fixed this issue
> and enabled invoicing in OFBiz to record vat tax amount as separate line
> items. [~lektran] has actively worked with us to finalize the solution design
> and completing the implementation. [~ankush.upadhyay] is the developer who
> worked on solution design. [~ankush.upadhyay] please provide the patch for
> this issue.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Issue Comment Deleted] (OFBIZ-7335) Production run party assignment's thruDate should be editable
[ https://issues.apache.org/jira/browse/OFBIZ-7335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-7335: --- Comment: was deleted (was: As I was traveling yesterday, I didn't have the opportunity to do a search/find on the related issues and list them here. These issues are: * OFBIZ-5705 * OFBIZ-5851 * OFBIZ-5852 * OFBIZ-6097) > Production run party assignment's thruDate should be editable > - > > Key: OFBIZ-7335 > URL: https://issues.apache.org/jira/browse/OFBIZ-7335 > Project: OFBiz > Issue Type: Improvement > Components: manufacturing >Affects Versions: Trunk >Reporter: Amardeep Singh Jhajj >Assignee: Amardeep Singh Jhajj > Attachments: OFBIZ-7335.patch > > > Currently, we don't have support to set thruDate for production run party > assignment. So, there should be a support of setting the thruDate if needed. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-7522) Hide user inputs for Location/Lot# for fully issued components against production run task
[ https://issues.apache.org/jira/browse/OFBIZ-7522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15969845#comment-15969845 ] Jacques Le Roux commented on OFBIZ-7522: Should we not close here? > Hide user inputs for Location/Lot# for fully issued components against > production run task > -- > > Key: OFBIZ-7522 > URL: https://issues.apache.org/jira/browse/OFBIZ-7522 > Project: OFBiz > Issue Type: Improvement > Components: manufacturing >Affects Versions: 14.12.01, 15.12.01 >Reporter: Swapnil Shah >Assignee: Anuj Jain >Priority: Minor > Attachments: OFBIZ-7522-A.patch, OFBIZ-7522.patch, PR_1.png > > > Once any component item gets fully issued then also we allow user to enter > the location/lot# etc. under 'Materials Required By The Running Task' panel, > like we do for un-issued or partially issued components. > We can possible hide user selection and text entry against such fully issued > items and show it only if remaining to be issued qty > 0 > Please refer to attached screenshot for reference. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-7385) Allow user to select multiple options in "Sales By Store" report from basic search criteria while generating report
[ https://issues.apache.org/jira/browse/OFBIZ-7385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15969846#comment-15969846 ] Jacques Le Roux commented on OFBIZ-7385: What is the status here? > Allow user to select multiple options in "Sales By Store" report from basic > search criteria while generating report > --- > > Key: OFBIZ-7385 > URL: https://issues.apache.org/jira/browse/OFBIZ-7385 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: 16.11.01 >Reporter: Swapnil Shah >Assignee: Mohammad Kathawala > Attachments: OFBIZ-7385.patch, Salebystore.png > > > Currently system allow user to select any specific search criteria link and > hence report is generated only based on any one given selected criteria. > We can add the feature for generating single report based on multiple values > (possibly via checkbox?) within basic search criteria in this report namely: > 1) Product Store > 2) Order Status > and show the results based on all the selected values. Please refer attached > screenshot -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-7012) VAT tax are not recorded as separate line items in Invoice for products with VAT tax included in their price
[
https://issues.apache.org/jira/browse/OFBIZ-7012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15969850#comment-15969850
]
Jacques Le Roux commented on OFBIZ-7012:
For instance a subtask OFBIZ-1463 ;)
> VAT tax are not recorded as separate line items in Invoice for products with
> VAT tax included in their price
>
>
> Key: OFBIZ-7012
> URL: https://issues.apache.org/jira/browse/OFBIZ-7012
> Project: OFBiz
> Issue Type: New Feature
> Components: accounting, order
>Reporter: Divesh Dutta
>Assignee: Divesh Dutta
> Attachments: OFBIZ-7012.patch
>
>
> In countries like UK VAT system works. So in VAT system, VAT taxes are
> included in product's price. So OFBiz have support of VAT tax where you can
> include VAT in product's price itself. Here is the example data we create to
> enable VAT calculations:
> {code}
>
>
>
>
>
>
> taxAuthGeoId="GBR" taxAuthPartyId="GB_TA"/>
>
> productStoreId="9000" taxAuthGeoId="GBR" taxAuthPartyId="GB_TA"
> taxAuthorityRateTypeId="VAT_TAX" taxPercentage="20.00" />
> productPricePurposeId="PURCHASE" productPriceTypeId="DEFAULT_PRICE"
> productStoreGroupId="_NA_" taxAuthGeoId="GBR" taxAuthPartyId="GB_TA"
> taxInPrice="Y" />
> {code}
> When invoices are created, tax amount included in product's price is not
> separated in new invoice line item. And when general ledger postings are
> done, then tax amount is not posted in Liability account. So due to this
> organizations have no way to figure out how much tax is to be paid to tax
> authority.
> Ideally, product's actual price (without VAT) should be recorded in revenue
> account and tax should be recorded in liability account.
> For doing this, when invoice is created, VAT amount should be separated and
> created as new line item.
> Recently we have worked for one of our client where we have fixed this issue
> and enabled invoicing in OFBiz to record vat tax amount as separate line
> items. [~lektran] has actively worked with us to finalize the solution design
> and completing the implementation. [~ankush.upadhyay] is the developer who
> worked on solution design. [~ankush.upadhyay] please provide the patch for
> this issue.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Comment Edited] (OFBIZ-7121) get-related-one element was not defined in file widget-form.xsd
[ https://issues.apache.org/jira/browse/OFBIZ-7121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15970510#comment-15970510 ] Jacques Le Roux edited comment on OFBIZ-7121 at 4/16/17 9:01 PM: - Dalater was right, there is not widget-common.xsd in R13.07 and it's of course not included in widget.xsd. So I suggest all R13.07 users to update to more recent version R16.11 among them... was (Author: jacques.le.roux): Dalater was right, there is not widget-common.xsd in R13.07 and it's of course not included in widget.xsd. So I suggest all R13.07 to update to more recent version R16.11 among them... > get-related-one element was not defined in file widget-form.xsd > --- > > Key: OFBIZ-7121 > URL: https://issues.apache.org/jira/browse/OFBIZ-7121 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Release Branch 13.07 >Reporter: dalater >Assignee: Jacques Le Roux > > get-related-one element was not defined in file widget-form.xsd -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (OFBIZ-7375) Routing should not be allow to update with empty routing name
[ https://issues.apache.org/jira/browse/OFBIZ-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-7375. -- Resolution: Fixed Fix Version/s: (was: Trunk) Release Branch 13.07 Release Branch 14.12 Release Branch 15.12 16.11.02 Upcoming Release Thanks Ankit, Your patch is in trunk r1791634 R16.11 r1791635 R15.12 r1791636 R14.12 r1791637 R13.07 r1791638 > Routing should not be allow to update with empty routing name > - > > Key: OFBIZ-7375 > URL: https://issues.apache.org/jira/browse/OFBIZ-7375 > Project: OFBiz > Issue Type: Bug > Components: manufacturing >Affects Versions: Trunk >Reporter: Ankit Joshi >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Release, 16.11.02, Release Branch 15.12, > Release Branch 14.12, Release Branch 13.07 > > Attachments: OFBIZ-7375-trunk.patch > > > Steps to regenerate - > 1) Navigate to manufacturing -> Routing > 2) Press New Routing button. > 3) Try to create a routing without entering Routing Name. It will not allowed > to create the record as routing name is mandatory field. > 4) Create routing by adding proper details. > 5) Now, select newly create routing from manufacturing -> Routing > 6) Try to update selected routing with empty Routing Name. > Actual : Routing can be update with empty Routing Name. > Expected : Routing should not allow to update with empty Routing Name. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
