[GH] (pekko): Workflow run "Nightly Builds (1.0)" failed!
The GitHub Actions job "Nightly Builds (1.0)" on pekko.git has failed. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 3fff73894bf339722b2e4d7a4a5491b1de4ca6a9 / scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.noreply.github.com> Update gson to 2.11.0 (#1339) Co-authored-by: scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.noreply.github.com> Report URL: https://github.com/apache/pekko/actions/runs/9231278914 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko-http): Workflow run "Nightly Builds" is working again!
The GitHub Actions job "Nightly Builds" on pekko-http.git has succeeded. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: 9addffe87b9babd7cc55757a5807102869ab923d / scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.noreply.github.com> Update gson to 2.11.0 (#562) Co-authored-by: scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.noreply.github.com> Report URL: https://github.com/apache/pekko-http/actions/runs/9231994767 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko): Workflow run "Nightly Builds" failed!
The GitHub Actions job "Nightly Builds" on pekko.git has failed. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 3fff73894bf339722b2e4d7a4a5491b1de4ca6a9 / scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.noreply.github.com> Update gson to 2.11.0 (#1339) Co-authored-by: scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.noreply.github.com> Report URL: https://github.com/apache/pekko/actions/runs/9231341598 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [D] Only EventSourcedBehavior, or nested EventSourcedBehavior allowed. exception thrown in EventSourcedBehaviorTestKit [pekko]
GitHub user pjfanning added a comment to the discussion: Only EventSourcedBehavior, or nested EventSourcedBehavior allowed. exception thrown in EventSourcedBehaviorTestKit Do you want to make the change suggested in https://github.com/akka/akka/issues/30747#issuecomment-934726706 ? GitHub link: https://github.com/apache/pekko/discussions/1343#discussioncomment-9549967 This is an automatically sent email for notifications@pekko.apache.org. To unsubscribe, please send an email to: notifications-unsubscr...@pekko.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko-connectors): Workflow run "CI" failed!
The GitHub Actions job "CI" on pekko-connectors.git has failed. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: e4f50396d42b2b74fd945e73857d05c73377a792 / PJ Fanning notify CI issues (#668) Report URL: https://github.com/apache/pekko-connectors/actions/runs/9225167558 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] notify CI issues [pekko-connectors]
pjfanning merged PR #668: URL: https://github.com/apache/pekko-connectors/pull/668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] perf: avoid large offset query via limit windowing [pekko-persistence-jdbc]
nvollmar commented on code in PR #180:
URL:
https://github.com/apache/pekko-persistence-jdbc/pull/180#discussion_r1613480943
##
core/src/main/scala/org/apache/pekko/persistence/jdbc/journal/dao/BaseJournalDaoWithReadMessages.scala:
##
@@ -38,13 +38,28 @@ trait BaseJournalDaoWithReadMessages extends
JournalDaoWithReadMessages {
toSequenceNr: Long,
batchSize: Int,
refreshInterval: Option[(FiniteDuration, Scheduler)]):
Source[Try[(PersistentRepr, Long)], NotUsed] = {
+internalBatchStream(persistenceId, fromSequenceNr, toSequenceNr,
batchSize, refreshInterval).mapConcat(identity)
+ }
+ /**
+ * separate this method for unit tests.
+ */
+ @InternalApi
+ private[dao] def internalBatchStream(persistenceId: String,
+ fromSequenceNr: Long,
+ toSequenceNr: Long,
+ batchSize: Int,
+ refreshInterval: Option[(FiniteDuration, Scheduler)]) = {
Review Comment:
it is generally good practice to do input validation to catch failures early
and make constraints explicit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] Avoid unnecessary shard updates while shutting down [pekko]
nvollmar commented on PR #1342: URL: https://github.com/apache/pekko/pull/1342#issuecomment-2129398958 Would be good to have that in 1.0.3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] Avoid unnecessary shard updates while shutting down [pekko]
pjfanning commented on PR #1342: URL: https://github.com/apache/pekko/pull/1342#issuecomment-2129395580 looks sensible to me - let's see what other reviewers say When we get a fix in, we might want to backport it to 1.0.x. I think we should make a 1.0.3 release in the next few weeks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] Avoid unnecessary shard updates while shutting down [pekko]
nvollmar opened a new pull request, #1342: URL: https://github.com/apache/pekko/pull/1342 Refs #1341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[I] With entity passivation enabled the shard region will cause a lot of unhandled ShardsUpdated during shutdown [pekko]
nvollmar opened a new issue, #1341:
URL: https://github.com/apache/pekko/issues/1341
We encounter hundreds of these during a node shutdown
```
unhandled message from
Actor[pekko://main/system/sharding/transactionsAggregates#-1585167465] to
Actor[pekko://main/system/sharding/transactionsAggregates/4#-516417762]:
ShardsUpdated(5)
```
Root cause is to link to link `ShardRegion` sending updates for each
terminated shard when passivation strategy is used:
```
if (settings.passivationStrategy !=
ClusterShardingSettings.NoPassivationStrategy) {
shards.values.foreach(_ ! ShardsUpdated(shards.size))
}
```
See
[here](https://github.com/apache/pekko/blob/3fff73894bf339722b2e4d7a4a5491b1de4ca6a9/cluster-sharding/src/main/scala/org/apache/pekko/cluster/sharding/ShardRegion.scala#L1006)
That message is not handled/ignored by the `Shard` during termination:
```
context.become {
case Terminated(ref) => receiveTerminated(ref)
}
```
See
[here](https://github.com/apache/pekko/blob/3fff73894bf339722b2e4d7a4a5491b1de4ca6a9/cluster-sharding/src/main/scala/org/apache/pekko/cluster/sharding/Shard.scala#L895)
There would be two ways to fix this:
1. At this time the `ShardRegion` property `gracefulShutdownInProgress` is
already set to `true` - check for that in the if and don't send any more
updates
2. During termination in the `Shard` match and ignore the `ShardsUpdated`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko-persistence-jdbc): Workflow run "H2 Unit Tests" failed!
The GitHub Actions job "H2 Unit Tests" on pekko-persistence-jdbc.git has failed. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 17252d7c420f4dcfc7b0bff16255ea5a408cf22d / PJ Fanning notify CI issues (#194) Report URL: https://github.com/apache/pekko-persistence-jdbc/actions/runs/9221315022 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] notify CI issues [pekko-persistence-jdbc]
pjfanning merged PR #194: URL: https://github.com/apache/pekko-persistence-jdbc/pull/194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
