[jira] [Commented] (RYA-501) Guava changed the Iterators api.
[ https://issues.apache.org/jira/browse/RYA-501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634418#comment-16634418 ] ASF GitHub Bot commented on RYA-501: Github user asfgit commented on the issue: https://github.com/apache/incubator-rya/pull/304 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/782/ > Guava changed the Iterators api. > > > Key: RYA-501 > URL: https://issues.apache.org/jira/browse/RYA-501 > Project: Rya > Issue Type: Improvement >Reporter: Andrew Smith >Assignee: Andrew Smith >Priority: Trivial > > Guava changed scope of Iterators.emptyIterator(). > This can cause problems for anything that uses rya as a dependency or if rya > ever upgrades it's guava version. Java now has the Collections api with > emptyIterator. Changing to that will resolve this problem. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] incubator-rya issue #304: RYA-501 Change guava Iterators to Collections
Github user asfgit commented on the issue: https://github.com/apache/incubator-rya/pull/304 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/782/ ---
[GitHub] incubator-rya issue #305: Rya 135 collection name
Github user asfgit commented on the issue: https://github.com/apache/incubator-rya/pull/305 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/781/Build result: FAILURE[...truncated 92.71 MB...][INFO] [INFO] Total time: 01:06 h[INFO] Finished at: 2018-10-01T17:56:20+00:00[INFO] Final Memory: 418M/2808M[INFO] Waiting for Jenkins to finish collecting data[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.2:compile (default-compile) on project rya.kafka.connect.mongo: Compilation failure[ERROR] /home/jenkins/jenkins-slave/workspace/incubator-rya-master-with-optionals-pull-requests/extras/kafka.connect/mongo/src/main/java/org/apache/rya/kafka/connect/mongo/MongoRyaSinkTask.java:[106,18] cannot find symbol[ERROR] symbol: method setMongoDBName(java.lang.String)[ERROR] location: variable ryaConfig of type org.apache.rya.mongodb.MongoDBRdfConfiguration[ERROR] -> [Help 1][ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR] mvn -rf :rya.kafka.connect.mongochannel stoppedSetting status of c7406d70d512334216923eaab6c55ea1f1a568eb to FAILURE with url https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/781/ and message: 'FAILURE 'Using context: Jenkins: clean package -Pgeoindexing ---
[GitHub] incubator-rya issue #305: Rya 135 collection name
Github user asfgit commented on the issue: https://github.com/apache/incubator-rya/pull/305 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/780/ ---
[jira] [Commented] (RYA-501) Guava changed the Iterators api.
[ https://issues.apache.org/jira/browse/RYA-501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634312#comment-16634312 ] ASF GitHub Bot commented on RYA-501: GitHub user isper3at reopened a pull request: https://github.com/apache/incubator-rya/pull/304 RYA-501 Change guava Iterators to Collections ## Description >What Changed? Google changed the Iterators object emptyIterator() visibility. This can cause versioning issues with anything depending on a newer version of guava. Using Java's Collections.emptyIterator() instead. ### Tests >Coverage? N/A ### Links [Jira](https://issues.apache.org/jira/browse/RYA-501) ### Checklist - [ ] Code Review - [x] Squash Commits People To Reivew @ejwhite922 @kchilton2 @pujav65 You can merge this pull request into a Git repository by running: $ git pull https://github.com/isper3at/incubator-rya RYA-501_guavaToJava-4.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rya/pull/304.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #304 commit 93c1d89dafc16d4d50bc4581ec6ada311ca494ae Author: Andrew Smith Date: 2018-09-14T16:37:16Z RYA-501 Change guava Iterators to Collections Google changed the Iterators object emptyIterator() visibility. This can cause versioning issues with anything depending on a newer version of guava. Using Java's Collections.emptyIterator() instead. > Guava changed the Iterators api. > > > Key: RYA-501 > URL: https://issues.apache.org/jira/browse/RYA-501 > Project: Rya > Issue Type: Improvement >Reporter: Andrew Smith >Assignee: Andrew Smith >Priority: Trivial > > Guava changed scope of Iterators.emptyIterator(). > This can cause problems for anything that uses rya as a dependency or if rya > ever upgrades it's guava version. Java now has the Collections api with > emptyIterator. Changing to that will resolve this problem. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] incubator-rya pull request #304: RYA-501 Change guava Iterators to Collectio...
GitHub user isper3at reopened a pull request: https://github.com/apache/incubator-rya/pull/304 RYA-501 Change guava Iterators to Collections ## Description >What Changed? Google changed the Iterators object emptyIterator() visibility. This can cause versioning issues with anything depending on a newer version of guava. Using Java's Collections.emptyIterator() instead. ### Tests >Coverage? N/A ### Links [Jira](https://issues.apache.org/jira/browse/RYA-501) ### Checklist - [ ] Code Review - [x] Squash Commits People To Reivew @ejwhite922 @kchilton2 @pujav65 You can merge this pull request into a Git repository by running: $ git pull https://github.com/isper3at/incubator-rya RYA-501_guavaToJava-4.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rya/pull/304.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #304 commit 93c1d89dafc16d4d50bc4581ec6ada311ca494ae Author: Andrew Smith Date: 2018-09-14T16:37:16Z RYA-501 Change guava Iterators to Collections Google changed the Iterators object emptyIterator() visibility. This can cause versioning issues with anything depending on a newer version of guava. Using Java's Collections.emptyIterator() instead. ---
[GitHub] incubator-rya issue #305: Rya 135 collection name
Github user asfgit commented on the issue: https://github.com/apache/incubator-rya/pull/305 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/779/ ---
[GitHub] incubator-rya pull request #305: Rya 135 collection name
GitHub user isper3at opened a pull request: https://github.com/apache/incubator-rya/pull/305 Rya 135 collection name ## Description >What Changed? Merging existing content into master. Already reviewed and merged into 3.x You can merge this pull request into a Git repository by running: $ git pull https://github.com/isper3at/incubator-rya RYA-135_collectionName Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rya/pull/305.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #305 commit 942d9d62350815a33f28a22f101cdb5c262c70ed Author: Andrew Smith Date: 2018-09-14T16:33:10Z RYA-135 Hard code triples collection There is no need for the triples collection to be configurable, as only the mongo database name will change the rya instance. commit 010f40de276b2152451a42e1c830a2ad88b94860 Author: Andrew Smith Date: 2018-09-14T21:06:27Z Responded to code review removed all references to mongo collection prefix commit 3593c535ddf387d656cde87e793be7bb8980289e Author: Andrew Smith Date: 2018-09-14T22:19:56Z More code review ---
[jira] [Commented] (RYA-135) Confusing configuration: CONF_TBL_PREFIX versus MONGO_COLLECTION_PREFIX versus RyaInstance
[
https://issues.apache.org/jira/browse/RYA-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634171#comment-16634171
]
ASF GitHub Bot commented on RYA-135:
Github user isper3at closed the pull request at:
https://github.com/apache/incubator-rya/pull/300
> Confusing configuration: CONF_TBL_PREFIX versus MONGO_COLLECTION_PREFIX
> versus RyaInstance
> ---
>
> Key: RYA-135
> URL: https://issues.apache.org/jira/browse/RYA-135
> Project: Rya
> Issue Type: Improvement
> Components: sail
>Reporter: David W. Lotts
>Assignee: Andrew Smith
>Priority: Minor
>
> These THREE constants [#1] [#2] [#3] are somewhat redundant. They are the
> the same as the Rya Instance in most cases. For MongoDB, the table
> prefix[#2] may be used incorrectly instead of the collection prefix[#1].
> They should probably be melded into one config key and method and be called
> the rya instance. The RyaDetails has this concept. There is a
> ConfigUtil.getTablePrefix() and TablePrefixLayoutStrategy.getTablePrefix()
> that should be refactored as part of this.
> Some have suggested that the collection prefix is not needed at all since it
> is scoped inside a single Mongo Database which contains only one rya instance.
> {anchor:1}1 {code} conf.set(MongoDBRdfConfiguration.MONGO_COLLECTION_PREFIX,
> "rya_");{code}
> {anchor:2}2 {code}conf.set(RdfCloudTripleStoreConfiguration.CONF_TBL_PREFIX,
> "rya_");{code}
> {anchor:3}3 {code}TablePrefixLayoutStrategy.tablePrefix =
> RdfCloudTripleStoreConstants.TBL_PRFX_DEF; // = "rya_";{code}
> Some unit tests set them as different values.
> Look at
> extras/indexing/src/main/java/mvm/rya/sail/config/RyaSailFactory.java around
> line 73 for a good example of the confusion. Look for this comment:
> // XXX Should(?) be MongoDBRdfConfiguration.MONGO_COLLECTION_PREFIX inside
> the if below.
> One more redundant field: TablePrefixLayoutStrategy.tablePrefix See RYA-138
> It is defaults to "rya_" but has a getter and setter.
> {code}
> TablePrefixLayoutStrategy implements TableLayoutStrategy{
> private String tablePrefix = RdfCloudTripleStoreConstants.TBL_PRFX_DEF;
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] incubator-rya pull request #300: RYA-135 Hard code triples collection
Github user isper3at closed the pull request at: https://github.com/apache/incubator-rya/pull/300 ---
[jira] [Commented] (RYA-501) Guava changed the Iterators api.
[ https://issues.apache.org/jira/browse/RYA-501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634163#comment-16634163 ] ASF GitHub Bot commented on RYA-501: Github user isper3at closed the pull request at: https://github.com/apache/incubator-rya/pull/302 > Guava changed the Iterators api. > > > Key: RYA-501 > URL: https://issues.apache.org/jira/browse/RYA-501 > Project: Rya > Issue Type: Improvement >Reporter: Andrew Smith >Assignee: Andrew Smith >Priority: Trivial > > Guava changed scope of Iterators.emptyIterator(). > This can cause problems for anything that uses rya as a dependency or if rya > ever upgrades it's guava version. Java now has the Collections api with > emptyIterator. Changing to that will resolve this problem. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] incubator-rya pull request #302: RYA-501 Change guava Iterators to Collectio...
Github user isper3at closed the pull request at: https://github.com/apache/incubator-rya/pull/302 ---
[jira] [Commented] (RYA-500) Make RdfFileInputTool to accept multiple input paths
[ https://issues.apache.org/jira/browse/RYA-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633975#comment-16633975 ] ASF GitHub Bot commented on RYA-500: Github user asfgit closed the pull request at: https://github.com/apache/incubator-rya/pull/299 > Make RdfFileInputTool to accept multiple input paths > > > Key: RYA-500 > URL: https://issues.apache.org/jira/browse/RYA-500 > Project: Rya > Issue Type: Improvement >Affects Versions: 3.2.12 >Reporter: Maxim Kolchin >Priority: Trivial > Labels: mapreduce > > We store RDF files in multiple folders where each folder contains data about > a specific type of entity (e.g. person, company, etc.). So it's not > convenient that the RdfFileInputTool allows only a single input path. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] incubator-rya pull request #299: RYA-500: Make RdfFileInputTool to accept mu...
Github user asfgit closed the pull request at: https://github.com/apache/incubator-rya/pull/299 ---
