[GitHub] incubator-rya pull request #196: RYA-313

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-rya/pull/196


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rya pull request #196: RYA-313

[isper3at]

Github user isper3at commented on a diff in the pull request:

https://github.com/apache/incubator-rya/pull/196#discussion_r131490821
  
--- Diff: 
dao/mongodb.rya/src/main/java/org/apache/rya/mongodb/MongoDBQueryEngine.java ---
@@ -118,7 +124,8 @@ public MongoDBRdfConfiguration getConf() {
 }
 
 // TODO not sure what to do about regex ranges?
-final RyaStatementBindingSetCursorIterator iterator = new 
RyaStatementBindingSetCursorIterator(coll, rangeMap, strategy, 
conf.getAuthorizations());
+final RyaStatementBindingSetCursorIterator iterator = new 
RyaStatementBindingSetCursorIterator(
+getCollection(conf), rangeMap, strategy, 
conf.getAuthorizations());
--- End diff --

i think other parts of this class use the legacy DBCollection coll still


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rya pull request #196: RYA-313

[amihalik]

Github user amihalik commented on a diff in the pull request:

https://github.com/apache/incubator-rya/pull/196#discussion_r131464691
  
--- Diff: 
dao/mongodb.rya/src/main/java/org/apache/rya/mongodb/MongoDBQueryEngine.java ---
@@ -118,7 +124,8 @@ public MongoDBRdfConfiguration getConf() {
 }
 
 // TODO not sure what to do about regex ranges?
-final RyaStatementBindingSetCursorIterator iterator = new 
RyaStatementBindingSetCursorIterator(coll, rangeMap, strategy, 
conf.getAuthorizations());
+final RyaStatementBindingSetCursorIterator iterator = new 
RyaStatementBindingSetCursorIterator(
+getCollection(conf), rangeMap, strategy, 
conf.getAuthorizations());
--- End diff --

Since you call getCollection(conf), I believe that coll is now an unused 
field.  Can you remove it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rya pull request #196: RYA-313

[isper3at]

GitHub user isper3at opened a pull request:

https://github.com/apache/incubator-rya/pull/196

RYA-313

Aggregation now is performed over batches of 1000.

## Description
>What Changed?
Changed the iterator to use the non-deprecated Mongo api, enabled the 
aggregation framework to work properly.

This could be a very good reason to address: [Jira mongo api 
ticket](https://issues.apache.org/jira/browse/RYA-302)

### Tests
>Coverage?
No tests, just ran locally and assured that no exception for document size 
was thrown.

### Links
[Jira](https://issues.apache.org/jira/browse/RYA-313)

### Checklist
- [ ] Code Review
- [ ] Squash Commits

 People To Reivew
@amihalik 


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/isper3at/incubator-rya RYA-313

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-rya/pull/196.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #196


commit 3b279972198d34a2bcda775bc6ec4f9a87ade8ba
Author: isper3at 
Date:   2017-08-03T23:03:11Z

RYA-313
Aggregation now is performed over batches of 1000.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---