[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #2601: Verify the shardingRule at the beginning
tuohai666 commented on issue #2601: Verify the shardingRule at the beginning URL: https://github.com/apache/incubator-shardingsphere/issues/2601#issuecomment-517557000 I thinks you can study groovy script first and try to use the script to calculate the routing result. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] jingshanglu opened a new pull request #2799: add mysql grammar support for srs and trigger
jingshanglu opened a new pull request #2799: add mysql grammar support for srs and trigger URL: https://github.com/apache/incubator-shardingsphere/pull/2799 Changes proposed in this pull request: - add mysql grammar support for srs and trigger - revision keyword.g4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2798: [INFRA-18812] Switch to .mvn/jvm.config ...
terrymanu commented on issue #2798: [INFRA-18812] Switch to .mvn/jvm.config ... URL: https://github.com/apache/incubator-shardingsphere/pull/2798#issuecomment-517524576 Got it. Thank you very much for the pull request, and sorry about for polluted for other projects. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #2798: [INFRA-18812] Switch to .mvn/jvm.config ...
terrymanu merged pull request #2798: [INFRA-18812] Switch to .mvn/jvm.config ... URL: https://github.com/apache/incubator-shardingsphere/pull/2798 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] lalicw commented on issue #2722: Make SQL parse module as an open public API
lalicw commented on issue #2722: Make SQL parse module as an open public API URL: https://github.com/apache/incubator-shardingsphere/issues/2722#issuecomment-517519503 This is really an usable and impressive optimization that can help end users a lot，thank you for your efforts This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] hboutemy commented on a change in pull request #2798: [INFRA-18812] Switch to .mvn/jvm.config ...
hboutemy commented on a change in pull request #2798: [INFRA-18812] Switch to .mvn/jvm.config ... URL: https://github.com/apache/incubator-shardingsphere/pull/2798#discussion_r309902225 ## File path: .mvn/jvm.config ## @@ -0,0 +1 @@ +-Xmx1024m -XX:MaxPermSize=256m Review comment: @rfscholte need to add this `.mvn/jvm.config` to rat excludes in root `pom.xml` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] hboutemy edited a comment on issue #2798: [INFRA-18812] Switch to .mvn/jvm.config ...
hboutemy edited a comment on issue #2798: [INFRA-18812] Switch to .mvn/jvm.config ... URL: https://github.com/apache/incubator-shardingsphere/pull/2798#issuecomment-517459580 notice: what is polluted first is `.mavenrc` file that is added to Jenkins node home directory... and yes, this script pollutes MAVEN_OPTS... instead of creating `.mavenrc`, the `MAVEN_OPTS` variable could just have been basically defined before `mvn` command in Jenkinsfile, without polluting Jenkins slave and `.mvn/jvm.config` way of doing this JVM configuration looks nice, since it will not only be available to Jenkins nodes but also to developers building shardingsphere on their own laptop This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] hboutemy edited a comment on issue #2798: [INFRA-18812] Switch to .mvn/jvm.config ...
hboutemy edited a comment on issue #2798: [INFRA-18812] Switch to .mvn/jvm.config ... URL: https://github.com/apache/incubator-shardingsphere/pull/2798#issuecomment-517459580 notice: what is polluted first is `.mavenrc` file that is added to Jenkins node home directory... and yes, this script pollutes MAVEN_OPTS... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] hboutemy commented on issue #2798: [INFRA-18812] Switch to .mvn/jvm.config ...
hboutemy commented on issue #2798: [INFRA-18812] Switch to .mvn/jvm.config ... URL: https://github.com/apache/incubator-shardingsphere/pull/2798#issuecomment-517459580 notice: what is polluted first is `.mavenrc` file that is added to Jenkins node filesystem... and yes, this script pollutes MAVEN_OPTS... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] rfscholte opened a new pull request #2798: [INFRA-18812] Switch to .mvn/jvm.config ...
rfscholte opened a new pull request #2798: [INFRA-18812] Switch to .mvn/jvm.config ... URL: https://github.com/apache/incubator-shardingsphere/pull/2798 ... so MAVEN_OPTS won't get polluted. Recently while running integration tests of Apache Maven we noticed our builds becoming more and more unstable. These tests all were testing MAVEN_OPTS. We discovered that this project was generating .mavenrc files that stayed on the server, meaning that every new build was using this file and the new MAVEN_OPTS. Since Maven 3.3.1 it is possible to define jvm arguments per project. This PR contains those changes and that will restore the predictable behaviour of Jenkins. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #2797: #2777, change select_distinct test case from H2 to MySQL
coveralls commented on issue #2797: #2777, change select_distinct test case from H2 to MySQL URL: https://github.com/apache/incubator-shardingsphere/pull/2797#issuecomment-517244564 ## Pull Request Test Coverage Report for [Build 9045](https://coveralls.io/builds/24924570) * **0** of **0** changed or added relevant lines in **0** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage remained the same at **64.063%** --- | Totals | [](https://coveralls.io/builds/24924570) | | :-- | --: | | Change from base [Build 9044](https://coveralls.io/builds/24874907): | 0.0% | | Covered Lines: | 9040 | | Relevant Lines: | 14111 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #2797: #2777, change select_distinct test case from H2 to MySQL
terrymanu merged pull request #2797: #2777, change select_distinct test case from H2 to MySQL URL: https://github.com/apache/incubator-shardingsphere/pull/2797 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 opened a new pull request #2797: #2777, change select_distinct test case from H2 to MySQL
tuohai666 opened a new pull request #2797: #2777, change select_distinct test case from H2 to MySQL URL: https://github.com/apache/incubator-shardingsphere/pull/2797 #2777 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2746: add Java Microbenchmark Harness to our project
terrymanu commented on issue #2746: add Java Microbenchmark Harness to our project URL: https://github.com/apache/incubator-shardingsphere/issues/2746#issuecomment-517222024 @CalvinKirs Just as @nancyzrh said, this PR only add a maven dependency for jmh, but does not add any test cases yet, so I think you need add test cases for that. As my understanding, jmh only can print benchmark info to console which is not very make sense, we have already use jmeter to test benchmark. The precondition for introduce jmh to ShardingSphere is we need to auto assert if benchmark is under threshold. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2791: Broadcast Tables Round Robin (Load Balance)
terrymanu commented on issue #2791: Broadcast Tables Round Robin (Load Balance) URL: https://github.com/apache/incubator-shardingsphere/issues/2791#issuecomment-517221184 Hi, the title should be a question, or a statement to describe your proposal. What's is your proposal for this issue? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #2795: How to integrate apollo configuration
terrymanu closed issue #2795: How to integrate apollo configuration URL: https://github.com/apache/incubator-shardingsphere/issues/2795 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2795: How to integrate apollo configuration
terrymanu commented on issue #2795: How to integrate apollo configuration URL: https://github.com/apache/incubator-shardingsphere/issues/2795#issuecomment-517220042 duplicate with #2530 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2796: select.....for update应该路由到master节点
terrymanu commented on issue #2796: select.for update应该路由到master节点 URL: https://github.com/apache/incubator-shardingsphere/issues/2796#issuecomment-517219668 **For English only**, other languages will not accept. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #2796: select.....for update应该路由到master节点
terrymanu closed issue #2796: select.for update应该路由到master节点 URL: https://github.com/apache/incubator-shardingsphere/issues/2796 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] VitZhou opened a new issue #2796: select.....for update应该路由到master节点
VitZhou opened a new issue #2796: select.for update应该路由到master节点
URL: https://github.com/apache/incubator-shardingsphere/issues/2796
## Feature Request
select.for update应该路由到master节点,在一般的业务场景下,使用for update是为了锁行,然后进行数据的修改.比如:
@Transactional
public void updateById(String id) {
UserEntity byId = userDAO.findById(id);
byId.setName("update"+byId.getName());
userDAO.update(byId);
}
如果路由到slave节点的话无法起到锁住数据的效果.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] jeffmxzhao opened a new issue #2795: How to integrate apollo configuration
jeffmxzhao opened a new issue #2795: How to integrate apollo configuration URL: https://github.com/apache/incubator-shardingsphere/issues/2795 I am using ctrip apollo in my project, Is there any API can be use to integate apollo configuration? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
