[GitHub] [incubator-shardingsphere] hunter7727 commented on issue #1876: #1873 bug fixs
hunter7727 commented on issue #1876: #1873 bug fixs URL: https://github.com/apache/incubator-shardingsphere/pull/1876#issuecomment-534388376 May I ask when this pr can be merged into the master branch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao commented on a change in pull request #3086: support query hint context for sharding-proxy
cherrylzhao commented on a change in pull request #3086: support query hint
context for sharding-proxy
URL:
https://github.com/apache/incubator-shardingsphere/pull/3086#discussion_r327416996
##
File path:
sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/text/sctl/hint/internal/HintCommandExecutorFactory.java
##
@@ -46,30 +51,53 @@
/**
* Create hint command executor instance.
*
- * @param sql SQL
+ * @param shardingRule sharding rule
+ * @param sql SQL
* @return hint command executor
*/
-public static HintCommandExecutor newInstance(final String sql) {
+public static HintCommandExecutor newInstance(final ShardingRule
shardingRule, final String sql) {
Optional shardingTCLStatement = new
ShardingCTLHintParser(sql).doParse();
if (!shardingTCLStatement.isPresent()) {
return new HintErrorFormatExecutor(sql);
}
HintCommand hintCommand = shardingTCLStatement.get().getHintCommand();
+Optional hintUpdateExecutor =
getHintUpdateExecutor(hintCommand);
+if (hintUpdateExecutor.isPresent()) {
+return hintUpdateExecutor.get();
+}
+Optional hintQueryExecutor =
getHintQueryExecutor(hintCommand, shardingRule);
+if (hintQueryExecutor.isPresent()) {
+return hintQueryExecutor.get();
+}
+return new HintErrorParameterExecutor(sql);
+}
+
+private static Optional getHintUpdateExecutor(final
HintCommand hintCommand) {
Review comment:
let's ignore it at first.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere-example] cherrylzhao commented on a change in pull request #182: add example for sharding-proxy of hint mode
cherrylzhao commented on a change in pull request #182: add example for sharding-proxy of hint mode URL: https://github.com/apache/incubator-shardingsphere-example/pull/182#discussion_r327412870 ## File path: example-core/example-api/src/main/java/org/apache/shardingsphere/example/core/api/DataSourceUtil.java ## @@ -29,7 +29,7 @@ private static final String USER_NAME = "root"; -private static final String PASSWORD = ""; +private static final String PASSWORD = "liya76133951";// changed by liya Review comment: password should not be modified. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-example] cherrylzhao commented on a change in pull request #182: add example for sharding-proxy of hint mode
cherrylzhao commented on a change in pull request #182: add example for sharding-proxy of hint mode URL: https://github.com/apache/incubator-shardingsphere-example/pull/182#discussion_r327412928 ## File path: sharding-jdbc-example/sharding-example/sharding-raw-jdbc-example/src/main/resources/META-INF/sharding-databases.yaml ## @@ -3,12 +3,12 @@ dataSources: driverClassName: com.mysql.jdbc.Driver jdbcUrl: jdbc:mysql://localhost:3306/demo_ds_0?serverTimezone=UTC=false=true=UTF-8 username: root -password: +password: liya76133951 Review comment: password should not be modified. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] cherrylzhao opened a new issue #247: add doc for proxy-hint feature
cherrylzhao opened a new issue #247: add doc for proxy-hint feature URL: https://github.com/apache/incubator-shardingsphere-doc/issues/247 - [ ] [sctl-sharding-proxy-control-language-cn](https://github.com/apache/incubator-shardingsphere-doc/blob/master/document/current/content/manual/sharding-proxy/usage.cn.md#sctl-sharding-proxy-control-language) - [ ] [sctl-sharding-proxy-control-language-en](https://github.com/apache/incubator-shardingsphere-doc/blob/master/document/current/content/manual/sharding-proxy/usage.en.md#sctl-sharding-proxy-control-language) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] cherrylzhao closed issue #247: add doc for proxy-hint feature
cherrylzhao closed issue #247: add doc for proxy-hint feature URL: https://github.com/apache/incubator-shardingsphere-doc/issues/247 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] cherrylzhao merged pull request #264: add doc for proxy-hint update
cherrylzhao merged pull request #264: add doc for proxy-hint update URL: https://github.com/apache/incubator-shardingsphere-doc/pull/264 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao commented on a change in pull request #3086: support query hint context for sharding-proxy
cherrylzhao commented on a change in pull request #3086: support query hint
context for sharding-proxy
URL:
https://github.com/apache/incubator-shardingsphere/pull/3086#discussion_r327401599
##
File path:
sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/rule/ShardingRule.java
##
@@ -378,6 +378,19 @@ private boolean isShardingColumn(final TableRule
tableRule, final String columnN
return result;
}
+/**
+ * Get logic table names.
+ *
+ * @return logic table name
+ */
+public Collection getLogicTableNames() {
Review comment:
it should be moved to `HintShowTableStatusExecutor`, only show table status
would use this method.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao commented on a change in pull request #3086: support query hint context for sharding-proxy
cherrylzhao commented on a change in pull request #3086: support query hint
context for sharding-proxy
URL:
https://github.com/apache/incubator-shardingsphere/pull/3086#discussion_r327410534
##
File path:
sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/text/sctl/hint/internal/executor/HintShowTableStatusExecutor.java
##
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package
org.apache.shardingsphere.shardingproxy.backend.text.sctl.hint.internal.executor;
+
+import com.google.common.base.Joiner;
+import lombok.RequiredArgsConstructor;
+import org.apache.shardingsphere.api.hint.HintManager;
+import org.apache.shardingsphere.core.rule.ShardingRule;
+import
org.apache.shardingsphere.shardingproxy.backend.response.BackendResponse;
+import
org.apache.shardingsphere.shardingproxy.backend.response.query.QueryData;
+import
org.apache.shardingsphere.shardingproxy.backend.response.query.QueryHeader;
+import
org.apache.shardingsphere.shardingproxy.backend.response.query.QueryResponse;
+import
org.apache.shardingsphere.shardingproxy.backend.text.sctl.hint.internal.HintCommandExecutor;
+import
org.apache.shardingsphere.shardingproxy.backend.text.sctl.hint.internal.result.HintShowTableStatusResult;
+
+import java.sql.Types;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.LinkedList;
+import java.util.List;
+import java.util.Map;
+
+/**
+ * Hint show table status command executor.
+ *
+ * @author liya
+ */
+@RequiredArgsConstructor
+public final class HintShowTableStatusExecutor implements HintCommandExecutor {
Review comment:
same with HintShowStatusExecutor, should refactor it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao commented on a change in pull request #3086: support query hint context for sharding-proxy
cherrylzhao commented on a change in pull request #3086: support query hint
context for sharding-proxy
URL:
https://github.com/apache/incubator-shardingsphere/pull/3086#discussion_r327407189
##
File path:
sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/text/sctl/hint/internal/HintCommandExecutorFactory.java
##
@@ -46,30 +51,53 @@
/**
* Create hint command executor instance.
*
- * @param sql SQL
+ * @param shardingRule sharding rule
+ * @param sql SQL
* @return hint command executor
*/
-public static HintCommandExecutor newInstance(final String sql) {
+public static HintCommandExecutor newInstance(final ShardingRule
shardingRule, final String sql) {
Optional shardingTCLStatement = new
ShardingCTLHintParser(sql).doParse();
if (!shardingTCLStatement.isPresent()) {
return new HintErrorFormatExecutor(sql);
}
HintCommand hintCommand = shardingTCLStatement.get().getHintCommand();
+Optional hintUpdateExecutor =
getHintUpdateExecutor(hintCommand);
+if (hintUpdateExecutor.isPresent()) {
+return hintUpdateExecutor.get();
+}
+Optional hintQueryExecutor =
getHintQueryExecutor(hintCommand, shardingRule);
+if (hintQueryExecutor.isPresent()) {
+return hintQueryExecutor.get();
+}
+return new HintErrorParameterExecutor(sql);
+}
+
+private static Optional getHintUpdateExecutor(final
HintCommand hintCommand) {
Review comment:
getHintUpdateExecutor and getHintQueryExecutor could inline into newInstance.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao commented on a change in pull request #3086: support query hint context for sharding-proxy
cherrylzhao commented on a change in pull request #3086: support query hint
context for sharding-proxy
URL:
https://github.com/apache/incubator-shardingsphere/pull/3086#discussion_r327410115
##
File path:
sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/text/sctl/hint/internal/executor/HintShowStatusExecutor.java
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package
org.apache.shardingsphere.shardingproxy.backend.text.sctl.hint.internal.executor;
+
+import org.apache.shardingsphere.api.hint.HintManager;
+import
org.apache.shardingsphere.shardingproxy.backend.response.BackendResponse;
+import
org.apache.shardingsphere.shardingproxy.backend.response.query.QueryData;
+import
org.apache.shardingsphere.shardingproxy.backend.response.query.QueryHeader;
+import
org.apache.shardingsphere.shardingproxy.backend.response.query.QueryResponse;
+import
org.apache.shardingsphere.shardingproxy.backend.text.sctl.hint.internal.HintCommandExecutor;
+import
org.apache.shardingsphere.shardingproxy.backend.text.sctl.hint.internal.HintShardingType;
+import
org.apache.shardingsphere.shardingproxy.backend.text.sctl.hint.internal.result.HintShowStatusResult;
+
+import java.sql.Types;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.Iterator;
+import java.util.List;
+
+/**
+ * Hint show status command executor.
+ *
+ * @author liya
+ */
+public final class HintShowStatusExecutor implements HintCommandExecutor {
+
+private List queryHeaders;
Review comment:
how about using `ShowShardingCTLMergedResult` to refactor it.
see `ShardingCTLShowBackendHandler` we have done before.
you can hold the mergeResult in HintShowStatusExecutor, then
`ShardingCTLHintBackendHandler` will invoke it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao commented on a change in pull request #3086: support query hint context for sharding-proxy
cherrylzhao commented on a change in pull request #3086: support query hint
context for sharding-proxy
URL:
https://github.com/apache/incubator-shardingsphere/pull/3086#discussion_r327396902
##
File path:
sharding-core/sharding-core-api/src/main/java/org/apache/shardingsphere/api/hint/HintManager.java
##
@@ -80,6 +81,9 @@ public void setDatabaseShardingValue(final Comparable
value) {
* @param value sharding value
*/
public void addDatabaseShardingValue(final String logicTable, final
Comparable value) {
+if (databaseShardingValues.containsKey("")) {
Review comment:
how about changing to
``` java
if (databaseShardingOnly) {
databaseShardingValues.removeAll("");
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao commented on a change in pull request #3086: support query hint context for sharding-proxy
cherrylzhao commented on a change in pull request #3086: support query hint
context for sharding-proxy
URL:
https://github.com/apache/incubator-shardingsphere/pull/3086#discussion_r327402178
##
File path:
sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/text/sctl/hint/ShardingCTLHintBackendHandler.java
##
@@ -33,28 +34,31 @@
private final String sql;
-private final boolean supportHint;
+private final BackendConnection backendConnection;
+
+private HintCommandExecutor hintCommandExecutor;
public ShardingCTLHintBackendHandler(final String sql, final
BackendConnection backendConnection) {
this.sql = sql;
-this.supportHint = backendConnection.isSupportHint();
+this.backendConnection = backendConnection;
}
@Override
public BackendResponse execute() {
-if (!supportHint) {
+if (!backendConnection.isSupportHint()) {
throw new UnsupportedOperationException(String.format("%s should
be true, please check your config",
ShardingPropertiesConstant.PROXY_HINT_ENABLED.getKey()));
}
-return HintCommandExecutorFactory.newInstance(sql).execute();
+hintCommandExecutor =
HintCommandExecutorFactory.newInstance(backendConnection.getLogicSchema().getShardingRule(),
sql);
Review comment:
I think I it's better to use backendConnection directly here, and
`getShardingRule` in `ShowTableStatusExecutor`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere-example] hanxuewen removed a comment on issue #181: 主键赋值错误，或者未赋值
hanxuewen removed a comment on issue #181: 主键赋值错误，或者未赋值 URL: https://github.com/apache/incubator-shardingsphere-example/issues/181#issuecomment-534368838 @terrymanu 大神，帮忙看下 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-example] hanxuewen commented on issue #181: 主键赋值错误，或者未赋值
hanxuewen commented on issue #181: 主键赋值错误，或者未赋值 URL: https://github.com/apache/incubator-shardingsphere-example/issues/181#issuecomment-534368769 @terrymanu 大神，帮忙看下 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-example] hanxuewen commented on issue #181: 主键赋值错误，或者未赋值
hanxuewen commented on issue #181: 主键赋值错误，或者未赋值 URL: https://github.com/apache/incubator-shardingsphere-example/issues/181#issuecomment-534368838 @terrymanu 大神，帮忙看下 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tanhaican opened a new issue #3097: Unknown system variable 'query_cache_size'
tanhaican opened a new issue #3097: Unknown system variable 'query_cache_size' URL: https://github.com/apache/incubator-shardingsphere/issues/3097 ## Bug Report - There are 4 similar issues, but none of them are exactly like me - I've tried after the document, but still can not solve the problem ### Which version of ShardingSphere did you use? First, I tried apache-shardingsphere-incubating-4.0.0-RC2-sharding-proxy-bin, Then, I build myself from dev branch (2019-09-24) ### Which project did you use? Sharding-JDBC or Sharding-Proxy? Sharding-Proxy ### Expected behavior Connected successfully by SpringBoot Application with Druid Or HikariCP Datasource ### Actual behavior Connected successfully by Navicat (sometimes throws NullPointerException: null, but still work) Both of Druid or HikariCP in my SpringBoot Application start faild by throwing "Failed to initialize pool: Unknown system variable 'query_cache_size' " ### Reason analyze (If you can) ### Steps to reproduce the behavior, such as: SQL to execute, sharding rule configuration, when exception occur etc. 1. Sharding-Proxy (4.0.0-RC2) (config-sharding.yaml) 2. SprintBoot with Druid or HikariCP 3. MySQL 8.0.12 4. Tried mysql-connector-java-5.1.44、mysql-connector-java-8.0.17.jar in SpringBoot application and sharding-proxy/lib，none of them works ### Example codes for reproduce this issue (such as a github link). [config-sharding.yaml.txt](https://github.com/apache/incubator-shardingsphere/files/3645028/config-sharding.yaml.txt) [server.yaml.txt](https://github.com/apache/incubator-shardingsphere/files/3645029/server.yaml.txt) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #3077: shardingsphere scaling out component
KomachiSion commented on issue #3077: shardingsphere scaling out component URL: https://github.com/apache/incubator-shardingsphere/issues/3077#issuecomment-534364808 Hi @dongzl, we welcome everyone to join this work. > what conditions dose this component can merge to `shardingsphere?` About the component, I think, the first important work is handling dependencies(now working). And then we need to develop some based function so that it can work with shardingsphere. If these works finished, it can be merged to shardingsphere. > How can we contribute to this work? What should we do? open issue in repo [sharding-scaling](https://github.com/avalon566/sharding-scaling.git) or repo [apache/incubator-shardingsphere](https://github.com/apache/incubator-shardingsphere) tell us what's your want to do. Then Fork repo [sharding-scaling](https://github.com/avalon566/sharding-scaling.git) to code and open PR, ss team and @avalon566 will discuss the PR with you. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao commented on a change in pull request #3093: Fix SCTL statement execute error with comments
cherrylzhao commented on a change in pull request #3093: Fix SCTL statement
execute error with comments
URL:
https://github.com/apache/incubator-shardingsphere/pull/3093#discussion_r327406458
##
File path:
sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/text/TextProtocolBackendHandlerFactory.java
##
@@ -104,4 +111,15 @@ private static TextProtocolBackendHandler
createDALBackendHandler(final DALState
}
return new UnicastBackendHandler(sql, backendConnection);
}
+
+private static String trimSqlComment(final String sql) {
+String result = sql;
+if (sql.startsWith(COMMENT_PREFIX)) {
+result = sql.substring(sql.indexOf(COMMENT_SUFFIX) + 2).trim();
+}
+if (sql.endsWith(SQL_END)) {
Review comment:
ok, it beyond client, let's retain this logic
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao commented on a change in pull request #3093: Fix SCTL statement execute error with comments
cherrylzhao commented on a change in pull request #3093: Fix SCTL statement
execute error with comments
URL:
https://github.com/apache/incubator-shardingsphere/pull/3093#discussion_r327406071
##
File path:
sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/text/TextProtocolBackendHandlerFactory.java
##
@@ -60,8 +66,9 @@
* @return instance of text protocol backend handler
*/
public static TextProtocolBackendHandler newInstance(final DatabaseType
databaseType, final String sql, final BackendConnection backendConnection) {
-if
(sql.toUpperCase().startsWith(ShardingCTLBackendHandlerFactory.SCTL)) {
-return ShardingCTLBackendHandlerFactory.newInstance(sql,
backendConnection);
+final String trimCommentSQL = trimSqlComment(sql);
+if
(trimCommentSQL.toUpperCase().startsWith(ShardingCTLBackendHandlerFactory.SCTL))
{
+return
ShardingCTLBackendHandlerFactory.newInstance(trimCommentSQL, backendConnection);
Review comment:
I have understood it. so I suggest you add a SCTLUtils class, it should
include 2 method.
- isSCTL(final string sql )
use regx to judge it
- trimComment
are you agree with it?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] xin497668869 closed issue #3096: Springboot condition bug
xin497668869 closed issue #3096: Springboot condition bug URL: https://github.com/apache/incubator-shardingsphere/issues/3096 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] xin497668869 opened a new issue #3096: Springboot condition bug
xin497668869 opened a new issue #3096: Springboot condition bug
URL: https://github.com/apache/incubator-shardingsphere/issues/3096
## Bug Report
**For English only**, other languages will not accept.
Before report a bug, make sure you have:
- Searched open and closed [GitHub
issues](https://github.com/apache/incubator-shardingsphere/issues).
- Read documentation: [ShardingSphere
Doc](https://shardingsphere.apache.org/document/current/en/overview).
Please pay attention on issues you submitted, because we maybe need more
details.
If no response **more than 7 days** and we cannot reproduce it on current
information, we will **close it**.
Please answer these questions before submitting your issue. Thanks!
### Which version of ShardingSphere did you use?
branch dev
### Which project did you use? Sharding-JDBC or Sharding-Proxy?
Sharding-JDBC
### Expected behavior
in class
org.apache.shardingsphere.shardingjdbc.spring.boot.sharding.ShardingRuleCondition
it should be
return isMasterSlaveRule || isEncryptRule ? ConditionOutcome.match("Have
found master-slave or encrypt rule in environment") :
ConditionOutcome.noMatch();
### Actual behavior
return isMasterSlaveRule || isEncryptRule ?
ConditionOutcome.noMatch("Have found master-slave or encrypt rule in
environment") : ConditionOutcome.match();
### Reason analyze (If you can)
### Steps to reproduce the behavior, such as: SQL to execute, sharding rule
configuration, when exception occur etc.
### Example codes for reproduce this issue (such as a github link).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] yanyzy commented on a change in pull request #3093: Fix SCTL statement execute error with comments
yanyzy commented on a change in pull request #3093: Fix SCTL statement execute
error with comments
URL:
https://github.com/apache/incubator-shardingsphere/pull/3093#discussion_r327402682
##
File path:
sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/text/TextProtocolBackendHandlerFactory.java
##
@@ -104,4 +111,15 @@ private static TextProtocolBackendHandler
createDALBackendHandler(final DALState
}
return new UnicastBackendHandler(sql, backendConnection);
}
+
+private static String trimSqlComment(final String sql) {
+String result = sql;
+if (sql.startsWith(COMMENT_PREFIX)) {
+result = sql.substring(sql.indexOf(COMMENT_SUFFIX) + 2).trim();
+}
+if (sql.endsWith(SQL_END)) {
Review comment:
I think it may be that the client is unable to recognize the statement,
resulting in no processing.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] yanyzy commented on a change in pull request #3093: Fix SCTL statement execute error with comments
yanyzy commented on a change in pull request #3093: Fix SCTL statement execute
error with comments
URL:
https://github.com/apache/incubator-shardingsphere/pull/3093#discussion_r327401965
##
File path:
sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/text/TextProtocolBackendHandlerFactory.java
##
@@ -60,8 +66,9 @@
* @return instance of text protocol backend handler
*/
public static TextProtocolBackendHandler newInstance(final DatabaseType
databaseType, final String sql, final BackendConnection backendConnection) {
-if
(sql.toUpperCase().startsWith(ShardingCTLBackendHandlerFactory.SCTL)) {
-return ShardingCTLBackendHandlerFactory.newInstance(sql,
backendConnection);
+final String trimCommentSQL = trimSqlComment(sql);
+if
(trimCommentSQL.toUpperCase().startsWith(ShardingCTLBackendHandlerFactory.SCTL))
{
+return
ShardingCTLBackendHandlerFactory.newInstance(trimCommentSQL, backendConnection);
Review comment:
Yes, it looks clearer. but if sql is like
```bash
select x from table where z="sctl:"
```
this situation is rare but also possible.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl commented on issue #3077: shardingsphere scaling out component
dongzl commented on issue #3077: shardingsphere scaling out component URL: https://github.com/apache/incubator-shardingsphere/issues/3077#issuecomment-534354489 Hi @terrymanu, what conditions dose this component can merge to shardingsphere? How can we contribute to this work? What should we do? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao commented on a change in pull request #3093: Fix SCTL statement execute error with comments
cherrylzhao commented on a change in pull request #3093: Fix SCTL statement
execute error with comments
URL:
https://github.com/apache/incubator-shardingsphere/pull/3093#discussion_r327395023
##
File path:
sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/text/TextProtocolBackendHandlerFactory.java
##
@@ -104,4 +111,15 @@ private static TextProtocolBackendHandler
createDALBackendHandler(final DALState
}
return new UnicastBackendHandler(sql, backendConnection);
}
+
+private static String trimSqlComment(final String sql) {
+String result = sql;
+if (sql.startsWith(COMMENT_PREFIX)) {
+result = sql.substring(sql.indexOf(COMMENT_SUFFIX) + 2).trim();
+}
+if (sql.endsWith(SQL_END)) {
Review comment:
`;` will not be passed to proxy, please verify it again.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao commented on a change in pull request #3093: Fix SCTL statement execute error with comments
cherrylzhao commented on a change in pull request #3093: Fix SCTL statement
execute error with comments
URL:
https://github.com/apache/incubator-shardingsphere/pull/3093#discussion_r327394690
##
File path:
sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/text/TextProtocolBackendHandlerFactory.java
##
@@ -60,8 +66,9 @@
* @return instance of text protocol backend handler
*/
public static TextProtocolBackendHandler newInstance(final DatabaseType
databaseType, final String sql, final BackendConnection backendConnection) {
-if
(sql.toUpperCase().startsWith(ShardingCTLBackendHandlerFactory.SCTL)) {
-return ShardingCTLBackendHandlerFactory.newInstance(sql,
backendConnection);
+final String trimCommentSQL = trimSqlComment(sql);
Review comment:
it's better to move trimComentSQL logic to `ShardingCTLBackendHandlerFactory`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao commented on a change in pull request #3093: Fix SCTL statement execute error with comments
cherrylzhao commented on a change in pull request #3093: Fix SCTL statement
execute error with comments
URL:
https://github.com/apache/incubator-shardingsphere/pull/3093#discussion_r327394889
##
File path:
sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/text/TextProtocolBackendHandlerFactory.java
##
@@ -60,8 +66,9 @@
* @return instance of text protocol backend handler
*/
public static TextProtocolBackendHandler newInstance(final DatabaseType
databaseType, final String sql, final BackendConnection backendConnection) {
-if
(sql.toUpperCase().startsWith(ShardingCTLBackendHandlerFactory.SCTL)) {
-return ShardingCTLBackendHandlerFactory.newInstance(sql,
backendConnection);
+final String trimCommentSQL = trimSqlComment(sql);
+if
(trimCommentSQL.toUpperCase().startsWith(ShardingCTLBackendHandlerFactory.SCTL))
{
+return
ShardingCTLBackendHandlerFactory.newInstance(trimCommentSQL, backendConnection);
Review comment:
so here should use contains method, then trim in
ShardingCTLBackendHandlerFactory
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] wgy8283335 opened a new issue #3095: ConfigCenter should replace RegistryCenter in some places.
wgy8283335 opened a new issue #3095: ConfigCenter should replace RegistryCenter in some places. URL: https://github.com/apache/incubator-shardingsphere/issues/3095 ## ConfigCenter should replace RegistryCenter in some places. ### These class should be modified. - org.apache.shardingsphere.shardingjdbc.orchestration.util.TestRegistryCenter - org.apache.shardingsphere.shardingjdbc.orchestration.spring.boot.registry.TestRegistryCenter - org.apache.shardingsphere.shardingjdbc.orchestration.spring.registry.TestRegistryCenter - org.apache.shardingsphere.ui.servcie.RegistryCenterService - org.apache.shardingsphere.ui.servcie.impl.RegistryCenterServiceImpl - org.apache.shardingsphere.ui.util.RegistryCenterFactory ### Some of these class should be modified. - org.apache.shardingsphere.orchestration.internal.registry.config.listener.AuthenticationChangedListener - org.apache.shardingsphere.orchestration.internal.registry.config.listener.ConfigurationChangedListenerManager - org.apache.shardingsphere.orchestration.internal.registry.config.listener.PropertiesChangedListener - org.apache.shardingsphere.orchestration.internal.registry.config.listener.SchemaChangedListener - org.apache.shardingsphere.orchestration.internal.registry.config.service.ConfigurationService - org.apache.shardingsphere.orchestration.internal.registry.listener.PostShardingOrchestrationEventListener - org.apache.shardingsphere.orchestration.internal.registry.listener.ShardingOrchestrationListenerManager - org.apache.shardingsphere.orchestration.internal.registry.state.listener.DataSourceStateChangedListener - org.apache.shardingsphere.orchestration.internal.registry.state.listener.InstanceStateChangedListener - org.apache.shardingsphere.orchestration.internal.registry.state.listener.StateChangedListenerManager - org.apache.shardingsphere.orchestration.internal.registry.state.service.StateService This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] wqzwh opened a new pull request #266: Add new committer(Qi Wang)
wqzwh opened a new pull request #266: Add new committer(Qi Wang) URL: https://github.com/apache/incubator-shardingsphere-doc/pull/266 1.add new committer(Qi Wang) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-shardingsphere-benchmark] branch master updated: for performance
This is an automated email from the ASF dual-hosted git repository. zhaoyanan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-shardingsphere-benchmark.git The following commit(s) were added to refs/heads/master by this push: new b01413b for performance b01413b is described below commit b01413b86097f7a1a0a0edefb3aec8f5bbd534d1 Author: nancyzrh AuthorDate: Tue Sep 24 06:48:12 2019 +0800 for performance --- report/data/3.0_single_delete_merge.log_plot| 4 report/data/3.0_single_insert_merge.log_plot| 4 report/data/3.0_single_select_merge.log_plot| 4 report/data/3.0_single_update_merge.log_plot| 4 report/data/3.0_sp_delete_raw_merge.log_plot| 4 report/data/3.0_sp_insert_raw_merge.log_plot| 4 report/data/3.0_sp_select_raw_merge.log_plot| 4 report/data/3.0_sp_update_raw_merge.log_plot| 4 report/data/4.0_single_delete_merge.log_plot| 1 + report/data/4.0_single_insert_merge.log_plot| 1 + report/data/4.0_single_select_merge.log_plot| 1 + report/data/4.0_single_update_merge.log_plot| 1 + report/data/4.0_sp_delete_raw_merge.log_plot| 1 + report/data/4.0_sp_insert_raw_merge.log_plot| 1 + report/data/4.0_sp_select_raw_merge.log_plot| 1 + report/data/4.0_sp_update_raw_merge.log_plot| 1 + report/data/direct_delete_merge.log_plot| 1 + report/data/direct_insert_merge.log_plot| 1 + report/data/direct_select_merge.log_plot| 1 + report/data/direct_update_merge.log_plot| 1 + report/data/encrypt/4.0_sp_delete_enc.log_plot | 1 + report/data/encrypt/4.0_sp_insert_enc.log_plot | 1 + .../encrypt/4.0_sp_insert_enc_sharding.log_plot | 1 + report/data/encrypt/4.0_sp_select_enc.log_plot | 1 + report/data/encrypt/4.0_sp_update_enc.log_plot | 1 + report/data/master_slave/3.0_sp_delete_ms.log_plot | 4 .../master_slave/3.0_sp_delete_ms_sharding.log_plot | 1 + report/data/master_slave/3.0_sp_insert_ms.log_plot | 4 .../master_slave/3.0_sp_insert_ms_sharding.log_plot | 1 + report/data/master_slave/3.0_sp_select_ms.log_plot | 4 .../master_slave/3.0_sp_select_ms_sharding.log_plot | 1 + report/data/master_slave/3.0_sp_update_ms.log_plot | 4 .../master_slave/3.0_sp_update_ms_sharding.log_plot | 1 + report/data/master_slave/4.0_sp_delete_ms.log_plot | 1 + .../master_slave/4.0_sp_delete_ms_sharding.log_plot | 1 + report/data/master_slave/4.0_sp_insert_ms.log_plot | 1 + .../master_slave/4.0_sp_insert_ms_sharding.log_plot | 1 + report/data/master_slave/4.0_sp_select_ms.log_plot | 1 + .../master_slave/4.0_sp_select_ms_sharding.log_plot | 1 + report/data/master_slave/4.0_sp_update_ms.log_plot | 1 + .../master_slave/4.0_sp_update_ms_sharding.log_plot | 1 + report/scenario_1/delete_single.png | Bin 28296 -> 32986 bytes report/scenario_1/insert_single.png | Bin 26815 -> 31536 bytes report/scenario_1/select_single.png | Bin 27659 -> 28721 bytes report/scenario_1/update_single.png | Bin 28104 -> 25791 bytes report/sp_raw/delete_single_raw.png | Bin 31173 -> 36032 bytes report/sp_raw/insert_single_raw.png | Bin 30368 -> 33684 bytes report/sp_raw/select_single_raw.png | Bin 26939 -> 30421 bytes report/sp_raw/update_single_raw.png | Bin 29952 -> 31324 bytes 49 files changed, 77 insertions(+) diff --git a/report/data/3.0_single_delete_merge.log_plot b/report/data/3.0_single_delete_merge.log_plot index 651218c..b0663d9 100644 --- a/report/data/3.0_single_delete_merge.log_plot +++ b/report/data/3.0_single_delete_merge.log_plot @@ -2,3 +2,7 @@ summary = 200 in 00:00:38 = 53307.7/s Avg: 3 Min: 0 Max:96 Err: summary = 200 in 00:00:36 = 55783.3/s Avg: 3 Min: 0 Max:92 Err: 0 (0.00%) summary = 200 in 00:00:34 = 59096.4/s Avg: 3 Min: 0 Max:78 Err: 0 (0.00%) summary = 200 in 00:00:34 = 58644.1/s Avg: 3 Min: 0 Max:62 Err: 0 (0.00%) +summary = 200 in 00:00:33 = 59964.6/s Avg: 3 Min: 0 Max:68 Err: 0 (0.00%) +summary = 200 in 00:00:34 = 58820.1/s Avg: 3 Min: 0 Max:58 Err: 0 (0.00%) +summary = 200 in 00:00:34 = 58823.5/s Avg: 3 Min: 0 Max:57 Err: 0 (0.00%) +summary = 200 in 00:00:34 = 59440.7/s Avg: 3 Min: 0 Max:64 Err: 0 (0.00%) diff --git a/report/data/3.0_single_insert_merge.log_plot b/report/data/3.0_single_insert_merge.log_plot index 6398eea..7bc17b4 100644 --- a/report/data/3.0_single_insert_merge.log_plot +++ b/report/data/3.0_single_insert_merge.log_plot @@ -2,3 +2,7 @@ summary = 200 in 00:00:26 = 78428.3/s Avg: 2
[GitHub] [incubator-shardingsphere] jdeegan opened a new issue #3094: Question regarding reference tables
jdeegan opened a new issue #3094: Question regarding reference tables URL: https://github.com/apache/incubator-shardingsphere/issues/3094 I am trying test how reference (broadcast) tables operate with Sharding-JDBC. More specifically, I want to test if a record is inserted into one reference table, will it automatically update all the reference tables in all the shards, or does each shard have to be manipulated separately when it comes to broadcast tables. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] DesperateL commented on issue #2952: Error happened when compiling 4.0.0-RC2 source code
DesperateL commented on issue #2952: Error happened when compiling 4.0.0-RC2 source code URL: https://github.com/apache/incubator-shardingsphere/issues/2952#issuecomment-534156297 how did you solve this problem? @timchan1011 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] redwolf2019 commented on issue #3075: sharding fully support with JOOQ?
redwolf2019 commented on issue #3075: sharding fully support with JOOQ? URL: https://github.com/apache/incubator-shardingsphere/issues/3075#issuecomment-534118450 @sluk3r thanks for you help! this is repository, DDL in resources path. https://github.com/redwolf2019/jooq_example This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #3093: Fix SCTL statement execute error with comments
coveralls commented on issue #3093: Fix SCTL statement execute error with comments URL: https://github.com/apache/incubator-shardingsphere/pull/3093#issuecomment-534105529 ## Pull Request Test Coverage Report for [Build 417](https://coveralls.io/builds/25869325) * **9** of **9** **(100.0%)** changed or added relevant lines in **1** file are covered. * No unchanged relevant lines lost coverage. * Overall coverage increased (+**0.04%**) to **65.166%** --- | Totals | [](https://coveralls.io/builds/25869325) | | :-- | --: | | Change from base [Build 406](https://coveralls.io/builds/25867773): | 0.04% | | Covered Lines: | 9580 | | Relevant Lines: | 14701 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] haetao commented on issue #265: Adjust the format of yaml file
haetao commented on issue #265: Adjust the format of yaml file URL: https://github.com/apache/incubator-shardingsphere-doc/pull/265#issuecomment-534096362 Adjust the format of yaml file This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] haetao removed a comment on issue #265: Adjust the format of yaml file
haetao removed a comment on issue #265: Adjust the format of yaml file URL: https://github.com/apache/incubator-shardingsphere-doc/pull/265#issuecomment-534096362 Adjust the format of yaml file This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] haetao opened a new pull request #265: Adjust the format of yaml file
haetao opened a new pull request #265: Adjust the format of yaml file URL: https://github.com/apache/incubator-shardingsphere-doc/pull/265 Adjust the format of yaml file This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] yanyzy opened a new pull request #3093: Fix SCTL statement execute error with comments
yanyzy opened a new pull request #3093: Fix SCTL statement execute error with comments URL: https://github.com/apache/incubator-shardingsphere/pull/3093 Fixes #3092. add trim to support sctl statement with comments This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] yanyzy opened a new issue #3092: SCTL statement get error when sql contains comments
yanyzy opened a new issue #3092: SCTL statement get error when sql contains comments URL: https://github.com/apache/incubator-shardingsphere/issues/3092 ## Bug Report ### Which version of ShardingSphere did you use? Dev ### Which project did you use? Sharding-JDBC or Sharding-Proxy? Sharding-Proxy ### Expected behavior SCTL statement can get correct results ### Actual behavior When sql contains comments, the stcl statement will report an error. ### Steps to reproduce the behavior, such as: SQL to execute, sharding rule configuration, when exception occur etc. First i use DataGrip to execute command, and it get an error  so, i use command line tool to execute it, it works fine. but if sql has comments, will get error.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #3086: support query hint context for sharding-proxy
coveralls commented on issue #3086: support query hint context for sharding-proxy URL: https://github.com/apache/incubator-shardingsphere/pull/3086#issuecomment-534087836 ## Pull Request Test Coverage Report for [Build 416](https://coveralls.io/builds/25868356) * **106** of **127** **(83.46%)** changed or added relevant lines in **10** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage increased (+**0.1%**) to **65.255%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/text/sctl/hint/internal/executor/AbstractHintUpdateExecutor.java](https://coveralls.io/builds/25868356/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Ftext%2Fsctl%2Fhint%2Finternal%2Fexecutor%2FAbstractHintUpdateExecutor.java#L32) | 0 | 1 | 0.0% | [sharding-core/sharding-core-api/src/main/java/org/apache/shardingsphere/api/hint/HintManager.java](https://coveralls.io/builds/25868356/source?filename=sharding-core%2Fsharding-core-api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fapi%2Fhint%2FHintManager.java#L85) | 1 | 4 | 25.0% | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/rule/ShardingRule.java](https://coveralls.io/builds/25868356/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frule%2FShardingRule.java#L387) | 0 | 5 | 0.0% | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/text/sctl/hint/internal/executor/HintShowTableStatusExecutor.java](https://coveralls.io/builds/25868356/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Ftext%2Fsctl%2Fhint%2Finternal%2Fexecutor%2FHintShowTableStatusExecutor.java#L67) | 39 | 51 | 76.47% | Totals | [](https://coveralls.io/builds/25868356) | | :-- | --: | | Change from base [Build 406](https://coveralls.io/builds/25867773): | 0.1% | | Covered Lines: | 9661 | | Relevant Lines: | 14805 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-example] betterjava opened a new pull request #182: add example for sharding-proxy of hint mode
betterjava opened a new pull request #182: add example for sharding-proxy of hint mode URL: https://github.com/apache/incubator-shardingsphere-example/pull/182 Fixes #179. Changes proposed in this pull request: - add new module sharding-proxy-hint-example. - set hint value through sctl:hint statement. - add conf file for hint. - the hint result is reflected by the sharding-proxy log. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] yjjqrqqq commented on issue #3009: Define variable in sql
yjjqrqqq commented on issue #3009: Define variable in sql URL: https://github.com/apache/incubator-shardingsphere/issues/3009#issuecomment-534075150 @terrymanu Thanks,我已经解决了。 分库的几张表使用ShardingSphere， 其它的还是用普通的数据源 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3079: Fixes #3068 Add a judgment for user's database privileges.
terrymanu merged pull request #3079: Fixes #3068 Add a judgment for user's database privileges. URL: https://github.com/apache/incubator-shardingsphere/pull/3079 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #3068: Sharding-Proxy: Configuring user access to the database is invalid
terrymanu closed issue #3068: Sharding-Proxy: Configuring user access to the database is invalid URL: https://github.com/apache/incubator-shardingsphere/issues/3068 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #3091: Generic insert statement for Sharding and encrypt on optimize module
coveralls commented on issue #3091: Generic insert statement for Sharding and encrypt on optimize module URL: https://github.com/apache/incubator-shardingsphere/pull/3091#issuecomment-534068268 ## Pull Request Test Coverage Report for [Build 415](https://coveralls.io/builds/25867445) * **112** of **160** **(70.0%)** changed or added relevant lines in **45** files are covered. * **16** unchanged lines in **4** files lost coverage. * Overall coverage decreased (**-0.2%**) to **65.075%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [sharding-core/sharding-core-optimize/src/main/java/org/apache/shardingsphere/core/optimize/encrypt/engine/EncryptWhereOptimizeEngine.java](https://coveralls.io/builds/25867445/source?filename=sharding-core%2Fsharding-core-optimize%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Foptimize%2Fencrypt%2Fengine%2FEncryptWhereOptimizeEngine.java#L35) | 0 | 1 | 0.0% | [sharding-core/sharding-core-optimize/src/main/java/org/apache/shardingsphere/core/optimize/encrypt/statement/EncryptConditionOptimizedStatement.java](https://coveralls.io/builds/25867445/source?filename=sharding-core%2Fsharding-core-optimize%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Foptimize%2Fencrypt%2Fstatement%2FEncryptConditionOptimizedStatement.java#L32) | 0 | 1 | 0.0% | [sharding-core/sharding-core-optimize/src/main/java/org/apache/shardingsphere/core/optimize/encrypt/statement/EncryptTransparentOptimizedStatement.java](https://coveralls.io/builds/25867445/source?filename=sharding-core%2Fsharding-core-optimize%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Foptimize%2Fencrypt%2Fstatement%2FEncryptTransparentOptimizedStatement.java#L31) | 0 | 1 | 0.0% | [sharding-core/sharding-core-optimize/src/main/java/org/apache/shardingsphere/core/optimize/sharding/statement/ShardingTransparentOptimizedStatement.java](https://coveralls.io/builds/25867445/source?filename=sharding-core%2Fsharding-core-optimize%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Foptimize%2Fsharding%2Fstatement%2FShardingTransparentOptimizedStatement.java#L31) | 0 | 1 | 0.0% | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/ShardingPreparedStatement.java](https://coveralls.io/builds/25867445/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fstatement%2FShardingPreparedStatement.java#L131) | 4 | 5 | 80.0% | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/ShardingStatement.java](https://coveralls.io/builds/25867445/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fstatement%2FShardingStatement.java#L113) | 3 | 4 | 75.0% | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/JDBCDatabaseCommunicationEngine.java](https://coveralls.io/builds/25867445/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2FJDBCDatabaseCommunicationEngine.java#L90) | 0 | 1 | 0.0% | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/execute/JDBCExecuteEngine.java](https://coveralls.io/builds/25867445/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fexecute%2FJDBCExecuteEngine.java#L76) | 0 | 1 | 0.0% | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/PreparedStatementExecutorWrapper.java](https://coveralls.io/builds/25867445/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fwrapper%2FPreparedStatementExecutorWrapper.java#L98) | 0 | 1 | 0.0% | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/StatementExecutorWrapper.java](https://coveralls.io/builds/25867445/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fwrapper%2FStatementExecutorWrapper.java#L99) | 0 | 1 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | |
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3091: Generic insert statement for Sharding and encrypt on optimize module
terrymanu merged pull request #3091: Generic insert statement for Sharding and encrypt on optimize module URL: https://github.com/apache/incubator-shardingsphere/pull/3091 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #3091: Generic insert statement for Sharding and encrypt on optimize module
terrymanu opened a new pull request #3091: Generic insert statement for Sharding and encrypt on optimize module URL: https://github.com/apache/incubator-shardingsphere/pull/3091 For #3061. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] tristaZero commented on issue #264: add doc for proxy-hint update
tristaZero commented on issue #264: add doc for proxy-hint update URL: https://github.com/apache/incubator-shardingsphere-doc/pull/264#issuecomment-534059860 @betterjava Hi, nice to see you again. :) Hope you can become our committer. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #3079: Fixes #3068 Add a judgment for user's database privileges.
tristaZero commented on issue #3079: Fixes #3068 Add a judgment for user's database privileges. URL: https://github.com/apache/incubator-shardingsphere/pull/3079#issuecomment-534058466 @yanyzy yanyzy Hi, thanks your issue and suggestion, and @sunbufu Your pr is great. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #3090: Generic insert statement for Sharding and encrypt on optimize module
coveralls commented on issue #3090: Generic insert statement for Sharding and encrypt on optimize module URL: https://github.com/apache/incubator-shardingsphere/pull/3090#issuecomment-534055536 ## Pull Request Test Coverage Report for [Build 411](https://coveralls.io/builds/25866807) * **110** of **160** **(68.75%)** changed or added relevant lines in **45** files are covered. * **59** unchanged lines in **8** files lost coverage. * Overall coverage decreased (**-0.3%**) to **64.962%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [sharding-core/sharding-core-optimize/src/main/java/org/apache/shardingsphere/core/optimize/encrypt/engine/EncryptWhereOptimizeEngine.java](https://coveralls.io/builds/25866807/source?filename=sharding-core%2Fsharding-core-optimize%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Foptimize%2Fencrypt%2Fengine%2FEncryptWhereOptimizeEngine.java#L35) | 0 | 1 | 0.0% | [sharding-core/sharding-core-optimize/src/main/java/org/apache/shardingsphere/core/optimize/encrypt/statement/EncryptConditionOptimizedStatement.java](https://coveralls.io/builds/25866807/source?filename=sharding-core%2Fsharding-core-optimize%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Foptimize%2Fencrypt%2Fstatement%2FEncryptConditionOptimizedStatement.java#L32) | 0 | 1 | 0.0% | [sharding-core/sharding-core-optimize/src/main/java/org/apache/shardingsphere/core/optimize/encrypt/statement/EncryptTransparentOptimizedStatement.java](https://coveralls.io/builds/25866807/source?filename=sharding-core%2Fsharding-core-optimize%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Foptimize%2Fencrypt%2Fstatement%2FEncryptTransparentOptimizedStatement.java#L31) | 0 | 1 | 0.0% | [sharding-core/sharding-core-optimize/src/main/java/org/apache/shardingsphere/core/optimize/sharding/statement/ShardingTransparentOptimizedStatement.java](https://coveralls.io/builds/25866807/source?filename=sharding-core%2Fsharding-core-optimize%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Foptimize%2Fsharding%2Fstatement%2FShardingTransparentOptimizedStatement.java#L31) | 0 | 1 | 0.0% | [sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/core/route/type/broadcast/TableBroadcastRoutingEngine.java](https://coveralls.io/builds/25866807/source?filename=sharding-core%2Fsharding-core-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Froute%2Ftype%2Fbroadcast%2FTableBroadcastRoutingEngine.java#L65) | 1 | 2 | 50.0% | [sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/core/route/type/standard/StandardRoutingEngine.java](https://coveralls.io/builds/25866807/source?filename=sharding-core%2Fsharding-core-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Froute%2Ftype%2Fstandard%2FStandardRoutingEngine.java#L73) | 1 | 2 | 50.0% | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/ShardingPreparedStatement.java](https://coveralls.io/builds/25866807/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fstatement%2FShardingPreparedStatement.java#L131) | 4 | 5 | 80.0% | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/ShardingStatement.java](https://coveralls.io/builds/25866807/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fstatement%2FShardingStatement.java#L113) | 3 | 4 | 75.0% | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/JDBCDatabaseCommunicationEngine.java](https://coveralls.io/builds/25866807/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2FJDBCDatabaseCommunicationEngine.java#L90) | 0 | 1 | 0.0% | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/execute/JDBCExecuteEngine.java](https://coveralls.io/builds/25866807/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fexecute%2FJDBCExecuteEngine.java#L76) | 0 | 1 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/strategy/keygen/TimeService.java](https://coveralls.io/builds/25866807/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fstrategy%2Fkeygen%2FTimeService.java#L33) | 1 | 0.0% | |
[GitHub] [incubator-shardingsphere] terrymanu closed pull request #3090: Generic insert statement for Sharding and encrypt on optimize module
terrymanu closed pull request #3090: Generic insert statement for Sharding and encrypt on optimize module URL: https://github.com/apache/incubator-shardingsphere/pull/3090 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3090: Generic insert statement for Sharding and encrypt on optimize module
terrymanu commented on issue #3090: Generic insert statement for Sharding and encrypt on optimize module URL: https://github.com/apache/incubator-shardingsphere/pull/3090#issuecomment-534053870 Invalid pr This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #3079: Fixes #3068 Add a judgment for user's database privileges.
coveralls edited a comment on issue #3079: Fixes #3068 Add a judgment for user's database privileges. URL: https://github.com/apache/incubator-shardingsphere/pull/3079#issuecomment-533867548 ## Pull Request Test Coverage Report for [Build 410](https://coveralls.io/builds/25866360) * **20** of **21** **(95.24%)** changed or added relevant lines in **3** files are covered. * **28** unchanged lines in **1** file lost coverage. * Overall coverage increased (+**0.06%**) to **65.314%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/auth/MySQLAuthenticationEngine.java](https://coveralls.io/builds/25866360/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fmysql%2Fauth%2FMySQLAuthenticationEngine.java#L75) | 11 | 12 | 91.67% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [sharding-proxy/sharding-proxy-bootstrap/src/main/java/org/apache/shardingsphere/shardingproxy/Bootstrap.java](https://coveralls.io/builds/25866360/source?filename=sharding-proxy%2Fsharding-proxy-bootstrap%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2FBootstrap.java#L81) | 28 | 0.0% | | Totals | [](https://coveralls.io/builds/25866360) | | :-- | --: | | Change from base [Build 400](https://coveralls.io/builds/25853436): | 0.06% | | Covered Lines: | 9622 | | Relevant Lines: | 14732 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #3090: Generic insert statement for Sharding and encrypt on optimize module
terrymanu opened a new pull request #3090: Generic insert statement for Sharding and encrypt on optimize module URL: https://github.com/apache/incubator-shardingsphere/pull/3090 For #3061. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] tristaZero commented on a change in pull request #263: update doc
tristaZero commented on a change in pull request #263: update doc URL: https://github.com/apache/incubator-shardingsphere-doc/pull/263#discussion_r327042050 ## File path: community/content/team/_index.cn.md ## @@ -16,25 +16,27 @@ ShardingSphere团队由项目成员和提交者组成。成员可以直接访问 | 名字 | GithubUsername | Review comment: How about using GitHub ID instead of GithubUsername? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] tristaZero commented on a change in pull request #263: update doc
tristaZero commented on a change in pull request #263: update doc
URL:
https://github.com/apache/incubator-shardingsphere-doc/pull/263#discussion_r327043786
##
File path:
document/current/content/manual/sharding-jdbc/usage/transaction.en.md
##
@@ -46,7 +46,7 @@ Currently, we have integrated saga and seata into
shardingsphere.
```
-`${shardingsphere-spi-impl.version}` mentioned has not been posted to the
central maven repository, so you need to install it by yourself.
+`${shardingsphere-spi-impl.version}` mentioned has not been posted to the
central maven repository, so you need to install it by yourself.project
address:
[shardingsphere-spi-impl](https://github.com/sharding-sphere/shardingsphere-spi-impl)
Review comment:
`projectt address: [...` should have a capital.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3089: Refactor: improve some codes not that graceful
terrymanu merged pull request #3089: Refactor: improve some codes not that graceful URL: https://github.com/apache/incubator-shardingsphere/pull/3089 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] taojintianxia opened a new pull request #3089: Refactor: improve some codes not that graceful
taojintianxia opened a new pull request #3089: Refactor: improve some codes not that graceful URL: https://github.com/apache/incubator-shardingsphere/pull/3089 Changes proposed in this pull request: - improve some codes not that graceful This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] sunbufu closed issue #3016: JdbcTemplate DDL isn't working
sunbufu closed issue #3016: JdbcTemplate DDL isn't working URL: https://github.com/apache/incubator-shardingsphere/issues/3016 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] happy89lgk commented on issue #3016: JdbcTemplate DDL isn't working
happy89lgk commented on issue #3016: JdbcTemplate DDL isn't working URL: https://github.com/apache/incubator-shardingsphere/issues/3016#issuecomment-534017000 ok,thank you This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3087: For #3032, add missing dcl test cases for alter relative grammars.
terrymanu merged pull request #3087: For #3032, add missing dcl test cases for alter relative grammars. URL: https://github.com/apache/incubator-shardingsphere/pull/3087 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #2819: How to turn off keyGenerator feature in 4.0.0-RC1 version
terrymanu closed issue #2819: How to turn off keyGenerator feature in 4.0.0-RC1 version URL: https://github.com/apache/incubator-shardingsphere/issues/2819 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2819: How to turn off keyGenerator feature in 4.0.0-RC1 version
terrymanu commented on issue #2819: How to turn off keyGenerator feature in 4.0.0-RC1 version URL: https://github.com/apache/incubator-shardingsphere/issues/2819#issuecomment-534013554 Closed because no response any more This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3006: 4.0.0-RC2 ResultSetMetaData data was lost
terrymanu commented on issue #3006: 4.0.0-RC2 ResultSetMetaData data was lost URL: https://github.com/apache/incubator-shardingsphere/issues/3006#issuecomment-534011820 How to understand `one field is the content of another field` ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3009: Define variable in sql
terrymanu commented on issue #3009: Define variable in sql URL: https://github.com/apache/incubator-shardingsphere/issues/3009#issuecomment-534011254 The ROI of support variable is pretty low, no plan to do this for now This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #3009: Define variable in sql
terrymanu closed issue #3009: Define variable in sql URL: https://github.com/apache/incubator-shardingsphere/issues/3009 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3008: Non-sub-database and sub-table, page query limit Bug
terrymanu commented on issue #3008: Non-sub-database and sub-table, page query limit Bug URL: https://github.com/apache/incubator-shardingsphere/issues/3008#issuecomment-534010957 Can you provide your version of shardingsphere? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-example] hanxuewen opened a new issue #181: 主键赋值错误，或者未赋值
hanxuewen opened a new issue #181: 主键赋值错误，或者未赋值
URL: https://github.com/apache/incubator-shardingsphere-example/issues/181
spring-datasource配置：
`
123
10
`
Mybaits：
`
SELECT LAST_INSERT_ID()
insert into ec_order (order_no, member_id, member_name,
source, order_type, order_total_price,
actually_pay_price, goods_total_price, freight_price,
activity_price, is_use_coupon, is_invoice,
order_status, pay_status, is_split,
user_remark, order_remark, is_admin_order,
order_time, pay_time, return_type,
payment, ip_address, is_logistic
)
values (#{orderNo,jdbcType=VARCHAR}, #{memberId,jdbcType=BIGINT},
#{memberName,jdbcType=VARCHAR},
#{source,jdbcType=VARCHAR}, #{orderType,jdbcType=INTEGER},
#{orderTotalPrice,jdbcType=DOUBLE},
#{actuallyPayPrice,jdbcType=DOUBLE},
#{goodsTotalPrice,jdbcType=DOUBLE}, #{freightPrice,jdbcType=DOUBLE},
#{activityPrice,jdbcType=DOUBLE}, #{isUseCoupon,jdbcType=INTEGER},
#{isInvoice,jdbcType=INTEGER},
#{orderStatus,jdbcType=INTEGER}, #{payStatus,jdbcType=INTEGER},
#{isSplit,jdbcType=INTEGER},
#{userRemark,jdbcType=VARCHAR}, #{orderRemark,jdbcType=VARCHAR},
#{isAdminOrder,jdbcType=INTEGER},
#{orderTime,jdbcType=TIMESTAMP}, #{payTime,jdbcType=TIMESTAMP},
#{returnType,jdbcType=INTEGER},
#{payment,jdbcType=INTEGER}, #{ipAddress,jdbcType=VARCHAR},
#{isLogistic,jdbcType=INTEGER}
)
`
没有自动追加ID，但是却把ID赋值到了别的字段:is_admin_order了
但是如果我把mybaits的insert SQL追加上ID，就不会赋值错误，但是ID也没有值，插入导数据库用的是mysql的自增值
这个问题该如何处理
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere-doc] betterjava edited a comment on issue #247: add doc for proxy-hint feature
betterjava edited a comment on issue #247: add doc for proxy-hint feature URL: https://github.com/apache/incubator-shardingsphere-doc/issues/247#issuecomment-533787972 - [ ] sctl-sharding-proxy-control-language-cn - [x] sctl-sharding-proxy-control-update - [ ] sctl-sharding-proxy-control-query - [ ] sctl-sharding-proxy-control-language-en - [x] sctl-sharding-proxy-control-update - [ ] sctl-sharding-proxy-control-query This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] betterjava edited a comment on issue #247: add doc for proxy-hint feature
betterjava edited a comment on issue #247: add doc for proxy-hint feature URL: https://github.com/apache/incubator-shardingsphere-doc/issues/247#issuecomment-533787972 - [ ] sctl-sharding-proxy-control-language-cn - [x] sctl-sharding-proxy-control-update - [ ] sctl-sharding-proxy-control-query - [ ] sctl-sharding-proxy-control-language-en - [ ] sctl-sharding-proxy-control-update - [ ] sctl-sharding-proxy-control-query This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] betterjava opened a new pull request #264: add doc for proxy-hint update
betterjava opened a new pull request #264: add doc for proxy-hint update URL: https://github.com/apache/incubator-shardingsphere-doc/pull/264 add doc for proxy-hint update This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] sunbufu commented on issue #3079: Fixes #3068 Add a judgment for user's database privileges.
sunbufu commented on issue #3079: Fixes #3068 Add a judgment for user's database privileges. URL: https://github.com/apache/incubator-shardingsphere/pull/3079#issuecomment-533977328 > Hi, i have a suggestion. i check the [Server Error Message Reference](https://dev.mysql.com/doc/refman/5.7/en/server-error-reference.html), i think the error message of access denied for user should be different from access denied for user to database. Good job! I think we should consider this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] Shj451148969 commented on issue #2712: 【4.0.0-RC2 & 4.0.0-RC3-SNAPSHOT】sharding-jdbc-spring-boot-starter init dataSource failed
Shj451148969 commented on issue #2712: 【4.0.0-RC2 & 4.0.0-RC3-SNAPSHOT】sharding-jdbc-spring-boot-starter init dataSource failed URL: https://github.com/apache/incubator-shardingsphere/issues/2712#issuecomment-533975854 I meet the same problem This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] yanyzy commented on issue #3079: Fixes #3068 Add a judgment for user's database privileges.
yanyzy commented on issue #3079: Fixes #3068 Add a judgment for user's database privileges. URL: https://github.com/apache/incubator-shardingsphere/pull/3079#issuecomment-533974857 Hi, i have a suggestion. i check the [Server Error Message Reference](https://dev.mysql.com/doc/refman/5.7/en/server-error-reference.html), i think the error message of access denied for user should be different from access denied for user to database. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] haocao opened a new pull request #3087: For #3032, add missing dcl test cases for alter relative grammars.
haocao opened a new pull request #3087: For #3032, add missing dcl test cases for alter relative grammars. URL: https://github.com/apache/incubator-shardingsphere/pull/3087 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] betterjava opened a new pull request #3086: support query hint context for sharding-proxy
betterjava opened a new pull request #3086: support query hint context for sharding-proxy URL: https://github.com/apache/incubator-shardingsphere/pull/3086 Fixes #3057. Changes proposed in this pull request: - support query hint context for sharding-proxy - sctl:hint show status result like that: | master_only | sharding_type | |---|---| |true / false|databases_only / databases_tables| - sctl:hint show table status result like that: | table_name |database_sharding_values|table_sharding_values| |---|---|---| | t_order |value1,value2|value3,value4| This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] beckhampu commented on issue #3019: maven build errors
beckhampu commented on issue #3019: maven build errors URL: https://github.com/apache/incubator-shardingsphere/issues/3019#issuecomment-533968992 @Myshiner , has your problem been solved? Can you give me some feedback? Thx！ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
