[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4990: Update description in scaling-principle-overview.en.png

2020-03-28 Thread GitBox
terrymanu merged pull request #4990: Update description in 
scaling-principle-overview.en.png
URL: https://github.com/apache/incubator-shardingsphere/pull/4990
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] cherrylzhao opened a new issue #4991: make ShardingDataSource compatible with Seata in micro service distribution transaction

2020-03-28 Thread GitBox
cherrylzhao opened a new issue #4991: make ShardingDataSource compatible with 
Seata in micro service distribution transaction
URL: https://github.com/apache/incubator-shardingsphere/issues/4991
 
 
   In micro-service distribution transaction, Seata will wrap 
`ShardingDataSource` as `DataSourceProxy` which communication with seata-server 
through RPC protocol,
   and DataSourceProxy will invoke some standard JDBC interface to get metadata 
from ShardingDataSource, however ShardingDataSource don't compatible with it. I 
have investigated in my local environment and found these issues we should 
resolve
   - [ ] support get information by logical schema in CachedDataBaseMetaData
   - [ ] support getParameterMetaData in ShardingPreparedStatement
   - [ ] add `client.transaction.micro-service-enable` in 
sharding-transaction-base-seata-at
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] cherrylzhao closed issue #4884: io.seata.config.ConfigFuture - config operation timeout, cost:5002 ms

2020-03-28 Thread GitBox
cherrylzhao closed issue #4884: io.seata.config.ConfigFuture - config operation 
timeout,cost:5002 ms
URL: https://github.com/apache/incubator-shardingsphere/issues/4884
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] coveralls commented on issue #4990: Update description in scaling-principle-overview.en.png

2020-03-28 Thread GitBox
coveralls commented on issue #4990: Update description in 
scaling-principle-overview.en.png
URL: 
https://github.com/apache/incubator-shardingsphere/pull/4990#issuecomment-605543504
 
 
   ## Pull Request Test Coverage Report for [Build 
10683](https://coveralls.io/builds/29684701)
   
   * **0** of **0**   changed or added relevant lines in **0** files are 
covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage remained the same at **57.527%**
   
   ---
   
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/29684701/badge)](https://coveralls.io/builds/29684701)
 |
   | :-- | --: |
   | Change from base [Build 10682](https://coveralls.io/builds/29681056): |  
0.0% |
   | Covered Lines: | 11773 |
   | Relevant Lines: | 20465 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4990: Update description in scaling-principle-overview.en.png

2020-03-28 Thread GitBox
codecov-io commented on issue #4990: Update description in 
scaling-principle-overview.en.png
URL: 
https://github.com/apache/incubator-shardingsphere/pull/4990#issuecomment-605543073
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4990?src=pr=h1)
 Report
   > Merging 
[#4990](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4990?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/3b01bb63a56103eac61194c81c452864872bf3bf=desc)
 will **not change** coverage by `%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4990/graphs/tree.svg?width=650=150=pr=ZvlXpWa7so)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4990?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master#4990   +/-   ##
   =
 Coverage 54.02%   54.02%   
 Complexity  442  442   
   =
 Files  1146 1146   
 Lines 2046520465   
 Branches   3744 3744   
   =
 Hits  1105711057   
 Misses 8704 8704   
 Partials704  704   
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4990?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4990?src=pr=footer).
 Last update 
[3b01bb6...939ba25](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4990?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] KomachiSion opened a new pull request #4990: Update description in scaling-principle-overview.en.png

2020-03-28 Thread GitBox
KomachiSion opened a new pull request #4990: Update description in 
scaling-principle-overview.en.png
URL: https://github.com/apache/incubator-shardingsphere/pull/4990
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[incubator-shardingsphere-benchmark] branch master updated: for performance

2020-03-28 Thread zhangyonglun
This is an automated email from the ASF dual-hosted git repository.

zhangyonglun pushed a commit to branch master
in repository 
https://gitbox.apache.org/repos/asf/incubator-shardingsphere-benchmark.git


The following commit(s) were added to refs/heads/master by this push:
 new 8111819  for performance
8111819 is described below

commit 811181983906cb163a5ba8ec4df4105091cdaae8
Author: tuohai666 
AuthorDate: Sun Mar 29 04:51:59 2020 +0800

for performance
---
 report/jtl_json/full_route_test.json| 2 +-
 report/jtl_json/master_slave_encrypt_sharding_test.json | 2 +-
 report/jtl_json/master_slave_test.json  | 2 +-
 report/jtl_json/single_route_test.json  | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/report/jtl_json/full_route_test.json 
b/report/jtl_json/full_route_test.json
index 5dda7aa..491bcc0 100644
--- a/report/jtl_json/full_route_test.json
+++ b/report/jtl_json/full_route_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [{"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1", 
"Max": "10", "Min": "0", "Throughout": "23036.87", "Samples": 4999, "Date": 
"2019.12.19 02:35:57 ", "Avg": "0"}, {"99.9th": "9", "Err": "0.0%", "95th": 
"2", "50th": "1", "Max": "9", "Min": "0", "Throughout": "22619.91", "Samples": 
4999, "Date": "2019.12.20 13:34:47 ", "Avg": "0"}, {"99.9th": "9", "Err": 
"0.0%", "95th": "2", "50th": "1", "Max": "9", "Min": "0", "Throughout": 
"22931.19", "Samples": 4999, "Date": [...]
\ No newline at end of file
+{"SELECT": [{"data": [{"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1", 
"Max": "10", "Min": "0", "Throughout": "23036.87", "Samples": 4999, "Date": 
"2019.12.19 02:35:57 ", "Avg": "0"}, {"99.9th": "9", "Err": "0.0%", "95th": 
"2", "50th": "1", "Max": "9", "Min": "0", "Throughout": "22619.91", "Samples": 
4999, "Date": "2019.12.20 13:34:47 ", "Avg": "0"}, {"99.9th": "9", "Err": 
"0.0%", "95th": "2", "50th": "1", "Max": "9", "Min": "0", "Throughout": 
"22931.19", "Samples": 4999, "Date": [...]
\ No newline at end of file
diff --git a/report/jtl_json/master_slave_encrypt_sharding_test.json 
b/report/jtl_json/master_slave_encrypt_sharding_test.json
index 9499543..b652a61 100644
--- a/report/jtl_json/master_slave_encrypt_sharding_test.json
+++ b/report/jtl_json/master_slave_encrypt_sharding_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [{"99.9th": "16", "Err": "0.0%", "95th": "3", "50th": 
"2", "Max": "66", "Min": "1", "Throughout": "9381.73", "Samples": 99, 
"Date": "2019.12.19 02:40:33 ", "Avg": "2"}, {"99.9th": "16", "Err": "0.0%", 
"95th": "3", "50th": "2", "Max": "62", "Min": "1", "Throughout": "9038.48", 
"Samples": 99, "Date": "2019.12.20 13:39:23 ", "Avg": "2"}, {"99.9th": 
"16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "63", "Min": "1", 
"Throughout": "9071.44", "Samples": 99, [...]
\ No newline at end of file
+{"SELECT": [{"data": [{"99.9th": "16", "Err": "0.0%", "95th": "3", "50th": 
"2", "Max": "66", "Min": "1", "Throughout": "9381.73", "Samples": 99, 
"Date": "2019.12.19 02:40:33 ", "Avg": "2"}, {"99.9th": "16", "Err": "0.0%", 
"95th": "3", "50th": "2", "Max": "62", "Min": "1", "Throughout": "9038.48", 
"Samples": 99, "Date": "2019.12.20 13:39:23 ", "Avg": "2"}, {"99.9th": 
"16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "63", "Min": "1", 
"Throughout": "9071.44", "Samples": 99, [...]
\ No newline at end of file
diff --git a/report/jtl_json/master_slave_test.json 
b/report/jtl_json/master_slave_test.json
index 43b56f1..6d9e906 100644
--- a/report/jtl_json/master_slave_test.json
+++ b/report/jtl_json/master_slave_test.json
@@ -1 +1 @@
-{"INSERT+SELECT+DELETE": [{"data": [], "type": "Sharding-Proxy_3.1"}, {"data": 
[{"99.9th": "38", "Err": "0.0%", "95th": "16", "50th": "11", "Max": "48", 
"Min": "7", "Throughout": "1720.96", "Samples": 29709, "Date": "2020.01.01 
02:49:45 ", "Avg": "11"}, {"99.9th": "27", "Err": "0.0%", "95th": "16", "50th": 
"11", "Max": "37", "Min": "7", "Throughout": "1701.38", "Samples": 17218, 
"Date": "2020.01.02 02:49:52 ", "Avg": "11"}, {"99.9th": "30", "Err": "0.0%", 
"95th": "16", "50th": "11", "Max [...]
\ No newline at end of file
+{"INSERT+SELECT+DELETE": [{"data": [], "type": "Sharding-Proxy_3.1"}, {"data": 
[{"99.9th": "38", "Err": "0.0%", "95th": "16", "50th": "11", "Max": "48", 
"Min": "7", "Throughout": "1720.96", "Samples": 29709, "Date": "2020.01.01 
02:49:45 ", "Avg": "11"}, {"99.9th": "27", "Err": "0.0%", "95th": "16", "50th": 
"11", "Max": "37", "Min": "7", "Throughout": "1701.38", "Samples": 17218, 
"Date": "2020.01.02 02:49:52 ", "Avg": "11"}, {"99.9th": "30", "Err": "0.0%", 
"95th": "16", "50th": "11", "Max [...]
\ No newline at end of file
diff --git a/report/jtl_json/single_route_test.json 
b/report/jtl_json/single_route_test.json
index 8e0cf9e..54a9f38 100644
--- a/report/jtl_json/single_route_test.json
+++ b/report/jtl_json/single_route_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [], "type": 

[GitHub] [incubator-shardingsphere] ranjeet-floyd commented on issue #4784: Throw NPE when INSERT column and values mismatch

2020-03-28 Thread GitBox
ranjeet-floyd commented on issue #4784: Throw NPE when INSERT column and values 
mismatch
URL: 
https://github.com/apache/incubator-shardingsphere/issues/4784#issuecomment-605488820
 
 
   @terrymanu  Thanks but  Not able to find it. Can you please point to class.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] tuohai666 merged pull request #4989: Use PrepareEngine for encrypt and master-slave

2020-03-28 Thread GitBox
tuohai666 merged pull request #4989: Use PrepareEngine for encrypt and 
master-slave
URL: https://github.com/apache/incubator-shardingsphere/pull/4989
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4989: Use PrepareEngine for encrypt and master-slave

2020-03-28 Thread GitBox
terrymanu opened a new pull request #4989: Use PrepareEngine for encrypt and 
master-slave
URL: https://github.com/apache/incubator-shardingsphere/pull/4989
 
 
   For #3691.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4987: Add start-index and stop-index assertion for ConstraintDefinitionSegment

2020-03-28 Thread GitBox
terrymanu merged pull request #4987: Add start-index and stop-index assertion 
for ConstraintDefinitionSegment
URL: https://github.com/apache/incubator-shardingsphere/pull/4987
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] terrymanu closed issue #4890: Add start-index and stop-index assertion for ConstraintDefinitionSegment

2020-03-28 Thread GitBox
terrymanu closed issue #4890: Add start-index and stop-index assertion for 
ConstraintDefinitionSegment
URL: https://github.com/apache/incubator-shardingsphere/issues/4890
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] dongzl merged pull request #4988: Establish shardingsphere-pluggable module

2020-03-28 Thread GitBox
dongzl merged pull request #4988: Establish shardingsphere-pluggable module
URL: https://github.com/apache/incubator-shardingsphere/pull/4988
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4988: Establish shardingsphere-pluggable module

2020-03-28 Thread GitBox
terrymanu opened a new pull request #4988: Establish shardingsphere-pluggable 
module
URL: https://github.com/apache/incubator-shardingsphere/pull/4988
 
 
   For #3691.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] coveralls commented on issue #4987: Add start-index and stop-index assertion for ConstraintDefinitionSegment

2020-03-28 Thread GitBox
coveralls commented on issue #4987: Add start-index and stop-index assertion 
for ConstraintDefinitionSegment
URL: 
https://github.com/apache/incubator-shardingsphere/pull/4987#issuecomment-605444872
 
 
   ## Pull Request Test Coverage Report for [Build 
10677](https://coveralls.io/builds/29678681)
   
   * **0** of **0**   changed or added relevant lines in **0** files are 
covered.
   * **3** unchanged lines in **1** file lost coverage.
   * Overall coverage decreased (**-0.005%**) to **57.627%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-|--|--: |
   | 
[sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29678681/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L63)
 | 3 | 76.0% |
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/29678681/badge)](https://coveralls.io/builds/29678681)
 |
   | :-- | --: |
   | Change from base [Build 1202](https://coveralls.io/builds/29676912): |  
-0.005% |
   | Covered Lines: | 11825 |
   | Relevant Lines: | 20520 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4987: Add start-index and stop-index assertion for ConstraintDefinitionSegment

2020-03-28 Thread GitBox
codecov-io commented on issue #4987: Add start-index and stop-index assertion 
for ConstraintDefinitionSegment
URL: 
https://github.com/apache/incubator-shardingsphere/pull/4987#issuecomment-605444344
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4987?src=pr=h1)
 Report
   > Merging 
[#4987](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4987?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/3876ffaba720cee808b3514ae90097c03292793f=desc)
 will **not change** coverage by `%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4987/graphs/tree.svg?width=650=150=pr=ZvlXpWa7so)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4987?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master#4987   +/-   ##
   =
 Coverage 54.13%   54.13%   
 Complexity  444  444   
   =
 Files  1146 1146   
 Lines 2052020520   
 Branches   3746 3746   
   =
 Hits  1110911109   
 Misses 8707 8707   
 Partials704  704   
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4987?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4987?src=pr=footer).
 Last update 
[3876ffa...c802e06](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4987?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] strongduanmu opened a new pull request #4987: Add start-index and stop-index assertion for ConstraintDefinitionSegment

2020-03-28 Thread GitBox
strongduanmu opened a new pull request #4987: Add start-index and stop-index 
assertion for ConstraintDefinitionSegment
URL: https://github.com/apache/incubator-shardingsphere/pull/4987
 
 
   Fixes #4890 .
   
   Changes proposed in this pull request:
   - Add start-index and stop-index assertion for ConstraintDefinitionSegment
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] zjls007 closed issue #4954: how i use sharding-jdbc-spring-boot-starter with spring-jdbc use seata-at, your example is raw-jdbc, can you help me

2020-03-28 Thread GitBox
zjls007 closed issue #4954: how i use sharding-jdbc-spring-boot-starter with 
spring-jdbc use seata-at,your example is raw-jdbc, can you help me
URL: https://github.com/apache/incubator-shardingsphere/issues/4954
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] zjls007 commented on issue #4954: how i use sharding-jdbc-spring-boot-starter with spring-jdbc use seata-at, your example is raw-jdbc, can you help me

2020-03-28 Thread GitBox
zjls007 commented on issue #4954: how i use sharding-jdbc-spring-boot-starter 
with spring-jdbc use seata-at,your example is raw-jdbc, can you help me
URL: 
https://github.com/apache/incubator-shardingsphere/issues/4954#issuecomment-605430259
 
 
   thanks, main question Solved,work happy for you!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] cherrylzhao commented on issue #4954: how i use sharding-jdbc-spring-boot-starter with spring-jdbc use seata-at, your example is raw-jdbc, can you help me

2020-03-28 Thread GitBox
cherrylzhao commented on issue #4954: how i use 
sharding-jdbc-spring-boot-starter with spring-jdbc use seata-at,your example is 
raw-jdbc, can you help me
URL: 
https://github.com/apache/incubator-shardingsphere/issues/4954#issuecomment-605428320
 
 
   here is the 
[transaction-base-seata-spring-boot-example](https://github.com/apache/incubator-shardingsphere/tree/master/examples/sharding-jdbc-example/transaction-example/transaction-base-seata-spring-boot-example),
 hope this will help you


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] strongduanmu commented on issue #4890: Add start-index and stop-index assertion for ConstraintDefinitionSegment

2020-03-28 Thread GitBox
strongduanmu commented on issue #4890: Add start-index and stop-index assertion 
for ConstraintDefinitionSegment
URL: 
https://github.com/apache/incubator-shardingsphere/issues/4890#issuecomment-605424809
 
 
   Can I try to solve this issue?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] lennonn commented on issue #4986: if field name of table is "call", encrypt not work.

2020-03-28 Thread GitBox
lennonn commented on issue #4986: if field name of table  is "call",encrypt not 
work.
URL: 
https://github.com/apache/incubator-shardingsphere/issues/4986#issuecomment-605422346
 
 
   > can you show Encryptor rule config?
   
   ```
   encryptors:
 aes:
   props:
 aes.key.value: '123456'
   type: AES
   tables:
 test:
   columns:
 call:
   assistedQueryColumn: ''
   cipherColumn: cipher_call
   encryptor: aes
   plainColumn: ''
   ```
   
   
![image](https://user-images.githubusercontent.com/8982513/77820562-185e1d00-711e-11ea-8b8d-ab2dbb32eba9.png)
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] yu199195 commented on issue #4986: if field name of table is "call", encrypt not work.

2020-03-28 Thread GitBox
yu199195 commented on issue #4986: if field name of table  is "call",encrypt 
not work.
URL: 
https://github.com/apache/incubator-shardingsphere/issues/4986#issuecomment-605421144
 
 
   can you show Encryptor rule config?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] lennonn opened a new issue #4986: if field name of table is "call", encrypt not work.

2020-03-28 Thread GitBox
lennonn opened a new issue #4986: if field name of table  is "call",encrypt not 
work.
URL: https://github.com/apache/incubator-shardingsphere/issues/4986
 
 
   
   ### version 4.0.1
   SQL: jdbcTemplate.update("INSERT INTO `test` (id,name,call) VALUES (1, '1', 
'1')");
   
   ### ERROR LOG:
   
   line 1:28 no viable alternative at input '(id,name,call'
   line 1:28 no viable alternative at input '(id,name,call'
   
   java.lang.IllegalStateException: Failed to execute CommandLineRunner
at 
org.springframework.boot.SpringApplication.callRunner(SpringApplication.java:787)
 [spring-boot-2.2.4.RELEASE.jar:2.2.4.RELEASE]
at 
org.springframework.boot.SpringApplication.callRunners(SpringApplication.java:768)
 [spring-boot-2.2.4.RELEASE.jar:2.2.4.RELEASE]
at 
org.springframework.boot.SpringApplication.run(SpringApplication.java:322) 
[spring-boot-2.2.4.RELEASE.jar:2.2.4.RELEASE]
at 
org.springframework.boot.SpringApplication.run(SpringApplication.java:1226) 
[spring-boot-2.2.4.RELEASE.jar:2.2.4.RELEASE]
at 
org.springframework.boot.SpringApplication.run(SpringApplication.java:1215) 
[spring-boot-2.2.4.RELEASE.jar:2.2.4.RELEASE]
at shardingtest.Application.main(Application.java:31) [classes/:na]
   Caused by: java.lang.IllegalStateException: null
at 
com.google.common.base.Preconditions.checkState(Preconditions.java:158) 
~[guava-18.0.jar:na]
at 
org.apache.shardingsphere.encrypt.rewrite.token.generator.impl.EncryptForUseDefaultInsertColumnsTokenGenerator.generateNewSQLToken(EncryptForUseDefaultInsertColumnsTokenGenerator.java:84)
 ~[encrypt-core-rewrite-4.0.1.jar:4.0.1]
at 
org.apache.shardingsphere.encrypt.rewrite.token.generator.impl.EncryptForUseDefaultInsertColumnsTokenGenerator.generateSQLToken(EncryptForUseDefaultInsertColumnsTokenGenerator.java:62)
 ~[encrypt-core-rewrite-4.0.1.jar:4.0.1]
at 
org.apache.shardingsphere.encrypt.rewrite.token.generator.impl.EncryptForUseDefaultInsertColumnsTokenGenerator.generateSQLToken(EncryptForUseDefaultInsertColumnsTokenGenerator.java:44)
 ~[encrypt-core-rewrite-4.0.1.jar:4.0.1]
at 
org.apache.shardingsphere.underlying.rewrite.sql.token.generator.SQLTokenGenerators.generateSQLTokens(SQLTokenGenerators.java:78)
 ~[shardingsphere-rewrite-engine-4.0.1.jar:4.0.1]
at 
org.apache.shardingsphere.underlying.rewrite.context.SQLRewriteContext.generateSQLTokens(SQLRewriteContext.java:83)
 ~[shardingsphere-rewrite-engine-4.0.1.jar:4.0.1]
at 
org.apache.shardingsphere.shardingjdbc.jdbc.core.statement.EncryptStatement.getRewriteSQL(EncryptStatement.java:100)
 ~[sharding-jdbc-core-4.0.1.jar:4.0.1]
at 
org.apache.shardingsphere.shardingjdbc.jdbc.core.statement.EncryptStatement.executeUpdate(EncryptStatement.java:124)
 ~[sharding-jdbc-core-4.0.1.jar:4.0.1]
at 
org.springframework.jdbc.core.JdbcTemplate$1UpdateStatementCallback.doInStatement(JdbcTemplate.java:531)
 ~[spring-jdbc-4.3.26.RELEASE.jar:4.3.26.RELEASE]
at 
org.springframework.jdbc.core.JdbcTemplate$1UpdateStatementCallback.doInStatement(JdbcTemplate.java:528)
 ~[spring-jdbc-4.3.26.RELEASE.jar:4.3.26.RELEASE]
at 
org.springframework.jdbc.core.JdbcTemplate.execute(JdbcTemplate.java:407) 
~[spring-jdbc-4.3.26.RELEASE.jar:4.3.26.RELEASE]
at 
org.springframework.jdbc.core.JdbcTemplate.update(JdbcTemplate.java:543) 
~[spring-jdbc-4.3.26.RELEASE.jar:4.3.26.RELEASE]
at shardingtest.Application.run(Application.java:59) [classes/:na]
at 
org.springframework.boot.SpringApplication.callRunner(SpringApplication.java:784)
 [spring-boot-2.2.4.RELEASE.jar:2.2.4.RELEASE]
... 5 common frames omitted
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4707: proxy-4.0.1 return wrong result when varchar value NULL in hibernate.

2020-03-28 Thread GitBox
tristaZero commented on issue #4707: proxy-4.0.1 return wrong result when 
varchar value NULL in hibernate.
URL: 
https://github.com/apache/incubator-shardingsphere/issues/4707#issuecomment-605416890
 
 
   @wangjing112 You detailed investigation seems convinced. 
   Could you provide us the Query SQL, parameters, and the configuration of the 
relevant query tables so that we can reproduce this exception in our local 
environment? You know, we need to do some debug. :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4985: add transaction-base-seata-spring-boot-example

2020-03-28 Thread GitBox
tristaZero merged pull request #4985: add 
transaction-base-seata-spring-boot-example
URL: https://github.com/apache/incubator-shardingsphere/pull/4985
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] coveralls commented on issue #4985: add transaction-base-seata-spring-boot-example

2020-03-28 Thread GitBox
coveralls commented on issue #4985: add 
transaction-base-seata-spring-boot-example
URL: 
https://github.com/apache/incubator-shardingsphere/pull/4985#issuecomment-605412792
 
 
   ## Pull Request Test Coverage Report for [Build 
2277](https://coveralls.io/builds/29676636)
   
   * **0** of **0**   changed or added relevant lines in **0** files are 
covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage remained the same at **57.632%**
   
   ---
   
   
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/29676636/badge)](https://coveralls.io/builds/29676636)
 |
   | :-- | --: |
   | Change from base [Build 1201](https://coveralls.io/builds/29675449): |  
0.0% |
   | Covered Lines: | 11826 |
   | Relevant Lines: | 20520 |
   
   ---
   #   - [Coveralls](https://coveralls.io)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-shardingsphere] cherrylzhao opened a new pull request #4985: add transaction-base-seata-spring-boot-example

2020-03-28 Thread GitBox
cherrylzhao opened a new pull request #4985: add 
transaction-base-seata-spring-boot-example
URL: https://github.com/apache/incubator-shardingsphere/pull/4985
 
 
   add transaction-base-seata-spring-boot-example


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services