[GitHub] [incubator-shardingsphere] codecov-io commented on issue #5013: add start-index and stop-index property in literal-expression for PR#5006
codecov-io commented on issue #5013: add start-index and stop-index property in literal-expression for PR#5006 URL: https://github.com/apache/incubator-shardingsphere/pull/5013#issuecomment-606412424 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5013?src=pr=h1) Report > Merging [#5013](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5013?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/026ef43e98dc7cd4481be69f4e80962fb3499a96=desc) will **increase** coverage by `0.01%`. > The diff coverage is `16.24%`. [](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5013?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5013 +/- ## + Coverage 53.82% 53.84% +0.01% - Complexity 441 443 +2 Files 1139 1140 +1 Lines 2047420472 -2 Branches 3741 3741 + Hits 1102111024 +3 + Misses 8748 8744 -4 + Partials705 704 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5013?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...sphere/encrypt/metadata/EncryptColumnMetaData.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5013/diff?src=pr=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvbWV0YWRhdGEvRW5jcnlwdENvbHVtbk1ldGFEYXRhLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ncrypt/metadata/EncryptTableMetaDataDecorator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5013/diff?src=pr=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvbWV0YWRhdGEvRW5jcnlwdFRhYmxlTWV0YURhdGFEZWNvcmF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...re/encrypt/merge/EncryptResultDecoratorEngine.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5013/diff?src=pr=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1tZXJnZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZW5jcnlwdC9tZXJnZS9FbmNyeXB0UmVzdWx0RGVjb3JhdG9yRW5naW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ite/context/EncryptSQLRewriteContextDecorator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5013/diff?src=pr=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1yZXdyaXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvY29udGV4dC9FbmNyeXB0U1FMUmV3cml0ZUNvbnRleHREZWNvcmF0b3IuamF2YQ==) | `80.00% <0.00%> (-8.89%)` | `0.00 <0.00> (ø)` | | | [...enerator/impl/EncryptProjectionTokenGenerator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5013/diff?src=pr=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1yZXdyaXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvdG9rZW4vZ2VuZXJhdG9yL2ltcGwvRW5jcnlwdFByb2plY3Rpb25Ub2tlbkdlbmVyYXRvci5qYXZh) | `82.50% <0.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...rslave/route/engine/MasterSlaveRouteDecorator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5013/diff?src=pr=tree#diff-bWFzdGVyLXNsYXZlLWNvcmUvbWFzdGVyLXNsYXZlLWNvcmUtcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21hc3RlcnNsYXZlL3JvdXRlL2VuZ2luZS9NYXN0ZXJTbGF2ZVJvdXRlRGVjb3JhdG9yLmphdmE=) | `89.47% <0.00%> (-4.98%)` | `0.00 <0.00> (ø)` | | | [...rite/context/ShadowSQLRewriteContextDecorator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5013/diff?src=pr=tree#diff-c2hhZG93LWNvcmUvc2hhZG93LWNvcmUtcmV3cml0ZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhZG93L3Jld3JpdGUvY29udGV4dC9TaGFkb3dTUUxSZXdyaXRlQ29udGV4dERlY29yYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ngsphere/core/metadata/ShardingMetaDataLoader.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5013/diff?src=pr=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9tZXRhZGF0YS9TaGFyZGluZ01ldGFEYXRhTG9hZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [.../core/metadata/ShardingTableMetaDataDecorator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5013/diff?src=pr=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9tZXRhZGF0YS9TaGFyZGluZ1RhYmxlTWV0YURhdGFEZWNvcmF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | |
[GitHub] [incubator-shardingsphere] strongduanmu opened a new pull request #5013: add start-index and stop-index property in literal-expression for PR#5006
strongduanmu opened a new pull request #5013: add start-index and stop-index property in literal-expression for PR#5006 URL: https://github.com/apache/incubator-shardingsphere/pull/5013 Fixes #4995 . Changes proposed in this pull request: - add start-index and stop-index property in literal-expression for PR#5006 - - This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] strongduanmu commented on issue #5006: add parsing integrated test for update query sql
strongduanmu commented on issue #5006: add parsing integrated test for update query sql URL: https://github.com/apache/incubator-shardingsphere/pull/5006#issuecomment-606387481 > Hi, @strongduanmu Good job. Thanks for your first contribution to the community, and hope to see your interaction with the community more. :) Currently I am learning SS source code, and I pay attention to the issue list every day, but some issues are a bit difficult for me now, I will continue to study hard, and then make more contributions to the community. If there is an issue of appropriate difficulty, you can assign it to me and I will be happy to solve it. @tristaZero This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #5006: add parsing integrated test for update query sql
tristaZero commented on issue #5006: add parsing integrated test for update query sql URL: https://github.com/apache/incubator-shardingsphere/pull/5006#issuecomment-606382806 Hi, @strongduanmu Good job. Thanks for your first contribution to the community, and hope to see your interaction with the community more. :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #5006: add parsing integrated test for update query sql
tristaZero merged pull request #5006: add parsing integrated test for update query sql URL: https://github.com/apache/incubator-shardingsphere/pull/5006 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero closed issue #4995: Add parsing integrated test for `update` query SQL
tristaZero closed issue #4995: Add parsing integrated test for `update` query SQL URL: https://github.com/apache/incubator-shardingsphere/issues/4995 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao merged pull request #4945: make key-generator as a spring bean on spring namespace.
cherrylzhao merged pull request #4945: make key-generator as a spring bean on spring namespace. URL: https://github.com/apache/incubator-shardingsphere/pull/4945 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao closed issue #1977: make key-generator and encryptor strategy as a spring bean on spring namespace
cherrylzhao closed issue #1977: make key-generator and encryptor strategy as a spring bean on spring namespace URL: https://github.com/apache/incubator-shardingsphere/issues/1977 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] yanyzy opened a new issue #5012: Shadow database judges incorrectly when using proxy
yanyzy opened a new issue #5012: Shadow database judges incorrectly when using proxy URL: https://github.com/apache/incubator-shardingsphere/issues/5012 ### Which version of ShardingSphere did you use? 5.0.0-RC1-SNAPSHOT ### Which project did you use? Sharding-JDBC or Sharding-Proxy? Sharding-Proxy ### Reason analyze (If you can) The boolean received by the proxy is 0/1，but the judgment method of the shadow database does not judge 0/1.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #3265: sharding-ui-frontend config file problem
terrymanu closed issue #3265: sharding-ui-frontend config file problem URL: https://github.com/apache/incubator-shardingsphere/issues/3265 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #5007: Fixes Issue3265
terrymanu merged pull request #5007: Fixes Issue3265 URL: https://github.com/apache/incubator-shardingsphere/pull/5007 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #4978: Sharding-Proxy doesn't response for "Unsupported Command" from PSQL cli
terrymanu closed issue #4978: Sharding-Proxy doesn't response for "Unsupported Command" from PSQL cli URL: https://github.com/apache/incubator-shardingsphere/issues/4978 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #5009: #4978, Sharding-Proxy doesn't response for "Unsupported Command" from…
terrymanu merged pull request #5009: #4978, Sharding-Proxy doesn't response for "Unsupported Command" from… URL: https://github.com/apache/incubator-shardingsphere/pull/5009 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #5010: refactor schema metadata
terrymanu merged pull request #5010: refactor schema metadata URL: https://github.com/apache/incubator-shardingsphere/pull/5010 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] menghaoranss commented on a change in pull request #5007: Fixes Issue3265
menghaoranss commented on a change in pull request #5007: Fixes Issue3265
URL:
https://github.com/apache/incubator-shardingsphere/pull/5007#discussion_r400611088
##
File path:
shardingsphere-ui/shardingsphere-ui-backend/src/main/java/org/apache/shardingsphere/ui/servcie/impl/CenterConfigServiceImpl.java
##
@@ -102,6 +103,28 @@ public CenterConfigs loadAll(String orchestrationType) {
return result;
}
+@Override
+public void update(CenterConfigDTO config) {
+CenterConfigs configs = loadAll();
+if (!config.getPrimaryName().equals(config.getName())) {
+CenterConfig existedConfig = find(config.getName(),
config.getOrchestrationType(), configs);
+if (null != existedConfig) {
+throw new
ShardingSphereUIException(ShardingSphereUIException.SERVER_ERROR, "Center
already existed!");
Review comment:
fixed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #5007: Fixes Issue3265
kimmking commented on a change in pull request #5007: Fixes Issue3265
URL:
https://github.com/apache/incubator-shardingsphere/pull/5007#discussion_r400605593
##
File path:
shardingsphere-ui/shardingsphere-ui-backend/src/main/java/org/apache/shardingsphere/ui/servcie/impl/CenterConfigServiceImpl.java
##
@@ -102,6 +103,28 @@ public CenterConfigs loadAll(String orchestrationType) {
return result;
}
+@Override
+public void update(CenterConfigDTO config) {
+CenterConfigs configs = loadAll();
+if (!config.getPrimaryName().equals(config.getName())) {
+CenterConfig existedConfig = find(config.getName(),
config.getOrchestrationType(), configs);
+if (null != existedConfig) {
+throw new
ShardingSphereUIException(ShardingSphereUIException.SERVER_ERROR, "Center
already existed!");
Review comment:
Add name to messages.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #5011: Add getType for OrderAware
tristaZero merged pull request #5011: Add getType for OrderAware URL: https://github.com/apache/incubator-shardingsphere/pull/5011 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-shardingsphere-benchmark] branch master updated: for performance
This is an automated email from the ASF dual-hosted git repository.
zhangyonglun pushed a commit to branch master
in repository
https://gitbox.apache.org/repos/asf/incubator-shardingsphere-benchmark.git
The following commit(s) were added to refs/heads/master by this push:
new 76b3470 for performance
76b3470 is described below
commit 76b3470173a25ade50a81f03a31cd7067236db2b
Author: tuohai666
AuthorDate: Tue Mar 31 04:52:14 2020 +0800
for performance
---
report/jtl_json/full_route_test.json| 2 +-
report/jtl_json/master_slave_encrypt_sharding_test.json | 2 +-
report/jtl_json/master_slave_test.json | 2 +-
report/jtl_json/single_route_test.json | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/report/jtl_json/full_route_test.json
b/report/jtl_json/full_route_test.json
index 262ce47..d92ef0a 100644
--- a/report/jtl_json/full_route_test.json
+++ b/report/jtl_json/full_route_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [{"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1",
"Max": "10", "Min": "0", "Throughout": "23036.87", "Samples": 4999, "Date":
"2019.12.19 02:35:57 ", "Avg": "0"}, {"99.9th": "9", "Err": "0.0%", "95th":
"2", "50th": "1", "Max": "9", "Min": "0", "Throughout": "22619.91", "Samples":
4999, "Date": "2019.12.20 13:34:47 ", "Avg": "0"}, {"99.9th": "9", "Err":
"0.0%", "95th": "2", "50th": "1", "Max": "9", "Min": "0", "Throughout":
"22931.19", "Samples": 4999, "Date": [...]
\ No newline at end of file
+{"SELECT": [{"data": [{"99.9th": "9", "Err": "0.0%", "95th": "2", "50th": "1",
"Max": "10", "Min": "0", "Throughout": "23036.87", "Samples": 4999, "Date":
"2019.12.19 02:35:57 ", "Avg": "0"}, {"99.9th": "9", "Err": "0.0%", "95th":
"2", "50th": "1", "Max": "9", "Min": "0", "Throughout": "22619.91", "Samples":
4999, "Date": "2019.12.20 13:34:47 ", "Avg": "0"}, {"99.9th": "9", "Err":
"0.0%", "95th": "2", "50th": "1", "Max": "9", "Min": "0", "Throughout":
"22931.19", "Samples": 4999, "Date": [...]
\ No newline at end of file
diff --git a/report/jtl_json/master_slave_encrypt_sharding_test.json
b/report/jtl_json/master_slave_encrypt_sharding_test.json
index 9839048..de36dbb 100644
--- a/report/jtl_json/master_slave_encrypt_sharding_test.json
+++ b/report/jtl_json/master_slave_encrypt_sharding_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [{"99.9th": "16", "Err": "0.0%", "95th": "3", "50th":
"2", "Max": "66", "Min": "1", "Throughout": "9381.73", "Samples": 99,
"Date": "2019.12.19 02:40:33 ", "Avg": "2"}, {"99.9th": "16", "Err": "0.0%",
"95th": "3", "50th": "2", "Max": "62", "Min": "1", "Throughout": "9038.48",
"Samples": 99, "Date": "2019.12.20 13:39:23 ", "Avg": "2"}, {"99.9th":
"16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "63", "Min": "1",
"Throughout": "9071.44", "Samples": 99, [...]
\ No newline at end of file
+{"SELECT": [{"data": [{"99.9th": "16", "Err": "0.0%", "95th": "3", "50th":
"2", "Max": "66", "Min": "1", "Throughout": "9381.73", "Samples": 99,
"Date": "2019.12.19 02:40:33 ", "Avg": "2"}, {"99.9th": "16", "Err": "0.0%",
"95th": "3", "50th": "2", "Max": "62", "Min": "1", "Throughout": "9038.48",
"Samples": 99, "Date": "2019.12.20 13:39:23 ", "Avg": "2"}, {"99.9th":
"16", "Err": "0.0%", "95th": "3", "50th": "2", "Max": "63", "Min": "1",
"Throughout": "9071.44", "Samples": 99, [...]
\ No newline at end of file
diff --git a/report/jtl_json/master_slave_test.json
b/report/jtl_json/master_slave_test.json
index 96d9d39..31ee20a 100644
--- a/report/jtl_json/master_slave_test.json
+++ b/report/jtl_json/master_slave_test.json
@@ -1 +1 @@
-{"INSERT+SELECT+DELETE": [{"data": [], "type": "Sharding-Proxy_3.1"}, {"data":
[{"99.9th": "38", "Err": "0.0%", "95th": "16", "50th": "11", "Max": "48",
"Min": "7", "Throughout": "1720.96", "Samples": 29709, "Date": "2020.01.01
02:49:45 ", "Avg": "11"}, {"99.9th": "27", "Err": "0.0%", "95th": "16", "50th":
"11", "Max": "37", "Min": "7", "Throughout": "1701.38", "Samples": 17218,
"Date": "2020.01.02 02:49:52 ", "Avg": "11"}, {"99.9th": "30", "Err": "0.0%",
"95th": "16", "50th": "11", "Max [...]
\ No newline at end of file
+{"INSERT+SELECT+DELETE": [{"data": [], "type": "Sharding-Proxy_3.1"}, {"data":
[{"99.9th": "38", "Err": "0.0%", "95th": "16", "50th": "11", "Max": "48",
"Min": "7", "Throughout": "1720.96", "Samples": 29709, "Date": "2020.01.01
02:49:45 ", "Avg": "11"}, {"99.9th": "27", "Err": "0.0%", "95th": "16", "50th":
"11", "Max": "37", "Min": "7", "Throughout": "1701.38", "Samples": 17218,
"Date": "2020.01.02 02:49:52 ", "Avg": "11"}, {"99.9th": "30", "Err": "0.0%",
"95th": "16", "50th": "11", "Max [...]
\ No newline at end of file
diff --git a/report/jtl_json/single_route_test.json
b/report/jtl_json/single_route_test.json
index c4d9240..d1a1afa 100644
--- a/report/jtl_json/single_route_test.json
+++ b/report/jtl_json/single_route_test.json
@@ -1 +1 @@
-{"SELECT": [{"data": [], "type":
[GitHub] [incubator-shardingsphere] coveralls commented on issue #5011: Add getType for OrderAware
coveralls commented on issue #5011: Add getType for OrderAware URL: https://github.com/apache/incubator-shardingsphere/pull/5011#issuecomment-606154214 ## Pull Request Test Coverage Report for [Build 10713](https://coveralls.io/builds/29716794) * **0** of **16** **(0.0%)** changed or added relevant lines in **9** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage decreased (**-0.02%**) to **57.309%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [encrypt-core/encrypt-core-merge/src/main/java/org/apache/shardingsphere/encrypt/merge/EncryptResultDecoratorEngine.java](https://coveralls.io/builds/29716794/source?filename=encrypt-core%2Fencrypt-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Fmerge%2FEncryptResultDecoratorEngine.java#L60) | 0 | 1 | 0.0% | [encrypt-core/encrypt-core-rewrite/src/main/java/org/apache/shardingsphere/encrypt/rewrite/context/EncryptSQLRewriteContextDecorator.java](https://coveralls.io/builds/29716794/source?filename=encrypt-core%2Fencrypt-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Frewrite%2Fcontext%2FEncryptSQLRewriteContextDecorator.java#L53) | 0 | 1 | 0.0% | [master-slave-core/master-slave-core-route/src/main/java/org/apache/shardingsphere/masterslave/route/engine/MasterSlaveRouteDecorator.java](https://coveralls.io/builds/29716794/source?filename=master-slave-core%2Fmaster-slave-core-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmasterslave%2Froute%2Fengine%2FMasterSlaveRouteDecorator.java#L68) | 0 | 1 | 0.0% | [shadow-core/shadow-core-rewrite/src/main/java/org/apache/shardingsphere/shadow/rewrite/context/ShadowSQLRewriteContextDecorator.java](https://coveralls.io/builds/29716794/source?filename=shadow-core%2Fshadow-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshadow%2Frewrite%2Fcontext%2FShadowSQLRewriteContextDecorator.java#L51) | 0 | 1 | 0.0% | [sharding-core/sharding-core-merge/src/main/java/org/apache/shardingsphere/sharding/merge/ShardingResultMergerEngine.java](https://coveralls.io/builds/29716794/source?filename=sharding-core%2Fsharding-core-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Fmerge%2FShardingResultMergerEngine.java#L55) | 0 | 1 | 0.0% | [sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/sharding/rewrite/context/ShardingSQLRewriteContextDecorator.java](https://coveralls.io/builds/29716794/source?filename=sharding-core%2Fsharding-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Frewrite%2Fcontext%2FShardingSQLRewriteContextDecorator.java#L57) | 0 | 1 | 0.0% | [sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/sharding/route/engine/ShardingRouteDecorator.java](https://coveralls.io/builds/29716794/source?filename=sharding-core%2Fsharding-core-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Froute%2Fengine%2FShardingRouteDecorator.java#L162) | 0 | 1 | 0.0% | [shardingsphere-underlying/shardingsphere-pluggable/src/main/java/org/apache/shardingsphere/underlying/pluggble/merge/MergeEngine.java](https://coveralls.io/builds/29716794/source?filename=shardingsphere-underlying%2Fshardingsphere-pluggable%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Fpluggble%2Fmerge%2FMergeEngine.java#L66) | 0 | 3 | 0.0% | [shardingsphere-underlying/shardingsphere-pluggable/src/main/java/org/apache/shardingsphere/underlying/pluggble/prepare/BasePrepareEngine.java](https://coveralls.io/builds/29716794/source?filename=shardingsphere-underlying%2Fshardingsphere-pluggable%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Fpluggble%2Fprepare%2FBasePrepareEngine.java#L101) | 0 | 6 | 0.0% | Totals | [](https://coveralls.io/builds/29716794) | | :-- | --: | | Change from base [Build 10711](https://coveralls.io/builds/29715603): | -0.02% | | Covered Lines: | 11738 | | Relevant Lines: | 20482 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4945: make key-generator as a spring bean on spring namespace.
coveralls edited a comment on issue #4945: make key-generator as a spring bean on spring namespace. URL: https://github.com/apache/incubator-shardingsphere/pull/4945#issuecomment-604253200 ## Pull Request Test Coverage Report for [Build 10712](https://coveralls.io/builds/29716160) * **27** of **27** **(100.0%)** changed or added relevant lines in **9** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage increased (+**0.02%**) to **57.349%** --- | Totals | [](https://coveralls.io/builds/29716160) | | :-- | --: | | Change from base [Build 10711](https://coveralls.io/builds/29715603): | 0.02% | | Covered Lines: | 11740 | | Relevant Lines: | 20471 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io edited a comment on issue #4945: make key-generator as a spring bean on spring namespace.
codecov-io edited a comment on issue #4945: make key-generator as a spring bean on spring namespace. URL: https://github.com/apache/incubator-shardingsphere/pull/4945#issuecomment-604251543 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945?src=pr=h1) Report > Merging [#4945](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/e330c7b54315d33df1ae0ac14da17b1f5b6beb74=desc) will **increase** coverage by `0.02%`. > The diff coverage is `92.59%`. [](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4945 +/- ## + Coverage 53.82% 53.85% +0.02% - Complexity 441 443 +2 Files 1139 1140 +1 Lines 2047420471 -3 Branches 3741 3740 -1 + Hits 1102111024 +3 + Misses 8748 8743 -5 + Partials705 704 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...org/apache/shardingsphere/core/rule/TableRule.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/diff?src=pr=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9ydWxlL1RhYmxlUnVsZS5qYXZh) | `83.90% <75.00%> (-0.19%)` | `1.00 <0.00> (ø)` | | | [.../apache/shardingsphere/core/rule/ShardingRule.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/diff?src=pr=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9ydWxlL1NoYXJkaW5nUnVsZS5qYXZh) | `73.73% <80.00%> (-0.27%)` | `0.00 <0.00> (ø)` | | | [...api/config/sharding/KeyGeneratorConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/diff?src=pr=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYXBpL2NvbmZpZy9zaGFyZGluZy9LZXlHZW5lcmF0b3JDb25maWd1cmF0aW9uLmphdmE=) | `100.00% <100.00%> (+50.00%)` | `0.00 <0.00> (ø)` | | | [...strategy/keygen/SnowflakeKeyGenerateAlgorithm.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/diff?src=pr=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9zdHJhdGVneS9rZXlnZW4vU25vd2ZsYWtlS2V5R2VuZXJhdGVBbGdvcml0aG0uamF2YQ==) | `93.18% <100.00%> (ø)` | `0.00 <0.00> (?)` | | | [...core/strategy/keygen/UUIDKeyGenerateAlgorithm.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/diff?src=pr=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9zdHJhdGVneS9rZXlnZW4vVVVJREtleUdlbmVyYXRlQWxnb3JpdGhtLmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../swapper/KeyGeneratorConfigurationYamlSwapper.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/diff?src=pr=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS95YW1sL3N3YXBwZXIvS2V5R2VuZXJhdG9yQ29uZmlndXJhdGlvbllhbWxTd2FwcGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ithm/keygen/KeyGenerateAlgorithmServiceLoader.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/diff?src=pr=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3BpL2FsZ29yaXRobS9rZXlnZW4vS2V5R2VuZXJhdGVBbGdvcml0aG1TZXJ2aWNlTG9hZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | | | [...e/factorybean/KeyGenerateAlgorithmFactoryBean.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4945/diff?src=pr=tree#diff-c2hhcmRpbmctc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nLW5hbWVzcGFjZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdqZGJjL3NwcmluZy9uYW1lc3BhY2UvZmFjdG9yeWJlYW4vS2V5R2VuZXJhdGVBbGdvcml0aG1GYWN0b3J5QmVhbi5qYXZh) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | | |
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #5011: Add getType for OrderAware
terrymanu opened a new pull request #5011: Add getType for OrderAware URL: https://github.com/apache/incubator-shardingsphere/pull/5011 For #3691. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #5002: add start-index and stop-index for LiteralExpressionSegment
terrymanu merged pull request #5002: add start-index and stop-index for LiteralExpressionSegment URL: https://github.com/apache/incubator-shardingsphere/pull/5002 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #4781: Add start-index and stop-index assertion for LiteralExpressionSegment
terrymanu closed issue #4781: Add start-index and stop-index assertion for LiteralExpressionSegment URL: https://github.com/apache/incubator-shardingsphere/issues/4781 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao commented on a change in pull request #4945: make key-generator as a spring bean on spring namespace.
cherrylzhao commented on a change in pull request #4945: make key-generator as
a spring bean on spring namespace.
URL:
https://github.com/apache/incubator-shardingsphere/pull/4945#discussion_r400277252
##
File path:
sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/rule/TableRule.java
##
@@ -130,7 +129,7 @@ private void addActualTable(final String datasourceName,
final String tableName)
}
private boolean containsKeyGeneratorConfiguration(final
TableRuleConfiguration tableRuleConfiguration) {
Review comment:
containsKeyGeneratorConfiguration => containsKeyGenerateAlgorithm is better
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao commented on a change in pull request #4945: make key-generator as a spring bean on spring namespace.
cherrylzhao commented on a change in pull request #4945: make key-generator as
a spring bean on spring namespace.
URL:
https://github.com/apache/incubator-shardingsphere/pull/4945#discussion_r400273976
##
File path:
sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/rule/ShardingRule.java
##
@@ -108,14 +108,14 @@ private ShardingStrategy
createDefaultShardingStrategy(final ShardingStrategyCon
return
Optional.ofNullable(shardingStrategyConfiguration).map(ShardingStrategyFactory::newInstance).orElse(new
NoneShardingStrategy());
}
-private ShardingKeyGenerator createDefaultKeyGenerator(final
KeyGeneratorConfiguration keyGeneratorConfiguration) {
-ShardingKeyGeneratorServiceLoader serviceLoader = new
ShardingKeyGeneratorServiceLoader();
+private KeyGenerateAlgorithm createDefaultKeyGenerateAlgorithm(final
KeyGeneratorConfiguration keyGeneratorConfiguration) {
+KeyGenerateAlgorithmServiceLoader serviceLoader = new
KeyGenerateAlgorithmServiceLoader();
return containsKeyGeneratorConfiguration(keyGeneratorConfiguration)
-?
serviceLoader.newService(keyGeneratorConfiguration.getType(),
keyGeneratorConfiguration.getProperties()) : serviceLoader.newService();
+? keyGeneratorConfiguration.getKeyGenerateAlgorithm() :
serviceLoader.newService();
}
private boolean containsKeyGeneratorConfiguration(final
KeyGeneratorConfiguration keyGeneratorConfiguration) {
Review comment:
containsKeyGeneratorConfiguration => containsKeyGenerateAlgorithm is better
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #5010: refactor schema metadata
coveralls commented on issue #5010: refactor schema metadata URL: https://github.com/apache/incubator-shardingsphere/pull/5010#issuecomment-606016349 ## Pull Request Test Coverage Report for [Build 10710](https://coveralls.io/builds/29710197) * **1** of **37** **(2.7%)** changed or added relevant lines in **8** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage increased (+**0.04%**) to **57.373%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/impl/MasterSlaveSchema.java](https://coveralls.io/builds/29710197/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2Fimpl%2FMasterSlaveSchema.java#L62) | 0 | 1 | 0.0% | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/impl/ShadowSchema.java](https://coveralls.io/builds/29710197/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2Fimpl%2FShadowSchema.java#L54) | 0 | 1 | 0.0% | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/impl/TransparentSchema.java](https://coveralls.io/builds/29710197/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2Fimpl%2FTransparentSchema.java#L46) | 0 | 1 | 0.0% | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/impl/EncryptSchema.java](https://coveralls.io/builds/29710197/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2Fimpl%2FEncryptSchema.java#L56) | 0 | 2 | 0.0% | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/ShardingMetaDataLoader.java](https://coveralls.io/builds/29710197/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fmetadata%2FShardingMetaDataLoader.java#L80) | 0 | 6 | 0.0% | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/LogicSchema.java](https://coveralls.io/builds/29710197/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2FLogicSchema.java#L59) | 0 | 9 | 0.0% | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/impl/ShardingSchema.java](https://coveralls.io/builds/29710197/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2Fimpl%2FShardingSchema.java#L93) | 0 | 16 | 0.0% | Totals | [](https://coveralls.io/builds/29710197) | | :-- | --: | | Change from base [Build 10705](https://coveralls.io/builds/29707536): | 0.04% | | Covered Lines: | 11738 | | Relevant Lines: | 20459 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #5009: #4978, Sharding-Proxy doesn't response for "Unsupported Command" from…
coveralls commented on issue #5009: #4978, Sharding-Proxy doesn't response for "Unsupported Command" from… URL: https://github.com/apache/incubator-shardingsphere/pull/5009#issuecomment-606000791 ## Pull Request Test Coverage Report for [Build 10709](https://coveralls.io/builds/29709521) * **0** of **10** **(0.0%)** changed or added relevant lines in **4** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage decreased (**-0.02%**) to **57.309%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/MySQLCommandExecuteEngine.java](https://coveralls.io/builds/29709521/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fmysql%2Fcommand%2FMySQLCommandExecuteEngine.java#L69) | 0 | 1 | 0.0% | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-core/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/command/CommandExecutorTask.java](https://coveralls.io/builds/29709521/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fcommand%2FCommandExecutorTask.java#L78) | 0 | 2 | 0.0% | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-postgresql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/postgresql/PostgreSQLErrPacketFactory.java](https://coveralls.io/builds/29709521/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fpostgresql%2FPostgreSQLErrPacketFactory.java#L48) | 0 | 3 | 0.0% | [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-postgresql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/postgresql/command/PostgreSQLCommandExecuteEngine.java](https://coveralls.io/builds/29709521/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fpostgresql%2Fcommand%2FPostgreSQLCommandExecuteEngine.java#L65) | 0 | 4 | 0.0% | Totals | [](https://coveralls.io/builds/29709521) | | :-- | --: | | Change from base [Build 10705](https://coveralls.io/builds/29707536): | -0.02% | | Covered Lines: | 11738 | | Relevant Lines: | 20482 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #5002: add start-index and stop-index for LiteralExpressionSegment
coveralls edited a comment on issue #5002: add start-index and stop-index for LiteralExpressionSegment URL: https://github.com/apache/incubator-shardingsphere/pull/5002#issuecomment-605884386 ## Pull Request Test Coverage Report for [Build 10708](https://coveralls.io/builds/29708813) * **0** of **0** changed or added relevant lines in **0** files are covered. * **45** unchanged lines in **5** files lost coverage. * Overall coverage increased (+**0.2%**) to **57.331%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/column/ColumnMetaDataLoader.java](https://coveralls.io/builds/29708813/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fmetadata%2Fcolumn%2FColumnMetaDataLoader.java#L95) | 2 | 85.11% | | [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/table/TableMetaData.java](https://coveralls.io/builds/29708813/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fmetadata%2Ftable%2FTableMetaData.java#L72) | 2 | 92.86% | | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/ShardingTableMetaDataDecorator.java](https://coveralls.io/builds/29708813/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fmetadata%2FShardingTableMetaDataDecorator.java#L54) | 5 | 0% | | [sharding-scaling/sharding-scaling-postgresql/src/main/java/org/apache/shardingsphere/shardingscaling/postgresql/wal/WalEventConverter.java](https://coveralls.io/builds/29708813/source?filename=sharding-scaling%2Fsharding-scaling-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fpostgresql%2Fwal%2FWalEventConverter.java#L52) | 14 | 0% | | [sharding-scaling/sharding-scaling-mysql/src/main/java/org/apache/shardingsphere/shardingscaling/mysql/MySQLBinlogReader.java](https://coveralls.io/builds/29708813/source?filename=sharding-scaling%2Fsharding-scaling-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fmysql%2FMySQLBinlogReader.java#L51) | 22 | 0% | | Totals | [](https://coveralls.io/builds/29708813) | | :-- | --: | | Change from base [Build 10702](https://coveralls.io/builds/29702082): | 0.2% | | Covered Lines: | 11738 | | Relevant Lines: | 20474 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #5007: Fixes Issue3265
coveralls commented on issue #5007: Fixes Issue3265 URL: https://github.com/apache/incubator-shardingsphere/pull/5007#issuecomment-605979700 ## Pull Request Test Coverage Report for [Build 10707](https://coveralls.io/builds/29708389) * **0** of **0** changed or added relevant lines in **0** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage remained the same at **57.331%** --- | Totals | [](https://coveralls.io/builds/29708389) | | :-- | --: | | Change from base [Build 10705](https://coveralls.io/builds/29707536): | 0.0% | | Covered Lines: | 11738 | | Relevant Lines: | 20474 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #5007: Fixes Issue3265
codecov-io commented on issue #5007: Fixes Issue3265 URL: https://github.com/apache/incubator-shardingsphere/pull/5007#issuecomment-605975180 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5007?src=pr=h1) Report > Merging [#5007](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5007?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/2048b38bc794d95f3d6f3c532381f3543cf31335=desc) will **increase** coverage by `0.12%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5007?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5007 +/- ## + Coverage 53.70% 53.82% +0.12% + Complexity 442 441 -1 Files 1143 1139 -4 Lines 2051520474 -41 Branches 3745 3741 -4 + Hits 1101711021 +4 + Misses 8797 8748 -49 - Partials701 705 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5007?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../core/metadata/ShardingTableMetaDataDecorator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5007/diff?src=pr=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9tZXRhZGF0YS9TaGFyZGluZ1RhYmxlTWV0YURhdGFEZWNvcmF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | | | [...phere/shardingscaling/mysql/MySQLBinlogReader.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5007/diff?src=pr=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZ3NjYWxpbmcvbXlzcWwvTXlTUUxCaW5sb2dSZWFkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | | | [...shardingscaling/core/metadata/MetaDataManager.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5007/diff?src=pr=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL21ldGFkYXRhL01ldGFEYXRhTWFuYWdlci5qYXZh) | `100.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | | | [...rdingscaling/postgresql/wal/WalEventConverter.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5007/diff?src=pr=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLXBvc3RncmVzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9wb3N0Z3Jlc3FsL3dhbC9XYWxFdmVudENvbnZlcnRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | | | [...ngscaling/core/metadata/column/ColumnMetaData.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5007/diff?src=pr=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL21ldGFkYXRhL2NvbHVtbi9Db2x1bW5NZXRhRGF0YS5qYXZh) | | | | | [...ing/core/metadata/column/ColumnMetaDataLoader.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5007/diff?src=pr=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL21ldGFkYXRhL2NvbHVtbi9Db2x1bW5NZXRhRGF0YUxvYWRlci5qYXZh) | | | | | [...dingscaling/core/metadata/table/TableMetaData.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5007/diff?src=pr=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL21ldGFkYXRhL3RhYmxlL1RhYmxlTWV0YURhdGEuamF2YQ==) | | | | | [...aling/core/metadata/table/TableMetaDataLoader.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5007/diff?src=pr=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL21ldGFkYXRhL3RhYmxlL1RhYmxlTWV0YURhdGFMb2FkZXIuamF2YQ==) | | | | | [...ql/parser/binder/metadata/table/TableMetaData.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5007/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWJpbmRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9iaW5kZXIvbWV0YWRhdGEvdGFibGUvVGFibGVNZXRhRGF0YS5qYXZh) | `89.28% <0.00%> (+10.71%)` | `0.00% <0.00%> (ø%)` | | |
[GitHub] [incubator-shardingsphere] coveralls commented on issue #5006: add parsing integrated test for update query sql
coveralls commented on issue #5006: add parsing integrated test for update query sql URL: https://github.com/apache/incubator-shardingsphere/pull/5006#issuecomment-605969796 ## Pull Request Test Coverage Report for [Build 10706](https://coveralls.io/builds/29707936) * **0** of **0** changed or added relevant lines in **0** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage remained the same at **57.331%** --- | Totals | [](https://coveralls.io/builds/29707936) | | :-- | --: | | Change from base [Build 10705](https://coveralls.io/builds/29707536): | 0.0% | | Covered Lines: | 11738 | | Relevant Lines: | 20474 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking opened a new pull request #5010: refactor schema metadata
kimmking opened a new pull request #5010: refactor schema metadata URL: https://github.com/apache/incubator-shardingsphere/pull/5010 Changes proposed in this pull request: - extract physical metadata field in proxy for 5 sub class - decouple physical metadata metadata This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 opened a new pull request #5009: #4978, Sharding-Proxy doesn't response for "Unsupported Command" from…
tuohai666 opened a new pull request #5009: #4978, Sharding-Proxy doesn't response for "Unsupported Command" from… URL: https://github.com/apache/incubator-shardingsphere/pull/5009 … PSQL cli Fixes #4978. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] zjcnb commented on a change in pull request #5002: add start-index and stop-index for LiteralExpressionSegment
zjcnb commented on a change in pull request #5002: add start-index and stop-index for LiteralExpressionSegment URL: https://github.com/apache/incubator-shardingsphere/pull/5002#discussion_r400132215 ## File path: shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/resources/sql/dml/delete.xml ## @@ -6,7 +6,7 @@ ~ The ASF licenses this file to You under the Apache License, Version 2.0 ~ (the "License"); you may not use this file except in compliance with ~ the License. You may obtain a copy of the License at - ~ + ~delete_with_alias Review comment: ok, i fixed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking opened a new issue #5008: Refactor LogicSchema in proxy #MetaDataCenter-phase-1
kimmking opened a new issue #5008: Refactor LogicSchema in proxy #MetaDataCenter-phase-1 URL: https://github.com/apache/incubator-shardingsphere/issues/5008 According to https://github.com/apache/incubator-shardingsphere/issues/4896, we will refactor LogicSchema and 5 sub class to uniform all metadata loading: - [] extract physical metadata field for 5 sub class - [] decouple physical metadata metadata - [] process logic tables for ShardingSchema - [] decouple refreshTableMetaData and ShardingMetaDataLoader - [] decouple jdbc-core and ShardingMetaDataLoader This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] menghaoranss opened a new pull request #5007: Fixes Issue3265
menghaoranss opened a new pull request #5007: Fixes Issue3265 URL: https://github.com/apache/incubator-shardingsphere/pull/5007 Fixes #3265. Changes proposed in this pull request: - support edit config and registry center This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #5003: 杭州海康威视数字技术股份有限公司+https://www.hikvision.com
terrymanu closed issue #5003: 杭州海康威视数字技术股份有限公司+https://www.hikvision.com URL: https://github.com/apache/incubator-shardingsphere/issues/5003 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] strongduanmu opened a new pull request #5006: add parsing integrated test for update query sql
strongduanmu opened a new pull request #5006: add parsing integrated test for update query sql URL: https://github.com/apache/incubator-shardingsphere/pull/5006 Fixes #4995 . Changes proposed in this pull request: - Add parsing integrated test for update query SQL This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #5004: 杭州萤石软件有限公司+https://www.ys7.com/
terrymanu closed issue #5004: 杭州萤石软件有限公司+https://www.ys7.com/ URL: https://github.com/apache/incubator-shardingsphere/issues/5004 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #5002: add start-index and stop-index for LiteralExpressionSegment
terrymanu commented on a change in pull request #5002: add start-index and stop-index for LiteralExpressionSegment URL: https://github.com/apache/incubator-shardingsphere/pull/5002#discussion_r400102559 ## File path: shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/resources/sql/dml/delete.xml ## @@ -6,7 +6,7 @@ ~ The ASF licenses this file to You under the Apache License, Version 2.0 ~ (the "License"); you may not use this file except in compliance with ~ the License. You may obtain a copy of the License at - ~ + ~delete_with_alias Review comment: Please do not change copyright This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #4866: Replace metaData part in sharding-scaling with metaData in sql-parse
terrymanu closed issue #4866: Replace metaData part in sharding-scaling with metaData in sql-parse URL: https://github.com/apache/incubator-shardingsphere/issues/4866 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #5005: Replace TableMetaData in sharding-scaling-module
terrymanu merged pull request #5005: Replace TableMetaData in sharding-scaling-module URL: https://github.com/apache/incubator-shardingsphere/pull/5005 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #5005: Replace TableMetaData in sharding-scaling-module
coveralls commented on issue #5005: Replace TableMetaData in sharding-scaling-module URL: https://github.com/apache/incubator-shardingsphere/pull/5005#issuecomment-605919696 ## Pull Request Test Coverage Report for [Build 10704](https://coveralls.io/builds/29705476) * **25** of **33** **(75.76%)** changed or added relevant lines in **9** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage increased (+**0.2%**) to **57.331%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [encrypt-core/encrypt-core-common/src/main/java/org/apache/shardingsphere/encrypt/metadata/EncryptColumnMetaData.java](https://coveralls.io/builds/29705476/source?filename=encrypt-core%2Fencrypt-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Fmetadata%2FEncryptColumnMetaData.java#L41) | 0 | 1 | 0.0% | [encrypt-core/encrypt-core-common/src/main/java/org/apache/shardingsphere/encrypt/metadata/EncryptTableMetaDataDecorator.java](https://coveralls.io/builds/29705476/source?filename=encrypt-core%2Fencrypt-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Fmetadata%2FEncryptTableMetaDataDecorator.java#L57) | 0 | 1 | 0.0% | [sharding-scaling/sharding-scaling-postgresql/src/main/java/org/apache/shardingsphere/shardingscaling/postgresql/wal/WalEventConverter.java](https://coveralls.io/builds/29705476/source?filename=sharding-scaling%2Fsharding-scaling-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fpostgresql%2Fwal%2FWalEventConverter.java#L127) | 0 | 1 | 0.0% | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/ShardingTableMetaDataDecorator.java](https://coveralls.io/builds/29705476/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fmetadata%2FShardingTableMetaDataDecorator.java#L53) | 0 | 2 | 0.0% | [sharding-scaling/sharding-scaling-mysql/src/main/java/org/apache/shardingsphere/shardingscaling/mysql/MySQLBinlogReader.java](https://coveralls.io/builds/29705476/source?filename=sharding-scaling%2Fsharding-scaling-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fmysql%2FMySQLBinlogReader.java#L117) | 0 | 3 | 0.0% | Totals | [](https://coveralls.io/builds/29705476) | | :-- | --: | | Change from base [Build 10702](https://coveralls.io/builds/29702082): | 0.2% | | Covered Lines: | 11738 | | Relevant Lines: | 20474 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #5005: Replace TableMetaData in sharding-scaling-module
codecov-io commented on issue #5005: Replace TableMetaData in sharding-scaling-module URL: https://github.com/apache/incubator-shardingsphere/pull/5005#issuecomment-605917214 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5005?src=pr=h1) Report > Merging [#5005](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5005?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/8887a699636309994883a676e8c912dd8728a17d=desc) will **increase** coverage by `0.05%`. > The diff coverage is `75.75%`. [](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5005?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5005 +/- ## + Coverage 53.77% 53.82% +0.05% + Complexity 442 441 -1 Files 1143 1139 -4 Lines 2048820474 -14 Branches 3749 3741 -8 + Hits 1101711021 +4 + Misses 8770 8748 -22 - Partials701 705 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5005?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...sphere/encrypt/metadata/EncryptColumnMetaData.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5005/diff?src=pr=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvbWV0YWRhdGEvRW5jcnlwdENvbHVtbk1ldGFEYXRhLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ncrypt/metadata/EncryptTableMetaDataDecorator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5005/diff?src=pr=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvbWV0YWRhdGEvRW5jcnlwdFRhYmxlTWV0YURhdGFEZWNvcmF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [.../core/metadata/ShardingTableMetaDataDecorator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5005/diff?src=pr=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9tZXRhZGF0YS9TaGFyZGluZ1RhYmxlTWV0YURhdGFEZWNvcmF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...re/execute/executor/reader/AbstractJDBCReader.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5005/diff?src=pr=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL2V4ZWN1dGUvZXhlY3V0b3IvcmVhZGVyL0Fic3RyYWN0SkRCQ1JlYWRlci5qYXZh) | `83.33% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...phere/shardingscaling/mysql/MySQLBinlogReader.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5005/diff?src=pr=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZ3NjYWxpbmcvbXlzcWwvTXlTUUxCaW5sb2dSZWFkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...rdingscaling/postgresql/wal/WalEventConverter.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5005/diff?src=pr=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLXBvc3RncmVzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9wb3N0Z3Jlc3FsL3dhbC9XYWxFdmVudENvbnZlcnRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...shardingscaling/core/metadata/MetaDataManager.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5005/diff?src=pr=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL21ldGFkYXRhL01ldGFEYXRhTWFuYWdlci5qYXZh) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ore/synctask/history/HistoryDataSyncTaskGroup.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5005/diff?src=pr=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL3N5bmN0YXNrL2hpc3RvcnkvSGlzdG9yeURhdGFTeW5jVGFza0dyb3VwLmphdmE=) | `76.69% <100.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...r/binder/metadata/column/ColumnMetaDataLoader.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5005/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWJpbmRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9iaW5kZXIvbWV0YWRhdGEvY29sdW1uL0NvbHVtbk1ldGFEYXRhTG9hZGVyLmphdmE=) | `68.08% <100.00%> (+68.08%)` |
[GitHub] [incubator-shardingsphere] yu199195 commented on issue #5003: 杭州海康威视数字技术股份有限公司+https://www.hikvision.com
yu199195 commented on issue #5003: 杭州海康威视数字技术股份有限公司+https://www.hikvision.com URL: https://github.com/apache/incubator-shardingsphere/issues/5003#issuecomment-605914531 @dwyane3011 Hi,,Pease register here : https://github.com/apache/incubator-shardingsphere/issues/234 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] yu199195 edited a comment on issue #5003: 杭州海康威视数字技术股份有限公司+https://www.hikvision.com
yu199195 edited a comment on issue #5003: 杭州海康威视数字技术股份有限公司+https://www.hikvision.com URL: https://github.com/apache/incubator-shardingsphere/issues/5003#issuecomment-605914531 @dwyane3011 Hi,Pease register here : https://github.com/apache/incubator-shardingsphere/issues/234 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] yu199195 commented on issue #5004: 杭州萤石软件有限公司+https://www.ys7.com/
yu199195 commented on issue #5004: 杭州萤石软件有限公司+https://www.ys7.com/ URL: https://github.com/apache/incubator-shardingsphere/issues/5004#issuecomment-605914336 @dwyane3011 hi,Please register here : https://github.com/apache/incubator-shardingsphere/issues/234 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion opened a new pull request #5005: Replace TableMetaData in sharding-scaling-module
KomachiSion opened a new pull request #5005: Replace TableMetaData in sharding-scaling-module URL: https://github.com/apache/incubator-shardingsphere/pull/5005 Fixes #4866 . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #5002: add start-index and stop-index for LiteralExpressionSegment
coveralls commented on issue #5002: add start-index and stop-index for LiteralExpressionSegment URL: https://github.com/apache/incubator-shardingsphere/pull/5002#issuecomment-605884386 ## Pull Request Test Coverage Report for [Build 10703](https://coveralls.io/builds/29703753) * **0** of **0** changed or added relevant lines in **0** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage remained the same at **57.178%** --- | Totals | [](https://coveralls.io/builds/29703753) | | :-- | --: | | Change from base [Build 10702](https://coveralls.io/builds/29702082): | 0.0% | | Covered Lines: | 11730 | | Relevant Lines: | 20515 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] dwyane3011 opened a new issue #5004: 杭州萤石软件有限公司+https://www.ys7.com/
dwyane3011 opened a new issue #5004: 杭州萤石软件有限公司+https://www.ys7.com/ URL: https://github.com/apache/incubator-shardingsphere/issues/5004 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] dwyane3011 opened a new issue #5003: 杭州海康威视数字技术股份有限公司+https://www.hikvision.com
dwyane3011 opened a new issue #5003: 杭州海康威视数字技术股份有限公司+https://www.hikvision.com URL: https://github.com/apache/incubator-shardingsphere/issues/5003 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao commented on a change in pull request #4996: add sharding.transaction.seata.at.enable config to compatible with se…
cherrylzhao commented on a change in pull request #4996: add
sharding.transaction.seata.at.enable config to compatible with se…
URL:
https://github.com/apache/incubator-shardingsphere/pull/4996#discussion_r37169
##
File path:
sharding-transaction/sharding-transaction-base/sharding-transaction-base-seata-at/src/main/java/org/apache/shardingsphere/transaction/base/seata/at/SeataATShardingTransactionManager.java
##
@@ -47,34 +47,56 @@
private final Map dataSourceMap = new HashMap<>();
-private final FileConfiguration configuration = new
FileConfiguration("seata.conf");
+private final String applicationId;
+
+private final String transactionServiceGroup;
+
+private final boolean enableSeataAT;
+
+public SeataATShardingTransactionManager() {
+FileConfiguration configuration = new FileConfiguration("seata.conf");
+enableSeataAT =
configuration.getBoolean("sharding.transaction.seata.at.enable", true);
Review comment:
I'll fix it in next PR
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere-doc] tuohai666 opened a new pull request #467: update website
tuohai666 opened a new pull request #467: update website URL: https://github.com/apache/incubator-shardingsphere-doc/pull/467 Create from jenkins This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] tuohai666 opened a new pull request #466: update website
tuohai666 opened a new pull request #466: update website URL: https://github.com/apache/incubator-shardingsphere-doc/pull/466 Create from jenkins This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] tuohai666 closed pull request #465: update website
tuohai666 closed pull request #465: update website URL: https://github.com/apache/incubator-shardingsphere-doc/pull/465 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] tuohai666 opened a new pull request #465: update website
tuohai666 opened a new pull request #465: update website URL: https://github.com/apache/incubator-shardingsphere-doc/pull/465 Create from jenkins This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue #4961: fix selectStatement contained tableReferences for other db
tristaZero edited a comment on issue #4961: fix selectStatement contained tableReferences for other db URL: https://github.com/apache/incubator-shardingsphere/pull/4961#issuecomment-605826691 Good job, and it is time to review the SQL cases below whether it could cover all the databases except for `MySQL`(They are updated in your last PR). > 1. select_inner_join_related_with_name 2. select_sharding_route_with_broadcast_table This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4961: fix selectStatement contained tableReferences for other db
tristaZero merged pull request #4961: fix selectStatement contained tableReferences for other db URL: https://github.com/apache/incubator-shardingsphere/pull/4961 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4961: fix selectStatement contained tableReferences for other db
tristaZero commented on issue #4961: fix selectStatement contained tableReferences for other db URL: https://github.com/apache/incubator-shardingsphere/pull/4961#issuecomment-605826691 Good job, and it is time to review the SQL cases below whether it could cover all the databases except for `MySQL`(They are updated in your last PR). > 1. select_inner_join_related_with_name 2. select_sharding_route_with_broadcast_table This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #4546: SQLParseEngine can not get columns when sql columns has 'source' name key
terrymanu closed issue #4546: SQLParseEngine can not get columns when sql columns has 'source' name key URL: https://github.com/apache/incubator-shardingsphere/issues/4546 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4832: insert...ON DUPLICATE KEY UPDATE error
terrymanu commented on issue #4832: insert...ON DUPLICATE KEY UPDATE error URL: https://github.com/apache/incubator-shardingsphere/issues/4832#issuecomment-605825176 Will close soon if no update anymore This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu closed issue #4861: two tables left join with different routing rules are not supported
terrymanu closed issue #4861: two tables left join with different routing rules are not supported URL: https://github.com/apache/incubator-shardingsphere/issues/4861 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4862: using "" will route to all datanode
terrymanu commented on issue #4862: using "" will route to all datanode URL: https://github.com/apache/incubator-shardingsphere/issues/4862#issuecomment-605824759 Will close soon if no update anymore This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] wujiangyong commented on issue #3681: tomcat start slowly with default datasource setting
wujiangyong commented on issue #3681: tomcat start slowly with default datasource setting URL: https://github.com/apache/incubator-shardingsphere/issues/3681#issuecomment-605823201 I've been using `4.0.1` and I have the same problem, it took me 5-7 minutes to start up the app. Then I google it, one way is to skip the method, which I haven't adopted. Copy the class `TableMetaDataInitializer` into your project, and remove `loadDefaultTables` method. Then I looked into the code, I found when `findActualDefaultDataSourceName` returns `Optional.absent()`, it will not run into the actual loading. So I assume in some cases, `loadDefaultTables()` is not required, and I'v only used table sharding with sharding-jdbc, so there comes the second solution, I configured two `` in ``, and actually the second one is a placeholder which I never used, and everything works fine for me, so far so good. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #5001: The task summary of SQL parse module
tristaZero commented on issue #5001: The task summary of SQL parse module URL: https://github.com/apache/incubator-shardingsphere/issues/5001#issuecomment-605815781 @jingshanglu Hi This issue is a summary of the remaining tasks for sharding parser, which needs your hand, our veteran. :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero opened a new issue #5001: The task summary of SQL parse module
tristaZero opened a new issue #5001: The task summary of SQL parse module URL: https://github.com/apache/incubator-shardingsphere/issues/5001 Remaining todo list for SQL parse module - [ ] Parse `joinTable` Query SQL(#4885) - [ ] Support `TOP()` (#4867) - [ ] Support pagination (#4887) - [ ] Make subquery parsing test work well (#4696) - [ ] Move predicateBuilder from `Parser module` to `Bind module` - [ ] Check test coverage of Sharding Parse and analysis SQL cases to improve this coverage - [ ] Collate SQL grammar definitions (#4683) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere-doc] tuohai666 closed pull request #464: update website
tuohai666 closed pull request #464: update website URL: https://github.com/apache/incubator-shardingsphere-doc/pull/464 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
