[GitHub] [incubator-shardingsphere] tristaZero commented on issue #3276: Add table owner for logic encrypt column
tristaZero commented on issue #3276: Add table owner for logic encrypt column URL: https://github.com/apache/incubator-shardingsphere/pull/3276#issuecomment-542967941 @gufengwyx8 Hi, good job. :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #3276: Add table owner for logic encrypt column
tristaZero commented on issue #3276: Add table owner for logic encrypt column URL: https://github.com/apache/incubator-shardingsphere/pull/3276#issuecomment-542505110 Thanks for your reply, there are tableName and alias in TableSegment, when getTableName(), it should not return alias actually. But you are right, getTableName() return alias in EncryptSQLRewriteEngineParameterizedTest , which is an another issue. @gufengwyx8 I approve of your pr, and here are just two items we can consider, 1. Rename `tableOwner` to `columnOwner`, which means the owner of colum. 2. Instead of adding a new function `getOwnerName()`, can we reuse `getOwner()` ? That' all, waiting for your suggetions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #3276: Add table owner for logic encrypt column
tristaZero commented on issue #3276: Add table owner for logic encrypt column URL: https://github.com/apache/incubator-shardingsphere/pull/3276#issuecomment-542069705 @gufengwyx8 Hi, So great and so fast! The solution in your PR is correct, but to make the members of `EncryptCondition` and `EncryptPredicateToken` less, can you keep `ColumnSegment` in `EncryptPredicateToken` and delete `columnName`? Through that, we can get `columnName` and `its owner` from `ColumnSegment` in `ColumnSegment`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
