[GitHub] [incubator-shardingsphere] wqzwh commented on a change in pull request #3039: sharding-ui-frontend add unit test

2019-09-17 Thread GitBox 
wqzwh commented on a change in pull request #3039: sharding-ui-frontend add 
unit test
URL: 
https://github.com/apache/incubator-shardingsphere/pull/3039#discussion_r325131254
 
 

 ##
 File path: sharding-ui/sharding-ui-frontend/package.json
 ##
 @@ -9,7 +9,8 @@
 "start": "npm run dev",
 "lint": "eslint --ext .js,.vue src",
 "test": "cross-env NODE_ENV=mock  webpack-dev-server --inline --progress 
--config build/webpack.dev.conf.js",
-"build": "node build/build.js"
+"build": "node build/build.js",
+"unit": "cross-env BABEL_ENV=test karma start --single-run"
 
 Review comment:
   Es-mock is suitable for use in the early stages of development, but can not 
be used for the time being, so this iteration has been deleted.
   
   Karma does unit testing for components and pages


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] wqzwh commented on a change in pull request #3039: sharding-ui-frontend add unit test

2019-09-17 Thread GitBox 
wqzwh commented on a change in pull request #3039: sharding-ui-frontend add 
unit test
URL: 
https://github.com/apache/incubator-shardingsphere/pull/3039#discussion_r325130222
 
 

 ##
 File path: sharding-ui/sharding-ui-frontend/src/components/Logo/index.vue
 ##
 @@ -18,8 +18,8 @@
 
   
 
-  
-  
+  
 
 Review comment:
   add eslint rules，solve the problem of adding self-closing tags，the snippet 
code is as follows:
   
   ```
   "vue/html-self-closing": ["error", {
 "html": {
   "void": "any",
   "normal": "any",
   "component": "any"
 },
 "svg": "any",
 "math": "any"
   }]
   
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] wqzwh commented on a change in pull request #3039: sharding-ui-frontend add unit test

2019-09-17 Thread GitBox 
wqzwh commented on a change in pull request #3039: sharding-ui-frontend add 
unit test
URL: 
https://github.com/apache/incubator-shardingsphere/pull/3039#discussion_r325130159
 
 

 ##
 File path: sharding-ui/sharding-ui-frontend/src/components/Container/index.vue
 ##
 @@ -18,17 +18,17 @@
 
   
 
-  
+  
 
 
   
-
+
 
 Review comment:
   add eslint rules，solve the problem of adding self-closing tags，the snippet 
code is as follows:
   
   ```
   "vue/html-self-closing": ["error", {
 "html": {
   "void": "any",
   "normal": "any",
   "component": "any"
 },
 "svg": "any",
 "math": "any"
   }]
   
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services