[GitHub] [shardingsphere] ThanoshanMV edited a comment on pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE

2021-01-21 Thread GitBox


ThanoshanMV edited a comment on pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#issuecomment-764325579







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] ThanoshanMV edited a comment on pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE

2021-01-21 Thread GitBox


ThanoshanMV edited a comment on pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#issuecomment-764325579


   Hi @tristaZero, I've searched through the documents and I haven't found 
anything about pre-PRs. 
   
   For the preparation work, I'll try to find out basic vague SQL grammar 
definitions and correct them referring to Oracle documentation in the [target 
directory](https://github.com/apache/shardingsphere/tree/master/shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/antlr4/imports/oracle)
 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] ThanoshanMV edited a comment on pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE

2021-01-21 Thread GitBox


ThanoshanMV edited a comment on pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#issuecomment-764325579


   Hi @tristaZero, I've searched through the documents and I haven't found 
anything about pre-PRs. 
   
   For the preparation work, I would like to do more tasks related to our 
COMDEV-385. I think this will allow me to explore more into the project and 
have a better understanding. 
   
   I'm okay with any of your tasks and suggestions. 
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] ThanoshanMV edited a comment on pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE

2021-01-20 Thread GitBox


ThanoshanMV edited a comment on pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#issuecomment-764325579


   Hi @tristaZero, I've searched through the documents and I haven't found 
anything about pre-PRs. Seems like we can not pre-PR. I'm also not sure about 
this. 
   
   For the preparation work, I would like to do more tasks related to our 
COMDEV-385. I think this will allow me to explore more into the project and 
have a better understanding. 
   
   I'm okay with any of your tasks and suggestions. 
   
   I'll comment in the COMDEV-385.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [shardingsphere] ThanoshanMV edited a comment on pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE

2021-01-20 Thread GitBox


ThanoshanMV edited a comment on pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#issuecomment-764325579


   Hi @tristaZero, I've searched through the documents and I haven't found 
anything about pre-PRs. Seems like we can not pre-PR. I'm also not sure about 
this. 
   
   For the preparation work, I would like to do more tasks related to our 
COMDEV-385. I think this will allow me to explore more into the project and 
have a better understanding. 
   
   I'm okay with any of your tasks and suggestions. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org