[GitHub] [shardingsphere] codecov-io commented on pull request #9112: add support alter sharding rule

2021-01-21 Thread GitBox 


codecov-io commented on pull request #9112:
URL: https://github.com/apache/shardingsphere/pull/9112#issuecomment-764222356


   # 
[Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9112?src=pr=h1) 
Report
   > Merging 
[#9112](https://codecov.io/gh/apache/shardingsphere/pull/9112?src=pr=desc) 
(c79af69) into 
[master](https://codecov.io/gh/apache/shardingsphere/commit/2523fa0680d6324da7921241b614d52c3a9ca25b?el=desc)
 (2523fa0) will **decrease** coverage by `0.41%`.
   > The diff coverage is `7.78%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/shardingsphere/pull/9112/graphs/tree.svg?width=650=150=pr=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/9112?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#9112  +/-   ##
   
   - Coverage 69.80%   69.39%   -0.42% 
   + Complexity  660  657   -3 
   
 Files  1643 1649   +6 
 Lines 2660026786 +186 
 Branches   4630 4670  +40 
   
   + Hits  1856918588  +19 
   - Misses 6745 6908 +163 
   - Partials   1286 1290   +4 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/shardingsphere/pull/9112?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...dingsphere/distsql/parser/core/DistSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXIvc2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXItZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL3BhcnNlci9jb3JlL0Rpc3RTUUxWaXNpdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...stsql/rdl/AlterReplicaQueryRuleBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL0FsdGVyUmVwbGljYVF1ZXJ5UnVsZUJhY2tlbmRIYW5kbGVyLmphdmE=)
 | `10.00% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...t/distsql/rdl/AlterShardingRuleBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL0FsdGVyU2hhcmRpbmdSdWxlQmFja2VuZEhhbmRsZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...end/text/distsql/rdl/RDLBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL1JETEJhY2tlbmRIYW5kbGVyRmFjdG9yeS5qYXZh)
 | `85.71% <0.00%> (-6.60%)` | `0.00 <0.00> (ø)` | |
   | 
[...re/proxy/frontend/mysql/MySQLErrPacketFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL215c3FsL015U1FMRXJyUGFja2V0RmFjdG9yeS5qYXZh)
 | `62.96% <0.00%> (-5.04%)` | `0.00 <0.00> (ø)` | |
   | 
[...ding/converter/ShardingRuleStatementConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9jb252ZXJ0ZXIvU2hhcmRpbmdSdWxlU3RhdGVtZW50Q29udmVydGVyLmphdmE=)
 | `66.66% <58.82%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...rdingsphere/db/protocol/error/CommonErrorCode.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvZXJyb3IvQ29tbW9uRXJyb3JDb2RlLmphdmE=)
 | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...sql/rdl/impl/CreateShardingRuleBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL2ltcGwvQ3JlYXRlU2hhcmRpbmdSdWxlQmFja2VuZEhhbmRsZXIuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
   |

[GitHub] [shardingsphere] codecov-io commented on pull request #9112: add support alter sharding rule

2021-01-20 Thread GitBox 


codecov-io commented on pull request #9112:
URL: https://github.com/apache/shardingsphere/pull/9112#issuecomment-764222356


   # 
[Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9112?src=pr=h1) 
Report
   > Merging 
[#9112](https://codecov.io/gh/apache/shardingsphere/pull/9112?src=pr=desc) 
(c79af69) into 
[master](https://codecov.io/gh/apache/shardingsphere/commit/2523fa0680d6324da7921241b614d52c3a9ca25b?el=desc)
 (2523fa0) will **decrease** coverage by `0.41%`.
   > The diff coverage is `7.78%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/shardingsphere/pull/9112/graphs/tree.svg?width=650=150=pr=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/9112?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#9112  +/-   ##
   
   - Coverage 69.80%   69.39%   -0.42% 
   + Complexity  660  657   -3 
   
 Files  1643 1649   +6 
 Lines 2660026786 +186 
 Branches   4630 4670  +40 
   
   + Hits  1856918588  +19 
   - Misses 6745 6908 +163 
   - Partials   1286 1290   +4 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/shardingsphere/pull/9112?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...dingsphere/distsql/parser/core/DistSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXIvc2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXItZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL3BhcnNlci9jb3JlL0Rpc3RTUUxWaXNpdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...stsql/rdl/AlterReplicaQueryRuleBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL0FsdGVyUmVwbGljYVF1ZXJ5UnVsZUJhY2tlbmRIYW5kbGVyLmphdmE=)
 | `10.00% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...t/distsql/rdl/AlterShardingRuleBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL0FsdGVyU2hhcmRpbmdSdWxlQmFja2VuZEhhbmRsZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...end/text/distsql/rdl/RDLBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL1JETEJhY2tlbmRIYW5kbGVyRmFjdG9yeS5qYXZh)
 | `85.71% <0.00%> (-6.60%)` | `0.00 <0.00> (ø)` | |
   | 
[...re/proxy/frontend/mysql/MySQLErrPacketFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL215c3FsL015U1FMRXJyUGFja2V0RmFjdG9yeS5qYXZh)
 | `62.96% <0.00%> (-5.04%)` | `0.00 <0.00> (ø)` | |
   | 
[...ding/converter/ShardingRuleStatementConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9jb252ZXJ0ZXIvU2hhcmRpbmdSdWxlU3RhdGVtZW50Q29udmVydGVyLmphdmE=)
 | `66.66% <58.82%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...rdingsphere/db/protocol/error/CommonErrorCode.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvZXJyb3IvQ29tbW9uRXJyb3JDb2RlLmphdmE=)
 | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...sql/rdl/impl/CreateShardingRuleBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/9112/diff?src=pr=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL2ltcGwvQ3JlYXRlU2hhcmRpbmdSdWxlQmFja2VuZEhhbmRsZXIuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
   |