[GitHub] wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)
wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-389747821 > It's hard to transfer the only one, because of the Spring AntPathMatcher import some util class, the other util class also import others, but they all belong to a same package, can I transfer the whole package org.springframework.util? exclude child package of course @SevenPointOld You can do a full package transfer, or rewrite the match logic. That is your decision. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)
wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-389747694 > @SevenPointOld 您的 classpath 里并没有 skywalking-plugin.def,请问 TraceIgnoreExtendService 是如何被 SkyWalking 加载的呢? @brucewu-fly plugin.def is for plugin definition, such as: dubbo, sofa plugin. Service initialization is based on other mechanism. See `org.apache.skywalking.apm.agent.core.boot.BootService` file. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed issue #1234: 请问有告警相关的文档吗?
wu-sheng closed issue #1234: 请问有告警相关的文档吗? URL: https://github.com/apache/incubator-skywalking/issues/1234 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1234: 请问有告警相关的文档吗?
wu-sheng commented on issue #1234: 请问有告警相关的文档吗? URL: https://github.com/apache/incubator-skywalking/issues/1234#issuecomment-389725160 Issue must be in English. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SevenPointOld commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)
SevenPointOld commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-389725100 > Please notice, only transfer the only one you need It's hard to transfer the only one, because of the Spring `AntPathMatcher` import some util class, the other util class also import others, but they all belong to a same package, can I transfer the whole package `org.springframework.util`? exclude child package of course This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tangmingming opened a new issue #1234: 请问有告警相关的文档吗?
tangmingming opened a new issue #1234: 请问有告警相关的文档吗? URL: https://github.com/apache/incubator-skywalking/issues/1234 Please answer these questions before submitting your issue. - Why do you submit this issue? - [1] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature or performance improvement ___ ### Question 看到有告警相关的功能,却不知道如何配置 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)
wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-389537884 Master codes version updated. Please follow. And resolve the License issue ASAP. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed pull request #1233: Update version to beta2 for next iteration.
wu-sheng closed pull request #1233: Update version to beta2 for next iteration. URL: https://github.com/apache/incubator-skywalking/pull/1233 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #1233: Update version to beta2 for next iteration.
coveralls commented on issue #1233: Update version to beta2 for next iteration. URL: https://github.com/apache/incubator-skywalking/pull/1233#issuecomment-389508572 [![Coverage Status](https://coveralls.io/builds/17011078/badge)](https://coveralls.io/builds/17011078) Coverage remained the same at 23.511% when pulling **5b87732a55d8669797ebe0118f78c26ebdd397fe on version-beta2** into **08d9324391900326f850fd0a9191be6d83b45ef3 on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng opened a new pull request #1233: Update version to beta2 for next iteration.
wu-sheng opened a new pull request #1233: Update version to beta2 for next iteration. URL: https://github.com/apache/incubator-skywalking/pull/1233 New version number only This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SevenPointOld commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)
SevenPointOld commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-389464675 > I think should add in this plugin module. What about the distribution look like this? ![image](https://user-images.githubusercontent.com/12181207/40110582-eb90004a-5932-11e8-8eae-55525143bec8.png) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)
wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-389450553 @SevenPointOld I think should add in this plugin module. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SevenPointOld commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)
SevenPointOld commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-389447570 @wu-sheng Should I create a new module as a dependent transformation? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)
wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-389426446 @SevenPointOld please use shade plugin to transfer this class from spring denpendency, rather then use code copy. like this https://maven.apache.org/plugins/maven-shade-plugin/examples/class-relocation.html Please notice, only transfer the only one you need. Based on this, I can trust on License. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services