[GitHub] peng-yongsheng commented on issue #1258: Segment buffer pre read failure
peng-yongsheng commented on issue #1258: Segment buffer pre read failure URL: https://github.com/apache/incubator-skywalking/issues/1258#issuecomment-391216708 Single segment contains multiple entry span planning support in 5.0.0-beta2 version. So ignore this exception. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #1255: Fixing #1231. Adding order and status to trace query.
coveralls commented on issue #1255: Fixing #1231. Adding order and status to trace query. URL: https://github.com/apache/incubator-skywalking/pull/1255#issuecomment-391136082 [](https://coveralls.io/builds/17118537) Coverage increased (+0.002%) to 23.498% when pulling **48b4bd146579f66c0856c54e2b17ab86587041b3 on ajanthan:master** into **9c4b95ab9f6ae3e49ad485aa63df392bb79d4dfc on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] candyleer commented on issue #1256: Fix occure the NPE when SpringMVC and hystrix work together
candyleer commented on issue #1256: Fix occure the NPE when SpringMVC and hystrix work together URL: https://github.com/apache/incubator-skywalking/pull/1256#issuecomment-391214448 ok,I will test in last case This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1258: Segment buffer pre read failure
wu-sheng commented on issue #1258: Segment buffer pre read failure URL: https://github.com/apache/incubator-skywalking/issues/1258#issuecomment-391212292 @peng-yongsheng could you consider to ignore and abandon traces can't be analysis? And just log it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng closed pull request #1252: Update release doc and related script
peng-yongsheng closed pull request #1252: Update release doc and related script URL: https://github.com/apache/incubator-skywalking/pull/1252 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)
coveralls commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-388714290 [](https://coveralls.io/builds/17118285) Coverage increased (+0.4%) to 23.874% when pulling **973c02bc8e26a1f9f5bad52074a8641c976de911 on SevenPointOld:master** into **d55640454ee63b151272f043697f8779bb6cdd50 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #1256: Fix occure the NPE when SpringMVC and hystrix work together
coveralls commented on issue #1256: Fix occure the NPE when SpringMVC and hystrix work together URL: https://github.com/apache/incubator-skywalking/pull/1256#issuecomment-391208952 [](https://coveralls.io/builds/17118181) Coverage remained the same at 23.499% when pulling **4a1846d98fb77e93a1b51bc7757e425d5fba4c5f on ascrutae:fix/hystrix-springmvc** into **d55640454ee63b151272f043697f8779bb6cdd50 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ascrutae commented on issue #1258: Segment buffer pre read failure
ascrutae commented on issue #1258: Segment buffer pre read failure URL: https://github.com/apache/incubator-skywalking/issues/1258#issuecomment-391208222 Cloud you describe you demo more detail? It is important to help us to locate this issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dinggel opened a new issue #1258: Segment buffer pre read failure
dinggel opened a new issue #1258: Segment buffer pre read failure URL: https://github.com/apache/incubator-skywalking/issues/1258 __ ### Question - What do you want to know? Make a mistake every three seconds： 2018-05-23 10:44:37,174 - org.apache.skywalking.apm.collector.analysis.segment.parser.provider.buffer.SegmentBufferReader -60152610 [pool-4-thr ead-1] ERROR [] - Segment buffer pre read failure. org.apache.skywalking.apm.collector.core.UnexpectedException: This segment contains multiple entry span. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xjr100419 opened a new issue #1257: TraceContext.traceId() [Ignored Trace]
xjr100419 opened a new issue #1257: TraceContext.traceId() [Ignored Trace] URL: https://github.com/apache/incubator-skywalking/issues/1257 __ ### Question TraceContext.traceId() return [Ignored Trace] SkyWalking3.2.6 window centos7 jkd8 in spring cloud .I have many service runing . some TraceContext.traceId() return the right TraceId. but in some services TraceContext.traceId() return [Ignored Trace] under is my agent logfile [skywalking-api.log](https://github.com/apache/incubator-skywalking/files/2029295/skywalking-api.log) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #172: Fixing Issue 1231[https://github.com/apache/incubator-skywalking/issu…
wu-sheng commented on issue #172: Fixing Issue 1231[https://github.com/apache/incubator-skywalking/issu… URL: https://github.com/apache/incubator-skywalking-ui/pull/172#issuecomment-391181889 @ajanthan Look like your CI fails. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ascrutae opened a new pull request #1256: Fix occure the NPE when SpringMVC and hystrix work together
ascrutae opened a new pull request #1256: Fix occure the NPE when SpringMVC and hystrix work together URL: https://github.com/apache/incubator-skywalking/pull/1256 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ] Improve performance - Related issues #1238 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1255: Fixing #1231. Adding order and status to trace query.
wu-sheng commented on issue #1255: Fixing #1231. Adding order and status to trace query. URL: https://github.com/apache/incubator-skywalking/pull/1255#issuecomment-391163251 Thanks and look forward to have this soon. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ajanthan commented on issue #1255: Fixing #1231. Adding order and status to trace query.
ajanthan commented on issue #1255: Fixing #1231. Adding order and status to trace query. URL: https://github.com/apache/incubator-skywalking/pull/1255#issuecomment-391161821 OK. Let me change Ints to enum and resend the pull request. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on a change in pull request #1252: Update release doc and related script
wu-sheng commented on a change in pull request #1252: Update release doc and
related script
URL:
https://github.com/apache/incubator-skywalking/pull/1252#discussion_r190070122
##
File path: tools/releasing/create_source_release.sh
##
@@ -20,11 +20,13 @@
# This script relies on few environment variables to determine source code
package
# behavior, those variables are:
# RELEASE_VERSION -- The version of this source package.
+# RELEASE_ROUND -- The round of this version release.
# For example: RELEASE_VERSION=5.0.0-alpha
+# RELEASE_ROUND=1
RELEASE_VERSION=${RELEASE_VERSION}
-TAG_NAME="v"${RELEASE_VERSION}
+TAG_NAME=${RELEASE_VERSION}(RC${RELEASE_ROUND})
Review comment:
I am OK with this. Let's merge the new doc and script.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] coveralls commented on issue #1255: Fixing #1231. Adding order and status to trace query.
coveralls commented on issue #1255: Fixing #1231. Adding order and status to trace query. URL: https://github.com/apache/incubator-skywalking/pull/1255#issuecomment-391136082 [](https://coveralls.io/builds/17113658) Coverage decreased (-0.002%) to 23.498% when pulling **8b0dbbc24fa6d12369eef606cf284e27c147e99b on ajanthan:master** into **d55640454ee63b151272f043697f8779bb6cdd50 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ajanthan opened a new pull request #172: Fixing Issue 1231[https://github.com/apache/incubator-skywalking/issu…
ajanthan opened a new pull request #172: Fixing Issue 1231[https://github.com/apache/incubator-skywalking/issu… URL: https://github.com/apache/incubator-skywalking-ui/pull/172 Fixing issue[1231](https://github.com/apache/incubator-skywalking/issues/1231). Enabling trace search by status and order. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #1252: Update release doc and related script
coveralls commented on issue #1252: Update release doc and related script URL: https://github.com/apache/incubator-skywalking/pull/1252#issuecomment-390857578 [](https://coveralls.io/builds/17108683) Coverage decreased (-0.004%) to 23.495% when pulling **014e6c1b609d28a75b68bf7d7d1604b0c1255894 on release-doc** into **d55640454ee63b151272f043697f8779bb6cdd50 on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #1252: Update release doc and related script
coveralls commented on issue #1252: Update release doc and related script URL: https://github.com/apache/incubator-skywalking/pull/1252#issuecomment-390857578 [](https://coveralls.io/builds/17102332) Coverage decreased (-0.004%) to 23.495% when pulling **6d7443c80152843eb3498f99ddc2d3ae3f9ab841 on release-doc** into **d55640454ee63b151272f043697f8779bb6cdd50 on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SevenPointOld commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)
SevenPointOld commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-390936276 Promise This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SevenPointOld commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)
SevenPointOld commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-390936276 Promise This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] harley2011 commented on issue #1254: Duplicate traceid in different request
harley2011 commented on issue #1254: Duplicate traceid in different request URL: https://github.com/apache/incubator-skywalking/issues/1254#issuecomment-390916264 I need to rewrite the class of "com.github.danielwegener.logback.kafka.KafkaAppender"? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] harley2011 opened a new issue #1254: traceid重复，不同请求的traceid相同问题
harley2011 opened a new issue #1254: traceid重复，不同请求的traceid相同问题 URL: https://github.com/apache/incubator-skywalking/issues/1254 Hi 各位大佬： 现在我们项目集成skywalking出现不同请求traceid重复的问题，麻烦帮忙看下是什么原因，引起的谢谢。 logback配置如下：  日志出来相同的traceid:  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1250: Dashboard to Service page Error
wu-sheng commented on issue #1250: Dashboard to Service page Error URL: https://github.com/apache/incubator-skywalking/issues/1250#issuecomment-390895067 That is query for front and behind, but, that should not be the problem. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1250: Dashboard to Service page Error
wu-sheng commented on issue #1250: Dashboard to Service page Error URL: https://github.com/apache/incubator-skywalking/issues/1250#issuecomment-390890621 I am a little confused. Local span should be not part of analysis, and if EntrySpan and ExistSpan are in different segment, then should no dependencies. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] candyleer commented on issue #1250: Dashboard to Service page Error
candyleer commented on issue #1250: Dashboard to Service page Error URL: https://github.com/apache/incubator-skywalking/issues/1250#issuecomment-390889788 so that mean if we use cross thread and create exit span in it this issue may reproduce. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] candyleer commented on issue #1250: Dashboard to Service page Error
candyleer commented on issue #1250: Dashboard to Service page Error URL: https://github.com/apache/incubator-skywalking/issues/1250#issuecomment-390889525 @wu-sheng I found the listener `public class ServiceReferenceMetricSpanListener implements EntrySpanListener, ExitSpanListener `just parse the entry and exit span ,but in `cross thread` ,we create local span for it, so in es,`service_name` has service_id (36,44,-42),but service_metric_minute(or hour,day) didn't contain,so cannot found the nodes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] candyleer commented on issue #1250: Dashboard to Service page Error
candyleer commented on issue #1250: Dashboard to Service page Error URL: https://github.com/apache/incubator-skywalking/issues/1250#issuecomment-390885487 Yes ,I am reading the backend method and try to fix it This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] candyleer commented on issue #1250: Dashboard to Service page Error
candyleer commented on issue #1250: Dashboard to Service page Error URL: https://github.com/apache/incubator-skywalking/issues/1250#issuecomment-390885487 Yes ,I am reading the back method and try to fix it This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1250: Dashboard to Service page Error
wu-sheng commented on issue #1250: Dashboard to Service page Error URL: https://github.com/apache/incubator-skywalking/issues/1250#issuecomment-390883972 > I read the ui codes,maybe it's caused by in getServiceTopology the nodes don't contain the calls source,only target If `nodes` doesn't include all `source` and `target`, that should a backend bug. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] candyleer commented on issue #1250: Dashboard to Service page Error
candyleer commented on issue #1250: Dashboard to Service page Error URL: https://github.com/apache/incubator-skywalking/issues/1250#issuecomment-390880087 I read the ui codes,maybe it's caused by in `getServiceTopology ` the `nodes` don't contain the calls `source`,only `target` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] candyleer commented on issue #1250: Dashboard to Service page Error
candyleer commented on issue #1250: Dashboard to Service page Error URL: https://github.com/apache/incubator-skywalking/issues/1250#issuecomment-390880087 I read the ui codes,maybe it's caused by in `getServiceTopology ` the nodes don't contain the calls `source`,only `target` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed pull request #1253: Fix NPE in Okhttp plugin when connect failed
wu-sheng closed pull request #1253: Fix NPE in Okhttp plugin when connect failed
URL: https://github.com/apache/incubator-skywalking/pull/1253
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/apm-sniffer/apm-sdk-plugin/okhttp-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/okhttp/v3/RealCallInterceptor.java
b/apm-sniffer/apm-sdk-plugin/okhttp-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/okhttp/v3/RealCallInterceptor.java
index e00c74715..d9a9ae7ab 100644
---
a/apm-sniffer/apm-sdk-plugin/okhttp-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/okhttp/v3/RealCallInterceptor.java
+++
b/apm-sniffer/apm-sdk-plugin/okhttp-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/okhttp/v3/RealCallInterceptor.java
@@ -100,12 +100,13 @@ public void onConstruct(EnhancedInstance objInst,
Object[] allArguments) {
public Object afterMethod(EnhancedInstance objInst, Method method,
Object[] allArguments,
Class[] argumentsTypes, Object ret) throws Throwable {
Response response = (Response)ret;
-int statusCode = response.code();
-
-AbstractSpan span = ContextManager.activeSpan();
-if (statusCode >= 400) {
-span.errorOccurred();
-Tags.STATUS_CODE.set(span, Integer.toString(statusCode));
+if (response != null) {
+int statusCode = response.code();
+AbstractSpan span = ContextManager.activeSpan();
+if (statusCode >= 400) {
+span.errorOccurred();
+Tags.STATUS_CODE.set(span, Integer.toString(statusCode));
+}
}
ContextManager.stopSpan();
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
