[GitHub] SevenPointOld commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)
SevenPointOld commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-391929197 OK, I'll do it This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hardzhang opened a new pull request #1264: way to solve Import-Project-Eclipse-RequireItems-Exception
hardzhang opened a new pull request #1264: way to solve Import-Project-Eclipse-RequireItems-Exception URL: https://github.com/apache/incubator-skywalking/pull/1264 导入skywalking工程到eclipse,遇到如下异常 Missing requirement: Checkstyle configuration plugin for M2Eclipse 1.0.0.201705301746 (com.basistech.m2e.code.quality.checkstyle.feature.feature.group 1.0.0.201705301746) requires 'net.sf.eclipsecs.core 5.2.0' but it could not be found 解决办法。 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1263: Separated TTL to TTL-day and TTL-month
wu-sheng commented on issue #1263: Separated TTL to TTL-day and TTL-month URL: https://github.com/apache/incubator-skywalking/issues/1263#issuecomment-391912765 Sorry, should be TTL-month, not year. :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1262: Filter non-active service name when UI query.
wu-sheng commented on issue #1262: Filter non-active service name when UI query. URL: https://github.com/apache/incubator-skywalking/pull/1262#issuecomment-391730284 And 24 hours look like too unpredict to end user. I suggest we support ttl-day, ttl-year to remove data. And the service status of valid could be considered by the ttl-*. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #1262: Filter non-active service name when UI query.
coveralls commented on issue #1262: Filter non-active service name when UI query. URL: https://github.com/apache/incubator-skywalking/pull/1262#issuecomment-391712845 [](https://coveralls.io/builds/17147136) Coverage decreased (-0.08%) to 23.785% when pulling **9230288851407f9d9e56823bc4c47372ef6687eb on peng-yongsheng:feature/1124** into **5893dbe926c2b3db2c22cd459455dd13e7065143 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #1262: Filter non-active service name when UI query.
coveralls commented on issue #1262: Filter non-active service name when UI query. URL: https://github.com/apache/incubator-skywalking/pull/1262#issuecomment-391712845 [](https://coveralls.io/builds/17146712) Coverage decreased (-0.08%) to 23.788% when pulling **3cd7fcff46d8270a7d808db3c1277eb39699cdd6 on peng-yongsheng:feature/1124** into **5893dbe926c2b3db2c22cd459455dd13e7065143 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng closed issue #1195: Invalid calls in Service topology query
peng-yongsheng closed issue #1195: Invalid calls in Service topology query URL: https://github.com/apache/incubator-skywalking/issues/1195 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng commented on issue #1195: Invalid calls in Service topology query
peng-yongsheng commented on issue #1195: Invalid calls in Service topology query URL: https://github.com/apache/incubator-skywalking/issues/1195#issuecomment-391644247 Add check method into agent-collector protocol to avoid system exception when users clean all of the data in storage. It seems not the best solution. Why users clean all of the data? 1. Upgrade collector 1. Reset system The best solution is: 1. [Agent dynamic refresh](https://github.com/apache/incubator-skywalking/issues/1181) 1. Display all the agents which connecting to the collector in UI, and by click the `Reset` button to reset agents. 1. Better documentation. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #1261: Sync UI about trace query.
coveralls commented on issue #1261: Sync UI about trace query. URL: https://github.com/apache/incubator-skywalking/pull/1261#issuecomment-391633574 [](https://coveralls.io/builds/17142195) Coverage decreased (-0.004%) to 23.87% when pulling **0b362cb06d7f8cb076ec26d1301289d98d6da5a0 on ui-sync** into **58ede1d0b8b47620fcfbb62d97aa2d8032bd3818 on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1236: bug:5.0.0-beta:The project contains hystrix1.5.12 and rxjava-1.2.0 packages
wu-sheng commented on issue #1236: bug:5.0.0-beta:The project contains hystrix1.5.12 and rxjava-1.2.0 packages URL: https://github.com/apache/incubator-skywalking/issues/1236#issuecomment-391633056 @wfs0902 Could you recheck this for our master code? I assume it is fixed. If fix fails, please reopen this issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed issue #1238: NPE when use hystrix in spring
wu-sheng closed issue #1238: NPE when use hystrix in spring URL: https://github.com/apache/incubator-skywalking/issues/1238 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed issue #1231: Add order and status options in trace query.
wu-sheng closed issue #1231: Add order and status options in trace query. URL: https://github.com/apache/incubator-skywalking/issues/1231 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1238: NPE when use hystrix in spring
wu-sheng commented on issue #1238: NPE when use hystrix in spring URL: https://github.com/apache/incubator-skywalking/issues/1238#issuecomment-391632726 Fixed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)
wu-sheng commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-391629031 @SevenPointOld I think you miss add your README to incubating features menu.  Also, you should consider to add a section in Chinese document: https://github.com/apache/incubator-skywalking/blob/master/docs/README_ZH.md The title should be `孵化特性`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng opened a new pull request #1261: Sync UI about trace query.
wu-sheng opened a new pull request #1261: Sync UI about trace query. URL: https://github.com/apache/incubator-skywalking/pull/1261 Because I merged the new trace query, I have to submit this UI sync. Otherwise, most likely, trace query will not be able to use. FYI @apache/skywalking-committers This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed issue #462: [Agent] Plugin for Spring ThreadPoolTaskExecutor
wu-sheng closed issue #462: [Agent] Plugin for Spring ThreadPoolTaskExecutor URL: https://github.com/apache/incubator-skywalking/issues/462 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] carlvine500 commented on issue #462: [Agent] Plugin for Spring ThreadPoolTaskExecutor
carlvine500 commented on issue #462: [Agent] Plugin for Spring
ThreadPoolTaskExecutor
URL:
https://github.com/apache/incubator-skywalking/issues/462#issuecomment-391603189
@wu-sheng I think it's already supported , @wtj199101 follow my example:
```
ExecutorService threadPool = Executors.newFixedThreadPool(1);
// your code
threadPool.execute(() -> {
try {
//
} catch (Exception e) {
//
}
});
// your code with trace across thread
threadPool.execute(RunnableWrapper.of(() -> {
try {
//
} catch (Exception e) {
//
}
}));
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wu-sheng closed pull request #1255: Fixing #1231. Adding order and status to trace query.
wu-sheng closed pull request #1255: Fixing #1231. Adding order and status to
trace query.
URL: https://github.com/apache/incubator-skywalking/pull/1255
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/dao/ui/ISegmentDurationUIDAO.java
b/apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/dao/ui/ISegmentDurationUIDAO.java
index 46e82826a..97f93f3ff 100644
---
a/apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/dao/ui/ISegmentDurationUIDAO.java
+++
b/apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/dao/ui/ISegmentDurationUIDAO.java
@@ -19,7 +19,9 @@
package org.apache.skywalking.apm.collector.storage.dao.ui;
import org.apache.skywalking.apm.collector.storage.base.dao.DAO;
+import org.apache.skywalking.apm.collector.storage.ui.trace.QueryOrder;
import org.apache.skywalking.apm.collector.storage.ui.trace.TraceBrief;
+import org.apache.skywalking.apm.collector.storage.ui.trace.TraceState;
/**
* Interface to be implemented for execute database query operation
@@ -55,5 +57,5 @@
* @return not nullable result list
*/
TraceBrief loadTop(long startSecondTimeBucket, long endSecondTimeBucket,
long minDuration, long maxDuration,
-String operationName, int applicationId, int limit, int from,
String... segmentIds);
+ String operationName, int applicationId, int limit, int
from, TraceState traceState, QueryOrder queryOrder, String... segmentIds);
}
diff --git
a/apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/ui/trace/QueryOrder.java
b/apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/ui/trace/QueryOrder.java
new file mode 100644
index 0..2f0a5f9d1
--- /dev/null
+++
b/apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/ui/trace/QueryOrder.java
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.collector.storage.ui.trace;
+
+public enum QueryOrder {
+BY_START_TIME,
+BY_DURATION
+}
diff --git
a/apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/ui/trace/TraceQueryCondition.java
b/apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/ui/trace/TraceQueryCondition.java
index 86bea1abe..103d70043 100644
---
a/apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/ui/trace/TraceQueryCondition.java
+++
b/apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/ui/trace/TraceQueryCondition.java
@@ -31,6 +31,25 @@
private Duration queryDuration;
private int minTraceDuration;
private int maxTraceDuration;
+private TraceState traceState;
+private QueryOrder queryOrder;
+
+public TraceState getTraceState() {
+return traceState;
+}
+
+public void setTraceState(TraceState traceState) {
+this.traceState = traceState;
+}
+
+public QueryOrder getQueryOrder() {
+return queryOrder;
+}
+
+public void setQueryOrder(QueryOrder queryOrder) {
+this.queryOrder = queryOrder;
+}
+
private Pagination paging;
public int getApplicationId() {
diff --git
a/apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/ui/trace/TraceState.java
[GitHub] wu-sheng closed pull request #1240: Add application filter for service and two conditions for trace query.
wu-sheng closed pull request #1240: Add application filter for service and two conditions for trace query. URL: https://github.com/apache/incubator-skywalking/pull/1240 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
