[GitHub] [skywalking] aderm commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario
aderm commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#issuecomment-551419131 Ok, next will add comments and test the interceptors via mock. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng merged pull request #3802: Provide archetypes for plugin testcase
wu-sheng merged pull request #3802: Provide archetypes for plugin testcase URL: https://github.com/apache/skywalking/pull/3802 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[skywalking] branch master updated (998ce29 -> 23bc69c)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
from 998ce29 update plugin test doc. (#3804)
add 23bc69c Provide archetypes for plugin testcase (#3802)
No new revisions were added by this update.
Summary of changes:
docs/en/guides/Plugin-test.md | 10 ++
.../tomcat-container => archetypes/jvm}/pom.xml| 21 ++--
.../META-INF/maven/archetype-metadata.xml | 65
.../resources/archetype-resources}/bin/startup.sh | 2 +-
.../archetype-resources/config/expectedData.yaml | 23 +++--
.../archetype-resources}/configuration.yml | 8 +-
.../main/resources/archetype-resources}/pom.xml| 54 +++---
.../src/main/assembly/assembly.xml | 2 +-
.../src/main/java}/Application.java| 2 +-
.../src/main/java/controller}/CaseController.java | 23 +++--
.../src/main/resources/application.properties | 3 +-
.../src/main/resources/log4j2.xml | 0
.../archetype-resources}/support-version.list | 6 +-
test/{e2e/e2e-ttl => plugin/archetypes}/pom.xml| 22 ++--
.../tomcat-container => archetypes/tomcat}/pom.xml | 21 ++--
.../META-INF/maven/archetype-metadata.xml | 64
.../archetype-resources/config/expectedData.yaml | 23 +++--
.../archetype-resources}/configuration.yml | 9 +-
.../main/resources/archetype-resources}/pom.xml| 25 ++---
.../src/main/java/CaseServlet.java}| 13 ++-
.../src/main/java}/HealthCheckServlet.java | 2 +-
.../src/main/resources/log4j2.xml | 0
.../src/main/webapp/WEB-INF/web.xml| 19 ++--
.../archetype-resources}/support-version.list | 6 +-
test/plugin/generator.sh | 111 +
25 files changed, 378 insertions(+), 156 deletions(-)
copy test/plugin/{containers/tomcat-container => archetypes/jvm}/pom.xml (77%)
create mode 100644
test/plugin/archetypes/jvm/src/main/resources/META-INF/maven/archetype-metadata.xml
copy test/plugin/{scenarios/sofarpc-scenario =>
archetypes/jvm/src/main/resources/archetype-resources}/bin/startup.sh (93%)
copy apm-dist/bin/startup.sh =>
test/plugin/archetypes/jvm/src/main/resources/archetype-resources/config/expectedData.yaml
(76%)
copy test/plugin/{scenarios/sofarpc-scenario =>
archetypes/jvm/src/main/resources/archetype-resources}/configuration.yml (81%)
copy test/plugin/{scenarios/jetty-scenario/jettyclient-scenario =>
archetypes/jvm/src/main/resources/archetype-resources}/pom.xml (62%)
copy test/plugin/{scenarios/sofarpc-scenario =>
archetypes/jvm/src/main/resources/archetype-resources}/src/main/assembly/assembly.xml
(96%)
copy
test/plugin/{scenarios/canal-scenario/src/main/java/org/apache/skywalking/apm/testcase/canal
=>
archetypes/jvm/src/main/resources/archetype-resources/src/main/java}/Application.java
(95%)
copy
test/plugin/{scenarios/spring-3.0.x-scenario/src/main/java/test/org/apache/skywalking/apm/testcase/spring3
=>
archetypes/jvm/src/main/resources/archetype-resources/src/main/java/controller}/CaseController.java
(71%)
copy test/plugin/{scenarios/canal-scenario =>
archetypes/jvm/src/main/resources/archetype-resources}/src/main/resources/application.properties
(91%)
copy test/plugin/{scenarios/spring-4.3.x-scenario =>
archetypes/jvm/src/main/resources/archetype-resources}/src/main/resources/log4j2.xml
(100%)
copy test/plugin/{scenarios/canal-scenario =>
archetypes/jvm/src/main/resources/archetype-resources}/support-version.list
(96%)
copy test/{e2e/e2e-ttl => plugin/archetypes}/pom.xml (81%)
copy test/plugin/{containers/tomcat-container => archetypes/tomcat}/pom.xml
(77%)
create mode 100644
test/plugin/archetypes/tomcat/src/main/resources/META-INF/maven/archetype-metadata.xml
copy apm-dist/bin/startup.sh =>
test/plugin/archetypes/tomcat/src/main/resources/archetype-resources/config/expectedData.yaml
(76%)
copy test/plugin/{scenarios/jetty-scenario =>
archetypes/tomcat/src/main/resources/archetype-resources}/configuration.yml
(80%)
copy test/plugin/{scenarios/ehcache-2.x-scenario =>
archetypes/tomcat/src/main/resources/archetype-resources}/pom.xml (81%)
copy
test/plugin/{scenarios/httpclient-4.3.x-scenario/src/main/java/org/apache/skywalking/apm/testcase/httpclient/HealthCheckServlet.java
=>
archetypes/tomcat/src/main/resources/archetype-resources/src/main/java/CaseServlet.java}
(85%)
copy
test/plugin/{scenarios/httpclient-4.3.x-scenario/src/main/java/org/apache/skywalking/apm/testcase/httpclient
=>
archetypes/tomcat/src/main/resources/archetype-resources/src/main/java}/HealthCheckServlet.java
(96%)
copy test/plugin/{scenarios/httpclient-4.3.x-scenario =>
archetypes/tomcat/src/main/resources/archetype-resources}/src/main/resources/log4j2.xml
(100%)
copy
[GitHub] [skywalking] wu-sheng commented on issue #3802: Provide archetypes for plugin testcase
wu-sheng commented on issue #3802: Provide archetypes for plugin testcase URL: https://github.com/apache/skywalking/pull/3802#issuecomment-551403738 This is a very productive and helpful feature for new contributors. Great idea. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3805: The webflux-plugin is not working properly
wu-sheng commented on issue #3805: The webflux-plugin is not working properly URL: https://github.com/apache/skywalking/issues/3805#issuecomment-551399963 @cyejing You could check the test at https://github.com/apache/skywalking/tree/master/test/plugin/scenarios/webflux-scenario, and get the idea what is the difference. @zhaoyuguang Maybe we just support part of it. I remember we just support webflux + Spring MVC, rather than real Reactive framework. You know better than me. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking-cli] wu-sheng commented on issue #6: [Feature] Set GraphQL client and add service ls command
wu-sheng commented on issue #6: [Feature] Set GraphQL client and add service ls command URL: https://github.com/apache/skywalking-cli/pull/6#issuecomment-551397201 @heyanlong It doesn't look like you approved this PR, there is still comment in your reply. Is this a mistake? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario
wu-sheng commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#issuecomment-551396919 > 1. No comment for codes 1. No unit test cases for interceptors. You should mock parameter to check the interceptors. Follow this two, others LGTM. @kezhenxu94 @dmsolr @arugal Please recheck. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario
wu-sheng commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#discussion_r343998249 ## File path: apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/ComponentsDefine.java ## @@ -143,4 +143,6 @@ public static final OfficialComponent EHCACHE = new OfficialComponent(75, "Ehcache"); public static final OfficialComponent SOCKET_IO = new OfficialComponent(76, "SocketIO"); + +public static final OfficialComponent REST_HIGH_LEVEL_CLIENT = new OfficialComponent(77, "rest-high-level-client"); Review comment: Yes. HTTP Client is recommended. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] arugal commented on issue #3802: Provide archetypes for plugin testcase
arugal commented on issue #3802: Provide archetypes for plugin testcase URL: https://github.com/apache/skywalking/pull/3802#issuecomment-551396196 Wait PR merge. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] dmsolr edited a comment on issue #3788: Rabbitmq plugin test migration
dmsolr edited a comment on issue #3788: Rabbitmq plugin test migration URL: https://github.com/apache/skywalking/pull/3788#issuecomment-551135794 Hi, @viswaramamoorthy ~~I updated the default value of BUILD_ID without usage.~~ (I have a mistake. In fact, it has deleted.) I have merged the master into your pr. Now, you need to pull the latest code. and retry it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] cyejing opened a new issue #3805: The webflux-plugin is not working properly
cyejing opened a new issue #3805: The webflux-plugin is not working properly URL: https://github.com/apache/skywalking/issues/3805 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [X] Bug - [ ] Requirement - [ ] Feature or performance improvement ___ ### Question - What do you want to know? The webflux-plugin is not working properly because WebFlux is Reactive Programming ，plugin use ThreadLocal is not working properly webflux-plugin 并不能正常工作,因为 WebFlux 是响应式编程。 处理的线程会发生变化，插件内部使用ThreadLocal 根本不能获取到原来线程的信息，还会因为未能正确关闭span信息 导致ThreadLocal一直没有释放 ___ ### Bug - What happen? this is debug msg：    webflux-plugins Intercept 3 method ，the thread has changed when the method is executed ___ ### Requirement or improvement - Need to deal with it without relying on ThreadLocal This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario
aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin
& elasticsearch 6.x test scenario
URL: https://github.com/apache/skywalking/pull/3803#discussion_r343975636
##
File path: Jenkinsfile-Agent-Test
##
@@ -82,6 +83,12 @@ pipeline {
parallel {
stage('Group1') {
stages {
+stage('elasticsearch-6.x-scenario 6.7.1-6.8.4 (7)') {
+steps {
+sh 'bash test/plugin/run.sh
--build_id=wl1_${BUILD_ID} elasticsearch-6.x-scenario'
Review comment:
ok
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario
aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#discussion_r343975431 ## File path: apm-sniffer/apm-sdk-plugin/elasticsearch-6.x-plugin/pom.xml ## @@ -0,0 +1,49 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> + +apm-sdk-plugin +org.apache.skywalking +6.5.0-SNAPSHOT + +4.0.0 + +apm-elasticsearch-6.x-plugin +jar + +elasticsearch-6.x-plugin +http://maven.apache.org + + +UTF-8 +1.8 Review comment: OK, I will delete java.version. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking-cli] heyanlong commented on a change in pull request #6: [Feature] Set GraphQL client and add service ls command
heyanlong commented on a change in pull request #6: [Feature] Set GraphQL
client and add service ls command
URL: https://github.com/apache/skywalking-cli/pull/6#discussion_r343972888
##
File path: commands/service/list.go
##
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package service
+
+import (
+ "encoding/json"
+ "fmt"
+ "github.com/apache/skywalking-cli/commands"
+ "github.com/apache/skywalking-cli/graphql/client"
+ "github.com/apache/skywalking-cli/graphql/schema"
+ "github.com/urfave/cli"
+)
+
+var ListCommand = cli.Command{
+ Name: "list",
+ ShortName: "ls",
+ Usage: "List all available services",
+ Flags: []cli.Flag{
+ cli.StringFlag{
+ Name: "start",
+ Usage: "Query start time",
+ },
+ cli.StringFlag{
+ Name: "end",
+ Usage: "Query end time",
+ },
+ cli.GenericFlag{
+ Name: "step",
+ Value: {
+ Enum: schema.AllStep,
+ Default: schema.StepMinute,
+ Selected: schema.StepMinute,
+ },
+ },
+ },
+ Before: commands.BeforeChain([]cli.BeforeFunc{
+ commands.SetUpDuration,
+ }),
+ Action: func(ctx *cli.Context) error {
+ end := ctx.String("end")
+ start := ctx.String("start")
+ step := ctx.Generic("step")
+ services := client.Services(schema.Duration{
+ Start: start,
+ End: end,
+ Step: step.(*commands.StepEnumValue).Selected,
+ })
+
+ if bytes, e := json.Marshal(services); e != nil {
Review comment:
Add bool flag --table or -t output table mode?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] heyanlong commented on a change in pull request #6: [Feature] Set GraphQL client and add service ls command
heyanlong commented on a change in pull request #6: [Feature] Set GraphQL
client and add service ls command
URL: https://github.com/apache/skywalking-cli/pull/6#discussion_r343973491
##
File path: scripts/build
##
@@ -20,7 +20,7 @@
cli_build() {
out="bin"
CGO_ENABLED=0 go build $GO_BUILD_FLAGS \
- -o "${out}/swctl" cmd/* || return
+ -o "${out}/swctl" swctl/* || return
Review comment:
cmd is officially recommended by golang.
e.g.
cmd/swctl/*
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario
aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#discussion_r343973617 ## File path: apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/ComponentsDefine.java ## @@ -143,4 +143,6 @@ public static final OfficialComponent EHCACHE = new OfficialComponent(75, "Ehcache"); public static final OfficialComponent SOCKET_IO = new OfficialComponent(76, "SocketIO"); + +public static final OfficialComponent REST_HIGH_LEVEL_CLIENT = new OfficialComponent(77, "rest-high-level-client"); Review comment: This is not recommended in the new ES version. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] arugal commented on a change in pull request #3788: Rabbitmq plugin test migration
arugal commented on a change in pull request #3788: Rabbitmq plugin test
migration
URL: https://github.com/apache/skywalking/pull/3788#discussion_r343972646
##
File path: test/plugin/scenarios/rabbitmq-scenario/config/expectedData.yaml
##
@@ -0,0 +1,100 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+registryItems:
+ applications:
+ - {rabbitmq-scenario: nq 0}
+ instances:
+ - {rabbitmq-scenario: 1}
+ operationNames:
+ - rabbitmq-scenario:
[/rabbitmq-scenario/case/rabbitmq,/rabbitmq-scenario/case/healthcheck,RabbitMQ/Topic/Queue/test/Producer,RabbitMQ/Topic/Queue/test/Consumer]
+segmentItems:
+- applicationCode: rabbitmq-scenario
+ segmentSize: ge 2
+ segments:
Review comment:
Should be changed to ```gt 2``` or ```ge 3```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] arugal commented on a change in pull request #3788: Rabbitmq plugin test migration
arugal commented on a change in pull request #3788: Rabbitmq plugin test
migration
URL: https://github.com/apache/skywalking/pull/3788#discussion_r343971873
##
File path: test/plugin/scenarios/rabbitmq-scenario/config/expectedData.yaml
##
@@ -0,0 +1,100 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+registryItems:
+ applications:
+ - {rabbitmq-scenario: nq 0}
+ instances:
+ - {rabbitmq-scenario: 1}
+ operationNames:
+ - rabbitmq-scenario:
[/rabbitmq-scenario/case/rabbitmq,/rabbitmq-scenario/case/healthcheck,RabbitMQ/Topic/Queue/test/Producer,RabbitMQ/Topic/Queue/test/Consumer]
Review comment:
Don't need healthcheck operation name
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] arugal commented on a change in pull request #3788: Rabbitmq plugin test migration
arugal commented on a change in pull request #3788: Rabbitmq plugin test
migration
URL: https://github.com/apache/skywalking/pull/3788#discussion_r343971635
##
File path: test/plugin/scenarios/rabbitmq-scenario/config/expectedData.yaml
##
@@ -0,0 +1,100 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+registryItems:
+ applications:
+ - {rabbitmq-scenario: nq 0}
+ instances:
+ - {rabbitmq-scenario: 1}
+ operationNames:
+ - rabbitmq-scenario:
[/rabbitmq-scenario/case/rabbitmq,/rabbitmq-scenario/case/healthcheck,RabbitMQ/Topic/Queue/test/Producer,RabbitMQ/Topic/Queue/test/Consumer]
+segmentItems:
+- applicationCode: rabbitmq-scenario
+ segmentSize: ge 2
+ segments:
+ - segmentId: not null
+spans:
+- operationName: RabbitMQ/Topic/Queue/test/Consumer
+ operationId: 0
+ parentSpanId: -1
+ spanId: 0
+ spanLayer: MQ
+ startTime: nq 0
+ endTime: nq 0
+ componentId: 53
+ componentName: ''
+ isError: false
+ spanType: Entry
+ peer: ''
+ peerId: 0
+ tags:
+ - {key: mq.broker, value: 'not null'}
+ - {key: mq.topic, value: ''}
+ - {key: mq.queue, value: test}
+ refs:
+ - {parentEndpointId: 0, parentEndpoint:
/rabbitmq-scenario/case/rabbitmq, networkAddressId: 0,entryEndpointId: 0,
refType: CrossProcess, parentSpanId: 1, parentTraceSegmentId: not
null,parentServiceInstanceId: nq 0, networkAddress: not null, entryEndpoint:
/rabbitmq-scenario/case/rabbitmq,entryServiceInstanceId: nq 0}
+ - segmentId: not null
+spans:
+- operationName: RabbitMQ/Topic/Queue/test/Producer
+ operationId: 0
+ parentSpanId: 0
+ spanId: 1
+ spanLayer: MQ
+ startTime: nq 0
+ endTime: nq 0
+ componentId: 52
+ componentName: ''
+ isError: false
+ spanType: Exit
+ peer: not null
+ peerId: 0
+ tags:
+ - {key: mq.broker, value: 'not null'}
+ - {key: mq.queue, value: test}
+ - {key: mq.topic, value: ''}
+- operationName: /rabbitmq-scenario/case/rabbitmq
+ operationId: 0
+ parentSpanId: -1
+ spanId: 0
+ spanLayer: Http
+ startTime: nq 0
+ endTime: nq 0
+ componentId: 1
+ componentName: ''
+ isError: false
+ spanType: Entry
+ peer: ''
+ peerId: 0
+ tags:
+ - {key: url, value:
'http://localhost:8080/rabbitmq-scenario/case/rabbitmq'}
+ - {key: http.method, value: GET}
+ - segmentId: not null
+spans:
+- operationName: /rabbitmq-scenario/case/healthcheck
+ operationId: 0
Review comment:
Don't need healthcheck segment
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] innerpeacez commented on issue #7: Added subcommand structure based on design documentation
innerpeacez commented on issue #7: Added subcommand structure based on design documentation URL: https://github.com/apache/skywalking-cli/pull/7#issuecomment-551360343 Sorry, I didn't see his @kezhenxu94 pr, I closed it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking-cli] innerpeacez closed pull request #7: Added subcommand structure based on design documentation
innerpeacez closed pull request #7: Added subcommand structure based on design documentation URL: https://github.com/apache/skywalking-cli/pull/7 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking-cli] innerpeacez commented on issue #7: Added subcommand structure based on design documentation
innerpeacez commented on issue #7: Added subcommand structure based on design documentation URL: https://github.com/apache/skywalking-cli/pull/7#issuecomment-551359277 I am not sure if this is appropriate. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] dmsolr commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario
dmsolr commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#discussion_r343966272 ## File path: apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/ComponentsDefine.java ## @@ -143,4 +143,6 @@ public static final OfficialComponent EHCACHE = new OfficialComponent(75, "Ehcache"); public static final OfficialComponent SOCKET_IO = new OfficialComponent(76, "SocketIO"); + +public static final OfficialComponent REST_HIGH_LEVEL_CLIENT = new OfficialComponent(77, "rest-high-level-client"); Review comment: What is it? Why don't we use `TRANSPORT_CLIENT`? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] dmsolr commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario
dmsolr commented on a change in pull request #3803: Add elasticsearch 6.x
plugin & elasticsearch 6.x test scenario
URL: https://github.com/apache/skywalking/pull/3803#discussion_r343965420
##
File path: Jenkinsfile-Agent-Test
##
@@ -82,6 +83,12 @@ pipeline {
parallel {
stage('Group1') {
stages {
+stage('elasticsearch-6.x-scenario 6.7.1-6.8.4 (7)') {
+steps {
+sh 'bash test/plugin/run.sh
--build_id=wl1_${BUILD_ID} elasticsearch-6.x-scenario'
Review comment:
we don't need the argument, build_id.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] innerpeacez opened a new pull request #7: Added subcommand structure based on design documentation
innerpeacez opened a new pull request #7: Added subcommand structure based on design documentation URL: https://github.com/apache/skywalking-cli/pull/7 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[skywalking-website] branch asf-site updated (aa9b9d4 -> a395f6b)
This is an automated email from the ASF dual-hosted git repository.
tanjian pushed a change to branch asf-site
in repository https://gitbox.apache.org/repos/asf/skywalking-website.git.
discard aa9b9d4 Update asf-site
new a395f6b Update asf-site
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (aa9b9d4)
\
N -- N -- N refs/heads/asf-site (a395f6b)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
404.html | 6 +-
assets/js/{10.9cfa209a.js => 10.bcff8a3a.js} | 2 +-
assets/js/{11.2dc6ed02.js => 11.1f0c7d5a.js} | 2 +-
assets/js/{12.ddea7324.js => 12.519e658f.js} | 2 +-
assets/js/{13.92bcb689.js => 13.e36e9a07.js} | 2 +-
assets/js/{14.7c4021c3.js => 14.147a9f03.js} | 2 +-
assets/js/{15.8e544ce7.js => 15.e7ebbad3.js} | 2 +-
assets/js/{16.d2cc69cb.js => 16.8fae2424.js} | 2 +-
assets/js/{17.8a8b59b1.js => 17.9607da83.js} | 2 +-
assets/js/{18.b4a75423.js => 18.505b417f.js} | 2 +-
assets/js/{19.5e409ee0.js => 19.40b15dc7.js} | 2 +-
assets/js/{2.fdde4b34.js => 2.5ca0d2ea.js} | 2 +-
assets/js/{20.bae1dccc.js => 20.23be1686.js} | 2 +-
assets/js/{21.3b9135d9.js => 21.30b90620.js} | 2 +-
assets/js/{22.4c4f3a16.js => 22.1ec92db7.js} | 2 +-
assets/js/{23.bc4e663b.js => 23.4d49a942.js} | 2 +-
assets/js/{24.d122c5da.js => 24.c8bc73b4.js} | 2 +-
assets/js/{25.84640f07.js => 25.c180dbab.js} | 2 +-
assets/js/{26.b1354649.js => 26.f246d928.js} | 2 +-
assets/js/{27.d2a2e26c.js => 27.e5239ee2.js} | 2 +-
assets/js/{28.9ccab755.js => 28.0e7a3c98.js} | 2 +-
assets/js/29.577faf47.js | 1 +
assets/js/{3.03f1e1c3.js => 3.d831833d.js} | 2 +-
assets/js/{29.f0c6237d.js => 30.2449f9bd.js} | 2 +-
assets/js/{30.6731b6af.js => 31.3bca69bc.js} | 2 +-
assets/js/{31.d5a21496.js => 32.ed688561.js} | 2 +-
assets/js/{32.a2646e59.js => 33.6e9d8ba2.js} | 2 +-
assets/js/34.eda87250.js | 1 -
assets/js/{33.4e6ea0ed.js => 34.fe427a63.js} | 2 +-
assets/js/35.25e2d1b2.js | 1 +
assets/js/{4.1ec9fd89.js => 4.0bf197d5.js} | 2 +-
assets/js/{5.c4e5d699.js => 5.fbabf314.js} | 2 +-
assets/js/{6.d47b66f5.js => 6.e6a4017f.js} | 2 +-
assets/js/{7.5c99d199.js => 7.d6674481.js} | 2 +-
assets/js/{8.a6c148af.js => 8.091e0b35.js} | 2 +-
assets/js/{9.47e59f1d.js => 9.93d2adc5.js} | 2 +-
assets/js/{app.75075b89.js => app.dd0d51af.js} | 6 +-
blog/2018-05-24-skywalking-net.html| 4 +-
blog/2018-12-12-skywalking-service-mesh-ready.html | 4 +-
blog/2019-01-01-Understand-Trace.html | 4 +-
blog/2019-01-25-mesh-loadtest.html | 4 +-
blog/2019-09-25-alarm-webhook-share.html | 4 +-
blog/index.html| 4 +-
downloads/index.html | 4 +-
events/index.html | 4 +-
index.html | 4 +-
team/index.html| 4 +-
zh/blog/2018-05-24-skywalking-net.html | 4 +-
...2018-12-18-Apache-SkyWalking-5-0-UserGuide.html | 4 +-
...018-12-21-SkyWalking-apm-sniffer-beginning.html | 4 +-
.../2018-12-21-SkyWalking-source-code-read.html| 4 +-
zh/blog/2019-01-02-Understand-trace-trans2cn.html | 4 +-
.../2019-01-02-skywalking-elasticsearch-basic.html | 4 +-
zh/blog/2019-01-03-monitor-microservice.html | 4 +-
zh/blog/2019-01-21-agent-plugin-practice.html | 4 +-
zh/blog/2019-01-24-skywalking-remote-debug.html| 4 +-
zh/blog/2019-02-24-skywalking-pk-pinpoint.html | 4 +-
zh/blog/2019-03-01-skywalking-troubleshoot.html| 4 +-
...oduction-of-skywalking-and-simple-practice.html | 4 +-
.../2019-08-30-how-to-use-Skywalking-Agent.html| 4 +-
...-apache-skyWalking-committer-apply-process.html | 4 +-
zh/blog/2019-10-08-how-to-use-sw-chart.html| 4 +-
...alking-elasticsearch-storage-optimization.html} | 75
[GitHub] [skywalking] tuhao1020 commented on issue #3521: error about oap server configuration by consul
tuhao1020 commented on issue #3521: error about oap server configuration by consul URL: https://github.com/apache/skywalking/issues/3521#issuecomment-551351355 I just use the orignal yml and start a consul instance on localhost:8500, but error occurs as @kongkong56 showed above. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] aderm commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario
aderm commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#issuecomment-551347238 Ok, no problem This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario
wu-sheng commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#issuecomment-551346271 I mean this doc, https://github.com/apache/skywalking/blob/master/docs/en/setup/service-agent/java-agent/Supported-list.md should be updated in this PR too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking-website] kezhenxu94 merged pull request #66: Add zh blog for elasticsearch storage optimization
kezhenxu94 merged pull request #66: Add zh blog for elasticsearch storage optimization URL: https://github.com/apache/skywalking-website/pull/66 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[skywalking-website] branch master updated: Add zh blog for elasticsearch storage optimization (#66)
This is an automated email from the ASF dual-hosted git repository.
kezhenxu94 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-website.git
The following commit(s) were added to refs/heads/master by this push:
new 88d2960 Add zh blog for elasticsearch storage optimization (#66)
88d2960 is described below
commit 88d29609ff1a177d3471fecca0f92c27033c4e87
Author: 兵
AuthorDate: Fri Nov 8 09:47:27 2019 +0800
Add zh blog for elasticsearch storage optimization (#66)
---
...kywalking-elasticsearch-storage-optimization.md | 71 ++
docs/zh/blog/README.md | 4 ++
2 files changed, 75 insertions(+)
diff --git
a/docs/zh/blog/2019-11-07-skywalking-elasticsearch-storage-optimization.md
b/docs/zh/blog/2019-11-07-skywalking-elasticsearch-storage-optimization.md
new file mode 100644
index 000..4946300
--- /dev/null
+++ b/docs/zh/blog/2019-11-07-skywalking-elasticsearch-storage-optimization.md
@@ -0,0 +1,71 @@
+# skywalking使用elasticsearch存储的优化
+PS:本文仅仅是在我的测试环境实验过，如果有问题，请自行优化调整
+
+前记：记得skywlking还是6.0版本的时候我就在试用，当时是skywalking基本在两三天左右就会监控数据完全查不出来，elasticsearch日志报错，由于当时也算是初用es，主要用来日志收集，并且时间有限，没有继续深入研究，最近空闲，更新到最新的6.5.0(开发版本)还是会出现同样的问题，下定决心解决下，于是有了本文的浅知拙见
+
+### 本次调优环境
+skywalking: 6.5.0
+elasticsearch:6.3.2(下文用es代替)
+
+### 调优过程
+1. 当然是百度了，百度后其实翻来翻去就找到一个相关的文章https://my.oschina.net/keking/blog/3025303 ，参考之。
+2. 调整skywalking的这两个参数试试
+`bulkActions: 4000 # Execute the bulk every 2000 requests`
+ ` bulkSize: 60 # flush the bulk every 20mb`
+然后es还是继续挂，继续频繁的重启
+
+3. 继续看这个文章，发现了另外一篇https://www.easyice.cn/archives/207 ，继续参考之
+4.
这篇文章发现每一个字我都认识，看起来也能懂，但是对于es小白的我来说，着实不知道怎么调整这些参数，姑且先加到es的配置文件里边试试看吧，于是就加了，然后重启es的时候说发现index参数配置，自从5.0之后就不支持这样配置了，还给调了个es的接口去设置，但是设置失败（真够不错的），朝着这个思路去百度，百度到快放弃，后来就寻思，再试试看吧，（百度的结果是知道了index有静态参数和动态参数，动态的参数是可以随时设置，静态的只能创建或者关闭状态的索引才可以设置）
+然鹅并不知道怎么关闭索引，继续百度，（怎么全特么百度，好吧不百度了，直接来干货）
+ * 关闭索引（我的skywalking索引命名空间是dry_trace）
+ ` curl -XPOST "http://localhost:9200/dry_trace*/_close"`
+ * 设置参数
+curl -XPUT
'http://localhost:9200/dry_trace*/_settings?preserve_existing=true' -H
'Content-type:application/json' -d '{
+ "index.refresh_interval" : "10s",
+ "index.translog.durability" : "async",
+ "index.translog.flush_threshold_size" : "1024mb",
+ "index.translog.sync_interval" : "120s"
+ }'
+ *打开索引
+`curl -XPOST "http://localhost:9200/dry_trace*/_open"`
+5. 还有一点，第四步的方式只适用于现有的索引设置，那么新的索引设置呢，总不能每天重复下第四步吧。当然不需要，来干货
+首先登陆kinaba控制台找到开发工具
+贴入以下代码
+ PUT /_template/dry_trace_tmp
+{
+ "index_patterns": "dry_trace*",
+ "order": 1,
+ "settings": {
+ "index": {
+ "refresh_interval": "30s",
+ "translog": {
+ "flush_threshold_size": "1GB",
+ "sync_interval": "60s",
+ "durability": "async"
+ }
+ }
+ }
+}
+
+
+
+
+
+6. 截止目前为止运行一周，还未发现挂掉，一切看起来正常
+
+
+
+### 完结---
+于 2019年11月
+
+
+
+
+
+
+
+
+
+
+
+
diff --git a/docs/zh/blog/README.md b/docs/zh/blog/README.md
index ac1ad65..387c2cf 100644
--- a/docs/zh/blog/README.md
+++ b/docs/zh/blog/README.md
@@ -2,6 +2,10 @@
layout: LayoutBlog
blog:
+- title: skywalking使用elasticsearch存储的优化
+ name: 2019-11-07-skywalking-elasticsearch-storage-optimization
+ time: langyan1022，11月7日，2019
+ short: skywalking使用elasticsearch存储的优化
- title: 使用 chart 部署 skywalking
name: 2019-10-08-how-to-use-sw-chart
[GitHub] [skywalking] wu-sheng commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario
wu-sheng commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#discussion_r343957353 ## File path: apm-sniffer/apm-sdk-plugin/elasticsearch-6.x-plugin/pom.xml ## @@ -0,0 +1,49 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> + +apm-sdk-plugin +org.apache.skywalking +6.5.0-SNAPSHOT + +4.0.0 + +apm-elasticsearch-6.x-plugin +jar + +elasticsearch-6.x-plugin +http://maven.apache.org + + +UTF-8 +1.8 Review comment: This is not about the ES 6 requirement, this is about your plugin codes. It is OK plugin complied in 1.6, and lib required 1.8+ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] arugal commented on issue #3788: Rabbitmq plugin test migration
arugal commented on issue #3788: Rabbitmq plugin test migration URL: https://github.com/apache/skywalking/pull/3788#issuecomment-551345489 /run agent-plugin-test-1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] arugal commented on issue #3788: Rabbitmq plugin test migration
arugal commented on issue #3788: Rabbitmq plugin test migration URL: https://github.com/apache/skywalking/pull/3788#issuecomment-551345413 /run agent-plugin-test-4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] arugal removed a comment on issue #3788: Rabbitmq plugin test migration
arugal removed a comment on issue #3788: Rabbitmq plugin test migration URL: https://github.com/apache/skywalking/pull/3788#issuecomment-551345413 /run agent-plugin-test-4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking-website] langyan1022 commented on a change in pull request #66: Add zh blog for elasticsearch storage optimization
langyan1022 commented on a change in pull request #66: Add zh blog for elasticsearch storage optimization URL: https://github.com/apache/skywalking-website/pull/66#discussion_r343955620 ## File path: docs/zh/blog/README.md ## @@ -2,6 +2,10 @@ layout: LayoutBlog blog: +- title: skywalking使用elasticsearch存储的优化 + name: 2019-11-07-skywalking-elasticsearch-storage-optimization + time: innerpeacez，11月7日，2019 Review comment: ok，I have corrected these errors This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] aderm edited a comment on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario
aderm edited a comment on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#issuecomment-551343104 > supported-list doc should be updated. Regarding the supported version, the version before 6.7.0, some places are different, not compatible, and supports versions later than 6.7.1. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] aderm commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario
aderm commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#issuecomment-551343104 > supported-list doc should be updated. Regarding the supported version, the version before 6.7.0, some places are different, not compatible This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario
aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#discussion_r343954478 ## File path: apm-sniffer/apm-sdk-plugin/elasticsearch-6.x-plugin/pom.xml ## @@ -0,0 +1,49 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> + +apm-sdk-plugin +org.apache.skywalking +6.5.0-SNAPSHOT + +4.0.0 + +apm-elasticsearch-6.x-plugin +jar + +elasticsearch-6.x-plugin +http://maven.apache.org + + +UTF-8 +1.8 Review comment: Other versions have not been tried, however, ES6+ official has requested that you must follow the java8 version. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3788: Rabbitmq plugin test migration
wu-sheng commented on issue #3788: Rabbitmq plugin test migration URL: https://github.com/apache/skywalking/pull/3788#issuecomment-551339551 Please follow this, https://github.com/apache/skywalking/blob/master/docs/en/guides/Plugin-test.md#the-elapsed-time-list-of-plugins. And add your task into the fastest one when it is ready to be merged. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario
wu-sheng commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#discussion_r343951058 ## File path: apm-sniffer/apm-sdk-plugin/elasticsearch-6.x-plugin/pom.xml ## @@ -0,0 +1,49 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> + +apm-sdk-plugin +org.apache.skywalking +6.5.0-SNAPSHOT + +4.0.0 + +apm-elasticsearch-6.x-plugin +jar + +elasticsearch-6.x-plugin +http://maven.apache.org + + +UTF-8 +1.8 Review comment: Do you need 1.8 for plugin source codes? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario
aderm commented on a change in pull request #3803: Add elasticsearch 6.x plugin
& elasticsearch 6.x test scenario
URL: https://github.com/apache/skywalking/pull/3803#discussion_r343951312
##
File path: docs/en/guides/Plugin-test.md
##
@@ -602,12 +602,13 @@ stage('Run Agent Plugin Tests') {
Find the button 'detail' of your Workload in the PR page. Enter to the page
and get the elapsed time of your task.
### Workload 1
- Group 1 (2164.287s)
+ Group 1 (2635.00s)
Review comment:
ok
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3788: Rabbitmq plugin test migration
wu-sheng commented on issue #3788: Rabbitmq plugin test migration URL: https://github.com/apache/skywalking/pull/3788#issuecomment-551331107 Related to #3583 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario
wu-sheng commented on a change in pull request #3803: Add elasticsearch 6.x
plugin & elasticsearch 6.x test scenario
URL: https://github.com/apache/skywalking/pull/3803#discussion_r343942588
##
File path: docs/en/guides/Plugin-test.md
##
@@ -602,12 +602,13 @@ stage('Run Agent Plugin Tests') {
Find the button 'detail' of your Workload in the PR page. Enter to the page
and get the elapsed time of your task.
### Workload 1
- Group 1 (2164.287s)
+ Group 1 (2635.00s)
Review comment:
Choose the fastest group/workload to add your task, please.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #3788: Rabbitmq plugin test migration
wu-sheng commented on a change in pull request #3788: Rabbitmq plugin test
migration
URL: https://github.com/apache/skywalking/pull/3788#discussion_r343940312
##
File path: test/plugin/scenarios/rabbitmq-scenario/pom.xml
##
@@ -0,0 +1,131 @@
+
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+4.0.0
+
+org.apache.skywalking
+rabbitmq-scenario
+5.0.0-2018
+skywalking-rabbitmq-scenario
+
+
+UTF-8
+
+5.4.0
+${test.framework.version}
+
+2.8.1
+2.1.4.RELEASE
+
+
+
+
+com.rabbitmq
+amqp-client
+${test.framework.version}
+
+
+
+org.springframework.boot
+spring-boot-starter
+${spring-boot-version}
+
+
+spring-boot-starter-logging
+org.springframework.boot
+
+
+
+
+org.apache.logging.log4j
+log4j-api
+${log4j.version}
+
+
+org.apache.logging.log4j
+log4j-core
+${log4j.version}
+
+
+org.springframework.boot
+spring-boot-starter-web
+${spring-boot-version}
+
+
+
+
+rabbitmq-scenario
+
+
+org.springframework.boot
+spring-boot-maven-plugin
+1.5.9.RELEASE
+
+
+
+repackage
+
+
+
+
+
+org.apache.maven.plugins
+maven-compiler-plugin
+3.6.0
+
+1.8
+1.8
+${project.build.sourceEncoding}
+
+
+
+org.apache.maven.plugins
+maven-assembly-plugin
+
+
+assemble
+package
+
+single
+
+
+
+
src/main/assembly/assembly.xml
+
+
+
+
+
+
+
+
+
+
+spring-snapshots
+http://repo.spring.io/snapshot
+
+
+spring-milestones
+http://repo.spring.io/milestone
+
+
Review comment:
Please notice this, I don't think we need spring repo. Maven central should
be enough, right?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #3788: Rabbitmq plugin test migration
wu-sheng commented on a change in pull request #3788: Rabbitmq plugin test
migration
URL: https://github.com/apache/skywalking/pull/3788#discussion_r343939681
##
File path:
test/plugin/scenarios/rabbitmq-scenario/src/main/java/org/apache/skywalking/apm/testcase/rabbitmq/controller/CaseController.java
##
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.testcase.rabbitmq.controller;
+
+
+import com.rabbitmq.client.*;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+import org.springframework.beans.factory.annotation.Value;
+import org.springframework.context.annotation.PropertySource;
+import org.springframework.web.bind.annotation.RequestMapping;
+import org.springframework.web.bind.annotation.ResponseBody;
+import org.springframework.web.bind.annotation.RestController;
+
+
+import java.io.IOException;
+
+@RestController
+@RequestMapping("/case")
+@PropertySource("classpath:application.properties")
+public class CaseController {
+
+private Logger logger = LogManager.getLogger(CaseController.class);
+
+
+private static final String USERNAME = "admin";
+
+private static final String PASSWORD = "admin";
+
+@Value(value = "${rabbitmq.host:127.0.0.1}")
+private String brokerUrl;
+
+private static final int PORT = 5672;
+
+private static final String QUEUE_NAME = "test";
+
+private static final String MESSAGE = "rabbitmq-testcase";
+
+ConnectionFactory factory;
+
+Connection connection = null;
+
+
+@RequestMapping("/rabbitmq")
+@ResponseBody
+public String rabbitmqCase() {
+
+try{
+factory = new ConnectionFactory();
+logger.info("Using brokerUrl = " + brokerUrl);
+factory.setHost(brokerUrl);
+factory.setPort(PORT);
+factory.setUsername(USERNAME);
+factory.setPassword(PASSWORD);
+
+connection = factory.newConnection();
+
+Channel channel = connection.createChannel();
+channel.queueDeclare(QUEUE_NAME, false, false, false, null);
+AMQP.BasicProperties.Builder propsBuilder = new
AMQP.BasicProperties.Builder();
+logger.info("Message being published -->"+MESSAGE);
+channel.basicPublish("", QUEUE_NAME, propsBuilder.build(),
MESSAGE.getBytes("UTF-8"));
+logger.info("Message has been published-->"+MESSAGE);
+
+DeliverCallback deliverCallback = (consumerTag, delivery) -> {
+String message = new String(delivery.getBody(), "UTF-8");
+logger.info("Message received-->"+message);
+};
+channel.basicConsume(QUEUE_NAME, true, deliverCallback,
consumerTag -> { });
+Thread.sleep(5000);
+logger.info("Message Consumed-->");
+channel.close();
+connection.close();
+
+}catch (Exception ex){
+logger.error(ex.toString());
+}
+return "Success";
+}
+
+@RequestMapping("/healthcheck")
+public String healthCheck() throws Exception {
+
+try{
+factory = new ConnectionFactory();
+logger.info("Using brokerUrl = " + brokerUrl);
+factory.setHost(brokerUrl);
+factory.setPort(PORT);
+factory.setUsername(USERNAME);
+factory.setPassword(PASSWORD);
+
+connection = factory.newConnection();
+
+Channel channel = connection.createChannel();
+channel.queueDeclare(QUEUE_NAME, false, false, false, null);
+logger.info("Completed Health Check. Able to connect to RabbitMQ
and create queue-->");
+channel.close();
+connection.close();
Review comment:
Close should be in finally, to avoid memory leak, even for tests.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact
[GitHub] [skywalking] wu-sheng commented on a change in pull request #3788: Rabbitmq plugin test migration
wu-sheng commented on a change in pull request #3788: Rabbitmq plugin test
migration
URL: https://github.com/apache/skywalking/pull/3788#discussion_r343939631
##
File path:
test/plugin/scenarios/rabbitmq-scenario/src/main/java/org/apache/skywalking/apm/testcase/rabbitmq/controller/CaseController.java
##
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.testcase.rabbitmq.controller;
+
+
+import com.rabbitmq.client.*;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+import org.springframework.beans.factory.annotation.Value;
+import org.springframework.context.annotation.PropertySource;
+import org.springframework.web.bind.annotation.RequestMapping;
+import org.springframework.web.bind.annotation.ResponseBody;
+import org.springframework.web.bind.annotation.RestController;
+
+
+import java.io.IOException;
+
+@RestController
+@RequestMapping("/case")
+@PropertySource("classpath:application.properties")
+public class CaseController {
+
+private Logger logger = LogManager.getLogger(CaseController.class);
+
+
+private static final String USERNAME = "admin";
+
+private static final String PASSWORD = "admin";
+
+@Value(value = "${rabbitmq.host:127.0.0.1}")
+private String brokerUrl;
+
+private static final int PORT = 5672;
+
+private static final String QUEUE_NAME = "test";
+
+private static final String MESSAGE = "rabbitmq-testcase";
+
+ConnectionFactory factory;
+
+Connection connection = null;
+
+
+@RequestMapping("/rabbitmq")
+@ResponseBody
+public String rabbitmqCase() {
+
+try{
+factory = new ConnectionFactory();
+logger.info("Using brokerUrl = " + brokerUrl);
+factory.setHost(brokerUrl);
+factory.setPort(PORT);
+factory.setUsername(USERNAME);
+factory.setPassword(PASSWORD);
+
+connection = factory.newConnection();
+
+Channel channel = connection.createChannel();
+channel.queueDeclare(QUEUE_NAME, false, false, false, null);
+AMQP.BasicProperties.Builder propsBuilder = new
AMQP.BasicProperties.Builder();
+logger.info("Message being published -->"+MESSAGE);
+channel.basicPublish("", QUEUE_NAME, propsBuilder.build(),
MESSAGE.getBytes("UTF-8"));
+logger.info("Message has been published-->"+MESSAGE);
+
+DeliverCallback deliverCallback = (consumerTag, delivery) -> {
+String message = new String(delivery.getBody(), "UTF-8");
+logger.info("Message received-->"+message);
+};
+channel.basicConsume(QUEUE_NAME, true, deliverCallback,
consumerTag -> { });
+Thread.sleep(5000);
+logger.info("Message Consumed-->");
+channel.close();
+connection.close();
+
Review comment:
Close should be in finally, to avoid memory leak, even for tests.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng merged pull request #3804: update plugin test doc.
wu-sheng merged pull request #3804: update plugin test doc. URL: https://github.com/apache/skywalking/pull/3804 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[skywalking] branch master updated: update plugin test doc. (#3804)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 998ce29 update plugin test doc. (#3804) 998ce29 is described below commit 998ce2963219521e75c653affbdb1d0e0322f0a0 Author: aderm <394102...@qq.com> AuthorDate: Fri Nov 8 08:16:52 2019 +0800 update plugin test doc. (#3804) --- docs/en/guides/Plugin-test.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/en/guides/Plugin-test.md b/docs/en/guides/Plugin-test.md index 75a7b81..412ba9a 100644 --- a/docs/en/guides/Plugin-test.md +++ b/docs/en/guides/Plugin-test.md @@ -21,7 +21,7 @@ The test framework provides `JVM-container` and `Tomcat-container` base images. ### JVM-container Image Introduction [JVM-container](../../../test/plugin/containers/jvm-container) uses `openjdk:8` as the basic image. -The test case project is required to be packaged as `project-name.zip`, including `startup.sh` and uber jar, by using `mvn package`. +The test case project is required to be packaged as `project-name.zip`, including `startup.sh` and uber jar, by using `mvn clean package`. Take the following test projects as good examples * [sofarpc-scenario](../../../test/plugin/scenarios/sofarpc-scenario) as a single project case. @@ -30,7 +30,7 @@ Take the following test projects as good examples ### Tomcat-container Image Introduction [Tomcat-container](../../../test/plugin/containers/tomcat-container) uses `tomcat:8.5.42-jdk8-openjdk` as the basic image. -The test case project is required to ba packaged as `project-name.war` by using `mvn package`. +The test case project is required to be packaged as `project-name.war` by using `mvn package`. Take the following test project as a good example * [spring-4.3.x-scenario](https://github.com/apache/skywalking/tree/master/test/plugin/scenarios/spring-4.3.x-scenario)
[GitHub] [skywalking] viswaramamoorthy commented on issue #3788: Rabbitmq plugin test migration
viswaramamoorthy commented on issue #3788: Rabbitmq plugin test migration URL: https://github.com/apache/skywalking/pull/3788#issuecomment-551240065 Few fixes added and all RabbitMQ tests are running successfully in local env This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] dmsolr commented on a change in pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario
dmsolr commented on a change in pull request #3803: Add elasticsearch 6.x
plugin & elasticsearch 6.x test scenario
URL: https://github.com/apache/skywalking/pull/3803#discussion_r343783541
##
File path: docs/en/guides/Plugin-test.md
##
@@ -602,12 +602,13 @@ stage('Run Agent Plugin Tests') {
Find the button 'detail' of your Workload in the PR page. Enter to the page
and get the elapsed time of your task.
### Workload 1
- Group 1 (2164.287s)
+ Group 1 (2635.00s)
Review comment:
placed in workload4-group1 is better
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] dmsolr commented on issue #3802: [WIP] provide archetypes for plugin testcase
dmsolr commented on issue #3802: [WIP] provide archetypes for plugin testcase URL: https://github.com/apache/skywalking/pull/3802#issuecomment-551181998 I will supplement usage into the document. we can get the usage by `./test/plugin/archetypes/generator.sh -h`. so developers can try it if you are interested in it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] aderm commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario
aderm commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#issuecomment-551144322 /run agent-plugin-test-4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] aderm opened a new pull request #3804: update plugin test doc.
aderm opened a new pull request #3804: update plugin test doc. URL: https://github.com/apache/skywalking/pull/3804 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ] Improve performance - Related issues ___ ### Bug fix - Bug description. - How to fix? ___ ### New feature or improvement - Describe the details and related test reports. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking-cli] wu-sheng commented on issue #6: [Feature] Set GraphQL client and add service ls command
wu-sheng commented on issue #6: [Feature] Set GraphQL client and add service ls command URL: https://github.com/apache/skywalking-cli/pull/6#issuecomment-551137892 Also, unit tests, test coverage, and comment should be added. For e2e, we could add later, that is not a high priority work. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] dmsolr commented on issue #3788: Rabbitmq plugin test migration
dmsolr commented on issue #3788: Rabbitmq plugin test migration URL: https://github.com/apache/skywalking/pull/3788#issuecomment-551135794 Hi, @viswaramamoorthy I updated the default value of BUILD_ID without usage. I have merged the master into your pr. Now, you need to pull the latest code. and retry it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking-cli] wu-sheng commented on a change in pull request #6: [Feature] Set GraphQL client and add service ls command
wu-sheng commented on a change in pull request #6: [Feature] Set GraphQL client
and add service ls command
URL: https://github.com/apache/skywalking-cli/pull/6#discussion_r343719190
##
File path: commands/interceptor.go
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package commands
+
+import (
+ "github.com/apache/skywalking-cli/graphql/schema"
+ "github.com/apache/skywalking-cli/logger"
+ "github.com/urfave/cli"
+ "time"
+)
+
+// Convenient function to chain up multiple cli.BeforeFunc
+func BeforeChain(beforeFunctions []cli.BeforeFunc) cli.BeforeFunc {
+ return func(ctx *cli.Context) error {
+ for _, beforeFunc := range beforeFunctions {
+ if err := beforeFunc(ctx); err != nil {
+ return err
+ }
+ }
+ return nil
+ }
+}
+
+var StepFormats = map[schema.Step]string{
+ schema.StepMonth: "2006-01-02",
+ schema.StepDay:"2006-01-02",
+ schema.StepHour: "2006-01-02 15",
+ schema.StepMinute: "2006-01-02 1504",
+ schema.StepSecond: "2006-01-02 1504",
+}
+
+// Set the duration if not set, and format it according to
+// the given step
+func SetUpDuration(ctx *cli.Context) error {
+ step := ctx.Generic("step").(*StepEnumValue).Selected
+ end := ctx.String("end")
+ if len(end) == 0 {
+ end = time.Now().Format(StepFormats[step])
+ logger.Log.Debugln("Missing --end, defaults to", end)
+ if err := ctx.Set("end", end); err != nil {
+ return err
+ }
+ }
+
+ start := ctx.String("start")
+ if len(start) == 0 {
+ start = time.Now().Add(-15 *
time.Minute).Format(StepFormats[step])
Review comment:
I think should be -15 units in the current step, rather than only 15 mins.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] wu-sheng commented on a change in pull request #6: [Feature] Set GraphQL client and add service ls command
wu-sheng commented on a change in pull request #6: [Feature] Set GraphQL client
and add service ls command
URL: https://github.com/apache/skywalking-cli/pull/6#discussion_r343720517
##
File path: swctl/main.go
##
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package main
+
+import (
+ "encoding/json"
+ "github.com/apache/skywalking-cli/commands/service"
+ "github.com/apache/skywalking-cli/config"
+ "github.com/sirupsen/logrus"
+ "github.com/urfave/cli"
+ "gopkg.in/yaml.v2"
+ "io/ioutil"
+ "os"
+
+ "github.com/apache/skywalking-cli/logger"
+)
+
+var log *logrus.Logger
+
+func init() {
+ log = logger.Log
+}
+
+func main() {
+ app := cli.NewApp()
+ app.Usage = "The CLI (Command Line Interface) for Apache SkyWalking."
+ app.Flags = []cli.Flag{
+ cli.StringFlag{
+ Name: "config",
+ Value: "./settings.yml",
Review comment:
As following design doc, this should be `~/.skywalking.ym` config file.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] wu-sheng commented on a change in pull request #6: [Feature] Set GraphQL client and add service ls command
wu-sheng commented on a change in pull request #6: [Feature] Set GraphQL client
and add service ls command
URL: https://github.com/apache/skywalking-cli/pull/6#discussion_r343721588
##
File path: graphql/client/client.go
##
@@ -16,27 +16,36 @@
*
*/
-package main
+package client
import (
- "github.com/apache/skywalking-cli/swctl/service"
- "github.com/urfave/cli"
+ "context"
+ "github.com/apache/skywalking-cli/config"
+ "github.com/apache/skywalking-cli/graphql/schema"
+ "github.com/apache/skywalking-cli/logger"
+ "github.com/machinebox/graphql"
)
-var serviceCmd = cli.Command{
- Name: "service",
- Flags: []cli.Flag{
- cli.BoolFlag{
- Name: "list",
- Usage: "list all available services.",
- },
- },
- Action: func(c *cli.Context) {
- ctl := service.NewService(c)
+func Services(duration schema.Duration) []schema.Service {
+ ctx := context.Background()
+ client := graphql.NewClient(config.Config.Global.BaseUrl)
+ client.Log = func(msg string) {
+ logger.Log.Debugln(msg)
+ }
- err := ctl.Exec()
- if err != nil {
- log.Fatal(err)
+ var response map[string][]schema.Service
+ request := graphql.NewRequest(`
+ query ($duration: Duration!) {
+ services: getAllServices(duration: $duration) {
+ id name
+ }
}
- },
+ `)
+ request.Var("duration", duration)
+ if err := client.Run(ctx, request, ); err != nil {
+ logger.Log.Fatalln(err)
+ panic(err)
+ }
+
+ return response["services"]
Review comment:
This looks like a really good GraphQL lib, better than Java's :)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] wu-sheng commented on a change in pull request #6: [Feature] Set GraphQL client and add service ls command
wu-sheng commented on a change in pull request #6: [Feature] Set GraphQL client
and add service ls command
URL: https://github.com/apache/skywalking-cli/pull/6#discussion_r343717713
##
File path: commands/interceptor.go
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package commands
+
+import (
+ "github.com/apache/skywalking-cli/graphql/schema"
+ "github.com/apache/skywalking-cli/logger"
+ "github.com/urfave/cli"
+ "time"
+)
+
+// Convenient function to chain up multiple cli.BeforeFunc
+func BeforeChain(beforeFunctions []cli.BeforeFunc) cli.BeforeFunc {
+ return func(ctx *cli.Context) error {
+ for _, beforeFunc := range beforeFunctions {
+ if err := beforeFunc(ctx); err != nil {
+ return err
+ }
+ }
+ return nil
+ }
+}
+
+var StepFormats = map[schema.Step]string{
+ schema.StepMonth: "2006-01-02",
+ schema.StepDay:"2006-01-02",
+ schema.StepHour: "2006-01-02 15",
+ schema.StepMinute: "2006-01-02 1504",
+ schema.StepSecond: "2006-01-02 1504",
+}
+
+// Set the duration if not set, and format it according to
+// the given step
+func SetUpDuration(ctx *cli.Context) error {
+ step := ctx.Generic("step").(*StepEnumValue).Selected
Review comment:
Do we really need `step`? I think we could detect `step` from time format.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] wu-sheng commented on a change in pull request #6: [Feature] Set GraphQL client and add service ls command
wu-sheng commented on a change in pull request #6: [Feature] Set GraphQL client
and add service ls command
URL: https://github.com/apache/skywalking-cli/pull/6#discussion_r343718904
##
File path: commands/interceptor.go
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package commands
+
+import (
+ "github.com/apache/skywalking-cli/graphql/schema"
+ "github.com/apache/skywalking-cli/logger"
+ "github.com/urfave/cli"
+ "time"
+)
+
+// Convenient function to chain up multiple cli.BeforeFunc
+func BeforeChain(beforeFunctions []cli.BeforeFunc) cli.BeforeFunc {
+ return func(ctx *cli.Context) error {
+ for _, beforeFunc := range beforeFunctions {
+ if err := beforeFunc(ctx); err != nil {
+ return err
+ }
+ }
+ return nil
+ }
+}
+
+var StepFormats = map[schema.Step]string{
+ schema.StepMonth: "2006-01-02",
+ schema.StepDay:"2006-01-02",
+ schema.StepHour: "2006-01-02 15",
+ schema.StepMinute: "2006-01-02 1504",
+ schema.StepSecond: "2006-01-02 1504",
+}
+
+// Set the duration if not set, and format it according to
+// the given step
+func SetUpDuration(ctx *cli.Context) error {
+ step := ctx.Generic("step").(*StepEnumValue).Selected
+ end := ctx.String("end")
+ if len(end) == 0 {
+ end = time.Now().Format(StepFormats[step])
Review comment:
We could still use this format, but a little more complex. Using start time
format to set default end time.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] arugal commented on issue #3788: Rabbitmq plugin test migration
arugal commented on issue #3788: Rabbitmq plugin test migration URL: https://github.com/apache/skywalking/pull/3788#issuecomment-551134171 ha, use ```bash test/plugin/run.sh -f rabbitmq-scenario``` set the ```BUILD_ID```, maybe you need to pull the latest code? https://github.com/apache/skywalking/blob/62060749f7bea3cd97716a5ba0cec6103f46d02c/test/plugin/run.sh#L148 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] viswaramamoorthy commented on issue #3788: Rabbitmq plugin test migration
viswaramamoorthy commented on issue #3788: Rabbitmq plugin test migration
URL: https://github.com/apache/skywalking/pull/3788#issuecomment-551128788
@arugal That is the issue. run,sh is an issue. build_id has to be defaulted
to latest so the built docker image can be run. It is defaulted to "local"
because of this, docker compose generated looks for "
skywalking/agent-test-jvm:local" that never exists and hence container not
starting
I have shown the problem in bold below. check
build_id="**local**"
..
print_help() {
echo "Usage: run.sh [OPTION] SCENARIO_NAME"
echo -e "\t-f, --force_build \t\t do force to build Plugin-Test tools
and images"
echo -e "\t--build_id, \t\t\t specify Plugin_Test's image tag. Defalt:
**latest**"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-website] kezhenxu94 commented on a change in pull request #66: Add zh blog for elasticsearch storage optimization
kezhenxu94 commented on a change in pull request #66: Add zh blog for elasticsearch storage optimization URL: https://github.com/apache/skywalking-website/pull/66#discussion_r343711738 ## File path: docs/zh/blog/2019-11-07-skywalking-elasticsearch-storage-optimization.md ## @@ -0,0 +1,49 @@ +# skywalking使用elasticsearch存储的优化 +PS:本文仅仅是在我的测试环境实验过，如果有问题，请自行优化调整 + +前记：记得skywlking还是6.0版本的时候我就在试用，当时是skywalking基本在两三天左右就会监控数据完全查不出来，elasticsearch日志报错，由于当时也算是初用es，主要用来日志收集，并且时间有限，没有继续深入研究，最近空闲，更新到最新的6.5.0(开发版本)还是会出现同样的问题，下定决心解决下，于是有了本文的浅知拙见 + +###本次调优环境 Review comment: ```suggestion ### 本次调优环境 ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking-website] kezhenxu94 commented on a change in pull request #66: Add zh blog for elasticsearch storage optimization
kezhenxu94 commented on a change in pull request #66: Add zh blog for elasticsearch storage optimization URL: https://github.com/apache/skywalking-website/pull/66#discussion_r343712368 ## File path: docs/zh/blog/2019-11-07-skywalking-elasticsearch-storage-optimization.md ## @@ -0,0 +1,49 @@ +# skywalking使用elasticsearch存储的优化 +PS:本文仅仅是在我的测试环境实验过，如果有问题，请自行优化调整 + +前记：记得skywlking还是6.0版本的时候我就在试用，当时是skywalking基本在两三天左右就会监控数据完全查不出来，elasticsearch日志报错，由于当时也算是初用es，主要用来日志收集，并且时间有限，没有继续深入研究，最近空闲，更新到最新的6.5.0(开发版本)还是会出现同样的问题，下定决心解决下，于是有了本文的浅知拙见 + +###本次调优环境 +skywalking: 6.5.0 +elasticsearch:6.3.2(下文用es代替) + +###调优过程 +1. 当然是百度了，百度后其实翻来翻去就找到一个相关的文章https://my.oschina.net/keking/blog/3025303，参考之。 Review comment: ```suggestion 1. 当然是百度了，百度后其实翻来翻去就找到一个相关的文章https://my.oschina.net/keking/blog/3025303 ，参考之。 ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking-website] kezhenxu94 commented on a change in pull request #66: Add zh blog for elasticsearch storage optimization
kezhenxu94 commented on a change in pull request #66: Add zh blog for elasticsearch storage optimization URL: https://github.com/apache/skywalking-website/pull/66#discussion_r343711878 ## File path: docs/zh/blog/2019-11-07-skywalking-elasticsearch-storage-optimization.md ## @@ -0,0 +1,49 @@ +# skywalking使用elasticsearch存储的优化 +PS:本文仅仅是在我的测试环境实验过，如果有问题，请自行优化调整 + +前记：记得skywlking还是6.0版本的时候我就在试用，当时是skywalking基本在两三天左右就会监控数据完全查不出来，elasticsearch日志报错，由于当时也算是初用es，主要用来日志收集，并且时间有限，没有继续深入研究，最近空闲，更新到最新的6.5.0(开发版本)还是会出现同样的问题，下定决心解决下，于是有了本文的浅知拙见 + +###本次调优环境 +skywalking: 6.5.0 +elasticsearch:6.3.2(下文用es代替) + +###调优过程 Review comment: ```suggestion ### 调优过程 ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking-website] kezhenxu94 commented on a change in pull request #66: Add zh blog for elasticsearch storage optimization
kezhenxu94 commented on a change in pull request #66: Add zh blog for elasticsearch storage optimization URL: https://github.com/apache/skywalking-website/pull/66#discussion_r343713027 ## File path: docs/zh/blog/README.md ## @@ -2,6 +2,10 @@ layout: LayoutBlog blog: +- title: skywalking使用elasticsearch存储的优化 + name: 2019-11-07-skywalking-elasticsearch-storage-optimization + time: innerpeacez，11月7日，2019 Review comment: ```suggestion time: langyan1022，11月7日，2019 ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking-website] kezhenxu94 commented on a change in pull request #66: Add zh blog for elasticsearch storage optimization
kezhenxu94 commented on a change in pull request #66: Add zh blog for elasticsearch storage optimization URL: https://github.com/apache/skywalking-website/pull/66#discussion_r343712485 ## File path: docs/zh/blog/2019-11-07-skywalking-elasticsearch-storage-optimization.md ## @@ -0,0 +1,49 @@ +# skywalking使用elasticsearch存储的优化 +PS:本文仅仅是在我的测试环境实验过，如果有问题，请自行优化调整 + +前记：记得skywlking还是6.0版本的时候我就在试用，当时是skywalking基本在两三天左右就会监控数据完全查不出来，elasticsearch日志报错，由于当时也算是初用es，主要用来日志收集，并且时间有限，没有继续深入研究，最近空闲，更新到最新的6.5.0(开发版本)还是会出现同样的问题，下定决心解决下，于是有了本文的浅知拙见 + +###本次调优环境 +skywalking: 6.5.0 +elasticsearch:6.3.2(下文用es代替) + +###调优过程 +1. 当然是百度了，百度后其实翻来翻去就找到一个相关的文章https://my.oschina.net/keking/blog/3025303，参考之。 +2. 调整skywalking的这两个参数试试 +`bulkActions: 4000 # Execute the bulk every 2000 requests` + ` bulkSize: 60 # flush the bulk every 20mb` +然后es还是继续挂，继续频繁的重启 + +3. 继续看这个文章，发现了另外一篇https://www.easyice.cn/archives/207，继续参考之 Review comment: ```suggestion 3. 继续看这个文章，发现了另外一篇https://www.easyice.cn/archives/207 ，继续参考之 ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] arugal edited a comment on issue #3788: Rabbitmq plugin test migration
arugal edited a comment on issue #3788: Rabbitmq plugin test migration URL: https://github.com/apache/skywalking/pull/3788#issuecomment-55758 > Local error is not due to health check, it is complaining about missing or docker image permission. see below. > Run locally use ```bash test/plugin/run.sh -f rabbitmq-scenario``` > Anyway, I have added healthcheck and made changes to log messages. check Good, let's wait for the test result. Todo list: 1. merge the master branch code 2. modify ```Jenkinsfile-Agent-Test#Test Cases Report``` 3. update [The elapsed time list of plugins](https://github.com/apache/skywalking/blob/master/docs/en/guides/Plugin-test.md#the-elapsed-time-list-of-plugins) according to test results 4. ... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] arugal edited a comment on issue #3788: Rabbitmq plugin test migration
arugal edited a comment on issue #3788: Rabbitmq plugin test migration URL: https://github.com/apache/skywalking/pull/3788#issuecomment-55758 > Local error is not due to health check, it is complaining about missing or docker image permission. see below. > Run locally use ```bash test/plugin/run.sh -f rabbitmq-scenario``` > Anyway, I have added healthcheck and made changes to log messages. check Good, let's wait for the test result. Todo list: 1. merge the master code 2. modify ```Jenkinsfile-Agent-Test#Test Cases Report``` 3. update [The elapsed time list of plugins](https://github.com/apache/skywalking/blob/master/docs/en/guides/Plugin-test.md#the-elapsed-time-list-of-plugins) according to test results 4. ... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] arugal commented on issue #3788: Rabbitmq plugin test migration
arugal commented on issue #3788: Rabbitmq plugin test migration URL: https://github.com/apache/skywalking/pull/3788#issuecomment-55758 > Local error is not due to health check, it is complaining about missing or docker image permission. see below. > Run locally use ```bash test/plugin/run.sh -f rabbitmq-scenario``` > Anyway, I have added healthcheck and made changes to log messages. check Good, let's wait for the test result. Todo list: 1. merge the latest main branch code 2. modify ```Jenkinsfile-Agent-Test#Test Cases Report``` 3. update [The elapsed time list of plugins](https://github.com/apache/skywalking/blob/master/docs/en/guides/Plugin-test.md#the-elapsed-time-list-of-plugins) according to test results 4. ... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] viswaramamoorthy commented on issue #3788: Rabbitmq plugin test migration
viswaramamoorthy commented on issue #3788: Rabbitmq plugin test migration URL: https://github.com/apache/skywalking/pull/3788#issuecomment-551104362 Local error is not due to health check, it is complaining about missing or docker image permission. see below. Pulling rabbitmq-scenario-5.5.1-local (skywalking/agent-test-jvm:local)... ERROR: The image for the service you're trying to recreate has been removed. If you continue, volume data could be lost. Consider backing up your data before continuing. Anyway, I have added healthcheck and made changes to log messages. check This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking-cli] wu-sheng commented on issue #6: [Feature] Set GraphQL client and add service ls command
wu-sheng commented on issue #6: [Feature] Set GraphQL client and add service ls command URL: https://github.com/apache/skywalking-cli/pull/6#issuecomment-551096824 > CLI is usually chained with pipe, like swctl service ls | jq, presenting the data in a table maybe another option, but that's another story Agree. Table form should be a specific parameter. Such as `--list-t` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] arugal edited a comment on issue #3788: Rabbitmq plugin test migration
arugal edited a comment on issue #3788: Rabbitmq plugin test migration URL: https://github.com/apache/skywalking/pull/3788#issuecomment-551091070 > I ran rabbitmq-scenario locally using run.sh. I saw few basic errors. > > is run.sh expected work locally for e.g. my laptop? I have docker installed. Hello, has ```healthcheck-url``` been added? this is the log for [workload1-group1](https://builds.apache.org/blue/organizations/jenkins/skywalking-agent-test/detail/skywalking-agent-test/1056/pipeline/166) because the failed due to a lack of ```healthcheck-url```. ``` [2019-11-07T01:30:10.520Z] [ERROR] rabbitmq-scenario-5.5.1 url=http://localhost:8080/rabbitmq-case/case/healthcheck, status=HTTP/1.1 404 health check failed! ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] arugal commented on issue #3788: Rabbitmq plugin test migration
arugal commented on issue #3788: Rabbitmq plugin test migration URL: https://github.com/apache/skywalking/pull/3788#issuecomment-551091070 > I ran rabbitmq-scenario locally using run.sh. I saw few basic errors. > > is run.sh expected work locally for e.g. my laptop? I have docker installed. Hello, has ```healthcheck-url``` been added? This is the log for [workload1-group1](https://builds.apache.org/blue/organizations/jenkins/skywalking-agent-test/detail/skywalking-agent-test/1056/pipeline/166) because the failed due to a lack of ```healthcheck-url```. ``` [2019-11-07T01:30:10.520Z] [ERROR] rabbitmq-scenario-5.5.1 url=http://localhost:8080/rabbitmq-case/case/healthcheck, status=HTTP/1.1 404 health check failed! ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] viswaramamoorthy commented on issue #3788: Rabbitmq plugin test migration
viswaramamoorthy commented on issue #3788: Rabbitmq plugin test migration URL: https://github.com/apache/skywalking/pull/3788#issuecomment-551088082 I ran rabbitmq-scenario locally using run.sh. I saw few basic errors. is run.sh expected work locally for e.g. my laptop? I have docker installed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking-cli] kezhenxu94 edited a comment on issue #6: [Feature] Set GraphQL client and add service ls command
kezhenxu94 edited a comment on issue #6: [Feature] Set GraphQL client and add
service ls command
URL: https://github.com/apache/skywalking-cli/pull/6#issuecomment-551044006
work like this
```shell
skywalking-cli $ ./bin/swctl --config=/Users/kezhenxu/settings.yml service
ls
[{"id":"4","name":"projectA"},{"id":"2","name":"projectB"},{"id":"5","name":"projectD"},{"id":"3","name":"projectC"}]
skywalking-cli $ ./bin/swctl --config=/Users/kezhenxu/settings.yml --debug
service ls
DEBU[2019-11-07 19:38:43] Debug mode is enabled
DEBU[2019-11-07 19:38:43] Using configuration file:
/Users/kezhenxu/settings.yml
DEBU[2019-11-07 19:38:43] Configurations:
{"Global":{"BaseUrl":"http://122.112.182.72:8080/graphql"}}
DEBU[2019-11-07 19:38:43] Missing --end, defaults to 2019-11-07 1938
DEBU[2019-11-07 19:38:43] Missing --start, defaults to 2019-11-07 1923
DEBU[2019-11-07 19:38:43] >> variables: map[duration:{2019-11-07 1923
2019-11-07 1938 MINUTE}]
DEBU[2019-11-07 19:38:43] >> query:
query ($duration: Duration!) {
services: getAllServices(duration: $duration) {
id name
}
}
DEBU[2019-11-07 19:38:43] >> headers: map[Accept:[application/json;
charset=utf-8] Content-Type:[application/json; charset=utf-8]]
DEBU[2019-11-07 19:38:43] <<
{"data":{"services":[{"id":"2","name":"projectB"},{"id":"4","name":"projectA"},{"id":"5","name":"projectD"},{"id":"3","name":"projectC"}]}}
[{"id":"2","name":"projectB"},{"id":"4","name":"projectA"},{"id":"5","name":"projectD"},{"id":"3","name":"projectC"}]
skywalking-cli $ ./bin/swctl --config=/Users/kezhenxu/settings.yml --debug
service ls --start=2019-10-01 --step=MONTH
DEBU[2019-11-07 19:39:06] Debug mode is enabled
DEBU[2019-11-07 19:39:06] Using configuration file:
/Users/kezhenxu/settings.yml
DEBU[2019-11-07 19:39:06] Configurations:
{"Global":{"BaseUrl":"http://122.112.182.72:8080/graphql"}}
DEBU[2019-11-07 19:39:06] Missing --end, defaults to 2019-11-07
DEBU[2019-11-07 19:39:06] >> variables: map[duration:{2019-10-01 2019-11-07
MONTH}]
DEBU[2019-11-07 19:39:06] >> query:
query ($duration: Duration!) {
services: getAllServices(duration: $duration) {
id name
}
}
DEBU[2019-11-07 19:39:06] >> headers: map[Accept:[application/json;
charset=utf-8] Content-Type:[application/json; charset=utf-8]]
DEBU[2019-11-07 19:39:06] <<
{"data":{"services":[{"id":"4","name":"projectA"},{"id":"2","name":"projectB"},{"id":"5","name":"projectD"},{"id":"3","name":"projectC"}]}}
[{"id":"4","name":"projectA"},{"id":"2","name":"projectB"},{"id":"5","name":"projectD"},{"id":"3","name":"projectC"}]
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] kezhenxu94 commented on issue #6: [Feature] Set GraphQL client and add service ls command
kezhenxu94 commented on issue #6: [Feature] Set GraphQL client and add service ls command URL: https://github.com/apache/skywalking-cli/pull/6#issuecomment-551082650 > Hi, maybe it would be better to present the data in tables？ > >  CLI is usually chained with pipe, like `swctl service ls | jq`, presenting the data in a table maybe another option, but that's another story This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking-cli] arugal commented on issue #6: [Feature] Set GraphQL client and add service ls command
arugal commented on issue #6: [Feature] Set GraphQL client and add service ls command URL: https://github.com/apache/skywalking-cli/pull/6#issuecomment-551076830 Hi, maybe it would be better to present the data in tables？  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] aderm commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario
aderm commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#issuecomment-551046766 When the external is exit span, the local span problem created and it has been fixed in the second commit. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking-cli] kezhenxu94 commented on issue #6: [Feature] Set GraphQL client and add service ls command
kezhenxu94 commented on issue #6: [Feature] Set GraphQL client and add service
ls command
URL: https://github.com/apache/skywalking-cli/pull/6#issuecomment-551044006
work like this
```shell
skywalking-cli $ ./bin/swctl --config=/Users/kezhenxu/settings.yml service
ls
[{"id":"4","name":"projectA"},{"id":"2","name":"projectB"},{"id":"5","name":"projectD"},{"id":"3","name":"projectC"}]
skywalking-cli $ ./bin/swctl --config=/Users/kezhenxu/settings.yml --debug
service ls
DEBU[2019-11-07 19:38:43] Debug mode is enabled
DEBU[2019-11-07 19:38:43] Using configuration file:
/Users/kezhenxu/settings.yml
DEBU[2019-11-07 19:38:43] Configurations:
{"Global":{"BaseUrl":"http://122.112.182.72:8080/graphql"}}
DEBU[2019-11-07 19:38:43] Missing --end, defaults to 2019-11-07 1938
DEBU[2019-11-07 19:38:43] Missing --start, defaults to 2019-11-07 1923
DEBU[2019-11-07 19:38:43] >> variables: map[duration:{2019-11-07 1923
2019-11-07 1938 MINUTE}]
DEBU[2019-11-07 19:38:43] >> query:
query ($duration: Duration!) {
services: getAllServices(duration: $duration) {
id name
}
}
DEBU[2019-11-07 19:38:43] >> headers: map[Accept:[application/json;
charset=utf-8] Content-Type:[application/json; charset=utf-8]]
DEBU[2019-11-07 19:38:43] <<
{"data":{"services":[{"id":"2","name":"projectB"},{"id":"4","name":"projectA"},{"id":"5","name":"projectD"},{"id":"3","name":"projectC"}]}}
[{"id":"2","name":"projectB"},{"id":"4","name":"projectA"},{"id":"5","name":"projectD"},{"id":"3","name":"projectC"}]
skywalking-cli $ ./bin/swctl --config=/Users/kezhenxu/settings.yml --debug
service ls --start=2019-10-01 --step=MONTH
DEBU[2019-11-07 19:39:06] Debug mode is enabled
DEBU[2019-11-07 19:39:06] Using configuration file:
/Users/kezhenxu/settings.yml
DEBU[2019-11-07 19:39:06] Configurations:
{"Global":{"BaseUrl":"http://122.112.182.72:8080/graphql"}}
DEBU[2019-11-07 19:39:06] Missing --end, defaults to 2019-11-07
DEBU[2019-11-07 19:39:06] >> variables: map[duration:{2019-10-01 2019-11-07
MONTH}]
DEBU[2019-11-07 19:39:06] >> query:
query ($duration: Duration!) {
services: getAllServices(duration: $duration) {
id name
}
}
DEBU[2019-11-07 19:39:06] >> headers: map[Accept:[application/json;
charset=utf-8] Content-Type:[application/json; charset=utf-8]]
DEBU[2019-11-07 19:39:06] <<
{"data":{"services":[{"id":"4","name":"projectA"},{"id":"2","name":"projectB"},{"id":"5","name":"projectD"},{"id":"3","name":"projectC"}]}}
[{"id":"4","name":"projectA"},{"id":"2","name":"projectB"},{"id":"5","name":"projectD"},{"id":"3","name":"projectC"}]
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] aderm closed pull request #3769: httpasyncclient plugin adpter for ES. if out is exit span, do not propagating context
aderm closed pull request #3769: httpasyncclient plugin adpter for ES. if out is exit span, do not propagating context URL: https://github.com/apache/skywalking/pull/3769 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] aderm commented on issue #3769: httpasyncclient plugin adpter for ES. if out is exit span, do not propagating context
aderm commented on issue #3769: httpasyncclient plugin adpter for ES. if out is exit span, do not propagating context URL: https://github.com/apache/skywalking/pull/3769#issuecomment-551041332 Httpasyncclient plugin When the external is exit span, there is no need to perform snapshot delivery. This problem has been solved. Reference #3803 , so this PR closed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking-cli] kezhenxu94 commented on issue #6: [Feature] Set GraphQL client and add service ls command
kezhenxu94 commented on issue #6: [Feature] Set GraphQL client and add service ls command URL: https://github.com/apache/skywalking-cli/pull/6#issuecomment-551035397 @heyanlong I did some refactoring, please review, thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking-cli] kezhenxu94 opened a new pull request #6: [Feature] Set GraphQL client and add service ls command
kezhenxu94 opened a new pull request #6: [Feature] Set GraphQL client and add service ls command URL: https://github.com/apache/skywalking-cli/pull/6 Motivation: Set up the graphql client, schema and implement a service command for reference Modifications: - Set up GraphQL client - Implement service ls command Result: GraphQL client can be reused by other commands This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] dmsolr commented on issue #3788: Rabbitmq plugin test migration
dmsolr commented on issue #3788: Rabbitmq plugin test migration URL: https://github.com/apache/skywalking/pull/3788#issuecomment-551022981 Hi @viswaramamoorthy It is almost to be good. follows the reviewer's suggestion and fix them. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] dmsolr commented on issue #3801: Why there are so many indexes
dmsolr commented on issue #3801: Why there are so many indexes URL: https://github.com/apache/skywalking/issues/3801#issuecomment-551021037 It is easy to delete historical data of ES. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] dmsolr closed issue #3801: Why there are so many indexes
dmsolr closed issue #3801: Why there are so many indexes URL: https://github.com/apache/skywalking/issues/3801 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario
wu-sheng commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#issuecomment-550995202 As aysnc http and es plugin are both default plugin. You must make sure they could work together, that is the default option. So, if anything incompatible in there, should be fixed first. Such as having unexpected exit span or local span with meaningless operation name. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] aderm commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario
aderm commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#issuecomment-550993223 Found that httpasyncclient has nothing to do with es6.x plugin, the test samples can pass normally, the only problem is that there may be problems in httpasyncclient. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario
wu-sheng commented on issue #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803#issuecomment-550989965 We need to fix async http first. What is status of that ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [skywalking] aderm opened a new pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario
aderm opened a new pull request #3803: Add elasticsearch 6.x plugin & elasticsearch 6.x test scenario URL: https://github.com/apache/skywalking/pull/3803 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [x] New feature provided - [ ] Improve performance - Related issues ___ ### Bug fix - Bug description. - How to fix? ___ ### New feature or improvement - Describe the details and related test reports. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
