[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5014: Fix timebucket conversion issue
codecov[bot] edited a comment on pull request #5014: URL: https://github.com/apache/skywalking/pull/5014#issuecomment-652950224 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=h1) Report > Merging [#5014](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/00619a9a3dbb8c41ff06635abfb89c05a761d6a4=desc) will **decrease** coverage by `9.99%`. > The diff coverage is `33.33%`. [](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5014 +/- ## = - Coverage 53.33% 43.34% -10.00% + Complexity 2941 2301 -640 = Files 766 761-5 Lines 1930119274 -27 Branches 1912 1912 = - Hits 10294 8354 -1940 - Misses 814910303 +2154 + Partials858 617 -241 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...torage/plugin/influxdb/query/AggregationQuery.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9BZ2dyZWdhdGlvblF1ZXJ5LmphdmE=) | `13.33% <0.00%> (ø)` | `2.00 <0.00> (ø)` | | | [...er/storage/plugin/influxdb/query/MetricsQuery.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRyaWNzUXVlcnkuamF2YQ==) | `50.83% <0.00%> (-0.84%)` | `10.00 <0.00> (-1.00)` | | | [...kywalking/oap/server/core/analysis/TimeBucket.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvVGltZUJ1Y2tldC5qYXZh) | `58.69% <100.00%> (+1.87%)` | `15.00 <0.00> (ø)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [136
[GitHub] [skywalking] BFergerson commented on issue #5011: java.lang.NullPointerException at org.apache.skywalking.apm.agent.core.context.ContextManager.stopSpan
BFergerson commented on issue #5011: URL: https://github.com/apache/skywalking/issues/5011#issuecomment-652954273 @LinXiaoJian, I'll give it a go. Please provide step-by-step instructions necessary to produce the issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5014: Fix timebucket conversion issue
codecov[bot] edited a comment on pull request #5014: URL: https://github.com/apache/skywalking/pull/5014#issuecomment-652950224 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=h1) Report > Merging [#5014](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/00619a9a3dbb8c41ff06635abfb89c05a761d6a4=desc) will **decrease** coverage by `12.99%`. > The diff coverage is `33.33%`. [](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5014 +/- ## = - Coverage 53.33% 40.33% -13.00% + Complexity 2941 2161 -780 = Files 766 745 -21 Lines 1930118874 -427 Branches 1912 1879 -33 = - Hits 10294 7613 -2681 - Misses 814910696 +2547 + Partials858 565 -293 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...torage/plugin/influxdb/query/AggregationQuery.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9BZ2dyZWdhdGlvblF1ZXJ5LmphdmE=) | `13.33% <0.00%> (ø)` | `2.00 <0.00> (ø)` | | | [...er/storage/plugin/influxdb/query/MetricsQuery.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRyaWNzUXVlcnkuamF2YQ==) | `22.50% <0.00%> (-29.17%)` | `5.00 <0.00> (-6.00)` | | | [...kywalking/oap/server/core/analysis/TimeBucket.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvVGltZUJ1Y2tldC5qYXZh) | `54.34% <100.00%> (-2.48%)` | `14.00 <0.00> (-1.00)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [171
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5014: Fix timebucket conversion issue
codecov[bot] edited a comment on pull request #5014: URL: https://github.com/apache/skywalking/pull/5014#issuecomment-652950224 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5014: Fix timebucket conversion issue
codecov[bot] edited a comment on pull request #5014: URL: https://github.com/apache/skywalking/pull/5014#issuecomment-652950224 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=h1) Report > Merging [#5014](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/00619a9a3dbb8c41ff06635abfb89c05a761d6a4=desc) will **decrease** coverage by `18.71%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5014 +/- ## = - Coverage 53.33% 34.61% -18.72% + Complexity 2941 1897 -1044 = Files 766 745 -21 Lines 1930118828 -473 Branches 1912 1877 -35 = - Hits 10294 6518 -3776 - Misses 814911821 +3672 + Partials858 489 -369 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...kywalking/oap/server/core/analysis/TimeBucket.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvVGltZUJ1Y2tldC5qYXZh) | `26.08% <0.00%> (-30.74%)` | `9.00 <0.00> (-6.00)` | | | [...torage/plugin/influxdb/query/AggregationQuery.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9BZ2dyZWdhdGlvblF1ZXJ5LmphdmE=) | `0.00% <0.00%> (-13.34%)` | `0.00 <0.00> (-2.00)` | | | [...er/storage/plugin/influxdb/query/MetricsQuery.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRyaWNzUXVlcnkuamF2YQ==) | `0.00% <0.00%> (-51.67%)` | `0.00 <0.00> (-11.00)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [226
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5014: Fix timebucket conversion issue
codecov[bot] edited a comment on pull request #5014: URL: https://github.com/apache/skywalking/pull/5014#issuecomment-652950224 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=h1) Report > Merging [#5014](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/00619a9a3dbb8c41ff06635abfb89c05a761d6a4=desc) will **decrease** coverage by `22.24%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5014 +/- ## = - Coverage 53.33% 31.08% -22.25% + Complexity 2941 1728 -1213 = Files 766 745 -21 Lines 1930118808 -493 Branches 1912 1875 -37 = - Hits 10294 5847 -4447 - Misses 814912516 +4367 + Partials858 445 -413 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...kywalking/oap/server/core/analysis/TimeBucket.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvVGltZUJ1Y2tldC5qYXZh) | `26.08% <0.00%> (-30.74%)` | `9.00 <0.00> (-6.00)` | | | [...torage/plugin/influxdb/query/AggregationQuery.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9BZ2dyZWdhdGlvblF1ZXJ5LmphdmE=) | `0.00% <0.00%> (-13.34%)` | `0.00 <0.00> (-2.00)` | | | [...er/storage/plugin/influxdb/query/MetricsQuery.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRyaWNzUXVlcnkuamF2YQ==) | `0.00% <0.00%> (-51.67%)` | `0.00 <0.00> (-11.00)` | | | [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [256
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5014: Fix timebucket conversion issue
codecov[bot] edited a comment on pull request #5014: URL: https://github.com/apache/skywalking/pull/5014#issuecomment-652950224 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5014: Fix timebucket conversion issue
codecov[bot] edited a comment on pull request #5014: URL: https://github.com/apache/skywalking/pull/5014#issuecomment-652950224 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=h1) Report > Merging [#5014](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/00619a9a3dbb8c41ff06635abfb89c05a761d6a4=desc) will **decrease** coverage by `23.32%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5014 +/- ## = - Coverage 53.33% 30.01% -23.33% + Complexity 2941 1683 -1258 = Files 766 745 -21 Lines 1930118797 -504 Branches 1912 1875 -37 = - Hits 10294 5641 -4653 - Misses 814912710 +4561 + Partials858 446 -412 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...kywalking/oap/server/core/analysis/TimeBucket.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvVGltZUJ1Y2tldC5qYXZh) | `26.08% <0.00%> (-30.74%)` | `9.00 <0.00> (-6.00)` | | | [...torage/plugin/influxdb/query/AggregationQuery.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9BZ2dyZWdhdGlvblF1ZXJ5LmphdmE=) | `0.00% <0.00%> (-13.34%)` | `0.00 <0.00> (-2.00)` | | | [...er/storage/plugin/influxdb/query/MetricsQuery.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRyaWNzUXVlcnkuamF2YQ==) | `0.00% <0.00%> (-51.67%)` | `0.00 <0.00> (-11.00)` | | | [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [279
[GitHub] [skywalking] LinXiaoJian commented on issue #5011: java.lang.NullPointerException at org.apache.skywalking.apm.agent.core.context.ContextManager.stopSpan
LinXiaoJian commented on issue #5011: URL: https://github.com/apache/skywalking/issues/5011#issuecomment-652951640 @BFergerson I am currently using the framework of is my friend, open source web framework based on vertx, if you are interested in, you can view the following address: https://github.com/cloudoptlab/cloudopt-next This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5014: Fix timebucket conversion issue
codecov[bot] edited a comment on pull request #5014: URL: https://github.com/apache/skywalking/pull/5014#issuecomment-652950224 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=h1) Report > Merging [#5014](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/00619a9a3dbb8c41ff06635abfb89c05a761d6a4=desc) will **decrease** coverage by `53.33%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5014 +/- ## - Coverage 53.33% 0.00% -53.34% Files 766 164 -602 Lines 193014056-15245 Branches 1912 481 -1431 - Hits 10294 0-10294 + Misses 81494056 -4093 + Partials858 0 -858 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [724 more](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5014: Fix timebucket conversion issue
codecov[bot] edited a comment on pull request #5014: URL: https://github.com/apache/skywalking/pull/5014#issuecomment-652950224 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=h1) Report > Merging [#5014](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/00619a9a3dbb8c41ff06635abfb89c05a761d6a4=desc) will **decrease** coverage by `53.33%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5014 +/- ## - Coverage 53.33% 0.00% -53.34% Files 766 163 -603 Lines 193014051-15250 Branches 1912 481 -1431 - Hits 10294 0-10294 + Misses 81494051 -4098 + Partials858 0 -858 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [725 more](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5014: Fix timebucket conversion issue
codecov[bot] edited a comment on pull request #5014: URL: https://github.com/apache/skywalking/pull/5014#issuecomment-652950224 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=h1) Report > Merging [#5014](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/00619a9a3dbb8c41ff06635abfb89c05a761d6a4=desc) will **decrease** coverage by `53.33%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5014 +/- ## - Coverage 53.33% 0.00% -53.34% Files 766 158 -608 Lines 193013948-15353 Branches 1912 470 -1442 - Hits 10294 0-10294 + Misses 81493948 -4201 + Partials858 0 -858 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [727 more](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5014: Fix timebucket conversion issue
codecov[bot] edited a comment on pull request #5014: URL: https://github.com/apache/skywalking/pull/5014#issuecomment-652950224 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=h1) Report > Merging [#5014](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/00619a9a3dbb8c41ff06635abfb89c05a761d6a4=desc) will **decrease** coverage by `53.33%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5014 +/- ## - Coverage 53.33% 0.00% -53.34% Files 766 161 -605 Lines 193014039-15262 Branches 1912 481 -1431 - Hits 10294 0-10294 + Misses 81494039 -4110 + Partials858 0 -858 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [725 more](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5014: Fix timebucket conversion issue
codecov[bot] edited a comment on pull request #5014: URL: https://github.com/apache/skywalking/pull/5014#issuecomment-652950224 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=h1) Report > Merging [#5014](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/00619a9a3dbb8c41ff06635abfb89c05a761d6a4=desc) will **decrease** coverage by `53.33%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5014 +/- ## - Coverage 53.33% 0.00% -53.34% Files 766 152 -614 Lines 193013817-15484 Branches 1912 451 -1461 - Hits 10294 0-10294 + Misses 81493817 -4332 + Partials858 0 -858 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [733 more](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] commented on pull request #5014: Fix timebucket conversion issue
codecov[bot] commented on pull request #5014: URL: https://github.com/apache/skywalking/pull/5014#issuecomment-652950224 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=h1) Report > Merging [#5014](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/00619a9a3dbb8c41ff06635abfb89c05a761d6a4=desc) will **decrease** coverage by `53.33%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5014 +/- ## - Coverage 53.33% 0.00% -53.34% Files 766 149 -617 Lines 193013771-15530 Branches 1912 447 -1465 - Hits 10294 0-10294 + Misses 81493771 -4378 + Partials858 0 -858 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5014?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [735 more](https://codecov.io/gh/apache/skywalking/pull/5014/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] dmsolr closed pull request #5006: [WIP] Test InfluxDB E2E failed in cluster mode
dmsolr closed pull request #5006: URL: https://github.com/apache/skywalking/pull/5006 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] dmsolr opened a new pull request #5014: Fix timebucket conversion issue
dmsolr opened a new pull request #5014: URL: https://github.com/apache/skywalking/pull/5014 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ] Improve performance - Related issues ___ ### Bug fix - Bug description. The TimeBucket converts to timestamp issue led to failure to e2e test. - How to fix? ___ ### New feature or improvement - Describe the details and related test reports. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] BFergerson edited a comment on issue #5011: java.lang.NullPointerException at org.apache.skywalking.apm.agent.core.context.ContextManager.stopSpan
BFergerson edited a comment on issue #5011: URL: https://github.com/apache/skywalking/issues/5011#issuecomment-652945767 @LinXiaoJian, unfortunately, those images aren't enough for me to help. Most of that code seems to be more custom than Vert.x idiomatic. Are you able to produce this issue in a project you can send me the source code for (via GitHub)? Preferably a minimally reproducible project. I don't think Kotlin should cause the issue you're seeing. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] BFergerson commented on issue #5011: java.lang.NullPointerException at org.apache.skywalking.apm.agent.core.context.ContextManager.stopSpan
BFergerson commented on issue #5011: URL: https://github.com/apache/skywalking/issues/5011#issuecomment-652945767 @LinXiaoJian, unfortunately, those images aren't enough for me to help. Most of that code seems to be more custom than Vert.x idiomatic. Are you able to produce this issue in a project you can send me the source code for (via GitHub)? Preferrable the minimally reproducible one. I don't think Kotlin should cause the issue you're seeing. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] LinXiaoJian edited a comment on issue #5011: java.lang.NullPointerException at org.apache.skywalking.apm.agent.core.context.ContextManager.stopSpan
LinXiaoJian edited a comment on issue #5011: URL: https://github.com/apache/skywalking/issues/5011#issuecomment-652936726 @BFergerson @wu-sheng I followed the error to find the following code, I'm using Kotlin development, I don't know if this is relevant   This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] LinXiaoJian commented on issue #5011: java.lang.NullPointerException at org.apache.skywalking.apm.agent.core.context.ContextManager.stopSpan
LinXiaoJian commented on issue #5011:
URL: https://github.com/apache/skywalking/issues/5011#issuecomment-652936726
@BFergerson @wu-sheng I followed the error to find the following code, I'm
using Kotlin development, I don't know if this is relevant
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5013: 8.0.0-8.0.1。table:endpoint_relation_server_side,column:entity_id .Data too long for column 'entity_id' at row 1
wu-sheng commented on issue #5013: URL: https://github.com/apache/skywalking/issues/5013#issuecomment-652912958 I think this is code level bug. 1. `EndpointRelationServerSideMetrics#entityId` 1. `ServiceInstanceRelationClientSideMetrics#entityId` 1. `ServiceInstanceRelationServerSideMetrics#entityId` 1. `ServiceRelationClientSideMetrics#entityId` 1. `ServiceRelationServerSideMetrics#entityId` Should add length statement in the Column annotation, should be `@Column(columnName = ENTITY_ID, length = 512)` Could you like to test locally? And send a pull request if the test passes? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] yazong commented on issue #5013: 8.0.0-8.0.1。table:endpoint_relation_server_side,column:entity_id .Data too long for column 'entity_id' at row 1
yazong commented on issue #5013: URL: https://github.com/apache/skywalking/issues/5013#issuecomment-652905713 > English only, please. 2020-07-02 15:09:49,144 - org.apache.skywalking.oap.server.storage.plugin.jdbc.h2.dao.H2BatchDAO - 75 [pool-4-thread-1] ERROR [] - Data truncation: Data too long for column 'entity_id' at row 1 com.mysql.cj.jdbc.exceptions.MysqlDataTruncation: Data truncation: Data too long for column 'entity_id' at row 1 at com.mysql.cj.jdbc.exceptions.SQLExceptionsMapping.translateException(SQLExceptionsMapping.java:97) ~[mysql-connector-java-6.0.6.jar:6.0.6] at com.mysql.cj.jdbc.ServerPreparedStatement.serverExecute(ServerPreparedStatement.java:1299) ~[mysql-connector-java-6.0.6.jar:6.0.6] at com.mysql.cj.jdbc.ServerPreparedStatement.executeInternal(ServerPreparedStatement.java:701) ~[mysql-connector-java-6.0.6.jar:6.0.6] at com.mysql.cj.jdbc.PreparedStatement.execute(PreparedStatement.java:1153) ~[mysql-connector-java-6.0.6.jar:6.0.6] at com.zaxxer.hikari.pool.ProxyPreparedStatement.execute(ProxyPreparedStatement.java:44) ~[HikariCP-3.1.0.jar:?] at com.zaxxer.hikari.pool.HikariProxyPreparedStatement.execute(HikariProxyPreparedStatement.java) ~[HikariCP-3.1.0.jar:?] at org.apache.skywalking.oap.server.storage.plugin.jdbc.SQLExecutor.invoke(SQLExecutor.java:53) ~[storage-jdbc-hikaricp-plugin-8.0.1.jar:8.0.1] at org.apache.skywalking.oap.server.storage.plugin.jdbc.h2.dao.H2BatchDAO.synchronous(H2BatchDAO.java:72) ~[storage-jdbc-hikaricp-plugin-8.0.1.jar:8.0.1] at org.apache.skywalking.oap.server.core.storage.PersistenceTimer.extractDataAndSave(PersistenceTimer.java:122) ~[server-core-8.0.1.jar:8.0.1] at org.apache.skywalking.oap.server.core.storage.PersistenceTimer.lambda$start$0(PersistenceTimer.java:78) ~[server-core-8.0.1.jar:8.0.1] at org.apache.skywalking.apm.util.RunnableWithExceptionProtection.run(RunnableWithExceptionProtection.java:33) [apm-util-8.0.1.jar:8.0.1] at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_172] at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) [?:1.8.0_172] at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180) [?:1.8.0_172] at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294) [?:1.8.0_172] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:1.8.0_172] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:1.8.0_172] at java.lang.Thread.run(Thread.java:748) [?:1.8.0_172] how do you solve this problem,please? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking-python] wu-sheng commented on pull request #30: [Core][BugFix] Add content equality of SegmentRef
wu-sheng commented on pull request #30: URL: https://github.com/apache/skywalking-python/pull/30#issuecomment-652906087 Oh, I see. So, python agent only had ref override self trace id mechanism, no ref override and ignorance mechanisms, right? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 commented on pull request #30: [Core][BugFix] Add content equality of SegmentRef
kezhenxu94 commented on pull request #30: URL: https://github.com/apache/skywalking-python/pull/30#issuecomment-652904534 > Is python facing duplicated trace id? No, this fixes the duplicate refs when one framework is built on another, for example, Flask is built on top of requests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 edited a comment on pull request #30: [Core][BugFix] Add content equality of SegmentRef
kezhenxu94 edited a comment on pull request #30: URL: https://github.com/apache/skywalking-python/pull/30#issuecomment-652904534 > Is python facing duplicated trace id? No, this fixes the duplicate refs when one framework is built on another, for example, Flask is built on top of requests https://github.com/apache/skywalking-python/blob/d121c145994f6734fee67f9da27d47986d600de5/skywalking/trace/span/__init__.py#L173-L174 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking-python] branch master updated: [Core][BugFix] Add content equality of SegmentRef (#30)
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-python.git The following commit(s) were added to refs/heads/master by this push: new 1736c24 [Core][BugFix] Add content equality of SegmentRef (#30) 1736c24 is described below commit 1736c2490c62b44f27e526d515551b6bca086d0b Author: kezhenxu94 AuthorDate: Thu Jul 2 17:42:45 2020 +0800 [Core][BugFix] Add content equality of SegmentRef (#30) --- skywalking/trace/segment/__init__.py | 12 1 file changed, 12 insertions(+) diff --git a/skywalking/trace/segment/__init__.py b/skywalking/trace/segment/__init__.py index bf1a71e..4a8d905 100644 --- a/skywalking/trace/segment/__init__.py +++ b/skywalking/trace/segment/__init__.py @@ -37,6 +37,18 @@ class SegmentRef(object): self.endpoint = carrier.endpoint # type: str self.client_address = carrier.client_address # type: str +def __eq__(self, other): +if not isinstance(other, SegmentRef): +raise NotImplementedError +return self.ref_type == other.ref_type and \ +self.trace_id == other.trace_id and \ +self.segment_id == other.segment_id and \ +self.span_id == other.span_id and \ +self.service == other.service and \ +self.service_instance == other.service_instance and \ +self.endpoint == other.endpoint and \ +self.client_address == other.client_address + class _NewID(ID): pass
[GitHub] [skywalking-python] kezhenxu94 merged pull request #30: [Core][BugFix] Add content equality of SegmentRef
kezhenxu94 merged pull request #30: URL: https://github.com/apache/skywalking-python/pull/30 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking-python] wu-sheng commented on pull request #30: [Core][BugFix] Add content equality of SegmentRef
wu-sheng commented on pull request #30: URL: https://github.com/apache/skywalking-python/pull/30#issuecomment-652889198 Is python facing duplicated trace id? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #5013: 8.0.0-8.0.1。table:endpoint_relation_server_side,column:entity_id .Data too long for column 'entity_id' at row 1
wu-sheng closed issue #5013: URL: https://github.com/apache/skywalking/issues/5013 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5013: 8.0.0-8.0.1。table:endpoint_relation_server_side,column:entity_id .Data too long for column 'entity_id' at row 1
wu-sheng commented on issue #5013: URL: https://github.com/apache/skywalking/issues/5013#issuecomment-652886173 English only, please. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] BFergerson commented on issue #5011: java.lang.NullPointerException at org.apache.skywalking.apm.agent.core.context.ContextManager.stopSpan
BFergerson commented on issue #5011: URL: https://github.com/apache/skywalking/issues/5011#issuecomment-652869715 @LinXiaoJian, I can help you with the Vert.x issue if you provide some sample code or more information about the issue but I'm not sure what mysql-connector-java has to do with Vert.x. They are unrelated and should not affect each other. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5011: java.lang.NullPointerException at org.apache.skywalking.apm.agent.core.context.ContextManager.stopSpan
wu-sheng commented on issue #5011: URL: https://github.com/apache/skywalking/issues/5011#issuecomment-652856979 These warnings have nothing related to the vert.x. And these are not errors. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] yazong opened a new issue #5013: 8.0.0-8.0.1。table:endpoint_relation_server_side,column:entity_id .Data too long for column 'entity_id' at row 1
yazong opened a new issue #5013: URL: https://github.com/apache/skywalking/issues/5013 **Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature or performance improvement ___ ### Question - What do you want to know? ___ ### Bug - Which version of SkyWalking, OS and JRE? - Which company or project? - What happen? If possible, provide a way for reproducing the error. e.g. demo application, component version. (一)测试环境测试机centos7-64安装skywalking8.0.1。jdk1.8-64bit。 CentOS Linux release 7.5.1804 (Core) 3.10.0-862.el7.x86_64 (二)本机PC-windows10-64bit基于jdk1.8-64bit使用IDEA2018.1-64bit版本启动Springcloud网关，配置如下: Greenwich.SR3 org.springframework.boot spring-boot-starter-parent 2.1.9.RELEASE org.springframework.cloud spring-cloud-starter-gateway spring-cloud-starter-gateway(2.1.3.RELEASE) IDEA配置skywalking-agent.jar以及 SW_AGENT_NAME=service-gateway;SW_AGENT_COLLECTOR_BACKEND_SERVICES=10.10.8.17:11800 在网关本地启动完成，还未通过网关访问微服务时(比如http://172.50.3.249:8770/service-hi/hi)，即个人理解为初始加载这个工程时。 skywalking-oap-server.log日志中抛出如下异常: 2020-07-02 15:09:49,144 - org.apache.skywalking.oap.server.storage.plugin.jdbc.h2.dao.H2BatchDAO - 75 [pool-4-thread-1] ERROR [] - Data truncation: Data too long for column 'entity_id' at row 1 com.mysql.cj.jdbc.exceptions.MysqlDataTruncation: Data truncation: Data too long for column 'entity_id' at row 1 at com.mysql.cj.jdbc.exceptions.SQLExceptionsMapping.translateException(SQLExceptionsMapping.java:97) ~[mysql-connector-java-6.0.6.jar:6.0.6] at com.mysql.cj.jdbc.ServerPreparedStatement.serverExecute(ServerPreparedStatement.java:1299) ~[mysql-connector-java-6.0.6.jar:6.0.6] at com.mysql.cj.jdbc.ServerPreparedStatement.executeInternal(ServerPreparedStatement.java:701) ~[mysql-connector-java-6.0.6.jar:6.0.6] at com.mysql.cj.jdbc.PreparedStatement.execute(PreparedStatement.java:1153) ~[mysql-connector-java-6.0.6.jar:6.0.6] at com.zaxxer.hikari.pool.ProxyPreparedStatement.execute(ProxyPreparedStatement.java:44) ~[HikariCP-3.1.0.jar:?] at com.zaxxer.hikari.pool.HikariProxyPreparedStatement.execute(HikariProxyPreparedStatement.java) ~[HikariCP-3.1.0.jar:?] at org.apache.skywalking.oap.server.storage.plugin.jdbc.SQLExecutor.invoke(SQLExecutor.java:53) ~[storage-jdbc-hikaricp-plugin-8.0.1.jar:8.0.1] at org.apache.skywalking.oap.server.storage.plugin.jdbc.h2.dao.H2BatchDAO.synchronous(H2BatchDAO.java:72) ~[storage-jdbc-hikaricp-plugin-8.0.1.jar:8.0.1] at org.apache.skywalking.oap.server.core.storage.PersistenceTimer.extractDataAndSave(PersistenceTimer.java:122) ~[server-core-8.0.1.jar:8.0.1] at org.apache.skywalking.oap.server.core.storage.PersistenceTimer.lambda$start$0(PersistenceTimer.java:78) ~[server-core-8.0.1.jar:8.0.1] at org.apache.skywalking.apm.util.RunnableWithExceptionProtection.run(RunnableWithExceptionProtection.java:33) [apm-util-8.0.1.jar:8.0.1] at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_172] at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) [?:1.8.0_172] at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180) [?:1.8.0_172] at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294) [?:1.8.0_172] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:1.8.0_172] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:1.8.0_172] at java.lang.Thread.run(Thread.java:748) [?:1.8.0_172] 个人通过修改apache-skywalking-apm-bin/config/log4j2.xml的日志输出级别为DEBUG后，发现 在插入或更新endpoint_relation_server_side表时，发现接收的entity_id值过长，大于表中的varchar(200)。 1)我把其他表检查了一下，其他表的entity_id为varchar(512)，当我改成功512后就没再报错。 2)docs/en/setup/service-agent/java-agent/Supported-list.md支持 Spring Cloud Gateway 2.0.2.RELEASE -> 2.2.x.RELEASE (Optional²) 注: 本次本机测试为单节点eureka+单节点gateway+双节点service 不确定我提的这个issue是否正确，打扰了。谢谢。 ___ ### Requirement or improvement - Please describe about your requirements or improvement suggestions.** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] LinXiaoJian edited a comment on issue #5011: java.lang.NullPointerException at org.apache.skywalking.apm.agent.core.context.ContextManager.stopSpan
LinXiaoJian edited a comment on issue #5011: URL: https://github.com/apache/skywalking/issues/5011#issuecomment-652850463 I can see support for vertx 3.8.1 in the Supported-list.md, But I just couldn't get started，I added the apm-mysql-*.jar and it didn't work. I use mysql-connector-java:8.0.19 2 vert.x-eventloop-thread-0 AbstractClassEnhancePluginDefine : enhance class com.mysql.cj.jdbc.Driver by plugin org.apache.skywalking.apm.plugin.jdbc.mysql.v6.define.DriverInstrumentation is not working. Because witness class com.mysql.cj.api.MysqlConnection is not existed. WARN 2020-07-02 15:55:47:738 vert.x-eventloop-thread-0 AbstractClassEnhancePluginDefine : enhance class com.mysql.cj.jdbc.NonRegisteringDriver by plugin org.apache.skywalking.apm.plugin.jdbc.mysql.v6.define.CacheIpsInstrumentation is not working. Because witness class com.mysql.cj.api.MysqlConnection is not existed. WARN 2020-07-02 15:55:47:988 vert.x-eventloop-thread-0 AbstractClassEnhancePluginDefine : enhance class com.mysql.cj.jdbc.ConnectionImpl by plugin org.apache.skywalking.apm.plugin.jdbc.mysql.v6.define.ConnectionInstrumentation is not working. Because witness class com.mysql.cj.api.MysqlConnection is not existed. WARN 2020-07-02 15:55:47:988 vert.x-eventloop-thread-0 AbstractClassEnhancePluginDefine : enhance class com.mysql.cj.jdbc.ConnectionImpl by plugin org.apache.skywalking.apm.plugin.jdbc.mysql.v6.define.ConnectionImplCreateInstrumentation is not working. Because witness class com.mysql.cj.api.MysqlConnection is not existed. WARN 2020-07-02 15:55:48:358 vert.x-eventloop-thread-0 AbstractClassEnhancePluginDefine : enhance class com.mysql.cj.jdbc.StatementImpl by plugin org.apache.skywalking.apm.plugin.jdbc.mysql.v6.define.StatementInstrumentation is not working. Because witness class com.mysql.cj.api.MysqlConnection is not existed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] LinXiaoJian commented on issue #5011: java.lang.NullPointerException at org.apache.skywalking.apm.agent.core.context.ContextManager.stopSpan
LinXiaoJian commented on issue #5011: URL: https://github.com/apache/skywalking/issues/5011#issuecomment-652850463 I can see support for vertx 3.8.1 in the Supported-list.md, But I just couldn't get started，I added the apm-mysql-*.jar and it didn't work 2 vert.x-eventloop-thread-0 AbstractClassEnhancePluginDefine : enhance class com.mysql.cj.jdbc.Driver by plugin org.apache.skywalking.apm.plugin.jdbc.mysql.v6.define.DriverInstrumentation is not working. Because witness class com.mysql.cj.api.MysqlConnection is not existed. WARN 2020-07-02 15:55:47:738 vert.x-eventloop-thread-0 AbstractClassEnhancePluginDefine : enhance class com.mysql.cj.jdbc.NonRegisteringDriver by plugin org.apache.skywalking.apm.plugin.jdbc.mysql.v6.define.CacheIpsInstrumentation is not working. Because witness class com.mysql.cj.api.MysqlConnection is not existed. WARN 2020-07-02 15:55:47:988 vert.x-eventloop-thread-0 AbstractClassEnhancePluginDefine : enhance class com.mysql.cj.jdbc.ConnectionImpl by plugin org.apache.skywalking.apm.plugin.jdbc.mysql.v6.define.ConnectionInstrumentation is not working. Because witness class com.mysql.cj.api.MysqlConnection is not existed. WARN 2020-07-02 15:55:47:988 vert.x-eventloop-thread-0 AbstractClassEnhancePluginDefine : enhance class com.mysql.cj.jdbc.ConnectionImpl by plugin org.apache.skywalking.apm.plugin.jdbc.mysql.v6.define.ConnectionImplCreateInstrumentation is not working. Because witness class com.mysql.cj.api.MysqlConnection is not existed. WARN 2020-07-02 15:55:48:358 vert.x-eventloop-thread-0 AbstractClassEnhancePluginDefine : enhance class com.mysql.cj.jdbc.StatementImpl by plugin org.apache.skywalking.apm.plugin.jdbc.mysql.v6.define.StatementInstrumentation is not working. Because witness class com.mysql.cj.api.MysqlConnection is not existed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking-python] branch bugfix/equality-of-segment-ref updated (7083b85 -> 50c4772)
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch bugfix/equality-of-segment-ref in repository https://gitbox.apache.org/repos/asf/skywalking-python.git. discard 7083b85 [Core][BugFix] Add content equality of SegmentRef add 50c4772 [Core][BugFix] Add content equality of SegmentRef This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (7083b85) \ N -- N -- N refs/heads/bugfix/equality-of-segment-ref (50c4772) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: skywalking/trace/segment/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[GitHub] [skywalking-python] wu-sheng commented on pull request #25: Add Flask plugin
wu-sheng commented on pull request #25: URL: https://github.com/apache/skywalking-python/pull/25#issuecomment-652825923 Forse push and close? What happens? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 closed pull request #25: Add Flask plugin
kezhenxu94 closed pull request #25: URL: https://github.com/apache/skywalking-python/pull/25 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 opened a new pull request #30: [Core][BugFix] Add content equality of SegmentRef
kezhenxu94 opened a new pull request #30: URL: https://github.com/apache/skywalking-python/pull/30 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking-python] 01/01: [Core][BugFix] Add content equality of SegmentRef
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch bugfix/equality-of-segment-ref in repository https://gitbox.apache.org/repos/asf/skywalking-python.git commit 7083b85dbba1d0beee982ef782b314a264b539e7 Author: kezhenxu94 AuthorDate: Thu Jul 2 15:01:36 2020 +0800 [Core][BugFix] Add content equality of SegmentRef --- skywalking/trace/segment/__init__.py | 12 1 file changed, 12 insertions(+) diff --git a/skywalking/trace/segment/__init__.py b/skywalking/trace/segment/__init__.py index bf1a71e..8062724 100644 --- a/skywalking/trace/segment/__init__.py +++ b/skywalking/trace/segment/__init__.py @@ -37,6 +37,18 @@ class SegmentRef(object): self.endpoint = carrier.endpoint # type: str self.client_address = carrier.client_address # type: str +def __eq__(self, other): +if not isinstance(other, SegmentRef): +raise NotImplemented +return self.ref_type == other.ref_type and \ +self.trace_id == other.trace_id and \ +self.segment_id == other.segment_id and \ +self.span_id == other.span_id and \ +self.service == other.service and \ +self.service_instance == other.service_instance and \ +self.endpoint == other.endpoint and \ +self.client_address == other.client_address + class _NewID(ID): pass
[skywalking-python] branch bugfix/equality-of-segment-ref created (now 7083b85)
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch bugfix/equality-of-segment-ref in repository https://gitbox.apache.org/repos/asf/skywalking-python.git. at 7083b85 [Core][BugFix] Add content equality of SegmentRef This branch includes the following new commits: new 7083b85 [Core][BugFix] Add content equality of SegmentRef The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[GitHub] [skywalking] wu-sheng commented on issue #5012: Why All My Instances' PID Equal 1?
wu-sheng commented on issue #5012: URL: https://github.com/apache/skywalking/issues/5012#issuecomment-652803923 Easy answer, learn docker. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #5012: Why All My Instances' PID Equal 1?
wu-sheng closed issue #5012: URL: https://github.com/apache/skywalking/issues/5012 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] otailai commented on issue #5012: Why All My Instances' PID Equal 1?
otailai commented on issue #5012: URL: https://github.com/apache/skywalking/issues/5012#issuecomment-652803661 the version of SkyWalking is 7.0.0 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] otailai opened a new issue #5012: Why All My Instances' PID Equal 1?
otailai opened a new issue #5012: URL: https://github.com/apache/skywalking/issues/5012 - Why do you submit this issue? - [x] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature or performance improvement ___ ### Question - What do you want to know? **the pids of all instances are all the same** Please check the incident behavior via following screeshot:  These applications are running within Docker, and I build a basic image by `COPY agent/ /app/agent/` and run application by adding `-javaagent:/app/agent/skywalking-agent.jar` into program arguments. Did I import any misconfiguration when deploying? Hope for replying! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
