[GitHub] [skywalking-cli] kezhenxu94 merged pull request #56: Add traces search

[GitBox]

kezhenxu94 merged pull request #56:
URL: https://github.com/apache/skywalking-cli/pull/56


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking-cli] kezhenxu94 commented on a change in pull request #56: Add traces search

[GitBox]

kezhenxu94 commented on a change in pull request #56:
URL: https://github.com/apache/skywalking-cli/pull/56#discussion_r471929804



##
File path: display/graph/tree/list.go
##
@@ -0,0 +1,190 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package tree
+
+import (
+   "fmt"
+   "strings"
+
+   d "github.com/apache/skywalking-cli/display/displayable"
+   "github.com/apache/skywalking-cli/graphql/schema"
+   "github.com/apache/skywalking-cli/graphql/trace"
+
+   ui "github.com/gizak/termui/v3"
+   "github.com/gizak/termui/v3/widgets"
+   "github.com/urfave/cli"
+
+   "github.com/apache/skywalking-cli/logger"
+)
+
+const DefaultPageSize = 15
+const keymap = " Keymap "
+const cc = ""
+
+func DisplayList(ctx *cli.Context, displayable *d.Displayable) error {
+   data := displayable.Data.(schema.TraceBrief)
+   condition := displayable.Condition.(*schema.TraceQueryCondition)
+   if err := ui.Init(); err != nil {
+   logger.Log.Fatalf("failed to initialize termui: %v", err)
+   }
+   defer ui.Close()
+
+   list := widgets.NewList()
+   list.TitleStyle.Fg = ui.ColorRed
+   list.TextStyle = ui.NewStyle(ui.ColorYellow)
+   list.WrapText = false
+
+   tree := widgets.NewTree()
+   tree.TextStyle = ui.NewStyle(ui.ColorYellow)
+   tree.WrapText = false
+   tree.TitleStyle.Fg = ui.ColorRed
+
+   help := widgets.NewParagraph()
+   help.WrapText = false
+   help.Title = keymap
+   help.Text = `[k  ](fg:red,mod:bold) Scroll Up
+   [   ](fg:red,mod:bold) Scroll Up
+   [j  ](fg:red,mod:bold) Scroll Down
+   [ ](fg:red,mod:bold) Scroll Down
+   [](fg:red,mod:bold) list Page Up
+   [](fg:red,mod:bold) list Page Down   
+   [p  ](fg:red,mod:bold) list Page Up
+   [n  ](fg:red,mod:bold) list Page Down
+   [](fg:red,mod:bold) Scroll Half Page Up
+   [](fg:red,mod:bold) Scroll Half Page Down
+   [ ](fg:red,mod:bold) Scroll to Top
+   [](fg:red,mod:bold) Show Trace
+   [  ](fg:red,mod:bold) Scroll to Bottom
+   [q  ](fg:red,mod:bold) Quit
+   [](fg:red,mod:bold) Quit
+`
+   draw(list, tree, help, data, 0, ctx, condition)
+   listenTracesKeyboard(list, tree, data, ctx, help, condition)
+
+   return nil
+}
+
+func draw(list *widgets.List, tree *widgets.Tree, help *widgets.Paragraph, 
data schema.TraceBrief, showIndex int,
+   ctx *cli.Context, condition *schema.TraceQueryCondition) {
+   x, y := ui.TerminalDimensions()
+
+   if data.Total != 0 {
+   var traceID = data.Traces[showIndex].TraceIds[0]
+   list.Title = fmt.Sprintf("[ %d/%d  %s]", 
*condition.Paging.PageNum, totalPages(data.Total), traceID)
+   nodes, serviceNames := getNodeData(ctx, traceID)
+   tree.Title = fmt.Sprintf("[%s]", strings.Join(serviceNames, 
"->"))
+   tree.SetNodes(nodes)
+   list.Rows = rows(data, x/4)
+   } else {
+   noData := "no data"
+   list.Title = noData
+   tree.Title = noData
+   }
+
+   list.SetRect(0, 0, x, y)
+   tree.SetRect(x/4, 0, x, y)
+   help.SetRect(x-x/7, 0, x, y)
+   tree.ExpandAll()

Review comment:
   The reason why we cannot switch the focus between the `list` and `tree` 
is that we manually set the rectangle area of them, by placing these widgets 
into containers, the focus can be switched between them, refer to 
`skywalking-cli/display/graph/linear/linear.go`





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[skywalking-cli] branch master updated: Add traces search (#56)

[kezhenxu94]

This is an automated email from the ASF dual-hosted git repository.

kezhenxu94 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-cli.git


The following commit(s) were added to refs/heads/master by this push:
 new eeec64b  Add traces search (#56)
eeec64b is described below

commit eeec64bb4dcdee12993ebff8f1f40ef6b248a82a
Author: huawei 
AuthorDate: Tue Aug 18 13:52:23 2020 +0800

Add traces search (#56)
---
 .gitmodules  |   2 +-
 README.md|  39 ---
 assets/graphqls/trace/Traces.graphql |  30 ++
 commands/trace/list.go   |  97 +-
 display/displayable/displayable.go   |   7 +-
 display/graph/graph.go   |   5 +
 display/graph/tree/adapter.go|  11 +-
 display/graph/tree/list.go   | 190 +++
 display/graph/tree/tree.go   |   9 +-
 go.mod   |   2 +-
 go.sum   |  16 ++-
 graphql/trace/trace.go   |  11 ++
 query-protocol   |   2 +-
 13 files changed, 382 insertions(+), 39 deletions(-)

diff --git a/.gitmodules b/.gitmodules
index 5ba3c21..3405629 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -1,3 +1,3 @@
 [submodule "query-protocol"]
path = query-protocol
-   url = http://github.com/apache/skywalking-query-protocol/
+   url = http://github.com/apache/skywalking-query-protocol/
\ No newline at end of file
diff --git a/README.md b/README.md
index 3655fa9..298e680 100644
--- a/README.md
+++ b/README.md
@@ -263,38 +263,41 @@ Ascii Graph, like coloring in terminal, so please use 
`json`  or `yaml` instead.
 
 
 
-### `dashboard`
-
- `dashboard global-metrics`
+### `trace ls`
 
 
 
-dashboard global-metrics [--template=template]
-
-`dashboard global-metrics` displays global metrics in the form of a dashboard.
+trace ls
 
 | argument | description | default |
 | :--- | :--- | :--- |
-| `--template` | The template file to customize how to display information | 
`templates/Dashboard.Global.json` |
-
-You can imitate the content of [the default template 
file](example/Dashboard.Global.json) to customize the dashboard.
+| `--trace-id` | the trace id whose spans are to displayed |  |
+| `--service-id` | the service id whose trace are to displayed |  |
+| `--service-instance-id` | the service instance id whose trace are to 
displayed |  |
+| `--tags` | Only tags defined in the core/default/searchableTagKeys are 
searchable. Check more details on the Configuration Vocabulary page | See 
[Configuration Vocabulary 
page](https://github.com/apache/skywalking/blob/master/docs/en/setup/backend/configuration-vocabulary.md)
 |
+| `--start` | See [Common options](#common-options) | See [Common 
options](#common-options) |
+| `--end` | See [Common options](#common-options) | See [Common 
options](#common-options) |
 
 
 
- `dashboard global`
+### `dashboard`
 
 
 
-dashboard global [--template=template]
+dashboard global-metrics [--template=template]
 
-`dashboard global` displays global metrics, global response latency and global 
heat map in the form of a dashboard.
+`dashboard global-metrics` displays global metrics in the form of a dashboard.
 
 | argument | description | default |
 | :--- | :--- | :--- |
-| `--template` | The template file to customize how to display information | 
`templates/Dashboard.Global.json` |
+| `--template` | the template file to customize how to display information | 
`templates/Dashboard.Global.json` |
+
+You can imitate the content of [the default template 
file](example/Dashboard.Global.json) to customize the dashboard.
 
 
 
+
+
 ### `checkHealth`
 
 
@@ -567,6 +570,16 @@ $ ./bin/swctl --display graph trace 
1585375544413.464998031.46647
 
 
 
+Display the traces
+
+```shell
+$ ./bin/swctl --display graph trace ls --start='2020-08-13 1754' 
--end='2020-08-20 2020'  --tags='http.method=POST'
+```
+
+
+
+
+
 Automatically convert to server side timezone
 
 if your backend nodes are deployed in docker and the timezone is UTC, you may 
not want to convert your timezone to UTC every time you type a command, 
`--timezone` comes to your rescue.
diff --git a/assets/graphqls/trace/Traces.graphql 
b/assets/graphqls/trace/Traces.graphql
new file mode 100644
index 000..ef91477
--- /dev/null
+++ b/assets/graphqls/trace/Traces.graphql
@@ -0,0 +1,30 @@
+# Licensed to Apache Software Foundation (ASF) under one or more contributor
+# license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright
+# ownership. Apache Software Foundation (ASF) licenses this file to you under
+# the Apache License, Version 2.0 (the "License"); you may
+# not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in 

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5339: Add support for spring @Scheduled

[GitBox]

wu-sheng commented on a change in pull request #5339:
URL: https://github.com/apache/skywalking/pull/5339#discussion_r471929578



##
File path: 
apm-sniffer/apm-sdk-plugin/spring-plugins/scheduled-annotation-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/scheduled/ScheduledMethodInterceptor.java
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.spring.scheduled;
+
+import org.apache.skywalking.apm.agent.core.context.ContextCarrier;
+import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceConstructorInterceptor;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
+import org.apache.skywalking.apm.network.trace.component.ComponentsDefine;
+
+import java.lang.reflect.Method;
+
+public class ScheduledMethodInterceptor implements 
InstanceMethodsAroundInterceptor, InstanceConstructorInterceptor {
+
+private static final String DEFAULT_OPERATION_NAME = "SpringScheduled";
+
+@Override
+public void beforeMethod(EnhancedInstance objInst, Method method, Object[] 
allArguments, Class[] argumentsTypes, MethodInterceptResult result) throws 
Throwable {
+String targetMethodName = (String) objInst.getSkyWalkingDynamicField();
+String operationName = targetMethodName != null ? targetMethodName : 
DEFAULT_OPERATION_NAME;
+
+AbstractSpan span = ContextManager.createEntrySpan(operationName, new 
ContextCarrier());

Review comment:
   If it is an entry, then it is a bug. Could you confirm? If yes. please 
send a pull request to fix.
   
   And if you want to analysis the performance of the job, consider to use 
logic endpoint tag, which is also included in the dev doc, too.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] hailin0 commented on a change in pull request #5339: Add support for spring @Scheduled

[GitBox]

hailin0 commented on a change in pull request #5339:
URL: https://github.com/apache/skywalking/pull/5339#discussion_r471928247



##
File path: 
apm-sniffer/apm-sdk-plugin/spring-plugins/scheduled-annotation-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/scheduled/ScheduledMethodInterceptor.java
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.spring.scheduled;
+
+import org.apache.skywalking.apm.agent.core.context.ContextCarrier;
+import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceConstructorInterceptor;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
+import org.apache.skywalking.apm.network.trace.component.ComponentsDefine;
+
+import java.lang.reflect.Method;
+
+public class ScheduledMethodInterceptor implements 
InstanceMethodsAroundInterceptor, InstanceConstructorInterceptor {
+
+private static final String DEFAULT_OPERATION_NAME = "SpringScheduled";
+
+@Override
+public void beforeMethod(EnhancedInstance objInst, Method method, Object[] 
allArguments, Class[] argumentsTypes, MethodInterceptResult result) throws 
Throwable {
+String targetMethodName = (String) objInst.getSkyWalkingDynamicField();
+String operationName = targetMethodName != null ? targetMethodName : 
DEFAULT_OPERATION_NAME;
+
+AbstractSpan span = ContextManager.createEntrySpan(operationName, new 
ContextCarrier());

Review comment:
   Thank you, I will read the plugin dev document.
   I referenced [elasticjob 
plugin](https://github.com/apache/skywalking/blob/master/apm-sniffer/apm-sdk-plugin/elastic-job-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/elasticjob/ElasticJobExecutorInterceptor.java#L39)
   





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] xbkaishui edited a comment on issue #5329: The plugin of skywalking agent does not support collecting http header details, such as referer, user-agent, if-none-match, cookie, pay

[GitBox]

xbkaishui edited a comment on issue #5329:
URL: https://github.com/apache/skywalking/issues/5329#issuecomment-675260845


   For the headers part,  it maybe contains sensitive data, such as token, or 
userInfo related. shoud we add option choose to filter by header names? 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] xbkaishui commented on issue #5329: The plugin of skywalking agent does not support collecting http header details, such as referer, user-agent, if-none-match, cookie, payload, e

[GitBox]

xbkaishui commented on issue #5329:
URL: https://github.com/apache/skywalking/issues/5329#issuecomment-675260845


   For the headers part,  it maybe contains senstive data, such as token, or 
userInfo related. shoud we add option choose to filter by header names? 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5339: Add support for spring @Scheduled

[GitBox]

wu-sheng commented on a change in pull request #5339:
URL: https://github.com/apache/skywalking/pull/5339#discussion_r471923271



##
File path: 
test/plugin/scenarios/spring-scheduled-scenario/config/expectedData.yaml
##
@@ -0,0 +1,48 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+segmentItems:
+  - serviceName: spring-scheduled-scenario
+segmentSize: ge 2
+segments:

Review comment:
   You missed the segment from the peer. There should be entry span 
representing the server side of this exit span.
   
   I know it is not the thing you added, but it should work, and the segment is 
expected.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] hailin0 commented on a change in pull request #5339: Add support for spring @Scheduled

[GitBox]

hailin0 commented on a change in pull request #5339:
URL: https://github.com/apache/skywalking/pull/5339#discussion_r471922334



##
File path: 
test/plugin/scenarios/spring-scheduled-scenario/config/expectedData.yaml
##
@@ -0,0 +1,48 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+segmentItems:
+  - serviceName: spring-scheduled-scenario
+segmentSize: ge 2
+segments:

Review comment:
   Yes, it's on [line 
37](https://github.com/apache/skywalking/pull/5339/files/7f6bba6a27a0ba0ccb41c639f0002e5276b7de3a#diff-f1c217f8303ef2da8c91cd14aaa67300R37).





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

[GitBox]

codecov[bot] edited a comment on pull request #5345:
URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) 
Report
   > Merging 
[#5345](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `0.00%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5345/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5345  +/-   ##
   
   - Coverage 53.26%   53.25%   -0.01% 
   - Complexity 3215 3218   +3 
   
 Files   829  830   +1 
 Lines 2084620850   +4 
 Branches   2023 2023  
   
   + Hits  1110311104   +1 
   - Misses 8836 8848  +12 
   + Partials907  898   -9 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...iver/clr/provider/handler/CLRSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctY2xyLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2Nsci9wcm92aWRlci9oYW5kbGVyL0NMUlNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `10.00% <0.00%> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...erver/library/server/grpc/CustomThreadFactory.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvQ3VzdG9tVGhyZWFkRmFjdG9yeS5qYXZh)
 | `69.23% <0.00%> (-7.70%)` | `2.00% <0.00%> (-1.00%)` | |
   | 
[...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==)
 | `57.77% <0.00%> (-4.45%)` | `17.00% <0.00%> (-1.00%)` | |
   | 
[...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=)
 | `50.70% <0.00%> (-2.82%)` | `12.00% <0.00%> (ø%)` | |
   | 
[...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh)
 | `57.08% <0.00%> (-2.58%)` | `27.00% <0.00%> (-1.00%)` | |
   | 
[...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh)
 | `54.00% <0.00%> (-2.00%)` | `6.00% <0.00%> (-1.00%)` | |
   | 
[...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | 
[...e/parser/listener/MultiScopesAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9NdWx0aVNjb3Blc0FuYWx5c2lzTGlzdGVuZXIuamF2YQ==)
 | `70.55% <0.00%> (+2.22%)` | `26.00% <0.00%> (+2.00%)` | |
   | 
[...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh)
 | `78.94% <0.00%> (+2.63%)` | `18.00% <0.00%> (+2.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

[GitBox]

codecov[bot] edited a comment on pull request #5345:
URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) 
Report
   > Merging 
[#5345](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `0.20%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5345/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5345  +/-   ##
   
   - Coverage 53.26%   53.05%   -0.21% 
   + Complexity 3215 3208   -7 
   
 Files   829  830   +1 
 Lines 2084620850   +4 
 Branches   2023 2023  
   
   - Hits  1110311063  -40 
   - Misses 8836 8898  +62 
   + Partials907  889  -18 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...iver/clr/provider/handler/CLRSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctY2xyLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2Nsci9wcm92aWRlci9oYW5kbGVyL0NMUlNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `10.00% <0.00%> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ge/plugin/elasticsearch/query/TraceQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVHJhY2VRdWVyeUVzREFPLmphdmE=)
 | `3.75% <0.00%> (-28.75%)` | `1.00% <0.00%> (-2.00%)` | |
   | 
[...torage/plugin/elasticsearch/base/MetricsEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9NZXRyaWNzRXNEQU8uamF2YQ==)
 | `80.00% <0.00%> (-20.00%)` | `4.00% <0.00%> (-1.00%)` | |
   | 
[...erver/library/server/grpc/CustomThreadFactory.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvQ3VzdG9tVGhyZWFkRmFjdG9yeS5qYXZh)
 | `69.23% <0.00%> (-7.70%)` | `2.00% <0.00%> (-1.00%)` | |
   | 
[...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh)
 | `53.21% <0.00%> (-6.44%)` | `24.00% <0.00%> (-4.00%)` | |
   | 
[...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==)
 | `57.77% <0.00%> (-4.45%)` | `17.00% <0.00%> (-1.00%)` | |
   | 
[...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2pkYmMvaGlrYXJpY3AvSkRCQ0hpa2FyaUNQQ2xpZW50LmphdmE=)
 | `50.70% <0.00%> (-2.82%)` | `12.00% <0.00%> (ø%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

[GitBox]

codecov[bot] edited a comment on pull request #5345:
URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) 
Report
   > Merging 
[#5345](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `0.87%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5345/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5345  +/-   ##
   
   - Coverage 53.26%   52.38%   -0.88% 
   + Complexity 3215 3185  -30 
   
 Files   829  830   +1 
 Lines 2084620850   +4 
 Branches   2023 2023  
   
   - Hits  1110310923 -180 
   - Misses 8836 9037 +201 
   + Partials907  890  -17 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...iver/clr/provider/handler/CLRSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctY2xyLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2Nsci9wcm92aWRlci9oYW5kbGVyL0NMUlNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `10.00% <0.00%> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh)
 | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
   | 
[...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh)
 | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
   | 
[...gin/elasticsearch/query/ProfileTaskQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tRdWVyeUVzREFPLmphdmE=)
 | `28.57% <0.00%> (-59.19%)` | `2.00% <0.00%> (-7.00%)` | |
   | 
[...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==)
 | `42.85% <0.00%> (-57.15%)` | `1.00% <0.00%> (-1.00%)` | |
   | 
[...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeUVzN0RBTy5qYXZh)
 | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
   | 
[...rver/core/profile/ProfileThreadSnapshotRecord.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGhyZWFkU25hcHNob3RSZWNvcmQuamF2YQ==)
 | `47.82% <0.00%> (-34.79%)` | `2.00% <0.00%> (ø%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

[GitBox]

codecov[bot] edited a comment on pull request #5345:
URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) 
Report
   > Merging 
[#5345](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `1.59%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5345/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5345  +/-   ##
   
   - Coverage 53.26%   51.66%   -1.60% 
   + Complexity 3215 3163  -52 
   
 Files   829  829  
 Lines 2084620829  -17 
 Branches   2023 2022   -1 
   
   - Hits  1110310762 -341 
   - Misses 8836 9181 +345 
   + Partials907  886  -21 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...iver/clr/provider/handler/CLRSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctY2xyLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2Nsci9wcm92aWRlci9oYW5kbGVyL0NMUlNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `10.00% <0.00%> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh)
 | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
   | 
[...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh)
 | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
   | 
[...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==)
 | `2.41% <0.00%> (-79.04%)` | `1.00% <0.00%> (-10.00%)` | |
   | 
[...e/plugin/jdbc/h2/dao/H2ProfileTaskLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRhc2tMb2dRdWVyeURBTy5qYXZh)
 | `13.63% <0.00%> (-77.28%)` | `1.00% <0.00%> (-3.00%)` | |
   | 
[...gin/elasticsearch/query/ProfileTaskQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tRdWVyeUVzREFPLmphdmE=)
 | `28.57% <0.00%> (-59.19%)` | `2.00% <0.00%> (-7.00%)` | |
   | 
[...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==)
 | `42.85% <0.00%> (-57.15%)` | `1.00% <0.00%> (-1.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

[GitBox]

codecov[bot] edited a comment on pull request #5345:
URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) 
Report
   > Merging 
[#5345](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `0.86%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5345/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5345  +/-   ##
   
   - Coverage 53.26%   52.39%   -0.87% 
   + Complexity 3215 3185  -30 
   
 Files   829  829  
 Lines 2084620846  
 Branches   2023 2023  
   
   - Hits  1110310923 -180 
   - Misses 8836 9033 +197 
   + Partials907  890  -17 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...iver/clr/provider/handler/CLRSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctY2xyLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2Nsci9wcm92aWRlci9oYW5kbGVyL0NMUlNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `10.00% <0.00%> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh)
 | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
   | 
[...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh)
 | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
   | 
[...gin/elasticsearch/query/ProfileTaskQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tRdWVyeUVzREFPLmphdmE=)
 | `28.57% <0.00%> (-59.19%)` | `2.00% <0.00%> (-7.00%)` | |
   | 
[...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==)
 | `42.85% <0.00%> (-57.15%)` | `1.00% <0.00%> (-1.00%)` | |
   | 
[...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeUVzN0RBTy5qYXZh)
 | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
   | 
[...rver/core/profile/ProfileThreadSnapshotRecord.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9Qcm9maWxlVGhyZWFkU25hcHNob3RSZWNvcmQuamF2YQ==)
 | `47.82% <0.00%> (-34.79%)` | `2.00% <0.00%> (ø%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

[GitBox]

codecov[bot] edited a comment on pull request #5345:
URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) 
Report
   > Merging 
[#5345](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `2.34%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5345/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5345  +/-   ##
   
   - Coverage 53.26%   50.91%   -2.35% 
   + Complexity 3215 3129  -86 
   
 Files   829  829  
 Lines 2084620829  -17 
 Branches   2023 2022   -1 
   
   - Hits  1110310606 -497 
   - Misses 8836 9349 +513 
   + Partials907  874  -33 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...iver/clr/provider/handler/CLRSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctY2xyLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2Nsci9wcm92aWRlci9oYW5kbGVyL0NMUlNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `10.00% <0.00%> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh)
 | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
   | 
[...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh)
 | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
   | 
[...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==)
 | `2.41% <0.00%> (-79.04%)` | `1.00% <0.00%> (-10.00%)` | |
   | 
[...e/plugin/jdbc/h2/dao/H2ProfileTaskLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRhc2tMb2dRdWVyeURBTy5qYXZh)
 | `13.63% <0.00%> (-77.28%)` | `1.00% <0.00%> (-3.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

[GitBox]

codecov[bot] edited a comment on pull request #5345:
URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) 
Report
   > Merging 
[#5345](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `3.03%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5345/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5345  +/-   ##
   
   - Coverage 53.26%   50.22%   -3.04% 
   + Complexity 3215 3107 -108 
   
 Files   829  829  
 Lines 2084620819  -27 
 Branches   2023 2021   -2 
   
   - Hits  1110310456 -647 
   - Misses 8836 9502 +666 
   + Partials907  861  -46 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...iver/clr/provider/handler/CLRSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctY2xyLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2Nsci9wcm92aWRlci9oYW5kbGVyL0NMUlNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `10.00% <0.00%> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh)
 | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
   | 
[...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh)
 | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
   | 
[.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=)
 | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
   | 
[...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==)
 | `2.41% <0.00%> (-79.04%)` | `1.00% <0.00%> (-10.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

[GitBox]

codecov[bot] edited a comment on pull request #5345:
URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) 
Report
   > Merging 
[#5345](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `3.12%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5345/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5345  +/-   ##
   
   - Coverage 53.26%   50.13%   -3.13% 
   + Complexity 3215 3098 -117 
   
 Files   829  829  
 Lines 2084620819  -27 
 Branches   2023 2021   -2 
   
   - Hits  1110310437 -666 
   - Misses 8836 9521 +685 
   + Partials907  861  -46 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...iver/clr/provider/handler/CLRSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctY2xyLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2Nsci9wcm92aWRlci9oYW5kbGVyL0NMUlNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `10.00% <0.00%> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh)
 | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
   | 
[...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh)
 | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
   | 
[.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=)
 | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
   | 
[...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==)
 | `2.41% <0.00%> (-79.04%)` | `1.00% <0.00%> (-10.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

[GitBox]

codecov[bot] edited a comment on pull request #5345:
URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) 
Report
   > Merging 
[#5345](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `3.03%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5345/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5345  +/-   ##
   
   - Coverage 53.26%   50.22%   -3.04% 
   + Complexity 3215 3098 -117 
   
 Files   829  828   -1 
 Lines 2084620780  -66 
 Branches   2023 2020   -3 
   
   - Hits  1110310437 -666 
   - Misses 8836 9482 +646 
   + Partials907  861  -46 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...iver/clr/provider/handler/CLRSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctY2xyLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2Nsci9wcm92aWRlci9oYW5kbGVyL0NMUlNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `10.00% <0.00%> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh)
 | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
   | 
[...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh)
 | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
   | 
[.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=)
 | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
   | 
[...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==)
 | `2.41% <0.00%> (-79.04%)` | `1.00% <0.00%> (-10.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

[GitBox]

codecov[bot] edited a comment on pull request #5345:
URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) 
Report
   > Merging 
[#5345](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `3.02%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5345/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5345  +/-   ##
   
   - Coverage 53.26%   50.24%   -3.03% 
   + Complexity 3215 3098 -117 
   
 Files   829  826   -3 
 Lines 2084620774  -72 
 Branches   2023 2020   -3 
   
   - Hits  1110310437 -666 
   - Misses 8836 9476 +640 
   + Partials907  861  -46 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...iver/clr/provider/handler/CLRSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctY2xyLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2Nsci9wcm92aWRlci9oYW5kbGVyL0NMUlNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `10.00% <0.00%> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh)
 | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
   | 
[...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh)
 | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
   | 
[.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=)
 | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
   | 
[...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==)
 | `2.41% <0.00%> (-79.04%)` | `1.00% <0.00%> (-10.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

[GitBox]

codecov[bot] edited a comment on pull request #5345:
URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) 
Report
   > Merging 
[#5345](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `3.02%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5345/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5345  +/-   ##
   
   - Coverage 53.26%   50.24%   -3.03% 
   + Complexity 3215 3098 -117 
   
 Files   829  826   -3 
 Lines 2084620774  -72 
 Branches   2023 2020   -3 
   
   - Hits  1110310437 -666 
   - Misses 8836 9476 +640 
   + Partials907  861  -46 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...iver/clr/provider/handler/CLRSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctY2xyLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2Nsci9wcm92aWRlci9oYW5kbGVyL0NMUlNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `10.00% <0.00%> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh)
 | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
   | 
[...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh)
 | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
   | 
[.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=)
 | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
   | 
[...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==)
 | `2.41% <0.00%> (-79.04%)` | `1.00% <0.00%> (-10.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

[GitBox]

codecov[bot] edited a comment on pull request #5345:
URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) 
Report
   > Merging 
[#5345](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `2.78%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5345/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5345  +/-   ##
   
   - Coverage 53.26%   50.48%   -2.79% 
   + Complexity 3215 3098 -117 
   
 Files   829  823   -6 
 Lines 2084620675 -171 
 Branches   2023 2009  -14 
   
   - Hits  1110310437 -666 
   - Misses 8836 9377 +541 
   + Partials907  861  -46 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...iver/clr/provider/handler/CLRSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctY2xyLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2Nsci9wcm92aWRlci9oYW5kbGVyL0NMUlNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `10.00% <0.00%> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh)
 | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
   | 
[...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh)
 | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
   | 
[.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=)
 | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
   | 
[...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==)
 | `2.41% <0.00%> (-79.04%)` | `1.00% <0.00%> (-10.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

[GitBox]

codecov[bot] edited a comment on pull request #5345:
URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) 
Report
   > Merging 
[#5345](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `2.74%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5345/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5345  +/-   ##
   
   - Coverage 53.26%   50.52%   -2.75% 
   + Complexity 3215 3098 -117 
   
 Files   829  822   -7 
 Lines 2084620659 -187 
 Branches   2023 2005  -18 
   
   - Hits  1110310437 -666 
   - Misses 8836 9361 +525 
   + Partials907  861  -46 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...iver/clr/provider/handler/CLRSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctY2xyLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2Nsci9wcm92aWRlci9oYW5kbGVyL0NMUlNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `10.00% <0.00%> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh)
 | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
   | 
[...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh)
 | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
   | 
[.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=)
 | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
   | 
[...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==)
 | `2.41% <0.00%> (-79.04%)` | `1.00% <0.00%> (-10.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

[GitBox]

codecov[bot] edited a comment on pull request #5345:
URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) 
Report
   > Merging 
[#5345](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `2.67%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5345/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5345  +/-   ##
   
   - Coverage 53.26%   50.58%   -2.68% 
   + Complexity 3215 3098 -117 
   
 Files   829  821   -8 
 Lines 2084620633 -213 
 Branches   2023 2005  -18 
   
   - Hits  1110310437 -666 
   - Misses 8836 9335 +499 
   + Partials907  861  -46 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...iver/clr/provider/handler/CLRSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctY2xyLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2Nsci9wcm92aWRlci9oYW5kbGVyL0NMUlNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `10.00% <0.00%> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh)
 | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
   | 
[...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh)
 | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
   | 
[.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=)
 | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
   | 
[...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==)
 | `2.41% <0.00%> (-79.04%)` | `1.00% <0.00%> (-10.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

[GitBox]

codecov[bot] edited a comment on pull request #5345:
URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) 
Report
   > Merging 
[#5345](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `2.65%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5345/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5345  +/-   ##
   
   - Coverage 53.26%   50.61%   -2.66% 
   + Complexity 3215 3098 -117 
   
 Files   829  819  -10 
 Lines 2084620622 -224 
 Branches   2023 2005  -18 
   
   - Hits  1110310437 -666 
   - Misses 8836 9324 +488 
   + Partials907  861  -46 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...iver/clr/provider/handler/CLRSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctY2xyLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2Nsci9wcm92aWRlci9oYW5kbGVyL0NMUlNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `10.00% <0.00%> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh)
 | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
   | 
[...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh)
 | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
   | 
[.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=)
 | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
   | 
[...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==)
 | `2.41% <0.00%> (-79.04%)` | `1.00% <0.00%> (-10.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

[GitBox]

codecov[bot] edited a comment on pull request #5345:
URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) 
Report
   > Merging 
[#5345](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `2.68%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5345/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5345  +/-   ##
   
   - Coverage 53.26%   50.57%   -2.69% 
   + Complexity 3215 3097 -118 
   
 Files   829  819  -10 
 Lines 2084620612 -234 
 Branches   2023 2005  -18 
   
   - Hits  1110310424 -679 
   - Misses 8836 9326 +490 
   + Partials907  862  -45 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...iver/clr/provider/handler/CLRSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctY2xyLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2Nsci9wcm92aWRlci9oYW5kbGVyL0NMUlNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `10.00% <0.00%> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh)
 | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
   | 
[...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh)
 | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
   | 
[.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=)
 | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
   | 
[...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==)
 | `2.41% <0.00%> (-79.04%)` | `1.00% <0.00%> (-10.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

[GitBox]

codecov[bot] edited a comment on pull request #5345:
URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) 
Report
   > Merging 
[#5345](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `4.98%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5345/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5345  +/-   ##
   
   - Coverage 53.26%   48.27%   -4.99% 
   + Complexity 3215 2997 -218 
   
 Files   829  819  -10 
 Lines 2084620593 -253 
 Branches   2023 2005  -18 
   
   - Hits  11103 9942-1161 
   - Misses 8836 9824 +988 
   + Partials907  827  -80 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...iver/clr/provider/handler/CLRSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctY2xyLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2Nsci9wcm92aWRlci9oYW5kbGVyL0NMUlNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `10.00% <0.00%> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh)
 | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
   | 
[.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==)
 | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
   | 
[...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh)
 | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
   | 
[...m/network/trace/component/command/BaseCommand.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0Jhc2VDb21tYW5kLmphdmE=)
 | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-2.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

[GitBox]

codecov[bot] edited a comment on pull request #5345:
URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) 
Report
   > Merging 
[#5345](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `4.96%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5345/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5345  +/-   ##
   
   - Coverage 53.26%   48.29%   -4.97% 
   + Complexity 3215 2997 -218 
   
 Files   829  819  -10 
 Lines 2084620587 -259 
 Branches   2023 1992  -31 
   
   - Hits  11103 9942-1161 
   - Misses 8836 9818 +982 
   + Partials907  827  -80 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...iver/clr/provider/handler/CLRSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctY2xyLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2Nsci9wcm92aWRlci9oYW5kbGVyL0NMUlNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `10.00% <0.00%> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh)
 | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
   | 
[.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==)
 | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
   | 
[...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh)
 | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
   | 
[...m/network/trace/component/command/BaseCommand.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0Jhc2VDb21tYW5kLmphdmE=)
 | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-2.00%)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

[GitBox]

codecov[bot] edited a comment on pull request #5345:
URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) 
Report
   > Merging 
[#5345](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `14.43%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5345/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5345   +/-   ##
   =
   - Coverage 53.26%   38.82%   -14.44% 
   + Complexity 3215 2338  -877 
   =
 Files   829  819   -10 
 Lines 2084620585  -261 
 Branches   2023 1990   -33 
   =
   - Hits  11103 7993 -3110 
   - Misses 883612004 +3168 
   + Partials907  588  -319 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...iver/clr/provider/handler/CLRSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctY2xyLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2Nsci9wcm92aWRlci9oYW5kbGVyL0NMUlNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `10.00% <0.00%> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [205 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

[GitBox]

codecov[bot] edited a comment on pull request #5345:
URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) 
Report
   > Merging 
[#5345](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `17.76%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5345/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5345   +/-   ##
   =
   - Coverage 53.26%   35.50%   -17.77% 
   + Complexity 3215 2112 -1103 
   =
 Files   829  803   -26 
 Lines 2084620121  -725 
 Branches   2023 1950   -73 
   =
   - Hits  11103 7143 -3960 
   - Misses 883612439 +3603 
   + Partials907  539  -368 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...iver/clr/provider/handler/CLRSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctY2xyLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2Nsci9wcm92aWRlci9oYW5kbGVyL0NMUlNvdXJjZURpc3BhdGNoZXIuamF2YQ==)
 | `10.00% <0.00%> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [248 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

[GitBox]

codecov[bot] edited a comment on pull request #5345:
URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

[GitBox]

codecov[bot] edited a comment on pull request #5345:
URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) 
Report
   > Merging 
[#5345](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `53.26%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5345/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #5345   +/-   ##
   
   - Coverage 53.26%   0.00%   -53.27% 
   
 Files   829 164  -665 
 Lines 208463977-16869 
 Branches   2023 466 -1557 
   
   - Hits  11103   0-11103 
   + Misses 88363977 -4859 
   + Partials907   0  -907 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [793 
more](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

[GitBox]

codecov[bot] edited a comment on pull request #5345:
URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) 
Report
   > Merging 
[#5345](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `53.26%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5345/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #5345   +/-   ##
   
   - Coverage 53.26%   0.00%   -53.27% 
   
 Files   829 163  -666 
 Lines 208463971-16875 
 Branches   2023 466 -1557 
   
   - Hits  11103   0-11103 
   + Misses 88363971 -4865 
   + Partials907   0  -907 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [794 
more](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

[GitBox]

codecov-io edited a comment on pull request #4228:
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) 
Report
   > Merging 
[#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `1.05%`.
   > The diff coverage is `19.05%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4228/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4228  +/-   ##
   
   - Coverage 53.26%   52.20%   -1.06% 
   - Complexity 3215 3264  +49 
   
 Files   829  869  +40 
 Lines 2084621484 +638 
 Branches   2023 2060  +37 
   
   + Hits  1110311216 +113 
   - Misses 8836 9369 +533 
   + Partials907  899   -8 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../skywalking/oap/server/core/analysis/NodeType.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvTm9kZVR5cGUuamF2YQ==)
 | `52.94% <0.00%> (-1.61%)` | `7.00 <0.00> (ø)` | |
   | 
[...server/core/analysis/metrics/ErrorRateMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9FcnJvclJhdGVNZXRyaWNzLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...oap/server/core/browser/source/BrowserAppPerf.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFBlcmYuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...re/browser/source/BrowserAppSingleVersionPerf.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFNpbmdsZVZlcnNpb25QZXJmLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=)
 | `100.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...server/core/storage/query/IBrowserLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JQnJvd3NlckxvZ1F1ZXJ5REFPLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ider/parser/errorlog/BrowserErrorLogDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9Ccm93c2VyRXJyb3JMb2dEZWNvcmF0b3IuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [99 
more](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree-more)
 | 

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

[GitBox]

codecov-io edited a comment on pull request #4228:
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) 
Report
   > Merging 
[#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `1.03%`.
   > The diff coverage is `19.05%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4228/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4228  +/-   ##
   
   - Coverage 53.26%   52.22%   -1.04% 
   - Complexity 3215 3264  +49 
   
 Files   829  869  +40 
 Lines 2084621476 +630 
 Branches   2023 2045  +22 
   
   + Hits  1110311216 +113 
   - Misses 8836 9361 +525 
   + Partials907  899   -8 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../skywalking/oap/server/core/analysis/NodeType.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvTm9kZVR5cGUuamF2YQ==)
 | `52.94% <0.00%> (-1.61%)` | `7.00 <0.00> (ø)` | |
   | 
[...server/core/analysis/metrics/ErrorRateMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9FcnJvclJhdGVNZXRyaWNzLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...oap/server/core/browser/source/BrowserAppPerf.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFBlcmYuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...re/browser/source/BrowserAppSingleVersionPerf.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFNpbmdsZVZlcnNpb25QZXJmLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=)
 | `100.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...server/core/storage/query/IBrowserLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JQnJvd3NlckxvZ1F1ZXJ5REFPLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ider/parser/errorlog/BrowserErrorLogDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9Ccm93c2VyRXJyb3JMb2dEZWNvcmF0b3IuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [106 
more](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree-more)
 | 

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

[GitBox]

codecov-io edited a comment on pull request #4228:
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) 
Report
   > Merging 
[#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `1.21%`.
   > The diff coverage is `19.05%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4228/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4228  +/-   ##
   
   - Coverage 53.26%   52.04%   -1.22% 
   - Complexity 3215 3249  +34 
   
 Files   829  869  +40 
 Lines 2084621476 +630 
 Branches   2023 2045  +22 
   
   + Hits  1110311178  +75 
   - Misses 8836 9402 +566 
   + Partials907  896  -11 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../skywalking/oap/server/core/analysis/NodeType.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvTm9kZVR5cGUuamF2YQ==)
 | `52.94% <0.00%> (-1.61%)` | `7.00 <0.00> (ø)` | |
   | 
[...server/core/analysis/metrics/ErrorRateMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9FcnJvclJhdGVNZXRyaWNzLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...oap/server/core/browser/source/BrowserAppPerf.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFBlcmYuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...re/browser/source/BrowserAppSingleVersionPerf.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFNpbmdsZVZlcnNpb25QZXJmLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=)
 | `100.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...server/core/storage/query/IBrowserLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JQnJvd3NlckxvZ1F1ZXJ5REFPLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ider/parser/errorlog/BrowserErrorLogDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9Ccm93c2VyRXJyb3JMb2dEZWNvcmF0b3IuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [123 
more](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree-more)
 | 

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

[GitBox]

codecov-io edited a comment on pull request #4228:
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) 
Report
   > Merging 
[#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `1.18%`.
   > The diff coverage is `19.05%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4228/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4228  +/-   ##
   
   - Coverage 53.26%   52.07%   -1.19% 
   - Complexity 3215 3249  +34 
   
 Files   829  867  +38 
 Lines 2084621465 +619 
 Branches   2023 2045  +22 
   
   + Hits  1110311178  +75 
   - Misses 8836 9391 +555 
   + Partials907  896  -11 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../skywalking/oap/server/core/analysis/NodeType.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvTm9kZVR5cGUuamF2YQ==)
 | `52.94% <0.00%> (-1.61%)` | `7.00 <0.00> (ø)` | |
   | 
[...server/core/analysis/metrics/ErrorRateMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9FcnJvclJhdGVNZXRyaWNzLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...oap/server/core/browser/source/BrowserAppPerf.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFBlcmYuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...re/browser/source/BrowserAppSingleVersionPerf.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFNpbmdsZVZlcnNpb25QZXJmLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=)
 | `100.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...server/core/storage/query/IBrowserLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JQnJvd3NlckxvZ1F1ZXJ5REFPLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ider/parser/errorlog/BrowserErrorLogDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9Ccm93c2VyRXJyb3JMb2dEZWNvcmF0b3IuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [125 
more](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree-more)
 | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5345: Fix CLRThread metrics setId error.

[GitBox]

codecov[bot] edited a comment on pull request #5345:
URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) 
Report
   > Merging 
[#5345](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `53.26%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5345/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #5345   +/-   ##
   
   - Coverage 53.26%   0.00%   -53.27% 
   
 Files   829 163  -666 
 Lines 208463971-16875 
 Branches   2023 466 -1557 
   
   - Hits  11103   0-11103 
   + Misses 88363971 -4865 
   + Partials907   0  -907 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [794 
more](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

[GitBox]

codecov-io edited a comment on pull request #4228:
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) 
Report
   > Merging 
[#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `1.19%`.
   > The diff coverage is `19.05%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4228/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4228  +/-   ##
   
   - Coverage 53.26%   52.06%   -1.20% 
   - Complexity 3215 3247  +32 
   
 Files   829  867  +38 
 Lines 2084621465 +619 
 Branches   2023 2045  +22 
   
   + Hits  1110311176  +73 
   - Misses 8836 9393 +557 
   + Partials907  896  -11 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../skywalking/oap/server/core/analysis/NodeType.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvTm9kZVR5cGUuamF2YQ==)
 | `52.94% <0.00%> (-1.61%)` | `7.00 <0.00> (ø)` | |
   | 
[...server/core/analysis/metrics/ErrorRateMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9FcnJvclJhdGVNZXRyaWNzLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...oap/server/core/browser/source/BrowserAppPerf.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFBlcmYuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...re/browser/source/BrowserAppSingleVersionPerf.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFNpbmdsZVZlcnNpb25QZXJmLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=)
 | `100.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...server/core/storage/query/IBrowserLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JQnJvd3NlckxvZ1F1ZXJ5REFPLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ider/parser/errorlog/BrowserErrorLogDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9Ccm93c2VyRXJyb3JMb2dEZWNvcmF0b3IuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [126 
more](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree-more)
 | 

[GitHub] [skywalking] codecov[bot] commented on pull request #5345: Fix CLRThread metrics setId error.

[GitBox]

codecov[bot] commented on pull request #5345:
URL: https://github.com/apache/skywalking/pull/5345#issuecomment-675245963


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=h1) 
Report
   > Merging 
[#5345](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `53.26%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5345/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #5345   +/-   ##
   
   - Coverage 53.26%   0.00%   -53.27% 
   
 Files   829 161  -668 
 Lines 208463959-16887 
 Branches   2023 466 -1557 
   
   - Hits  11103   0-11103 
   + Misses 88363959 -4877 
   + Partials907   0  -907 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5345?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [794 
more](https://codecov.io/gh/apache/skywalking/pull/5345/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

[GitBox]

codecov-io edited a comment on pull request #4228:
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

[GitBox]

codecov-io edited a comment on pull request #4228:
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) 
Report
   > Merging 
[#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `1.99%`.
   > The diff coverage is `19.05%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4228/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4228  +/-   ##
   
   - Coverage 53.26%   51.26%   -2.00% 
   - Complexity 3215 3221   +6 
   
 Files   829  867  +38 
 Lines 2084621465 +619 
 Branches   2023 2045  +22 
   
   - Hits  1110311005  -98 
   - Misses 8836 9573 +737 
   + Partials907  887  -20 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../skywalking/oap/server/core/analysis/NodeType.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvTm9kZVR5cGUuamF2YQ==)
 | `52.94% <0.00%> (-1.61%)` | `7.00 <0.00> (ø)` | |
   | 
[...server/core/analysis/metrics/ErrorRateMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9FcnJvclJhdGVNZXRyaWNzLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...oap/server/core/browser/source/BrowserAppPerf.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFBlcmYuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...re/browser/source/BrowserAppSingleVersionPerf.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFNpbmdsZVZlcnNpb25QZXJmLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=)
 | `100.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...server/core/storage/query/IBrowserLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JQnJvd3NlckxvZ1F1ZXJ5REFPLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ider/parser/errorlog/BrowserErrorLogDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9Ccm93c2VyRXJyb3JMb2dEZWNvcmF0b3IuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [133 
more](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree-more)
 | 

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

[GitBox]

codecov-io edited a comment on pull request #4228:
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) 
Report
   > Merging 
[#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `2.32%`.
   > The diff coverage is `19.05%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4228/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4228  +/-   ##
   
   - Coverage 53.26%   50.93%   -2.33% 
   + Complexity 3215 3200  -15 
   
 Files   829  865  +36 
 Lines 2084621459 +613 
 Branches   2023 2045  +22 
   
   - Hits  1110310930 -173 
   - Misses 8836 9645 +809 
   + Partials907  884  -23 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../skywalking/oap/server/core/analysis/NodeType.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvTm9kZVR5cGUuamF2YQ==)
 | `52.94% <0.00%> (-1.61%)` | `7.00 <0.00> (ø)` | |
   | 
[...server/core/analysis/metrics/ErrorRateMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9FcnJvclJhdGVNZXRyaWNzLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...oap/server/core/browser/source/BrowserAppPerf.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFBlcmYuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...re/browser/source/BrowserAppSingleVersionPerf.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFNpbmdsZVZlcnNpb25QZXJmLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=)
 | `100.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...server/core/storage/query/IBrowserLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JQnJvd3NlckxvZ1F1ZXJ5REFPLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ider/parser/errorlog/BrowserErrorLogDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9Ccm93c2VyRXJyb3JMb2dEZWNvcmF0b3IuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [140 
more](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree-more)
 | 

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

[GitBox]

codecov-io edited a comment on pull request #4228:
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

[GitBox]

codecov-io edited a comment on pull request #4228:
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) 
Report
   > Merging 
[#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `12.68%`.
   > The diff coverage is `19.05%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4228/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4228   +/-   ##
   =
   - Coverage 53.26%   40.57%   -12.69% 
   + Complexity 3215 2481  -734 
   =
 Files   829  865   +36 
 Lines 2084621459  +613 
 Branches   2023 2045   +22 
   =
   - Hits  11103 8708 -2395 
   - Misses 883612112 +3276 
   + Partials907  639  -268 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../skywalking/oap/server/core/analysis/NodeType.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvTm9kZVR5cGUuamF2YQ==)
 | `52.94% <0.00%> (-1.61%)` | `7.00 <0.00> (ø)` | |
   | 
[...server/core/analysis/metrics/ErrorRateMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9FcnJvclJhdGVNZXRyaWNzLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...oap/server/core/browser/source/BrowserAppPerf.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFBlcmYuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...re/browser/source/BrowserAppSingleVersionPerf.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFNpbmdsZVZlcnNpb25QZXJmLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=)
 | `100.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...server/core/storage/query/IBrowserLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JQnJvd3NlckxvZ1F1ZXJ5REFPLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ider/parser/errorlog/BrowserErrorLogDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9Ccm93c2VyRXJyb3JMb2dEZWNvcmF0b3IuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [270 

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

[GitBox]

codecov-io edited a comment on pull request #4228:
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

[GitBox]

codecov-io edited a comment on pull request #4228:
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) 
Report
   > Merging 
[#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `18.70%`.
   > The diff coverage is `18.46%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4228/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4228   +/-   ##
   =
   - Coverage 53.26%   34.55%   -18.71% 
   + Complexity 3215 2214 -1001 
   =
 Files   829  864   +35 
 Lines 2084621370  +524 
 Branches   2023 2042   +19 
   =
   - Hits  11103 7384 -3719 
   - Misses 883613439 +4603 
   + Partials907  547  -360 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../skywalking/oap/server/core/analysis/NodeType.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvTm9kZVR5cGUuamF2YQ==)
 | `52.94% <0.00%> (-1.61%)` | `7.00 <0.00> (ø)` | |
   | 
[...server/core/analysis/metrics/ErrorRateMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9FcnJvclJhdGVNZXRyaWNzLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...oap/server/core/browser/source/BrowserAppPerf.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFBlcmYuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...re/browser/source/BrowserAppSingleVersionPerf.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFNpbmdsZVZlcnNpb25QZXJmLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=)
 | `100.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...server/core/storage/query/IBrowserLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JQnJvd3NlckxvZ1F1ZXJ5REFPLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ider/parser/errorlog/BrowserErrorLogDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9Ccm93c2VyRXJyb3JMb2dEZWNvcmF0b3IuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [328 

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

[GitBox]

codecov-io edited a comment on pull request #4228:
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) 
Report
   > Merging 
[#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `20.33%`.
   > The diff coverage is `17.87%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4228/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4228   +/-   ##
   =
   - Coverage 53.26%   32.92%   -20.34% 
   + Complexity 3215 2106 -1109 
   =
 Files   829  864   +35 
 Lines 2084621370  +524 
 Branches   2023 2042   +19 
   =
   - Hits  11103 7037 -4066 
   - Misses 883613815 +4979 
   + Partials907  518  -389 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../skywalking/oap/server/core/analysis/NodeType.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvTm9kZVR5cGUuamF2YQ==)
 | `52.94% <0.00%> (-1.61%)` | `7.00 <0.00> (ø)` | |
   | 
[...server/core/analysis/metrics/ErrorRateMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9FcnJvclJhdGVNZXRyaWNzLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...oap/server/core/browser/source/BrowserAppPerf.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFBlcmYuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...re/browser/source/BrowserAppSingleVersionPerf.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFNpbmdsZVZlcnNpb25QZXJmLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=)
 | `100.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...server/core/storage/query/IBrowserLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JQnJvd3NlckxvZ1F1ZXJ5REFPLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ider/parser/errorlog/BrowserErrorLogDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9Ccm93c2VyRXJyb3JMb2dEZWNvcmF0b3IuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [343 

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

[GitBox]

codecov-io edited a comment on pull request #4228:
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) 
Report
   > Merging 
[#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `20.25%`.
   > The diff coverage is `17.87%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4228/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4228   +/-   ##
   =
   - Coverage 53.26%   33.00%   -20.26% 
   + Complexity 3215 2108 -1107 
   =
 Files   829  864   +35 
 Lines 2084621370  +524 
 Branches   2023 2042   +19 
   =
   - Hits  11103 7054 -4049 
   - Misses 883613798 +4962 
   + Partials907  518  -389 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../skywalking/oap/server/core/analysis/NodeType.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvTm9kZVR5cGUuamF2YQ==)
 | `52.94% <0.00%> (-1.61%)` | `7.00 <0.00> (ø)` | |
   | 
[...server/core/analysis/metrics/ErrorRateMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9FcnJvclJhdGVNZXRyaWNzLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...oap/server/core/browser/source/BrowserAppPerf.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFBlcmYuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...re/browser/source/BrowserAppSingleVersionPerf.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFNpbmdsZVZlcnNpb25QZXJmLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=)
 | `100.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...server/core/storage/query/IBrowserLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JQnJvd3NlckxvZ1F1ZXJ5REFPLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ider/parser/errorlog/BrowserErrorLogDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9Ccm93c2VyRXJyb3JMb2dEZWNvcmF0b3IuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [340 

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

[GitBox]

codecov-io edited a comment on pull request #4228:
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) 
Report
   > Merging 
[#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `22.42%`.
   > The diff coverage is `15.92%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4228/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4228   +/-   ##
   =
   - Coverage 53.26%   30.83%   -22.43% 
   + Complexity 3215 1950 -1265 
   =
 Files   829  847   +18 
 Lines 2084620875   +29 
 Branches   2023 1994   -29 
   =
   - Hits  11103 6437 -4666 
   - Misses 883613967 +5131 
   + Partials907  471  -436 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../skywalking/oap/server/core/analysis/NodeType.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvTm9kZVR5cGUuamF2YQ==)
 | `52.94% <0.00%> (-1.61%)` | `7.00 <0.00> (ø)` | |
   | 
[...server/core/analysis/metrics/ErrorRateMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9FcnJvclJhdGVNZXRyaWNzLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...oap/server/core/browser/source/BrowserAppPerf.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFBlcmYuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...re/browser/source/BrowserAppSingleVersionPerf.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFNpbmdsZVZlcnNpb25QZXJmLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=)
 | `100.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...server/core/storage/query/IBrowserLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JQnJvd3NlckxvZ1F1ZXJ5REFPLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ider/parser/errorlog/BrowserErrorLogDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9Ccm93c2VyRXJyb3JMb2dEZWNvcmF0b3IuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [365 

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

[GitBox]

codecov-io edited a comment on pull request #4228:
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) 
Report
   > Merging 
[#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `23.89%`.
   > The diff coverage is `15.92%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4228/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#4228   +/-   ##
   =
   - Coverage 53.26%   29.36%   -23.90% 
   + Complexity 3215 1853 -1362 
   =
 Files   829  847   +18 
 Lines 2084620829   -17 
 Branches   2023 1993   -30 
   =
   - Hits  11103 6117 -4986 
   - Misses 883614252 +5416 
   + Partials907  460  -447 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../skywalking/oap/server/core/analysis/NodeType.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvTm9kZVR5cGUuamF2YQ==)
 | `50.00% <0.00%> (-4.55%)` | `6.00 <0.00> (-1.00)` | |
   | 
[...server/core/analysis/metrics/ErrorRateMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9FcnJvclJhdGVNZXRyaWNzLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...oap/server/core/browser/source/BrowserAppPerf.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFBlcmYuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...re/browser/source/BrowserAppSingleVersionPerf.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFNpbmdsZVZlcnNpb25QZXJmLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=)
 | `100.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | 
[...server/core/storage/query/IBrowserLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9xdWVyeS9JQnJvd3NlckxvZ1F1ZXJ5REFPLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ider/parser/errorlog/BrowserErrorLogDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9Ccm93c2VyRXJyb3JMb2dEZWNvcmF0b3IuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [398 

[GitHub] [skywalking] wu-sheng commented on issue #5329: The plugin of skywalking agent does not support collecting http header details, such as referer, user-agent, if-none-match, cookie, payload, et

[GitBox]

wu-sheng commented on issue #5329:
URL: https://github.com/apache/skywalking/issues/5329#issuecomment-675244422


   Done



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] snakorse opened a new pull request #5345: Fix CLRThread metrics setId error.

[GitBox]

snakorse opened a new pull request #5345:
URL: https://github.com/apache/skywalking/pull/5345


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [x] Bug fix
   - [ ] New feature provided
   - [ ] Improve performance
   
   ___
   ### Bug fix
   - Bug description.
   The `serviceInstanceCLRThread.setId` method uses `serviceInstance` by 
mistake.
   
   - How to fix?
   Should use `serviceInstanceId`.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

[GitBox]

codecov-io edited a comment on pull request #4228:
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) 
Report
   > Merging 
[#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `53.26%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4228/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4228   +/-   ##
   
   - Coverage 53.26%   0.00%   -53.27% 
   
 Files   829 168  -661 
 Lines 208464102-16744 
 Branches   2023 477 -1546 
   
   - Hits  11103   0-11103 
   + Misses 88364102 -4734 
   + Partials907   0  -907 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [775 
more](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

[GitBox]

codecov-io edited a comment on pull request #4228:
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

[GitBox]

codecov-io edited a comment on pull request #4228:
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) 
Report
   > Merging 
[#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `53.26%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4228/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4228   +/-   ##
   
   - Coverage 53.26%   0.00%   -53.27% 
   
 Files   829 167  -662 
 Lines 208464096-16750 
 Branches   2023 477 -1546 
   
   - Hits  11103   0-11103 
   + Misses 88364096 -4740 
   + Partials907   0  -907 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [776 
more](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

[GitBox]

codecov-io edited a comment on pull request #4228:
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) 
Report
   > Merging 
[#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `53.26%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4228/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4228   +/-   ##
   
   - Coverage 53.26%   0.00%   -53.27% 
   
 Files   829 152  -677 
 Lines 208463764-17082 
 Branches   2023 441 -1582 
   
   - Hits  11103   0-11103 
   + Misses 88363764 -5072 
   + Partials907   0  -907 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [788 
more](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

[GitBox]

codecov-io edited a comment on pull request #4228:
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) 
Report
   > Merging 
[#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `53.26%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4228/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #4228   +/-   ##
   
   - Coverage 53.26%   0.00%   -53.27% 
   
 Files   829 151  -678 
 Lines 208463724-17122 
 Branches   2023 437 -1586 
   
   - Hits  11103   0-11103 
   + Misses 88363724 -5112 
   + Partials907   0  -907 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | ... and [788 
more](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

[GitBox]

codecov-io edited a comment on pull request #4228:
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) 
Report
   > Merging 
[#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b173cde5dbeeb1a15aa25954fe960dd480267f20=desc)
 will **decrease** coverage by `0.62%`.
   > The diff coverage is `19.79%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4228/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4228  +/-   ##
   
   - Coverage 53.26%   52.64%   -0.63% 
   - Complexity 3215 3226  +11 
   
 Files   829 1530 +701 
 Lines 2084632805   +11959 
 Branches   2023 3562+1539 
   
   + Hits  1110317269+6166 
   - Misses 883614720+5884 
   + Partials907  816  -91 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../skywalking/oap/server/core/analysis/NodeType.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvTm9kZVR5cGUuamF2YQ==)
 | `52.94% <0.00%> (-1.61%)` | `7.00 <0.00> (ø)` | |
   | 
[...server/core/analysis/metrics/ErrorRateMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9FcnJvclJhdGVNZXRyaWNzLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...oap/server/core/browser/source/BrowserAppPerf.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFBlcmYuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...re/browser/source/BrowserAppSingleVersionPerf.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFNpbmdsZVZlcnNpb25QZXJmLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ider/parser/errorlog/BrowserErrorLogDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9Ccm93c2VyRXJyb3JMb2dEZWNvcmF0b3IuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ser/provider/parser/errorlog/ErrorLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9FcnJvckxvZ0FuYWx5emVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 

[GitHub] [skywalking] xbkaishui commented on issue #5329: The plugin of skywalking agent does not support collecting http header details, such as referer, user-agent, if-none-match, cookie, payload, e

[GitBox]

xbkaishui commented on issue #5329:
URL: https://github.com/apache/skywalking/issues/5329#issuecomment-675239448


   I want to try, please assign to me 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #5344: How to access the same skywalking service in multiple environments?

[GitBox]

wu-sheng commented on issue #5344:
URL: https://github.com/apache/skywalking/issues/5344#issuecomment-675238906


   You could do anything you want. I just say, we don't have that concept. Why 
need APM in the tesr and dev env? Strange thing.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] gyjx commented on issue #5344: How to access the same skywalking service in multiple environments?

[GitBox]

gyjx commented on issue #5344:
URL: https://github.com/apache/skywalking/issues/5344#issuecomment-675236166


   Does SK not support service partitioning? Do I need to deploy three SK 
services? dev test pre 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #5344: How to access the same skywalking service in multiple environments?

[GitBox]

wu-sheng commented on issue #5344:
URL: https://github.com/apache/skywalking/issues/5344#issuecomment-675235477


   No, we don't have that. Management is not our agenda today.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] gyjx commented on issue #5344: How to access the same skywalking service in multiple environments?

[GitBox]

gyjx commented on issue #5344:
URL: https://github.com/apache/skywalking/issues/5344#issuecomment-675235260


   I'm sorry, maybe I didn't make it clear. I mean, if I have three links: 
development, testing and pre release, but I just want to deploy a skywalking 
service, how will I divide it?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #5344: How to access the same skywalking service in multiple environments?

[GitBox]

wu-sheng commented on issue #5344:
URL: https://github.com/apache/skywalking/issues/5344#issuecomment-675224138


   What do you mean by how to access? We don't set any limitation for this.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] wu-sheng closed issue #5344: How to access the same skywalking service in multiple environments?

[GitBox]

wu-sheng closed issue #5344:
URL: https://github.com/apache/skywalking/issues/5344


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] gyjx opened a new issue #5344: How to access the same skywalking service in multiple environments?

[GitBox]

gyjx opened a new issue #5344:
URL: https://github.com/apache/skywalking/issues/5344


   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [ ] Question or discussion
   - [ ] Bug
   - [X ] Requirement
   - [ ] Feature or performance improvement
   
   ___
   ### Question
   - What do you want to know?
   How to access the same skywalking service in multiple environments?
   ___
   ### Bug
   - Which version of SkyWalking, OS and JRE?
   
   - Which company or project?
   
   - What happened?
   If possible, provide a way to reproduce the error. e.g. demo application, 
component version.
   
   ___
   ### Requirement or improvement
   - Please describe your requirements or improvement suggestions.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #5343: SW_STORAGE_ES_INDEX_SHARDS_NUMBER ineffective

[GitBox]

wu-sheng commented on issue #5343:
URL: https://github.com/apache/skywalking/issues/5343#issuecomment-675214918


   6.4 is a very old version for the community.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] wu-sheng closed issue #5343: SW_STORAGE_ES_INDEX_SHARDS_NUMBER ineffective

[GitBox]

wu-sheng closed issue #5343:
URL: https://github.com/apache/skywalking/issues/5343


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #5343: SW_STORAGE_ES_INDEX_SHARDS_NUMBER ineffective

[GitBox]

wu-sheng commented on issue #5343:
URL: https://github.com/apache/skywalking/issues/5343#issuecomment-675214806


   Do you delete the templates?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #5085: Include request method type in rest mapping annotations

[GitBox]

wu-sheng commented on pull request #5085:
URL: https://github.com/apache/skywalking/pull/5085#issuecomment-675214362


   @kezhenxu94 Could you take a look the error?
   
   @BFergerson I think the key error is here, 
https://github.com/apache/skywalking/blob/master/test/e2e/e2e-test/src/test/java/org/apache/skywalking/e2e/profile/ProfileE2E.java#L144
   You changed the endpoint naming rule, then the profile task fails because no 
endpoint name matched the task parameter.
   
   Note, the logs you posted are not related to this, I just say for the e2e 
test fail because of timeout.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] pingliu opened a new issue #5343: SW_STORAGE_ES_INDEX_SHARDS_NUMBER ineffective

[GitBox]

pingliu opened a new issue #5343:
URL: https://github.com/apache/skywalking/issues/5343


   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [X] Question or discussion
   - [X ] Bug
   - [ ] Requirement
   - [ ] Feature or performance improvement
   
   ___
   ### Question
   - What do you want to know?
   
   
   ___
   ### Bug
   - Which version of SkyWalking, OS and JRE?
   skywalking:6.4
   - Which company or project?
   
   - What happened?
   If possible, provide a way to reproduce the error. e.g. demo application, 
component version.
   
   first,I use the elasticsearch default config,the default index shard is 2. 
it's ok.
   but when I change the index shard config, change to 3,then stop service and 
delete index, and start service,
   the created index shard also is 2.  
   why ??
   ___
   ### Requirement or improvement
   - Please describe your requirements or improvement suggestions.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] ascrutae commented on pull request #5335: fix bug about webflux broken trace

[GitBox]

ascrutae commented on pull request #5335:
URL: https://github.com/apache/skywalking/pull/5335#issuecomment-675213869


   Got it!
   On Aug 18, 2020, 10:19 AM +0800, 吴晟 Wu Sheng , 
wrote:
   > @ascrutae I close this for now. Wait for your fix.
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub, or unsubscribe.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5339: Add support for spring @Scheduled

[GitBox]

wu-sheng commented on a change in pull request #5339:
URL: https://github.com/apache/skywalking/pull/5339#discussion_r471877418



##
File path: 
test/plugin/scenarios/spring-scheduled-scenario/config/expectedData.yaml
##
@@ -0,0 +1,48 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+segmentItems:
+  - serviceName: spring-scheduled-scenario
+segmentSize: ge 2
+segments:

Review comment:
   From my reading of your test case codes, there should be a segment 
starting with `SchedulingJob#work`, where it is? Or do I miss anything?

##
File path: .github/workflows/plugins-test.3.yaml
##
@@ -55,6 +55,7 @@ jobs:
   - { name: 'hbase-scenario', title: 'hbase-scenario (5)' }
   - { name: 'spring-kafka-2.2.x-scenario', title: 'Spring-Kafka 2.2.x 
(7)' }
   - { name: 'spring-kafka-2.3.x-scenario', title: 'Spring-Kafka 2.3.x 
(7)' }
+  - { name: 'spring-scheduled-scenario', title: 'Spring Scheduled 
3.1.x-5.2.x (119)' }

Review comment:
   Don't use all 119 versions, it costs too many CI resources and time. 
Just choose the typical ones, such as choose the latest version in 5.0.x to 
represent all versions.

##
File path: 
apm-sniffer/apm-sdk-plugin/spring-plugins/scheduled-annotation-plugin/src/main/java/org/apache/skywalking/apm/plugin/spring/scheduled/ScheduledMethodInterceptor.java
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.spring.scheduled;
+
+import org.apache.skywalking.apm.agent.core.context.ContextCarrier;
+import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceConstructorInterceptor;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
+import org.apache.skywalking.apm.network.trace.component.ComponentsDefine;
+
+import java.lang.reflect.Method;
+
+public class ScheduledMethodInterceptor implements 
InstanceMethodsAroundInterceptor, InstanceConstructorInterceptor {
+
+private static final String DEFAULT_OPERATION_NAME = "SpringScheduled";
+
+@Override
+public void beforeMethod(EnhancedInstance objInst, Method method, Object[] 
allArguments, Class[] argumentsTypes, MethodInterceptResult result) throws 
Throwable {
+String targetMethodName = (String) objInst.getSkyWalkingDynamicField();
+String operationName = targetMethodName != null ? targetMethodName : 
DEFAULT_OPERATION_NAME;
+
+AbstractSpan span = ContextManager.createEntrySpan(operationName, new 
ContextCarrier());

Review comment:
   This is just a local scheduler task, not an entry. Please read the 
plugin dev document. This should be a local span. Could you share why you put 
this as Entry Span?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] wu-sheng closed pull request #5335: fix bug about webflux broken trace

[GitBox]

wu-sheng closed pull request #5335:
URL: https://github.com/apache/skywalking/pull/5335


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on pull request #5335: fix bug about webflux broken trace

[GitBox]

wu-sheng commented on pull request #5335:
URL: https://github.com/apache/skywalking/pull/5335#issuecomment-675210299


   @ascrutae I close this for now. Wait for your fix.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP

[GitBox]

codecov-io edited a comment on pull request #4228:
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) 
Report
   > Merging 
[#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/522e0951bcdf0bc2fbec177163049ebd5168f525=desc)
 will **decrease** coverage by `0.79%`.
   > The diff coverage is `19.79%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4228/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#4228  +/-   ##
   
   - Coverage 53.43%   52.64%   -0.80% 
   - Complexity 3204 3226  +22 
   
 Files  1493 1530  +37 
 Lines 3226532805 +540 
 Branches   3557 3562   +5 
   
   + Hits  1724117269  +28 
   - Misses1420814720 +512 
 Partials816  816  
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../skywalking/oap/server/core/analysis/NodeType.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvTm9kZVR5cGUuamF2YQ==)
 | `52.94% <0.00%> (-1.61%)` | `7.00 <0.00> (ø)` | |
   | 
[...server/core/analysis/metrics/ErrorRateMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9FcnJvclJhdGVNZXRyaWNzLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...oap/server/core/browser/source/BrowserAppPerf.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFBlcmYuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...re/browser/source/BrowserAppSingleVersionPerf.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFNpbmdsZVZlcnNpb25QZXJmLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh)
 | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | |
   | 
[...ider/parser/errorlog/BrowserErrorLogDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9Ccm93c2VyRXJyb3JMb2dEZWNvcmF0b3IuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ser/provider/parser/errorlog/ErrorLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9FcnJvckxvZ0FuYWx5emVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

[GitBox]

codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) 
Report
   > Merging 
[#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc)
 will **decrease** coverage by `0.13%`.
   > The diff coverage is `57.37%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5276  +/-   ##
   
   - Coverage 53.16%   53.02%   -0.14% 
   - Complexity 3159 3199  +40 
   
 Files   816  830  +14 
 Lines 2045020885 +435 
 Branches   1969 2029  +60 
   
   + Hits  1087211075 +203 
   - Misses 8697 8903 +206 
   - Partials881  907  +26 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==)
 | `56.75% <0.00%> (-1.58%)` | `18.00 <2.00> (ø)` | |
   | 
[...skywalking/apm/agent/core/plugin/PluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkRlZmluZS5qYXZh)
 | `64.28% <0.00%> (-4.95%)` | `3.00 <0.00> (ø)` | |
   | 
[.../agent/core/plugin/match/ClassAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL0NsYXNzQW5ub3RhdGlvbk1hdGNoLmphdmE=)
 | `80.00% <ø> (ø)` | `7.00 <0.00> (ø)` | |
   | 
[.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==)
 | `63.17% <ø> (+0.21%)` | `29.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh)
 | `76.62% <0.00%> (-6.48%)` | `26.00 <0.00> (ø)` | |
   | 
[...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==)
 | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...a/org/apache/skywalking/oap/server/core/Const.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29uc3QuamF2YQ==)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [93 
more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=continue).
   > **Legend** - [Click 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

[GitBox]

codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) 
Report
   > Merging 
[#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc)
 will **decrease** coverage by `0.12%`.
   > The diff coverage is `57.37%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5276  +/-   ##
   
   - Coverage 53.16%   53.03%   -0.13% 
   - Complexity 3159 3199  +40 
   
 Files   816  829  +13 
 Lines 2045020881 +431 
 Branches   1969 2029  +60 
   
   + Hits  1087211075 +203 
   - Misses 8697 8899 +202 
   - Partials881  907  +26 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==)
 | `56.75% <0.00%> (-1.58%)` | `18.00 <2.00> (ø)` | |
   | 
[...skywalking/apm/agent/core/plugin/PluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkRlZmluZS5qYXZh)
 | `64.28% <0.00%> (-4.95%)` | `3.00 <0.00> (ø)` | |
   | 
[.../agent/core/plugin/match/ClassAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL0NsYXNzQW5ub3RhdGlvbk1hdGNoLmphdmE=)
 | `80.00% <ø> (ø)` | `7.00 <0.00> (ø)` | |
   | 
[.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==)
 | `63.17% <ø> (+0.21%)` | `29.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh)
 | `76.62% <0.00%> (-6.48%)` | `26.00 <0.00> (ø)` | |
   | 
[...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==)
 | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...a/org/apache/skywalking/oap/server/core/Const.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29uc3QuamF2YQ==)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [92 
more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=continue).
   > **Legend** - [Click 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

[GitBox]

codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) 
Report
   > Merging 
[#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc)
 will **decrease** coverage by `0.10%`.
   > The diff coverage is `57.37%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5276  +/-   ##
   
   - Coverage 53.16%   53.05%   -0.11% 
   - Complexity 3159 3199  +40 
   
 Files   816  827  +11 
 Lines 2045020875 +425 
 Branches   1969 2029  +60 
   
   + Hits  1087211075 +203 
   - Misses 8697 8893 +196 
   - Partials881  907  +26 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==)
 | `56.75% <0.00%> (-1.58%)` | `18.00 <2.00> (ø)` | |
   | 
[...skywalking/apm/agent/core/plugin/PluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkRlZmluZS5qYXZh)
 | `64.28% <0.00%> (-4.95%)` | `3.00 <0.00> (ø)` | |
   | 
[.../agent/core/plugin/match/ClassAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL0NsYXNzQW5ub3RhdGlvbk1hdGNoLmphdmE=)
 | `80.00% <ø> (ø)` | `7.00 <0.00> (ø)` | |
   | 
[.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==)
 | `63.17% <ø> (+0.21%)` | `29.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh)
 | `76.62% <0.00%> (-6.48%)` | `26.00 <0.00> (ø)` | |
   | 
[...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==)
 | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...a/org/apache/skywalking/oap/server/core/Const.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29uc3QuamF2YQ==)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [90 
more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=continue).
   > **Legend** - [Click 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

[GitBox]

codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) 
Report
   > Merging 
[#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc)
 will **decrease** coverage by `0.11%`.
   > The diff coverage is `57.37%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5276  +/-   ##
   
   - Coverage 53.16%   53.04%   -0.12% 
   - Complexity 3159 3197  +38 
   
 Files   816  827  +11 
 Lines 2045020875 +425 
 Branches   1969 2029  +60 
   
   + Hits  1087211073 +201 
   - Misses 8697 8895 +198 
   - Partials881  907  +26 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==)
 | `56.75% <0.00%> (-1.58%)` | `18.00 <2.00> (ø)` | |
   | 
[...skywalking/apm/agent/core/plugin/PluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkRlZmluZS5qYXZh)
 | `64.28% <0.00%> (-4.95%)` | `3.00 <0.00> (ø)` | |
   | 
[.../agent/core/plugin/match/ClassAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL0NsYXNzQW5ub3RhdGlvbk1hdGNoLmphdmE=)
 | `80.00% <ø> (ø)` | `7.00 <0.00> (ø)` | |
   | 
[.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==)
 | `63.17% <ø> (+0.21%)` | `29.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh)
 | `76.62% <0.00%> (-6.48%)` | `26.00 <0.00> (ø)` | |
   | 
[...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==)
 | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...a/org/apache/skywalking/oap/server/core/Const.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29uc3QuamF2YQ==)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [91 
more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=continue).
   > **Legend** - [Click 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

[GitBox]

codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) 
Report
   > Merging 
[#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc)
 will **decrease** coverage by `0.10%`.
   > The diff coverage is `57.37%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5276  +/-   ##
   
   - Coverage 53.16%   53.05%   -0.11% 
   - Complexity 3159 3199  +40 
   
 Files   816  827  +11 
 Lines 2045020875 +425 
 Branches   1969 2029  +60 
   
   + Hits  1087211075 +203 
   - Misses 8697 8893 +196 
   - Partials881  907  +26 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==)
 | `56.75% <0.00%> (-1.58%)` | `18.00 <2.00> (ø)` | |
   | 
[...skywalking/apm/agent/core/plugin/PluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkRlZmluZS5qYXZh)
 | `64.28% <0.00%> (-4.95%)` | `3.00 <0.00> (ø)` | |
   | 
[.../agent/core/plugin/match/ClassAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL0NsYXNzQW5ub3RhdGlvbk1hdGNoLmphdmE=)
 | `80.00% <ø> (ø)` | `7.00 <0.00> (ø)` | |
   | 
[.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==)
 | `63.17% <ø> (+0.21%)` | `29.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh)
 | `76.62% <0.00%> (-6.48%)` | `26.00 <0.00> (ø)` | |
   | 
[...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==)
 | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...a/org/apache/skywalking/oap/server/core/Const.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29uc3QuamF2YQ==)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [90 
more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=continue).
   > **Legend** - [Click 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

[GitBox]

codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) 
Report
   > Merging 
[#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc)
 will **decrease** coverage by `11.24%`.
   > The diff coverage is `55.38%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5276   +/-   ##
   =
   - Coverage 53.16%   41.91%   -11.25% 
   + Complexity 3159 2476  -683 
   =
 Files   816  826   +10 
 Lines 2045020859  +409 
 Branches   1969 2025   +56 
   =
   - Hits  10872 8743 -2129 
   - Misses 869711469 +2772 
   + Partials881  647  -234 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <0.00%> (-98.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-79.25%)` | `0.00 <0.00> (ø)` | |
   | 
[...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==)
 | `0.00% <0.00%> (-58.34%)` | `0.00 <0.00> (-18.00)` | |
   | 
[...he/skywalking/apm/agent/core/plugin/PluginCfg.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkNmZy5qYXZh)
 | `0.00% <0.00%> (-82.36%)` | `0.00 <0.00> (-6.00)` | |
   | 
[...skywalking/apm/agent/core/plugin/PluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkRlZmluZS5qYXZh)
 | `0.00% <0.00%> (-69.24%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../agent/core/plugin/match/ClassAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL0NsYXNzQW5ub3RhdGlvbk1hdGNoLmphdmE=)
 | `0.00% <ø> (-80.00%)` | `0.00 <0.00> (-7.00)` | |
   | 
[.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==)
 | `63.17% <ø> (+0.21%)` | `29.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh)
 | `76.62% <0.00%> (-6.48%)` | `26.00 <0.00> (ø)` | |
   | ... and [235 
more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=continue).
   > **Legend** - [Click here to 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

[GitBox]

codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

[GitBox]

codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) 
Report
   > Merging 
[#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc)
 will **decrease** coverage by `1.22%`.
   > The diff coverage is `56.55%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5276  +/-   ##
   
   - Coverage 53.16%   51.93%   -1.23% 
   + Complexity 3159 3155   -4 
   
 Files   816  827  +11 
 Lines 2045020875 +425 
 Branches   1969 2029  +60 
   
   - Hits  1087210842  -30 
   - Misses 8697 9144 +447 
   - Partials881  889   +8 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==)
 | `56.75% <0.00%> (-1.58%)` | `18.00 <2.00> (ø)` | |
   | 
[...skywalking/apm/agent/core/plugin/PluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkRlZmluZS5qYXZh)
 | `64.28% <0.00%> (-4.95%)` | `3.00 <0.00> (ø)` | |
   | 
[.../agent/core/plugin/match/ClassAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL0NsYXNzQW5ub3RhdGlvbk1hdGNoLmphdmE=)
 | `80.00% <ø> (ø)` | `7.00 <0.00> (ø)` | |
   | 
[.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==)
 | `63.17% <ø> (+0.21%)` | `29.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh)
 | `76.62% <0.00%> (-6.48%)` | `26.00 <0.00> (ø)` | |
   | 
[...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==)
 | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...a/org/apache/skywalking/oap/server/core/Const.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29uc3QuamF2YQ==)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [108 
more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=continue).
   > **Legend** - [Click 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

[GitBox]

codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) 
Report
   > Merging 
[#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc)
 will **decrease** coverage by `13.30%`.
   > The diff coverage is `55.05%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5276   +/-   ##
   =
   - Coverage 53.16%   39.85%   -13.31% 
   + Complexity 3159 2380  -779 
   =
 Files   816  825+9 
 Lines 2045020797  +347 
 Branches   1969 2024   +55 
   =
   - Hits  10872 8289 -2583 
   - Misses 869711891 +3194 
   + Partials881  617  -264 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <0.00%> (-98.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-79.25%)` | `0.00 <0.00> (ø)` | |
   | 
[...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==)
 | `0.00% <0.00%> (-58.34%)` | `0.00 <0.00> (-18.00)` | |
   | 
[...he/skywalking/apm/agent/core/plugin/PluginCfg.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkNmZy5qYXZh)
 | `0.00% <0.00%> (-82.36%)` | `0.00 <0.00> (-6.00)` | |
   | 
[...skywalking/apm/agent/core/plugin/PluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkRlZmluZS5qYXZh)
 | `0.00% <0.00%> (-69.24%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../agent/core/plugin/match/ClassAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL0NsYXNzQW5ub3RhdGlvbk1hdGNoLmphdmE=)
 | `0.00% <ø> (-80.00%)` | `0.00 <0.00> (-7.00)` | |
   | 
[.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==)
 | `63.17% <ø> (+0.21%)` | `29.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh)
 | `76.62% <0.00%> (-6.48%)` | `26.00 <0.00> (ø)` | |
   | ... and [255 
more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=continue).
   > **Legend** - [Click here to 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

[GitBox]

codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) 
Report
   > Merging 
[#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc)
 will **decrease** coverage by `11.19%`.
   > The diff coverage is `55.38%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5276   +/-   ##
   =
   - Coverage 53.16%   41.96%   -11.20% 
   + Complexity 3159 2476  -683 
   =
 Files   816  825+9 
 Lines 2045020833  +383 
 Branches   1969 2025   +56 
   =
   - Hits  10872 8743 -2129 
   - Misses 869711443 +2746 
   + Partials881  647  -234 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <0.00%> (-98.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-79.25%)` | `0.00 <0.00> (ø)` | |
   | 
[...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==)
 | `0.00% <0.00%> (-58.34%)` | `0.00 <0.00> (-18.00)` | |
   | 
[...he/skywalking/apm/agent/core/plugin/PluginCfg.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkNmZy5qYXZh)
 | `0.00% <0.00%> (-82.36%)` | `0.00 <0.00> (-6.00)` | |
   | 
[...skywalking/apm/agent/core/plugin/PluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkRlZmluZS5qYXZh)
 | `0.00% <0.00%> (-69.24%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../agent/core/plugin/match/ClassAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL0NsYXNzQW5ub3RhdGlvbk1hdGNoLmphdmE=)
 | `0.00% <ø> (-80.00%)` | `0.00 <0.00> (-7.00)` | |
   | 
[.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==)
 | `63.17% <ø> (+0.21%)` | `29.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh)
 | `76.62% <0.00%> (-6.48%)` | `26.00 <0.00> (ø)` | |
   | ... and [234 
more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=continue).
   > **Legend** - [Click here to 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

[GitBox]

codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) 
Report
   > Merging 
[#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc)
 will **decrease** coverage by `13.24%`.
   > The diff coverage is `57.36%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5276   +/-   ##
   =
   - Coverage 53.16%   39.91%   -13.25% 
   + Complexity 3159 2331  -828 
   =
 Files   816  808-8 
 Lines 2045020314  -136 
 Branches   1969 1985   +16 
   =
   - Hits  10872 8109 -2763 
   - Misses 869711597 +2900 
   + Partials881  608  -273 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <0.00%> (-98.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-79.25%)` | `0.00 <0.00> (ø)` | |
   | 
[...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==)
 | `0.00% <0.00%> (-58.34%)` | `0.00 <0.00> (-18.00)` | |
   | 
[...he/skywalking/apm/agent/core/plugin/PluginCfg.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkNmZy5qYXZh)
 | `0.00% <0.00%> (-82.36%)` | `0.00 <0.00> (-6.00)` | |
   | 
[...skywalking/apm/agent/core/plugin/PluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkRlZmluZS5qYXZh)
 | `0.00% <0.00%> (-69.24%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../agent/core/plugin/match/ClassAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL0NsYXNzQW5ub3RhdGlvbk1hdGNoLmphdmE=)
 | `0.00% <ø> (-80.00%)` | `0.00 <0.00> (-7.00)` | |
   | 
[.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==)
 | `63.17% <ø> (+0.21%)` | `29.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh)
 | `76.62% <0.00%> (-6.48%)` | `26.00 <0.00> (ø)` | |
   | ... and [263 
more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=continue).
   > **Legend** - [Click here to 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

[GitBox]

codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) 
Report
   > Merging 
[#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc)
 will **decrease** coverage by `13.32%`.
   > The diff coverage is `57.36%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5276   +/-   ##
   =
   - Coverage 53.16%   39.84%   -13.33% 
   + Complexity 3159 2331  -828 
   =
 Files   816  809-7 
 Lines 2045020353   -97 
 Branches   1969 1986   +17 
   =
   - Hits  10872 8109 -2763 
   - Misses 869711636 +2939 
   + Partials881  608  -273 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <0.00%> (-98.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-79.25%)` | `0.00 <0.00> (ø)` | |
   | 
[...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==)
 | `0.00% <0.00%> (-58.34%)` | `0.00 <0.00> (-18.00)` | |
   | 
[...he/skywalking/apm/agent/core/plugin/PluginCfg.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkNmZy5qYXZh)
 | `0.00% <0.00%> (-82.36%)` | `0.00 <0.00> (-6.00)` | |
   | 
[...skywalking/apm/agent/core/plugin/PluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkRlZmluZS5qYXZh)
 | `0.00% <0.00%> (-69.24%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../agent/core/plugin/match/ClassAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL0NsYXNzQW5ub3RhdGlvbk1hdGNoLmphdmE=)
 | `0.00% <ø> (-80.00%)` | `0.00 <0.00> (-7.00)` | |
   | 
[.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==)
 | `63.17% <ø> (+0.21%)` | `29.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh)
 | `76.62% <0.00%> (-6.48%)` | `26.00 <0.00> (ø)` | |
   | ... and [262 
more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=continue).
   > **Legend** - [Click here to 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

[GitBox]

codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) 
Report
   > Merging 
[#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc)
 will **decrease** coverage by `14.87%`.
   > The diff coverage is `49.56%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5276   +/-   ##
   =
   - Coverage 53.16%   38.28%   -14.88% 
   + Complexity 3159 2247  -912 
   =
 Files   816  808-8 
 Lines 2045020311  -139 
 Branches   1969 1985   +16 
   =
   - Hits  10872  -3095 
   - Misses 869711927 +3230 
   + Partials881  607  -274 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <0.00%> (-98.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-79.25%)` | `0.00 <0.00> (ø)` | |
   | 
[...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==)
 | `0.00% <0.00%> (-58.34%)` | `0.00 <0.00> (-18.00)` | |
   | 
[...he/skywalking/apm/agent/core/plugin/PluginCfg.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkNmZy5qYXZh)
 | `0.00% <0.00%> (-82.36%)` | `0.00 <0.00> (-6.00)` | |
   | 
[...skywalking/apm/agent/core/plugin/PluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkRlZmluZS5qYXZh)
 | `0.00% <0.00%> (-69.24%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../agent/core/plugin/match/ClassAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL0NsYXNzQW5ub3RhdGlvbk1hdGNoLmphdmE=)
 | `0.00% <ø> (-80.00%)` | `0.00 <0.00> (-7.00)` | |
   | 
[.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==)
 | `63.17% <ø> (+0.21%)` | `29.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh)
 | `76.62% <0.00%> (-6.48%)` | `26.00 <0.00> (ø)` | |
   | ... and [293 
more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=continue).
   > **Legend** - [Click here to 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

[GitBox]

codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

[GitBox]

codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) 
Report
   > Merging 
[#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc)
 will **decrease** coverage by `26.51%`.
   > The diff coverage is `36.22%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5276   +/-   ##
   =
   - Coverage 53.16%   26.64%   -26.52% 
   + Complexity 3159 1668 -1491 
   =
 Files   816  806   -10 
 Lines 2045020115  -335 
 Branches   1969 1937   -32 
   =
   - Hits  10872 5360 -5512 
   - Misses 869714368 +5671 
   + Partials881  387  -494 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==)
 | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <0.00%> (-98.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-79.25%)` | `0.00 <0.00> (ø)` | |
   | 
[...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==)
 | `0.00% <0.00%> (-58.34%)` | `0.00 <0.00> (-18.00)` | |
   | 
[...he/skywalking/apm/agent/core/plugin/PluginCfg.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkNmZy5qYXZh)
 | `0.00% <0.00%> (-82.36%)` | `0.00 <0.00> (-6.00)` | |
   | 
[...skywalking/apm/agent/core/plugin/PluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkRlZmluZS5qYXZh)
 | `0.00% <0.00%> (-69.24%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../agent/core/plugin/match/ClassAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL0NsYXNzQW5ub3RhdGlvbk1hdGNoLmphdmE=)
 | `0.00% <ø> (-80.00%)` | `0.00 <0.00> (-7.00)` | |
   | 
[.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==)
 | `63.17% <ø> (+0.21%)` | `29.00 <0.00> (ø)` | |
   | 
[...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh)
 | `76.62% <0.00%> (-6.48%)` | `26.00 <0.00> (ø)` | |
   | ... and [398 
more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=continue).
   > **Legend** - [Click here to 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

[GitBox]

codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

[GitBox]

codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) 
Report
   > Merging 
[#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc)
 will **decrease** coverage by `53.16%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #5276   +/-   ##
   
   - Coverage 53.16%   0.00%   -53.17% 
   
 Files   816 167  -649 
 Lines 204504076-16374 
 Branches   1969 477 -1492 
   
   - Hits  10872   0-10872 
   + Misses 86974076 -4621 
   + Partials881   0  -881 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <0.00%> (-98.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-79.25%)` | `0.00 <0.00> (ø)` | |
   | 
[...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==)
 | `0.00% <0.00%> (-58.34%)` | `0.00 <0.00> (-18.00)` | |
   | 
[...he/skywalking/apm/agent/core/plugin/PluginCfg.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkNmZy5qYXZh)
 | `0.00% <0.00%> (-82.36%)` | `0.00 <0.00> (-6.00)` | |
   | 
[...skywalking/apm/agent/core/plugin/PluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkRlZmluZS5qYXZh)
 | `0.00% <0.00%> (-69.24%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../agent/core/plugin/match/ClassAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL0NsYXNzQW5ub3RhdGlvbk1hdGNoLmphdmE=)
 | `0.00% <ø> (-80.00%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [726 
more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=continue).
 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

[GitBox]

codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) 
Report
   > Merging 
[#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc)
 will **decrease** coverage by `53.16%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #5276   +/-   ##
   
   - Coverage 53.16%   0.00%   -53.17% 
   
 Files   816 166  -650 
 Lines 204504070-16380 
 Branches   1969 477 -1492 
   
   - Hits  10872   0-10872 
   + Misses 86974070 -4627 
   + Partials881   0  -881 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <0.00%> (-98.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-79.25%)` | `0.00 <0.00> (ø)` | |
   | 
[...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==)
 | `0.00% <0.00%> (-58.34%)` | `0.00 <0.00> (-18.00)` | |
   | 
[...he/skywalking/apm/agent/core/plugin/PluginCfg.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkNmZy5qYXZh)
 | `0.00% <0.00%> (-82.36%)` | `0.00 <0.00> (-6.00)` | |
   | 
[...skywalking/apm/agent/core/plugin/PluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkRlZmluZS5qYXZh)
 | `0.00% <0.00%> (-69.24%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../agent/core/plugin/match/ClassAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL0NsYXNzQW5ub3RhdGlvbk1hdGNoLmphdmE=)
 | `0.00% <ø> (-80.00%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [727 
more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=continue).
 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

[GitBox]

codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) 
Report
   > Merging 
[#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc)
 will **decrease** coverage by `53.16%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #5276   +/-   ##
   
   - Coverage 53.16%   0.00%   -53.17% 
   
 Files   816 154  -662 
 Lines 204503823-16627 
 Branches   1969 448 -1521 
   
   - Hits  10872   0-10872 
   + Misses 86973823 -4874 
   + Partials881   0  -881 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <0.00%> (-98.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-79.25%)` | `0.00 <0.00> (ø)` | |
   | 
[...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==)
 | `0.00% <0.00%> (-58.34%)` | `0.00 <0.00> (-18.00)` | |
   | 
[...he/skywalking/apm/agent/core/plugin/PluginCfg.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkNmZy5qYXZh)
 | `0.00% <0.00%> (-82.36%)` | `0.00 <0.00> (-6.00)` | |
   | 
[...skywalking/apm/agent/core/plugin/PluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkRlZmluZS5qYXZh)
 | `0.00% <0.00%> (-69.24%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../agent/core/plugin/match/ClassAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL0NsYXNzQW5ub3RhdGlvbk1hdGNoLmphdmE=)
 | `0.00% <ø> (-80.00%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [735 
more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=continue).
 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

[GitBox]

codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) 
Report
   > Merging 
[#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc)
 will **decrease** coverage by `53.16%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #5276   +/-   ##
   
   - Coverage 53.16%   0.00%   -53.17% 
   
 Files   816 164  -652 
 Lines 204504058-16392 
 Branches   1969 477 -1492 
   
   - Hits  10872   0-10872 
   + Misses 86974058 -4639 
   + Partials881   0  -881 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <0.00%> (-98.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-79.25%)` | `0.00 <0.00> (ø)` | |
   | 
[...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==)
 | `0.00% <0.00%> (-58.34%)` | `0.00 <0.00> (-18.00)` | |
   | 
[...he/skywalking/apm/agent/core/plugin/PluginCfg.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkNmZy5qYXZh)
 | `0.00% <0.00%> (-82.36%)` | `0.00 <0.00> (-6.00)` | |
   | 
[...skywalking/apm/agent/core/plugin/PluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkRlZmluZS5qYXZh)
 | `0.00% <0.00%> (-69.24%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../agent/core/plugin/match/ClassAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL0NsYXNzQW5ub3RhdGlvbk1hdGNoLmphdmE=)
 | `0.00% <ø> (-80.00%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [727 
more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=continue).
 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

[GitBox]

codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) 
Report
   > Merging 
[#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc)
 will **decrease** coverage by `53.16%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #5276   +/-   ##
   
   - Coverage 53.16%   0.00%   -53.17% 
   
 Files   816 154  -662 
 Lines 204503815-16635 
 Branches   1969 448 -1521 
   
   - Hits  10872   0-10872 
   + Misses 86973815 -4882 
   + Partials881   0  -881 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `0.00% <0.00%> (-98.67%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-79.25%)` | `0.00 <0.00> (ø)` | |
   | 
[...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==)
 | `0.00% <0.00%> (-58.34%)` | `0.00 <0.00> (-18.00)` | |
   | 
[...he/skywalking/apm/agent/core/plugin/PluginCfg.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkNmZy5qYXZh)
 | `0.00% <0.00%> (-82.36%)` | `0.00 <0.00> (-6.00)` | |
   | 
[...skywalking/apm/agent/core/plugin/PluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkRlZmluZS5qYXZh)
 | `0.00% <0.00%> (-69.24%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../agent/core/plugin/match/ClassAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL0NsYXNzQW5ub3RhdGlvbk1hdGNoLmphdmE=)
 | `0.00% <ø> (-80.00%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [736 
more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=continue).
 

[GitHub] [skywalking] hanahmily commented on a change in pull request #5276: Add labeled metrics to alarm system

[GitBox]

hanahmily commented on a change in pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#discussion_r471810755



##
File path: docs/en/setup/backend/backend-alarm.md
##
@@ -24,6 +24,12 @@ Alarm rule is constituted by following keys
 - **Exclude names**. The following entity names are excluded in this rule. 
Please follow [Entity name define](#entity-name).
 - **Include names regex**. Provide a regex to include the entity names. If 
both setting the include name list and include name regex, both rules will take 
effect.
 - **Exclude names regex**. Provide a regex to exclude the exclude names. If 
both setting the exclude name list and exclude name regex, both rules will take 
effect.
+- **Include labels**. The following labels of the metric are included in this 
rule.
+- **Exclude labels**. The following labels of the metric are excluded in this 
rule.
+- **Include labels regex**. Provide a regex to include labels. If both setting 
the include label list and include label regex, both rules will take effect.
+- **Exclude labels regex**. Provide a regex to exclude labels. If both setting 
the exclude label list and exclude label regex, both rules will take effect.
+*The settings of labels is required by meter-system which intends to store 
metrics from label-system platform, just like Prometheus, Micrometer, etc.
+The function supports the above four settings should implement 
`LabeledValueHolder`.*

Review comment:
   done

##
File path: 
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RunningRule.java
##
@@ -168,6 +161,46 @@ public void in(MetaInAlarm meta, Metrics metrics) {
 }
 }
 
+private boolean validate(String target, List includeList, 
List excludeList,

Review comment:
   done





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[skywalking] branch labeled-alarm updated (3ec59c3 -> 04374d5)

[hanahmily]

This is an automated email from the ASF dual-hosted git repository.

hanahmily pushed a change to branch labeled-alarm
in repository https://gitbox.apache.org/repos/asf/skywalking.git.


from 3ec59c3  Merge branch 'master' into labeled-alarm
 add b8e5ff5  Remove Buffer redundant strategy judgment code. (#5277)
 add 29a9d1c  Add iQIYI.COM at the powered by page (#5279)
 add b1305ba  fix：fix NullPointerException for replaceParam when message is 
null (#5280)
 add 69297b9  Support Apache ShardingSphere-Elasticjob (#5153)
 add fdd242e  Update HttpClientExecuteInterceptor.java (#5283)
 add 2df3c68  Super Size Dataset record index  es rolling step (#5282)
 add e37fc2e  Support spring-kafka (#5254)
 add 5a2c91c  [optimize] Raw use of parameterized class (#5286)
 add 7f7e96b  [IMPORTANT] Query traces with tags as condition (#5270)
 add ecc18b9  Support !=, like filter expressions in OAL (#5269)
 add 3d0522f  Add OALListener missing code (#5296)
 add 532384e  fix bug when extend the scope and recommend to start with 
1 or the scope greater than 1000 (#5299)
 add a7e7783  disable kafka property in agent.config (#5305)
 add d3e0dbb  Remove duplicate settings telemetry related context id in 
nacos. (#5306)
 add abf  Support @KafkaPollAndInvoke annotation to replace @Trace when 
just using the Kafka scenario agent plugin (#5304)
 add 522e095  Update elasticsearch Python Plugin Component (#5303)
 add b588b5f  Fix spring-kafka test unstable (#5310)
 add 68317dd  Add agent plugins selector (#5293)
 add 391dcbc  ui sync (#5312)
 add 197ef1e  Improve Es trace basic  query performance (#5132)
 add 0c1c390  Correct the yaml config. (#5318)
 add 68eba15  Add latest function (#5321)
 add f731c25  Miss topic in the KafkaServiceManagementServiceClient (#5326)
 add a6e45d0  spring annotation enhance (#5320)
 add ed71efd  Fix spring-kafka test unstable (#5313)
 add b173cde  Upgrade the byte-buddy to 1.10.14 with asm (#5338)
 add 6000ee7  Merge branch 'master' into labeled-alarm
 add 950a6a8  Fix some nits
 add 04374d5  Merge branch 'labeled-alarm' of github.com:apache/skywalking 
into labeled-alarm

No new revisions were added by this update.

Summary of changes:
 .github/workflows/ci-it.yaml   |   2 +
 .github/workflows/plugins-test.0.yaml  |   1 +
 .github/workflows/plugins-test.3.yaml  |   2 +
 .gitignore |   7 +-
 apm-application-toolkit/apm-toolkit-kafka/pom.xml  |  33 
 .../apm/toolkit/kafka/KafkaPollAndInvoke.java  |  12 +-
 .../apm/toolkit/trace/CallableWrapper.java |   6 +-
 .../apm/toolkit/trace/SupplierWrapper.java |   4 +-
 apm-application-toolkit/pom.xml|   1 +
 .../apm/commons/datacarrier/buffer/Buffer.java |  12 +-
 .../network/trace/component/ComponentsDefine.java  |   2 +
 apm-sniffer/apm-agent-core/pom.xml |   2 +-
 .../skywalking/apm/agent/core/conf/Config.java |   5 +
 .../apm/agent/core/logging/core/PatternLogger.java |   3 +
 .../apm/agent/core/plugin/PluginCfg.java   |   6 +-
 .../apm/agent/core/plugin/PluginDefine.java|   4 +
 .../apm/agent/core/plugin/PluginSelector.java  |  48 ++
 .../core/plugin/match/ClassAnnotationMatch.java|   2 +-
 .../apm/agent/core/plugin/match/RegexMatch.java|  67 
 .../apm/agent/core/plugin/PluginSelectorTest.java  |  57 +++
 .../apm/agent/core/plugin/match/MatchTest.java |  84 ++
 .../core/plugin/match/MatchTestAnnotation.java |  12 +-
 .../pom.xml|  24 +--
 .../elasticjob/ElasticJobExecutorInterceptor.java  |  59 +++
 .../define/ElasticJobExecutorInstrumentation.java  |  74 +
 .../src/main/resources/skywalking-plugin.def   |   7 +-
 .../v3/HttpClientExecuteInterceptor.java   |   2 +-
 .../{kafka-plugin => kafka-commons}/pom.xml|  14 +-
 .../apm/plugin/kafka/CallbackAdapter.java  |   0
 .../AbstractKafkaTemplateInstrumentation.java  |   0
 .../apm/plugin/kafka/define/Constants.java |  11 +-
 .../apm/plugin/kafka/define/InterceptorMethod.java |  48 ++
 .../apm/plugin/kafka/define/KafkaContext.java} |  33 ++--
 apm-sniffer/apm-sdk-plugin/kafka-plugin/pom.xml|  11 +-
 .../apm/plugin/kafka/KafkaConsumerInterceptor.java |  26 +--
 .../src/main/resources/skywalking-plugin.def   |   1 -
 apm-sniffer/apm-sdk-plugin/pom.xml |   2 +
 apm-sniffer/apm-sdk-plugin/spring-plugins/pom.xml  |   1 +
 .../spring-kafka-2.x-plugin}/pom.xml   |  24 ++-
 .../kafka/KafkaTemplateCallbackInterceptor.java|  10 +-
 .../kafka/PollAndInvokeMethodInterceptor.java} |  26 +--
 .../kafka/define/KafkaTemplateInstrumentation.java |   7 +-
 .../define/ListenerConsumerInstrumentation.java}   |  25 ++-
 

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system

[GitBox]

codecov[bot] edited a comment on pull request #5276:
URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) 
Report
   > Merging 
[#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc)
 will **decrease** coverage by `0.21%`.
   > The diff coverage is `19.64%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5276/graphs/tree.svg?width=650=150=pr=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5276  +/-   ##
   
   - Coverage 53.16%   52.94%   -0.22% 
   + Complexity 3159 3153   -6 
   
 Files   816  821   +5 
 Lines 2045020537  +87 
 Branches   1969 1979  +10 
   
   + Hits  1087210874   +2 
   - Misses 8697 8777  +80 
   - Partials881  886   +5 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==)
 | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh)
 | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: |
   | 
[...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=)
 | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
   | 
[...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh)
 | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | |
   | 
[...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==)
 | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | |
   | 
[...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeUVzN0RBTy5qYXZh)
 | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
   | 
[...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=)
 | `62.71% <0.00%> (-5.09%)` | `10.00% <0.00%> (-2.00%)` | |
   | 
[...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==)
 | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | |
   | 
[...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==)
 | `82.35% <0.00%> (-2.95%)` |