[GitHub] [skywalking] wu-sheng merged pull request #5681: Fix inconsistent logic in PrefixMatch
wu-sheng merged pull request #5681: URL: https://github.com/apache/skywalking/pull/5681 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking] branch master updated: Fix inconsistent logic in PrefixMatch (#5681)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new 45e02ec Fix inconsistent logic in PrefixMatch (#5681)
45e02ec is described below
commit 45e02ec106d8c7ddc2604fcc22a934760ddf8d40
Author: ggndnn
AuthorDate: Sat Oct 17 12:46:10 2020 +0800
Fix inconsistent logic in PrefixMatch (#5681)
Co-authored-by: ggnn
Co-authored-by: kezhenxu94
---
.../org/apache/skywalking/apm/agent/core/plugin/match/PrefixMatch.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/match/PrefixMatch.java
b/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/match/PrefixMatch.java
index 2324539..c6a0a4c 100644
---
a/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/match/PrefixMatch.java
+++
b/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/match/PrefixMatch.java
@@ -44,7 +44,7 @@ public class PrefixMatch implements IndirectMatch {
if (junction == null) {
junction = ElementMatchers.nameStartsWith(prefix);
} else {
-junction =
junction.and(ElementMatchers.nameStartsWith(prefix));
+junction = junction.or(ElementMatchers.nameStartsWith(prefix));
}
}
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5681: Fix inconsistent logic in PrefixMatch
codecov[bot] edited a comment on pull request #5681: URL: https://github.com/apache/skywalking/pull/5681#issuecomment-710738674 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=h1) Report > Merging [#5681](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/06bec028695637f60dc8dda68498587018f0cf6c?el=desc) will **decrease** coverage by `7.74%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5681 +/- ## - Coverage 53.14% 45.39% -7.75% + Complexity 3390 3030 -360 Files 880 887 +7 Lines 2193822018 +80 Branches 2089 2095 +6 - Hits 11659 9996-1663 - Misses 934611184+1838 + Partials933 838 -95 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5681: Fix inconsistent logic in PrefixMatch
codecov[bot] edited a comment on pull request #5681: URL: https://github.com/apache/skywalking/pull/5681#issuecomment-710738674 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=h1) Report > Merging [#5681](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/06bec028695637f60dc8dda68498587018f0cf6c?el=desc) will **decrease** coverage by `5.16%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5681 +/- ## - Coverage 53.14% 47.98% -5.17% + Complexity 3390 3167 -223 Files 880 887 +7 Lines 2193822032 +94 Branches 2089 2096 +7 - Hits 1165910571-1088 - Misses 934610593+1247 + Partials933 868 -65 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | | | [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | | | [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00% <0.00%> (-6.00%)` | | | [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | | | [...m/network/trace/component/command/BaseCommand.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0Jhc2VDb21tYW5kLmphdmE=) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-2.00%)` | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5681: Fix inconsistent logic in PrefixMatch
codecov[bot] edited a comment on pull request #5681: URL: https://github.com/apache/skywalking/pull/5681#issuecomment-710738674 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=h1) Report > Merging [#5681](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/06bec028695637f60dc8dda68498587018f0cf6c?el=desc) will **decrease** coverage by `18.95%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5681 +/- ## = - Coverage 53.14% 34.18% -18.96% + Complexity 3390 2177 -1213 = Files 880 870 -10 Lines 2193821523 -415 Branches 2089 2047 -42 = - Hits 11659 7358 -4301 - Misses 934613614 +4268 + Partials933 551 -382 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [253 more](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree-more) | | -- [Continue to
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5681: Fix inconsistent logic in PrefixMatch
codecov[bot] edited a comment on pull request #5681: URL: https://github.com/apache/skywalking/pull/5681#issuecomment-710738674 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5681: Fix inconsistent logic in PrefixMatch
codecov[bot] edited a comment on pull request #5681: URL: https://github.com/apache/skywalking/pull/5681#issuecomment-710738674 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=h1) Report > Merging [#5681](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/06bec028695637f60dc8dda68498587018f0cf6c?el=desc) will **decrease** coverage by `23.56%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5681 +/- ## = - Coverage 53.14% 29.58% -23.57% + Complexity 3390 1915 -1475 = Files 880 870 -10 Lines 2193821477 -461 Branches 2089 2044 -45 = - Hits 11659 6353 -5306 - Misses 934614646 +5300 + Partials933 478 -455 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [318 more](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree-more) | | -- [Continue to
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5681: Fix inconsistent logic in PrefixMatch
codecov[bot] edited a comment on pull request #5681: URL: https://github.com/apache/skywalking/pull/5681#issuecomment-710738674 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=h1) Report > Merging [#5681](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/06bec028695637f60dc8dda68498587018f0cf6c?el=desc) will **decrease** coverage by `23.59%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5681 +/- ## = - Coverage 53.14% 29.54% -23.60% + Complexity 3390 1912 -1478 = Files 880 870 -10 Lines 2193821477 -461 Branches 2089 2044 -45 = - Hits 11659 6346 -5313 - Misses 934614649 +5303 + Partials933 482 -451 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [321 more](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree-more) | | -- [Continue to
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5681: Fix inconsistent logic in PrefixMatch
codecov[bot] edited a comment on pull request #5681: URL: https://github.com/apache/skywalking/pull/5681#issuecomment-710738674 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=h1) Report > Merging [#5681](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/06bec028695637f60dc8dda68498587018f0cf6c?el=desc) will **decrease** coverage by `23.56%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5681 +/- ## = - Coverage 53.14% 29.58% -23.57% + Complexity 3390 1916 -1474 = Files 880 870 -10 Lines 2193821477 -461 Branches 2089 2044 -45 = - Hits 11659 6354 -5305 - Misses 934614646 +5300 + Partials933 477 -456 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [317 more](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree-more) | | -- [Continue to
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5681: Fix inconsistent logic in PrefixMatch
codecov[bot] edited a comment on pull request #5681: URL: https://github.com/apache/skywalking/pull/5681#issuecomment-710738674 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=h1) Report > Merging [#5681](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/06bec028695637f60dc8dda68498587018f0cf6c?el=desc) will **decrease** coverage by `53.14%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5681 +/- ## - Coverage 53.14% 0.00% -53.15% Files 880 166 -714 Lines 219383944-17994 Branches 2089 446 -1643 - Hits 11659 0-11659 + Misses 93463944 -5402 + Partials933 0 -933 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [864 more](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5681: Fix inconsistent logic in PrefixMatch
codecov[bot] edited a comment on pull request #5681: URL: https://github.com/apache/skywalking/pull/5681#issuecomment-710738674 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5681: Fix inconsistent logic in PrefixMatch
codecov[bot] edited a comment on pull request #5681: URL: https://github.com/apache/skywalking/pull/5681#issuecomment-710738674 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=h1) Report > Merging [#5681](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/06bec028695637f60dc8dda68498587018f0cf6c?el=desc) will **decrease** coverage by `53.14%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5681 +/- ## - Coverage 53.14% 0.00% -53.15% Files 880 165 -715 Lines 219383938-18000 Branches 2089 446 -1643 - Hits 11659 0-11659 + Misses 93463938 -5408 + Partials933 0 -933 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [863 more](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5681: Fix inconsistent logic in PrefixMatch
codecov[bot] edited a comment on pull request #5681: URL: https://github.com/apache/skywalking/pull/5681#issuecomment-710738674 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=h1) Report > Merging [#5681](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/06bec028695637f60dc8dda68498587018f0cf6c?el=desc) will **decrease** coverage by `53.14%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5681 +/- ## - Coverage 53.14% 0.00% -53.15% Files 880 195 -685 Lines 219384542-17396 Branches 2089 520 -1569 - Hits 11659 0-11659 + Misses 93464542 -4804 + Partials933 0 -933 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...lking/apm/agent/core/plugin/match/PrefixMatch.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL1ByZWZpeE1hdGNoLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [894 more](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5681: Fix inconsistent logic in PrefixMatch
codecov[bot] edited a comment on pull request #5681: URL: https://github.com/apache/skywalking/pull/5681#issuecomment-710738674 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=h1) Report > Merging [#5681](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/06bec028695637f60dc8dda68498587018f0cf6c?el=desc) will **decrease** coverage by `53.14%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5681 +/- ## - Coverage 53.14% 0.00% -53.15% Files 880 174 -706 Lines 219384200-17738 Branches 2089 477 -1612 - Hits 11659 0-11659 + Misses 93464200 -5146 + Partials933 0 -933 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [872 more](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5681: Fix inconsistent logic in PrefixMatch
codecov[bot] edited a comment on pull request #5681: URL: https://github.com/apache/skywalking/pull/5681#issuecomment-710738674 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5681: Fix inconsistent logic in PrefixMatch
codecov[bot] edited a comment on pull request #5681: URL: https://github.com/apache/skywalking/pull/5681#issuecomment-710738674 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5681: Fix inconsistent logic in PrefixMatch
codecov[bot] edited a comment on pull request #5681: URL: https://github.com/apache/skywalking/pull/5681#issuecomment-710738674 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=h1) Report > Merging [#5681](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/06bec028695637f60dc8dda68498587018f0cf6c?el=desc) will **decrease** coverage by `53.14%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5681 +/- ## - Coverage 53.14% 0.00% -53.15% Files 880 194 -686 Lines 219384503-17435 Branches 2089 519 -1570 - Hits 11659 0-11659 + Misses 93464503 -4843 + Partials933 0 -933 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...lking/apm/agent/core/plugin/match/PrefixMatch.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL1ByZWZpeE1hdGNoLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [893 more](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5681: Fix inconsistent logic in PrefixMatch
codecov[bot] edited a comment on pull request #5681: URL: https://github.com/apache/skywalking/pull/5681#issuecomment-710738674 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=h1) Report > Merging [#5681](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d86570a88ebe5079898647b74168ab91a9be4a6a?el=desc) will **decrease** coverage by `40.47%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5681 +/- ## - Coverage 40.47% 0.00% -40.48% Files 879 194 -685 Lines 217814503-17278 Branches 2066 519 -1547 - Hits 8816 0 -8816 + Misses122294503 -7726 + Partials736 0 -736 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...lking/apm/agent/core/plugin/match/PrefixMatch.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL1ByZWZpeE1hdGNoLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [862 more](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5681: Fix inconsistent logic in PrefixMatch
codecov[bot] edited a comment on pull request #5681: URL: https://github.com/apache/skywalking/pull/5681#issuecomment-710738674 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #5681: Fix inconsistent logic in PrefixMatch
codecov[bot] commented on pull request #5681: URL: https://github.com/apache/skywalking/pull/5681#issuecomment-710738674 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=h1) Report > Merging [#5681](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d86570a88ebe5079898647b74168ab91a9be4a6a?el=desc) will **decrease** coverage by `40.47%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5681 +/- ## - Coverage 40.47% 0.00% -40.48% Files 879 161 -718 Lines 217813906-17875 Branches 2066 445 -1621 - Hits 8816 0 -8816 + Misses122293906 -8323 + Partials736 0 -736 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [852 more](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5681: Fix inconsistent logic in PrefixMatch
codecov[bot] edited a comment on pull request #5681: URL: https://github.com/apache/skywalking/pull/5681#issuecomment-710738674 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=h1) Report > Merging [#5681](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d86570a88ebe5079898647b74168ab91a9be4a6a?el=desc) will **decrease** coverage by `40.47%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5681 +/- ## - Coverage 40.47% 0.00% -40.48% Files 879 192 -687 Lines 217814489-17292 Branches 2066 519 -1547 - Hits 8816 0 -8816 + Misses122294489 -7740 + Partials736 0 -736 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5681?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...lking/apm/agent/core/plugin/match/PrefixMatch.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL1ByZWZpeE1hdGNoLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [861 more](https://codecov.io/gh/apache/skywalking/pull/5681/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] ggndnn opened a new pull request #5681: Fix inconsistent logic in PrefixMatch
ggndnn opened a new pull request #5681: URL: https://github.com/apache/skywalking/pull/5681 Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ] Improve performance - Related issues ___ ### Bug fix - Bug description. - How to fix? ___ ### New feature or improvement - Describe the details and related test reports. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking] branch master updated: Fix application start duration log "Failed to load class org.slf4j.impl.StaticLoggerBinder." (#5678)
This is an automated email from the ASF dual-hosted git repository.
tanjian pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new 06bec02 Fix application start duration log "Failed to load class
org.slf4j.impl.StaticLoggerBinder." (#5678)
06bec02 is described below
commit 06bec028695637f60dc8dda68498587018f0cf6c
Author: zifeihan
AuthorDate: Sat Oct 17 09:44:42 2020 +0800
Fix application start duration log "Failed to load class
org.slf4j.impl.StaticLoggerBinder." (#5678)
* Fix application start duration log "Failed to load class
"org.slf4j.impl.StaticLoggerBinder"." when use kafka reporter. because kafka
reporter use slf4j-api, but no implementor for slf4j.
* Polishing.
* Adapter slf4j Logger of agent used to skywalking agent Logger.
* Make the comments more accurate.
Co-authored-by: 吴晟 Wu Sheng
---
apm-sniffer/apm-agent-core/pom.xml | 12 +
.../apm/agent/core/logging/api/ILog.java | 10 +
.../apm/agent/core/logging/api/NoopLogger.java | 25 ++
.../agent/core/logging/core/AbstractLogger.java| 37 +++
.../apm/agent/core/logging/core/LogLevel.java | 2 +-
.../org/slf4j/impl/InternalLoggerFactory.java | 49 +++
.../org/slf4j/impl/Slf4jLoggerAdapter.java | 342 +
.../org/slf4j/impl/StaticLoggerBinder.java | 81 +
apm-sniffer/apm-agent/pom.xml | 1 +
docs/en/FAQ/README.md | 1 -
docs/en/FAQ/Too-many-gRPC-logs.md | 8 -
docs/en/setup/service-agent/java-agent/README.md | 4 +-
12 files changed, 560 insertions(+), 12 deletions(-)
diff --git a/apm-sniffer/apm-agent-core/pom.xml
b/apm-sniffer/apm-agent-core/pom.xml
index 8056db3..fff74d5 100644
--- a/apm-sniffer/apm-agent-core/pom.xml
+++ b/apm-sniffer/apm-agent-core/pom.xml
@@ -48,7 +48,10 @@
${shade.package}.${shade.io.opencensus.source}
io.perfmark
${shade.package}.${shade.io.perfmark.source}
+org.slf4j
+
${shade.package}.${shade.org.slf4j.source}
1.18.0
+1.7.25
@@ -113,6 +116,11 @@
jmh-generator-annprocess
test
+
+org.slf4j
+slf4j-api
+${slf4j.version}
+
@@ -179,6 +187,10 @@
${shade.io.perfmark.source}
${shade.io.perfmark.target}
+
+
${shade.org.slf4j.source}
+
${shade.org.slf4j.target}
+
diff --git
a/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/logging/api/ILog.java
b/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/logging/api/ILog.java
index 11db0d0..8f023a9 100644
---
a/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/logging/api/ILog.java
+++
b/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/logging/api/ILog.java
@@ -27,6 +27,8 @@ public interface ILog {
void info(String format, Object... arguments);
+void info(Throwable t, String format, Object... arguments);
+
void warn(String format, Object... arguments);
void warn(Throwable e, String format, Object... arguments);
@@ -43,6 +45,8 @@ public interface ILog {
boolean isErrorEnable();
+boolean isTraceEnabled();
+
void debug(String format);
void debug(String format, Object... arguments);
@@ -50,4 +54,10 @@ public interface ILog {
void debug(Throwable t, String format, Object... arguments);
void error(String format);
+
+void trace(String format);
+
+void trace(String format, Object... arguments);
+
+void trace(Throwable t, String format, Object... arguments);
}
diff --git
a/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/logging/api/NoopLogger.java
b/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/logging/api/NoopLogger.java
index b78fc55..151dbf2 100644
---
a/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/logging/api/NoopLogger.java
+++
b/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/logging/api/NoopLogger.java
@@ -36,6 +36,11 @@ public enum NoopLogger implements ILog {
}
@Override
+public void info(final Throwable t, final String format, final Object...
arguments) {
+
+}
+
+@Override
public void warn(String format, Object... arguments) {
}
@@ -66,6 +71,11 @@ public enum NoopLogger
[GitHub] [skywalking] JaredTan95 merged pull request #5678: Fix application start duration log "Failed to load class org.slf4j.impl.StaticLoggerBinder."
JaredTan95 merged pull request #5678: URL: https://github.com/apache/skywalking/pull/5678 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5661: Add health checker for cluster management module
codecov[bot] edited a comment on pull request #5661: URL: https://github.com/apache/skywalking/pull/5661#issuecomment-708093378 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=h1) Report > Merging [#5661](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `27.08%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5661 +/- ## = - Coverage 53.45% 26.36% -27.09% + Complexity 3412 1737 -1675 = Files 880 874-6 Lines 2192521457 -468 Branches 2089 2023 -66 = - Hits 11719 5657 -6062 - Misses 927015439 +6169 + Partials936 361 -575 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ter/plugin/consul/ClusterModuleConsulProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NsdXN0ZXJNb2R1bGVDb25zdWxQcm92aWRlci5qYXZh) | `12.90% <0.00%> (-1.39%)` | `2.00 <0.00> (ø)` | | | [...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...cluster/plugin/etcd/ClusterModuleEtcdProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvQ2x1c3Rlck1vZHVsZUV0Y2RQcm92aWRlci5qYXZh) | `22.22% <0.00%> (-4.45%)` | `2.00 <0.00> (ø)` | | | [...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...in/kubernetes/ClusterModuleKubernetesProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvQ2x1c3Rlck1vZHVsZUt1YmVybmV0ZXNQcm92aWRlci5qYXZh) | `23.52% <0.00%> (-5.05%)` | `2.00 <0.00> (ø)` | | | [...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `12.90% <0.00%> (-1.39%)` | `2.00 <0.00> (ø)` | | | [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ugin/zookeeper/ClusterModuleZookeeperProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL0NsdXN0ZXJNb2R1bGVab29rZWVwZXJQcm92aWRlci5qYXZh) | `10.00% <0.00%> (-0.64%)` | `3.00
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5661: Add health checker for cluster management module
codecov[bot] edited a comment on pull request #5661: URL: https://github.com/apache/skywalking/pull/5661#issuecomment-708093378 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=h1) Report > Merging [#5661](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `27.08%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5661 +/- ## = - Coverage 53.45% 26.36% -27.09% + Complexity 3412 1737 -1675 = Files 880 874-6 Lines 2192521457 -468 Branches 2089 2023 -66 = - Hits 11719 5657 -6062 - Misses 927015439 +6169 + Partials936 361 -575 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ter/plugin/consul/ClusterModuleConsulProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NsdXN0ZXJNb2R1bGVDb25zdWxQcm92aWRlci5qYXZh) | `12.90% <0.00%> (-1.39%)` | `2.00 <0.00> (ø)` | | | [...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...cluster/plugin/etcd/ClusterModuleEtcdProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvQ2x1c3Rlck1vZHVsZUV0Y2RQcm92aWRlci5qYXZh) | `22.22% <0.00%> (-4.45%)` | `2.00 <0.00> (ø)` | | | [...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...in/kubernetes/ClusterModuleKubernetesProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvQ2x1c3Rlck1vZHVsZUt1YmVybmV0ZXNQcm92aWRlci5qYXZh) | `23.52% <0.00%> (-5.05%)` | `2.00 <0.00> (ø)` | | | [...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `12.90% <0.00%> (-1.39%)` | `2.00 <0.00> (ø)` | | | [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ugin/zookeeper/ClusterModuleZookeeperProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL0NsdXN0ZXJNb2R1bGVab29rZWVwZXJQcm92aWRlci5qYXZh) | `10.00% <0.00%> (-0.64%)` | `3.00
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5661: Add health checker for cluster management module
codecov[bot] edited a comment on pull request #5661: URL: https://github.com/apache/skywalking/pull/5661#issuecomment-708093378 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=h1) Report > Merging [#5661](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `27.07%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5661 +/- ## = - Coverage 53.45% 26.37% -27.08% + Complexity 3412 1737 -1675 = Files 880 872-8 Lines 2192521445 -480 Branches 2089 2023 -66 = - Hits 11719 5657 -6062 - Misses 927015427 +6157 + Partials936 361 -575 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ter/plugin/consul/ClusterModuleConsulProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NsdXN0ZXJNb2R1bGVDb25zdWxQcm92aWRlci5qYXZh) | `12.90% <0.00%> (-1.39%)` | `2.00 <0.00> (ø)` | | | [...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...cluster/plugin/etcd/ClusterModuleEtcdProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvQ2x1c3Rlck1vZHVsZUV0Y2RQcm92aWRlci5qYXZh) | `22.22% <0.00%> (-4.45%)` | `2.00 <0.00> (ø)` | | | [...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...in/kubernetes/ClusterModuleKubernetesProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvQ2x1c3Rlck1vZHVsZUt1YmVybmV0ZXNQcm92aWRlci5qYXZh) | `23.52% <0.00%> (-5.05%)` | `2.00 <0.00> (ø)` | | | [...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `12.90% <0.00%> (-1.39%)` | `2.00 <0.00> (ø)` | | | [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ugin/zookeeper/ClusterModuleZookeeperProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL0NsdXN0ZXJNb2R1bGVab29rZWVwZXJQcm92aWRlci5qYXZh) | `10.00% <0.00%> (-0.64%)` | `3.00
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5661: Add health checker for cluster management module
codecov[bot] edited a comment on pull request #5661: URL: https://github.com/apache/skywalking/pull/5661#issuecomment-708093378 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=h1) Report > Merging [#5661](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `26.96%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5661 +/- ## = - Coverage 53.45% 26.48% -26.97% + Complexity 3412 1737 -1675 = Files 880 866 -14 Lines 2192521360 -565 Branches 2089 2014 -75 = - Hits 11719 5657 -6062 - Misses 927015342 +6072 + Partials936 361 -575 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ter/plugin/consul/ClusterModuleConsulProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NsdXN0ZXJNb2R1bGVDb25zdWxQcm92aWRlci5qYXZh) | `12.90% <0.00%> (-1.39%)` | `2.00 <0.00> (ø)` | | | [...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...cluster/plugin/etcd/ClusterModuleEtcdProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvQ2x1c3Rlck1vZHVsZUV0Y2RQcm92aWRlci5qYXZh) | `22.22% <0.00%> (-4.45%)` | `2.00 <0.00> (ø)` | | | [...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...in/kubernetes/ClusterModuleKubernetesProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvQ2x1c3Rlck1vZHVsZUt1YmVybmV0ZXNQcm92aWRlci5qYXZh) | `23.52% <0.00%> (-5.05%)` | `2.00 <0.00> (ø)` | | | [...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `12.90% <0.00%> (-1.39%)` | `2.00 <0.00> (ø)` | | | [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ugin/zookeeper/ClusterModuleZookeeperProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL0NsdXN0ZXJNb2R1bGVab29rZWVwZXJQcm92aWRlci5qYXZh) | `10.00% <0.00%> (-0.64%)` | `3.00
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5661: Add health checker for cluster management module
codecov[bot] edited a comment on pull request #5661: URL: https://github.com/apache/skywalking/pull/5661#issuecomment-708093378 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=h1) Report > Merging [#5661](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `21.94%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5661 +/- ## = - Coverage 53.45% 31.50% -21.95% + Complexity 3412 1737 -1675 = Files 880 721 -159 Lines 2192517956 -3969 Branches 2089 1634 -455 = - Hits 11719 5657 -6062 - Misses 927011938 +2668 + Partials936 361 -575 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ter/plugin/consul/ClusterModuleConsulProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NsdXN0ZXJNb2R1bGVDb25zdWxQcm92aWRlci5qYXZh) | `12.90% <0.00%> (-1.39%)` | `2.00 <0.00> (ø)` | | | [...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...cluster/plugin/etcd/ClusterModuleEtcdProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvQ2x1c3Rlck1vZHVsZUV0Y2RQcm92aWRlci5qYXZh) | `22.22% <0.00%> (-4.45%)` | `2.00 <0.00> (ø)` | | | [...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...in/kubernetes/ClusterModuleKubernetesProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvQ2x1c3Rlck1vZHVsZUt1YmVybmV0ZXNQcm92aWRlci5qYXZh) | `23.52% <0.00%> (-5.05%)` | `2.00 <0.00> (ø)` | | | [...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `12.90% <0.00%> (-1.39%)` | `2.00 <0.00> (ø)` | | | [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ugin/zookeeper/ClusterModuleZookeeperProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL0NsdXN0ZXJNb2R1bGVab29rZWVwZXJQcm92aWRlci5qYXZh) | `10.00% <0.00%> (-0.64%)` | `3.00
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5661: Add health checker for cluster management module
codecov[bot] edited a comment on pull request #5661: URL: https://github.com/apache/skywalking/pull/5661#issuecomment-708093378 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=h1) Report > Merging [#5661](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `21.41%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5661 +/- ## = - Coverage 53.45% 32.03% -21.42% + Complexity 3412 2076 -1336 = Files 880 879-1 Lines 2192521674 -251 Branches 2089 2056 -33 = - Hits 11719 6944 -4775 - Misses 927014207 +4937 + Partials936 523 -413 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ter/plugin/consul/ClusterModuleConsulProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NsdXN0ZXJNb2R1bGVDb25zdWxQcm92aWRlci5qYXZh) | `12.90% <0.00%> (-1.39%)` | `2.00 <0.00> (ø)` | | | [...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...cluster/plugin/etcd/ClusterModuleEtcdProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvQ2x1c3Rlck1vZHVsZUV0Y2RQcm92aWRlci5qYXZh) | `22.22% <0.00%> (-4.45%)` | `2.00 <0.00> (ø)` | | | [...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...in/kubernetes/ClusterModuleKubernetesProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvQ2x1c3Rlck1vZHVsZUt1YmVybmV0ZXNQcm92aWRlci5qYXZh) | `23.52% <0.00%> (-5.05%)` | `2.00 <0.00> (ø)` | | | [...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `12.90% <0.00%> (-1.39%)` | `2.00 <0.00> (ø)` | | | [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ugin/zookeeper/ClusterModuleZookeeperProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL0NsdXN0ZXJNb2R1bGVab29rZWVwZXJQcm92aWRlci5qYXZh) | `10.00% <0.00%> (-0.64%)` | `3.00
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5661: Add health checker for cluster management module
codecov[bot] edited a comment on pull request #5661: URL: https://github.com/apache/skywalking/pull/5661#issuecomment-708093378 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=h1) Report > Merging [#5661](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `21.49%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5661 +/- ## = - Coverage 53.45% 31.95% -21.50% + Complexity 3412 2076 -1336 = Files 880 881+1 Lines 2192521733 -192 Branches 2089 2063 -26 = - Hits 11719 6944 -4775 - Misses 927014266 +4996 + Partials936 523 -413 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ter/plugin/consul/ClusterModuleConsulProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NsdXN0ZXJNb2R1bGVDb25zdWxQcm92aWRlci5qYXZh) | `12.90% <0.00%> (-1.39%)` | `2.00 <0.00> (ø)` | | | [...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...cluster/plugin/etcd/ClusterModuleEtcdProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvQ2x1c3Rlck1vZHVsZUV0Y2RQcm92aWRlci5qYXZh) | `22.22% <0.00%> (-4.45%)` | `2.00 <0.00> (ø)` | | | [...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...in/kubernetes/ClusterModuleKubernetesProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvQ2x1c3Rlck1vZHVsZUt1YmVybmV0ZXNQcm92aWRlci5qYXZh) | `23.52% <0.00%> (-5.05%)` | `2.00 <0.00> (ø)` | | | [...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `12.90% <0.00%> (-1.39%)` | `2.00 <0.00> (ø)` | | | [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ugin/zookeeper/ClusterModuleZookeeperProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL0NsdXN0ZXJNb2R1bGVab29rZWVwZXJQcm92aWRlci5qYXZh) | `10.00% <0.00%> (-0.64%)` | `3.00
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5661: Add health checker for cluster management module
codecov[bot] edited a comment on pull request #5661: URL: https://github.com/apache/skywalking/pull/5661#issuecomment-708093378 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=h1) Report > Merging [#5661](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `23.69%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5661 +/- ## = - Coverage 53.45% 29.75% -23.70% + Complexity 3412 1941 -1471 = Files 880 878-2 Lines 2192521615 -310 Branches 2089 2051 -38 = - Hits 11719 6432 -5287 - Misses 927014709 +5439 + Partials936 474 -462 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ter/plugin/consul/ClusterModuleConsulProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NsdXN0ZXJNb2R1bGVDb25zdWxQcm92aWRlci5qYXZh) | `12.90% <0.00%> (-1.39%)` | `2.00 <0.00> (ø)` | | | [...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...cluster/plugin/etcd/ClusterModuleEtcdProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvQ2x1c3Rlck1vZHVsZUV0Y2RQcm92aWRlci5qYXZh) | `22.22% <0.00%> (-4.45%)` | `2.00 <0.00> (ø)` | | | [...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...in/kubernetes/ClusterModuleKubernetesProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvQ2x1c3Rlck1vZHVsZUt1YmVybmV0ZXNQcm92aWRlci5qYXZh) | `23.52% <0.00%> (-5.05%)` | `2.00 <0.00> (ø)` | | | [...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `12.90% <0.00%> (-1.39%)` | `2.00 <0.00> (ø)` | | | [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ugin/zookeeper/ClusterModuleZookeeperProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL0NsdXN0ZXJNb2R1bGVab29rZWVwZXJQcm92aWRlci5qYXZh) | `10.00% <0.00%> (-0.64%)` | `3.00
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5661: Add health checker for cluster management module
codecov[bot] edited a comment on pull request #5661: URL: https://github.com/apache/skywalking/pull/5661#issuecomment-708093378 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=h1) Report > Merging [#5661](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `53.45%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5661 +/- ## - Coverage 53.45% 0.00% -53.46% Files 880 173 -707 Lines 219254011-17914 Branches 2089 454 -1635 - Hits 11719 0-11719 + Misses 92704011 -5259 + Partials936 0 -936 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [861 more](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5661: Add health checker for cluster management module
codecov[bot] edited a comment on pull request #5661: URL: https://github.com/apache/skywalking/pull/5661#issuecomment-708093378 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=h1) Report > Merging [#5661](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `53.45%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5661 +/- ## - Coverage 53.45% 0.00% -53.46% Files 880 171 -709 Lines 219253974-17951 Branches 2089 448 -1641 - Hits 11719 0-11719 + Misses 92703974 -5296 + Partials936 0 -936 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [859 more](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5661: Add health checker for cluster management module
codecov[bot] edited a comment on pull request #5661: URL: https://github.com/apache/skywalking/pull/5661#issuecomment-708093378 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=h1) Report > Merging [#5661](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `53.45%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5661 +/- ## - Coverage 53.45% 0.00% -53.46% Files 880 170 -710 Lines 219253970-17955 Branches 2089 448 -1641 - Hits 11719 0-11719 + Misses 92703970 -5300 + Partials936 0 -936 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [858 more](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5661: Add health checker for cluster management module
codecov[bot] edited a comment on pull request #5661: URL: https://github.com/apache/skywalking/pull/5661#issuecomment-708093378 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=h1) Report > Merging [#5661](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `53.45%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5661 +/- ## - Coverage 53.45% 0.00% -53.46% Files 880 168 -712 Lines 219253959-17966 Branches 2089 448 -1641 - Hits 11719 0-11719 + Misses 92703959 -5311 + Partials936 0 -936 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [856 more](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5661: Add health checker for cluster management module
codecov[bot] edited a comment on pull request #5661: URL: https://github.com/apache/skywalking/pull/5661#issuecomment-708093378 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5661: Add health checker for cluster management module
codecov[bot] edited a comment on pull request #5661: URL: https://github.com/apache/skywalking/pull/5661#issuecomment-708093378 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on a change in pull request #5661: Add health checker for cluster management module
xbkaishui commented on a change in pull request #5661:
URL: https://github.com/apache/skywalking/pull/5661#discussion_r506772792
##
File path:
oap-server/server-cluster-plugin/cluster-consul-plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/consul/ConsulCoordinator.java
##
@@ -49,22 +56,32 @@ public ConsulCoordinator(ClusterModuleConsulConfig config,
Consul client) {
@Override
public List queryRemoteNodes() {
-HealthClient healthClient = client.healthClient();
-
-// Discover only "passing" nodes
-List nodes =
healthClient.getHealthyServiceInstances(serviceName).getResponse();
-
List remoteInstances = new ArrayList<>();
-if (CollectionUtils.isNotEmpty(nodes)) {
-nodes.forEach(node -> {
-if (!Strings.isNullOrEmpty(node.getService().getAddress())) {
-Address address = new
Address(node.getService().getAddress(), node.getService().getPort(), false);
-if (address.equals(selfAddress)) {
-address.setSelf(true);
+try {
+HealthClient healthClient = client.healthClient();
+// Discover only "passing" nodes
+List nodes =
healthClient.getHealthyServiceInstances(serviceName).getResponse();
+if (CollectionUtils.isNotEmpty(nodes)) {
+nodes.forEach(node -> {
+if
(!Strings.isNullOrEmpty(node.getService().getAddress())) {
+Address address = new
Address(node.getService().getAddress(), node.getService().getPort(), false);
+if (address.equals(selfAddress)) {
+address.setSelf(true);
+}
+remoteInstances.add(new RemoteInstance(address));
Review comment:
Done, current implementation will ignore coordinator standalone mode
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5661: Add health checker for cluster management module
codecov[bot] edited a comment on pull request #5661: URL: https://github.com/apache/skywalking/pull/5661#issuecomment-708093378 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=h1) Report > Merging [#5661](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `19.67%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5661 +/- ## = - Coverage 53.45% 33.77% -19.68% + Complexity 3412 2145 -1267 = Files 880 876-4 Lines 2192521689 -236 Branches 2089 2070 -19 = - Hits 11719 7325 -4394 - Misses 927013805 +4535 + Partials936 559 -377 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ter/plugin/consul/ClusterModuleConsulProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NsdXN0ZXJNb2R1bGVDb25zdWxQcm92aWRlci5qYXZh) | `12.90% <0.00%> (-1.39%)` | `2.00 <0.00> (ø)` | | | [...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...cluster/plugin/etcd/ClusterModuleEtcdProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvQ2x1c3Rlck1vZHVsZUV0Y2RQcm92aWRlci5qYXZh) | `22.22% <0.00%> (-4.45%)` | `2.00 <0.00> (ø)` | | | [...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...in/kubernetes/ClusterModuleKubernetesProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvQ2x1c3Rlck1vZHVsZUt1YmVybmV0ZXNQcm92aWRlci5qYXZh) | `23.52% <0.00%> (-5.05%)` | `2.00 <0.00> (ø)` | | | [...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `12.90% <0.00%> (-1.39%)` | `2.00 <0.00> (ø)` | | | [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ugin/zookeeper/ClusterModuleZookeeperProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL0NsdXN0ZXJNb2R1bGVab29rZWVwZXJQcm92aWRlci5qYXZh) | `10.00% <0.00%> (-0.64%)` | `3.00
[GitHub] [skywalking] xbkaishui commented on a change in pull request #5661: Add health checker for cluster management module
xbkaishui commented on a change in pull request #5661:
URL: https://github.com/apache/skywalking/pull/5661#discussion_r506766573
##
File path:
oap-server/server-cluster-plugin/cluster-consul-plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/consul/ConsulCoordinator.java
##
@@ -49,22 +56,32 @@ public ConsulCoordinator(ClusterModuleConsulConfig config,
Consul client) {
@Override
public List queryRemoteNodes() {
-HealthClient healthClient = client.healthClient();
-
-// Discover only "passing" nodes
-List nodes =
healthClient.getHealthyServiceInstances(serviceName).getResponse();
-
List remoteInstances = new ArrayList<>();
-if (CollectionUtils.isNotEmpty(nodes)) {
-nodes.forEach(node -> {
-if (!Strings.isNullOrEmpty(node.getService().getAddress())) {
-Address address = new
Address(node.getService().getAddress(), node.getService().getPort(), false);
-if (address.equals(selfAddress)) {
-address.setSelf(true);
+try {
+HealthClient healthClient = client.healthClient();
+// Discover only "passing" nodes
+List nodes =
healthClient.getHealthyServiceInstances(serviceName).getResponse();
+if (CollectionUtils.isNotEmpty(nodes)) {
+nodes.forEach(node -> {
+if
(!Strings.isNullOrEmpty(node.getService().getAddress())) {
+Address address = new
Address(node.getService().getAddress(), node.getService().getPort(), false);
+if (address.equals(selfAddress)) {
+address.setSelf(true);
+}
+remoteInstances.add(new RemoteInstance(address));
Review comment:
got it
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[skywalking-kubernetes] branch refactor updated (56fa25c -> 07cba63)
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch refactor in repository https://gitbox.apache.org/repos/asf/skywalking-kubernetes.git. discard 56fa25c Refactor to unify the versions of SkyWalking add 07cba63 Refactor to unify the versions of SkyWalking This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (56fa25c) \ N -- N -- N refs/heads/refactor (07cba63) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: test/scripts/skywalking-deploy.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
[GitHub] [skywalking-kubernetes] kezhenxu94 opened a new pull request #55: Refactor to unify the usage of different versions of SkyWalking
kezhenxu94 opened a new pull request #55: URL: https://github.com/apache/skywalking-kubernetes/pull/55 I'll add the test case in this PR altogether after you reviewing the basic idea of the refactoring work This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking-kubernetes] 01/01: Refactor to unify the versions of SkyWalking
This is an automated email from the ASF dual-hosted git repository.
kezhenxu94 pushed a commit to branch refactor
in repository https://gitbox.apache.org/repos/asf/skywalking-kubernetes.git
commit 56fa25cc8ce1b3647b1250c53c007d968c82
Author: kezhenxu94
AuthorDate: Sat Oct 17 00:20:04 2020 +0800
Refactor to unify the versions of SkyWalking
---
.gitignore | 1 +
README.md | 97 ++
chart/skywalking/README.md | 2 +-
chart/skywalking/values-es6.yaml | 356 -
chart/skywalking/values-es7.yaml | 26 +++
chart/skywalking/values-my-es.yaml | 27 +++
chart/skywalking/values.yaml | 8 +-
7 files changed, 120 insertions(+), 397 deletions(-)
diff --git a/.gitignore b/.gitignore
index 538c8c5..495004e 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,2 +1,3 @@
.DS_Store
*~
+.idea
diff --git a/README.md b/README.md
index 1fe724e..2c9c52b 100644
--- a/README.md
+++ b/README.md
@@ -6,66 +6,91 @@ Apache SkyWalking Kubernetes
[](https://github.com/apache/skywalking)
[](https://twitter.com/AsfSkyWalking)
-SkyWalking Kubernetes repository provides ways to install and configure
skywalking in a Kubernetes cluster.
-The scripts are written in Helm3.
+SkyWalking Kubernetes repository provides ways to install and configure
SkyWalking in a Kubernetes cluster.
+The scripts are written in Helm 3.
## Documentation
- Chart Detailed Configuration
-chart detailed configuration please read [Chart
Readme](./chart/skywalking/README.md)
+### Chart Detailed Configuration
+Chart detailed configuration can be found at [Chart
Readme](./chart/skywalking/README.md)
- Deploy SkyWalking and Elasticsearch 7 (default)
+### Deploy SkyWalking in a Kubernetes cluster
-```shell script
-$ cd chart
+ Prerequisites
-$ helm repo add elastic https://helm.elastic.co
+```shell script
+git clone https://github.com/apache/skywalking-kubernetes
+cd skywalking-kubernetes/chart
+helm repo add elastic https://helm.elastic.co
+helm dep up skywalking
+export SKYWALKING_RELEASE_NAME=skywalking # change the release name according
to your scenario
+export SKYWALKING_RELEASE_NAMESPACE=istio-system # change the namespace
according to your scenario
+```
-$ helm dep up skywalking
+ Deploy the latest SkyWalking & Elasticsearch 6 (default)
-$ helm install skywalking -n
+```shell script
+helm install "${SKYWALKING_RELEASE_NAME}" skywalking -n
"${SKYWALKING_RELEASE_NAMESPACE}"
```
-**Note**: If you want to deploy Elasticsearch 6, execute the following command
+ Deploy the latest SkyWalking & Elasticsearch 7
```shell script
-$ helm dep up skywalking
-
-$ helm install skywalking -n --values
./skywalking/values-es6.yaml
+helm install "${SKYWALKING_RELEASE_NAME}" skywalking -n
"${SKYWALKING_RELEASE_NAMESPACE}" \
+ -f ./skywalking/values.yaml \
+ -f ./skywalking/values-es7.yaml
```
- Only deploy SkyWalking ,and use existing Elasticsearch
-If not want to deploy a new elasticsearch cluster, this way can be solved.
+ Deploy a specific version of SkyWalking & Elasticsearch
+
+- Deploy SkyWalking 8.0.1 & Elasticsearch 6.8.6
-Only need to close the elasticsearch deployed by chart default and configure
the existing elasticsearch connection method.
+```shell script
+helm install "${SKYWALKING_RELEASE_NAME}" skywalking -n
"${SKYWALKING_RELEASE_NAMESPACE}" \
+ --set oap.image.tag=8.0.1-es6 \
+ --set ui.image.tag=8.0.1 \
+ --set elasticsearch.imageTag=6.8.6
+```
+- Deploy SkyWalking 8.1.0 & Elasticsearch 7.5.1
```shell script
-$ cd chart
+helm install "${SKYWALKING_RELEASE_NAME}" skywalking -n
"${SKYWALKING_RELEASE_NAMESPACE}" \
+ --set oap.image.tag=8.1.0-es7 \
+ --set ui.image.tag=8.1.0 \
+ --set elasticsearch.imageTag=7.5.1
+```
-$ helm repo add elastic https://helm.elastic.co
+**NOTE**: Please make sure the specified OAP image tag supports the specified
Elasticsearch version.
-$ helm dep up skywalking
+ Deploy the latest SkyWalking & an existing Elasticsearch
-$ helm install skywalking -n \
---set elasticsearch.enabled=false \
---set elasticsearch.config.host= \
---set elasticsearch.config.port.http= \
---set elasticsearch.config.user= \
---set elasticsearch.config.password=
+1. Modify the connection information to the existing elasticsearch cluster in
file [`values-my-es.yaml`](chart/skywalking/values-my-es.yaml).
+1. Execute the command.
+```shell script
+helm install "${SKYWALKING_RELEASE_NAME}" skywalking -n
"${SKYWALKING_RELEASE_NAMESPACE}" \
+ -f ./skywalking/values.yaml \
+ -f ./skywalking/values-my-es.yaml
+```
+
+OR, if your existing Elasticsearch version is 7.x.x
+
+```shell script
+helm
[skywalking-kubernetes] branch refactor updated (9f5473b -> 5edebe1)
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch refactor in repository https://gitbox.apache.org/repos/asf/skywalking-kubernetes.git. discard 9f5473b Refactor to unify the versions of SkyWalking new 5edebe1 Refactor to unify the versions of SkyWalking This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (9f5473b) \ N -- N -- N refs/heads/refactor (5edebe1) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: chart/skywalking/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[skywalking-kubernetes] branch refactor updated (5edebe1 -> 56fa25c)
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch refactor in repository https://gitbox.apache.org/repos/asf/skywalking-kubernetes.git. discard 5edebe1 Refactor to unify the versions of SkyWalking new 56fa25c Refactor to unify the versions of SkyWalking This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (5edebe1) \ N -- N -- N refs/heads/refactor (56fa25c) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: chart/skywalking/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[skywalking-kubernetes] 01/01: Refactor to unify the versions of SkyWalking
This is an automated email from the ASF dual-hosted git repository.
kezhenxu94 pushed a commit to branch refactor
in repository https://gitbox.apache.org/repos/asf/skywalking-kubernetes.git
commit 5edebe113c89d4c2bc758829d4745017834e6bf5
Author: kezhenxu94
AuthorDate: Sat Oct 17 00:20:04 2020 +0800
Refactor to unify the versions of SkyWalking
---
.gitignore | 1 +
README.md | 97 ++
chart/skywalking/README.md | 4 +-
chart/skywalking/values-es6.yaml | 356 -
chart/skywalking/values-es7.yaml | 26 +++
chart/skywalking/values-my-es.yaml | 27 +++
chart/skywalking/values.yaml | 8 +-
7 files changed, 121 insertions(+), 398 deletions(-)
diff --git a/.gitignore b/.gitignore
index 538c8c5..495004e 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,2 +1,3 @@
.DS_Store
*~
+.idea
diff --git a/README.md b/README.md
index 1fe724e..2c9c52b 100644
--- a/README.md
+++ b/README.md
@@ -6,66 +6,91 @@ Apache SkyWalking Kubernetes
[](https://github.com/apache/skywalking)
[](https://twitter.com/AsfSkyWalking)
-SkyWalking Kubernetes repository provides ways to install and configure
skywalking in a Kubernetes cluster.
-The scripts are written in Helm3.
+SkyWalking Kubernetes repository provides ways to install and configure
SkyWalking in a Kubernetes cluster.
+The scripts are written in Helm 3.
## Documentation
- Chart Detailed Configuration
-chart detailed configuration please read [Chart
Readme](./chart/skywalking/README.md)
+### Chart Detailed Configuration
+Chart detailed configuration can be found at [Chart
Readme](./chart/skywalking/README.md)
- Deploy SkyWalking and Elasticsearch 7 (default)
+### Deploy SkyWalking in a Kubernetes cluster
-```shell script
-$ cd chart
+ Prerequisites
-$ helm repo add elastic https://helm.elastic.co
+```shell script
+git clone https://github.com/apache/skywalking-kubernetes
+cd skywalking-kubernetes/chart
+helm repo add elastic https://helm.elastic.co
+helm dep up skywalking
+export SKYWALKING_RELEASE_NAME=skywalking # change the release name according
to your scenario
+export SKYWALKING_RELEASE_NAMESPACE=istio-system # change the namespace
according to your scenario
+```
-$ helm dep up skywalking
+ Deploy the latest SkyWalking & Elasticsearch 6 (default)
-$ helm install skywalking -n
+```shell script
+helm install "${SKYWALKING_RELEASE_NAME}" skywalking -n
"${SKYWALKING_RELEASE_NAMESPACE}"
```
-**Note**: If you want to deploy Elasticsearch 6, execute the following command
+ Deploy the latest SkyWalking & Elasticsearch 7
```shell script
-$ helm dep up skywalking
-
-$ helm install skywalking -n --values
./skywalking/values-es6.yaml
+helm install "${SKYWALKING_RELEASE_NAME}" skywalking -n
"${SKYWALKING_RELEASE_NAMESPACE}" \
+ -f ./skywalking/values.yaml \
+ -f ./skywalking/values-es7.yaml
```
- Only deploy SkyWalking ,and use existing Elasticsearch
-If not want to deploy a new elasticsearch cluster, this way can be solved.
+ Deploy a specific version of SkyWalking & Elasticsearch
+
+- Deploy SkyWalking 8.0.1 & Elasticsearch 6.8.6
-Only need to close the elasticsearch deployed by chart default and configure
the existing elasticsearch connection method.
+```shell script
+helm install "${SKYWALKING_RELEASE_NAME}" skywalking -n
"${SKYWALKING_RELEASE_NAMESPACE}" \
+ --set oap.image.tag=8.0.1-es6 \
+ --set ui.image.tag=8.0.1 \
+ --set elasticsearch.imageTag=6.8.6
+```
+- Deploy SkyWalking 8.1.0 & Elasticsearch 7.5.1
```shell script
-$ cd chart
+helm install "${SKYWALKING_RELEASE_NAME}" skywalking -n
"${SKYWALKING_RELEASE_NAMESPACE}" \
+ --set oap.image.tag=8.1.0-es7 \
+ --set ui.image.tag=8.1.0 \
+ --set elasticsearch.imageTag=7.5.1
+```
-$ helm repo add elastic https://helm.elastic.co
+**NOTE**: Please make sure the specified OAP image tag supports the specified
Elasticsearch version.
-$ helm dep up skywalking
+ Deploy the latest SkyWalking & an existing Elasticsearch
-$ helm install skywalking -n \
---set elasticsearch.enabled=false \
---set elasticsearch.config.host= \
---set elasticsearch.config.port.http= \
---set elasticsearch.config.user= \
---set elasticsearch.config.password=
+1. Modify the connection information to the existing elasticsearch cluster in
file [`values-my-es.yaml`](chart/skywalking/values-my-es.yaml).
+1. Execute the command.
+```shell script
+helm install "${SKYWALKING_RELEASE_NAME}" skywalking -n
"${SKYWALKING_RELEASE_NAMESPACE}" \
+ -f ./skywalking/values.yaml \
+ -f ./skywalking/values-my-es.yaml
+```
+
+OR, if your existing Elasticsearch version is 7.x.x
+
+```shell script
+helm
[skywalking-kubernetes] branch refactor updated (83e85c2 -> 9f5473b)
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch refactor in repository https://gitbox.apache.org/repos/asf/skywalking-kubernetes.git. discard 83e85c2 Refactor to unify the versions of SkyWalking new 9f5473b Refactor to unify the versions of SkyWalking This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (83e85c2) \ N -- N -- N refs/heads/refactor (9f5473b) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: chart/skywalking/README.md | 8 1 file changed, 4 insertions(+), 4 deletions(-)
[skywalking-kubernetes] 01/01: Refactor to unify the versions of SkyWalking
This is an automated email from the ASF dual-hosted git repository.
kezhenxu94 pushed a commit to branch refactor
in repository https://gitbox.apache.org/repos/asf/skywalking-kubernetes.git
commit 9f5473b549ad05b3c76099c3629d1f52a6e5a487
Author: kezhenxu94
AuthorDate: Sat Oct 17 00:20:04 2020 +0800
Refactor to unify the versions of SkyWalking
---
.gitignore | 1 +
README.md | 97 ++
chart/skywalking/README.md | 6 +-
chart/skywalking/values-es6.yaml | 356 -
chart/skywalking/values-es7.yaml | 26 +++
chart/skywalking/values-my-es.yaml | 27 +++
chart/skywalking/values.yaml | 8 +-
7 files changed, 122 insertions(+), 399 deletions(-)
diff --git a/.gitignore b/.gitignore
index 538c8c5..495004e 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,2 +1,3 @@
.DS_Store
*~
+.idea
diff --git a/README.md b/README.md
index 1fe724e..2c9c52b 100644
--- a/README.md
+++ b/README.md
@@ -6,66 +6,91 @@ Apache SkyWalking Kubernetes
[](https://github.com/apache/skywalking)
[](https://twitter.com/AsfSkyWalking)
-SkyWalking Kubernetes repository provides ways to install and configure
skywalking in a Kubernetes cluster.
-The scripts are written in Helm3.
+SkyWalking Kubernetes repository provides ways to install and configure
SkyWalking in a Kubernetes cluster.
+The scripts are written in Helm 3.
## Documentation
- Chart Detailed Configuration
-chart detailed configuration please read [Chart
Readme](./chart/skywalking/README.md)
+### Chart Detailed Configuration
+Chart detailed configuration can be found at [Chart
Readme](./chart/skywalking/README.md)
- Deploy SkyWalking and Elasticsearch 7 (default)
+### Deploy SkyWalking in a Kubernetes cluster
-```shell script
-$ cd chart
+ Prerequisites
-$ helm repo add elastic https://helm.elastic.co
+```shell script
+git clone https://github.com/apache/skywalking-kubernetes
+cd skywalking-kubernetes/chart
+helm repo add elastic https://helm.elastic.co
+helm dep up skywalking
+export SKYWALKING_RELEASE_NAME=skywalking # change the release name according
to your scenario
+export SKYWALKING_RELEASE_NAMESPACE=istio-system # change the namespace
according to your scenario
+```
-$ helm dep up skywalking
+ Deploy the latest SkyWalking & Elasticsearch 6 (default)
-$ helm install skywalking -n
+```shell script
+helm install "${SKYWALKING_RELEASE_NAME}" skywalking -n
"${SKYWALKING_RELEASE_NAMESPACE}"
```
-**Note**: If you want to deploy Elasticsearch 6, execute the following command
+ Deploy the latest SkyWalking & Elasticsearch 7
```shell script
-$ helm dep up skywalking
-
-$ helm install skywalking -n --values
./skywalking/values-es6.yaml
+helm install "${SKYWALKING_RELEASE_NAME}" skywalking -n
"${SKYWALKING_RELEASE_NAMESPACE}" \
+ -f ./skywalking/values.yaml \
+ -f ./skywalking/values-es7.yaml
```
- Only deploy SkyWalking ,and use existing Elasticsearch
-If not want to deploy a new elasticsearch cluster, this way can be solved.
+ Deploy a specific version of SkyWalking & Elasticsearch
+
+- Deploy SkyWalking 8.0.1 & Elasticsearch 6.8.6
-Only need to close the elasticsearch deployed by chart default and configure
the existing elasticsearch connection method.
+```shell script
+helm install "${SKYWALKING_RELEASE_NAME}" skywalking -n
"${SKYWALKING_RELEASE_NAMESPACE}" \
+ --set oap.image.tag=8.0.1-es6 \
+ --set ui.image.tag=8.0.1 \
+ --set elasticsearch.imageTag=6.8.6
+```
+- Deploy SkyWalking 8.1.0 & Elasticsearch 7.5.1
```shell script
-$ cd chart
+helm install "${SKYWALKING_RELEASE_NAME}" skywalking -n
"${SKYWALKING_RELEASE_NAMESPACE}" \
+ --set oap.image.tag=8.1.0-es7 \
+ --set ui.image.tag=8.1.0 \
+ --set elasticsearch.imageTag=7.5.1
+```
-$ helm repo add elastic https://helm.elastic.co
+**NOTE**: Please make sure the specified OAP image tag supports the specified
Elasticsearch version.
-$ helm dep up skywalking
+ Deploy the latest SkyWalking & an existing Elasticsearch
-$ helm install skywalking -n \
---set elasticsearch.enabled=false \
---set elasticsearch.config.host= \
---set elasticsearch.config.port.http= \
---set elasticsearch.config.user= \
---set elasticsearch.config.password=
+1. Modify the connection information to the existing elasticsearch cluster in
file [`values-my-es.yaml`](chart/skywalking/values-my-es.yaml).
+1. Execute the command.
+```shell script
+helm install "${SKYWALKING_RELEASE_NAME}" skywalking -n
"${SKYWALKING_RELEASE_NAMESPACE}" \
+ -f ./skywalking/values.yaml \
+ -f ./skywalking/values-my-es.yaml
+```
+
+OR, if your existing Elasticsearch version is 7.x.x
+
+```shell script
+helm
[skywalking-kubernetes] branch refactor updated (8775729 -> 83e85c2)
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch refactor in repository https://gitbox.apache.org/repos/asf/skywalking-kubernetes.git. discard 8775729 Refactor to unify the versions of SkyWalking new 83e85c2 Refactor to unify the versions of SkyWalking This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (8775729) \ N -- N -- N refs/heads/refactor (83e85c2) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: chart/skywalking/README.md | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-)
[skywalking-kubernetes] 01/01: Refactor to unify the versions of SkyWalking
This is an automated email from the ASF dual-hosted git repository.
kezhenxu94 pushed a commit to branch refactor
in repository https://gitbox.apache.org/repos/asf/skywalking-kubernetes.git
commit 83e85c2026cc7a3d988609dc69dbb5f540b16144
Author: kezhenxu94
AuthorDate: Sat Oct 17 00:20:04 2020 +0800
Refactor to unify the versions of SkyWalking
---
.gitignore | 1 +
README.md | 97 ++
chart/skywalking/README.md | 12 +-
chart/skywalking/values-es6.yaml | 356 -
chart/skywalking/values-es7.yaml | 26 +++
chart/skywalking/values-my-es.yaml | 27 +++
chart/skywalking/values.yaml | 8 +-
7 files changed, 125 insertions(+), 402 deletions(-)
diff --git a/.gitignore b/.gitignore
index 538c8c5..495004e 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,2 +1,3 @@
.DS_Store
*~
+.idea
diff --git a/README.md b/README.md
index 1fe724e..2c9c52b 100644
--- a/README.md
+++ b/README.md
@@ -6,66 +6,91 @@ Apache SkyWalking Kubernetes
[](https://github.com/apache/skywalking)
[](https://twitter.com/AsfSkyWalking)
-SkyWalking Kubernetes repository provides ways to install and configure
skywalking in a Kubernetes cluster.
-The scripts are written in Helm3.
+SkyWalking Kubernetes repository provides ways to install and configure
SkyWalking in a Kubernetes cluster.
+The scripts are written in Helm 3.
## Documentation
- Chart Detailed Configuration
-chart detailed configuration please read [Chart
Readme](./chart/skywalking/README.md)
+### Chart Detailed Configuration
+Chart detailed configuration can be found at [Chart
Readme](./chart/skywalking/README.md)
- Deploy SkyWalking and Elasticsearch 7 (default)
+### Deploy SkyWalking in a Kubernetes cluster
-```shell script
-$ cd chart
+ Prerequisites
-$ helm repo add elastic https://helm.elastic.co
+```shell script
+git clone https://github.com/apache/skywalking-kubernetes
+cd skywalking-kubernetes/chart
+helm repo add elastic https://helm.elastic.co
+helm dep up skywalking
+export SKYWALKING_RELEASE_NAME=skywalking # change the release name according
to your scenario
+export SKYWALKING_RELEASE_NAMESPACE=istio-system # change the namespace
according to your scenario
+```
-$ helm dep up skywalking
+ Deploy the latest SkyWalking & Elasticsearch 6 (default)
-$ helm install skywalking -n
+```shell script
+helm install "${SKYWALKING_RELEASE_NAME}" skywalking -n
"${SKYWALKING_RELEASE_NAMESPACE}"
```
-**Note**: If you want to deploy Elasticsearch 6, execute the following command
+ Deploy the latest SkyWalking & Elasticsearch 7
```shell script
-$ helm dep up skywalking
-
-$ helm install skywalking -n --values
./skywalking/values-es6.yaml
+helm install "${SKYWALKING_RELEASE_NAME}" skywalking -n
"${SKYWALKING_RELEASE_NAMESPACE}" \
+ -f ./skywalking/values.yaml \
+ -f ./skywalking/values-es7.yaml
```
- Only deploy SkyWalking ,and use existing Elasticsearch
-If not want to deploy a new elasticsearch cluster, this way can be solved.
+ Deploy a specific version of SkyWalking & Elasticsearch
+
+- Deploy SkyWalking 8.0.1 & Elasticsearch 6.8.6
-Only need to close the elasticsearch deployed by chart default and configure
the existing elasticsearch connection method.
+```shell script
+helm install "${SKYWALKING_RELEASE_NAME}" skywalking -n
"${SKYWALKING_RELEASE_NAMESPACE}" \
+ --set oap.image.tag=8.0.1-es6 \
+ --set ui.image.tag=8.0.1 \
+ --set elasticsearch.imageTag=6.8.6
+```
+- Deploy SkyWalking 8.1.0 & Elasticsearch 7.5.1
```shell script
-$ cd chart
+helm install "${SKYWALKING_RELEASE_NAME}" skywalking -n
"${SKYWALKING_RELEASE_NAMESPACE}" \
+ --set oap.image.tag=8.1.0-es7 \
+ --set ui.image.tag=8.1.0 \
+ --set elasticsearch.imageTag=7.5.1
+```
-$ helm repo add elastic https://helm.elastic.co
+**NOTE**: Please make sure the specified OAP image tag supports the specified
Elasticsearch version.
-$ helm dep up skywalking
+ Deploy the latest SkyWalking & an existing Elasticsearch
-$ helm install skywalking -n \
---set elasticsearch.enabled=false \
---set elasticsearch.config.host= \
---set elasticsearch.config.port.http= \
---set elasticsearch.config.user= \
---set elasticsearch.config.password=
+1. Modify the connection information to the existing elasticsearch cluster in
file [`values-my-es.yaml`](chart/skywalking/values-my-es.yaml).
+1. Execute the command.
+```shell script
+helm install "${SKYWALKING_RELEASE_NAME}" skywalking -n
"${SKYWALKING_RELEASE_NAMESPACE}" \
+ -f ./skywalking/values.yaml \
+ -f ./skywalking/values-my-es.yaml
+```
+
+OR, if your existing Elasticsearch version is 7.x.x
+
+```shell script
+helm
[skywalking-kubernetes] branch refactor updated (e2a1deb -> 8775729)
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch refactor in repository https://gitbox.apache.org/repos/asf/skywalking-kubernetes.git. discard e2a1deb Refactor to unify the versions of SkyWalking new 8775729 Refactor to unify the versions of SkyWalking This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (e2a1deb) \ N -- N -- N refs/heads/refactor (8775729) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[skywalking-kubernetes] 01/01: Refactor to unify the versions of SkyWalking
This is an automated email from the ASF dual-hosted git repository.
kezhenxu94 pushed a commit to branch refactor
in repository https://gitbox.apache.org/repos/asf/skywalking-kubernetes.git
commit 8775729951d885b09bcdd66720c38b2449f1aa2f
Author: kezhenxu94
AuthorDate: Sat Oct 17 00:20:04 2020 +0800
Refactor to unify the versions of SkyWalking
---
.gitignore | 1 +
README.md | 97 ++
chart/skywalking/README.md | 12 +-
chart/skywalking/values-es6.yaml | 356 -
chart/skywalking/values-es7.yaml | 26 +++
chart/skywalking/values-my-es.yaml | 27 +++
chart/skywalking/values.yaml | 8 +-
7 files changed, 125 insertions(+), 402 deletions(-)
diff --git a/.gitignore b/.gitignore
index 538c8c5..495004e 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,2 +1,3 @@
.DS_Store
*~
+.idea
diff --git a/README.md b/README.md
index 1fe724e..2c9c52b 100644
--- a/README.md
+++ b/README.md
@@ -6,66 +6,91 @@ Apache SkyWalking Kubernetes
[](https://github.com/apache/skywalking)
[](https://twitter.com/AsfSkyWalking)
-SkyWalking Kubernetes repository provides ways to install and configure
skywalking in a Kubernetes cluster.
-The scripts are written in Helm3.
+SkyWalking Kubernetes repository provides ways to install and configure
SkyWalking in a Kubernetes cluster.
+The scripts are written in Helm 3.
## Documentation
- Chart Detailed Configuration
-chart detailed configuration please read [Chart
Readme](./chart/skywalking/README.md)
+### Chart Detailed Configuration
+Chart detailed configuration can be found at [Chart
Readme](./chart/skywalking/README.md)
- Deploy SkyWalking and Elasticsearch 7 (default)
+### Deploy SkyWalking in a Kubernetes cluster
-```shell script
-$ cd chart
+ Prerequisites
-$ helm repo add elastic https://helm.elastic.co
+```shell script
+git clone https://github.com/apache/skywalking-kubernetes
+cd skywalking-kubernetes/chart
+helm repo add elastic https://helm.elastic.co
+helm dep up skywalking
+export SKYWALKING_RELEASE_NAME=skywalking # change the release name according
to your scenario
+export SKYWALKING_RELEASE_NAMESPACE=istio-system # change the namespace
according to your scenario
+```
-$ helm dep up skywalking
+ Deploy the latest SkyWalking & Elasticsearch 6 (default)
-$ helm install skywalking -n
+```shell script
+helm install "${SKYWALKING_RELEASE_NAME}" skywalking -n
"${SKYWALKING_RELEASE_NAMESPACE}"
```
-**Note**: If you want to deploy Elasticsearch 6, execute the following command
+ Deploy the latest SkyWalking & Elasticsearch 7
```shell script
-$ helm dep up skywalking
-
-$ helm install skywalking -n --values
./skywalking/values-es6.yaml
+helm install "${SKYWALKING_RELEASE_NAME}" skywalking -n
"${SKYWALKING_RELEASE_NAMESPACE}" \
+ -f ./skywalking/values.yaml \
+ -f ./skywalking/values-es7.yaml
```
- Only deploy SkyWalking ,and use existing Elasticsearch
-If not want to deploy a new elasticsearch cluster, this way can be solved.
+ Deploy a specific version of SkyWalking & Elasticsearch
+
+- Deploy SkyWalking 8.0.1 & Elasticsearch 6.8.6
-Only need to close the elasticsearch deployed by chart default and configure
the existing elasticsearch connection method.
+```shell script
+helm install "${SKYWALKING_RELEASE_NAME}" skywalking -n
"${SKYWALKING_RELEASE_NAMESPACE}" \
+ --set oap.image.tag=8.0.1-es6 \
+ --set ui.image.tag=8.0.1 \
+ --set elasticsearch.imageTag=6.8.6
+```
+- Deploy SkyWalking 8.1.0 & Elasticsearch 7.5.1
```shell script
-$ cd chart
+helm install "${SKYWALKING_RELEASE_NAME}" skywalking -n
"${SKYWALKING_RELEASE_NAMESPACE}" \
+ --set oap.image.tag=8.1.0-es7 \
+ --set ui.image.tag=8.1.0 \
+ --set elasticsearch.imageTag=7.5.1
+```
-$ helm repo add elastic https://helm.elastic.co
+**NOTE**: Please make sure the specified OAP image tag supports the specified
Elasticsearch version.
-$ helm dep up skywalking
+ Deploy the latest SkyWalking & an existing Elasticsearch
-$ helm install skywalking -n \
---set elasticsearch.enabled=false \
---set elasticsearch.config.host= \
---set elasticsearch.config.port.http= \
---set elasticsearch.config.user= \
---set elasticsearch.config.password=
+1. Modify the connection information to the existing elasticsearch cluster in
file [`values-my-es.yaml`](chart/skywalking/values-my-es.yaml).
+1. Execute the command.
+```shell script
+helm install "${SKYWALKING_RELEASE_NAME}" skywalking -n
"${SKYWALKING_RELEASE_NAMESPACE}" \
+ -f ./skywalking/values.yaml \
+ -f ./skywalking/values-my-es.yaml
+```
+
+OR, if your existing Elasticsearch version is 7.x.x
+
+```shell script
+helm
[skywalking-kubernetes] 01/01: Refactor to unify the versions of SkyWalking
This is an automated email from the ASF dual-hosted git repository.
kezhenxu94 pushed a commit to branch refactor
in repository https://gitbox.apache.org/repos/asf/skywalking-kubernetes.git
commit e2a1deb09d528ea229a3fc5b4dbaba757f0a1eaa
Author: kezhenxu94
AuthorDate: Sat Oct 17 00:20:04 2020 +0800
Refactor to unify the versions of SkyWalking
---
.gitignore | 1 +
README.md | 97 ++
chart/skywalking/README.md | 12 +-
chart/skywalking/values-es6.yaml | 356 -
chart/skywalking/values-es7.yaml | 26 +++
chart/skywalking/values-my-es.yaml | 27 +++
chart/skywalking/values.yaml | 8 +-
7 files changed, 125 insertions(+), 402 deletions(-)
diff --git a/.gitignore b/.gitignore
index 538c8c5..495004e 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,2 +1,3 @@
.DS_Store
*~
+.idea
diff --git a/README.md b/README.md
index 1fe724e..e15a680 100644
--- a/README.md
+++ b/README.md
@@ -6,66 +6,91 @@ Apache SkyWalking Kubernetes
[](https://github.com/apache/skywalking)
[](https://twitter.com/AsfSkyWalking)
-SkyWalking Kubernetes repository provides ways to install and configure
skywalking in a Kubernetes cluster.
-The scripts are written in Helm3.
+SkyWalking Kubernetes repository provides ways to install and configure
SkyWalking in a Kubernetes cluster.
+The scripts are written in Helm 3.
## Documentation
- Chart Detailed Configuration
-chart detailed configuration please read [Chart
Readme](./chart/skywalking/README.md)
+### Chart Detailed Configuration
+Chart detailed configuration can be found at [Chart
Readme](./chart/skywalking/README.md)
- Deploy SkyWalking and Elasticsearch 7 (default)
+### Deploy SkyWalking in a Kubernetes cluster
-```shell script
-$ cd chart
+ Prerequisites
-$ helm repo add elastic https://helm.elastic.co
+```shell script
+git clone https://github.com/apache/skywalking-kubernetes
+cd skywalking-kubernetes/chart
+helm repo add elastic https://helm.elastic.co
+helm dep up skywalking
+export SKYWALKING_RELEASE_NAME=skywalking # change the release name according
to your scenario
+export SKYWALKING_RELEASE_NAMESPACE=istio-system # change the namespace
according to your scenario
+```
-$ helm dep up skywalking
+ Deploy the latest SkyWalking & Elasticsearch 6 (default)
-$ helm install skywalking -n
+```shell script
+helm install "${SKYWALKING_RELEASE_NAME}" skywalking -n
"${SKYWALKING_RELEASE_NAMESPACE}"
```
-**Note**: If you want to deploy Elasticsearch 6, execute the following command
+ Deploy the latest SkyWalking & Elasticsearch 7
```shell script
-$ helm dep up skywalking
-
-$ helm install skywalking -n --values
./skywalking/values-es6.yaml
+helm install "${SKYWALKING_RELEASE_NAME}" skywalking -n
"${SKYWALKING_RELEASE_NAMESPACE}" \
+ -f ./skywalking/values.yaml \
+ -f ./skywalking/values-es7.yaml
```
- Only deploy SkyWalking ,and use existing Elasticsearch
-If not want to deploy a new elasticsearch cluster, this way can be solved.
+ Deploy a specific version of SkyWalking & Elasticsearch
+
+- Deploy SkyWalking 8.0.1 & Elasticsearch 6.8.6
-Only need to close the elasticsearch deployed by chart default and configure
the existing elasticsearch connection method.
+```shell script
+helm install "${SKYWALKING_RELEASE_NAME}" skywalking -n
"${SKYWALKING_RELEASE_NAMESPACE}" \
+ --set oap.image.tag=8.0.1-es6 \
+ --set ui.image.tag=8.0.1 \
+ --set elasticsearch.imageTag=6.8.6
+```
+- Deploy SkyWalking 8.1.0 & Elasticsearch 7.5.1
```shell script
-$ cd chart
+helm install "${SKYWALKING_RELEASE_NAME}" skywalking -n
"${SKYWALKING_RELEASE_NAMESPACE}" \
+ --set oap.image.tag=8.1.0-es7 \
+ --set ui.image.tag=8.1.0 \
+ --set elasticsearch.imageTag=7.5.1
+```
-$ helm repo add elastic https://helm.elastic.co
+**NOTE**: Please make sure the specified OAP image version supports the
specified Elasticsearch version.
-$ helm dep up skywalking
+ Deploy the latest SkyWalking & an existing Elasticsearch
-$ helm install skywalking -n \
---set elasticsearch.enabled=false \
---set elasticsearch.config.host= \
---set elasticsearch.config.port.http= \
---set elasticsearch.config.user= \
---set elasticsearch.config.password=
+1. Modify the connection information to the existing elasticsearch cluster in
file [`values-my-es.yaml`](chart/skywalking/values-my-es.yaml).
+1. Execute the command.
+```shell script
+helm install "${SKYWALKING_RELEASE_NAME}" skywalking -n
"${SKYWALKING_RELEASE_NAMESPACE}" \
+ -f ./skywalking/values.yaml \
+ -f ./skywalking/values-my-es.yaml
+```
+
+OR, if your existing Elasticsearch version is 7.x.x
+
+```shell script
+helm
[skywalking-kubernetes] branch refactor created (now e2a1deb)
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch refactor in repository https://gitbox.apache.org/repos/asf/skywalking-kubernetes.git. at e2a1deb Refactor to unify the versions of SkyWalking This branch includes the following new commits: new e2a1deb Refactor to unify the versions of SkyWalking The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5678: Fix application start duration log "Failed to load class org.slf4j.impl.StaticLoggerBinder."
codecov[bot] edited a comment on pull request #5678: URL: https://github.com/apache/skywalking/pull/5678#issuecomment-709824893 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=h1) Report > Merging [#5678](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `23.42%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5678 +/- ## = - Coverage 53.45% 30.02% -23.43% + Complexity 3412 1988 -1424 = Files 880 907 +27 Lines 219257 +302 Branches 2089 2105 +16 = - Hits 11719 6674 -5045 - Misses 927015104 +5834 + Partials936 449 -487 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ng/apm/agent/core/logging/core/AbstractLogger.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0Fic3RyYWN0TG9nZ2VyLmphdmE=) | `0.00% <0.00%> (-55.00%)` | `0.00 <0.00> (-16.00)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-1.00)` | | | [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [335 more](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree-more) | | -- [Continue to
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5678: Fix application start duration log "Failed to load class org.slf4j.impl.StaticLoggerBinder."
codecov[bot] edited a comment on pull request #5678: URL: https://github.com/apache/skywalking/pull/5678#issuecomment-709824893 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=h1) Report > Merging [#5678](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `25.88%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5678 +/- ## = - Coverage 53.45% 27.56% -25.89% + Complexity 3412 1785 -1627 = Files 880 878-2 Lines 2192521386 -539 Branches 2089 2009 -80 = - Hits 11719 5895 -5824 - Misses 927015083 +5813 + Partials936 408 -528 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ng/apm/agent/core/logging/core/AbstractLogger.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0Fic3RyYWN0TG9nZ2VyLmphdmE=) | `0.00% <0.00%> (-55.00%)` | `0.00 <0.00> (-16.00)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-1.00)` | | | [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [390 more](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree-more) | | -- [Continue to
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5678: Fix application start duration log "Failed to load class org.slf4j.impl.StaticLoggerBinder."
codecov[bot] edited a comment on pull request #5678: URL: https://github.com/apache/skywalking/pull/5678#issuecomment-709824893 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=h1) Report > Merging [#5678](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `53.45%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5678 +/- ## - Coverage 53.45% 0.00% -53.46% Files 880 187 -693 Lines 219254356-17569 Branches 2089 504 -1585 - Hits 11719 0-11719 + Misses 92704356 -4914 + Partials936 0 -936 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ng/apm/agent/core/logging/core/AbstractLogger.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0Fic3RyYWN0TG9nZ2VyLmphdmE=) | `0.00% <0.00%> (-55.00%)` | `0.00 <0.00> (-16.00)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-1.00)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [886 more](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5678: Fix application start duration log "Failed to load class org.slf4j.impl.StaticLoggerBinder."
codecov[bot] edited a comment on pull request #5678: URL: https://github.com/apache/skywalking/pull/5678#issuecomment-709824893 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5678: Fix application start duration log "Failed to load class org.slf4j.impl.StaticLoggerBinder."
codecov[bot] edited a comment on pull request #5678: URL: https://github.com/apache/skywalking/pull/5678#issuecomment-709824893 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=h1) Report > Merging [#5678](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **increase** coverage by `0.06%`. > The diff coverage is `14.28%`. [](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5678 +/- ## + Coverage 53.45% 53.51% +0.06% + Complexity 3412 742-2670 Files 880 174 -706 Lines 21925 4057 -17868 Branches 2089 458-1631 - Hits 11719 2171-9548 + Misses 9270 1618-7652 + Partials936 268 -668 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ng/apm/agent/core/logging/core/AbstractLogger.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0Fic3RyYWN0TG9nZ2VyLmphdmE=) | `46.57% <7.69%> (-8.43%)` | `18.00 <2.00> (+2.00)` | :arrow_down: | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...apm/agent/core/remote/AuthenticationDecorator.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0F1dGhlbnRpY2F0aW9uRGVjb3JhdG9yLmphdmE=) | `33.33% <0.00%> (-26.67%)` | `3.00% <0.00%> (ø%)` | | | [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `58.82% <0.00%> (-17.65%)` | `4.00% <0.00%> (ø%)` | | | [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `60.37% <0.00%> (-13.21%)` | `9.00% <0.00%> (-1.00%)` | | | [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `51.35% <0.00%> (-10.82%)` | `8.00% <0.00%> (-1.00%)` | | | [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `62.71% <0.00%> (-5.09%)` | `10.00% <0.00%> (-2.00%)` | | | [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `57.14% <0.00%> (-3.58%)` | `7.00% <0.00%> (-1.00%)` | | | [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | | | | | [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | | | | | ... and [736
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5678: Fix application start duration log "Failed to load class org.slf4j.impl.StaticLoggerBinder."
codecov[bot] edited a comment on pull request #5678: URL: https://github.com/apache/skywalking/pull/5678#issuecomment-709824893 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=h1) Report > Merging [#5678](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **increase** coverage by `0.06%`. > The diff coverage is `14.28%`. [](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5678 +/- ## + Coverage 53.45% 53.51% +0.06% + Complexity 3412 742-2670 Files 880 174 -706 Lines 21925 4057 -17868 Branches 2089 458-1631 - Hits 11719 2171-9548 + Misses 9270 1618-7652 + Partials936 268 -668 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ng/apm/agent/core/logging/core/AbstractLogger.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0Fic3RyYWN0TG9nZ2VyLmphdmE=) | `46.57% <7.69%> (-8.43%)` | `18.00 <2.00> (+2.00)` | :arrow_down: | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...apm/agent/core/remote/AuthenticationDecorator.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0F1dGhlbnRpY2F0aW9uRGVjb3JhdG9yLmphdmE=) | `33.33% <0.00%> (-26.67%)` | `3.00% <0.00%> (ø%)` | | | [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `58.82% <0.00%> (-17.65%)` | `4.00% <0.00%> (ø%)` | | | [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `60.37% <0.00%> (-13.21%)` | `9.00% <0.00%> (-1.00%)` | | | [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `51.35% <0.00%> (-10.82%)` | `8.00% <0.00%> (-1.00%)` | | | [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `62.71% <0.00%> (-5.09%)` | `10.00% <0.00%> (-2.00%)` | | | [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `57.14% <0.00%> (-3.58%)` | `7.00% <0.00%> (-1.00%)` | | | [...he/skywalking/oal/rt/output/DispatcherContext.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L291dHB1dC9EaXNwYXRjaGVyQ29udGV4dC5qYXZh) | | | | | [...skywalking/oap/server/core/analysis/topn/TopN.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvdG9wbi9Ub3BOLmphdmE=) | | | | | ... and [736 more](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=continue). >
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5678: Fix application start duration log "Failed to load class org.slf4j.impl.StaticLoggerBinder."
codecov[bot] edited a comment on pull request #5678: URL: https://github.com/apache/skywalking/pull/5678#issuecomment-709824893 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=h1) Report > Merging [#5678](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **increase** coverage by `0.06%`. > The diff coverage is `14.28%`. [](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5678 +/- ## + Coverage 53.45% 53.51% +0.06% + Complexity 3412 742-2670 Files 880 174 -706 Lines 21925 4057 -17868 Branches 2089 458-1631 - Hits 11719 2171-9548 + Misses 9270 1618-7652 + Partials936 268 -668 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ng/apm/agent/core/logging/core/AbstractLogger.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0Fic3RyYWN0TG9nZ2VyLmphdmE=) | `46.57% <7.69%> (-8.43%)` | `18.00 <2.00> (+2.00)` | :arrow_down: | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...apm/agent/core/remote/AuthenticationDecorator.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0F1dGhlbnRpY2F0aW9uRGVjb3JhdG9yLmphdmE=) | `33.33% <0.00%> (-26.67%)` | `3.00% <0.00%> (ø%)` | | | [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `58.82% <0.00%> (-17.65%)` | `4.00% <0.00%> (ø%)` | | | [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `60.37% <0.00%> (-13.21%)` | `9.00% <0.00%> (-1.00%)` | | | [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `51.35% <0.00%> (-10.82%)` | `8.00% <0.00%> (-1.00%)` | | | [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `62.71% <0.00%> (-5.09%)` | `10.00% <0.00%> (-2.00%)` | | | [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `57.14% <0.00%> (-3.58%)` | `7.00% <0.00%> (-1.00%)` | | | [...analysis/metrics/expression/GreaterEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0dyZWF0ZXJFcXVhbE1hdGNoLmphdmE=) | | | | | [.../apache/skywalking/oal/rt/parser/ScriptParser.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9TY3JpcHRQYXJzZXIuamF2YQ==) | | | | | ... and [736 more](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5678: Fix application start duration log "Failed to load class org.slf4j.impl.StaticLoggerBinder."
codecov[bot] edited a comment on pull request #5678: URL: https://github.com/apache/skywalking/pull/5678#issuecomment-709824893 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=h1) Report > Merging [#5678](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **increase** coverage by `0.06%`. > The diff coverage is `14.28%`. [](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5678 +/- ## + Coverage 53.45% 53.51% +0.06% + Complexity 3412 742-2670 Files 880 174 -706 Lines 21925 4057 -17868 Branches 2089 458-1631 - Hits 11719 2171-9548 + Misses 9270 1618-7652 + Partials936 268 -668 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ng/apm/agent/core/logging/core/AbstractLogger.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0Fic3RyYWN0TG9nZ2VyLmphdmE=) | `46.57% <7.69%> (-8.43%)` | `18.00 <2.00> (+2.00)` | :arrow_down: | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...apm/agent/core/remote/AuthenticationDecorator.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0F1dGhlbnRpY2F0aW9uRGVjb3JhdG9yLmphdmE=) | `33.33% <0.00%> (-26.67%)` | `3.00% <0.00%> (ø%)` | | | [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `58.82% <0.00%> (-17.65%)` | `4.00% <0.00%> (ø%)` | | | [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `60.37% <0.00%> (-13.21%)` | `9.00% <0.00%> (-1.00%)` | | | [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `51.35% <0.00%> (-10.82%)` | `8.00% <0.00%> (-1.00%)` | | | [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `62.71% <0.00%> (-5.09%)` | `10.00% <0.00%> (-2.00%)` | | | [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `57.14% <0.00%> (-3.58%)` | `7.00% <0.00%> (-1.00%)` | | | [...ysis/manual/instance/InstanceUpdateDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVXBkYXRlRGlzcGF0Y2hlci5qYXZh) | | | | | [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | | | | | ... and [736
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5678: Fix application start duration log "Failed to load class org.slf4j.impl.StaticLoggerBinder."
codecov[bot] edited a comment on pull request #5678: URL: https://github.com/apache/skywalking/pull/5678#issuecomment-709824893 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=h1) Report > Merging [#5678](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **increase** coverage by `0.06%`. > The diff coverage is `14.28%`. [](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5678 +/- ## + Coverage 53.45% 53.51% +0.06% + Complexity 3412 742-2670 Files 880 174 -706 Lines 21925 4057 -17868 Branches 2089 458-1631 - Hits 11719 2171-9548 + Misses 9270 1618-7652 + Partials936 268 -668 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ng/apm/agent/core/logging/core/AbstractLogger.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0Fic3RyYWN0TG9nZ2VyLmphdmE=) | `46.57% <7.69%> (-8.43%)` | `18.00 <2.00> (+2.00)` | :arrow_down: | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...apm/agent/core/remote/AuthenticationDecorator.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0F1dGhlbnRpY2F0aW9uRGVjb3JhdG9yLmphdmE=) | `33.33% <0.00%> (-26.67%)` | `3.00% <0.00%> (ø%)` | | | [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `58.82% <0.00%> (-17.65%)` | `4.00% <0.00%> (ø%)` | | | [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `60.37% <0.00%> (-13.21%)` | `9.00% <0.00%> (-1.00%)` | | | [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `51.35% <0.00%> (-10.82%)` | `8.00% <0.00%> (-1.00%)` | | | [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `62.71% <0.00%> (-5.09%)` | `10.00% <0.00%> (-2.00%)` | | | [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `57.14% <0.00%> (-3.58%)` | `7.00% <0.00%> (-1.00%)` | | | [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | | | | | [...r/receiver/trace/provider/TraceModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvVHJhY2VNb2R1bGVQcm92aWRlci5qYXZh) | | | | | ... and [736
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5678: Fix application start duration log "Failed to load class org.slf4j.impl.StaticLoggerBinder."
codecov[bot] edited a comment on pull request #5678: URL: https://github.com/apache/skywalking/pull/5678#issuecomment-709824893 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=h1) Report > Merging [#5678](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **increase** coverage by `0.06%`. > The diff coverage is `14.28%`. [](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5678 +/- ## + Coverage 53.45% 53.51% +0.06% + Complexity 3412 742-2670 Files 880 174 -706 Lines 21925 4057 -17868 Branches 2089 458-1631 - Hits 11719 2171-9548 + Misses 9270 1618-7652 + Partials936 268 -668 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ng/apm/agent/core/logging/core/AbstractLogger.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0Fic3RyYWN0TG9nZ2VyLmphdmE=) | `46.57% <7.69%> (-8.43%)` | `18.00 <2.00> (+2.00)` | :arrow_down: | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...apm/agent/core/remote/AuthenticationDecorator.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0F1dGhlbnRpY2F0aW9uRGVjb3JhdG9yLmphdmE=) | `33.33% <0.00%> (-26.67%)` | `3.00% <0.00%> (ø%)` | | | [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `58.82% <0.00%> (-17.65%)` | `4.00% <0.00%> (ø%)` | | | [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `60.37% <0.00%> (-13.21%)` | `9.00% <0.00%> (-1.00%)` | | | [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `51.35% <0.00%> (-10.82%)` | `8.00% <0.00%> (-1.00%)` | | | [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `62.71% <0.00%> (-5.09%)` | `10.00% <0.00%> (-2.00%)` | | | [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `57.14% <0.00%> (-3.58%)` | `7.00% <0.00%> (-1.00%)` | | | [...lking/oap/server/core/exporter/ExporterModule.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvZXhwb3J0ZXIvRXhwb3J0ZXJNb2R1bGUuamF2YQ==) | | | | | [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | | | | | ... and [736 more](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=continue). >
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5678: Fix application start duration log "Failed to load class org.slf4j.impl.StaticLoggerBinder."
codecov[bot] edited a comment on pull request #5678: URL: https://github.com/apache/skywalking/pull/5678#issuecomment-709824893 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5678: Fix application start duration log "Failed to load class org.slf4j.impl.StaticLoggerBinder."
codecov[bot] edited a comment on pull request #5678: URL: https://github.com/apache/skywalking/pull/5678#issuecomment-709824893 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=h1) Report > Merging [#5678](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `53.45%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5678 +/- ## - Coverage 53.45% 0.00% -53.46% Files 880 174 -706 Lines 219254057-17868 Branches 2089 458 -1631 - Hits 11719 0-11719 + Misses 92704057 -5213 + Partials936 0 -936 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ng/apm/agent/core/logging/core/AbstractLogger.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0Fic3RyYWN0TG9nZ2VyLmphdmE=) | `0.00% <0.00%> (-55.00%)` | `0.00 <0.00> (-16.00)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-1.00)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [873 more](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5678: Fix application start duration log "Failed to load class org.slf4j.impl.StaticLoggerBinder."
codecov[bot] edited a comment on pull request #5678: URL: https://github.com/apache/skywalking/pull/5678#issuecomment-709824893 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=h1) Report > Merging [#5678](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `53.45%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5678 +/- ## - Coverage 53.45% 0.00% -53.46% Files 880 172 -708 Lines 219254015-17910 Branches 2089 454 -1635 - Hits 11719 0-11719 + Misses 92704015 -5255 + Partials936 0 -936 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ng/apm/agent/core/logging/core/AbstractLogger.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0Fic3RyYWN0TG9nZ2VyLmphdmE=) | `0.00% <0.00%> (-55.00%)` | `0.00 <0.00> (-16.00)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-1.00)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [871 more](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5678: Fix application start duration log "Failed to load class org.slf4j.impl.StaticLoggerBinder."
codecov[bot] edited a comment on pull request #5678: URL: https://github.com/apache/skywalking/pull/5678#issuecomment-709824893 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=h1) Report > Merging [#5678](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `53.45%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5678 +/- ## - Coverage 53.45% 0.00% -53.46% Files 880 166 -714 Lines 219253944-17981 Branches 2089 446 -1643 - Hits 11719 0-11719 + Misses 92703944 -5326 + Partials936 0 -936 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ng/apm/agent/core/logging/core/AbstractLogger.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0Fic3RyYWN0TG9nZ2VyLmphdmE=) | `0.00% <0.00%> (-55.00%)` | `0.00 <0.00> (-16.00)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-1.00)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [865 more](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5678: Fix application start duration log "Failed to load class org.slf4j.impl.StaticLoggerBinder."
codecov[bot] edited a comment on pull request #5678: URL: https://github.com/apache/skywalking/pull/5678#issuecomment-709824893 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=h1) Report > Merging [#5678](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `53.45%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5678 +/- ## - Coverage 53.45% 0.00% -53.46% Files 880 164 -716 Lines 219253932-17993 Branches 2089 446 -1643 - Hits 11719 0-11719 + Misses 92703932 -5338 + Partials936 0 -936 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ng/apm/agent/core/logging/core/AbstractLogger.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0Fic3RyYWN0TG9nZ2VyLmphdmE=) | `0.00% <0.00%> (-55.00%)` | `0.00 <0.00> (-16.00)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-1.00)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [865 more](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5678: Fix application start duration log "Failed to load class org.slf4j.impl.StaticLoggerBinder."
codecov[bot] edited a comment on pull request #5678: URL: https://github.com/apache/skywalking/pull/5678#issuecomment-709824893 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=h1) Report > Merging [#5678](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `53.45%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5678 +/- ## - Coverage 53.45% 0.00% -53.46% Files 880 187 -693 Lines 219254356-17569 Branches 2089 504 -1585 - Hits 11719 0-11719 + Misses 92704356 -4914 + Partials936 0 -936 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ng/apm/agent/core/logging/core/AbstractLogger.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0Fic3RyYWN0TG9nZ2VyLmphdmE=) | `0.00% <0.00%> (-55.00%)` | `0.00 <0.00> (-16.00)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-1.00)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [886 more](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5678: Fix application start duration log "Failed to load class org.slf4j.impl.StaticLoggerBinder."
codecov[bot] edited a comment on pull request #5678: URL: https://github.com/apache/skywalking/pull/5678#issuecomment-709824893 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=h1) Report > Merging [#5678](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `53.45%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5678 +/- ## - Coverage 53.45% 0.00% -53.46% Files 880 185 -695 Lines 219254344-17581 Branches 2089 504 -1585 - Hits 11719 0-11719 + Misses 92704344 -4926 + Partials936 0 -936 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ng/apm/agent/core/logging/core/AbstractLogger.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0Fic3RyYWN0TG9nZ2VyLmphdmE=) | `0.00% <0.00%> (-55.00%)` | `0.00 <0.00> (-16.00)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-1.00)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [886 more](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5661: Add health checker for cluster management module
codecov[bot] edited a comment on pull request #5661: URL: https://github.com/apache/skywalking/pull/5661#issuecomment-708093378 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=h1) Report > Merging [#5661](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `19.67%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5661 +/- ## = - Coverage 53.45% 33.77% -19.68% + Complexity 3412 2145 -1267 = Files 880 876-4 Lines 2192521689 -236 Branches 2089 2070 -19 = - Hits 11719 7325 -4394 - Misses 927013805 +4535 + Partials936 559 -377 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ter/plugin/consul/ClusterModuleConsulProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NsdXN0ZXJNb2R1bGVDb25zdWxQcm92aWRlci5qYXZh) | `12.90% <0.00%> (-1.39%)` | `2.00 <0.00> (ø)` | | | [...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...cluster/plugin/etcd/ClusterModuleEtcdProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvQ2x1c3Rlck1vZHVsZUV0Y2RQcm92aWRlci5qYXZh) | `22.22% <0.00%> (-4.45%)` | `2.00 <0.00> (ø)` | | | [...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...in/kubernetes/ClusterModuleKubernetesProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvQ2x1c3Rlck1vZHVsZUt1YmVybmV0ZXNQcm92aWRlci5qYXZh) | `23.52% <0.00%> (-5.05%)` | `2.00 <0.00> (ø)` | | | [...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `12.90% <0.00%> (-1.39%)` | `2.00 <0.00> (ø)` | | | [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ugin/zookeeper/ClusterModuleZookeeperProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL0NsdXN0ZXJNb2R1bGVab29rZWVwZXJQcm92aWRlci5qYXZh) | `10.00% <0.00%> (-0.64%)` | `3.00
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5661: Add health checker for cluster management module
codecov[bot] edited a comment on pull request #5661: URL: https://github.com/apache/skywalking/pull/5661#issuecomment-708093378 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=h1) Report > Merging [#5661](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `19.68%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5661 +/- ## = - Coverage 53.45% 33.76% -19.69% + Complexity 3412 2144 -1268 = Files 880 876-4 Lines 2192521689 -236 Branches 2089 2070 -19 = - Hits 11719 7323 -4396 - Misses 927013806 +4536 + Partials936 560 -376 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ter/plugin/consul/ClusterModuleConsulProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NsdXN0ZXJNb2R1bGVDb25zdWxQcm92aWRlci5qYXZh) | `12.90% <0.00%> (-1.39%)` | `2.00 <0.00> (ø)` | | | [...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...cluster/plugin/etcd/ClusterModuleEtcdProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvQ2x1c3Rlck1vZHVsZUV0Y2RQcm92aWRlci5qYXZh) | `22.22% <0.00%> (-4.45%)` | `2.00 <0.00> (ø)` | | | [...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...in/kubernetes/ClusterModuleKubernetesProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvQ2x1c3Rlck1vZHVsZUt1YmVybmV0ZXNQcm92aWRlci5qYXZh) | `23.52% <0.00%> (-5.05%)` | `2.00 <0.00> (ø)` | | | [...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `12.90% <0.00%> (-1.39%)` | `2.00 <0.00> (ø)` | | | [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ugin/zookeeper/ClusterModuleZookeeperProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL0NsdXN0ZXJNb2R1bGVab29rZWVwZXJQcm92aWRlci5qYXZh) | `10.00% <0.00%> (-0.64%)` | `3.00
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5661: Add health checker for cluster management module
codecov[bot] edited a comment on pull request #5661: URL: https://github.com/apache/skywalking/pull/5661#issuecomment-708093378 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=h1) Report > Merging [#5661](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `19.68%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5661 +/- ## = - Coverage 53.45% 33.76% -19.69% + Complexity 3412 2141 -1271 = Files 880 875-5 Lines 2192521679 -246 Branches 2089 2057 -32 = - Hits 11719 7319 -4400 - Misses 927013798 +4528 + Partials936 562 -374 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ter/plugin/consul/ClusterModuleConsulProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NsdXN0ZXJNb2R1bGVDb25zdWxQcm92aWRlci5qYXZh) | `12.90% <0.00%> (-1.39%)` | `2.00 <0.00> (ø)` | | | [...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...cluster/plugin/etcd/ClusterModuleEtcdProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvQ2x1c3Rlck1vZHVsZUV0Y2RQcm92aWRlci5qYXZh) | `22.22% <0.00%> (-4.45%)` | `2.00 <0.00> (ø)` | | | [...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...in/kubernetes/ClusterModuleKubernetesProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvQ2x1c3Rlck1vZHVsZUt1YmVybmV0ZXNQcm92aWRlci5qYXZh) | `23.52% <0.00%> (-5.05%)` | `2.00 <0.00> (ø)` | | | [...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `12.90% <0.00%> (-1.39%)` | `2.00 <0.00> (ø)` | | | [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ugin/zookeeper/ClusterModuleZookeeperProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL0NsdXN0ZXJNb2R1bGVab29rZWVwZXJQcm92aWRlci5qYXZh) | `10.00% <0.00%> (-0.64%)` | `3.00
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5661: Add health checker for cluster management module
codecov[bot] edited a comment on pull request #5661: URL: https://github.com/apache/skywalking/pull/5661#issuecomment-708093378 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=h1) Report > Merging [#5661](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `26.21%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5661 +/- ## = - Coverage 53.45% 27.23% -26.22% + Complexity 3412 1768 -1644 = Files 880 874-6 Lines 2192521470 -455 Branches 2089 2022 -67 = - Hits 11719 5847 -5872 - Misses 927015205 +5935 + Partials936 418 -518 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ter/plugin/consul/ClusterModuleConsulProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NsdXN0ZXJNb2R1bGVDb25zdWxQcm92aWRlci5qYXZh) | `12.90% <0.00%> (-1.39%)` | `2.00 <0.00> (ø)` | | | [...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...cluster/plugin/etcd/ClusterModuleEtcdProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvQ2x1c3Rlck1vZHVsZUV0Y2RQcm92aWRlci5qYXZh) | `22.22% <0.00%> (-4.45%)` | `2.00 <0.00> (ø)` | | | [...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...in/kubernetes/ClusterModuleKubernetesProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvQ2x1c3Rlck1vZHVsZUt1YmVybmV0ZXNQcm92aWRlci5qYXZh) | `23.52% <0.00%> (-5.05%)` | `2.00 <0.00> (ø)` | | | [...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `12.90% <0.00%> (-1.39%)` | `2.00 <0.00> (ø)` | | | [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ugin/zookeeper/ClusterModuleZookeeperProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL0NsdXN0ZXJNb2R1bGVab29rZWVwZXJQcm92aWRlci5qYXZh) | `10.00% <0.00%> (-0.64%)` | `3.00
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5661: Add health checker for cluster management module
codecov[bot] edited a comment on pull request #5661: URL: https://github.com/apache/skywalking/pull/5661#issuecomment-708093378 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=h1) Report > Merging [#5661](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `26.11%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5661 +/- ## = - Coverage 53.45% 27.33% -26.12% + Complexity 3412 1768 -1644 = Files 880 871-9 Lines 2192521387 -538 Branches 2089 2005 -84 = - Hits 11719 5847 -5872 - Misses 927015122 +5852 + Partials936 418 -518 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ter/plugin/consul/ClusterModuleConsulProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NsdXN0ZXJNb2R1bGVDb25zdWxQcm92aWRlci5qYXZh) | `12.90% <0.00%> (-1.39%)` | `2.00 <0.00> (ø)` | | | [...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...cluster/plugin/etcd/ClusterModuleEtcdProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvQ2x1c3Rlck1vZHVsZUV0Y2RQcm92aWRlci5qYXZh) | `22.22% <0.00%> (-4.45%)` | `2.00 <0.00> (ø)` | | | [...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...in/kubernetes/ClusterModuleKubernetesProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvQ2x1c3Rlck1vZHVsZUt1YmVybmV0ZXNQcm92aWRlci5qYXZh) | `23.52% <0.00%> (-5.05%)` | `2.00 <0.00> (ø)` | | | [...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `12.90% <0.00%> (-1.39%)` | `2.00 <0.00> (ø)` | | | [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ugin/zookeeper/ClusterModuleZookeeperProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL0NsdXN0ZXJNb2R1bGVab29rZWVwZXJQcm92aWRlci5qYXZh) | `10.00% <0.00%> (-0.64%)` | `3.00
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5661: Add health checker for cluster management module
codecov[bot] edited a comment on pull request #5661: URL: https://github.com/apache/skywalking/pull/5661#issuecomment-708093378 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=h1) Report > Merging [#5661](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `53.45%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5661 +/- ## - Coverage 53.45% 0.00% -53.46% Files 880 187 -693 Lines 219254343-17582 Branches 2089 504 -1585 - Hits 11719 0-11719 + Misses 92704343 -4927 + Partials936 0 -936 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [875 more](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5661: Add health checker for cluster management module
codecov[bot] edited a comment on pull request #5661: URL: https://github.com/apache/skywalking/pull/5661#issuecomment-708093378 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=h1) Report > Merging [#5661](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `26.07%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5661 +/- ## = - Coverage 53.45% 27.37% -26.08% + Complexity 3412 1768 -1644 = Files 880 869 -11 Lines 2192521359 -566 Branches 2089 2003 -86 = - Hits 11719 5847 -5872 - Misses 927015094 +5824 + Partials936 418 -518 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ter/plugin/consul/ClusterModuleConsulProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NsdXN0ZXJNb2R1bGVDb25zdWxQcm92aWRlci5qYXZh) | `12.90% <0.00%> (-1.39%)` | `2.00 <0.00> (ø)` | | | [...erver/cluster/plugin/consul/ConsulCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NvbnN1bENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...cluster/plugin/etcd/ClusterModuleEtcdProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvQ2x1c3Rlck1vZHVsZUV0Y2RQcm92aWRlci5qYXZh) | `22.22% <0.00%> (-4.45%)` | `2.00 <0.00> (ø)` | | | [...ap/server/cluster/plugin/etcd/EtcdCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZENvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...in/kubernetes/ClusterModuleKubernetesProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvQ2x1c3Rlck1vZHVsZUt1YmVybmV0ZXNQcm92aWRlci5qYXZh) | `23.52% <0.00%> (-5.05%)` | `2.00 <0.00> (ø)` | | | [...uster/plugin/kubernetes/KubernetesCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1rdWJlcm5ldGVzLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2t1YmVybmV0ZXMvS3ViZXJuZXRlc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh) | `12.90% <0.00%> (-1.39%)` | `2.00 <0.00> (ø)` | | | [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ugin/zookeeper/ClusterModuleZookeeperProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL0NsdXN0ZXJNb2R1bGVab29rZWVwZXJQcm92aWRlci5qYXZh) | `10.00% <0.00%> (-0.64%)` | `3.00
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5661: Add health checker for cluster management module
codecov[bot] edited a comment on pull request #5661: URL: https://github.com/apache/skywalking/pull/5661#issuecomment-708093378 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=h1) Report > Merging [#5661](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `53.45%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5661 +/- ## - Coverage 53.45% 0.00% -53.46% Files 880 166 -714 Lines 219253931-17994 Branches 2089 446 -1643 - Hits 11719 0-11719 + Misses 92703931 -5339 + Partials936 0 -936 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [854 more](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5661: Add health checker for cluster management module
wu-sheng commented on a change in pull request #5661:
URL: https://github.com/apache/skywalking/pull/5661#discussion_r506521308
##
File path:
oap-server/server-cluster-plugin/cluster-consul-plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/consul/ConsulCoordinator.java
##
@@ -49,22 +56,32 @@ public ConsulCoordinator(ClusterModuleConsulConfig config,
Consul client) {
@Override
public List queryRemoteNodes() {
-HealthClient healthClient = client.healthClient();
-
-// Discover only "passing" nodes
-List nodes =
healthClient.getHealthyServiceInstances(serviceName).getResponse();
-
List remoteInstances = new ArrayList<>();
-if (CollectionUtils.isNotEmpty(nodes)) {
-nodes.forEach(node -> {
-if (!Strings.isNullOrEmpty(node.getService().getAddress())) {
-Address address = new
Address(node.getService().getAddress(), node.getService().getPort(), false);
-if (address.equals(selfAddress)) {
-address.setSelf(true);
+try {
+HealthClient healthClient = client.healthClient();
+// Discover only "passing" nodes
+List nodes =
healthClient.getHealthyServiceInstances(serviceName).getResponse();
+if (CollectionUtils.isNotEmpty(nodes)) {
+nodes.forEach(node -> {
+if
(!Strings.isNullOrEmpty(node.getService().getAddress())) {
+Address address = new
Address(node.getService().getAddress(), node.getService().getPort(), false);
+if (address.equals(selfAddress)) {
+address.setSelf(true);
+}
+remoteInstances.add(new RemoteInstance(address));
Review comment:
Same thing should be checked in every coordinator implementation. I
noted that the users usually set up the cluster mode incorrectly, then, blame
SkyWalking insert duplicated data or statistic not accurate.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5661: Add health checker for cluster management module
wu-sheng commented on a change in pull request #5661:
URL: https://github.com/apache/skywalking/pull/5661#discussion_r506519863
##
File path:
oap-server/server-cluster-plugin/cluster-consul-plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/consul/ConsulCoordinator.java
##
@@ -49,22 +56,32 @@ public ConsulCoordinator(ClusterModuleConsulConfig config,
Consul client) {
@Override
public List queryRemoteNodes() {
-HealthClient healthClient = client.healthClient();
-
-// Discover only "passing" nodes
-List nodes =
healthClient.getHealthyServiceInstances(serviceName).getResponse();
-
List remoteInstances = new ArrayList<>();
-if (CollectionUtils.isNotEmpty(nodes)) {
-nodes.forEach(node -> {
-if (!Strings.isNullOrEmpty(node.getService().getAddress())) {
-Address address = new
Address(node.getService().getAddress(), node.getService().getPort(), false);
-if (address.equals(selfAddress)) {
-address.setSelf(true);
+try {
+HealthClient healthClient = client.healthClient();
+// Discover only "passing" nodes
+List nodes =
healthClient.getHealthyServiceInstances(serviceName).getResponse();
+if (CollectionUtils.isNotEmpty(nodes)) {
+nodes.forEach(node -> {
+if
(!Strings.isNullOrEmpty(node.getService().getAddress())) {
+Address address = new
Address(node.getService().getAddress(), node.getService().getPort(), false);
+if (address.equals(selfAddress)) {
+address.setSelf(true);
+}
+remoteInstances.add(new RemoteInstance(address));
Review comment:
If you found `127.0.0.1` or `localhost` exists in the node
list(list#size > 1), then the node should be labeled as unhealthy.
FYI @hanahmily @kezhenxu94 Make sense?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5661: Add health checker for cluster management module
codecov[bot] edited a comment on pull request #5661: URL: https://github.com/apache/skywalking/pull/5661#issuecomment-708093378 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=h1) Report > Merging [#5661](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `53.45%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5661 +/- ## - Coverage 53.45% 0.00% -53.46% Files 880 178 -702 Lines 219254182-17743 Branches 2089 470 -1619 - Hits 11719 0-11719 + Misses 92704182 -5088 + Partials936 0 -936 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [866 more](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5661: Add health checker for cluster management module
codecov[bot] edited a comment on pull request #5661: URL: https://github.com/apache/skywalking/pull/5661#issuecomment-708093378 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=h1) Report > Merging [#5661](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `53.45%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5661 +/- ## - Coverage 53.45% 0.00% -53.46% Files 880 176 -704 Lines 219254140-17785 Branches 2089 466 -1623 - Hits 11719 0-11719 + Misses 92704140 -5130 + Partials936 0 -936 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [864 more](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5661: Add health checker for cluster management module
codecov[bot] edited a comment on pull request #5661: URL: https://github.com/apache/skywalking/pull/5661#issuecomment-708093378 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=h1) Report > Merging [#5661](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `53.45%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5661 +/- ## - Coverage 53.45% 0.00% -53.46% Files 880 174 -706 Lines 219254134-17791 Branches 2089 466 -1623 - Hits 11719 0-11719 + Misses 92704134 -5136 + Partials936 0 -936 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [862 more](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5661: Add health checker for cluster management module
codecov[bot] edited a comment on pull request #5661: URL: https://github.com/apache/skywalking/pull/5661#issuecomment-708093378 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=h1) Report > Merging [#5661](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `53.45%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5661 +/- ## - Coverage 53.45% 0.00% -53.46% Files 880 170 -710 Lines 219254069-17856 Branches 2089 458 -1631 - Hits 11719 0-11719 + Misses 92704069 -5201 + Partials936 0 -936 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [858 more](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5661: Add health checker for cluster management module
codecov[bot] edited a comment on pull request #5661: URL: https://github.com/apache/skywalking/pull/5661#issuecomment-708093378 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=h1) Report > Merging [#5661](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `53.45%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5661 +/- ## - Coverage 53.45% 0.00% -53.46% Files 880 166 -714 Lines 219253960-17965 Branches 2089 450 -1639 - Hits 11719 0-11719 + Misses 92703960 -5310 + Partials936 0 -936 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [854 more](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5661: Add health checker for cluster management module
codecov[bot] edited a comment on pull request #5661: URL: https://github.com/apache/skywalking/pull/5661#issuecomment-708093378 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=h1) Report > Merging [#5661](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `53.45%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5661 +/- ## - Coverage 53.45% 0.00% -53.46% Files 880 169 -711 Lines 219254030-17895 Branches 2089 457 -1632 - Hits 11719 0-11719 + Misses 92704030 -5240 + Partials936 0 -936 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [857 more](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5661: Add health checker for cluster management module
codecov[bot] edited a comment on pull request #5661: URL: https://github.com/apache/skywalking/pull/5661#issuecomment-708093378 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=h1) Report > Merging [#5661](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `53.45%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5661 +/- ## - Coverage 53.45% 0.00% -53.46% Files 880 164 -716 Lines 219253914-18011 Branches 2089 446 -1643 - Hits 11719 0-11719 + Misses 92703914 -5356 + Partials936 0 -936 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [852 more](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5661: Add health checker for cluster management module
codecov[bot] edited a comment on pull request #5661: URL: https://github.com/apache/skywalking/pull/5661#issuecomment-708093378 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=h1) Report > Merging [#5661](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `53.45%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5661 +/- ## - Coverage 53.45% 0.00% -53.46% Files 880 177 -703 Lines 219254127-17798 Branches 2089 475 -1614 - Hits 11719 0-11719 + Misses 92704127 -5143 + Partials936 0 -936 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [865 more](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5661: Add health checker for cluster management module
codecov[bot] edited a comment on pull request #5661: URL: https://github.com/apache/skywalking/pull/5661#issuecomment-708093378 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=h1) Report > Merging [#5661](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `53.45%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5661 +/- ## - Coverage 53.45% 0.00% -53.46% Files 880 175 -705 Lines 219254116-17809 Branches 2089 475 -1614 - Hits 11719 0-11719 + Misses 92704116 -5154 + Partials936 0 -936 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [863 more](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5678: Fix application start duration log "Failed to load class org.slf4j.impl.StaticLoggerBinder."
codecov[bot] edited a comment on pull request #5678: URL: https://github.com/apache/skywalking/pull/5678#issuecomment-709824893 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=h1) Report > Merging [#5678](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `53.45%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5678 +/- ## - Coverage 53.45% 0.00% -53.46% Files 880 165 -715 Lines 219253938-17987 Branches 2089 446 -1643 - Hits 11719 0-11719 + Misses 92703938 -5332 + Partials936 0 -936 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5678?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ng/apm/agent/core/logging/core/AbstractLogger.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0Fic3RyYWN0TG9nZ2VyLmphdmE=) | `0.00% <0.00%> (-55.00%)` | `0.00 <0.00> (-16.00)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-1.00)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [864 more](https://codecov.io/gh/apache/skywalking/pull/5678/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5678: Fix application start duration log "Failed to load class org.slf4j.impl.StaticLoggerBinder."
wu-sheng commented on a change in pull request #5678: URL: https://github.com/apache/skywalking/pull/5678#discussion_r506488320 ## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/dependencies/org/slf4j/impl/StaticLoggerBinder.java ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.apm.dependencies.org.slf4j.impl; + +import org.slf4j.ILoggerFactory; +import org.slf4j.spi.LoggerFactoryBinder; + +/** + * SLF4J LoggerFactoryBinder implementation using Log4j. This class is part of the required classes used to specify an + * SLF4J logger provider implementation. Review comment: ```suggestion * The slf4j-api would try to load org.slf4j.impl.StaticLoggerBinder internal. In the agent core, we add our own implementation * for bridging to SkyWalking internal log component. * Therefore, logs of netty/grpc/kafka(agent shaded components) would output through the SkyWalking's log. * * Don't move this class to any other package, its package must be as same as the shaded org.apache.skywalking.apm.dependencies.org.slf4j.impl ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5661: Add health checker for cluster management module
codecov[bot] edited a comment on pull request #5661: URL: https://github.com/apache/skywalking/pull/5661#issuecomment-708093378 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=h1) Report > Merging [#5661](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `53.45%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5661 +/- ## - Coverage 53.45% 0.00% -53.46% Files 880 173 -707 Lines 219254104-17821 Branches 2089 475 -1614 - Hits 11719 0-11719 + Misses 92704104 -5166 + Partials936 0 -936 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [863 more](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5661: Add health checker for cluster management module
codecov[bot] edited a comment on pull request #5661: URL: https://github.com/apache/skywalking/pull/5661#issuecomment-708093378 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=h1) Report > Merging [#5661](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `53.45%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5661 +/- ## - Coverage 53.45% 0.00% -53.46% Files 880 175 -705 Lines 219254116-17809 Branches 2089 475 -1614 - Hits 11719 0-11719 + Misses 92704116 -5154 + Partials936 0 -936 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [863 more](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5661: Add health checker for cluster management module
codecov[bot] edited a comment on pull request #5661: URL: https://github.com/apache/skywalking/pull/5661#issuecomment-708093378 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=h1) Report > Merging [#5661](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `53.45%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5661 +/- ## - Coverage 53.45% 0.00% -53.46% Files 880 172 -708 Lines 219254088-17837 Branches 2089 471 -1618 - Hits 11719 0-11719 + Misses 92704088 -5182 + Partials936 0 -936 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [862 more](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5661: Add health checker for cluster management module
codecov[bot] edited a comment on pull request #5661: URL: https://github.com/apache/skywalking/pull/5661#issuecomment-708093378 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5661: Add health checker for cluster management module
codecov[bot] edited a comment on pull request #5661: URL: https://github.com/apache/skywalking/pull/5661#issuecomment-708093378 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5661: Add health checker for cluster management module
codecov[bot] edited a comment on pull request #5661: URL: https://github.com/apache/skywalking/pull/5661#issuecomment-708093378 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=h1) Report > Merging [#5661](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/98968122e9887b81b7074945948a732ae6815d7d?el=desc) will **decrease** coverage by `53.45%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5661 +/- ## - Coverage 53.45% 0.00% -53.46% Files 880 187 -693 Lines 219254343-17582 Branches 2089 504 -1585 - Hits 11719 0-11719 + Misses 92704343 -4927 + Partials936 0 -936 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5661?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [875 more](https://codecov.io/gh/apache/skywalking/pull/5661/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5678: Fix application start duration log "Failed to load class org.slf4j.impl.StaticLoggerBinder."
wu-sheng commented on a change in pull request #5678: URL: https://github.com/apache/skywalking/pull/5678#discussion_r506488320 ## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/dependencies/org/slf4j/impl/StaticLoggerBinder.java ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.apm.dependencies.org.slf4j.impl; + +import org.slf4j.ILoggerFactory; +import org.slf4j.spi.LoggerFactoryBinder; + +/** + * SLF4J LoggerFactoryBinder implementation using Log4j. This class is part of the required classes used to specify an + * SLF4J logger provider implementation. Review comment: ```suggestion * The slf4j-api would try to load org.slf4j.impl.StaticLoggerBinder internal. In the agent core, we add our own implementation * for bridging to SkyWalking internal log component. * Therefore, logs of netty/grpc/kafka(agent shaded components) would output through the SkyWalking's log. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
