[GitHub] [skywalking] rootsongjc edited a comment on issue #5534: Using Hugo to refactor Apache SkyWalking's website

2020-11-24 Thread GitBox


rootsongjc edited a comment on issue #5534:
URL: https://github.com/apache/skywalking/issues/5534#issuecomment-731053218


   The first version is basically finished, but there are still some problems 
left, which we can fix slowly. I will submit a PR.
   
   The next issues to be fixed in the next version include:
   - [x] P2:  update the layout of the download page, to allow the download 
addresses of different projects to be flattened on the page using modules.
   - [x] P2:  Events & News section  of the homepage, we should make it 
auto-generated, display the latest 4 events from the event lists
   - [ ] P1: Migrate the documentation, version support needed
   - [ ] P2: Make the projects and documentation page configurable, use the 
YAML or markdown instead of the raw HTML
   - [x] P1: fix the footer display problem
   - [ ] P2: add an arrow on the homepage, jump to the below sections
   - [ ] P2: add screenshots on the homepage



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking-swck] wu-sheng commented on a change in pull request #12: Introduce custom metrics apiserver which is an adapter to OAP cluster

2020-11-24 Thread GitBox


wu-sheng commented on a change in pull request #12:
URL: https://github.com/apache/skywalking-swck/pull/12#discussion_r530162327



##
File path: doc/custom-metrics-adapter.md
##
@@ -0,0 +1,77 @@
+# Custom metrics Adapter
+
+This adapter contains an implementation of [external 
metrics](https://github.com/kubernetes/community/blob/master/contributors/design-proposals/instrumentation/external-metrics-api.md)
+ API. It is therefore suitable for use with the autoscaling/v2 Horizontal Pod 
Autoscaler in Kubernetes 1.6+.
+ 
+
+## Use kustomize to customise your deployment
+
+1. Clone the source code:
+
+```sh
+git clone g...@github.com:apache/skywalking-swck.git
+```
+
+2. Edit file `config/adapter/adapter/kustomization.yaml` file to change your 
preferences. If you prefer to your private 
+ docker image, a quick path to override `ADAPTER_IMG` environment variable : 
`export ADAPTER_IMG=/adapter:`
+
+3. Use `make` to generate the final manifests and deploy:
+
+```sh
+make adapter-deploy
+```
+
+## Configuration
+
+The adapter takes the standard Kubernetes generic API server arguments 
(including those for authentication and authorization). 
+By default, it will attempt to using Kubernetes in-cluster config to connect 
to the cluster.
+
+It takes the following addition arguments specific to configuring how the 
adapter talks to SkyWalking OAP cluster:
+
+ * `--oap-addr` The address of OAP cluster.
+ * `--metric-filter-regex` A regular expression to filter metrics retrieved 
from OAP cluster.
+ * `--refresh-interval` This is the interval at which to update the cache of 
available metrics from OAP cluster. 
+ 
+## HPA Configuration
+
+External metrics allow you to autoscale your cluster based on any metric 
available in OAP cluster. 
+ Just provide a metric block with a `name` and `selector`, and use the 
`External` metric type.
+ 
+```yaml
+- type: External
+  external:
+metric:
+  name: 
+  metricSelector:
+matchLabels:
+  : 
+  ...
+target:
+  
+```
+
+ * metric_name: The name of metric generated by OAL or other subsystem.
+ * label: available `label_key`s are `service` and `label`. 
+  
+ The options of label keys are:
+ * `service` varies in different scopes. If the scope is `Service`, 
`ServiceInstance` and `Endpoint`, the `service` represents
+`serviceName`, `serviceInstanceName` and `endpointName` respectively.

Review comment:
   > We release a binary package actually, 
https://dist.apache.org/repos/dist/release/skywalking/swck/0.1.0/. But it's 
used to build the release image.
   
   This is strange, we have binary on the apache mirror system, but no one is 
able to download it, and no one knows it exists. I think we need to fix this.
   
   Image is another topic, if you want to release that, we need the docker file 
in the release binary tar ball.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] fgksgf commented on issue #5890: [CLI] Incorrect instance and enpoint level query implementation

2020-11-24 Thread GitBox


fgksgf commented on issue #5890:
URL: https://github.com/apache/skywalking/issues/5890#issuecomment-733526264


   Make sense to me



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5835:
URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) 
Report
   > Merging 
[#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=desc) 
(32f7738) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `1.71%`.
   > The diff coverage is `48.62%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5835/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5835  +/-   ##
   
   - Coverage 51.22%   49.50%   -1.72% 
   + Complexity 3497 3398  -99 
   
 Files  1661 1662   +1 
 Lines 3565935671  +12 
 Branches   3910 3903   -7 
   
   - Hits  1826617660 -606 
   - Misses1648517102 +617 
   - Partials908  909   +1 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...meter/analyzer/dsl/ExpressionParsingException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nRXhjZXB0aW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...e/skywalking/oap/server/receiver/otel/Handler.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../receiver/otel/HandlerInitializationException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVySW5pdGlhbGl6YXRpb25FeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...server/receiver/otel/OtelMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJDb25maWcuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...server/receiver/otel/OtelMetricReceiverModule.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJNb2R1bGUuamF2YQ==)
 | `66.66% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...g/oap/server/receiver/otel/oc/OCMetricHandler.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9vYy9PQ01ldHJpY0hhbmRsZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...storage/plugin/jdbc/h2/dao/H2MetadataQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0YWRhdGFRdWVyeURBTy5qYXZh)
 | `49.34% <0.00%> (ø)` | `12.00 <0.00> (ø)` | |
   | 
[...rver/receiver/otel/OtelMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJQcm92aWRlci5qYXZh)
 | `16.66% <20.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...king/oap/meter/analyzer/prometheus/rule/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9ydWxlL1J1bGVzLmphdmE=)
 | `58.33% <42.85%> (-8.34%)` | `3.00 <0.00> (ø)` | |
   | 
[...ache/skywalking/oap/meter/analyzer/dsl/Result.java](https://codecov.io/gh/apache/skywalkin

[GitHub] [skywalking] kezhenxu94 edited a comment on issue #5890: [CLI] Incorrect instance and enpoint level query implementation

2020-11-24 Thread GitBox


kezhenxu94 edited a comment on issue #5890:
URL: https://github.com/apache/skywalking/issues/5890#issuecomment-733525745


   > > I added a bool flag named unnormal, it's not required. Because the 
default value of bool is true.
   > > If we create a isNormal flag, we probably have to add this flag most of 
the time.
   > > What do you think ?
   > 
   > I think this is only coding style. You could give the parameter `true` if 
no input parameter. Right? `unnormal` is anti-protocol, which should not be 
recommended.
   
   +1, @fgksgf make `isNormal` type of string, and give it default value 
`"true"`, and validate that it should be either `"true"` or `"false"`



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] kezhenxu94 commented on issue #5890: [CLI] Incorrect instance and enpoint level query implementation

2020-11-24 Thread GitBox


kezhenxu94 commented on issue #5890:
URL: https://github.com/apache/skywalking/issues/5890#issuecomment-733525745


   > > I added a bool flag named unnormal, it's not required. Because the 
default value of bool is true.
   > > If we create a isNormal flag, we probably have to add this flag most of 
the time.
   > > What do you think ?
   > 
   > I think this is only coding style. You could give the parameter `true` if 
no input parameter. Right? `unnormal` is anti-protocol, which should not be 
recommended.
   
   +1, @fgksgf make `isNormal` type of string, and give it default value 
`true`, and validate that it should be either `true` or `false`



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking-swck] hanahmily commented on a change in pull request #12: Introduce custom metrics apiserver which is an adapter to OAP cluster

2020-11-24 Thread GitBox


hanahmily commented on a change in pull request #12:
URL: https://github.com/apache/skywalking-swck/pull/12#discussion_r530160629



##
File path: doc/custom-metrics-adapter.md
##
@@ -0,0 +1,77 @@
+# Custom metrics Adapter
+
+This adapter contains an implementation of [external 
metrics](https://github.com/kubernetes/community/blob/master/contributors/design-proposals/instrumentation/external-metrics-api.md)
+ API. It is therefore suitable for use with the autoscaling/v2 Horizontal Pod 
Autoscaler in Kubernetes 1.6+.
+ 
+
+## Use kustomize to customise your deployment
+
+1. Clone the source code:
+
+```sh
+git clone g...@github.com:apache/skywalking-swck.git
+```
+
+2. Edit file `config/adapter/adapter/kustomization.yaml` file to change your 
preferences. If you prefer to your private 
+ docker image, a quick path to override `ADAPTER_IMG` environment variable : 
`export ADAPTER_IMG=/adapter:`
+
+3. Use `make` to generate the final manifests and deploy:
+
+```sh
+make adapter-deploy
+```
+
+## Configuration
+
+The adapter takes the standard Kubernetes generic API server arguments 
(including those for authentication and authorization). 
+By default, it will attempt to using Kubernetes in-cluster config to connect 
to the cluster.
+
+It takes the following addition arguments specific to configuring how the 
adapter talks to SkyWalking OAP cluster:
+
+ * `--oap-addr` The address of OAP cluster.
+ * `--metric-filter-regex` A regular expression to filter metrics retrieved 
from OAP cluster.
+ * `--refresh-interval` This is the interval at which to update the cache of 
available metrics from OAP cluster. 
+ 
+## HPA Configuration
+
+External metrics allow you to autoscale your cluster based on any metric 
available in OAP cluster. 
+ Just provide a metric block with a `name` and `selector`, and use the 
`External` metric type.
+ 
+```yaml
+- type: External
+  external:
+metric:
+  name: 
+  metricSelector:
+matchLabels:
+  : 
+  ...
+target:
+  
+```
+
+ * metric_name: The name of metric generated by OAL or other subsystem.
+ * label: available `label_key`s are `service` and `label`. 
+  
+ The options of label keys are:
+ * `service` varies in different scopes. If the scope is `Service`, 
`ServiceInstance` and `Endpoint`, the `service` represents
+`serviceName`, `serviceInstanceName` and `endpointName` respectively.

Review comment:
   > there is only a source release
   
   We release a binary package actually, 
https://dist.apache.org/repos/dist/release/skywalking/swck/0.1.0/. But it's 
used to build the release image. The binary can't be run outside kubernetes, 
that's the reason I didn't add a link to our website. In the next 
release/0.2.0, I will add adapter binary into it.
   
   The image release strategy is since binary release package contains 
`operator` and `adapter`, I will add them to a single image called 
`apache/skywalking-swck`. The default entry point of the image is `operator`, 
if uses want to run adapter, they should add `command: /bin/adapter` to the pod 
container node. 
   
   You might notice that there are two different images for the operator and 
adapter respectively. They are only for dev purposes. The docker file of the 
release version is going to be submitted soon.
   






This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] wu-sheng commented on issue #5890: [CLI] Incorrect instance and enpoint level query implementation

2020-11-24 Thread GitBox


wu-sheng commented on issue #5890:
URL: https://github.com/apache/skywalking/issues/5890#issuecomment-733524157


   > I added a bool flag named unnormal, it's not required. Because the default 
value of bool is true.
   If we create a isNormal flag, we probably have to add this flag most of the 
time.
   What do you think ?
   
   I think this is only coding style. You could give the parameter `true` if no 
input parameter. Right? `unnormal` is anti-protocol, which should not be 
recommended.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5835:
URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) 
Report
   > Merging 
[#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=desc) 
(32f7738) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `1.12%`.
   > The diff coverage is `48.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5835/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5835  +/-   ##
   
   - Coverage 51.22%   50.10%   -1.13% 
   + Complexity 3497 3398  -99 
   
 Files  1661  906 -755 
 Lines 3565922692   -12967 
 Branches   3910 2190-1720 
   
   - Hits  1826611369-6897 
   + Misses1648510389-6096 
   - Partials908  934  +26 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...meter/analyzer/dsl/ExpressionParsingException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nRXhjZXB0aW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...e/skywalking/oap/server/receiver/otel/Handler.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../receiver/otel/HandlerInitializationException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVySW5pdGlhbGl6YXRpb25FeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...server/receiver/otel/OtelMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJDb25maWcuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...server/receiver/otel/OtelMetricReceiverModule.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJNb2R1bGUuamF2YQ==)
 | `66.66% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...g/oap/server/receiver/otel/oc/OCMetricHandler.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9vYy9PQ01ldHJpY0hhbmRsZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...storage/plugin/jdbc/h2/dao/H2MetadataQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0YWRhdGFRdWVyeURBTy5qYXZh)
 | `49.34% <0.00%> (ø)` | `12.00 <0.00> (ø)` | |
   | 
[...rver/receiver/otel/OtelMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJQcm92aWRlci5qYXZh)
 | `16.66% <20.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...king/oap/meter/analyzer/prometheus/rule/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9ydWxlL1J1bGVzLmphdmE=)
 | `58.33% <42.85%> (-8.34%)` | `3.00 <0.00> (ø)` | |
   | 
[.../skywalking/oap/meter/analyzer/dsl/Expression.java](https://codecov.io/gh/apache/skywalkin

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5835:
URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) 
Report
   > Merging 
[#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=desc) 
(70ad9ec) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `20.22%`.
   > The diff coverage is `1.47%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5835/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5835   +/-   ##
   =
   - Coverage 51.22%   31.00%   -20.23% 
   + Complexity 3497 1849 -1648 
   =
 Files  1661  758  -903 
 Lines 3565918967-16692 
 Branches   3910 1749 -2161 
   =
   - Hits  18266 5880-12386 
   + Misses1648512675 -3810 
   + Partials908  412  -496 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==)
 | `0.00% <0.00%> (-67.09%)` | `0.00 <0.00> (-14.00)` | |
   | 
[...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh)
 | `0.00% <0.00%> (-78.27%)` | `0.00 <0.00> (-8.00)` | |
   | 
[.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh)
 | `0.00% <0.00%> (-83.34%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../skywalking/oap/meter/analyzer/dsl/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb24uamF2YQ==)
 | `0.00% <0.00%> (-70.59%)` | `0.00 <0.00> (-5.00)` | |
   | 
[...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...meter/analyzer/dsl/ExpressionParsingException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nRXhjZXB0aW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ache/skywalking/oap/meter/analyzer/dsl/Result.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1Jlc3VsdC5qYXZh)
 | `0.00% <0.00%> (-60.00%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh)
 | `0.00% <0.00%> (-52.28%)` | `0.00 <0.00> (-55.00)` | |
   | 
[...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=)
 | `0.00% <0.00%> (-90.15%)` | `0.00 <0.00> (-20.00)` | |
   | 
[...king/oap/meter/analyzer/prometheus/rule/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9ydWxlL1J1bGVzLmphdmE=)
 | `0.00% <0.00%> (-66.67%)` | `0.00 <0.00> (-3.00)

[GitHub] [skywalking-cli] kezhenxu94 commented on a change in pull request #76: Add flags of instance, endpoint and normal for metrics command

2020-11-24 Thread GitBox


kezhenxu94 commented on a change in pull request #76:
URL: https://github.com/apache/skywalking-cli/pull/76#discussion_r530158976



##
File path: commands/metrics/single/single-metrics.go
##
@@ -49,7 +49,9 @@ var Command = cli.Command{
 
metricsName := ctx.String("name")
serviceName := ctx.String("service")
-   normal := true
+   normal := !ctx.Bool("unnoraml")

Review comment:
   
   ```suggestion
normal := !ctx.Bool("unnormal")
   ```





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5835:
URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) 
Report
   > Merging 
[#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=desc) 
(32f7738) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `1.21%`.
   > The diff coverage is `48.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5835/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5835  +/-   ##
   
   - Coverage 51.22%   50.00%   -1.22% 
   + Complexity 3497 3391 -106 
   
 Files  1661  906 -755 
 Lines 3565922692   -12967 
 Branches   3910 2190-1720 
   
   - Hits  1826611347-6919 
   + Misses1648510409-6076 
   - Partials908  936  +28 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...meter/analyzer/dsl/ExpressionParsingException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nRXhjZXB0aW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...e/skywalking/oap/server/receiver/otel/Handler.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../receiver/otel/HandlerInitializationException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVySW5pdGlhbGl6YXRpb25FeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...server/receiver/otel/OtelMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJDb25maWcuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...server/receiver/otel/OtelMetricReceiverModule.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJNb2R1bGUuamF2YQ==)
 | `66.66% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...g/oap/server/receiver/otel/oc/OCMetricHandler.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9vYy9PQ01ldHJpY0hhbmRsZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...storage/plugin/jdbc/h2/dao/H2MetadataQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0YWRhdGFRdWVyeURBTy5qYXZh)
 | `49.34% <0.00%> (ø)` | `12.00 <0.00> (ø)` | |
   | 
[...rver/receiver/otel/OtelMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJQcm92aWRlci5qYXZh)
 | `16.66% <20.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...king/oap/meter/analyzer/prometheus/rule/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9ydWxlL1J1bGVzLmphdmE=)
 | `58.33% <42.85%> (-8.34%)` | `3.00 <0.00> (ø)` | |
   | 
[.../skywalking/oap/meter/analyzer/dsl/Expression.java](https://codecov.io/gh/apache/skywalkin

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5835:
URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) 
Report
   > Merging 
[#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=desc) 
(32f7738) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `1.96%`.
   > The diff coverage is `48.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5835/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5835  +/-   ##
   
   - Coverage 51.22%   49.26%   -1.97% 
   + Complexity 3497 3347 -150 
   
 Files  1661  906 -755 
 Lines 3565922692   -12967 
 Branches   3910 2190-1720 
   
   - Hits  1826611179-7087 
   + Misses1648510590-5895 
   - Partials908  923  +15 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...meter/analyzer/dsl/ExpressionParsingException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nRXhjZXB0aW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...e/skywalking/oap/server/receiver/otel/Handler.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../receiver/otel/HandlerInitializationException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVySW5pdGlhbGl6YXRpb25FeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...server/receiver/otel/OtelMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJDb25maWcuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...server/receiver/otel/OtelMetricReceiverModule.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJNb2R1bGUuamF2YQ==)
 | `66.66% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...g/oap/server/receiver/otel/oc/OCMetricHandler.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9vYy9PQ01ldHJpY0hhbmRsZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...storage/plugin/jdbc/h2/dao/H2MetadataQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0YWRhdGFRdWVyeURBTy5qYXZh)
 | `49.34% <0.00%> (ø)` | `12.00 <0.00> (ø)` | |
   | 
[...rver/receiver/otel/OtelMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJQcm92aWRlci5qYXZh)
 | `16.66% <20.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...king/oap/meter/analyzer/prometheus/rule/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9ydWxlL1J1bGVzLmphdmE=)
 | `58.33% <42.85%> (-8.34%)` | `3.00 <0.00> (ø)` | |
   | 
[.../skywalking/oap/meter/analyzer/dsl/Expression.java](https://codecov.io/gh/apache/skywalkin

[GitHub] [skywalking] fgksgf edited a comment on issue #5890: [CLI] Incorrect instance and enpoint level query implementation

2020-11-24 Thread GitBox


fgksgf edited a comment on issue #5890:
URL: https://github.com/apache/skywalking/issues/5890#issuecomment-733510093


   @wu-sheng 
   I added a bool flag named `unnormal`, it's not required. Because the default 
value of `bool` is `true`.
   If we create a `isNormal` flag, we probably have to add this flag most of 
the time.
   What do you think ?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5835:
URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) 
Report
   > Merging 
[#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=desc) 
(32f7738) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `1.98%`.
   > The diff coverage is `48.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5835/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5835  +/-   ##
   
   - Coverage 51.22%   49.24%   -1.99% 
   + Complexity 3497 3343 -154 
   
 Files  1661  906 -755 
 Lines 3565922692   -12967 
 Branches   3910 2190-1720 
   
   - Hits  1826611174-7092 
   + Misses1648510591-5894 
   - Partials908  927  +19 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...meter/analyzer/dsl/ExpressionParsingException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nRXhjZXB0aW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...e/skywalking/oap/server/receiver/otel/Handler.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../receiver/otel/HandlerInitializationException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVySW5pdGlhbGl6YXRpb25FeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...server/receiver/otel/OtelMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJDb25maWcuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...server/receiver/otel/OtelMetricReceiverModule.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJNb2R1bGUuamF2YQ==)
 | `66.66% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...g/oap/server/receiver/otel/oc/OCMetricHandler.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9vYy9PQ01ldHJpY0hhbmRsZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...storage/plugin/jdbc/h2/dao/H2MetadataQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0YWRhdGFRdWVyeURBTy5qYXZh)
 | `49.34% <0.00%> (ø)` | `12.00 <0.00> (ø)` | |
   | 
[...rver/receiver/otel/OtelMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJQcm92aWRlci5qYXZh)
 | `16.66% <20.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...king/oap/meter/analyzer/prometheus/rule/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9ydWxlL1J1bGVzLmphdmE=)
 | `58.33% <42.85%> (-8.34%)` | `3.00 <0.00> (ø)` | |
   | 
[.../skywalking/oap/meter/analyzer/dsl/Expression.java](https://codecov.io/gh/apache/skywalkin

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5835:
URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) 
Report
   > Merging 
[#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=desc) 
(32f7738) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `1.98%`.
   > The diff coverage is `48.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5835/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5835  +/-   ##
   
   - Coverage 51.22%   49.23%   -1.99% 
   + Complexity 3497 3343 -154 
   
 Files  1661  906 -755 
 Lines 3565922692   -12967 
 Branches   3910 2190-1720 
   
   - Hits  1826611173-7093 
   + Misses1648510592-5893 
   - Partials908  927  +19 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...meter/analyzer/dsl/ExpressionParsingException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nRXhjZXB0aW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...e/skywalking/oap/server/receiver/otel/Handler.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../receiver/otel/HandlerInitializationException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVySW5pdGlhbGl6YXRpb25FeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...server/receiver/otel/OtelMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJDb25maWcuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...server/receiver/otel/OtelMetricReceiverModule.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJNb2R1bGUuamF2YQ==)
 | `66.66% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...g/oap/server/receiver/otel/oc/OCMetricHandler.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9vYy9PQ01ldHJpY0hhbmRsZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...storage/plugin/jdbc/h2/dao/H2MetadataQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0YWRhdGFRdWVyeURBTy5qYXZh)
 | `49.34% <0.00%> (ø)` | `12.00 <0.00> (ø)` | |
   | 
[...rver/receiver/otel/OtelMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJQcm92aWRlci5qYXZh)
 | `16.66% <20.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...king/oap/meter/analyzer/prometheus/rule/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9ydWxlL1J1bGVzLmphdmE=)
 | `58.33% <42.85%> (-8.34%)` | `3.00 <0.00> (ø)` | |
   | 
[.../skywalking/oap/meter/analyzer/dsl/Expression.java](https://codecov.io/gh/apache/skywalkin

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5835:
URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) 
Report
   > Merging 
[#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=desc) 
(32f7738) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `2.00%`.
   > The diff coverage is `48.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5835/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5835  +/-   ##
   
   - Coverage 51.22%   49.21%   -2.01% 
   + Complexity 3497 3342 -155 
   
 Files  1661  906 -755 
 Lines 3565922692   -12967 
 Branches   3910 2190-1720 
   
   - Hits  1826611169-7097 
   + Misses1648510596-5889 
   - Partials908  927  +19 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...meter/analyzer/dsl/ExpressionParsingException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nRXhjZXB0aW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...e/skywalking/oap/server/receiver/otel/Handler.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../receiver/otel/HandlerInitializationException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVySW5pdGlhbGl6YXRpb25FeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...server/receiver/otel/OtelMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJDb25maWcuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...server/receiver/otel/OtelMetricReceiverModule.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJNb2R1bGUuamF2YQ==)
 | `66.66% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...g/oap/server/receiver/otel/oc/OCMetricHandler.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9vYy9PQ01ldHJpY0hhbmRsZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...storage/plugin/jdbc/h2/dao/H2MetadataQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0YWRhdGFRdWVyeURBTy5qYXZh)
 | `49.34% <0.00%> (ø)` | `12.00 <0.00> (ø)` | |
   | 
[...rver/receiver/otel/OtelMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJQcm92aWRlci5qYXZh)
 | `16.66% <20.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...king/oap/meter/analyzer/prometheus/rule/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9ydWxlL1J1bGVzLmphdmE=)
 | `58.33% <42.85%> (-8.34%)` | `3.00 <0.00> (ø)` | |
   | 
[.../skywalking/oap/meter/analyzer/dsl/Expression.java](https://codecov.io/gh/apache/skywalkin

[GitHub] [skywalking-cli] kezhenxu94 commented on a change in pull request #76: Add flags of instance, endpoint and normal for metrics command

2020-11-24 Thread GitBox


kezhenxu94 commented on a change in pull request #76:
URL: https://github.com/apache/skywalking-cli/pull/76#discussion_r530155231



##
File path: assets/assets.gen.go
##
@@ -17,6 +17,8 @@
 
 // Code generated by go-bindata. DO NOT EDIT.
 // sources:
+// .DS_Store (6.148kB)

Review comment:
   Remove this file on your local directory, rerun `make codegen`, 
`assets.gen.go` should be intact in this PR





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking-cli] kezhenxu94 commented on a change in pull request #76: Add flags of instance, endpoint and normal for metrics command

2020-11-24 Thread GitBox


kezhenxu94 commented on a change in pull request #76:
URL: https://github.com/apache/skywalking-cli/pull/76#discussion_r530155231



##
File path: assets/assets.gen.go
##
@@ -17,6 +17,8 @@
 
 // Code generated by go-bindata. DO NOT EDIT.
 // sources:
+// .DS_Store (6.148kB)

Review comment:
   Remove this file on your local directory, `assets.gen.go` should be 
intact in this PR





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5835:
URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) 
Report
   > Merging 
[#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=desc) 
(32f7738) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `1.98%`.
   > The diff coverage is `48.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5835/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5835  +/-   ##
   
   - Coverage 51.22%   49.23%   -1.99% 
   + Complexity 3497 3342 -155 
   
 Files  1661  906 -755 
 Lines 3565922684   -12975 
 Branches   3910 2175-1735 
   
   - Hits  1826611169-7097 
   + Misses1648510588-5897 
   - Partials908  927  +19 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...meter/analyzer/dsl/ExpressionParsingException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nRXhjZXB0aW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...e/skywalking/oap/server/receiver/otel/Handler.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../receiver/otel/HandlerInitializationException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVySW5pdGlhbGl6YXRpb25FeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...server/receiver/otel/OtelMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJDb25maWcuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...server/receiver/otel/OtelMetricReceiverModule.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJNb2R1bGUuamF2YQ==)
 | `66.66% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...g/oap/server/receiver/otel/oc/OCMetricHandler.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9vYy9PQ01ldHJpY0hhbmRsZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...storage/plugin/jdbc/h2/dao/H2MetadataQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0YWRhdGFRdWVyeURBTy5qYXZh)
 | `49.66% <0.00%> (+0.32%)` | `12.00 <0.00> (ø)` | |
   | 
[...rver/receiver/otel/OtelMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJQcm92aWRlci5qYXZh)
 | `16.66% <20.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...king/oap/meter/analyzer/prometheus/rule/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9ydWxlL1J1bGVzLmphdmE=)
 | `58.33% <42.85%> (-8.34%)` | `3.00 <0.00> (ø)` | |
   | 
[.../skywalking/oap/meter/analyzer/dsl/Expression.java](https://codecov.io/gh/apache/skyw

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5835:
URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) 
Report
   > Merging 
[#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=desc) 
(32f7738) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `4.07%`.
   > The diff coverage is `48.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5835/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5835  +/-   ##
   
   - Coverage 51.22%   47.14%   -4.08% 
   + Complexity 3497 2631 -866 
   
 Files  1661  759 -902 
 Lines 3565919270   -16389 
 Branches   3910 1788-2122 
   
   - Hits  18266 9085-9181 
   + Misses16485 9517-6968 
   + Partials908  668 -240 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...meter/analyzer/dsl/ExpressionParsingException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nRXhjZXB0aW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...e/skywalking/oap/server/receiver/otel/Handler.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../receiver/otel/HandlerInitializationException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVySW5pdGlhbGl6YXRpb25FeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...server/receiver/otel/OtelMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJDb25maWcuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...server/receiver/otel/OtelMetricReceiverModule.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJNb2R1bGUuamF2YQ==)
 | `66.66% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...g/oap/server/receiver/otel/oc/OCMetricHandler.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9vYy9PQ01ldHJpY0hhbmRsZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...storage/plugin/jdbc/h2/dao/H2MetadataQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0YWRhdGFRdWVyeURBTy5qYXZh)
 | `49.66% <0.00%> (+0.32%)` | `12.00 <0.00> (ø)` | |
   | 
[...rver/receiver/otel/OtelMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJQcm92aWRlci5qYXZh)
 | `16.66% <20.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...king/oap/meter/analyzer/prometheus/rule/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9ydWxlL1J1bGVzLmphdmE=)
 | `58.33% <42.85%> (-8.34%)` | `3.00 <0.00> (ø)` | |
   | 
[.../skywalking/oap/meter/analyzer/dsl/Expression.java](https://codecov.io/gh/apache/skyw

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5835:
URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) 
Report
   > Merging 
[#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=desc) 
(32f7738) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `4.94%`.
   > The diff coverage is `48.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5835/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5835  +/-   ##
   
   - Coverage 51.22%   46.27%   -4.95% 
   + Complexity 3497 2593 -904 
   
 Files  1661  759 -902 
 Lines 3565919267   -16392 
 Branches   3910 1788-2122 
   
   - Hits  18266 8916-9350 
   + Misses16485 9683-6802 
   + Partials908  668 -240 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...meter/analyzer/dsl/ExpressionParsingException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nRXhjZXB0aW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...e/skywalking/oap/server/receiver/otel/Handler.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../receiver/otel/HandlerInitializationException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVySW5pdGlhbGl6YXRpb25FeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...server/receiver/otel/OtelMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJDb25maWcuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...server/receiver/otel/OtelMetricReceiverModule.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJNb2R1bGUuamF2YQ==)
 | `66.66% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...g/oap/server/receiver/otel/oc/OCMetricHandler.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9vYy9PQ01ldHJpY0hhbmRsZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...storage/plugin/jdbc/h2/dao/H2MetadataQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0YWRhdGFRdWVyeURBTy5qYXZh)
 | `49.66% <0.00%> (+0.32%)` | `12.00 <0.00> (ø)` | |
   | 
[...rver/receiver/otel/OtelMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJQcm92aWRlci5qYXZh)
 | `16.66% <20.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...king/oap/meter/analyzer/prometheus/rule/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9ydWxlL1J1bGVzLmphdmE=)
 | `58.33% <42.85%> (-8.34%)` | `3.00 <0.00> (ø)` | |
   | 
[.../skywalking/oap/meter/analyzer/dsl/Expression.java](https://codecov.io/gh/apache/skyw

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5835:
URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) 
Report
   > Merging 
[#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=desc) 
(32f7738) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `5.40%`.
   > The diff coverage is `48.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5835/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5835  +/-   ##
   
   - Coverage 51.22%   45.82%   -5.41% 
   + Complexity 3497 2563 -934 
   
 Files  1661  759 -902 
 Lines 3565919239   -16420 
 Branches   3910 1783-2127 
   
   - Hits  18266 8816-9450 
   + Misses16485 9761-6724 
   + Partials908  662 -246 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...meter/analyzer/dsl/ExpressionParsingException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nRXhjZXB0aW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...e/skywalking/oap/server/receiver/otel/Handler.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../receiver/otel/HandlerInitializationException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVySW5pdGlhbGl6YXRpb25FeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...server/receiver/otel/OtelMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJDb25maWcuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...server/receiver/otel/OtelMetricReceiverModule.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJNb2R1bGUuamF2YQ==)
 | `66.66% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...g/oap/server/receiver/otel/oc/OCMetricHandler.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9vYy9PQ01ldHJpY0hhbmRsZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...storage/plugin/jdbc/h2/dao/H2MetadataQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0YWRhdGFRdWVyeURBTy5qYXZh)
 | `49.66% <0.00%> (+0.32%)` | `12.00 <0.00> (ø)` | |
   | 
[...rver/receiver/otel/OtelMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJQcm92aWRlci5qYXZh)
 | `16.66% <20.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...king/oap/meter/analyzer/prometheus/rule/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9ydWxlL1J1bGVzLmphdmE=)
 | `58.33% <42.85%> (-8.34%)` | `3.00 <0.00> (ø)` | |
   | 
[.../skywalking/oap/meter/analyzer/dsl/Expression.java](https://codecov.io/gh/apache/skyw

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5835:
URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) 
Report
   > Merging 
[#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=desc) 
(32f7738) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `5.83%`.
   > The diff coverage is `48.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5835/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5835  +/-   ##
   
   - Coverage 51.22%   45.38%   -5.84% 
   + Complexity 3497 2529 -968 
   
 Files  1661  759 -902 
 Lines 3565919215   -16444 
 Branches   3910 1782-2128 
   
   - Hits  18266 8721-9545 
   + Misses16485 9841-6644 
   + Partials908  653 -255 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...meter/analyzer/dsl/ExpressionParsingException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nRXhjZXB0aW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...e/skywalking/oap/server/receiver/otel/Handler.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../receiver/otel/HandlerInitializationException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVySW5pdGlhbGl6YXRpb25FeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...server/receiver/otel/OtelMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJDb25maWcuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...server/receiver/otel/OtelMetricReceiverModule.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJNb2R1bGUuamF2YQ==)
 | `66.66% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...g/oap/server/receiver/otel/oc/OCMetricHandler.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9vYy9PQ01ldHJpY0hhbmRsZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...storage/plugin/jdbc/h2/dao/H2MetadataQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0YWRhdGFRdWVyeURBTy5qYXZh)
 | `49.66% <0.00%> (+0.32%)` | `12.00 <0.00> (ø)` | |
   | 
[...rver/receiver/otel/OtelMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJQcm92aWRlci5qYXZh)
 | `16.66% <20.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...king/oap/meter/analyzer/prometheus/rule/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9ydWxlL1J1bGVzLmphdmE=)
 | `58.33% <42.85%> (-8.34%)` | `3.00 <0.00> (ø)` | |
   | 
[.../skywalking/oap/meter/analyzer/dsl/Expression.java](https://codecov.io/gh/apache/skyw

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5835:
URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) 
Report
   > Merging 
[#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=desc) 
(32f7738) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `11.42%`.
   > The diff coverage is `1.47%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5835/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5835   +/-   ##
   =
   - Coverage 51.22%   39.79%   -11.43% 
   + Complexity 3497 2197 -1300 
   =
 Files  1661  758  -903 
 Lines 3565918999-16660 
 Branches   3910 1747 -2163 
   =
   - Hits  18266 7561-10705 
   + Misses1648510909 -5576 
   + Partials908  529  -379 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==)
 | `0.00% <0.00%> (-67.09%)` | `0.00 <0.00> (-14.00)` | |
   | 
[...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh)
 | `0.00% <0.00%> (-78.27%)` | `0.00 <0.00> (-8.00)` | |
   | 
[.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh)
 | `0.00% <0.00%> (-83.34%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../skywalking/oap/meter/analyzer/dsl/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb24uamF2YQ==)
 | `0.00% <0.00%> (-70.59%)` | `0.00 <0.00> (-5.00)` | |
   | 
[...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...meter/analyzer/dsl/ExpressionParsingException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nRXhjZXB0aW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ache/skywalking/oap/meter/analyzer/dsl/Result.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1Jlc3VsdC5qYXZh)
 | `0.00% <0.00%> (-60.00%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh)
 | `0.00% <0.00%> (-52.28%)` | `0.00 <0.00> (-55.00)` | |
   | 
[...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=)
 | `0.00% <0.00%> (-90.15%)` | `0.00 <0.00> (-20.00)` | |
   | 
[...king/oap/meter/analyzer/prometheus/rule/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9ydWxlL1J1bGVzLmphdmE=)
 | `0.00% <0.00%> (-66.67%)` | `0.00 <0.00> (-3.00)

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5835:
URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) 
Report
   > Merging 
[#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=desc) 
(32f7738) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `12.17%`.
   > The diff coverage is `1.47%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5835/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5835   +/-   ##
   =
   - Coverage 51.22%   39.04%   -12.18% 
   + Complexity 3497 2156 -1341 
   =
 Files  1661  758  -903 
 Lines 3565918999-16660 
 Branches   3910 1747 -2163 
   =
   - Hits  18266 7418-10848 
   + Misses1648511053 -5432 
   + Partials908  528  -380 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==)
 | `0.00% <0.00%> (-67.09%)` | `0.00 <0.00> (-14.00)` | |
   | 
[...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh)
 | `0.00% <0.00%> (-78.27%)` | `0.00 <0.00> (-8.00)` | |
   | 
[.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh)
 | `0.00% <0.00%> (-83.34%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../skywalking/oap/meter/analyzer/dsl/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb24uamF2YQ==)
 | `0.00% <0.00%> (-70.59%)` | `0.00 <0.00> (-5.00)` | |
   | 
[...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...meter/analyzer/dsl/ExpressionParsingException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nRXhjZXB0aW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ache/skywalking/oap/meter/analyzer/dsl/Result.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1Jlc3VsdC5qYXZh)
 | `0.00% <0.00%> (-60.00%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh)
 | `0.00% <0.00%> (-52.28%)` | `0.00 <0.00> (-55.00)` | |
   | 
[...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=)
 | `0.00% <0.00%> (-90.15%)` | `0.00 <0.00> (-20.00)` | |
   | 
[...king/oap/meter/analyzer/prometheus/rule/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9ydWxlL1J1bGVzLmphdmE=)
 | `0.00% <0.00%> (-66.67%)` | `0.00 <0.00> (-3.00)

[GitHub] [skywalking-cli] wu-sheng commented on pull request #76: Add flags of instance, endpoint and normal for metrics command

2020-11-24 Thread GitBox


wu-sheng commented on pull request #76:
URL: https://github.com/apache/skywalking-cli/pull/76#issuecomment-733514659


   Read this https://github.com/apache/skywalking-cli/pull/74



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5835:
URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) 
Report
   > Merging 
[#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=desc) 
(32f7738) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `12.22%`.
   > The diff coverage is `1.47%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5835/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5835   +/-   ##
   =
   - Coverage 51.22%   39.00%   -12.23% 
   + Complexity 3497 2103 -1394 
   =
 Files  1661  741  -920 
 Lines 3565918520-17139 
 Branches   3910 1701 -2209 
   =
   - Hits  18266 7223-11043 
   + Misses1648510783 -5702 
   + Partials908  514  -394 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==)
 | `0.00% <0.00%> (-67.09%)` | `0.00 <0.00> (-14.00)` | |
   | 
[...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh)
 | `0.00% <0.00%> (-78.27%)` | `0.00 <0.00> (-8.00)` | |
   | 
[.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh)
 | `0.00% <0.00%> (-83.34%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../skywalking/oap/meter/analyzer/dsl/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb24uamF2YQ==)
 | `0.00% <0.00%> (-70.59%)` | `0.00 <0.00> (-5.00)` | |
   | 
[...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...meter/analyzer/dsl/ExpressionParsingException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nRXhjZXB0aW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ache/skywalking/oap/meter/analyzer/dsl/Result.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1Jlc3VsdC5qYXZh)
 | `0.00% <0.00%> (-60.00%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh)
 | `0.00% <0.00%> (-52.28%)` | `0.00 <0.00> (-55.00)` | |
   | 
[...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=)
 | `0.00% <0.00%> (-90.15%)` | `0.00 <0.00> (-20.00)` | |
   | 
[...king/oap/meter/analyzer/prometheus/rule/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9ydWxlL1J1bGVzLmphdmE=)
 | `0.00% <0.00%> (-66.67%)` | `0.00 <0.00> (-3.00)

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5835:
URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) 
Report
   > Merging 
[#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=desc) 
(32f7738) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `15.74%`.
   > The diff coverage is `1.47%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5835/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5835   +/-   ##
   =
   - Coverage 51.22%   35.48%   -15.75% 
   + Complexity 3497 1938 -1559 
   =
 Files  1661  741  -920 
 Lines 3565918500-17159 
 Branches   3910 1699 -2211 
   =
   - Hits  18266 6564-11702 
   + Misses1648511469 -5016 
   + Partials908  467  -441 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==)
 | `0.00% <0.00%> (-67.09%)` | `0.00 <0.00> (-14.00)` | |
   | 
[...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh)
 | `0.00% <0.00%> (-78.27%)` | `0.00 <0.00> (-8.00)` | |
   | 
[.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh)
 | `0.00% <0.00%> (-83.34%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../skywalking/oap/meter/analyzer/dsl/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb24uamF2YQ==)
 | `0.00% <0.00%> (-70.59%)` | `0.00 <0.00> (-5.00)` | |
   | 
[...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...meter/analyzer/dsl/ExpressionParsingException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nRXhjZXB0aW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ache/skywalking/oap/meter/analyzer/dsl/Result.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1Jlc3VsdC5qYXZh)
 | `0.00% <0.00%> (-60.00%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh)
 | `0.00% <0.00%> (-52.28%)` | `0.00 <0.00> (-55.00)` | |
   | 
[...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=)
 | `0.00% <0.00%> (-90.15%)` | `0.00 <0.00> (-20.00)` | |
   | 
[...king/oap/meter/analyzer/prometheus/rule/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9ydWxlL1J1bGVzLmphdmE=)
 | `0.00% <0.00%> (-66.67%)` | `0.00 <0.00> (-3.00)

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5835:
URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) 
Report
   > Merging 
[#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=desc) 
(32f7738) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `19.33%`.
   > The diff coverage is `1.47%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5835/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5835   +/-   ##
   =
   - Coverage 51.22%   31.88%   -19.34% 
   + Complexity 3497 1785 -1712 
   =
 Files  1661  741  -920 
 Lines 3565918491-17168 
 Branches   3910 1699 -2211 
   =
   - Hits  18266 5896-12370 
   + Misses1648512168 -4317 
   + Partials908  427  -481 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==)
 | `0.00% <0.00%> (-67.09%)` | `0.00 <0.00> (-14.00)` | |
   | 
[...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh)
 | `0.00% <0.00%> (-78.27%)` | `0.00 <0.00> (-8.00)` | |
   | 
[.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh)
 | `0.00% <0.00%> (-83.34%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../skywalking/oap/meter/analyzer/dsl/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb24uamF2YQ==)
 | `0.00% <0.00%> (-70.59%)` | `0.00 <0.00> (-5.00)` | |
   | 
[...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...meter/analyzer/dsl/ExpressionParsingException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nRXhjZXB0aW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ache/skywalking/oap/meter/analyzer/dsl/Result.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1Jlc3VsdC5qYXZh)
 | `0.00% <0.00%> (-60.00%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh)
 | `0.00% <0.00%> (-52.28%)` | `0.00 <0.00> (-55.00)` | |
   | 
[...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=)
 | `0.00% <0.00%> (-90.15%)` | `0.00 <0.00> (-20.00)` | |
   | 
[...king/oap/meter/analyzer/prometheus/rule/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9ydWxlL1J1bGVzLmphdmE=)
 | `0.00% <0.00%> (-66.67%)` | `0.00 <0.00> (-3.00)

[GitHub] [skywalking-cli] fgksgf commented on pull request #76: Add flags of instance, endpoint and normal for metrics command

2020-11-24 Thread GitBox


fgksgf commented on pull request #76:
URL: https://github.com/apache/skywalking-cli/pull/76#issuecomment-733512874


   It's weird, failed to build, but I can build it successfully on my pc.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking-cli] fgksgf opened a new pull request #76: Add flags of instance, endpoint and normal for metrics command

2020-11-24 Thread GitBox


fgksgf opened a new pull request #76:
URL: https://github.com/apache/skywalking-cli/pull/76


   - Add flags of instance, endpoint and normal for metrics command
   - Fix format issue of `How-to-release.md`
   - Update `README.md`
   
   Resolve apache/skywalking#5890



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] fgksgf commented on issue #5890: [CLI] Incorrect instance and enpoint level query implementation

2020-11-24 Thread GitBox


fgksgf commented on issue #5890:
URL: https://github.com/apache/skywalking/issues/5890#issuecomment-733510093


   @wu-sheng 
   I added a bool flag named `unnormal`, it's not required. Because the default 
value of `normal` is `true`.
   If we create a `isNormal` flag, we probably have to add this flag most of 
the time.
   What do you think ?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5835:
URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) 
Report
   > Merging 
[#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=desc) 
(70ad9ec) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `20.22%`.
   > The diff coverage is `1.47%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5835/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5835   +/-   ##
   =
   - Coverage 51.22%   31.00%   -20.23% 
   + Complexity 3497 1849 -1648 
   =
 Files  1661  758  -903 
 Lines 3565918967-16692 
 Branches   3910 1749 -2161 
   =
   - Hits  18266 5880-12386 
   + Misses1648512675 -3810 
   + Partials908  412  -496 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==)
 | `0.00% <0.00%> (-67.09%)` | `0.00 <0.00> (-14.00)` | |
   | 
[...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh)
 | `0.00% <0.00%> (-78.27%)` | `0.00 <0.00> (-8.00)` | |
   | 
[.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh)
 | `0.00% <0.00%> (-83.34%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../skywalking/oap/meter/analyzer/dsl/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb24uamF2YQ==)
 | `0.00% <0.00%> (-70.59%)` | `0.00 <0.00> (-5.00)` | |
   | 
[...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...meter/analyzer/dsl/ExpressionParsingException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nRXhjZXB0aW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ache/skywalking/oap/meter/analyzer/dsl/Result.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1Jlc3VsdC5qYXZh)
 | `0.00% <0.00%> (-60.00%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh)
 | `0.00% <0.00%> (-52.28%)` | `0.00 <0.00> (-55.00)` | |
   | 
[...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=)
 | `0.00% <0.00%> (-90.15%)` | `0.00 <0.00> (-20.00)` | |
   | 
[...king/oap/meter/analyzer/prometheus/rule/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9ydWxlL1J1bGVzLmphdmE=)
 | `0.00% <0.00%> (-66.67%)` | `0.00 <0.00> (-3.00)

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5835:
URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) 
Report
   > Merging 
[#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=desc) 
(70ad9ec) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `20.26%`.
   > The diff coverage is `1.47%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5835/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5835   +/-   ##
   =
   - Coverage 51.22%   30.95%   -20.27% 
   + Complexity 3497 1806 -1691 
   =
 Files  1661  741  -920 
 Lines 3565918488-17171 
 Branches   3910 1703 -2207 
   =
   - Hits  18266 5723-12543 
   + Misses1648512359 -4126 
   + Partials908  406  -502 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==)
 | `0.00% <0.00%> (-67.09%)` | `0.00 <0.00> (-14.00)` | |
   | 
[...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh)
 | `0.00% <0.00%> (-78.27%)` | `0.00 <0.00> (-8.00)` | |
   | 
[.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh)
 | `0.00% <0.00%> (-83.34%)` | `0.00 <0.00> (-1.00)` | |
   | 
[.../skywalking/oap/meter/analyzer/dsl/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb24uamF2YQ==)
 | `0.00% <0.00%> (-70.59%)` | `0.00 <0.00> (-5.00)` | |
   | 
[...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...meter/analyzer/dsl/ExpressionParsingException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nRXhjZXB0aW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ache/skywalking/oap/meter/analyzer/dsl/Result.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1Jlc3VsdC5qYXZh)
 | `0.00% <0.00%> (-60.00%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh)
 | `0.00% <0.00%> (-52.28%)` | `0.00 <0.00> (-55.00)` | |
   | 
[...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=)
 | `0.00% <0.00%> (-90.15%)` | `0.00 <0.00> (-20.00)` | |
   | 
[...king/oap/meter/analyzer/prometheus/rule/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9ydWxlL1J1bGVzLmphdmE=)
 | `0.00% <0.00%> (-66.67%)` | `0.00 <0.00> (-3.00)

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5835:
URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5835:
URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) 
Report
   > Merging 
[#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=desc) 
(80f150e) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `1.00%`.
   > The diff coverage is `48.62%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5835/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5835  +/-   ##
   
   - Coverage 51.22%   50.22%   -1.01% 
   + Complexity 3497 3384 -113 
   
 Files  1661 1662   +1 
 Lines 3565935654   -5 
 Branches   3910 3901   -9 
   
   - Hits  1826617906 -360 
   - Misses1648516838 +353 
   - Partials908  910   +2 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...meter/analyzer/dsl/ExpressionParsingException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nRXhjZXB0aW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...e/skywalking/oap/server/receiver/otel/Handler.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../receiver/otel/HandlerInitializationException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVySW5pdGlhbGl6YXRpb25FeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...server/receiver/otel/OtelMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJDb25maWcuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...server/receiver/otel/OtelMetricReceiverModule.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJNb2R1bGUuamF2YQ==)
 | `66.66% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...g/oap/server/receiver/otel/oc/OCMetricHandler.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9vYy9PQ01ldHJpY0hhbmRsZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...storage/plugin/jdbc/h2/dao/H2MetadataQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0YWRhdGFRdWVyeURBTy5qYXZh)
 | `49.66% <0.00%> (+0.32%)` | `12.00 <0.00> (ø)` | |
   | 
[...rver/receiver/otel/OtelMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJQcm92aWRlci5qYXZh)
 | `16.66% <20.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...king/oap/meter/analyzer/prometheus/rule/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9ydWxlL1J1bGVzLmphdmE=)
 | `58.33% <42.85%> (-8.34%)` | `3.00 <0.00> (ø)` | |
   | 
[...ache/skywalking/oap/meter/analyzer/dsl/Result.java](https://codecov.io/gh/apache/skyw

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5835:
URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) 
Report
   > Merging 
[#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=desc) 
(80f150e) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `1.14%`.
   > The diff coverage is `48.62%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5835/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5835  +/-   ##
   
   - Coverage 51.22%   50.07%   -1.15% 
   + Complexity 3497 3353 -144 
   
 Files  1661 1662   +1 
 Lines 3565935652   -7 
 Branches   3910 3901   -9 
   
   - Hits  1826617854 -412 
   - Misses1648516887 +402 
   - Partials908  911   +3 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...meter/analyzer/dsl/ExpressionParsingException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nRXhjZXB0aW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...e/skywalking/oap/server/receiver/otel/Handler.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../receiver/otel/HandlerInitializationException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVySW5pdGlhbGl6YXRpb25FeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...server/receiver/otel/OtelMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJDb25maWcuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...server/receiver/otel/OtelMetricReceiverModule.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJNb2R1bGUuamF2YQ==)
 | `66.66% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...g/oap/server/receiver/otel/oc/OCMetricHandler.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9vYy9PQ01ldHJpY0hhbmRsZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...storage/plugin/jdbc/h2/dao/H2MetadataQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0YWRhdGFRdWVyeURBTy5qYXZh)
 | `49.66% <0.00%> (+0.32%)` | `12.00 <0.00> (ø)` | |
   | 
[...rver/receiver/otel/OtelMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJQcm92aWRlci5qYXZh)
 | `16.66% <20.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...king/oap/meter/analyzer/prometheus/rule/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9ydWxlL1J1bGVzLmphdmE=)
 | `58.33% <42.85%> (-8.34%)` | `3.00 <0.00> (ø)` | |
   | 
[...ache/skywalking/oap/meter/analyzer/dsl/Result.java](https://codecov.io/gh/apache/skyw

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5835:
URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) 
Report
   > Merging 
[#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=desc) 
(80f150e) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `1.15%`.
   > The diff coverage is `48.62%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5835/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5835  +/-   ##
   
   - Coverage 51.22%   50.07%   -1.16% 
   + Complexity 3497 3350 -147 
   
 Files  1661 1662   +1 
 Lines 3565935652   -7 
 Branches   3910 3901   -9 
   
   - Hits  1826617851 -415 
   - Misses1648516890 +405 
   - Partials908  911   +3 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...meter/analyzer/dsl/ExpressionParsingException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nRXhjZXB0aW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...e/skywalking/oap/server/receiver/otel/Handler.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../receiver/otel/HandlerInitializationException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVySW5pdGlhbGl6YXRpb25FeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...server/receiver/otel/OtelMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJDb25maWcuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...server/receiver/otel/OtelMetricReceiverModule.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJNb2R1bGUuamF2YQ==)
 | `66.66% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...g/oap/server/receiver/otel/oc/OCMetricHandler.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9vYy9PQ01ldHJpY0hhbmRsZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...storage/plugin/jdbc/h2/dao/H2MetadataQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0YWRhdGFRdWVyeURBTy5qYXZh)
 | `49.66% <0.00%> (+0.32%)` | `12.00 <0.00> (ø)` | |
   | 
[...rver/receiver/otel/OtelMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJQcm92aWRlci5qYXZh)
 | `16.66% <20.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...king/oap/meter/analyzer/prometheus/rule/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9ydWxlL1J1bGVzLmphdmE=)
 | `58.33% <42.85%> (-8.34%)` | `3.00 <0.00> (ø)` | |
   | 
[...ache/skywalking/oap/meter/analyzer/dsl/Result.java](https://codecov.io/gh/apache/skyw

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5835:
URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) 
Report
   > Merging 
[#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=desc) 
(80f150e) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `2.83%`.
   > The diff coverage is `11.21%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5835/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5835  +/-   ##
   
   - Coverage 51.22%   48.39%   -2.84% 
   + Complexity 3497 3076 -421 
   
 Files  1661 1662   +1 
 Lines 3565935622  -37 
 Branches   3910 3897  -13 
   
   - Hits  1826617238-1028 
   - Misses1648517512+1027 
   + Partials908  872  -36 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==)
 | `0.00% <0.00%> (-67.09%)` | `0.00 <0.00> (-14.00)` | |
   | 
[...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh)
 | `0.00% <0.00%> (-78.27%)` | `0.00 <0.00> (-8.00)` | |
   | 
[...meter/analyzer/dsl/ExpressionParsingException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nRXhjZXB0aW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=)
 | `0.00% <0.00%> (-90.15%)` | `0.00 <0.00> (-20.00)` | |
   | 
[...king/oap/meter/analyzer/prometheus/rule/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9ydWxlL1J1bGVzLmphdmE=)
 | `0.00% <0.00%> (-66.67%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...r/prometheus/provider/PrometheusFetcherConfig.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlckNvbmZpZy5qYXZh)
 | `28.57% <0.00%> (-71.43%)` | `1.00 <0.00> (ø)` | |
   | 
[...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=)
 | `30.00% <0.00%> (-54.00%)` | `4.00 <0.00> (-6.00)` | |
   | 
[...e/skywalking/oap/server/receiver/otel/Handler.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../receiver/otel/HandlerInitializationException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVySW5pdGlhbGl6YXRpb25FeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...server/receiver/otel/OtelMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2F

[GitHub] [skywalking-swck] wu-sheng commented on a change in pull request #12: Introduce custom metrics apiserver which is an adapter to OAP cluster

2020-11-24 Thread GitBox


wu-sheng commented on a change in pull request #12:
URL: https://github.com/apache/skywalking-swck/pull/12#discussion_r530142800



##
File path: doc/custom-metrics-adapter.md
##
@@ -0,0 +1,77 @@
+# Custom metrics Adapter
+
+This adapter contains an implementation of [external 
metrics](https://github.com/kubernetes/community/blob/master/contributors/design-proposals/instrumentation/external-metrics-api.md)
+ API. It is therefore suitable for use with the autoscaling/v2 Horizontal Pod 
Autoscaler in Kubernetes 1.6+.
+ 
+
+## Use kustomize to customise your deployment
+
+1. Clone the source code:
+
+```sh
+git clone g...@github.com:apache/skywalking-swck.git
+```
+
+2. Edit file `config/adapter/adapter/kustomization.yaml` file to change your 
preferences. If you prefer to your private 
+ docker image, a quick path to override `ADAPTER_IMG` environment variable : 
`export ADAPTER_IMG=/adapter:`
+
+3. Use `make` to generate the final manifests and deploy:
+
+```sh
+make adapter-deploy
+```
+
+## Configuration
+
+The adapter takes the standard Kubernetes generic API server arguments 
(including those for authentication and authorization). 
+By default, it will attempt to using Kubernetes in-cluster config to connect 
to the cluster.
+
+It takes the following addition arguments specific to configuring how the 
adapter talks to SkyWalking OAP cluster:
+
+ * `--oap-addr` The address of OAP cluster.
+ * `--metric-filter-regex` A regular expression to filter metrics retrieved 
from OAP cluster.
+ * `--refresh-interval` This is the interval at which to update the cache of 
available metrics from OAP cluster. 
+ 
+## HPA Configuration
+
+External metrics allow you to autoscale your cluster based on any metric 
available in OAP cluster. 
+ Just provide a metric block with a `name` and `selector`, and use the 
`External` metric type.
+ 
+```yaml
+- type: External
+  external:
+metric:
+  name: 
+  metricSelector:
+matchLabels:
+  : 
+  ...
+target:
+  
+```
+
+ * metric_name: The name of metric generated by OAL or other subsystem.
+ * label: available `label_key`s are `service` and `label`. 
+  
+ The options of label keys are:
+ * `service` varies in different scopes. If the scope is `Service`, 
`ServiceInstance` and `Endpoint`, the `service` represents
+`serviceName`, `serviceInstanceName` and `endpointName` respectively.

Review comment:
   Then, we need a deeper discussion about what do you plan to distribute. 
In the current release on the download page, 
http://skywalking.apache.org/downloads/, there is only a source release, so we 
always expect users to compile codes by themselves. How would this adaptor be?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking-swck] hanahmily commented on a change in pull request #12: Introduce custom metrics apiserver which is an adapter to OAP cluster

2020-11-24 Thread GitBox


hanahmily commented on a change in pull request #12:
URL: https://github.com/apache/skywalking-swck/pull/12#discussion_r530139941



##
File path: doc/custom-metrics-adapter.md
##
@@ -0,0 +1,77 @@
+# Custom metrics Adapter
+
+This adapter contains an implementation of [external 
metrics](https://github.com/kubernetes/community/blob/master/contributors/design-proposals/instrumentation/external-metrics-api.md)
+ API. It is therefore suitable for use with the autoscaling/v2 Horizontal Pod 
Autoscaler in Kubernetes 1.6+.
+ 
+
+## Use kustomize to customise your deployment
+
+1. Clone the source code:
+
+```sh
+git clone g...@github.com:apache/skywalking-swck.git
+```
+
+2. Edit file `config/adapter/adapter/kustomization.yaml` file to change your 
preferences. If you prefer to your private 
+ docker image, a quick path to override `ADAPTER_IMG` environment variable : 
`export ADAPTER_IMG=/adapter:`
+
+3. Use `make` to generate the final manifests and deploy:
+
+```sh
+make adapter-deploy
+```
+
+## Configuration
+
+The adapter takes the standard Kubernetes generic API server arguments 
(including those for authentication and authorization). 
+By default, it will attempt to using Kubernetes in-cluster config to connect 
to the cluster.
+
+It takes the following addition arguments specific to configuring how the 
adapter talks to SkyWalking OAP cluster:
+
+ * `--oap-addr` The address of OAP cluster.
+ * `--metric-filter-regex` A regular expression to filter metrics retrieved 
from OAP cluster.
+ * `--refresh-interval` This is the interval at which to update the cache of 
available metrics from OAP cluster. 
+ 
+## HPA Configuration
+
+External metrics allow you to autoscale your cluster based on any metric 
available in OAP cluster. 
+ Just provide a metric block with a `name` and `selector`, and use the 
`External` metric type.
+ 
+```yaml
+- type: External
+  external:
+metric:
+  name: 
+  metricSelector:
+matchLabels:
+  : 
+  ...
+target:
+  
+```
+
+ * metric_name: The name of metric generated by OAL or other subsystem.
+ * label: available `label_key`s are `service` and `label`. 
+  
+ The options of label keys are:
+ * `service` varies in different scopes. If the scope is `Service`, 
`ServiceInstance` and `Endpoint`, the `service` represents
+`serviceName`, `serviceInstanceName` and `endpointName` respectively.

Review comment:
   Noop. swck doesn't depend on a release. once this gets merged, swck 
could sync with it. 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5889:
URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=h1) 
Report
   > Merging 
[#5889](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=desc) 
(3173e7f) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `0.34%`.
   > The diff coverage is `33.33%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5889/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5889  +/-   ##
   
   - Coverage 51.22%   50.87%   -0.35% 
   + Complexity 3497 3465  -32 
   
 Files  1661  923 -738 
 Lines 3565923084   -12575 
 Branches   3910 2233-1677 
   
   - Hits  1826611744-6522 
   + Misses1648510384-6101 
   - Partials908  956  +48 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../skywalking/apm/agent/core/meter/MeterService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZXJ2aWNlLmphdmE=)
 | `48.27% <0.00%> (-41.01%)` | `7.00 <0.00> (ø)` | |
   | 
[...gent/core/pool/connections/ConnectionPoolInfo.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbEluZm8uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ol/connections/ObjectHadBeenRecycledException.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9PYmplY3RIYWRCZWVuUmVjeWNsZWRFeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...t/core/pool/connections/ConnectionPoolService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbFNlcnZpY2UuamF2YQ==)
 | `37.93% <37.93%> (ø)` | `7.00 <7.00> (?)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `79.68% <66.66%> (-0.65%)` | `0.00 <0.00> (ø)` | |
   | 
[...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
   | ...

[skywalking] branch otel-istio updated (80f150e -> 70ad9ec)

2020-11-24 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository.

hanahmily pushed a change to branch otel-istio
in repository https://gitbox.apache.org/repos/asf/skywalking.git.


from 80f150e  Disable istio and so11y metrics by default.
 add 70ad9ec  Fix micrometer testcase

No new revisions were added by this update.

Summary of changes:
 .../main/java/org/apache/skywalking/e2e/metrics/MetricsQuery.java   | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5835:
URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) 
Report
   > Merging 
[#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=desc) 
(80f150e) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `3.47%`.
   > The diff coverage is `11.21%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5835/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5835  +/-   ##
   
   - Coverage 51.22%   47.74%   -3.48% 
   + Complexity 3497 3021 -476 
   
 Files  1661 1662   +1 
 Lines 3565935621  -38 
 Branches   3910 3897  -13 
   
   - Hits  1826617008-1258 
   - Misses1648517742+1257 
   + Partials908  871  -37 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==)
 | `0.00% <0.00%> (-67.09%)` | `0.00 <0.00> (-14.00)` | |
   | 
[...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh)
 | `0.00% <0.00%> (-78.27%)` | `0.00 <0.00> (-8.00)` | |
   | 
[...meter/analyzer/dsl/ExpressionParsingException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nRXhjZXB0aW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=)
 | `0.00% <0.00%> (-90.15%)` | `0.00 <0.00> (-20.00)` | |
   | 
[...king/oap/meter/analyzer/prometheus/rule/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9ydWxlL1J1bGVzLmphdmE=)
 | `0.00% <0.00%> (-66.67%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...r/prometheus/provider/PrometheusFetcherConfig.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlckNvbmZpZy5qYXZh)
 | `28.57% <0.00%> (-71.43%)` | `1.00 <0.00> (ø)` | |
   | 
[...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=)
 | `30.00% <0.00%> (-54.00%)` | `4.00 <0.00> (-6.00)` | |
   | 
[...e/skywalking/oap/server/receiver/otel/Handler.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../receiver/otel/HandlerInitializationException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVySW5pdGlhbGl6YXRpb25FeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...server/receiver/otel/OtelMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2F

[GitHub] [skywalking-swck] wu-sheng commented on a change in pull request #12: Introduce custom metrics apiserver which is an adapter to OAP cluster

2020-11-24 Thread GitBox


wu-sheng commented on a change in pull request #12:
URL: https://github.com/apache/skywalking-swck/pull/12#discussion_r530138473



##
File path: doc/custom-metrics-adapter.md
##
@@ -0,0 +1,77 @@
+# Custom metrics Adapter
+
+This adapter contains an implementation of [external 
metrics](https://github.com/kubernetes/community/blob/master/contributors/design-proposals/instrumentation/external-metrics-api.md)
+ API. It is therefore suitable for use with the autoscaling/v2 Horizontal Pod 
Autoscaler in Kubernetes 1.6+.
+ 
+
+## Use kustomize to customise your deployment
+
+1. Clone the source code:
+
+```sh
+git clone g...@github.com:apache/skywalking-swck.git
+```
+
+2. Edit file `config/adapter/adapter/kustomization.yaml` file to change your 
preferences. If you prefer to your private 
+ docker image, a quick path to override `ADAPTER_IMG` environment variable : 
`export ADAPTER_IMG=/adapter:`
+
+3. Use `make` to generate the final manifests and deploy:
+
+```sh
+make adapter-deploy
+```
+
+## Configuration
+
+The adapter takes the standard Kubernetes generic API server arguments 
(including those for authentication and authorization). 
+By default, it will attempt to using Kubernetes in-cluster config to connect 
to the cluster.
+
+It takes the following addition arguments specific to configuring how the 
adapter talks to SkyWalking OAP cluster:
+
+ * `--oap-addr` The address of OAP cluster.
+ * `--metric-filter-regex` A regular expression to filter metrics retrieved 
from OAP cluster.
+ * `--refresh-interval` This is the interval at which to update the cache of 
available metrics from OAP cluster. 
+ 
+## HPA Configuration
+
+External metrics allow you to autoscale your cluster based on any metric 
available in OAP cluster. 
+ Just provide a metric block with a `name` and `selector`, and use the 
`External` metric type.
+ 
+```yaml
+- type: External
+  external:
+metric:
+  name: 
+  metricSelector:
+matchLabels:
+  : 
+  ...
+target:
+  
+```
+
+ * metric_name: The name of metric generated by OAL or other subsystem.
+ * label: available `label_key`s are `service` and `label`. 
+  
+ The options of label keys are:
+ * `service` varies in different scopes. If the scope is `Service`, 
`ServiceInstance` and `Endpoint`, the `service` represents
+`serviceName`, `serviceInstanceName` and `endpointName` respectively.

Review comment:
   https://github.com/apache/skywalking/issues/5890 I think this caused 
your misunderstanding. Let's hold this PR for a while, we should wait for CLI 
0.5.0. Agree?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] wu-sheng opened a new issue #5890: Incorrect instance and enpoint level query implementation

2020-11-24 Thread GitBox


wu-sheng opened a new issue #5890:
URL: https://github.com/apache/skywalking/issues/5890


   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [ ] Question or discussion
   - [x] Bug
   - [ ] Requirement
   - [ ] Feature or performance improvement
   
   ___
   ### Bug
   
![image](https://user-images.githubusercontent.com/5441976/100191819-c29b7800-2f2b-11eb-8109-ce3f3c58ac40.png)
   
   This bug is detected, which starts with the discussion here, 
https://github.com/apache/skywalking-swck/pull/12#discussion_r530091651. The 
current implementation of linear(maybe more) query, doesn't adopt/use the 
correct parameters.
   
   We should provide separate parameters for instance and endpoint names, with 
`isNormal` flag, which could be used in conjecture services.
   
   @fgksgf Let's fix this and call for 0.5.0 release. Note, #4466 should follow 
this when you implement those queries.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5889:
URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5889:
URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=h1) 
Report
   > Merging 
[#5889](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=desc) 
(3173e7f) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `0.60%`.
   > The diff coverage is `33.33%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5889/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5889  +/-   ##
   
   - Coverage 51.22%   50.62%   -0.61% 
   + Complexity 3497 3452  -45 
   
 Files  1661  922 -739 
 Lines 3565923080   -12579 
 Branches   3910 2233-1677 
   
   - Hits  1826611684-6582 
   + Misses1648510444-6041 
   - Partials908  952  +44 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../skywalking/apm/agent/core/meter/MeterService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZXJ2aWNlLmphdmE=)
 | `48.27% <0.00%> (-41.01%)` | `7.00 <0.00> (ø)` | |
   | 
[...gent/core/pool/connections/ConnectionPoolInfo.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbEluZm8uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ol/connections/ObjectHadBeenRecycledException.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9PYmplY3RIYWRCZWVuUmVjeWNsZWRFeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...t/core/pool/connections/ConnectionPoolService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbFNlcnZpY2UuamF2YQ==)
 | `37.93% <37.93%> (ø)` | `7.00 <7.00> (?)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `79.68% <66.66%> (-0.65%)` | `0.00 <0.00> (ø)` | |
   | 
[...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
   | ...

[GitHub] [skywalking-website] wu-sheng merged pull request #150: Fix the footer bug on the homepage

2020-11-24 Thread GitBox


wu-sheng merged pull request #150:
URL: https://github.com/apache/skywalking-website/pull/150


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[skywalking-website] branch master updated: Fix the footer bug on the homepage (#150)

2020-11-24 Thread wusheng
This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-website.git


The following commit(s) were added to refs/heads/master by this push:
 new 84fcaf5  Fix the footer bug on the homepage (#150)
84fcaf5 is described below

commit 84fcaf50fbc72f20215f11b37b51d1799877e678
Author: Juntao Zhang 
AuthorDate: Wed Nov 25 14:35:42 2020 +0800

Fix the footer bug on the homepage (#150)

* fix: remove the redundant div

* fix styles

* remove unused code

Co-authored-by: Juntao Zhang 
---
 themes/docsy/assets/scss/_styles_project.scss |  6 +++---
 themes/docsy/layouts/partials/footer.html | 22 ++
 2 files changed, 9 insertions(+), 19 deletions(-)

diff --git a/themes/docsy/assets/scss/_styles_project.scss 
b/themes/docsy/assets/scss/_styles_project.scss
index 4da458d..529e950 100644
--- a/themes/docsy/assets/scss/_styles_project.scss
+++ b/themes/docsy/assets/scss/_styles_project.scss
@@ -212,11 +212,11 @@ table {
 
   #overview.bg-box {
 background-color: #f7f7f9;
-//padding: 0 -15px !important;
   }
 
-  #overview {
-//padding:
+  .sky-row{
+margin-right: -15px;
+margin-left: -15px;
   }
 }
 
diff --git a/themes/docsy/layouts/partials/footer.html 
b/themes/docsy/layouts/partials/footer.html
index 8828ed9..3b49e00 100644
--- a/themes/docsy/layouts/partials/footer.html
+++ b/themes/docsy/layouts/partials/footer.html
@@ -1,32 +1,22 @@
 {{ $links := .Site.Params.links }}
-
-  
-
-  
+
+  
+
 {{ with $links }}
 {{ with index . "user"}}
 {{ template "footer-links-block"  . }}
 {{ end }}
 {{ end }}
-  
-
-
-
+
+
 
 {{ with .Site.Params.copyright }}© {{ 
now.Year}} {{ .}} {{ T "footer_all_rights_reserved" }}{{ end }}
 {{ with .Site.Params.privacy_policy }}{{ T "footer_privacy_policy" }}{{ end }}
{{ if not .Site.Params.ui.footer_about_disable }}
{{ with .Site.GetPage "about" }}{{ .Title }}{{ end }}
{{ end }}
-  
 
-
+
   Apache SkyWalking, SkyWalking, Apache, 
the Apache feather logo, and the Apache SkyWalking project logo are either 
registered trademarks or trademarks of the Apache Software Foundation.
 
   



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5889:
URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=h1) 
Report
   > Merging 
[#5889](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=desc) 
(3173e7f) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `1.66%`.
   > The diff coverage is `33.33%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5889/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5889  +/-   ##
   
   - Coverage 51.22%   49.56%   -1.67% 
   + Complexity 3497 3410  -87 
   
 Files  1661  922 -739 
 Lines 3565923070   -12589 
 Branches   3910 2232-1678 
   
   - Hits  1826611434-6832 
   + Misses1648510708-5777 
   - Partials908  928  +20 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../skywalking/apm/agent/core/meter/MeterService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZXJ2aWNlLmphdmE=)
 | `48.27% <0.00%> (-41.01%)` | `7.00 <0.00> (ø)` | |
   | 
[...gent/core/pool/connections/ConnectionPoolInfo.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbEluZm8uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ol/connections/ObjectHadBeenRecycledException.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9PYmplY3RIYWRCZWVuUmVjeWNsZWRFeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...t/core/pool/connections/ConnectionPoolService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbFNlcnZpY2UuamF2YQ==)
 | `37.93% <37.93%> (ø)` | `7.00 <7.00> (?)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `79.68% <66.66%> (-0.65%)` | `0.00 <0.00> (ø)` | |
   | 
[...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
   | ...

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5889:
URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=h1) 
Report
   > Merging 
[#5889](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=desc) 
(3173e7f) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `2.44%`.
   > The diff coverage is `33.33%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5889/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5889  +/-   ##
   
   - Coverage 51.22%   48.78%   -2.45% 
   + Complexity 3497 3369 -128 
   
 Files  1661  922 -739 
 Lines 3565923059   -12600 
 Branches   3910 2217-1693 
   
   - Hits  1826611249-7017 
   + Misses1648510884-5601 
   - Partials908  926  +18 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../skywalking/apm/agent/core/meter/MeterService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZXJ2aWNlLmphdmE=)
 | `48.27% <0.00%> (-41.01%)` | `7.00 <0.00> (ø)` | |
   | 
[...gent/core/pool/connections/ConnectionPoolInfo.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbEluZm8uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ol/connections/ObjectHadBeenRecycledException.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9PYmplY3RIYWRCZWVuUmVjeWNsZWRFeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...t/core/pool/connections/ConnectionPoolService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbFNlcnZpY2UuamF2YQ==)
 | `37.93% <37.93%> (ø)` | `7.00 <7.00> (?)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `79.68% <66.66%> (-0.65%)` | `0.00 <0.00> (ø)` | |
   | 
[...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
   | ...

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5889:
URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=h1) 
Report
   > Merging 
[#5889](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=desc) 
(3173e7f) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `2.90%`.
   > The diff coverage is `33.33%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5889/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5889  +/-   ##
   
   - Coverage 51.22%   48.32%   -2.91% 
   + Complexity 3497 3275 -222 
   
 Files  1661  905 -756 
 Lines 3565922580   -13079 
 Branches   3910 2171-1739 
   
   - Hits  1826610911-7355 
   + Misses1648510758-5727 
   - Partials908  911   +3 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../skywalking/apm/agent/core/meter/MeterService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZXJ2aWNlLmphdmE=)
 | `48.27% <0.00%> (-41.01%)` | `7.00 <0.00> (ø)` | |
   | 
[...gent/core/pool/connections/ConnectionPoolInfo.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbEluZm8uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ol/connections/ObjectHadBeenRecycledException.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9PYmplY3RIYWRCZWVuUmVjeWNsZWRFeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...t/core/pool/connections/ConnectionPoolService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbFNlcnZpY2UuamF2YQ==)
 | `37.93% <37.93%> (ø)` | `7.00 <7.00> (?)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `79.68% <66.66%> (-0.65%)` | `0.00 <0.00> (ø)` | |
   | 
[...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
   | ...

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5889:
URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=h1) 
Report
   > Merging 
[#5889](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=desc) 
(3173e7f) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `5.78%`.
   > The diff coverage is `33.33%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5889/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5889  +/-   ##
   
   - Coverage 51.22%   45.43%   -5.79% 
   + Complexity 3497 3109 -388 
   
 Files  1661  905 -756 
 Lines 3565922560   -13099 
 Branches   3910 2169-1741 
   
   - Hits  1826610250-8016 
   + Misses1648511445-5040 
   + Partials908  865  -43 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../skywalking/apm/agent/core/meter/MeterService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZXJ2aWNlLmphdmE=)
 | `48.27% <0.00%> (-41.01%)` | `7.00 <0.00> (ø)` | |
   | 
[...gent/core/pool/connections/ConnectionPoolInfo.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbEluZm8uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ol/connections/ObjectHadBeenRecycledException.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9PYmplY3RIYWRCZWVuUmVjeWNsZWRFeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...t/core/pool/connections/ConnectionPoolService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbFNlcnZpY2UuamF2YQ==)
 | `37.93% <37.93%> (ø)` | `7.00 <7.00> (?)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `79.68% <66.66%> (-0.65%)` | `0.00 <0.00> (ø)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | ... and [1209 
more](https://codecov.io/gh/apac

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5889:
URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=h1) 
Report
   > Merging 
[#5889](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=desc) 
(3173e7f) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `6.46%`.
   > The diff coverage is `33.33%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5889/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5889  +/-   ##
   
   - Coverage 51.22%   44.75%   -6.47% 
   + Complexity 3497 3087 -410 
   
 Files  1661  905 -756 
 Lines 3565922543   -13116 
 Branches   3910 2168-1742 
   
   - Hits  1826610089-8177 
   + Misses1648511593-4892 
   + Partials908  861  -47 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../skywalking/apm/agent/core/meter/MeterService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZXJ2aWNlLmphdmE=)
 | `48.27% <0.00%> (-41.01%)` | `7.00 <0.00> (ø)` | |
   | 
[...gent/core/pool/connections/ConnectionPoolInfo.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbEluZm8uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ol/connections/ObjectHadBeenRecycledException.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9PYmplY3RIYWRCZWVuUmVjeWNsZWRFeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...t/core/pool/connections/ConnectionPoolService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbFNlcnZpY2UuamF2YQ==)
 | `37.93% <37.93%> (ø)` | `7.00 <7.00> (?)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `79.68% <66.66%> (-0.65%)` | `0.00 <0.00> (ø)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | ... and [1210 
more](https://codecov.io/gh/apac

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5889:
URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=h1) 
Report
   > Merging 
[#5889](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=desc) 
(3173e7f) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `7.64%`.
   > The diff coverage is `33.33%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5889/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5889  +/-   ##
   
   - Coverage 51.22%   43.57%   -7.65% 
   + Complexity 3497 3016 -481 
   
 Files  1661  905 -756 
 Lines 3565922491   -13168 
 Branches   3910 2162-1748 
   
   - Hits  18266 9801-8465 
   + Misses1648511840-4645 
   + Partials908  850  -58 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../skywalking/apm/agent/core/meter/MeterService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZXJ2aWNlLmphdmE=)
 | `48.27% <0.00%> (-41.01%)` | `7.00 <0.00> (ø)` | |
   | 
[...gent/core/pool/connections/ConnectionPoolInfo.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbEluZm8uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ol/connections/ObjectHadBeenRecycledException.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9PYmplY3RIYWRCZWVuUmVjeWNsZWRFeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...t/core/pool/connections/ConnectionPoolService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbFNlcnZpY2UuamF2YQ==)
 | `37.93% <37.93%> (ø)` | `7.00 <7.00> (?)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `79.68% <66.66%> (-0.65%)` | `0.00 <0.00> (ø)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | ... and [1214 
more](https://codecov.io/gh/apac

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5889:
URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=h1) 
Report
   > Merging 
[#5889](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=desc) 
(3173e7f) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `7.73%`.
   > The diff coverage is `25.64%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5889/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5889  +/-   ##
   
   - Coverage 51.22%   43.49%   -7.74% 
   + Complexity 3497 3007 -490 
   
 Files  1661  905 -756 
 Lines 3565922491   -13168 
 Branches   3910 2162-1748 
   
   - Hits  18266 9782-8484 
   + Misses1648511860-4625 
   + Partials908  849  -59 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../skywalking/apm/agent/core/meter/MeterService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZXJ2aWNlLmphdmE=)
 | `37.93% <0.00%> (-51.36%)` | `6.00 <0.00> (-1.00)` | |
   | 
[...gent/core/pool/connections/ConnectionPoolInfo.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbEluZm8uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ol/connections/ObjectHadBeenRecycledException.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9PYmplY3RIYWRCZWVuUmVjeWNsZWRFeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...t/core/pool/connections/ConnectionPoolService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbFNlcnZpY2UuamF2YQ==)
 | `27.58% <27.58%> (ø)` | `6.00 <6.00> (?)` | |
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `79.68% <66.66%> (-0.65%)` | `0.00 <0.00> (ø)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | ... and [1214 
more](https://codecov.io/gh/

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5889:
URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=h1) 
Report
   > Merging 
[#5889](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=desc) 
(3173e7f) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `16.71%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5889/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5889   +/-   ##
   =
   - Coverage 51.22%   34.50%   -16.72% 
   + Complexity 3497 2320 -1177 
   =
 Files  1661  905  -756 
 Lines 3565922491-13168 
 Branches   3910 2162 -1748 
   =
   - Hits  18266 7761-10505 
   + Misses1648514129 -2356 
   + Partials908  601  -307 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-80.33%)` | `0.00 <0.00> (ø)` | |
   | 
[.../skywalking/apm/agent/core/meter/MeterService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-89.29%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...gent/core/pool/connections/ConnectionPoolInfo.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbEluZm8uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...t/core/pool/connections/ConnectionPoolService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ol/connections/ObjectHadBeenRecycledException.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9PYmplY3RIYWRCZWVuUmVjeWNsZWRFeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [1267 
more](https://codecov.io/gh/apache/skywalking/p

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5889:
URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=h1) 
Report
   > Merging 
[#5889](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=desc) 
(3173e7f) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `16.71%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5889/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5889   +/-   ##
   =
   - Coverage 51.22%   34.50%   -16.72% 
   + Complexity 3497 2320 -1177 
   =
 Files  1661  905  -756 
 Lines 3565922491-13168 
 Branches   3910 2162 -1748 
   =
   - Hits  18266 7761-10505 
   + Misses1648514129 -2356 
   + Partials908  601  -307 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-80.33%)` | `0.00 <0.00> (ø)` | |
   | 
[.../skywalking/apm/agent/core/meter/MeterService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-89.29%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...gent/core/pool/connections/ConnectionPoolInfo.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbEluZm8uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...t/core/pool/connections/ConnectionPoolService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ol/connections/ObjectHadBeenRecycledException.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9PYmplY3RIYWRCZWVuUmVjeWNsZWRFeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [1267 
more](https://codecov.io/gh/apache/skywalking/p

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5889:
URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=h1) 
Report
   > Merging 
[#5889](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=desc) 
(3173e7f) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `16.58%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5889/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5889   +/-   ##
   =
   - Coverage 51.22%   34.64%   -16.59% 
   + Complexity 3497 2320 -1177 
   =
 Files  1661  898  -763 
 Lines 3565922404-13255 
 Branches   3910 2150 -1760 
   =
   - Hits  18266 7761-10505 
   + Misses1648514042 -2443 
   + Partials908  601  -307 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-80.33%)` | `0.00 <0.00> (ø)` | |
   | 
[.../skywalking/apm/agent/core/meter/MeterService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-89.29%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...gent/core/pool/connections/ConnectionPoolInfo.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbEluZm8uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...t/core/pool/connections/ConnectionPoolService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ol/connections/ObjectHadBeenRecycledException.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9PYmplY3RIYWRCZWVuUmVjeWNsZWRFeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [1268 
more](https://codecov.io/gh/apache/skywalking/p

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5889:
URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=h1) 
Report
   > Merging 
[#5889](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=desc) 
(3173e7f) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `16.54%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5889/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5889   +/-   ##
   =
   - Coverage 51.22%   34.68%   -16.55% 
   + Complexity 3497 2320 -1177 
   =
 Files  1661  897  -764 
 Lines 3565922378-13281 
 Branches   3910 2150 -1760 
   =
   - Hits  18266 7761-10505 
   + Misses1648514016 -2469 
   + Partials908  601  -307 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-80.33%)` | `0.00 <0.00> (ø)` | |
   | 
[.../skywalking/apm/agent/core/meter/MeterService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-89.29%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...gent/core/pool/connections/ConnectionPoolInfo.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbEluZm8uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...t/core/pool/connections/ConnectionPoolService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ol/connections/ObjectHadBeenRecycledException.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9PYmplY3RIYWRCZWVuUmVjeWNsZWRFeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [1269 
more](https://codecov.io/gh/apache/skywalking/p

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5889:
URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=h1) 
Report
   > Merging 
[#5889](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=desc) 
(3173e7f) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `16.43%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5889/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5889   +/-   ##
   =
   - Coverage 51.22%   34.79%   -16.44% 
   + Complexity 3497 2320 -1177 
   =
 Files  1661  896  -765 
 Lines 3565922306-13353 
 Branches   3910 2133 -1777 
   =
   - Hits  18266 7761-10505 
   + Misses1648513944 -2541 
   + Partials908  601  -307 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-80.33%)` | `0.00 <0.00> (ø)` | |
   | 
[.../skywalking/apm/agent/core/meter/MeterService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-89.29%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...gent/core/pool/connections/ConnectionPoolInfo.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbEluZm8uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...t/core/pool/connections/ConnectionPoolService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ol/connections/ObjectHadBeenRecycledException.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9PYmplY3RIYWRCZWVuUmVjeWNsZWRFeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [1269 
more](https://codecov.io/gh/apache/skywalking/p

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5835:
URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) 
Report
   > Merging 
[#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=desc) 
(80f150e) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `3.47%`.
   > The diff coverage is `11.21%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5835/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5835  +/-   ##
   
   - Coverage 51.22%   47.74%   -3.48% 
   + Complexity 3497 3021 -476 
   
 Files  1661 1662   +1 
 Lines 3565935621  -38 
 Branches   3910 3897  -13 
   
   - Hits  1826617008-1258 
   - Misses1648517742+1257 
   + Partials908  871  -37 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==)
 | `0.00% <0.00%> (-67.09%)` | `0.00 <0.00> (-14.00)` | |
   | 
[...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh)
 | `0.00% <0.00%> (-78.27%)` | `0.00 <0.00> (-8.00)` | |
   | 
[...meter/analyzer/dsl/ExpressionParsingException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nRXhjZXB0aW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=)
 | `0.00% <0.00%> (-90.15%)` | `0.00 <0.00> (-20.00)` | |
   | 
[...king/oap/meter/analyzer/prometheus/rule/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9ydWxlL1J1bGVzLmphdmE=)
 | `0.00% <0.00%> (-66.67%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...r/prometheus/provider/PrometheusFetcherConfig.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlckNvbmZpZy5qYXZh)
 | `28.57% <0.00%> (-71.43%)` | `1.00 <0.00> (ø)` | |
   | 
[...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=)
 | `30.00% <0.00%> (-54.00%)` | `4.00 <0.00> (-6.00)` | |
   | 
[...e/skywalking/oap/server/receiver/otel/Handler.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../receiver/otel/HandlerInitializationException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVySW5pdGlhbGl6YXRpb25FeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...server/receiver/otel/OtelMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2F

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5889:
URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=h1) 
Report
   > Merging 
[#5889](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=desc) 
(a5b01a4) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `14.30%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5889/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5889   +/-   ##
   =
   - Coverage 51.22%   36.91%   -14.31% 
   + Complexity 3497 2473 -1024 
   =
 Files  1661  915  -746 
 Lines 3565922818-12841 
 Branches   3910 2189 -1721 
   =
   - Hits  18266 8424 -9842 
   + Misses1648513755 -2730 
   + Partials908  639  -269 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-80.33%)` | `0.00 <0.00> (ø)` | |
   | 
[.../skywalking/apm/agent/core/meter/MeterService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-89.29%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...gent/core/pool/connections/ConnectionPoolInfo.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbEluZm8uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...t/core/pool/connections/ConnectionPoolService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ol/connections/ObjectHadBeenRecycledException.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9PYmplY3RIYWRCZWVuUmVjeWNsZWRFeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [1252 
more](https://codecov.io/gh/apache/skyw

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5889:
URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=h1) 
Report
   > Merging 
[#5889](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=desc) 
(a5b01a4) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `14.30%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5889/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5889   +/-   ##
   =
   - Coverage 51.22%   36.91%   -14.31% 
   + Complexity 3497 2473 -1024 
   =
 Files  1661  915  -746 
 Lines 3565922818-12841 
 Branches   3910 2189 -1721 
   =
   - Hits  18266 8424 -9842 
   + Misses1648513755 -2730 
   + Partials908  639  -269 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-80.33%)` | `0.00 <0.00> (ø)` | |
   | 
[.../skywalking/apm/agent/core/meter/MeterService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-89.29%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...gent/core/pool/connections/ConnectionPoolInfo.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbEluZm8uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...t/core/pool/connections/ConnectionPoolService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ol/connections/ObjectHadBeenRecycledException.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9PYmplY3RIYWRCZWVuUmVjeWNsZWRFeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [1252 
more](https://codecov.io/gh/apache/skyw

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5889:
URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=h1) 
Report
   > Merging 
[#5889](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=desc) 
(a5b01a4) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `14.48%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5889/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5889   +/-   ##
   =
   - Coverage 51.22%   36.73%   -14.49% 
   + Complexity 3497 2466 -1031 
   =
 Files  1661  915  -746 
 Lines 3565922818-12841 
 Branches   3910 2189 -1721 
   =
   - Hits  18266 8382 -9884 
   + Misses1648513798 -2687 
   + Partials908  638  -270 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-80.33%)` | `0.00 <0.00> (ø)` | |
   | 
[.../skywalking/apm/agent/core/meter/MeterService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-89.29%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...gent/core/pool/connections/ConnectionPoolInfo.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbEluZm8uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...t/core/pool/connections/ConnectionPoolService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ol/connections/ObjectHadBeenRecycledException.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9PYmplY3RIYWRCZWVuUmVjeWNsZWRFeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [1252 
more](https://codecov.io/gh/apache/skyw

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5889:
URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=h1) 
Report
   > Merging 
[#5889](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=desc) 
(a5b01a4) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `14.51%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5889/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5889   +/-   ##
   =
   - Coverage 51.22%   36.71%   -14.52% 
   + Complexity 3497 2466 -1031 
   =
 Files  1661  915  -746 
 Lines 3565922818-12841 
 Branches   3910 2189 -1721 
   =
   - Hits  18266 8377 -9889 
   + Misses1648513802 -2683 
   + Partials908  639  -269 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-80.33%)` | `0.00 <0.00> (ø)` | |
   | 
[.../skywalking/apm/agent/core/meter/MeterService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-89.29%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...gent/core/pool/connections/ConnectionPoolInfo.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbEluZm8uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...t/core/pool/connections/ConnectionPoolService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ol/connections/ObjectHadBeenRecycledException.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9PYmplY3RIYWRCZWVuUmVjeWNsZWRFeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | ... and [1252 
more](https://codecov.io/gh/apache/skyw

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5889:
URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=h1) 
Report
   > Merging 
[#5889](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=desc) 
(a5b01a4) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `17.59%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5889/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5889   +/-   ##
   =
   - Coverage 51.22%   33.62%   -17.60% 
   + Complexity 3497 2248 -1249 
   =
 Files  1661  898  -763 
 Lines 3565922319-13340 
 Branches   3910 2141 -1769 
   =
   - Hits  18266 7505-10761 
   + Misses1648514241 -2244 
   + Partials908  573  -335 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-80.33%)` | `0.00 <0.00> (ø)` | |
   | 
[.../skywalking/apm/agent/core/meter/MeterService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-89.29%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...gent/core/pool/connections/ConnectionPoolInfo.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbEluZm8uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...t/core/pool/connections/ConnectionPoolService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ol/connections/ObjectHadBeenRecycledException.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9PYmplY3RIYWRCZWVuUmVjeWNsZWRFeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [1277 
more](https://codecov.io/gh/apache/skywalking/p

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5889:
URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=h1) 
Report
   > Merging 
[#5889](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=desc) 
(a5b01a4) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `20.41%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5889/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5889   +/-   ##
   =
   - Coverage 51.22%   30.81%   -20.42% 
   + Complexity 3497 2095 -1402 
   =
 Files  1661  898  -763 
 Lines 3565922319-13340 
 Branches   3910 2141 -1769 
   =
   - Hits  18266 6877-11389 
   + Misses1648514933 -1552 
   + Partials908  509  -399 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-80.33%)` | `0.00 <0.00> (ø)` | |
   | 
[.../skywalking/apm/agent/core/meter/MeterService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-89.29%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...gent/core/pool/connections/ConnectionPoolInfo.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbEluZm8uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...t/core/pool/connections/ConnectionPoolService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ol/connections/ObjectHadBeenRecycledException.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9PYmplY3RIYWRCZWVuUmVjeWNsZWRFeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [1289 
more](https://codecov.io/gh/apache/skywalking/p

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5889:
URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=h1) 
Report
   > Merging 
[#5889](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=desc) 
(a5b01a4) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `51.22%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5889/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #5889   +/-   ##
   
   - Coverage 51.22%   0.00%   -51.23% 
   
 Files  1661 173 -1488 
 Lines 356594105-31554 
 Branches   3910 466 -3444 
   
   - Hits  18266   0-18266 
   + Misses164854105-12380 
   + Partials908   0  -908 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-80.33%)` | `0.00 <0.00> (ø)` | |
   | 
[.../skywalking/apm/agent/core/meter/MeterService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-89.29%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...gent/core/pool/connections/ConnectionPoolInfo.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbEluZm8uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...t/core/pool/connections/ConnectionPoolService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ol/connections/ObjectHadBeenRecycledException.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9PYmplY3RIYWRCZWVuUmVjeWNsZWRFeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [1647 
more](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree-more)
 | |
   
   --
   

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5889:
URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=h1) 
Report
   > Merging 
[#5889](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=desc) 
(a5b01a4) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `51.22%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5889/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #5889   +/-   ##
   
   - Coverage 51.22%   0.00%   -51.23% 
   
 Files  1661 172 -1489 
 Lines 356594099-31560 
 Branches   3910 466 -3444 
   
   - Hits  18266   0-18266 
   + Misses164854099-12386 
   + Partials908   0  -908 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-80.33%)` | `0.00 <0.00> (ø)` | |
   | 
[.../skywalking/apm/agent/core/meter/MeterService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-89.29%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...gent/core/pool/connections/ConnectionPoolInfo.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbEluZm8uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...t/core/pool/connections/ConnectionPoolService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ol/connections/ObjectHadBeenRecycledException.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9PYmplY3RIYWRCZWVuUmVjeWNsZWRFeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [1647 
more](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree-more)
 | |
   
   --
   

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5889:
URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=h1) 
Report
   > Merging 
[#5889](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=desc) 
(a5b01a4) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `51.22%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5889/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #5889   +/-   ##
   
   - Coverage 51.22%   0.00%   -51.23% 
   
 Files  1661 171 -1490 
 Lines 356594088-31571 
 Branches   3910 466 -3444 
   
   - Hits  18266   0-18266 
   + Misses164854088-12397 
   + Partials908   0  -908 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-80.33%)` | `0.00 <0.00> (ø)` | |
   | 
[.../skywalking/apm/agent/core/meter/MeterService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-89.29%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...gent/core/pool/connections/ConnectionPoolInfo.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbEluZm8uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...t/core/pool/connections/ConnectionPoolService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ol/connections/ObjectHadBeenRecycledException.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9PYmplY3RIYWRCZWVuUmVjeWNsZWRFeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [1647 
more](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree-more)
 | |
   
   --
   

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5889:
URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=h1) 
Report
   > Merging 
[#5889](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=desc) 
(a5b01a4) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `51.22%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5889/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #5889   +/-   ##
   
   - Coverage 51.22%   0.00%   -51.23% 
   
 Files  1661 170 -1491 
 Lines 356594079-31580 
 Branches   3910 465 -3445 
   
   - Hits  18266   0-18266 
   + Misses164854079-12406 
   + Partials908   0  -908 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-80.33%)` | `0.00 <0.00> (ø)` | |
   | 
[.../skywalking/apm/agent/core/meter/MeterService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-89.29%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...gent/core/pool/connections/ConnectionPoolInfo.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbEluZm8uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...t/core/pool/connections/ConnectionPoolService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ol/connections/ObjectHadBeenRecycledException.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9PYmplY3RIYWRCZWVuUmVjeWNsZWRFeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [1647 
more](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree-more)
 | |
   
   --
   

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5889:
URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=h1) 
Report
   > Merging 
[#5889](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=desc) 
(a5b01a4) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `51.22%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5889/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master   #5889   +/-   ##
   
   - Coverage 51.22%   0.00%   -51.23% 
   
 Files  1661 164 -1497 
 Lines 356594002-31657 
 Branches   3910 457 -3453 
   
   - Hits  18266   0-18266 
   + Misses164854002-12483 
   + Partials908   0  -908 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-80.33%)` | `0.00 <0.00> (ø)` | |
   | 
[.../skywalking/apm/agent/core/meter/MeterService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-89.29%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...gent/core/pool/connections/ConnectionPoolInfo.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbEluZm8uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...t/core/pool/connections/ConnectionPoolService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ol/connections/ObjectHadBeenRecycledException.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9PYmplY3RIYWRCZWVuUmVjeWNsZWRFeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [1647 
more](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree-more)
 | |
   
   --
   

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5889:
URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=h1) 
Report
   > Merging 
[#5889](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=desc) 
(3173e7f) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `16.43%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5889/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5889   +/-   ##
   =
   - Coverage 51.22%   34.79%   -16.44% 
   + Complexity 3497 2320 -1177 
   =
 Files  1661  896  -765 
 Lines 3565922306-13353 
 Branches   3910 2133 -1777 
   =
   - Hits  18266 7761-10505 
   + Misses1648513944 -2541 
   + Partials908  601  -307 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-80.33%)` | `0.00 <0.00> (ø)` | |
   | 
[.../skywalking/apm/agent/core/meter/MeterService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-89.29%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...gent/core/pool/connections/ConnectionPoolInfo.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbEluZm8uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...t/core/pool/connections/ConnectionPoolService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ol/connections/ObjectHadBeenRecycledException.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9PYmplY3RIYWRCZWVuUmVjeWNsZWRFeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [1269 
more](https://codecov.io/gh/apache/skywalking/p

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5889:
URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=h1) 
Report
   > Merging 
[#5889](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=desc) 
(3173e7f) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `16.36%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5889/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5889   +/-   ##
   =
   - Coverage 51.22%   34.85%   -16.37% 
   + Complexity 3497 2320 -1177 
   =
 Files  1661  895  -766 
 Lines 3565922267-13392 
 Branches   3910 2132 -1778 
   =
   - Hits  18266 7761-10505 
   + Misses1648513905 -2580 
   + Partials908  601  -307 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-80.33%)` | `0.00 <0.00> (ø)` | |
   | 
[.../skywalking/apm/agent/core/meter/MeterService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-89.29%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...gent/core/pool/connections/ConnectionPoolInfo.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbEluZm8uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...t/core/pool/connections/ConnectionPoolService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ol/connections/ObjectHadBeenRecycledException.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9PYmplY3RIYWRCZWVuUmVjeWNsZWRFeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [1268 
more](https://codecov.io/gh/apache/skywalking/p

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5889:
URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=h1) 
Report
   > Merging 
[#5889](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=desc) 
(3173e7f) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `16.36%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5889/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5889   +/-   ##
   =
   - Coverage 51.22%   34.86%   -16.37% 
   + Complexity 3497 2320 -1177 
   =
 Files  1661  894  -767 
 Lines 3565922262-13397 
 Branches   3910 2132 -1778 
   =
   - Hits  18266 7761-10505 
   + Misses1648513900 -2585 
   + Partials908  601  -307 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-80.33%)` | `0.00 <0.00> (ø)` | |
   | 
[.../skywalking/apm/agent/core/meter/MeterService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-89.29%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...gent/core/pool/connections/ConnectionPoolInfo.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbEluZm8uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...t/core/pool/connections/ConnectionPoolService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ol/connections/ObjectHadBeenRecycledException.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9PYmplY3RIYWRCZWVuUmVjeWNsZWRFeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [1268 
more](https://codecov.io/gh/apache/skywalking/p

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5889:
URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=h1) 
Report
   > Merging 
[#5889](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=desc) 
(3173e7f) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `16.33%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5889/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5889   +/-   ##
   =
   - Coverage 51.22%   34.89%   -16.34% 
   + Complexity 3497 2320 -1177 
   =
 Files  1661  892  -769 
 Lines 3565922242-13417 
 Branches   3910 2131 -1779 
   =
   - Hits  18266 7761-10505 
   + Misses1648513880 -2605 
   + Partials908  601  -307 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-80.33%)` | `0.00 <0.00> (ø)` | |
   | 
[.../skywalking/apm/agent/core/meter/MeterService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-89.29%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...gent/core/pool/connections/ConnectionPoolInfo.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbEluZm8uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...t/core/pool/connections/ConnectionPoolService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ol/connections/ObjectHadBeenRecycledException.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9PYmplY3RIYWRCZWVuUmVjeWNsZWRFeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [1268 
more](https://codecov.io/gh/apache/skywalking/p

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5889:
URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=h1) 
Report
   > Merging 
[#5889](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=desc) 
(3173e7f) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `16.31%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5889/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5889   +/-   ##
   =
   - Coverage 51.22%   34.91%   -16.32% 
   + Complexity 3497 2320 -1177 
   =
 Files  1661  890  -771 
 Lines 3565922230-13429 
 Branches   3910 2131 -1779 
   =
   - Hits  18266 7761-10505 
   + Misses1648513868 -2617 
   + Partials908  601  -307 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==)
 | `0.00% <0.00%> (-80.33%)` | `0.00 <0.00> (ø)` | |
   | 
[.../skywalking/apm/agent/core/meter/MeterService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZXJ2aWNlLmphdmE=)
 | `0.00% <0.00%> (-89.29%)` | `0.00 <0.00> (-7.00)` | |
   | 
[...gent/core/pool/connections/ConnectionPoolInfo.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbEluZm8uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...t/core/pool/connections/ConnectionPoolService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9Db25uZWN0aW9uUG9vbFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...ol/connections/ObjectHadBeenRecycledException.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcG9vbC9jb25uZWN0aW9ucy9PYmplY3RIYWRCZWVuUmVjeWNsZWRFeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
   | 
[...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [1268 
more](https://codecov.io/gh/apache/skywalking/p

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5889:
URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=h1) 
Report
   > Merging 
[#5889](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=desc) 
(3173e7f) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `9.75%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5889/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5889  +/-   ##
   
   - Coverage 51.22%   41.46%   -9.76% 
   + Complexity 3497 2320-1177 
   
 Files  1661  741 -920 
 Lines 3565918716   -16943 
 Branches   3910 1739-2171 
   
   - Hits  18266 7761   -10505 
   + Misses1648510354-6131 
   + Partials908  601 -307 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
   | 
[...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...erver/storage/plugin/elasticsearch/base/EsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Fc0RBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
   | 
[.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXIt

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5889:
URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=h1) 
Report
   > Merging 
[#5889](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=desc) 
(3173e7f) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `14.66%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5889/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5889   +/-   ##
   =
   - Coverage 51.22%   36.55%   -14.67% 
   + Complexity 3497 2105 -1392 
   =
 Files  1661  741  -920 
 Lines 3565918697-16962 
 Branches   3910 1739 -2171 
   =
   - Hits  18266 6835-11431 
   + Misses1648511345 -5140 
   + Partials908  517  -391 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
   | 
[...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...server/storage/plugin/influxdb/base/RecordDAO.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL1JlY29yZERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
   | 
[...er/storage/plugin/influxdb/base/NoneStreamDAO.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5889: Support tracing data connection pool

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5889:
URL: https://github.com/apache/skywalking/pull/5889#issuecomment-733117624


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=h1) 
Report
   > Merging 
[#5889](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=desc) 
(3173e7f) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `19.86%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5889/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree)
   
   ```diff
   @@  Coverage Diff  @@
   ## master#5889   +/-   ##
   =
   - Coverage 51.22%   31.35%   -19.87% 
   + Complexity 3497 1819 -1678 
   =
 Files  1661  741  -920 
 Lines 3565918519-17140 
 Branches   3910 1706 -2204 
   =
   - Hits  18266 5807-12459 
   + Misses1648512308 -4177 
   + Partials908  404  -504 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5889?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ache/skywalking/oap/meter/analyzer/dsl/Sample.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZS5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...lking/oap/meter/analyzer/dsl/DownsamplingType.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0Rvd25zYW1wbGluZ1R5cGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...server/library/util/prometheus/metrics/Metric.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpYy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
   | 
[...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5889/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLm

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5835: Observing Istio control plane

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5835:
URL: https://github.com/apache/skywalking/pull/5835#issuecomment-726062733


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=h1) 
Report
   > Merging 
[#5835](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=desc) 
(45b7ae7) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `5.83%`.
   > The diff coverage is `48.61%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5835/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5835  +/-   ##
   
   - Coverage 51.22%   45.38%   -5.84% 
   + Complexity 3497 3045 -452 
   
 Files  1661  885 -776 
 Lines 3565922087   -13572 
 Branches   3910 2132-1778 
   
   - Hits  1826610025-8241 
   + Misses1648511212-5273 
   + Partials908  850  -58 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5835?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...meter/analyzer/dsl/ExpressionParsingException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nRXhjZXB0aW9uLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...e/skywalking/oap/server/receiver/otel/Handler.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVyLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../receiver/otel/HandlerInitializationException.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9IYW5kbGVySW5pdGlhbGl6YXRpb25FeGNlcHRpb24uamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...server/receiver/otel/OtelMetricReceiverConfig.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJDb25maWcuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...server/receiver/otel/OtelMetricReceiverModule.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJNb2R1bGUuamF2YQ==)
 | `66.66% <ø> (ø)` | `1.00 <0.00> (?)` | |
   | 
[...g/oap/server/receiver/otel/oc/OCMetricHandler.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9vYy9PQ01ldHJpY0hhbmRsZXIuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...storage/plugin/jdbc/h2/dao/H2MetadataQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0YWRhdGFRdWVyeURBTy5qYXZh)
 | `49.34% <0.00%> (ø)` | `12.00 <0.00> (ø)` | |
   | 
[...rver/receiver/otel/OtelMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL290ZWwtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvb3RlbC9PdGVsTWV0cmljUmVjZWl2ZXJQcm92aWRlci5qYXZh)
 | `16.66% <20.00%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[...king/oap/meter/analyzer/prometheus/rule/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5835/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9ydWxlL1J1bGVzLmphdmE=)
 | `58.33% <42.85%> (-8.34%)` | `3.00 <0.00> (ø)` | |
   | 
[.../skywalking/oap/meter/analyzer/dsl/Expression.java](https://codecov.io/gh/apache/skywalkin

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5887: Add the plugin for Apache CXF 3.x

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5887:
URL: https://github.com/apache/skywalking/pull/5887#issuecomment-732849272


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=h1) 
Report
   > Merging 
[#5887](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=desc) 
(55bbb86) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `5.35%`.
   > The diff coverage is `2.08%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5887/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5887  +/-   ##
   
   - Coverage 51.22%   45.87%   -5.36% 
   + Complexity 3497 3041 -456 
   
 Files  1661 1661  
 Lines 3565935697  +38 
 Branches   3910 3907   -3 
   
   - Hits  1826616375-1891 
   - Misses1648518407+1922 
   - Partials908  915   +7 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...v3/client/MessageSenderInterceptorInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vY3hmLTMueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9jeGYvdjMvY2xpZW50L01lc3NhZ2VTZW5kZXJJbnRlcmNlcHRvckludGVyY2VwdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...f/v3/server/AsyncInvokeConstructorInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vY3hmLTMueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9jeGYvdjMvc2VydmVyL0FzeW5jSW52b2tlQ29uc3RydWN0b3JJbnRlcmNlcHRvci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...in/cxf/v3/server/AsyncInvokeMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vY3hmLTMueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9jeGYvdjMvc2VydmVyL0FzeW5jSW52b2tlTWV0aG9kSW50ZXJjZXB0b3IuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.83% <100.00%> (+0.01%)` | `1.00 <0.00> (ø)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
   | 
[...erver/storage/plugin/elasticsearch/base/EsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Fc0RBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
   | 
[.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...storage/plugin/elasticsearch/base/RecordEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9SZWNvcmRFc0RBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...torage/plugin/elasticsearch/base/MetricsEsDAO.java](https://c

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5887: Add the plugin for Apache CXF 3.x

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5887:
URL: https://github.com/apache/skywalking/pull/5887#issuecomment-732849272


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=h1) 
Report
   > Merging 
[#5887](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=desc) 
(55bbb86) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `5.34%`.
   > The diff coverage is `2.08%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5887/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5887  +/-   ##
   
   - Coverage 51.22%   45.87%   -5.35% 
   + Complexity 3497 3041 -456 
   
 Files  1661 1661  
 Lines 3565935695  +36 
 Branches   3910 3905   -5 
   
   - Hits  1826616375-1891 
   - Misses1648518405+1920 
   - Partials908  915   +7 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...v3/client/MessageSenderInterceptorInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vY3hmLTMueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9jeGYvdjMvY2xpZW50L01lc3NhZ2VTZW5kZXJJbnRlcmNlcHRvckludGVyY2VwdG9yLmphdmE=)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...f/v3/server/AsyncInvokeConstructorInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vY3hmLTMueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9jeGYvdjMvc2VydmVyL0FzeW5jSW52b2tlQ29uc3RydWN0b3JJbnRlcmNlcHRvci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...in/cxf/v3/server/AsyncInvokeMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vY3hmLTMueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9jeGYvdjMvc2VydmVyL0FzeW5jSW52b2tlTWV0aG9kSW50ZXJjZXB0b3IuamF2YQ==)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.83% <100.00%> (+0.01%)` | `1.00 <0.00> (ø)` | |
   | 
[...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
   | 
[...erver/storage/plugin/elasticsearch/base/EsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Fc0RBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
   | 
[.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
   | 
[...storage/plugin/elasticsearch/base/RecordEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9SZWNvcmRFc0RBTy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | 
[...torage/plugin/elasticsearch/base/MetricsEsDAO.java](https://c

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5887: Add the plugin for Apache CXF 3.x

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5887:
URL: https://github.com/apache/skywalking/pull/5887#issuecomment-732849272


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=h1) 
Report
   > Merging 
[#5887](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=desc) 
(81fde26) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `0.43%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5887/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5887  +/-   ##
   
   - Coverage 51.22%   50.78%   -0.44% 
   + Complexity 3497 3408  -89 
   
 Files  1661  918 -743 
 Lines 3565922891   -12768 
 Branches   3910 2209-1701 
   
   - Hits  1826611626-6640 
   + Misses1648510315-6170 
   - Partials908  950  +42 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.83% <100.00%> (+0.01%)` | `1.00 <0.00> (ø)` | |
   | 
[...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZX

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5887: Add the plugin for Apache CXF 3.x

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5887:
URL: https://github.com/apache/skywalking/pull/5887#issuecomment-732849272


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=h1) 
Report
   > Merging 
[#5887](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=desc) 
(81fde26) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `0.42%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5887/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5887  +/-   ##
   
   - Coverage 51.22%   50.80%   -0.43% 
   + Complexity 3497 3407  -90 
   
 Files  1661  918 -743 
 Lines 3565922883   -12776 
 Branches   3910 2194-1716 
   
   - Hits  1826611625-6641 
   + Misses1648510308-6177 
   - Partials908  950  +42 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.83% <100.00%> (+0.01%)` | `1.00 <0.00> (ø)` | |
   | 
[...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZX

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5887: Add the plugin for Apache CXF 3.x

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5887:
URL: https://github.com/apache/skywalking/pull/5887#issuecomment-732849272


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=h1) 
Report
   > Merging 
[#5887](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=desc) 
(81fde26) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `0.42%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5887/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5887  +/-   ##
   
   - Coverage 51.22%   50.80%   -0.43% 
   + Complexity 3497 3407  -90 
   
 Files  1661  918 -743 
 Lines 3565922883   -12776 
 Branches   3910 2194-1716 
   
   - Hits  1826611625-6641 
   + Misses1648510308-6177 
   - Partials908  950  +42 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.83% <100.00%> (+0.01%)` | `1.00 <0.00> (ø)` | |
   | 
[...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZX

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5887: Add the plugin for Apache CXF 3.x

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5887:
URL: https://github.com/apache/skywalking/pull/5887#issuecomment-732849272


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=h1) 
Report
   > Merging 
[#5887](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=desc) 
(81fde26) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `0.42%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5887/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5887  +/-   ##
   
   - Coverage 51.22%   50.80%   -0.43% 
   + Complexity 3497 3407  -90 
   
 Files  1661  918 -743 
 Lines 3565922883   -12776 
 Branches   3910 2194-1716 
   
   - Hits  1826611625-6641 
   + Misses1648510308-6177 
   - Partials908  950  +42 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.83% <100.00%> (+0.01%)` | `1.00 <0.00> (ø)` | |
   | 
[...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZX

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5887: Add the plugin for Apache CXF 3.x

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5887:
URL: https://github.com/apache/skywalking/pull/5887#issuecomment-732849272


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=h1) 
Report
   > Merging 
[#5887](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=desc) 
(81fde26) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `0.42%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5887/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5887  +/-   ##
   
   - Coverage 51.22%   50.80%   -0.43% 
   + Complexity 3497 3407  -90 
   
 Files  1661  918 -743 
 Lines 3565922883   -12776 
 Branches   3910 2194-1716 
   
   - Hits  1826611625-6641 
   + Misses1648510308-6177 
   - Partials908  950  +42 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.83% <100.00%> (+0.01%)` | `1.00 <0.00> (ø)` | |
   | 
[...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZX

[skywalking-website] branch test updated: D

2020-11-24 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository.

kezhenxu94 pushed a commit to branch test
in repository https://gitbox.apache.org/repos/asf/skywalking-website.git


The following commit(s) were added to refs/heads/test by this push:
 new 51ec8a4  D
51ec8a4 is described below

commit 51ec8a4dc148889193860267ff57e5fdd0101507
Author: kezhenxu94 
AuthorDate: Wed Nov 25 12:54:00 2020 +0800

D
---
 content/_index.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/content/_index.html b/content/_index.html
index ca543b5..fceee59 100644
--- a/content/_index.html
+++ b/content/_index.html
@@ -43,7 +43,7 @@ linkTitle = "Apache SkyWalking"
 Tracing 
 Metrics
 Logging
-Browser monitoring Test test
+Browser monitoring Test
 
 
 



[skywalking-website] branch test updated: D

2020-11-24 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository.

kezhenxu94 pushed a commit to branch test
in repository https://gitbox.apache.org/repos/asf/skywalking-website.git


The following commit(s) were added to refs/heads/test by this push:
 new 6bce636  D
6bce636 is described below

commit 6bce636ea60bec6214aee09b9b8674c5c291bc8f
Author: kezhenxu94 
AuthorDate: Wed Nov 25 12:51:21 2020 +0800

D
---
 .github/workflows/deploy.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/deploy.yaml b/.github/workflows/deploy.yaml
index e27bb75..d793479 100644
--- a/.github/workflows/deploy.yaml
+++ b/.github/workflows/deploy.yaml
@@ -35,7 +35,7 @@ jobs:
   - name: Install
 run: |
   wget 
https://github.com/gohugoio/hugo/releases/download/v0.78.2/hugo_extended_0.78.2_Linux-64bit.tar.gz
-  tar xvf hugo_extended_0.74.3_Linux-64bit.tar.gz
+  tar xvf hugo_extended_0.78.2_Linux-64bit.tar.gz
   sudo mv hugo /usr/bin/
   npm install -D --save postcss-cli
   npm install -D --save autoprefixer



[skywalking-website] branch test updated: D

2020-11-24 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository.

kezhenxu94 pushed a commit to branch test
in repository https://gitbox.apache.org/repos/asf/skywalking-website.git


The following commit(s) were added to refs/heads/test by this push:
 new dd43b48  D
dd43b48 is described below

commit dd43b48336e20313c5ab9b3c79a1180d31353830
Author: kezhenxu94 
AuthorDate: Wed Nov 25 12:49:46 2020 +0800

D
---
 .github/workflows/deploy.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/deploy.yaml b/.github/workflows/deploy.yaml
index 78a3a9d..e27bb75 100644
--- a/.github/workflows/deploy.yaml
+++ b/.github/workflows/deploy.yaml
@@ -34,7 +34,7 @@ jobs:
 
   - name: Install
 run: |
-  wget 
https://github.com/gohugoio/hugo/releases/download/v0.74.3/hugo_extended_0.74.3_Linux-64bit.tar.gz
+  wget 
https://github.com/gohugoio/hugo/releases/download/v0.78.2/hugo_extended_0.78.2_Linux-64bit.tar.gz
   tar xvf hugo_extended_0.74.3_Linux-64bit.tar.gz
   sudo mv hugo /usr/bin/
   npm install -D --save postcss-cli



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5887: Add the plugin for Apache CXF 3.x

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5887:
URL: https://github.com/apache/skywalking/pull/5887#issuecomment-732849272


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=h1) 
Report
   > Merging 
[#5887](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=desc) 
(81fde26) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `0.42%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5887/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5887  +/-   ##
   
   - Coverage 51.22%   50.80%   -0.43% 
   + Complexity 3497 3407  -90 
   
 Files  1661  918 -743 
 Lines 3565922883   -12776 
 Branches   3910 2194-1716 
   
   - Hits  1826611625-6641 
   + Misses1648510308-6177 
   - Partials908  950  +42 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.83% <100.00%> (+0.01%)` | `1.00 <0.00> (ø)` | |
   | 
[...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZX

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5887: Add the plugin for Apache CXF 3.x

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5887:
URL: https://github.com/apache/skywalking/pull/5887#issuecomment-732849272


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=h1) 
Report
   > Merging 
[#5887](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=desc) 
(81fde26) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `0.32%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5887/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5887  +/-   ##
   
   - Coverage 51.22%   50.89%   -0.33% 
   + Complexity 3497 3407  -90 
   
 Files  1661  916 -745 
 Lines 3565922841   -12818 
 Branches   3910 2190-1720 
   
   - Hits  1826611625-6641 
   + Misses1648510266-6219 
   - Partials908  950  +42 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.83% <100.00%> (+0.01%)` | `1.00 <0.00> (ø)` | |
   | 
[...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZX

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5887: Add the plugin for Apache CXF 3.x

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5887:
URL: https://github.com/apache/skywalking/pull/5887#issuecomment-732849272







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5887: Add the plugin for Apache CXF 3.x

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5887:
URL: https://github.com/apache/skywalking/pull/5887#issuecomment-732849272







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5887: Add the plugin for Apache CXF 3.x

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5887:
URL: https://github.com/apache/skywalking/pull/5887#issuecomment-732849272


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=h1) 
Report
   > Merging 
[#5887](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=desc) 
(81fde26) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `1.90%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5887/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5887  +/-   ##
   
   - Coverage 51.22%   49.31%   -1.91% 
   + Complexity 3497 3348 -149 
   
 Files  1661  916 -745 
 Lines 3565922831   -12828 
 Branches   3910 2189-1721 
   
   - Hits  1826611260-7006 
   + Misses1648510639-5846 
   - Partials908  932  +24 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.83% <100.00%> (+0.01%)` | `1.00 <0.00> (ø)` | |
   | 
[...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZX

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5887: Add the plugin for Apache CXF 3.x

2020-11-24 Thread GitBox


codecov[bot] edited a comment on pull request #5887:
URL: https://github.com/apache/skywalking/pull/5887#issuecomment-732849272


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=h1) 
Report
   > Merging 
[#5887](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=desc) 
(81fde26) into 
[master](https://codecov.io/gh/apache/skywalking/commit/ec24c039f151f79a82282182bd4106b908382160?el=desc)
 (ec24c03) will **decrease** coverage by `2.01%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/5887/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#5887  +/-   ##
   
   - Coverage 51.22%   49.20%   -2.02% 
   + Complexity 3497 3338 -159 
   
 Files  1661  916 -745 
 Lines 3565922831   -12828 
 Branches   3910 2189-1721 
   
   - Hits  1826611234-7032 
   + Misses1648510665-5820 
   - Partials908  932  +24 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/5887?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=)
 | `98.83% <100.00%> (+0.01%)` | `1.00 <0.00> (ø)` | |
   | 
[...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | 
[...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/5887/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZX

  1   2   3   4   5   >