[I] [Bug] spring-webflux and spring-webflux-webclient can not be traced in spring-webflux 6.x [skywalking]
CzyerChen opened a new issue, #11654: URL: https://github.com/apache/skywalking/issues/11654 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking Component Java Agent (apache/skywalking-java) ### What happened One project with spring-boot-starter-webflux, change `spring-webflux` dependency from `5.2.9.RELEASE` to `6.0.0`, spring-webflux/spring-webflux-webclient nodes lost ### What you expected to happen The spring-webflux/spring-webflux-webclient nodes should be traced with spring-webflux:6.0.x ### How to reproduce - run the test scenario in `/skywalking-java/test/plugin/scenarios/webflux-scenario` - `spring-webflux:5.2.9.RELEASE` spring-webflux/spring-webflux-webclient nodes traced - change `spring-webflux` version from `5.2.9.RELEASE` to `6.0.0`, spring-webflux/spring-webflux-webclient nodes lost ### Anything else _No response_ ### Are you willing to submit a pull request to fix on your own? - [X] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] SkyWalking Java Agent failed to work with Arthas in some cases [skywalking]
kylixs commented on issue #11651: URL: https://github.com/apache/skywalking/issues/11651#issuecomment-1855331287 OK, let me have a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix NoSuchMethodError in mvc-annotation-commons deprecated method [skywalking-java]
CzyerChen opened a new pull request, #658: URL: https://github.com/apache/skywalking-java/pull/658 ### Fix [NoSuchMethodError in mvc-annotation-commons deprecated method](https://github.com/apache/skywalking/issues/11652) - [x] Add a unit test to verify that the fix works. current test scenarios(spring-4.3.x-scenario, spring-6.x-scenario) passed. - [x] Explain briefly why the bug exists and how to fix it. - [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #11652. - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] After integrating Skywalking agent with Springcloud gateway 4, traceid cannot be printed [skywalking]
JustUse commented on issue #11398: URL: https://github.com/apache/skywalking/issues/11398#issuecomment-1855102602 > Gateway 4.x is not supported. No one supported a PR about this. when can skywalking-java-agent support gateway 4.x , do you have any plan? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] SkyWalking Java Agent failed to work with Arthas in some cases [skywalking]
xzyJavaX commented on issue #11651: URL: https://github.com/apache/skywalking/issues/11651#issuecomment-1855060292 @kylixs https://github.com/xzyJavaX/dynamic-redefine-test. With java agent 9.1.0 to start, then start Arthas. Then `watch redis.clients.jedis.Jedis get -x 1` `watch org.apache.kafka.clients.producer.KafkaProducer send -x 1` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking) branch docs deleted (was 12a3017fc5)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch docs in repository https://gitbox.apache.org/repos/asf/skywalking.git was 12a3017fc5 Polish docs structure. Move customization docs separately from the introduction docs. The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
(skywalking) branch master updated: Polish docs structure. Move customization docs separately from the introduction docs. (#11653)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 0e4c0333e0 Polish docs structure. Move customization docs separately from the introduction docs. (#11653) 0e4c0333e0 is described below commit 0e4c0333e0482eb1b5317fbadeaee400a05fa51f Author: 吴晟 Wu Sheng AuthorDate: Thu Dec 14 10:49:00 2023 +0800 Polish docs structure. Move customization docs separately from the introduction docs. (#11653) --- docs/en/changes/changes.md | 1 + docs/en/concepts-and-designs/backend-overview.md | 14 +++-- docs/en/concepts-and-designs/overview.md | 28 - docs/menu.yml| 39 +++- 4 files changed, 43 insertions(+), 39 deletions(-) diff --git a/docs/en/changes/changes.md b/docs/en/changes/changes.md index 1498f81d56..f0b7a8bf56 100644 --- a/docs/en/changes/changes.md +++ b/docs/en/changes/changes.md @@ -19,5 +19,6 @@ Documentation * Update the release doc to remove the announcement as the tests are through e2e rather than manually. * Update the release notification mail a little. +* Polish docs structure. Move customization docs separately from the introduction docs. All issues and pull requests are [here](https://github.com/apache/skywalking/milestone/202?closed=1) diff --git a/docs/en/concepts-and-designs/backend-overview.md b/docs/en/concepts-and-designs/backend-overview.md index f68d123884..f65783791d 100644 --- a/docs/en/concepts-and-designs/backend-overview.md +++ b/docs/en/concepts-and-designs/backend-overview.md @@ -1,17 +1,11 @@ # Observability Analysis Platform -SkyWalking is an Observability Analysis Platform that provides full observability to services running in both brown and green zones, as well as services using a hybrid model. +SkyWalking OAP and UI provides dozens of features to support observability analysis for your services, cloud infrastructure, open-source components, and more. -## Capabilities -SkyWalking covers all 3 areas of observability, including, **Tracing**, **Metrics** and **Logging**. - -- **Tracing**. SkyWalking native data formats, and Zipkin traces of v1 and v2 formats are supported. -- **Metrics**. SkyWalking supports mature metrics formats, including native meter format, OTEL metrics format, and Telegraf format. -SkyWalking integrates with Service Mesh platforms, typically Istio and Envoy, to build observability into the data plane -or control plane. Also, SkyWalking native agents can run in the metrics mode, which greatly improves performances. -- **Logging**. Includes logs collected from disk or through network. Native agents could bind the tracing context with logs automatically, -or use SkyWalking to bind the trace and log through the text content. +Besides those out-of-box features for monitoring, users could leverage the powerful and flexible analysis language to build their own analysis and visualization. There are 3 powerful and native language engines designed to analyze observability data from the above areas. 1. [Observability Analysis Language](oal.md) processes native traces and service mesh data. 1. [Meter Analysis Language](mal.md) is responsible for metrics calculation for native meter data, and adopts a stable and widely used metrics system, such as Prometheus and OpenTelemetry. 1. [Log Analysis Language](lal.md) focuses on log contents and collaborate with Meter Analysis Language. + +SkyWalking community is willing to accept your monitoring extension powered by these languages, if the monitoring is public and general usable. diff --git a/docs/en/concepts-and-designs/overview.md b/docs/en/concepts-and-designs/overview.md index 6b6f376b9a..6118bcccb9 100644 --- a/docs/en/concepts-and-designs/overview.md +++ b/docs/en/concepts-and-designs/overview.md @@ -3,15 +3,31 @@ SkyWalking is an open source observability platform used to collect, analyze, ag infrastructures. SkyWalking provides an easy way to maintain a clear view of your distributed systems, even across Clouds. It is a modern APM, specially designed for cloud native, container based distributed systems. +SkyWalking covers all the observability needs in Cloud Native world, including: +- **Tracing**. SkyWalking native data formats, and Zipkin traces of v1 and v2 formats are supported. +- **Metrics**. SkyWalking supports mature metrics formats, including native meter format, OTEL metrics format, and Telegraf format. + SkyWalking integrates with Service Mesh platforms, typically Istio and Envoy, to build observability into the data plane + or control plane. Also, SkyWalking native agents can run in the metrics mode, which greatly improves performances. +- **Logging**. Includes logs collected from disk or through network. Native agents could bind the
Re: [PR] Move customization docs separately from the introduction docs [skywalking]
wu-sheng merged PR #11653: URL: https://github.com/apache/skywalking/pull/11653 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Move customization docs separately from the introduction docs [skywalking]
wu-sheng opened a new pull request, #11653: URL: https://github.com/apache/skywalking/pull/11653 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). Polish docs structure. Move customization docs separately from the introduction docs. Nowadays, SkyWalking has nearly provided most of the commonly used middleware, only developers have an interest in learning our analysis scripts to extend and/or contribute. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking) branch docs created (now 12a3017fc5)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch docs in repository https://gitbox.apache.org/repos/asf/skywalking.git at 12a3017fc5 Polish docs structure. Move customization docs separately from the introduction docs. This branch includes the following new commits: new 12a3017fc5 Polish docs structure. Move customization docs separately from the introduction docs. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
(skywalking) 01/01: Polish docs structure. Move customization docs separately from the introduction docs.
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch docs in repository https://gitbox.apache.org/repos/asf/skywalking.git commit 12a3017fc53dd8609e656e6cb2c1d4d5b73212b7 Author: Wu Sheng AuthorDate: Thu Dec 14 10:42:50 2023 +0800 Polish docs structure. Move customization docs separately from the introduction docs. --- docs/en/changes/changes.md | 1 + docs/en/concepts-and-designs/backend-overview.md | 14 +++-- docs/en/concepts-and-designs/overview.md | 28 - docs/menu.yml| 39 +++- 4 files changed, 43 insertions(+), 39 deletions(-) diff --git a/docs/en/changes/changes.md b/docs/en/changes/changes.md index 1498f81d56..f0b7a8bf56 100644 --- a/docs/en/changes/changes.md +++ b/docs/en/changes/changes.md @@ -19,5 +19,6 @@ Documentation * Update the release doc to remove the announcement as the tests are through e2e rather than manually. * Update the release notification mail a little. +* Polish docs structure. Move customization docs separately from the introduction docs. All issues and pull requests are [here](https://github.com/apache/skywalking/milestone/202?closed=1) diff --git a/docs/en/concepts-and-designs/backend-overview.md b/docs/en/concepts-and-designs/backend-overview.md index f68d123884..f65783791d 100644 --- a/docs/en/concepts-and-designs/backend-overview.md +++ b/docs/en/concepts-and-designs/backend-overview.md @@ -1,17 +1,11 @@ # Observability Analysis Platform -SkyWalking is an Observability Analysis Platform that provides full observability to services running in both brown and green zones, as well as services using a hybrid model. +SkyWalking OAP and UI provides dozens of features to support observability analysis for your services, cloud infrastructure, open-source components, and more. -## Capabilities -SkyWalking covers all 3 areas of observability, including, **Tracing**, **Metrics** and **Logging**. - -- **Tracing**. SkyWalking native data formats, and Zipkin traces of v1 and v2 formats are supported. -- **Metrics**. SkyWalking supports mature metrics formats, including native meter format, OTEL metrics format, and Telegraf format. -SkyWalking integrates with Service Mesh platforms, typically Istio and Envoy, to build observability into the data plane -or control plane. Also, SkyWalking native agents can run in the metrics mode, which greatly improves performances. -- **Logging**. Includes logs collected from disk or through network. Native agents could bind the tracing context with logs automatically, -or use SkyWalking to bind the trace and log through the text content. +Besides those out-of-box features for monitoring, users could leverage the powerful and flexible analysis language to build their own analysis and visualization. There are 3 powerful and native language engines designed to analyze observability data from the above areas. 1. [Observability Analysis Language](oal.md) processes native traces and service mesh data. 1. [Meter Analysis Language](mal.md) is responsible for metrics calculation for native meter data, and adopts a stable and widely used metrics system, such as Prometheus and OpenTelemetry. 1. [Log Analysis Language](lal.md) focuses on log contents and collaborate with Meter Analysis Language. + +SkyWalking community is willing to accept your monitoring extension powered by these languages, if the monitoring is public and general usable. diff --git a/docs/en/concepts-and-designs/overview.md b/docs/en/concepts-and-designs/overview.md index 6b6f376b9a..6118bcccb9 100644 --- a/docs/en/concepts-and-designs/overview.md +++ b/docs/en/concepts-and-designs/overview.md @@ -3,15 +3,31 @@ SkyWalking is an open source observability platform used to collect, analyze, ag infrastructures. SkyWalking provides an easy way to maintain a clear view of your distributed systems, even across Clouds. It is a modern APM, specially designed for cloud native, container based distributed systems. +SkyWalking covers all the observability needs in Cloud Native world, including: +- **Tracing**. SkyWalking native data formats, and Zipkin traces of v1 and v2 formats are supported. +- **Metrics**. SkyWalking supports mature metrics formats, including native meter format, OTEL metrics format, and Telegraf format. + SkyWalking integrates with Service Mesh platforms, typically Istio and Envoy, to build observability into the data plane + or control plane. Also, SkyWalking native agents can run in the metrics mode, which greatly improves performances. +- **Logging**. Includes logs collected from disk or through network. Native agents could bind the tracing context with logs automatically, + or use SkyWalking to bind the trace and log through the text content. +- **Profiling**. Profiling is a powerful tool to help developers understand the performance of their applications
(skywalking-showcase) branch main updated: Update OAP and UI
This is an automated email from the ASF dual-hosted git repository. wankai pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-showcase.git The following commit(s) were added to refs/heads/main by this push: new 64a2d08 Update OAP and UI 64a2d08 is described below commit 64a2d080dec316af3375e6e012ba9018835a7a8e Author: Wan Kai AuthorDate: Thu Dec 14 10:12:49 2023 +0800 Update OAP and UI --- Makefile.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.in b/Makefile.in index 2310d3c..c2ef516 100644 --- a/Makefile.in +++ b/Makefile.in @@ -29,10 +29,10 @@ ES_IMAGE ?= docker.elastic.co/elasticsearch/elasticsearch-oss ES_IMAGE_TAG ?= 7.10.2 SW_OAP_IMAGE ?= ghcr.io/apache/skywalking/oap -SW_OAP_IMAGE_TAG ?= 33e3f28fcf13683895737ea5551af5b6a16df219 +SW_OAP_IMAGE_TAG ?= 8ff67d09e90712341c7889e0e6f4dc9506f4ad16 SW_UI_IMAGE ?= ghcr.io/apache/skywalking/ui -SW_UI_IMAGE_TAG ?= 33e3f28fcf13683895737ea5551af5b6a16df219 +SW_UI_IMAGE_TAG ?= 8ff67d09e90712341c7889e0e6f4dc9506f4ad16 SW_CLI_IMAGE ?= ghcr.io/apache/skywalking-cli/skywalking-cli:0883266bfaa36612927b69e35781b64ea181758d SW_EVENT_EXPORTER_IMAGE ?= ghcr.io/apache/skywalking-kubernetes-event-exporter/skywalking-kubernetes-event-exporter:8a012a3f968cb139f817189afb9b3748841bba22
Re: [I] [Bug] mvc-annotation-commons NoSuchMethodError ServerHttpRequest.getMethodValue() [skywalking]
wu-sheng commented on issue #11652: URL: https://github.com/apache/skywalking/issues/11652#issuecomment-1854983620 In the Spring 6, `getMethodValue` is deprecated but because `Deprecated as of Spring Framework 6.0 in favor of getMethod() and HttpMethod.name()`. You could try whether your solution works. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] mvc-annotation-commons NoSuchMethodError ServerHttpRequest.getMethodValue() [skywalking]
CzyerChen commented on issue #11652:
URL: https://github.com/apache/skywalking/issues/11652#issuecomment-1854959748
I have checked `gettMethod` && `getMethodValue` method called by
`org.springframework.http.server.reactive.ServerHttpRequest` in all
`spring-web`
versions（3.0.x/3.1.x/3.2.x/4.0.x/4.1.x/4.2.x/4.3.x/5.0.x/5.1.x/5.2.x/5.3.x/6.0.x/6.1.x），`getMethod`
exists all the time, but `getMethodValue` only in version 5.x & 6.0.x
Whether we can just change the method from `getMethodValue` to `getMehtod`
without a new interceptor?
3.0.x
```
/**
* Represents a server-side HTTP request.
*
* @author Arjen Poutsma
* @since 3.0
*/
public interface ServerHttpRequest extends HttpInputMessage {
/**
* Return the HTTP method of the request.
* @return the HTTP method as an HttpMethod enum value
*/
HttpMethod getMethod();
/**
* Return the URI of the request.
* @return the URI of the request
*/
URI getURI();
}
```
3.1.x/3.2.x
```
public interface ServerHttpRequest extends HttpRequest, HttpInputMessage {
}
/**
* Represents an HTTP request message, consisting of {@linkplain
#getMethod() method}
* and {@linkplain #getURI() uri}.
*
* @author Arjen Poutsma
* @since 3.1
*/
public interface HttpRequest extends HttpMessage {
/**
* Return the HTTP method of the request.
* @return the HTTP method as an HttpMethod enum value
*/
HttpMethod getMethod();
/**
* Return the URI of the request.
* @return the URI of the request
*/
URI getURI();
}
```
4.0.x/4.1.x/4.2.x/4.3.x
```
/**
* Represents a server-side HTTP request.
*
* @author Arjen Poutsma
* @author Rossen Stoyanchev
* @since 3.0
*/
public interface ServerHttpRequest extends HttpRequest, HttpInputMessage {
/**
* Return a {@link java.security.Principal} instance containing the
name of the
* authenticated user. If the user has not been authenticated, the
method returns
* null.
*/
Principal getPrincipal();
/**
* Return the address on which the request was received.
*/
InetSocketAddress getLocalAddress();
/**
* Return the address of the remote client.
*/
InetSocketAddress getRemoteAddress();
/**
* Return a control that allows putting the request in asynchronous
mode so the
* response remains open until closed explicitly from the current or
another thread.
*/
ServerHttpAsyncRequestControl getAsyncRequestControl(ServerHttpResponse
response);
}
/**
* Represents an HTTP request message, consisting of {@linkplain
#getMethod() method}
* and {@linkplain #getURI() uri}.
*
* @author Arjen Poutsma
* @since 3.1
*/
public interface HttpRequest extends HttpMessage {
/**
* Return the HTTP method of the request.
* @return the HTTP method as an HttpMethod enum value
*/
HttpMethod getMethod();
/**
* Return the URI of the request.
* @return the URI of the request
*/
URI getURI();
}
```
5.0.x/5.1.x/5.2.x/5.3.x
```
/**
* Represents a server-side HTTP request.
*
* @author Arjen Poutsma
* @author Rossen Stoyanchev
* @since 3.0
*/
public interface ServerHttpRequest extends HttpRequest, HttpInputMessage {
/**
* Return a {@link java.security.Principal} instance containing the
name of the
* authenticated user.
* If the user has not been authenticated, the method returns
null.
*/
@Nullable
Principal getPrincipal();
/**
* Return the address on which the request was received.
*/
InetSocketAddress getLocalAddress();
/**
* Return the address of the remote client.
*/
InetSocketAddress getRemoteAddress();
/**
* Return a control that allows putting the request in asynchronous
mode so the
* response remains open until closed explicitly from the current or
another thread.
*/
ServerHttpAsyncRequestControl getAsyncRequestControl(ServerHttpResponse
response);
}
/**
* Represents an HTTP request message, consisting of
* {@linkplain #getMethod() method} and {@linkplain #getURI() uri}.
*
* @author Arjen Poutsma
* @since 3.1
*/
public interface HttpRequest extends HttpMessage {
/**
* Return the HTTP method of the request.
* @return the HTTP method as an HttpMethod enum value, or {@code null}
* if not resolvable (e.g. in case of a
Re: [I] [Bug] Unhelpful error for misconfigured .licenserc.yaml file [skywalking]
kezhenxu94 commented on issue #11648: URL: https://github.com/apache/skywalking/issues/11648#issuecomment-1854094453 > Ah. I see. Sorry. I was trying to reduce a larger file to feed into something fairly unrelated -- I'm not trying to set up skywalking for use... > > That said, the thrust of this ticket is not about whether or not bsd-3-clause is supported, but that the error reporting isn't great when the tool can't find what the user has (poorly) asked it to find. > > When I went looking trying to find things, I found this directory which didn't have bsd-3-clause: > https://github.com/apache/skywalking-eyes/tree/main/assets/header-templates > > OTOH, apparently it is present in this directory: > https://github.com/apache/skywalking-eyes/tree/main/assets/lcs-templates > > But as the error message said header-templates/, it didn't occur to me to look in a directory named lcs-templates/, hence the request that the tool explain where it was looking and what/why it was looking for it. OK sounds reasonable to me. Let me reopen the issue and polish the error logs later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] Unhelpful error for misconfigured .licenserc.yaml file [skywalking]
jsoref commented on issue #11648: URL: https://github.com/apache/skywalking/issues/11648#issuecomment-1853969973 Ah. I see. Sorry. I was trying to reduce a larger file to feed into something fairly unrelated -- I'm not trying to set up skywalking for use... That said, the thrust of this ticket is not about whether or not bsd-3-clause is supported, but that the error reporting isn't great when the tool can't find what the user has (poorly) asked it to find. When I went looking trying to find things, I found this directory which didn't have bsd-3-clause: https://github.com/apache/skywalking-eyes/tree/main/assets/header-templates OTOH, apparently it is present in this directory: https://github.com/apache/skywalking-eyes/tree/main/assets/lcs-templates But as the error message said `header-templates/`, it didn't occur to me to look in a directory named `lcs-templates/`, hence the request that the tool explain where it was looking and what/why it was looking for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] Unhelpful error for unrecognized spdx-id [skywalking]
kezhenxu94 closed issue #11648: [Bug] Unhelpful error for unrecognized spdx-id URL: https://github.com/apache/skywalking/issues/11648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] Unhelpful error for unrecognized spdx-id [skywalking]
kezhenxu94 commented on issue #11648: URL: https://github.com/apache/skywalking/issues/11648#issuecomment-1853894054 `BSD-3-Clause` is supported, you wrote the configuration file wrong, it's `header/license/spdx-id`, not `header/spdx-id`, please read the doc carefully https://github.com/apache/skywalking-eyes/blob/ee81ff786927ea6ffa48b1e29c48e5289f4753aa/README.md?plain=1#L596-L600 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] SkyWalking Java Agent failed to work with Arthas in some cases [skywalking]
lujiajing1126 commented on issue #11651: URL: https://github.com/apache/skywalking/issues/11651#issuecomment-1853667666 cc @xzyJavaX would help prepare demos -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] SkyWalking Java Agent failed to work with Arthas in some cases [skywalking]
kylixs commented on issue #11651: URL: https://github.com/apache/skywalking/issues/11651#issuecomment-1853657652 @lujiajing1126 Can you provide a demo to reproduction problem? Better put it on github -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] mvc-annotation-commons NoSuchMethodError ServerHttpRequest.getMethodValue() [skywalking]
CzyerChen commented on issue #11652: URL: https://github.com/apache/skywalking/issues/11652#issuecomment-1853604628 > That works. And please make sure you add the new unsupported version into the test matrix. Got it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] mvc-annotation-commons NoSuchMethodError ServerHttpRequest.getMethodValue() [skywalking]
wu-sheng commented on issue #11652: URL: https://github.com/apache/skywalking/issues/11652#issuecomment-1853603911 That works. And please make sure you add the new unsupported version into the test matrix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] mvc-annotation-commons NoSuchMethodError ServerHttpRequest.getMethodValue() [skywalking]
CzyerChen commented on issue #11652: URL: https://github.com/apache/skywalking/issues/11652#issuecomment-1853602611 > Are you proposing a new interceptor for newer version? add the witnessmethod and add a new interceptor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] mvc-annotation-commons NoSuchMethodError ServerHttpRequest.getMethodValue() [skywalking]
wu-sheng commented on issue #11652: URL: https://github.com/apache/skywalking/issues/11652#issuecomment-1853591324 Are you proposing a new interceptor for newer version? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] mvc-annotation-commons NoSuchMethodError ServerHttpRequest.getMethodValue() [skywalking]
CzyerChen opened a new issue, #11652:
URL: https://github.com/apache/skywalking/issues/11652
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no
similar issues.
### Apache SkyWalking Component
Java Agent (apache/skywalking-java)
### What happened
Run a project with
- SpringBoot 3.2.0(released at 2023.11.03)
- apm-springmvc-annotation-commons-9.1.0.jar
- apm-springmvc-annotation-6.x-plugin-9.1.0.jar
can not trace SpringMVC node because of the error from java-agent logs
```
java.lang.NoSuchMethodError: 'java.lang.String
org.springframework.http.server.reactive.ServerHttpRequest.getMethodValue()'
at
org.apache.skywalking.apm.plugin.spring.mvc.commons.interceptor.AbstractMethodInterceptor.beforeMethod(AbstractMethodInterceptor.java:171)
at
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstMethodsInter.intercept(InstMethodsInter.java:76)
```
but works fine with SpringBoot previous version, like 3.1.0.
With the error and the source code, see that:
```
public interface HttpRequest extends HttpMessage {
..
@Deprecated(since = "6.0", forRemoval = true)
default String getMethodValue() {
return getMethod().name();
}
..
}
```
the method `getMethodValue` removed from SpringBoot 3.2.0
### What you expected to happen
SpringMVC node can be traced with SpringBoot 3.1.0, and can not traced with
SpringBoot 3.2.0.
We should fix the bug.
### How to reproduce
Run a normal SpingBoot project with
- SpringBoot 3.2.0(released at 2023.11.03)
- apm-springmvc-annotation-commons-9.1.0.jar
- apm-springmvc-annotation-6.x-plugin-9.1.0.jar
### Anything else
_No response_
### Are you willing to submit a pull request to fix on your own?
- [X] Yes I am willing to submit a pull request on my own!
### Code of Conduct
- [X] I agree to follow this project's [Code of
Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
notifications-unsubscr...@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] [Bug] SkyWalking Java Agent failed to work with Arthas in some cases [skywalking]
wu-sheng commented on issue #11651: URL: https://github.com/apache/skywalking/issues/11651#issuecomment-1853583829 Is this some issue of Arthas? As the new auxiliary class, it is not available for Arthas -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] SkyWalking Java Agent failed to work with Arthas in some cases [skywalking]
lujiajing1126 commented on issue #11651: URL: https://github.com/apache/skywalking/issues/11651#issuecomment-1853583378 @kylixs Any idea? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] SkyWalking Java Agent failed to work with Arthas in some cases [skywalking]
lujiajing1126 opened a new issue, #11651: URL: https://github.com/apache/skywalking/issues/11651 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking Component Java Agent (apache/skywalking-java) ### What happened When instrumented with SW Java Agent and then run "watch" with Arthas. Different errors reported for different classes, For example, with Java Agent 9.1.0, watching `redis.clients.jedis.Jedis` reported `UnsupportedOperationException`,  With both 9.1.0 and 9.0.0, watching `org.apache.kafka.clients.producer.KafkaProducer` reported `TypeNotPresentException`,  ### What you expected to happen No Error Happened ### How to reproduce You may use Jedis 3.1.0 to test the former case and use Kafka-clients 3.1.2 to reproduce the latter one. ### Anything else _No response_ ### Are you willing to submit a pull request to fix on your own? - [ ] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] The java-agent caused NATS to display '-ERR Unknown Protocol Operation' [skywalking]
wu-sheng closed issue #11649: [Bug] The java-agent caused NATS to display '-ERR Unknown Protocol Operation' URL: https://github.com/apache/skywalking/issues/11649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] The java-agent caused NATS to display '-ERR Unknown Protocol Operation' [skywalking]
fly2F opened a new issue, #11649: URL: https://github.com/apache/skywalking/issues/11649 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking Component Java Agent (apache/skywalking-java) ### What happened Injected the sw8-x Header into a Message in NATS JetStream, but did not adjust the message, resulting in an abnormal message ### What you expected to happen No Error ### How to reproduce Java-Agent Version: Nats Java SDK: 2.17.1 The Java Agent injected 'NATS/1.0' and 'sw8-x:0-1702370457015' into the NATS protocol Error Log: ``` [42965] 2023/12/12 16:40:57.016125 [TRC] 172.20.31.146:37992 - cid:4737 - ->> [-ERR Unknown Protocol Operation] > [Liys] Parser error: Client parser ERROR, state=41, i=75: proto='"/1.0\r\nsw8-x:0-1702370457015\r\n\r\n+"...' > [Liys] Parser buf: PUB $JS.ACK.P1.bill_durable.2.75010.172953.1702362603906068441.2023 4 NATS/1.0 sw8-x:0-1702370457015 +ACK > [Liys] Parser msgBuf (len(c.msgBuf) >= c.pa.size)(0, 4) || (i-c.as+1 >= c.pa.size)(75, 71, 4): [42965] 2023/12/12 16:40:57.016152 [ERR] 172.20.31.146:37992 - cid:4737 - Client parser ERROR, state=41, i=75: proto='"/1.0\r\nsw8-x:0-1702370457015\r\n\r\n+"...' [42965] 2023/12/12 16:40:57.016154 [DBG] 172.20.31.146:37992 - cid:4737 - Client connection closed: Protocol Violation ``` ### Anything else _No response_ ### Are you willing to submit a pull request to fix on your own? - [ ] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
