Re: [I] [Bug] ERROR [] - Table "events_20231218" not found; SQL statement: [skywalking]
56600535 commented on issue #11678: URL: https://github.com/apache/skywalking/issues/11678#issuecomment-1864015029 When I run `oapService.sh` and `webappService.sh` respectively, the system starts normally, but service displays normally in UI, but trace has no data. Log normal. param : -javaagent:D:\skywalking-agent.jar -Dskywalking.agent.service_name=staging -Dskywalking.collector.backend_service=192.168.110.59:11800  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking) branch swip-1 updated (cdd93834be -> 1c650cd013)
This is an automated email from the ASF dual-hosted git repository. wankai pushed a change to branch swip-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git from cdd93834be polish SWIP-1.md add 1c650cd013 make query return all service hierarchy, change data model name No new revisions were added by this update. Summary of changes: docs/en/swip/SWIP-1.md | 82 +++--- 1 file changed, 51 insertions(+), 31 deletions(-)
Re: [I] [Bug] ERROR [] - Table "events_20231218" not found; SQL statement: [skywalking]
wu-sheng commented on issue #11678: URL: https://github.com/apache/skywalking/issues/11678#issuecomment-1863912410 Make sure the clock of your VM is correct. If this is not from a cold down env back to work, most likely this is your timezone or time setup/sync issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] ERROR [] - Table "events_20231218" not found; SQL statement: [skywalking]
wu-sheng closed issue #11678: [Bug] ERROR [] - Table "events_20231218" not found; SQL statement: URL: https://github.com/apache/skywalking/issues/11678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] ERROR [] - Table "events_20231218" not found; SQL statement: [skywalking]
56600535 commented on issue #11678: URL: https://github.com/apache/skywalking/issues/11678#issuecomment-1863900200 > We didn't create tables for passed days, and don't expect data for that old being reported into the system. So, the error could show up. I will try again with a new environment, Check to see if there is a problem. JDK Version: 11.0.8 SkyWalking APM Version: 9.7.0 JAVA agent Version: 9.1.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb) branch main updated: Fix several vulnerabilities. (#359)
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git The following commit(s) were added to refs/heads/main by this push: new eca1e455 Fix several vulnerabilities. (#359) eca1e455 is described below commit eca1e4554c8fe60335cd7fb8f48183dc79fabf33 Author: Gao Hongtao AuthorDate: Wed Dec 20 13:36:59 2023 +0800 Fix several vulnerabilities. (#359) Signed-off-by: Gao Hongtao --- dist/LICENSE | 139 +++--- .../license-github.com-gorilla-websocket.txt | 39 +- dist/licenses/ui-licenses/license-axios.txt| 20 +- .../ui-licenses/license-proxy-from-env.txt | 20 + go.mod | 92 ++-- go.sum | 506 + ui/LICENSE | 47 +- ui/package-lock.json | 274 +-- ui/package.json| 2 +- 9 files changed, 431 insertions(+), 708 deletions(-) diff --git a/dist/LICENSE b/dist/LICENSE index eff2181e..8c336175 100644 --- a/dist/LICENSE +++ b/dist/LICENSE @@ -187,11 +187,11 @@ Apache-2.0 licenses github.com/envoyproxy/protoc-gen-validate v1.0.2 Apache-2.0 github.com/go-logr/logr v1.3.0 Apache-2.0 github.com/go-logr/stdr v1.2.2 Apache-2.0 -github.com/golang/glog v1.1.2 Apache-2.0 +github.com/golang/glog v1.2.0 Apache-2.0 github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da Apache-2.0 github.com/google/btree v1.1.2 Apache-2.0 github.com/google/flatbuffers v23.5.26+incompatible Apache-2.0 -github.com/google/pprof v0.0.0-20231101202521-4ca4178f5c7a Apache-2.0 +github.com/google/pprof v0.0.0-20231212022811-ec68065c825e Apache-2.0 github.com/grpc-ecosystem/go-grpc-middleware v1.4.0 Apache-2.0 github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus v1.0.0 Apache-2.0 github.com/grpc-ecosystem/go-grpc-middleware/v2 v2.0.1 Apache-2.0 @@ -209,33 +209,33 @@ Apache-2.0 licenses github.com/prometheus/common v0.45.0 Apache-2.0 github.com/prometheus/procfs v0.12.0 Apache-2.0 github.com/soheilhy/cmux v0.1.5 Apache-2.0 -github.com/spf13/afero v1.10.0 Apache-2.0 -github.com/spf13/cobra v1.7.0 Apache-2.0 -github.com/tklauser/numcpus v0.6.1 Apache-2.0 +github.com/spf13/afero v1.11.0 Apache-2.0 +github.com/spf13/cobra v1.8.0 Apache-2.0 +github.com/tklauser/numcpus v0.7.0 Apache-2.0 github.com/zinclabs/bluge v1.1.5 Apache-2.0 github.com/zinclabs/bluge_segment_api v1.0.0 Apache-2.0 github.com/zinclabs/ice v1.1.3 Apache-2.0 -go.etcd.io/etcd/api/v3 v3.5.10 Apache-2.0 -go.etcd.io/etcd/client/pkg/v3 v3.5.10 Apache-2.0 -go.etcd.io/etcd/client/v2 v2.305.10 Apache-2.0 -go.etcd.io/etcd/client/v3 v3.5.10 Apache-2.0 -go.etcd.io/etcd/pkg/v3 v3.5.10 Apache-2.0 -go.etcd.io/etcd/raft/v3 v3.5.10 Apache-2.0 -go.etcd.io/etcd/server/v3 v3.5.10 Apache-2.0 +go.etcd.io/etcd/api/v3 v3.5.11 Apache-2.0 +go.etcd.io/etcd/client/pkg/v3 v3.5.11 Apache-2.0 +go.etcd.io/etcd/client/v2 v2.305.11 Apache-2.0 +go.etcd.io/etcd/client/v3 v3.5.11 Apache-2.0 +go.etcd.io/etcd/pkg/v3 v3.5.11 Apache-2.0 +go.etcd.io/etcd/raft/v3 v3.5.11 Apache-2.0 +go.etcd.io/etcd/server/v3 v3.5.11 Apache-2.0 go.opencensus.io v0.24.0 Apache-2.0 - go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.45.0 Apache-2.0 -go.opentelemetry.io/otel v1.19.0 Apache-2.0 -go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.19.0 Apache-2.0 -go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.19.0 Apache-2.0 -go.opentelemetry.io/otel/metric v1.19.0 Apache-2.0 -go.opentelemetry.io/otel/sdk v1.19.0 Apache-2.0 -go.opentelemetry.io/otel/trace v1.19.0 Apache-2.0 + go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.46.1 Apache-2.0 +go.opentelemetry.io/otel v1.21.0 Apache-2.0 +go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.21.0 Apache-2.0 +go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.21.0 Apache-2.0 +go.opentelemetry.io/otel/metric v1.21.0 Apache-2.0 +go.opentelemetry.io/otel/sdk v1.21.0 Apache-2.0 +go.opentelemetry.io/otel/trace v1.21.0 Apache-2.0 go.opentelemetry.io/proto/otlp v1.0.0 Apache-2.0 go.uber.org/mock v0.3.0 Apache-2.0 -google.golang.org/genproto v0.0.0-20231030173426-d783a09b4405 Apache-2.0 -google.golang.org/genproto/googleapis/api v0.0.0-20231030173426-d783a09b4405 Apache-2.0 -google.golang.org/genproto/googleapis/rpc v0.0.0-20231030173426-d783a09b4405 Apache-2.0 -google.golang.org/grpc v1.59.0 Apache-2.0 +google.golang.org/genproto v0.0.0-20231212172506-995d672761c0 Apache-2.0 +
(skywalking-banyandb) branch cve deleted (was 932b5c71)
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch cve in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git was 932b5c71 Fix several vulnerabilities. The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] Fix several vulnerabilities. [skywalking-banyandb]
hanahmily merged PR #359: URL: https://github.com/apache/skywalking-banyandb/pull/359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix several vulnerabilities. [skywalking-banyandb]
codecov-commenter commented on PR #359: URL: https://github.com/apache/skywalking-banyandb/pull/359#issuecomment-1863883521 ## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/359?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`fe2eae7`)](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/fe2eae7b18115df28c0ede8a056ba09d53365ac3?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 42.30% compared to head [(`932b5c7`)](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/359?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 42.30%. Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #359 +/- ## === Coverage 42.30% 42.30% === Files 145 145 Lines 1622116221 === Hits 6863 6863 Misses 8719 8719 Partials 639 639 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/359?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] SkyWalking 不支持Ignite [skywalking]
wu-sheng commented on issue #11679: URL: https://github.com/apache/skywalking/issues/11679#issuecomment-1863881280 We don't declare we support Ignite. And also, we don't debug plugins because they are from hundreds of people globally. If there is a cast issue, try to debug on your own. Also, we don't support discussions in Chinese on Github. If you have troubles in English discussion, please choose Slack CN channel. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] SkyWalking 不支持Ignite [skywalking]
wu-sheng closed issue #11679: [Bug] SkyWalking 不支持Ignite URL: https://github.com/apache/skywalking/issues/11679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix several vulnerabilities. [skywalking-banyandb]
hanahmily opened a new pull request, #359: URL: https://github.com/apache/skywalking-banyandb/pull/359 To address security vulnerabilities, we need to update several dependencies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb) 01/01: Fix several vulnerabilities.
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch cve in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git commit 932b5c71571fa97653f626d8708a67cbeb2a2abe Author: Gao Hongtao AuthorDate: Wed Dec 20 05:06:04 2023 + Fix several vulnerabilities. Signed-off-by: Gao Hongtao --- dist/LICENSE | 139 +++--- .../license-github.com-gorilla-websocket.txt | 39 +- dist/licenses/ui-licenses/license-axios.txt| 20 +- .../ui-licenses/license-proxy-from-env.txt | 20 + go.mod | 92 ++-- go.sum | 506 + ui/LICENSE | 47 +- ui/package-lock.json | 274 +-- ui/package.json| 2 +- 9 files changed, 431 insertions(+), 708 deletions(-) diff --git a/dist/LICENSE b/dist/LICENSE index eff2181e..8c336175 100644 --- a/dist/LICENSE +++ b/dist/LICENSE @@ -187,11 +187,11 @@ Apache-2.0 licenses github.com/envoyproxy/protoc-gen-validate v1.0.2 Apache-2.0 github.com/go-logr/logr v1.3.0 Apache-2.0 github.com/go-logr/stdr v1.2.2 Apache-2.0 -github.com/golang/glog v1.1.2 Apache-2.0 +github.com/golang/glog v1.2.0 Apache-2.0 github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da Apache-2.0 github.com/google/btree v1.1.2 Apache-2.0 github.com/google/flatbuffers v23.5.26+incompatible Apache-2.0 -github.com/google/pprof v0.0.0-20231101202521-4ca4178f5c7a Apache-2.0 +github.com/google/pprof v0.0.0-20231212022811-ec68065c825e Apache-2.0 github.com/grpc-ecosystem/go-grpc-middleware v1.4.0 Apache-2.0 github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus v1.0.0 Apache-2.0 github.com/grpc-ecosystem/go-grpc-middleware/v2 v2.0.1 Apache-2.0 @@ -209,33 +209,33 @@ Apache-2.0 licenses github.com/prometheus/common v0.45.0 Apache-2.0 github.com/prometheus/procfs v0.12.0 Apache-2.0 github.com/soheilhy/cmux v0.1.5 Apache-2.0 -github.com/spf13/afero v1.10.0 Apache-2.0 -github.com/spf13/cobra v1.7.0 Apache-2.0 -github.com/tklauser/numcpus v0.6.1 Apache-2.0 +github.com/spf13/afero v1.11.0 Apache-2.0 +github.com/spf13/cobra v1.8.0 Apache-2.0 +github.com/tklauser/numcpus v0.7.0 Apache-2.0 github.com/zinclabs/bluge v1.1.5 Apache-2.0 github.com/zinclabs/bluge_segment_api v1.0.0 Apache-2.0 github.com/zinclabs/ice v1.1.3 Apache-2.0 -go.etcd.io/etcd/api/v3 v3.5.10 Apache-2.0 -go.etcd.io/etcd/client/pkg/v3 v3.5.10 Apache-2.0 -go.etcd.io/etcd/client/v2 v2.305.10 Apache-2.0 -go.etcd.io/etcd/client/v3 v3.5.10 Apache-2.0 -go.etcd.io/etcd/pkg/v3 v3.5.10 Apache-2.0 -go.etcd.io/etcd/raft/v3 v3.5.10 Apache-2.0 -go.etcd.io/etcd/server/v3 v3.5.10 Apache-2.0 +go.etcd.io/etcd/api/v3 v3.5.11 Apache-2.0 +go.etcd.io/etcd/client/pkg/v3 v3.5.11 Apache-2.0 +go.etcd.io/etcd/client/v2 v2.305.11 Apache-2.0 +go.etcd.io/etcd/client/v3 v3.5.11 Apache-2.0 +go.etcd.io/etcd/pkg/v3 v3.5.11 Apache-2.0 +go.etcd.io/etcd/raft/v3 v3.5.11 Apache-2.0 +go.etcd.io/etcd/server/v3 v3.5.11 Apache-2.0 go.opencensus.io v0.24.0 Apache-2.0 - go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.45.0 Apache-2.0 -go.opentelemetry.io/otel v1.19.0 Apache-2.0 -go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.19.0 Apache-2.0 -go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.19.0 Apache-2.0 -go.opentelemetry.io/otel/metric v1.19.0 Apache-2.0 -go.opentelemetry.io/otel/sdk v1.19.0 Apache-2.0 -go.opentelemetry.io/otel/trace v1.19.0 Apache-2.0 + go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.46.1 Apache-2.0 +go.opentelemetry.io/otel v1.21.0 Apache-2.0 +go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.21.0 Apache-2.0 +go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.21.0 Apache-2.0 +go.opentelemetry.io/otel/metric v1.21.0 Apache-2.0 +go.opentelemetry.io/otel/sdk v1.21.0 Apache-2.0 +go.opentelemetry.io/otel/trace v1.21.0 Apache-2.0 go.opentelemetry.io/proto/otlp v1.0.0 Apache-2.0 go.uber.org/mock v0.3.0 Apache-2.0 -google.golang.org/genproto v0.0.0-20231030173426-d783a09b4405 Apache-2.0 -google.golang.org/genproto/googleapis/api v0.0.0-20231030173426-d783a09b4405 Apache-2.0 -google.golang.org/genproto/googleapis/rpc v0.0.0-20231030173426-d783a09b4405 Apache-2.0 -google.golang.org/grpc v1.59.0 Apache-2.0 +google.golang.org/genproto v0.0.0-20231212172506-995d672761c0 Apache-2.0 +google.golang.org/genproto/googleapis/api v0.0.0-20231212172506-995d672761c0 Apache-2.0 +google.golang.org/genproto/googleapis/rpc v0.0.0-20231212172506-995d672761c0 Apache-2.0 +
(skywalking-banyandb) branch cve created (now 932b5c71)
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch cve in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git at 932b5c71 Fix several vulnerabilities. This branch includes the following new commits: new 932b5c71 Fix several vulnerabilities. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[I] [Bug] SkyWalking 不支持Ignite [skywalking]
god8816 opened a new issue, #11679: URL: https://github.com/apache/skywalking/issues/11679 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking Component OAP server (apache/skywalking) ### What happened 项目集成Ignite没有问题，然后发布到生产环境有skywalking。报错信息： Cause: java.sql.SQLException: class org.apache.ignite.IgniteCheckedException: org.apache.skywalking.apm.plugin.jdbc.trace.SWPreparedStatement cannot be cast to org.h2.jdbc.JdbcPreparedStatement ; class org.apache.ignite.IgniteCheckedException: org.apache.skywalking.apm.plugin.jdbc.trace.SWPreparedStatement cannot be cast to org.h2.jdbc.JdbcPreparedStatement; nested exception is java.sql.SQLException: class org.apache.ignite.IgniteCheckedException: org.apache.skywalking.apm.plugin.jdbc.trace.SWPreparedStatement cannot be cast to org.h2.jdbc.JdbcPreparedStatement at org.springframework.jdbc.support.SQLErrorCodeSQLExceptionTranslator.doTranslate(SQLErrorCodeSQLExceptionTranslator.java:259) at org.springframework.jdbc.support.AbstractFallbackSQLExceptionTranslator.translate(AbstractFallbackSQLExceptionTranslator.java:72) ### What you expected to happen skywalking不支持Ignite ### How to reproduce 工程集群ignite 使用jdbc模式在skywalking环境，即可出现问题 ### Anything else 没有 ### Are you willing to submit a pull request to fix on your own? - [X] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] ERROR [] - Table "events_20231218" not found; SQL statement: [skywalking]
wu-sheng commented on issue #11678: URL: https://github.com/apache/skywalking/issues/11678#issuecomment-1863835548 We didn't create tables for passed days, and don't expect data for that old being reported into the system. So, the error could show up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] ERROR [] - Table "events_20231218" not found; SQL statement: [skywalking]
wu-sheng commented on issue #11678: URL: https://github.com/apache/skywalking/issues/11678#issuecomment-1863834139 Then why do you insert data for 2 days ago? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] ERROR [] - Table "events_20231218" not found; SQL statement: [skywalking]
56600535 commented on issue #11678: URL: https://github.com/apache/skywalking/issues/11678#issuecomment-1863829409 > Are you using a new env? Or reboot from a cold env? new env -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] ERROR [] - Table "events_20231218" not found; SQL statement: [skywalking]
wu-sheng commented on issue #11678: URL: https://github.com/apache/skywalking/issues/11678#issuecomment-1863814982 Are you using a new env? Or reboot from a cold env? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] ERROR [] - Table "events_20231218" not found; SQL statement: [skywalking]
56600535 opened a new issue, #11678: URL: https://github.com/apache/skywalking/issues/11678 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking Component OAP server (apache/skywalking) ### What happened I started with the default configuration,The following exception occurs.Version 9.7.0 ``` 2023-12-19 16:20:49,387 - org.apache.skywalking.oap.server.storage.plugin.jdbc.common.dao.JDBCBatchDAO - 81 [pool-3-thread-2] ERROR [] - Table "events_20231218" not found; SQL statement: INSERT INTO events_20231218(id,table_name,uuid,service,service_instance,endpoint,name,type,message,parameters,start_time,end_time,layer,time_bucket) VALUES (?,?,?,?,?,?,?,?,?,?,?,?,?,?) [42102-212] org.h2.jdbc.JdbcSQLSyntaxErrorException: Table "events_20231218" not found; SQL statement: INSERT INTO events_20231218(id,table_name,uuid,service,service_instance,endpoint,name,type,message,parameters,start_time,end_time,layer,time_bucket) VALUES (?,?,?,?,?,?,?,?,?,?,?,?,?,?) [42102-212] at org.h2.message.DbException.getJdbcSQLException(DbException.java:502) ~[h2-2.1.212.jar:2.1.212] at org.h2.message.DbException.getJdbcSQLException(DbException.java:477) ~[h2-2.1.212.jar:2.1.212] at org.h2.message.DbException.get(DbException.java:223) ~[h2-2.1.212.jar:2.1.212] at org.h2.message.DbException.get(DbException.java:199) ~[h2-2.1.212.jar:2.1.212] at org.h2.command.Parser.getTableOrViewNotFoundDbException(Parser.java:8376) ~[h2-2.1.212.jar:2.1.212] at org.h2.command.Parser.getTableOrViewNotFoundDbException(Parser.java:8347) ~[h2-2.1.212.jar:2.1.212] at org.h2.command.Parser.readTableOrView(Parser.java:8336) ~[h2-2.1.212.jar:2.1.212] at org.h2.command.Parser.readTableOrView(Parser.java:8306) ~[h2-2.1.212.jar:2.1.212] at org.h2.command.Parser.parseInsert(Parser.java:1641) ~[h2-2.1.212.jar:2.1.212] at org.h2.command.Parser.parsePrepared(Parser.java:814) ~[h2-2.1.212.jar:2.1.212] at org.h2.command.Parser.parse(Parser.java:691) ~[h2-2.1.212.jar:2.1.212] at org.h2.command.Parser.parse(Parser.java:661) ~[h2-2.1.212.jar:2.1.212] at org.h2.command.Parser.prepareCommand(Parser.java:568) ~[h2-2.1.212.jar:2.1.212] at org.h2.engine.SessionLocal.prepareLocal(SessionLocal.java:631) ~[h2-2.1.212.jar:2.1.212] at org.h2.engine.SessionLocal.prepareCommand(SessionLocal.java:554) ~[h2-2.1.212.jar:2.1.212] at org.h2.jdbc.JdbcConnection.prepareCommand(JdbcConnection.java:1116) ~[h2-2.1.212.jar:2.1.212] at org.h2.jdbc.JdbcPreparedStatement.(JdbcPreparedStatement.java:92) ~[h2-2.1.212.jar:2.1.212] at org.h2.jdbc.JdbcConnection.prepareStatement(JdbcConnection.java:288) ~[h2-2.1.212.jar:2.1.212] at com.zaxxer.hikari.pool.ProxyConnection.prepareStatement(ProxyConnection.java:318) ~[HikariCP-3.1.0.jar:?] at com.zaxxer.hikari.pool.HikariProxyConnection.prepareStatement(HikariProxyConnection.java) ~[HikariCP-3.1.0.jar:?] at org.apache.skywalking.oap.server.storage.plugin.jdbc.BatchSQLExecutor.invoke(BatchSQLExecutor.java:54) ~[storage-jdbc-hikaricp-plugin-9.7.0.jar:9.7.0] at org.apache.skywalking.oap.server.storage.plugin.jdbc.common.dao.JDBCBatchDAO.lambda$flush$1(JDBCBatchDAO.java:78) ~[storage-jdbc-hikaricp-plugin-9.7.0.jar:9.7.0] at java.util.HashMap.forEach(HashMap.java:1337) ~[?:?] at org.apache.skywalking.oap.server.storage.plugin.jdbc.common.dao.JDBCBatchDAO.flush(JDBCBatchDAO.java:75) ~[storage-jdbc-hikaricp-plugin-9.7.0.jar:9.7.0] at org.apache.skywalking.oap.server.core.storage.PersistenceTimer.lambda$extractDataAndSave$3(PersistenceTimer.java:135) ~[server-core-9.7.0.jar:9.7.0] at java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1736) [?:?] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?] ``` ### What you expected to happen normal operation ### How to reproduce Version 9.7.0. run `bin\startup.sh`. ### Anything else _No response_ ### Are you willing to submit a pull request to fix on your own? - [ ] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:
(skywalking-banyandb) branch storage-column deleted (was 9e5e8891)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch storage-column in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git was 9e5e8891 Update CHANGES.md The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [I] [Feature] Implement Inverted Index for SeriesDatabase [skywalking]
wu-sheng closed issue #11496: [Feature] Implement Inverted Index for SeriesDatabase URL: https://github.com/apache/skywalking/issues/11496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Feature] Remove primary index [skywalking]
wu-sheng closed issue #11491: [Feature] Remove primary index URL: https://github.com/apache/skywalking/issues/11491 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Feature] Remove Block Level from TSDB [skywalking]
wu-sheng closed issue #11492: [Feature] Remove Block Level from TSDB URL: https://github.com/apache/skywalking/issues/11492 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Measure column-based storage and new TSDB [skywalking-banyandb]
wu-sheng merged PR #358: URL: https://github.com/apache/skywalking-banyandb/pull/358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Measure column-based storage and new TSDB [skywalking-banyandb]
hanahmily opened a new pull request, #358: URL: https://github.com/apache/skywalking-banyandb/pull/358 Related to apache/skywalking#11472 - [x] Tests(including UT, IT, E2E) are added to verify the new feature. - [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. - [x] Fixes apache/skywalking#11491. - [x] Fixes apache/skywalking#11496. - [x] Fixes apache/skywalking#11492. - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking-banyandb/blob/main/CHANGES.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-banyandb) 02/04: Fix linter issues
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch storage-column
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
commit 12c0466fc06abe4a8fdc7fa2c64b7be15adc6e70
Author: Gao Hongtao
AuthorDate: Tue Dec 19 11:47:24 2023 +
Fix linter issues
Signed-off-by: Gao Hongtao
---
api/common/id.go | 1 +
banyand/internal/storage/index.go | 7 +-
banyand/internal/storage/index_test.go | 8 +-
banyand/internal/storage/segment.go| 7 +-
banyand/internal/storage/storage.go| 8 +-
banyand/internal/storage/tsdb.go | 13 +-
banyand/measure/block.go | 147 +++--
banyand/measure/block_metadata.go | 12 --
banyand/measure/block_reader.go| 5 -
banyand/measure/block_test.go | 83 ++--
banyand/measure/block_writer.go| 106 +++
banyand/measure/column.go | 60 -
banyand/measure/column_metadata.go | 17 +++
banyand/measure/column_metadata_test.go| 17 +++
banyand/measure/column_test.go | 64 -
banyand/measure/measure.go | 6 -
banyand/measure/metadata.go| 13 +-
banyand/measure/part_iter.go | 7 +-
banyand/measure/part_iter_test.go | 21 +--
banyand/measure/part_test.go | 8 +-
banyand/measure/query.go | 29 ++--
banyand/measure/query_test.go | 27 ++--
banyand/measure/topn.go| 6 +-
banyand/measure/tstable.go | 13 +-
banyand/measure/tstable_test.go| 27 ++--
banyand/measure/write.go | 11 +-
banyand/queue/local.go | 2 +-
banyand/stream/stream_write.go | 1 -
pkg/bytes/buffer.go| 6 +
pkg/bytes/resize.go| 2 +
pkg/compress/zstd/zstd.go | 3 +
pkg/compress/zstd/zstd_test.go | 30 -
pkg/encoding/bytes.go | 12 +-
pkg/encoding/encoding.go | 2 +
pkg/encoding/int.go| 26
pkg/encoding/int_list.go | 4 +-
pkg/encoding/int_list_test.go | 4 +-
pkg/fs/file_system.go | 4 +
pkg/fs/local_file_system.go| 5 +-
pkg/index/index.go | 4 +
pkg/index/lsm/lsm.go | 2 +-
pkg/logger/suger.go| 11 ++
pkg/pb/v1/metadata.go | 36 -
pkg/pb/v1/series.go| 11 +-
pkg/pb/v1/value.go | 9 +-
pkg/query/logical/common.go| 2 +
pkg/query/logical/index_filter.go | 1 +
.../measure/measure_plan_indexscan_local.go| 2 +-
pkg/schema/schema.go | 1 +
49 files changed, 513 insertions(+), 390 deletions(-)
diff --git a/api/common/id.go b/api/common/id.go
index 5ef1a5b1..bac12211 100644
--- a/api/common/id.go
+++ b/api/common/id.go
@@ -45,6 +45,7 @@ func (s SeriesID) Marshal() []byte {
return convert.Uint64ToBytes(uint64(s))
}
+// AppendToBytes appends series id to bytes.
func (s SeriesID) AppendToBytes(dest []byte) []byte {
return encoding.Uint64ToBytes(dest, uint64(s))
}
diff --git a/banyand/internal/storage/index.go
b/banyand/internal/storage/index.go
index d44b172c..eaef4967 100644
--- a/banyand/internal/storage/index.go
+++ b/banyand/internal/storage/index.go
@@ -42,9 +42,8 @@ func (d *database[T]) Lookup(ctx context.Context, series
*pbv1.Series) (pbv1.Ser
}
type seriesIndex struct {
- storeindex.SeriesStore
- l*logger.Logger
- position common.Position
+ store index.SeriesStore
+ l *logger.Logger
}
func newSeriesIndex(ctx context.Context, root string) (*seriesIndex, error) {
@@ -67,7 +66,7 @@ func (s *seriesIndex) Write(docs index.Documents) error {
var rangeOpts = index.RangeOpts{}
-func (s *seriesIndex) searchPrimary(ctx context.Context, series *pbv1.Series)
(pbv1.SeriesList, error) {
+func (s *seriesIndex) searchPrimary(_ context.Context, series *pbv1.Series)
(pbv1.SeriesList, error) {
var hasAny, hasWildcard bool
var prefixIndex int
diff --git a/banyand/internal/storage/index_test.go
b/banyand/internal/storage/index_test.go
index ad435f07..f1fd0a42 100644
---
(skywalking-banyandb) 04/04: Update CHANGES.md
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch storage-column in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git commit 9e5e8891cc22389192506a5d7e51dc025d8c7179 Author: Gao Hongtao AuthorDate: Tue Dec 19 21:46:16 2023 + Update CHANGES.md Signed-off-by: Gao Hongtao --- CHANGES.md | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index c504fc6b..ad38d375 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -8,13 +8,17 @@ Release Notes. - Support etcd client authentication. - Implement Local file system. -- Add health check command for bydbctl +- Add health check command for bydbctl. +- Implement Inverted Index for SeriesDatabase. +- Remove Block Level from TSDB. +- Remove primary index. +- Measure column-based storage: + - Data ingestion and retrieval. ### Bugs - Fix the bug that property merge new tags failed. - ### Chores - Bump go to 1.21.
(skywalking-banyandb) branch storage-column updated (4dfc9662 -> 9e5e8891)
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a change to branch storage-column
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
from 4dfc9662 Fix e2e error
new 4a090421 Align fields of structs
new 12c0466f Fix linter issues
add 234fe3e2 Combine banyand and bydbctl Dockerfile (#356)
new 71fda92a Merge remote-tracking branch 'origin/main' into storage-column
new 9e5e8891 Update CHANGES.md
The 4 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.github/workflows/e2e.storage.yml | 2 +-
.github/workflows/publish-docker.yml | 2 +-
CHANGES.md | 9 +-
Makefile | 18 ++-
api/common/id.go | 1 +
banyand/Makefile | 1 -
banyand/internal/storage/index.go | 7 +-
banyand/internal/storage/index_test.go | 8 +-
banyand/internal/storage/segment.go| 19 ++-
banyand/internal/storage/storage.go| 8 +-
banyand/internal/storage/tsdb.go | 13 +-
banyand/measure/block.go | 159 ++-
banyand/measure/block_metadata.go | 28 +---
banyand/measure/block_metadata_test.go | 2 +-
banyand/measure/block_reader.go| 5 -
banyand/measure/block_test.go | 172 -
banyand/measure/block_writer.go| 148 --
banyand/measure/column.go | 60 +++
banyand/measure/column_metadata.go | 19 ++-
banyand/measure/column_metadata_test.go| 19 ++-
banyand/measure/column_test.go | 64
banyand/measure/datapoints.go | 2 +-
banyand/measure/measure.go | 6 -
banyand/measure/metadata.go| 13 +-
banyand/measure/part.go| 28 ++--
banyand/measure/part_iter.go | 29 ++--
banyand/measure/part_iter_test.go | 23 +--
banyand/measure/part_test.go | 110 +++--
banyand/measure/query.go | 35 ++---
banyand/measure/query_test.go | 32 ++--
banyand/measure/topn.go| 6 +-
banyand/measure/tstable.go | 24 ++-
banyand/measure/tstable_test.go| 131 +---
banyand/measure/write.go | 11 +-
banyand/queue/local.go | 2 +-
banyand/stream/stream_write.go | 1 -
bydbctl/Makefile | 3 -
bydbctl/internal/cmd/health_check.go | 8 +-
bydbctl/internal/cmd/health_check_test.go | 21 ++-
.dockerignore => docker/.dockerignore | 0
{banyand => docker}/Dockerfile | 6 +-
bydbctl/Dockerfile => docker/Makefile | 20 +--
pkg/bytes/buffer.go| 6 +
pkg/bytes/resize.go| 2 +
pkg/compress/zstd/zstd.go | 3 +
pkg/compress/zstd/zstd_test.go | 30 +++-
pkg/encoding/bytes.go | 12 +-
pkg/encoding/encoding.go | 2 +
pkg/encoding/int.go| 26
pkg/encoding/int_list.go | 4 +-
pkg/encoding/int_list_test.go | 4 +-
pkg/fs/file_system.go | 4 +
pkg/fs/local_file_system.go| 5 +-
pkg/index/index.go | 6 +-
pkg/index/lsm/lsm.go | 2 +-
pkg/logger/suger.go| 11 ++
pkg/pb/v1/metadata.go | 38 -
pkg/pb/v1/series.go| 11 +-
pkg/pb/v1/value.go | 9 +-
pkg/query/logical/common.go| 2 +
pkg/query/logical/index_filter.go | 1 +
.../measure/measure_plan_indexscan_local.go| 2 +-
pkg/schema/schema.go | 1 +
test/docker/base-compose.yml | 9 +-
test/stress/docker-compose.yaml| 3 +-
test/stress/env| 1 -
test/stress/env.dev| 1 -
67 files changed, 805 insertions(+), 665 deletions(-)
rename .dockerignore
(skywalking-banyandb) 01/04: Align fields of structs
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch storage-column
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
commit 4a090421ece5ca2e882b18d790b847a495972b12
Author: Gao Hongtao
AuthorDate: Tue Dec 19 05:59:20 2023 +
Align fields of structs
Signed-off-by: Gao Hongtao
---
banyand/internal/storage/segment.go | 16 ++--
banyand/measure/block.go| 18 ++---
banyand/measure/block_metadata.go | 16 ++--
banyand/measure/block_metadata_test.go | 2 +-
banyand/measure/block_test.go | 127 +++-
banyand/measure/block_writer.go | 42 ---
banyand/measure/column.go | 2 +-
banyand/measure/column_metadata.go | 2 +-
banyand/measure/column_metadata_test.go | 2 +-
banyand/measure/datapoints.go | 2 +-
banyand/measure/part.go | 28 +++
banyand/measure/part_iter.go| 24 ++
banyand/measure/part_iter_test.go | 4 +-
banyand/measure/part_test.go| 110 ++-
banyand/measure/query.go| 8 +-
banyand/measure/query_test.go | 5 +-
banyand/measure/tstable.go | 11 +--
banyand/measure/tstable_test.go | 112 +++-
pkg/index/index.go | 2 +-
pkg/pb/v1/metadata.go | 2 +-
20 files changed, 268 insertions(+), 267 deletions(-)
diff --git a/banyand/internal/storage/segment.go
b/banyand/internal/storage/segment.go
index e32425d2..d85557e2 100644
--- a/banyand/internal/storage/segment.go
+++ b/banyand/internal/storage/segment.go
@@ -38,16 +38,16 @@ var errEndOfSegment = errors.New("reached the end of the
segment")
type segment[T TSTable] struct {
bucket.Reporter
- tsTable T
+ tsTable T
+ l*logger.Logger
+ position common.Position
+ timestamp.TimeRange
+ path string
+ suffixstring
+ closeOnce sync.Once
refCount int32
mustBeDeleted uint32
- l *logger.Logger
- position common.Position
- timestamp.TimeRange
- path string
- suffixstring
- closeOnce sync.Once
- idSegID
+ idSegID
}
func openSegment[T TSTable](ctx context.Context, startTime, endTime time.Time,
path, suffix string,
diff --git a/banyand/measure/block.go b/banyand/measure/block.go
index 1730d022..b66f5c40 100644
--- a/banyand/measure/block.go
+++ b/banyand/measure/block.go
@@ -325,21 +325,17 @@ func releaseBlock(b *block) {
var blockPool sync.Pool
type blockCursor struct {
- idx int
-
- timestamps []int64
-
- tagFamilies []ColumnFamily
-
- fields ColumnFamily
-
- columnValuesDecoder encoding.BytesBlockDecoder
p *part
bm blockMetadata
- minTimestampint64
- maxTimestampint64
+ fields ColumnFamily
+ timestamps []int64
+ tagFamilies []ColumnFamily
+ columnValuesDecoder encoding.BytesBlockDecoder
tagProjection []pbv1.TagProjection
fieldProjection []string
+ idx int
+ minTimestampint64
+ maxTimestampint64
}
func (bc *blockCursor) reset() {
diff --git a/banyand/measure/block_metadata.go
b/banyand/measure/block_metadata.go
index 77afe66d..dff2b74f 100644
--- a/banyand/measure/block_metadata.go
+++ b/banyand/measure/block_metadata.go
@@ -65,17 +65,13 @@ func (h *dataBlock) unmarshal(src []byte) ([]byte, error) {
}
type blockMetadata struct {
- seriesID common.SeriesID
-
+ tagFamilies map[string]*dataBlock
+ field columnFamilyMetadata
+ tagProjection []pbv1.TagProjection
+ timestampstimestampsMetadata
+ seriesID common.SeriesID
uncompressedSizeBytes uint64
-
- count uint64
-
- timestamps timestampsMetadata
- field columnFamilyMetadata
- tagFamilies map[string]*dataBlock
-
- tagProjection []pbv1.TagProjection
+ count uint64
}
func (bh *blockMetadata) getTagFamilyMetadata(name string) *dataBlock {
diff --git a/banyand/measure/block_metadata_test.go
b/banyand/measure/block_metadata_test.go
index a3c4e1c8..81da440b 100644
--- a/banyand/measure/block_metadata_test.go
+++ b/banyand/measure/block_metadata_test.go
@@ -151,8 +151,8 @@ func Test_timestampsMetadata_marshal_unmarshal(t
*testing.T) {
func Test_blockMetadata_marshal_unmarshal(t *testing.T) {
testCases := []struct {
- name string
original *blockMetadata
+ name string
}{
{
name: "Zero
(skywalking-banyandb) 03/04: Merge remote-tracking branch 'origin/main' into storage-column
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch storage-column
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
commit 71fda92a8e7f08d00dcd9ff78ec64d2057f054e5
Merge: 12c0466f 234fe3e2
Author: Gao Hongtao
AuthorDate: Tue Dec 19 11:49:49 2023 +
Merge remote-tracking branch 'origin/main' into storage-column
.github/workflows/e2e.storage.yml | 2 +-
.github/workflows/publish-docker.yml | 2 +-
CHANGES.md| 1 +
Makefile | 18 +-
banyand/Makefile | 1 -
banyand/measure/block_test.go | 4 +++-
bydbctl/Makefile | 3 ---
bydbctl/internal/cmd/health_check.go | 8 +++-
bydbctl/internal/cmd/health_check_test.go | 21 +++--
.dockerignore => docker/.dockerignore | 0
{banyand => docker}/Dockerfile| 6 +-
bydbctl/Dockerfile => docker/Makefile | 20 ++--
test/docker/base-compose.yml | 9 +++--
test/stress/docker-compose.yaml | 3 +--
test/stress/env | 1 -
test/stress/env.dev | 1 -
16 files changed, 56 insertions(+), 44 deletions(-)
diff --cc banyand/measure/block_test.go
index f989b6db,..e7b776c1
mode 100644,00..100644
--- a/banyand/measure/block_test.go
+++ b/banyand/measure/block_test.go
@@@ -1,464 -1,0 +1,466 @@@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package measure
+
+import (
+ "crypto/rand"
+ "encoding/binary"
+ "reflect"
+ "testing"
+
+ "github.com/google/go-cmp/cmp"
+
+ "github.com/apache/skywalking-banyandb/api/common"
+ "github.com/apache/skywalking-banyandb/pkg/bytes"
+ "github.com/apache/skywalking-banyandb/pkg/convert"
+ "github.com/apache/skywalking-banyandb/pkg/encoding"
+ "github.com/apache/skywalking-banyandb/pkg/fs"
+ pbv1 "github.com/apache/skywalking-banyandb/pkg/pb/v1"
+)
+
+func Test_block_reset(t *testing.T) {
+ type fields struct {
+ timestamps []int64
+ tagFamilies []columnFamily
+ field columnFamily
+ }
+ tests := []struct {
+ name string
+ fields fields
+ want block
+ }{
+ {
+ name: "Test reset",
+ fields: fields{
+ timestamps: []int64{1, 2, 3},
+ tagFamilies: []columnFamily{{}, {}, {}},
+ field: columnFamily{columns: []column{{},
{}}},
+ },
+ want: block{
+ timestamps: []int64{},
+ tagFamilies: []columnFamily{},
+ field: columnFamily{columns: []column{}},
+ },
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ b := {
+ timestamps: tt.fields.timestamps,
+ tagFamilies: tt.fields.tagFamilies,
+ field: tt.fields.field,
+ }
+ b.reset()
+ if !reflect.DeepEqual(*b, tt.want) {
+ t.Errorf("block.reset() = %+v, want %+v", *b,
tt.want)
+ }
+ })
+ }
+}
+
+func toTagProjection(b block) map[string][]string {
+ result := make(map[string][]string, len(b.tagFamilies))
+ for i := range b.tagFamilies {
+ names := make([]string, len(b.tagFamilies[i].columns))
+ for i2 := range b.tagFamilies[i].columns {
+ names[i2] = b.tagFamilies[i].columns[i2].name
+ }
+ result[b.tagFamilies[i].name] = names
+ }
+ return result
+}
+
+var conventionalBlock = block{
+ timestamps:
Re: [PR] SWIP-1 Create and detect Service Hierarchy Relationship [skywalking]
wu-sheng commented on code in PR #11670:
URL: https://github.com/apache/skywalking/pull/11670#discussion_r1431448658
##
docs/en/swip/SWIP-1.md:
##
@@ -0,0 +1,160 @@
+# Motivation
+
+Service relationship is one of the most important parts of collaborating data
in the APM. Service Map is supported for
+years from tracing to trace analysis. But still due to the means of the probs,
a service could be detected from multiple
+methods, which is the same service in multiple
+layers. [v9 proposal](https://github.com/apache/skywalking/discussions/8241)
mentioned the concept of the layer.
+Through this proposal, we plan to establish a kernel-level concept to connect
services detected in different layers.
+
+# Architecture Graph
+
+There is no significant architecture-level change.
+
+# Propose Changes
+
+The data sources of SkyWalking APM have covered traditional agent installed
service, VMs, cloud infra, k8s, etc.
+
+For example, a Java service is built in a docker image and is going to be
deployed in a k8s cluster, with a sidecar
+injected due to service mesh managed. The following services would be able to
detect cross-layers
+
+1. Java service, detected as Java agent installed.
+2. A pod of k8s service is detected, due to k8s layer monitoring.
+3. Side car perspective service is detected.
+4. VM Linux monitoring for a general process, as the container of Java service
is deployed on this specific k8s node.
+5. Virtual databases, caches, and queues conjectured by agents, and also
monitored through k8s monitoring, even traffic
+ monitored by service mesh.
+
+All these services have logic connections or are identical from a physical
perspective, but currently, they may be just
+similar on name(s), no further metadata connection.
+
+By those, we have a chance to move one step ahead to connect the dots of the
whole infrastructure. This means, for the
+first time, we are going to establish the connections among services detected
from various layers.
+
+**In the v10, I am proposing a new concept `Service Hierarchy`.** Service
Hierarchy defines the relationships of
+existing services in various layers. With more kinds of agent tech
involved(such as eBPF) and deployment tools(such as
+operator and agent injector), we could inject relative service/instance
metadata and try to build the connections,
+including,
+
+- Agent injector injects the pod ID into the system env, then Java agent could
report the relationship through system
+ properties.
+- Rover(eBPF agent) reveals its next iteration forward k8s monitoring rather
than profiling. And add the capabilities to
+ establish connections among k8s pods and service mesh srv.
+
+Meanwhile, as usual with the new major version change, I would expect UI side
changes as well. UI should have flexible
+capabilities to show hierarchy services from the service view and topology
view. Also, we could consider a deeper view
+of the instance part as well.
+
+# Imported Dependencies libs and their licenses.
+
+No new library is planned to be added to the codebase.
+
+# Compatibility
+
+About the **protocol**, there should be no breaking changes, but enhancements
only. New query protocols(
+service-hierarchy and instance-hierarchy) are considered to be added, some new
fields should be added on things like
+topology query and instance dependencies to list relative services/instances
from other layers directly rather than an
+extra query.
+
+About the data structure, due to the new data concept is going to be created,
service hierarchy relative data models are
+going to be added. If the user is using Elasticsearch and BanyanDB, this
should be compatible, they just need to
+re-run `init-mode` OAP to extend the existing models. But for SQL database
users(MySQL, PostgreSQL), this could require
+new tables.
+
+## GraphQL query protocol
+New query protocol `hierarchy.graphqls` is going to be added.
+```graphql
+type HierarchyRelatedService {
+# The related service ID.
+id: ID!
+# The literal name of the #id.
+name: String!
+# The related service's Layer name.
+layer: String
+}
+
+type HierarchyRelatedInstance {
+# The related instance ID.
+id: ID!
+# The literal name of the #id. Instance Name.
+name: String!
+# The related instance service's Layer name.
+layer: String
+}
+
+type ServiceHierarchy {
+upper: [HierarchyRelatedService!]!
+lower: [HierarchyRelatedService!]!
+}
Review Comment:
Let's try a complete hierarchy for service. The number of services is
limited, one layer per time seems to cost too much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
(skywalking-go) branch main updated: Changing intercept point for gin, make sure interfaces could be grouped when params defined in relativePath (#156)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-go.git
The following commit(s) were added to refs/heads/main by this push:
new 613c25b Changing intercept point for gin, make sure interfaces could
be grouped when params defined in relativePath (#156)
613c25b is described below
commit 613c25b3539965a46b92f2c355d050d1b3c3d804
Author: dylanforest
AuthorDate: Tue Dec 19 21:53:52 2023 +0800
Changing intercept point for gin, make sure interfaces could be grouped
when params defined in relativePath (#156)
---
CHANGES.md | 1 +
plugins/gin/instrument.go | 5 ++---
plugins/gin/intercepter.go | 12 ++--
plugins/gin/intercepter_test.go | 17 -
4 files changed, 21 insertions(+), 14 deletions(-)
diff --git a/CHANGES.md b/CHANGES.md
index cd80127..f8f3ca2 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -9,6 +9,7 @@ Release Notes.
Plugins
* Support setting a discard type of reporter.
* Add `redis.max_args_bytes` parameter for redis plugin.
+* Changing intercept point for gin, make sure interfaces could be grouped when
params defined in relativePath.
Documentation
diff --git a/plugins/gin/instrument.go b/plugins/gin/instrument.go
index a764ed0..4921e86 100644
--- a/plugins/gin/instrument.go
+++ b/plugins/gin/instrument.go
@@ -51,9 +51,8 @@ func (i *Instrument) Points() []*instrument.Point {
return []*instrument.Point{
{
PackagePath: "",
- At: instrument.NewMethodEnhance("*Engine",
"handleHTTPRequest",
- instrument.WithArgsCount(1),
instrument.WithArgType(0, "*Context")),
- Interceptor: "HTTPInterceptor",
+ At: instrument.NewMethodEnhance("*Context",
"Next"),
+ Interceptor: "ContextInterceptor",
},
}
}
diff --git a/plugins/gin/intercepter.go b/plugins/gin/intercepter.go
index e1fed3b..653f305 100644
--- a/plugins/gin/intercepter.go
+++ b/plugins/gin/intercepter.go
@@ -26,13 +26,13 @@ import (
"github.com/apache/skywalking-go/plugins/core/tracing"
)
-type HTTPInterceptor struct {
+type ContextInterceptor struct {
}
-func (h *HTTPInterceptor) BeforeInvoke(invocation operator.Invocation) error {
- context := invocation.Args()[0].(*gin.Context)
+func (h *ContextInterceptor) BeforeInvoke(invocation operator.Invocation)
error {
+ context := invocation.CallerInstance().(*gin.Context)
s, err := tracing.CreateEntrySpan(
- fmt.Sprintf("%s:%s", context.Request.Method,
context.Request.URL.Path), func(headerKey string) (string, error) {
+ fmt.Sprintf("%s:%s", context.Request.Method,
context.FullPath()), func(headerKey string) (string, error) {
return context.Request.Header.Get(headerKey), nil
},
tracing.WithLayer(tracing.SpanLayerHTTP),
@@ -46,11 +46,11 @@ func (h *HTTPInterceptor) BeforeInvoke(invocation
operator.Invocation) error {
return nil
}
-func (h *HTTPInterceptor) AfterInvoke(invocation operator.Invocation, result
...interface{}) error {
+func (h *ContextInterceptor) AfterInvoke(invocation operator.Invocation,
result ...interface{}) error {
if invocation.GetContext() == nil {
return nil
}
- context := invocation.Args()[0].(*gin.Context)
+ context := invocation.CallerInstance().(*gin.Context)
span := invocation.GetContext().(tracing.Span)
span.Tag(tracing.TagStatusCode, fmt.Sprintf("%d",
context.Writer.Status()))
if len(context.Errors) > 0 {
diff --git a/plugins/gin/intercepter_test.go b/plugins/gin/intercepter_test.go
index 7b530f2..f50dd11 100644
--- a/plugins/gin/intercepter_test.go
+++ b/plugins/gin/intercepter_test.go
@@ -19,8 +19,10 @@ package gin
import (
"net/http"
+ "reflect"
"testing"
"time"
+ "unsafe"
"github.com/apache/skywalking-go/plugins/core"
"github.com/apache/skywalking-go/plugins/core/operator"
@@ -36,13 +38,18 @@ func init() {
func TestInvoke(t *testing.T) {
defer core.ResetTracingContext()
- interceptor := {}
- request, err := http.NewRequest("GET", "http://localhost/;, http.NoBody)
+ interceptor := {}
+ request, err := http.NewRequest("GET",
"http://localhost/skywalking/trace/f4dd2255-e3be-4636-b2e7-fc1d407a30d3;,
http.NoBody)
assert.Nil(t, err, "new request error should be nil")
- invocation := operator.NewInvocation(nil, {
+ c := {
Request: request,
Writer: {},
- })
+ }
+
+ fullPath := reflect.ValueOf(c).Elem().FieldByName("fullPath")
+ reflect.NewAt(fullPath.Type(),
Re: [PR] Changing intercept point for gin, make sure interfaces could be group… [skywalking-go]
wu-sheng commented on PR #156: URL: https://github.com/apache/skywalking-go/pull/156#issuecomment-1862801093 > Any news? We had fixed this, and now this is able to merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Changing intercept point for gin, make sure interfaces could be group… [skywalking-go]
wu-sheng merged PR #156: URL: https://github.com/apache/skywalking-go/pull/156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(skywalking-go) branch main updated: Fix macOS CI Testing (#157)
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-go.git The following commit(s) were added to refs/heads/main by this push: new 974c257 Fix macOS CI Testing (#157) 974c257 is described below commit 974c25710bf5b6f89a53c7e712e82a0ce46d4641 Author: mrproliu <741550...@qq.com> AuthorDate: Tue Dec 19 20:33:26 2023 +0800 Fix macOS CI Testing (#157) --- .github/workflows/plugin-tests.yaml | 8 1 file changed, 8 insertions(+) diff --git a/.github/workflows/plugin-tests.yaml b/.github/workflows/plugin-tests.yaml index c731722..bc920f3 100644 --- a/.github/workflows/plugin-tests.yaml +++ b/.github/workflows/plugin-tests.yaml @@ -39,6 +39,10 @@ jobs: go-version: 1.18 - name: Setup docker (missing on MacOS) if: runner.os == 'macos' +env: + HOMEBREW_NO_AUTO_UPDATE: "1" + HOMEBREW_NO_INSTALL_UPGRADE: "1" + HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK: "1" run: | brew install docker brew install colima @@ -135,6 +139,10 @@ jobs: go-version: 1.18 - name: Setup docker (missing on MacOS) if: runner.os == 'macos' +env: + HOMEBREW_NO_AUTO_UPDATE: "1" + HOMEBREW_NO_INSTALL_UPGRADE: "1" + HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK: "1" run: | brew install docker docker-compose brew install colima
Re: [PR] Fix macOS CI Testing [skywalking-go]
wu-sheng merged PR #157: URL: https://github.com/apache/skywalking-go/pull/157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Support for tracing spring-cloud-gateway 4.x in gateway-4.x-plugin [skywalking-java]
CzyerChen opened a new pull request, #661: URL: https://github.com/apache/skywalking-java/pull/661 ### Add support for spring-cloud-gateway 4.x - [x] Add a unit test to verify that the fix works. - [x] Explain briefly why the bug exists and how to fix it. why: spring-cloud-starter-gateway 4.0.0 depends on spring-boot-starter-webflux 3.0.0 spring-boot-starter-webflux 3.0.0 depends on spring-webflux 6.0.2 spring-webflux-5.x plugin can not trace the request how: add support for spring-webflux-6.x diff from 5.x by witnessmethod upgrade spring-cloud-gateway to 4.x with spring-webflux-6.x diff from 3.x by witnessclass ### Add an agent plugin to support spring-cloud-gateway 4.x - [x] Add a test case for the new plugin, refer to [the doc](https://github.com/apache/skywalking-java/blob/main/docs/en/setup/service-agent/java-agent/Plugin-test.md) - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] skywalking agent [skywalking]
wu-sheng commented on issue #11675: URL: https://github.com/apache/skywalking/issues/11675#issuecomment-1862314209 follow https://github.com/apache/skywalking/issues/11651 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] skywalking agent [skywalking]
wu-sheng closed issue #11675: [Bug] skywalking agent URL: https://github.com/apache/skywalking/issues/11675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] skywalking agent [skywalking]
wu-sheng commented on issue #11675: URL: https://github.com/apache/skywalking/issues/11675#issuecomment-1862313280 duplicated reported. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] skywalking agent [skywalking]
wangkang4 opened a new issue, #11675: URL: https://github.com/apache/skywalking/issues/11675 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking Component Java Agent (apache/skywalking-java) ### What happened java agent version：9.0.0 arthas：3.7.1 The arthas retransform command is used to hot-load the class file. A retransform error message is displayed. java.lang.UnsupportedOperationException: class redefinition failed: attempted to change superclass or interfaces ### What you expected to happen The arthas hot-load class file function is not affected. ### How to reproduce  ### Anything else _No response_ ### Are you willing to submit a pull request to fix on your own? - [ ] Yes I am willing to submit a pull request on my own! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
